From c13a0a066cc9725af00572271e40b69dc76ff1a0 Mon Sep 17 00:00:00 2001 From: Chiachang Wang Date: Mon, 17 May 2021 16:57:15 +0800 Subject: [PATCH] Dump only NORMAL priority information if no priority assigned The legacy design of "dumpsys connectivity" will only dump information with NORMAL priority. It was updated to provide both NORMAL and HIGH priority information in order to support dump in bugreport. However, it will also affect the result using dumpsys connectivity. Update design to dump NORMAL priority only to align with legacy design. Bug: 188387185 Test: adb shell dumpsys connectivity Test: adb bugreport and check the result in bugreport Change-Id: I6825c5038e48e3060c0c3ad1512bd584ef6d10a7 --- service/src/com/android/server/ConnectivityService.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/service/src/com/android/server/ConnectivityService.java b/service/src/com/android/server/ConnectivityService.java index 085943a77b..e192c8fae2 100644 --- a/service/src/com/android/server/ConnectivityService.java +++ b/service/src/com/android/server/ConnectivityService.java @@ -1045,14 +1045,10 @@ public class ConnectivityService extends IConnectivityManager.Stub } else { // ConnectivityService publishes binder service using publishBinderService() with // no priority assigned will be treated as NORMAL priority. Dumpsys does not send - // "--dump-priority" arguments to the service. Thus, dump both NORMAL and HIGH to - // align the legacy design. + // "--dump-priority" arguments to the service. Thus, dump NORMAL only to align the + // legacy output for dumpsys connectivity. // TODO: Integrate into signal dump. dumpNormal(fd, pw, args); - pw.println(); - pw.println("DUMP OF SERVICE HIGH connectivity"); - pw.println(); - dumpHigh(fd, pw); } } }