From 210ab83b779e21a585295dc2f37e3f9e96eca9a0 Mon Sep 17 00:00:00 2001 From: Hugo Benichi Date: Tue, 26 Sep 2017 14:51:11 +0900 Subject: [PATCH] Fix NPE in NsdServiceTest Continuous test dashboards report that quit() can crash sometimes due to mThread being null. This patch adds a null guard in tearDown(). Bug: 32561414 Test: runtest frameworks-net Change-Id: If66fb47e31e77d25b4741a786f12eb78f0b9102e --- tests/net/java/com/android/server/NsdServiceTest.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/net/java/com/android/server/NsdServiceTest.java b/tests/net/java/com/android/server/NsdServiceTest.java index 2e49c98ca9..b88c784bed 100644 --- a/tests/net/java/com/android/server/NsdServiceTest.java +++ b/tests/net/java/com/android/server/NsdServiceTest.java @@ -77,7 +77,10 @@ public class NsdServiceTest { @After public void tearDown() throws Exception { - mThread.quit(); + if (mThread != null) { + mThread.quit(); + mThread = null; + } } @Test