From cbfd66262ea05e993c42a88818bc66527c286fb5 Mon Sep 17 00:00:00 2001 From: Ashish Sharma Date: Fri, 1 Nov 2013 14:57:30 -0700 Subject: [PATCH] Fix the race condition for b/11458382 Change-Id: I862da57a70283a2afd5d67751aec87fb808760d2 --- .../com/android/server/net/NetworkStatsService.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/services/java/com/android/server/net/NetworkStatsService.java b/services/java/com/android/server/net/NetworkStatsService.java index 5d6adc2268..271e9e9b22 100644 --- a/services/java/com/android/server/net/NetworkStatsService.java +++ b/services/java/com/android/server/net/NetworkStatsService.java @@ -464,21 +464,21 @@ public class NetworkStatsService extends INetworkStatsService.Stub { private NetworkStatsCollection mUidTagComplete; private NetworkStatsCollection getUidComplete() { - if (mUidComplete == null) { - synchronized (mStatsLock) { + synchronized (mStatsLock) { + if (mUidComplete == null) { mUidComplete = mUidRecorder.getOrLoadCompleteLocked(); } + return mUidComplete; } - return mUidComplete; } private NetworkStatsCollection getUidTagComplete() { - if (mUidTagComplete == null) { - synchronized (mStatsLock) { + synchronized (mStatsLock) { + if (mUidTagComplete == null) { mUidTagComplete = mUidTagRecorder.getOrLoadCompleteLocked(); } + return mUidTagComplete; } - return mUidTagComplete; } @Override