Merge "prevent nullptr dereference when calling unwanted" am: 03f03d7acf am: 07060e39fd
Original change: https://android-review.googlesource.com/c/platform/frameworks/opt/net/ethernet/+/1802269 Change-Id: Ica7a0ee1ae2d2c977fcc6caac3b53e157ff61281
This commit is contained in:
@@ -506,12 +506,15 @@ public class EthernetNetworkFactory extends NetworkFactory {
|
|||||||
mNetworkFactory.getProvider(), new EthernetNetworkAgent.Callbacks() {
|
mNetworkFactory.getProvider(), new EthernetNetworkAgent.Callbacks() {
|
||||||
@Override
|
@Override
|
||||||
public void onNetworkUnwanted() {
|
public void onNetworkUnwanted() {
|
||||||
|
// if mNetworkAgent is null, we have already called stop.
|
||||||
|
if (mNetworkAgent == null) return;
|
||||||
|
|
||||||
if (this == mNetworkAgent.getCallbacks()) {
|
if (this == mNetworkAgent.getCallbacks()) {
|
||||||
stop();
|
stop();
|
||||||
} else if (mNetworkAgent != null) {
|
} else {
|
||||||
Log.d(TAG, "Ignoring unwanted as we have a more modern " +
|
Log.d(TAG, "Ignoring unwanted as we have a more modern " +
|
||||||
"instance");
|
"instance");
|
||||||
} // Otherwise, we've already called stop.
|
}
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
mNetworkAgent.register();
|
mNetworkAgent.register();
|
||||||
|
|||||||
Reference in New Issue
Block a user