LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename setUidForeground to noteUidForeground

Browse Source 
This patch addresses API review about the naming of
NetworkStatsManager#setUidForeground and it would be
more appropriate to rename it to noteUidForeground.

Bug: 222291301
Test: atest FrameworksNetTests
Change-Id: I952762872850889609c9808aa6e3cdfc04317806
This commit is contained in:
Aaron Huang
2022-03-10 17:44:49 +08:00
parent 6342a7f58a
commit cdc5fe2b2b
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
framework-t/src/android/app/usage/NetworkStatsManager.java
View File

@@ -1061,9 +1061,9 @@ public class NetworkStatsManager {
@RequiresPermission(anyOf = { @RequiresPermission(anyOf = {
NetworkStack.PERMISSION_MAINLINE_NETWORK_STACK, NetworkStack.PERMISSION_MAINLINE_NETWORK_STACK,
android.Manifest.permission.NETWORK_STACK}) android.Manifest.permission.NETWORK_STACK})
public void setUidForeground(int uid, boolean uidForeground) { public void noteUidForeground(int uid, boolean uidForeground) {
try { try {
mService.setUidForeground(uid, uidForeground); mService.noteUidForeground(uid, uidForeground);
} catch (RemoteException e) { } catch (RemoteException e) {
throw e.rethrowFromSystemServer(); throw e.rethrowFromSystemServer();
} }

2
framework-t/src/android/net/INetworkStatsService.aidl
View File

@@ -91,7 +91,7 @@ interface INetworkStatsService {
in INetworkStatsProvider provider); in INetworkStatsProvider provider);
/** Mark given UID as being in foreground for stats purposes. */ /** Mark given UID as being in foreground for stats purposes. */
void setUidForeground(int uid, boolean uidForeground); void noteUidForeground(int uid, boolean uidForeground);
/** Advise persistence threshold; may be overridden internally. */ /** Advise persistence threshold; may be overridden internally. */
void advisePersistThreshold(long thresholdBytes); void advisePersistThreshold(long thresholdBytes);

2
service-t/src/com/android/server/net/NetworkStatsService.java
View File

@@ -1194,7 +1194,7 @@ public class NetworkStatsService extends INetworkStatsService.Stub {
} }
@VisibleForTesting @VisibleForTesting
public void setUidForeground(int uid, boolean uidForeground) { public void noteUidForeground(int uid, boolean uidForeground) {
PermissionUtils.enforceNetworkStackPermission(mContext); PermissionUtils.enforceNetworkStackPermission(mContext);
synchronized (mStatsLock) { synchronized (mStatsLock) {
final int set = uidForeground ? SET_FOREGROUND : SET_DEFAULT; final int set = uidForeground ? SET_FOREGROUND : SET_DEFAULT;