From 8f3a1b5091bffc8c49faa1c6e8631938f8fee85c Mon Sep 17 00:00:00 2001 From: Luke Huang Date: Tue, 16 Jun 2020 10:55:43 +0800 Subject: [PATCH 1/2] Update DnsPacket package name The package name needs to be updated as the class is moved into com.android.net.module.util. Bug: 149403767 Test: atest DnsResolverTest Change-Id: I908cb5f7bc6150e461748c8e34c92a19aa0206e4 --- tests/cts/net/src/android/net/cts/DnsResolverTest.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/cts/net/src/android/net/cts/DnsResolverTest.java b/tests/cts/net/src/android/net/cts/DnsResolverTest.java index 28753ffc41..e6f75c353b 100644 --- a/tests/cts/net/src/android/net/cts/DnsResolverTest.java +++ b/tests/cts/net/src/android/net/cts/DnsResolverTest.java @@ -30,7 +30,6 @@ import android.content.Context; import android.content.ContentResolver; import android.net.ConnectivityManager; import android.net.ConnectivityManager.NetworkCallback; -import android.net.DnsPacket; import android.net.DnsResolver; import android.net.LinkProperties; import android.net.Network; @@ -47,6 +46,8 @@ import android.system.ErrnoException; import android.test.AndroidTestCase; import android.util.Log; +import com.android.net.module.util.DnsPacket; + import java.net.Inet4Address; import java.net.Inet6Address; import java.net.InetAddress; From 7c9d2128de2b3b3457403c2ebd0d04abaa93c7d9 Mon Sep 17 00:00:00 2001 From: Cody Kesting Date: Mon, 8 Jun 2020 13:38:11 -0700 Subject: [PATCH 2/2] Only run ConnectivityDiagnosticsManagerTest as AppModeFull. This CL restricts ConnectivityDiagnosticsManagerTest to only being run as @AppModeFull. This is required, as Instant Apps are not allowed CHANGE_NETWORK_STATE (required for CM#requestNetwork) or MANAGE_TEST_NETWORKS (required for TestNetworkManager#setupTestNetwork) permissions - both of which are required for ConnectivityDiagnosticsManagerTest. Bug: 158431112 Test: atest android.net.cts.ConnectivityDiagnosticsManagerTest Change-Id: Id867b8dcaca758cfeb83009848e1099e900a0790 --- .../src/android/net/cts/ConnectivityDiagnosticsManagerTest.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/cts/net/src/android/net/cts/ConnectivityDiagnosticsManagerTest.java b/tests/cts/net/src/android/net/cts/ConnectivityDiagnosticsManagerTest.java index 0248f971dc..d17d8e53ae 100644 --- a/tests/cts/net/src/android/net/cts/ConnectivityDiagnosticsManagerTest.java +++ b/tests/cts/net/src/android/net/cts/ConnectivityDiagnosticsManagerTest.java @@ -57,6 +57,7 @@ import android.os.Build; import android.os.IBinder; import android.os.PersistableBundle; import android.os.Process; +import android.platform.test.annotations.AppModeFull; import android.util.Pair; import androidx.test.InstrumentationRegistry; @@ -74,6 +75,7 @@ import java.util.concurrent.Executor; @RunWith(DevSdkIgnoreRunner.class) @IgnoreUpTo(Build.VERSION_CODES.Q) // ConnectivityDiagnosticsManager did not exist in Q +@AppModeFull(reason = "CHANGE_NETWORK_STATE, MANAGE_TEST_NETWORKS not grantable to instant apps") public class ConnectivityDiagnosticsManagerTest { private static final int CALLBACK_TIMEOUT_MILLIS = 5000; private static final int NO_CALLBACK_INVOKED_TIMEOUT = 500;