From 586a6f200238e968e2ebb7a3bd94715b7cebd9e9 Mon Sep 17 00:00:00 2001 From: cken Date: Wed, 5 Dec 2018 20:32:30 +0900 Subject: [PATCH] Remove 'hasDns' parameter Netd use this parameter to determine which network it should use for DNS query when VPN is enabled. But it is no more reliable when we have seamless vpn handover, since the parameter does not make update to netd if we have DNS configuration change. Netd should call resolver API to get latest DNS information rather than this one. Bug: 116539103 Test: runtest frameworks-net passes Change-Id: I6491114ab6de0ff66322f1da69056e6f3c999b5a --- services/core/java/com/android/server/ConnectivityService.java | 1 - 1 file changed, 1 deletion(-) diff --git a/services/core/java/com/android/server/ConnectivityService.java b/services/core/java/com/android/server/ConnectivityService.java index bb3b9f72d5..286e6a1e42 100644 --- a/services/core/java/com/android/server/ConnectivityService.java +++ b/services/core/java/com/android/server/ConnectivityService.java @@ -5676,7 +5676,6 @@ public class ConnectivityService extends IConnectivityManager.Stub // This should never fail. Specifying an already in use NetID will cause failure. if (networkAgent.isVPN()) { mNMS.createVirtualNetwork(networkAgent.network.netId, - !networkAgent.linkProperties.getDnsServers().isEmpty(), (networkAgent.networkMisc == null || !networkAgent.networkMisc.allowBypass)); } else {