Wakeup packet events: addressing a few comments
This patch addresses a few post-submit comment for commits f562ac34a51dc and 60c9f63b66921. Bug: 34901696 Bug: 62179647 Test: runtest frameworks-net Change-Id: I4abec57e0c6bc869dc57b5eb54582dd977b64c30
This commit is contained in:
@@ -512,7 +512,7 @@ public class IpConnectivityEventBuilderTest {
|
|||||||
stats.nonApplicationWakeups = 1;
|
stats.nonApplicationWakeups = 1;
|
||||||
stats.rootWakeups = 2;
|
stats.rootWakeups = 2;
|
||||||
stats.systemWakeups = 3;
|
stats.systemWakeups = 3;
|
||||||
stats.unroutedWakeups = 3;
|
stats.noUidWakeups = 3;
|
||||||
|
|
||||||
IpConnectivityEvent got = IpConnectivityEventBuilder.toProto(stats);
|
IpConnectivityEvent got = IpConnectivityEventBuilder.toProto(stats);
|
||||||
String want = String.join("\n",
|
String want = String.join("\n",
|
||||||
@@ -526,11 +526,11 @@ public class IpConnectivityEventBuilderTest {
|
|||||||
" wakeup_stats <",
|
" wakeup_stats <",
|
||||||
" application_wakeups: 5",
|
" application_wakeups: 5",
|
||||||
" duration_sec: 0",
|
" duration_sec: 0",
|
||||||
|
" no_uid_wakeups: 3",
|
||||||
" non_application_wakeups: 1",
|
" non_application_wakeups: 1",
|
||||||
" root_wakeups: 2",
|
" root_wakeups: 2",
|
||||||
" system_wakeups: 3",
|
" system_wakeups: 3",
|
||||||
" total_wakeups: 14",
|
" total_wakeups: 14",
|
||||||
" unrouted_wakeups: 3",
|
|
||||||
" >",
|
" >",
|
||||||
">",
|
">",
|
||||||
"version: 2\n");
|
"version: 2\n");
|
||||||
|
|||||||
@@ -423,11 +423,11 @@ public class IpConnectivityMetricsTest {
|
|||||||
" wakeup_stats <",
|
" wakeup_stats <",
|
||||||
" application_wakeups: 2",
|
" application_wakeups: 2",
|
||||||
" duration_sec: 0",
|
" duration_sec: 0",
|
||||||
|
" no_uid_wakeups: 0",
|
||||||
" non_application_wakeups: 0",
|
" non_application_wakeups: 0",
|
||||||
" root_wakeups: 0",
|
" root_wakeups: 0",
|
||||||
" system_wakeups: 1",
|
" system_wakeups: 1",
|
||||||
" total_wakeups: 3",
|
" total_wakeups: 3",
|
||||||
" unrouted_wakeups: 0",
|
|
||||||
" >",
|
" >",
|
||||||
">",
|
">",
|
||||||
"events <",
|
"events <",
|
||||||
@@ -439,11 +439,11 @@ public class IpConnectivityMetricsTest {
|
|||||||
" wakeup_stats <",
|
" wakeup_stats <",
|
||||||
" application_wakeups: 1",
|
" application_wakeups: 1",
|
||||||
" duration_sec: 0",
|
" duration_sec: 0",
|
||||||
|
" no_uid_wakeups: 1",
|
||||||
" non_application_wakeups: 0",
|
" non_application_wakeups: 0",
|
||||||
" root_wakeups: 0",
|
" root_wakeups: 0",
|
||||||
" system_wakeups: 2",
|
" system_wakeups: 2",
|
||||||
" total_wakeups: 4",
|
" total_wakeups: 4",
|
||||||
" unrouted_wakeups: 1",
|
|
||||||
" >",
|
" >",
|
||||||
">",
|
">",
|
||||||
"version: 2\n");
|
"version: 2\n");
|
||||||
|
|||||||
@@ -163,11 +163,11 @@ public class NetdEventListenerServiceTest {
|
|||||||
" wakeup_stats <",
|
" wakeup_stats <",
|
||||||
" application_wakeups: 3",
|
" application_wakeups: 3",
|
||||||
" duration_sec: 0",
|
" duration_sec: 0",
|
||||||
|
" no_uid_wakeups: 0",
|
||||||
" non_application_wakeups: 0",
|
" non_application_wakeups: 0",
|
||||||
" root_wakeups: 0",
|
" root_wakeups: 0",
|
||||||
" system_wakeups: 2",
|
" system_wakeups: 2",
|
||||||
" total_wakeups: 5",
|
" total_wakeups: 5",
|
||||||
" unrouted_wakeups: 0",
|
|
||||||
" >",
|
" >",
|
||||||
">",
|
">",
|
||||||
"events <",
|
"events <",
|
||||||
@@ -179,11 +179,11 @@ public class NetdEventListenerServiceTest {
|
|||||||
" wakeup_stats <",
|
" wakeup_stats <",
|
||||||
" application_wakeups: 2",
|
" application_wakeups: 2",
|
||||||
" duration_sec: 0",
|
" duration_sec: 0",
|
||||||
|
" no_uid_wakeups: 2",
|
||||||
" non_application_wakeups: 1",
|
" non_application_wakeups: 1",
|
||||||
" root_wakeups: 2",
|
" root_wakeups: 2",
|
||||||
" system_wakeups: 3",
|
" system_wakeups: 3",
|
||||||
" total_wakeups: 10",
|
" total_wakeups: 10",
|
||||||
" unrouted_wakeups: 2",
|
|
||||||
" >",
|
" >",
|
||||||
">",
|
">",
|
||||||
"version: 2\n");
|
"version: 2\n");
|
||||||
|
|||||||
Reference in New Issue
Block a user