From d8e40b3204127d7d321cd7fb0ef06f19137492ef Mon Sep 17 00:00:00 2001 From: Anton Hansson Date: Wed, 25 Oct 2023 15:39:26 +0000 Subject: [PATCH] Baseline issues that were previously suppressed java_sdk_library has previously internally disabled a few legitimate issues. As this is being un-done for modules, add baselines for the pre-existing issues. Bug: 306806877 Test: m checkapi Merged-In: Ie764d33196675e1482f30ecfd3d6d22b7fa25c27 Change-Id: Ie764d33196675e1482f30ecfd3d6d22b7fa25c27 --- .../common/TetheringLib/api/lint-baseline.txt | 0 .../api/module-lib-lint-baseline.txt | 23 +++++++++++++ .../TetheringLib/api/system-lint-baseline.txt | 17 ++++++++++ framework-t/api/module-lib-lint-baseline.txt | 14 ++++++++ framework-t/api/system-lint-baseline.txt | 12 +++++++ framework/api/lint-baseline.txt | 17 +++++++++- framework/api/module-lib-lint-baseline.txt | 33 +++++++++++++++++++ framework/api/system-lint-baseline.txt | 28 ++++++++++++++++ 8 files changed, 143 insertions(+), 1 deletion(-) create mode 100644 Tethering/common/TetheringLib/api/lint-baseline.txt create mode 100644 Tethering/common/TetheringLib/api/module-lib-lint-baseline.txt create mode 100644 Tethering/common/TetheringLib/api/system-lint-baseline.txt create mode 100644 framework/api/module-lib-lint-baseline.txt diff --git a/Tethering/common/TetheringLib/api/lint-baseline.txt b/Tethering/common/TetheringLib/api/lint-baseline.txt new file mode 100644 index 0000000000..e69de29bb2 diff --git a/Tethering/common/TetheringLib/api/module-lib-lint-baseline.txt b/Tethering/common/TetheringLib/api/module-lib-lint-baseline.txt new file mode 100644 index 0000000000..1d095989c4 --- /dev/null +++ b/Tethering/common/TetheringLib/api/module-lib-lint-baseline.txt @@ -0,0 +1,23 @@ +// Baseline format: 1.0 +BroadcastBehavior: android.net.TetheringManager#ACTION_TETHER_STATE_CHANGED: + Field 'ACTION_TETHER_STATE_CHANGED' is missing @BroadcastBehavior + + +RequiresPermission: android.net.TetheringManager#requestLatestTetheringEntitlementResult(int, boolean, java.util.concurrent.Executor, android.net.TetheringManager.OnTetheringEntitlementResultListener): + Method 'requestLatestTetheringEntitlementResult' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.TetheringManager#startTethering(android.net.TetheringManager.TetheringRequest, java.util.concurrent.Executor, android.net.TetheringManager.StartTetheringCallback): + Method 'startTethering' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.TetheringManager#startTethering(int, java.util.concurrent.Executor, android.net.TetheringManager.StartTetheringCallback): + Method 'startTethering' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.TetheringManager#stopAllTethering(): + Method 'stopAllTethering' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.TetheringManager#stopTethering(int): + Method 'stopTethering' documentation mentions permissions already declared by @RequiresPermission + + +SdkConstant: android.net.TetheringManager#ACTION_TETHER_STATE_CHANGED: + Field 'ACTION_TETHER_STATE_CHANGED' is missing @SdkConstant(SdkConstantType.BROADCAST_INTENT_ACTION) + + +Todo: android.net.TetheringConstants: + Documentation mentions 'TODO' diff --git a/Tethering/common/TetheringLib/api/system-lint-baseline.txt b/Tethering/common/TetheringLib/api/system-lint-baseline.txt new file mode 100644 index 0000000000..e678ce184e --- /dev/null +++ b/Tethering/common/TetheringLib/api/system-lint-baseline.txt @@ -0,0 +1,17 @@ +// Baseline format: 1.0 +BroadcastBehavior: android.net.TetheringManager#ACTION_TETHER_STATE_CHANGED: + Field 'ACTION_TETHER_STATE_CHANGED' is missing @BroadcastBehavior + + +RequiresPermission: android.net.TetheringManager#requestLatestTetheringEntitlementResult(int, boolean, java.util.concurrent.Executor, android.net.TetheringManager.OnTetheringEntitlementResultListener): + Method 'requestLatestTetheringEntitlementResult' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.TetheringManager#startTethering(android.net.TetheringManager.TetheringRequest, java.util.concurrent.Executor, android.net.TetheringManager.StartTetheringCallback): + Method 'startTethering' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.TetheringManager#stopAllTethering(): + Method 'stopAllTethering' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.TetheringManager#stopTethering(int): + Method 'stopTethering' documentation mentions permissions already declared by @RequiresPermission + + +SdkConstant: android.net.TetheringManager#ACTION_TETHER_STATE_CHANGED: + Field 'ACTION_TETHER_STATE_CHANGED' is missing @SdkConstant(SdkConstantType.BROADCAST_INTENT_ACTION) diff --git a/framework-t/api/module-lib-lint-baseline.txt b/framework-t/api/module-lib-lint-baseline.txt index 3158bd4596..6f954df640 100644 --- a/framework-t/api/module-lib-lint-baseline.txt +++ b/framework-t/api/module-lib-lint-baseline.txt @@ -5,3 +5,17 @@ BannedThrow: android.app.usage.NetworkStatsManager#querySummary(android.net.Netw Methods must not mention RuntimeException subclasses in throws clauses (was `java.lang.SecurityException`) BannedThrow: android.app.usage.NetworkStatsManager#queryTaggedSummary(android.net.NetworkTemplate, long, long): Methods must not mention RuntimeException subclasses in throws clauses (was `java.lang.SecurityException`) + + +MissingPermission: android.net.IpSecManager#startTunnelModeTransformMigration(android.net.IpSecTransform, java.net.InetAddress, java.net.InetAddress): + Feature field FEATURE_IPSEC_TUNNEL_MIGRATION required by method android.net.IpSecManager.startTunnelModeTransformMigration(android.net.IpSecTransform, java.net.InetAddress, java.net.InetAddress) is hidden or removed + + +RequiresPermission: android.app.usage.NetworkStatsManager#registerUsageCallback(android.net.NetworkTemplate, long, java.util.concurrent.Executor, android.app.usage.NetworkStatsManager.UsageCallback): + Method 'registerUsageCallback' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.EthernetManager#disableInterface(String, java.util.concurrent.Executor, android.os.OutcomeReceiver): + Method 'disableInterface' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.EthernetManager#enableInterface(String, java.util.concurrent.Executor, android.os.OutcomeReceiver): + Method 'enableInterface' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.EthernetManager#updateConfiguration(String, android.net.EthernetNetworkUpdateRequest, java.util.concurrent.Executor, android.os.OutcomeReceiver): + Method 'updateConfiguration' documentation mentions permissions already declared by @RequiresPermission diff --git a/framework-t/api/system-lint-baseline.txt b/framework-t/api/system-lint-baseline.txt index c6055f62a0..4f7af87c7f 100644 --- a/framework-t/api/system-lint-baseline.txt +++ b/framework-t/api/system-lint-baseline.txt @@ -7,6 +7,18 @@ GenericException: android.net.IpSecManager.IpSecTunnelInterface#finalize(): Methods must not throw generic exceptions (`java.lang.Throwable`) +MissingPermission: android.net.IpSecManager#startTunnelModeTransformMigration(android.net.IpSecTransform, java.net.InetAddress, java.net.InetAddress): + Feature field FEATURE_IPSEC_TUNNEL_MIGRATION required by method android.net.IpSecManager.startTunnelModeTransformMigration(android.net.IpSecTransform, java.net.InetAddress, java.net.InetAddress) is hidden or removed + + +RequiresPermission: android.net.EthernetManager#disableInterface(String, java.util.concurrent.Executor, android.os.OutcomeReceiver): + Method 'disableInterface' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.EthernetManager#enableInterface(String, java.util.concurrent.Executor, android.os.OutcomeReceiver): + Method 'enableInterface' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.EthernetManager#updateConfiguration(String, android.net.EthernetNetworkUpdateRequest, java.util.concurrent.Executor, android.os.OutcomeReceiver): + Method 'updateConfiguration' documentation mentions permissions already declared by @RequiresPermission + + UnflaggedApi: android.nearby.CredentialElement#equals(Object): New API must be flagged with @FlaggedApi: method android.nearby.CredentialElement.equals(Object) UnflaggedApi: android.nearby.CredentialElement#hashCode(): diff --git a/framework/api/lint-baseline.txt b/framework/api/lint-baseline.txt index 2f4004ab72..4465bcbd6c 100644 --- a/framework/api/lint-baseline.txt +++ b/framework/api/lint-baseline.txt @@ -1,4 +1,19 @@ // Baseline format: 1.0 +BroadcastBehavior: android.net.ConnectivityManager#ACTION_BACKGROUND_DATA_SETTING_CHANGED: + Field 'ACTION_BACKGROUND_DATA_SETTING_CHANGED' is missing @BroadcastBehavior + + +RequiresPermission: android.net.ConnectivityManager#requestNetwork(android.net.NetworkRequest, android.app.PendingIntent): + Method 'requestNetwork' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.ConnectivityManager#requestNetwork(android.net.NetworkRequest, android.net.ConnectivityManager.NetworkCallback): + Method 'requestNetwork' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.NetworkCapabilities#getOwnerUid(): + Method 'getOwnerUid' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.http.BidirectionalStream.Builder#setTrafficStatsUid(int): + Method 'setTrafficStatsUid' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.http.UrlRequest.Builder#setTrafficStatsUid(int): + Method 'setTrafficStatsUid' documentation mentions permissions without declaring @RequiresPermission + + VisiblySynchronized: android.net.NetworkInfo#toString(): Internal locks must not be exposed (synchronizing on this or class is still - externally observable): method android.net.NetworkInfo.toString() diff --git a/framework/api/module-lib-lint-baseline.txt b/framework/api/module-lib-lint-baseline.txt new file mode 100644 index 0000000000..53a8c5e43b --- /dev/null +++ b/framework/api/module-lib-lint-baseline.txt @@ -0,0 +1,33 @@ +// Baseline format: 1.0 +BroadcastBehavior: android.net.ConnectivityManager#ACTION_BACKGROUND_DATA_SETTING_CHANGED: + Field 'ACTION_BACKGROUND_DATA_SETTING_CHANGED' is missing @BroadcastBehavior + + +RequiresPermission: android.net.ConnectivityManager#isTetheringSupported(): + Method 'isTetheringSupported' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.ConnectivityManager#requestNetwork(android.net.NetworkRequest, android.app.PendingIntent): + Method 'requestNetwork' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.ConnectivityManager#requestNetwork(android.net.NetworkRequest, android.net.ConnectivityManager.NetworkCallback): + Method 'requestNetwork' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.ConnectivityManager#requestRouteToHostAddress(int, java.net.InetAddress): + Method 'requestRouteToHostAddress' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.LinkProperties#getCaptivePortalApiUrl(): + Method 'getCaptivePortalApiUrl' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.LinkProperties#getCaptivePortalData(): + Method 'getCaptivePortalData' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.NetworkCapabilities#getOwnerUid(): + Method 'getOwnerUid' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.NetworkCapabilities#getUnderlyingNetworks(): + Method 'getUnderlyingNetworks' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.NetworkCapabilities.Builder#setAllowedUids(java.util.Set): + Method 'setAllowedUids' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.NetworkCapabilities.Builder#setSignalStrength(int): + Method 'setSignalStrength' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.NetworkCapabilities.Builder#setUnderlyingNetworks(java.util.List): + Method 'setUnderlyingNetworks' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.NetworkRequest.Builder#setSignalStrength(int): + Method 'setSignalStrength' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.http.BidirectionalStream.Builder#setTrafficStatsUid(int): + Method 'setTrafficStatsUid' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.http.UrlRequest.Builder#setTrafficStatsUid(int): + Method 'setTrafficStatsUid' documentation mentions permissions without declaring @RequiresPermission diff --git a/framework/api/system-lint-baseline.txt b/framework/api/system-lint-baseline.txt index 9a97707763..3ac97c004d 100644 --- a/framework/api/system-lint-baseline.txt +++ b/framework/api/system-lint-baseline.txt @@ -1 +1,29 @@ // Baseline format: 1.0 +BroadcastBehavior: android.net.ConnectivityManager#ACTION_BACKGROUND_DATA_SETTING_CHANGED: + Field 'ACTION_BACKGROUND_DATA_SETTING_CHANGED' is missing @BroadcastBehavior + + +RequiresPermission: android.net.ConnectivityManager#isTetheringSupported(): + Method 'isTetheringSupported' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.ConnectivityManager#requestNetwork(android.net.NetworkRequest, android.app.PendingIntent): + Method 'requestNetwork' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.ConnectivityManager#requestNetwork(android.net.NetworkRequest, android.net.ConnectivityManager.NetworkCallback): + Method 'requestNetwork' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.LinkProperties#getCaptivePortalApiUrl(): + Method 'getCaptivePortalApiUrl' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.LinkProperties#getCaptivePortalData(): + Method 'getCaptivePortalData' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.NetworkCapabilities#getOwnerUid(): + Method 'getOwnerUid' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.NetworkCapabilities#getUnderlyingNetworks(): + Method 'getUnderlyingNetworks' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.NetworkCapabilities.Builder#setSignalStrength(int): + Method 'setSignalStrength' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.NetworkCapabilities.Builder#setUnderlyingNetworks(java.util.List): + Method 'setUnderlyingNetworks' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.NetworkRequest.Builder#setSignalStrength(int): + Method 'setSignalStrength' documentation mentions permissions already declared by @RequiresPermission +RequiresPermission: android.net.http.BidirectionalStream.Builder#setTrafficStatsUid(int): + Method 'setTrafficStatsUid' documentation mentions permissions without declaring @RequiresPermission +RequiresPermission: android.net.http.UrlRequest.Builder#setTrafficStatsUid(int): + Method 'setTrafficStatsUid' documentation mentions permissions without declaring @RequiresPermission