From dacbdaa3787d5bf67124ca9fdb564765644a8479 Mon Sep 17 00:00:00 2001 From: Aaron Huang Date: Mon, 30 Mar 2020 17:30:46 +0800 Subject: [PATCH] Add tests for NetworkRequest API This change inculdes coverage of NetworkRequest#Builder().clearCapabilities() and NetworkRequest#getRequestorPackageName() Bug: 153614623 Test: atest CtsNetTestCasesLatestSdk:android.net.cts.NetworkRequestTest Change-Id: Id4e31013cfae78c25abd27b557da4e3e9487870c Merged-In: Id4e31013cfae78c25abd27b557da4e3e9487870c --- .../android/net/cts/NetworkRequestTest.java | 35 +++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/tests/cts/net/src/android/net/cts/NetworkRequestTest.java b/tests/cts/net/src/android/net/cts/NetworkRequestTest.java index 751418657f..08bf1e424b 100644 --- a/tests/cts/net/src/android/net/cts/NetworkRequestTest.java +++ b/tests/cts/net/src/android/net/cts/NetworkRequestTest.java @@ -62,6 +62,18 @@ public class NetworkRequestTest { .hasCapability(NET_CAPABILITY_MMS)); assertFalse(new NetworkRequest.Builder().removeCapability(NET_CAPABILITY_MMS).build() .hasCapability(NET_CAPABILITY_MMS)); + + final NetworkRequest nr = new NetworkRequest.Builder().clearCapabilities().build(); + // Verify request has no capabilities + verifyNoCapabilities(nr); + } + + private void verifyNoCapabilities(NetworkRequest nr) { + // NetworkCapabilities.mNetworkCapabilities is defined as type long + final int MAX_POSSIBLE_CAPABILITY = Long.SIZE; + for(int bit = 0; bit < MAX_POSSIBLE_CAPABILITY; bit++) { + assertFalse(nr.hasCapability(bit)); + } } @Test @@ -86,6 +98,29 @@ public class NetworkRequestTest { .build() .getNetworkSpecifier(); assertEquals(obtainedSpecifier, specifier); + + assertNull(new NetworkRequest.Builder() + .clearCapabilities() + .build() + .getNetworkSpecifier()); + } + + @Test + @IgnoreUpTo(Build.VERSION_CODES.Q) + public void testRequestorPackageName() { + assertNull(new NetworkRequest.Builder().build().getRequestorPackageName()); + final String pkgName = "android.net.test"; + final NetworkCapabilities nc = new NetworkCapabilities.Builder() + .setRequestorPackageName(pkgName) + .build(); + final NetworkRequest nr = new NetworkRequest.Builder() + .setCapabilities(nc) + .build(); + assertEquals(pkgName, nr.getRequestorPackageName()); + assertNull(new NetworkRequest.Builder() + .clearCapabilities() + .build() + .getRequestorPackageName()); } @Test