From 7509e6e053648b33166b831e2723d2f57b098f01 Mon Sep 17 00:00:00 2001 From: junyulai Date: Mon, 8 Apr 2019 16:58:22 +0800 Subject: [PATCH] Fix onBlockedStatusChanged does not work on multiple networks There is a logic error in maybeNotifyNetworkBlockedForNewUidRules that caused function to return if there is no status change in the first network. This would cause CTS failed in devices which has volte-enabled SIM inserted. Bug: 129409153 Fix: 117969394 Test: 1. atest com.android.cts.net.HostsideNetworkCallbackTests \ --generate-new-metrics 20 2. atest FrameworksNetTests Change-Id: Ifd18d1c6ad708c1dbc793f03d8241f572af50317 --- services/core/java/com/android/server/ConnectivityService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/ConnectivityService.java b/services/core/java/com/android/server/ConnectivityService.java index 9d2965afdb..88955d7e46 100644 --- a/services/core/java/com/android/server/ConnectivityService.java +++ b/services/core/java/com/android/server/ConnectivityService.java @@ -6554,7 +6554,7 @@ public class ConnectivityService extends IConnectivityManager.Stub uid, newRules, metered, mRestrictBackground); } if (oldBlocked == newBlocked) { - return; + continue; } final int arg = encodeBool(newBlocked); for (int i = 0; i < nai.numNetworkRequests(); i++) {