Merge "Return detailed reason of invalid proxy settings"

This commit is contained in:
Yuhao Zheng
2014-03-04 17:43:47 +00:00
committed by Android (Google) Code Review

View File

@@ -140,13 +140,9 @@ public class ProxyProperties implements Parcelable {
public boolean isValid() { public boolean isValid() {
if (!TextUtils.isEmpty(mPacFileUrl)) return true; if (!TextUtils.isEmpty(mPacFileUrl)) return true;
try { return Proxy.PROXY_VALID == Proxy.validate(mHost == null ? "" : mHost,
Proxy.validate(mHost == null ? "" : mHost, mPort == 0 ? "" : Integer.toString(mPort), mPort == 0 ? "" : Integer.toString(mPort),
mExclusionList == null ? "" : mExclusionList); mExclusionList == null ? "" : mExclusionList);
} catch (IllegalArgumentException e) {
return false;
}
return true;
} }
public java.net.Proxy makeProxy() { public java.net.Proxy makeProxy() {