From 911cf8fecd14790ba89f06a66d07590e5c26aa55 Mon Sep 17 00:00:00 2001 From: markchien Date: Mon, 19 Jul 2021 17:23:54 +0800 Subject: [PATCH] Add TetheringPrivilegedTests to postsubmit Also ignore DadProxyTest before S because it is only enabled from S. To using ignore test rule, replace AndroidJunit with DevSdkIgnoreRunner. It is fine because the we don't use the test UI (e.g. running test in UI thread). Test: atest TetheringPrivilegedTests Change-Id: I701ee877520f78ded2394adbae1f4d9dd612d700 --- TEST_MAPPING | 5 +++++ .../tests/privileged/src/android/net/ip/DadProxyTest.java | 7 +++++-- .../src/com/android/networkstack/tethering/BpfMapTest.java | 5 ++--- 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/TEST_MAPPING b/TEST_MAPPING index 54291a10f5..be0e0404ce 100644 --- a/TEST_MAPPING +++ b/TEST_MAPPING @@ -22,6 +22,11 @@ "name": "TetheringIntegrationTests" } ], + "postsubmit": [ + { + "name": "TetheringPrivilegedTests" + } + ], "mainline-presubmit": [ { "name": "CtsNetTestCasesLatestSdk[CaptivePortalLoginGoogle.apk+NetworkStackGoogle.apk+com.google.android.resolv.apex+com.google.android.tethering.apex]", diff --git a/Tethering/tests/privileged/src/android/net/ip/DadProxyTest.java b/Tethering/tests/privileged/src/android/net/ip/DadProxyTest.java index a933e1b277..23d9055745 100644 --- a/Tethering/tests/privileged/src/android/net/ip/DadProxyTest.java +++ b/Tethering/tests/privileged/src/android/net/ip/DadProxyTest.java @@ -31,6 +31,7 @@ import android.net.InetAddresses; import android.net.MacAddress; import android.net.util.InterfaceParams; import android.net.util.TetheringUtils; +import android.os.Build; import android.os.Handler; import android.os.HandlerThread; import android.os.IBinder; @@ -38,8 +39,9 @@ import android.os.Looper; import androidx.test.InstrumentationRegistry; import androidx.test.filters.SmallTest; -import androidx.test.runner.AndroidJUnit4; +import com.android.testutils.DevSdkIgnoreRule.IgnoreUpTo; +import com.android.testutils.DevSdkIgnoreRunner; import com.android.testutils.TapPacketReader; import com.android.testutils.TapPacketReaderRule; @@ -54,7 +56,8 @@ import org.mockito.MockitoAnnotations; import java.io.IOException; import java.nio.ByteBuffer; -@RunWith(AndroidJUnit4.class) +@RunWith(DevSdkIgnoreRunner.class) +@IgnoreUpTo(Build.VERSION_CODES.R) @SmallTest public class DadProxyTest { private static final int DATA_BUFFER_LEN = 4096; diff --git a/Tethering/tests/privileged/src/com/android/networkstack/tethering/BpfMapTest.java b/Tethering/tests/privileged/src/com/android/networkstack/tethering/BpfMapTest.java index 830729d98f..0deb17722a 100644 --- a/Tethering/tests/privileged/src/com/android/networkstack/tethering/BpfMapTest.java +++ b/Tethering/tests/privileged/src/com/android/networkstack/tethering/BpfMapTest.java @@ -31,9 +31,8 @@ import android.system.ErrnoException; import android.system.OsConstants; import android.util.ArrayMap; -import androidx.test.runner.AndroidJUnit4; - import com.android.testutils.DevSdkIgnoreRule.IgnoreUpTo; +import com.android.testutils.DevSdkIgnoreRunner; import org.junit.Before; import org.junit.BeforeClass; @@ -45,7 +44,7 @@ import java.util.NoSuchElementException; import java.util.concurrent.atomic.AtomicInteger; -@RunWith(AndroidJUnit4.class) +@RunWith(DevSdkIgnoreRunner.class) @IgnoreUpTo(Build.VERSION_CODES.R) public final class BpfMapTest { // Sync from packages/modules/Connectivity/Tethering/bpf_progs/offload.c.