diff --git a/framework-t/api/current.txt b/framework-t/api/current.txt index 55328532ff..86745d401b 100644 --- a/framework-t/api/current.txt +++ b/framework-t/api/current.txt @@ -228,8 +228,8 @@ package android.net.nsd { } public static interface NsdManager.ResolveListener { + method public default void onResolutionStopped(@NonNull android.net.nsd.NsdServiceInfo); method public void onResolveFailed(android.net.nsd.NsdServiceInfo, int); - method public default void onResolveStopped(@NonNull android.net.nsd.NsdServiceInfo); method public void onServiceResolved(android.net.nsd.NsdServiceInfo); method public default void onStopResolutionFailed(@NonNull android.net.nsd.NsdServiceInfo, int); } diff --git a/framework-t/src/android/net/nsd/NsdManager.java b/framework-t/src/android/net/nsd/NsdManager.java index 122e3a02a4..e38ae8e51a 100644 --- a/framework-t/src/android/net/nsd/NsdManager.java +++ b/framework-t/src/android/net/nsd/NsdManager.java @@ -767,18 +767,18 @@ public final class NsdManager { * Called on the internal thread or with an executor passed to * {@link NsdManager#resolveService} to report the resolution was stopped. * - * A stop resolution operation would call either onResolveStopped or onStopResolutionFailed - * once based on the result. + * A stop resolution operation would call either onResolutionStopped or + * onStopResolutionFailed once based on the result. */ - default void onResolveStopped(@NonNull NsdServiceInfo serviceInfo) { } + default void onResolutionStopped(@NonNull NsdServiceInfo serviceInfo) { } /** * Called once on the internal thread or with an executor passed to * {@link NsdManager#resolveService} to report that stopping resolution failed with an * error. * - * A stop resolution operation would call either onResolveStopped or onStopResolutionFailed - * once based on the result. + * A stop resolution operation would call either onResolutionStopped or + * onStopResolutionFailed once based on the result. */ default void onStopResolutionFailed(@NonNull NsdServiceInfo serviceInfo, @StopOperationFailureCode int errorCode) { } @@ -929,7 +929,7 @@ public final class NsdManager { break; case STOP_RESOLUTION_SUCCEEDED: removeListener(key); - executor.execute(() -> ((ResolveListener) listener).onResolveStopped( + executor.execute(() -> ((ResolveListener) listener).onResolutionStopped( ns)); break; case REGISTER_SERVICE_CALLBACK_FAILED: @@ -1301,7 +1301,7 @@ public final class NsdManager { /** * Stop service resolution initiated with {@link #resolveService}. * - * A successful stop is notified with a call to {@link ResolveListener#onResolveStopped}. + * A successful stop is notified with a call to {@link ResolveListener#onResolutionStopped}. * *

Upon failure to stop service resolution for example if resolution is done or the * requester stops resolution repeatedly, the application is notified diff --git a/tests/cts/net/src/android/net/cts/NsdManagerTest.kt b/tests/cts/net/src/android/net/cts/NsdManagerTest.kt index 66e7713df5..9b27df5bfb 100644 --- a/tests/cts/net/src/android/net/cts/NsdManagerTest.kt +++ b/tests/cts/net/src/android/net/cts/NsdManagerTest.kt @@ -41,7 +41,7 @@ import android.net.cts.NsdManagerTest.NsdRegistrationRecord.RegistrationEvent.Se import android.net.cts.NsdManagerTest.NsdRegistrationRecord.RegistrationEvent.ServiceUnregistered import android.net.cts.NsdManagerTest.NsdRegistrationRecord.RegistrationEvent.UnregistrationFailed import android.net.cts.NsdManagerTest.NsdResolveRecord.ResolveEvent.ResolveFailed -import android.net.cts.NsdManagerTest.NsdResolveRecord.ResolveEvent.ResolveStopped +import android.net.cts.NsdManagerTest.NsdResolveRecord.ResolveEvent.ResolutionStopped import android.net.cts.NsdManagerTest.NsdResolveRecord.ResolveEvent.ServiceResolved import android.net.cts.NsdManagerTest.NsdResolveRecord.ResolveEvent.StopResolutionFailed import android.net.cts.NsdManagerTest.NsdServiceInfoCallbackRecord.ServiceInfoCallbackEvent.RegisterCallbackFailed @@ -273,7 +273,7 @@ class NsdManagerTest { ResolveEvent() data class ServiceResolved(val serviceInfo: NsdServiceInfo) : ResolveEvent() - data class ResolveStopped(val serviceInfo: NsdServiceInfo) : ResolveEvent() + data class ResolutionStopped(val serviceInfo: NsdServiceInfo) : ResolveEvent() data class StopResolutionFailed(val serviceInfo: NsdServiceInfo, val errorCode: Int) : ResolveEvent() } @@ -286,8 +286,8 @@ class NsdManagerTest { add(ServiceResolved(si)) } - override fun onResolveStopped(si: NsdServiceInfo) { - add(ResolveStopped(si)) + override fun onResolutionStopped(si: NsdServiceInfo) { + add(ResolutionStopped(si)) } override fun onStopResolutionFailed(si: NsdServiceInfo, err: Int) { @@ -798,10 +798,10 @@ class NsdManagerTest { val resolveRecord = NsdResolveRecord() // Try to resolve an unknown service then stop it immediately. - // Expected ResolveStopped callback. + // Expected ResolutionStopped callback. nsdShim.resolveService(nsdManager, si, { it.run() }, resolveRecord) nsdShim.stopServiceResolution(nsdManager, resolveRecord) - val stoppedCb = resolveRecord.expectCallback() + val stoppedCb = resolveRecord.expectCallback() assertEquals(si.serviceName, stoppedCb.serviceInfo.serviceName) assertEquals(si.serviceType, stoppedCb.serviceInfo.serviceType) } diff --git a/tests/unit/java/com/android/server/NsdServiceTest.java b/tests/unit/java/com/android/server/NsdServiceTest.java index a2c4b9be83..5a3bc64cce 100644 --- a/tests/unit/java/com/android/server/NsdServiceTest.java +++ b/tests/unit/java/com/android/server/NsdServiceTest.java @@ -629,7 +629,7 @@ public class NsdServiceTest { waitForIdle(); verify(mMockMDnsM).stopOperation(resolveId); - verify(resolveListener, timeout(TIMEOUT_MS)).onResolveStopped(argThat(ns -> + verify(resolveListener, timeout(TIMEOUT_MS)).onResolutionStopped(argThat(ns -> request.getServiceName().equals(ns.getServiceName()) && request.getServiceType().equals(ns.getServiceType()))); } @@ -696,7 +696,7 @@ public class NsdServiceTest { waitForIdle(); verify(mMockMDnsM).stopOperation(getAddrId); - verify(resolveListener, timeout(TIMEOUT_MS)).onResolveStopped(argThat(ns -> + verify(resolveListener, timeout(TIMEOUT_MS)).onResolutionStopped(argThat(ns -> request.getServiceName().equals(ns.getServiceName()) && request.getServiceType().equals(ns.getServiceType()))); }