LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PT10] Move loadGlobalProxy into ProxyTracker.

Browse Source 
Test: runtest
Change-Id: Id1c57ebb575c8742310be4822ec6e3fa03f487c3
This commit is contained in:
Chalard Jean
2018-06-08 12:47:42 +09:00
parent 75e74f759d
commit e4f9bd95ec
2 changed files with 30 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
services/core/java/com/android/server/ConnectivityService.java
View File

@@ -1837,7 +1837,7 @@ public class ConnectivityService extends IConnectivityManager.Stub
}
void systemReady() {
loadGlobalProxy();
mProxyTracker.loadGlobalProxy();
registerNetdEventCallback();
synchronized (this) {
@@ -3455,31 +3455,6 @@ public class ConnectivityService extends IConnectivityManager.Stub
mProxyTracker.setGlobalProxy(proxyProperties);
}
private void loadGlobalProxy() {
ContentResolver res = mContext.getContentResolver();
String host = Settings.Global.getString(res, Settings.Global.GLOBAL_HTTP_PROXY_HOST);
int port = Settings.Global.getInt(res, Settings.Global.GLOBAL_HTTP_PROXY_PORT, 0);
String exclList = Settings.Global.getString(res,
Settings.Global.GLOBAL_HTTP_PROXY_EXCLUSION_LIST);
String pacFileUrl = Settings.Global.getString(res, Settings.Global.GLOBAL_HTTP_PROXY_PAC);
if (!TextUtils.isEmpty(host) || !TextUtils.isEmpty(pacFileUrl)) {
ProxyInfo proxyProperties;
if (!TextUtils.isEmpty(pacFileUrl)) {
proxyProperties = new ProxyInfo(pacFileUrl);
} else {
proxyProperties = new ProxyInfo(host, port, exclList);
}
if (!proxyProperties.isValid()) {
if (DBG) log("Invalid proxy properties, ignoring: " + proxyProperties.toString());
return;
}
synchronized (mProxyTracker.mProxyLock) {
mProxyTracker.mGlobalProxy = proxyProperties;
}
}
}
@Override
@Nullable
public ProxyInfo getGlobalProxy() {

29
services/core/java/com/android/server/connectivity/ProxyTracker.java
View File

@@ -141,6 +141,35 @@ public class ProxyTracker {
}
}
/**
* Read the global proxy settings and cache them in memory.
*/
public void loadGlobalProxy() {
ContentResolver res = mContext.getContentResolver();
String host = Settings.Global.getString(res, Settings.Global.GLOBAL_HTTP_PROXY_HOST);
int port = Settings.Global.getInt(res, Settings.Global.GLOBAL_HTTP_PROXY_PORT, 0);
String exclList = Settings.Global.getString(res,
Settings.Global.GLOBAL_HTTP_PROXY_EXCLUSION_LIST);
String pacFileUrl = Settings.Global.getString(res, Settings.Global.GLOBAL_HTTP_PROXY_PAC);
if (!TextUtils.isEmpty(host) || !TextUtils.isEmpty(pacFileUrl)) {
ProxyInfo proxyProperties;
if (!TextUtils.isEmpty(pacFileUrl)) {
proxyProperties = new ProxyInfo(pacFileUrl);
} else {
proxyProperties = new ProxyInfo(host, port, exclList);
}
if (!proxyProperties.isValid()) {
if (DBG) Slog.d(TAG, "Invalid proxy properties, ignoring: " + proxyProperties);
return;
}
synchronized (mProxyLock) {
mGlobalProxy = proxyProperties;
}
}
// TODO : shouldn't this function call mPacManager.setCurrentProxyScriptUrl ?
}
/**
* Sends the system broadcast informing apps about a new proxy configuration.
*