LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove isUnsafeBuild() from IpSecAlgorithm

Browse Source 
IpSec is going to move to Connectivity mainline module so
hidden API usage should be removed. There's no formal API
could be an alternative for Build.IS_ENG. Considering
isUnsafeBuild() is not a really helpful method because it
only prints the log in eng build. Therefore, remove it.

Bug: 204153604
Test: FrameworksNetTests
Change-Id: Ic354e12423629b0d72e8087843893953a0c8c465
This commit is contained in:
Aaron Huang
2021-12-09 16:18:06 +08:00
parent f318d55576
commit e6ab4493c6
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
framework-t/src/android/net/IpSecAlgorithm.java
View File

@@ -469,20 +469,12 @@ public final class IpSecAlgorithm implements Parcelable {
} }
} }
// Because encryption keys are sensitive and userdebug builds are used by large user pools
// such as beta testers, we only allow sensitive info such as keys on eng builds.
private static boolean isUnsafeBuild() {
return Build.IS_DEBUGGABLE && Build.IS_ENG;
}
@Override @Override
@NonNull @NonNull
public String toString() { public String toString() {
return new StringBuilder() return new StringBuilder()
.append("{mName=") .append("{mName=")
.append(mName) .append(mName)
.append(", mKey=")
.append(isUnsafeBuild() ? HexDump.toHexString(mKey) : "<hidden>")
.append(", mTruncLenBits=") .append(", mTruncLenBits=")
.append(mTruncLenBits) .append(mTruncLenBits)
.append("}") .append("}")