From ec0149f1ba48f8539824ae8b8ee38343b54cabe0 Mon Sep 17 00:00:00 2001 From: Chalard Jean Date: Tue, 3 Oct 2023 16:01:00 +0900 Subject: [PATCH] Remove an NPE in tearDown This is masking an exception in setUp() and makes debugging difficult Test: treehugger Change-Id: I8b5b80c4171d45076dd02bab5ff4b6dc81d98086 --- .../hostside/AbstractRestrictBackgroundNetworkTestCase.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/cts/hostside/app/src/com/android/cts/net/hostside/AbstractRestrictBackgroundNetworkTestCase.java b/tests/cts/hostside/app/src/com/android/cts/net/hostside/AbstractRestrictBackgroundNetworkTestCase.java index 89a55a760b..b9ed56a6a6 100644 --- a/tests/cts/hostside/app/src/com/android/cts/net/hostside/AbstractRestrictBackgroundNetworkTestCase.java +++ b/tests/cts/hostside/app/src/com/android/cts/net/hostside/AbstractRestrictBackgroundNetworkTestCase.java @@ -198,7 +198,8 @@ public abstract class AbstractRestrictBackgroundNetworkTestCase { protected void tearDown() throws Exception { executeShellCommand("cmd netpolicy stop-watching"); mServiceClient.unbind(); - if (mLock.isHeld()) mLock.release(); + final PowerManager.WakeLock lock = mLock; + if (null != lock && lock.isHeld()) lock.release(); } protected int getUid(String packageName) throws Exception {