From 4feab037a55449f9f8b3d65b744598b9fffa42b2 Mon Sep 17 00:00:00 2001 From: Remi NGUYEN VAN Date: Wed, 24 Jun 2020 13:06:41 +0900 Subject: [PATCH] Skip flaky CTS tests for presubmit Skip testRegisterCallbackWithCarrierPrivileges and testContinuousQueriesInline for presubmit, as they are highly flaky. These tests are still run in postsubmit as part of MTS. In order to put the CTS suite in presubmit as early as possible, add the annotation so they are skipped in TEST_MAPPING. Bug: 158153057 Bug: 159718782 Bug: 159762682 Test: m Change-Id: I4763db869fbc714767ea5ca3651e4a0b0c9e9378 --- .../src/android/net/cts/ConnectivityDiagnosticsManagerTest.java | 2 ++ tests/cts/net/src/android/net/cts/DnsResolverTest.java | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tests/cts/net/src/android/net/cts/ConnectivityDiagnosticsManagerTest.java b/tests/cts/net/src/android/net/cts/ConnectivityDiagnosticsManagerTest.java index a19ba64d7f..34ca9a4e69 100644 --- a/tests/cts/net/src/android/net/cts/ConnectivityDiagnosticsManagerTest.java +++ b/tests/cts/net/src/android/net/cts/ConnectivityDiagnosticsManagerTest.java @@ -80,6 +80,7 @@ import com.android.internal.util.ArrayUtils; import com.android.testutils.ArrayTrackRecord; import com.android.testutils.DevSdkIgnoreRule.IgnoreUpTo; import com.android.testutils.DevSdkIgnoreRunner; +import com.android.testutils.SkipPresubmit; import org.junit.After; import org.junit.Before; @@ -189,6 +190,7 @@ public class ConnectivityDiagnosticsManagerTest { cb.assertNoCallback(); } + @SkipPresubmit(reason = "Flaky: b/159718782; add to presubmit after fixing") @Test public void testRegisterCallbackWithCarrierPrivileges() throws Exception { assumeTrue(mPackageManager.hasSystemFeature(FEATURE_TELEPHONY)); diff --git a/tests/cts/net/src/android/net/cts/DnsResolverTest.java b/tests/cts/net/src/android/net/cts/DnsResolverTest.java index e6f75c353b..4acbbcfbdd 100644 --- a/tests/cts/net/src/android/net/cts/DnsResolverTest.java +++ b/tests/cts/net/src/android/net/cts/DnsResolverTest.java @@ -47,6 +47,7 @@ import android.test.AndroidTestCase; import android.util.Log; import com.android.net.module.util.DnsPacket; +import com.android.testutils.SkipPresubmit; import java.net.Inet4Address; import java.net.Inet6Address; @@ -585,6 +586,7 @@ public class DnsResolverTest extends AndroidTestCase { doTestContinuousQueries(mExecutor); } + @SkipPresubmit(reason = "Flaky: b/159762682; add to presubmit after fixing") public void testContinuousQueriesInline() throws Exception { doTestContinuousQueries(mExecutorInline); }