From f2d8b983b5832b8b01f634829680b02cad9d8ef7 Mon Sep 17 00:00:00 2001 From: Paul Jensen Date: Fri, 5 Sep 2014 10:18:36 -0400 Subject: [PATCH] Stop logging false error when lingering completes. When lingering completes ConnectivityService would log an error message saying the Network still had NetworkRequests. Fixed by ignoring listening NetworkRequests which aren't a problem. Change-Id: Ie78a1f91c47b012eae28a377dd77bee2cfcbde3b --- .../java/com/android/server/ConnectivityService.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/services/core/java/com/android/server/ConnectivityService.java b/services/core/java/com/android/server/ConnectivityService.java index c3b56fefa7..a811bb9da7 100644 --- a/services/core/java/com/android/server/ConnectivityService.java +++ b/services/core/java/com/android/server/ConnectivityService.java @@ -4436,10 +4436,14 @@ public class ConnectivityService extends IConnectivityManager.Stub { loge("Unknown NetworkAgentInfo in handleLingerComplete"); return; } - if (DBG) log("handleLingerComplete for " + oldNetwork.name()); if (DBG) { - if (oldNetwork.networkRequests.size() != 0) { - loge("Dead network still had " + oldNetwork.networkRequests.size() + " requests"); + log("handleLingerComplete for " + oldNetwork.name()); + for (int i = 0; i < oldNetwork.networkRequests.size(); i++) { + NetworkRequest nr = oldNetwork.networkRequests.valueAt(i); + // Ignore listening requests. + if (mNetworkRequests.get(nr).isRequest == false) continue; + loge("Dead network still had at least " + nr); + break; } } oldNetwork.asyncChannel.disconnect();