From 31c44d7bc468d8200bb1ebaa51b7403552667cf0 Mon Sep 17 00:00:00 2001 From: Remi NGUYEN VAN Date: Mon, 18 Feb 2019 11:20:28 +0900 Subject: [PATCH] Add logging to NetworkStackClient The current logging relies on the system log that may rotate. This is a problem to investigate bugs where the network stack service is not started. Add a SharedLog to NetworkStackClient and dump it in ConnectivityService (for lack of a better place to dump it). Bug: 124307802 Test: Booted, dumpsys connectivity shows the log Change-Id: If596451d0613645f68a8a32acb032eea76ea506c --- .../core/java/com/android/server/ConnectivityService.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/services/core/java/com/android/server/ConnectivityService.java b/services/core/java/com/android/server/ConnectivityService.java index b5fcde4bf2..1035efb803 100644 --- a/services/core/java/com/android/server/ConnectivityService.java +++ b/services/core/java/com/android/server/ConnectivityService.java @@ -2373,6 +2373,11 @@ public class ConnectivityService extends IConnectivityManager.Stub pw.decreaseIndent(); } + + pw.println(); + pw.println("NetworkStackClient logs:"); + pw.increaseIndent(); + NetworkStackClient.getInstance().dump(pw); } private void dumpNetworks(IndentingPrintWriter pw) {