LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Turn back on global proxy support.

Browse Source 
This reverts 138626.

Bug:8557674
Change-Id: I7b117d313c424d75bdeeea507541a96342f256f0
This commit is contained in:
Robert Greenwalt
2013-04-05 17:14:19 -07:00
parent 89218e5e3f
commit f9661d357f
1 changed files with 16 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
services/java/com/android/server/ConnectivityService.java
View File

@@ -321,12 +321,11 @@ public class ConnectivityService extends IConnectivityManager.Stub {
// track the current default http proxy - tell the world if we get a new one (real change) // track the current default http proxy - tell the world if we get a new one (real change)
private ProxyProperties mDefaultProxy = null; private ProxyProperties mDefaultProxy = null;
private Object mDefaultProxyLock = new Object(); private Object mProxyLock = new Object();
private boolean mDefaultProxyDisabled = false; private boolean mDefaultProxyDisabled = false;
// track the global proxy. // track the global proxy.
private ProxyProperties mGlobalProxy = null; private ProxyProperties mGlobalProxy = null;
private final Object mGlobalProxyLock = new Object();
private SettingsObserver mSettingsObserver; private SettingsObserver mSettingsObserver;
@@ -3039,14 +3038,15 @@ public class ConnectivityService extends IConnectivityManager.Stub {
// so this API change wouldn't have a benifit. It also breaks the passing // so this API change wouldn't have a benifit. It also breaks the passing
// of proxy info to all the JVMs. // of proxy info to all the JVMs.
// enforceAccessPermission(); // enforceAccessPermission();
synchronized (mDefaultProxyLock) { synchronized (mProxyLock) {
return mDefaultProxyDisabled ? null : mDefaultProxy; if (mGlobalProxy != null) return mGlobalProxy;
return (mDefaultProxyDisabled ? null : mDefaultProxy);
} }
} }
public void setGlobalProxy(ProxyProperties proxyProperties) { public void setGlobalProxy(ProxyProperties proxyProperties) {
enforceChangePermission(); enforceChangePermission();
synchronized (mGlobalProxyLock) { synchronized (mProxyLock) {
if (proxyProperties == mGlobalProxy) return; if (proxyProperties == mGlobalProxy) return;
if (proxyProperties != null && proxyProperties.equals(mGlobalProxy)) return; if (proxyProperties != null && proxyProperties.equals(mGlobalProxy)) return;
if (mGlobalProxy != null && mGlobalProxy.equals(proxyProperties)) return; if (mGlobalProxy != null && mGlobalProxy.equals(proxyProperties)) return;
@@ -3072,7 +3072,7 @@ public class ConnectivityService extends IConnectivityManager.Stub {
if (mGlobalProxy == null) { if (mGlobalProxy == null) {
proxyProperties = mDefaultProxy; proxyProperties = mDefaultProxy;
} }
//sendProxyBroadcast(proxyProperties); sendProxyBroadcast(proxyProperties);
} }
private void loadGlobalProxy() { private void loadGlobalProxy() {
@@ -3083,7 +3083,7 @@ public class ConnectivityService extends IConnectivityManager.Stub {
Settings.Global.GLOBAL_HTTP_PROXY_EXCLUSION_LIST); Settings.Global.GLOBAL_HTTP_PROXY_EXCLUSION_LIST);
if (!TextUtils.isEmpty(host)) { if (!TextUtils.isEmpty(host)) {
ProxyProperties proxyProperties = new ProxyProperties(host, port, exclList); ProxyProperties proxyProperties = new ProxyProperties(host, port, exclList);
synchronized (mGlobalProxyLock) { synchronized (mProxyLock) {
mGlobalProxy = proxyProperties; mGlobalProxy = proxyProperties;
} }
} }
@@ -3094,7 +3094,7 @@ public class ConnectivityService extends IConnectivityManager.Stub {
// so this API change wouldn't have a benifit. It also breaks the passing // so this API change wouldn't have a benifit. It also breaks the passing
// of proxy info to all the JVMs. // of proxy info to all the JVMs.
// enforceAccessPermission(); // enforceAccessPermission();
synchronized (mGlobalProxyLock) { synchronized (mProxyLock) {
return mGlobalProxy; return mGlobalProxy;
} }
} }
@@ -3103,11 +3103,12 @@ public class ConnectivityService extends IConnectivityManager.Stub {
if (proxy != null && TextUtils.isEmpty(proxy.getHost())) { if (proxy != null && TextUtils.isEmpty(proxy.getHost())) {
proxy = null; proxy = null;
} }
synchronized (mDefaultProxyLock) { synchronized (mProxyLock) {
if (mDefaultProxy != null && mDefaultProxy.equals(proxy)) return; if (mDefaultProxy != null && mDefaultProxy.equals(proxy)) return;
if (mDefaultProxy == proxy) return; if (mDefaultProxy == proxy) return; // catches repeated nulls
mDefaultProxy = proxy; mDefaultProxy = proxy;
if (mGlobalProxy != null) return;
if (!mDefaultProxyDisabled) { if (!mDefaultProxyDisabled) {
sendProxyBroadcast(proxy); sendProxyBroadcast(proxy);
} }
@@ -3350,10 +3351,10 @@ public class ConnectivityService extends IConnectivityManager.Stub {
mDnsOverridden = true; mDnsOverridden = true;
} }
// Temporarily disable the default proxy. // Temporarily disable the default proxy (not global).
synchronized (mDefaultProxyLock) { synchronized (mProxyLock) {
mDefaultProxyDisabled = true; mDefaultProxyDisabled = true;
if (mDefaultProxy != null) { if (mGlobalProxy == null && mDefaultProxy != null) {
sendProxyBroadcast(null); sendProxyBroadcast(null);
} }
} }
@@ -3368,9 +3369,9 @@ public class ConnectivityService extends IConnectivityManager.Stub {
mHandler.sendEmptyMessage(EVENT_RESTORE_DNS); mHandler.sendEmptyMessage(EVENT_RESTORE_DNS);
} }
} }
synchronized (mDefaultProxyLock) { synchronized (mProxyLock) {
mDefaultProxyDisabled = false; mDefaultProxyDisabled = false;
if (mDefaultProxy != null) { if (mGlobalProxy == null && mDefaultProxy != null) {
sendProxyBroadcast(mDefaultProxy); sendProxyBroadcast(mDefaultProxy);
} }
} }