From 77c4f5c602f3e22b79edcf4dd5d54df066861faf Mon Sep 17 00:00:00 2001 From: Patrick Rohr Date: Wed, 30 Nov 2022 12:56:29 -0800 Subject: [PATCH] gn2bp: rename _set_arg_positional_value for readability We could argue about just getting rid of it altogether. Test: none Change-Id: I1cfe5657d0faeff044b4dcfefb568eb70e6b8813 --- tools/gn2bp/gen_android_bp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/gn2bp/gen_android_bp b/tools/gn2bp/gen_android_bp index 1fc1be8c60..c8f964dd91 100755 --- a/tools/gn2bp/gen_android_bp +++ b/tools/gn2bp/gen_android_bp @@ -659,8 +659,7 @@ class BaseActionSanitizer(): i = self.target.args.index(arg) self.target.args[i + 1] = value - def _set_arg_positional_value(self, position, value): - assert(position < len(self.target.args)) + def _set_arg_at(self, position, value): self.target.args[position] = value def _delete_arg(self, arg): @@ -684,7 +683,7 @@ class BaseActionSanitizer(): class WriteBuildDateHeaderSanitizer(BaseActionSanitizer): def get_args(self): - self._set_arg_positional_value(0, '$(out)') + self._set_arg_at(0, '$(out)') return super().get_args() class WriteBuildFlagHeaderSanitizer(BaseActionSanitizer):