diff --git a/Tethering/common/TetheringLib/Android.bp b/Tethering/common/TetheringLib/Android.bp index fce436079b..f65277269f 100644 --- a/Tethering/common/TetheringLib/Android.bp +++ b/Tethering/common/TetheringLib/Android.bp @@ -22,6 +22,7 @@ java_sdk_library { defaults: ["framework-module-defaults"], impl_library_visibility: [ "//packages/modules/Connectivity/Tethering:__subpackages__", + "//packages/modules/Connectivity/tests:__subpackages__", ], srcs: [":framework-tethering-srcs"], diff --git a/Tethering/tests/integration/Android.bp b/Tethering/tests/integration/Android.bp index 351b9f4f5a..e807613ecd 100644 --- a/Tethering/tests/integration/Android.bp +++ b/Tethering/tests/integration/Android.bp @@ -51,7 +51,8 @@ android_library { defaults: ["TetheringIntegrationTestsDefaults"], visibility: [ "//packages/modules/Connectivity/tests/cts/tethering", - "//packages/modules/Connectivity/Tethering/tests/mts", + "//packages/modules/Connectivity/tests:__subpackages__", + "//packages/modules/Connectivity/Tethering/tests:__subpackages__", ] } @@ -104,7 +105,6 @@ android_test { "libnetworkstackutilsjni", "libtetherutilsjni", ], - jarjar_rules: ":TetheringTestsJarJarRules", compile_multilib: "both", manifest: "AndroidManifest_coverage.xml", } diff --git a/Tethering/tests/unit/Android.bp b/Tethering/tests/unit/Android.bp index b4b3977fd6..192a540ee5 100644 --- a/Tethering/tests/unit/Android.bp +++ b/Tethering/tests/unit/Android.bp @@ -75,6 +75,7 @@ java_defaults { "libstaticjvmtiagent", "libtetherutilsjni", ], + jarjar_rules: ":TetheringTestsJarJarRules", } // Library containing the unit tests. This is used by the coverage test target to pull in the @@ -85,7 +86,8 @@ android_library { defaults: ["TetheringTestsDefaults"], target_sdk_version: "30", visibility: [ - "//packages/modules/Connectivity/Tethering/tests/integration", + "//packages/modules/Connectivity/tests:__subpackages__", + "//packages/modules/Connectivity/Tethering/tests:__subpackages__", ] } @@ -96,7 +98,6 @@ android_test { "device-tests", "mts", ], - jarjar_rules: ":TetheringTestsJarJarRules", defaults: ["TetheringTestsDefaults"], compile_multilib: "both", } diff --git a/tests/common/Android.bp b/tests/common/Android.bp index e8963b9011..28339f116d 100644 --- a/tests/common/Android.bp +++ b/tests/common/Android.bp @@ -43,6 +43,53 @@ java_library { ], } +android_test { + name: "ConnectivityCoverageTests", + // Tethering started on SDK 30 + min_sdk_version: "30", + // TODO: change to 31 as soon as it is available + target_sdk_version: "30", + test_suites: ["device-tests", "mts"], + defaults: [ + "framework-connectivity-test-defaults", + "FrameworksNetTests-jni-defaults", + "libnetworkstackutilsjni_deps", + ], + manifest: "AndroidManifest_coverage.xml", + test_config: "AndroidTest_Coverage.xml", + static_libs: [ + // Added first so all tests use extended mockito, instead of all tests using regular mockito + // (some tests would fail). + // TODO: consider removing extended mockito usage in tests that use it, for performance + "mockito-target-extended-minus-junit4", + "FrameworksNetTestsLib", + "modules-utils-native-coverage-listener", + "NetdStaticLibTestsLib", + "NetworkStaticLibTestsLib", + "NetworkStackTestsLib", + "TetheringTestsLatestSdkLib", + "TetheringIntegrationTestsLatestSdkLib", + ], + jni_libs: [ + // For mockito extended + "libdexmakerjvmtiagent", + "libstaticjvmtiagent", + // For NetworkStackUtils included in NetworkStackBase + "libnetworkstackutilsjni", + "libtetherutilsjni", + // For framework tests + "libservice-connectivity", + ], + libs: [ + // Although not required to compile the static libs together, the "libs" used to build each + // of the common static test libs are necessary for R8 to avoid "Missing class" warnings and + // incorrect optimizations + "framework-tethering.impl", + "framework-wifi.stubs.module_lib", + ], + compile_multilib: "both", +} + // defaults for tests that need to build against framework-connectivity's @hide APIs // Only usable from targets that have visibility on framework-connectivity.impl. // Instead of using this, consider avoiding to depend on hidden connectivity APIs in diff --git a/tests/common/AndroidManifest_coverage.xml b/tests/common/AndroidManifest_coverage.xml new file mode 100644 index 0000000000..8a22792af8 --- /dev/null +++ b/tests/common/AndroidManifest_coverage.xml @@ -0,0 +1,29 @@ + + + + + + + + + + diff --git a/tests/common/AndroidTest_Coverage.xml b/tests/common/AndroidTest_Coverage.xml new file mode 100644 index 0000000000..577f36a3da --- /dev/null +++ b/tests/common/AndroidTest_Coverage.xml @@ -0,0 +1,27 @@ + + + + + + diff --git a/tests/unit/Android.bp b/tests/unit/Android.bp index 5eb43f3047..a7f57e8c92 100644 --- a/tests/unit/Android.bp +++ b/tests/unit/Android.bp @@ -45,21 +45,21 @@ java_defaults { ], } -android_test { - name: "FrameworksNetTests", +android_library { + name: "FrameworksNetTestsLib", + min_sdk_version: "30", defaults: [ "framework-connectivity-test-defaults", - "FrameworksNetTests-jni-defaults", ], srcs: [ "java/**/*.java", "java/**/*.kt", ], - test_suites: ["device-tests"], jarjar_rules: "jarjar-rules.txt", static_libs: [ "androidx.test.rules", "bouncycastle-repackaged-unbundled", + "core-tests-support", "FrameworksNetCommonTests", "frameworks-base-testutils", "frameworks-net-integration-testutils", @@ -78,7 +78,21 @@ android_test { "android.test.mock", "ServiceConnectivityResources", ], + visibility: ["//packages/modules/Connectivity/tests:__subpackages__"], +} + +android_test { + name: "FrameworksNetTests", + min_sdk_version: "30", + defaults: [ + "framework-connectivity-test-defaults", + "FrameworksNetTests-jni-defaults", + ], + test_suites: ["device-tests"], + static_libs: [ + "FrameworksNetTestsLib", + ], jni_libs: [ "libservice-connectivity", - ], + ] } diff --git a/tests/unit/java/com/android/server/net/NetworkStatsFactoryTest.java b/tests/unit/java/com/android/server/net/NetworkStatsFactoryTest.java index 93599f3c37..40d44468a6 100644 --- a/tests/unit/java/com/android/server/net/NetworkStatsFactoryTest.java +++ b/tests/unit/java/com/android/server/net/NetworkStatsFactoryTest.java @@ -43,10 +43,10 @@ import androidx.test.filters.SmallTest; import androidx.test.runner.AndroidJUnit4; import com.android.frameworks.tests.net.R; -import com.android.internal.util.test.FsUtil; import libcore.io.IoUtils; import libcore.io.Streams; +import libcore.testing.io.TestIoUtils; import org.junit.After; import org.junit.Before; @@ -70,10 +70,7 @@ public class NetworkStatsFactoryTest extends NetworkStatsBaseTest { @Before public void setUp() throws Exception { - mTestProc = new File(InstrumentationRegistry.getContext().getFilesDir(), "proc"); - if (mTestProc.exists()) { - FsUtil.deleteContents(mTestProc); - } + mTestProc = TestIoUtils.createTemporaryDirectory("proc"); // The libandroid_servers which have the native method is not available to // applications. So in order to have a test support native library, the native code @@ -86,10 +83,6 @@ public class NetworkStatsFactoryTest extends NetworkStatsBaseTest { @After public void tearDown() throws Exception { mFactory = null; - - if (mTestProc.exists()) { - FsUtil.deleteContents(mTestProc); - } } @Test diff --git a/tests/unit/java/com/android/server/net/NetworkStatsServiceTest.java b/tests/unit/java/com/android/server/net/NetworkStatsServiceTest.java index 3dd6598290..ee94ae9301 100644 --- a/tests/unit/java/com/android/server/net/NetworkStatsServiceTest.java +++ b/tests/unit/java/com/android/server/net/NetworkStatsServiceTest.java @@ -118,12 +118,13 @@ import androidx.test.runner.AndroidJUnit4; import com.android.internal.util.ArrayUtils; import com.android.internal.util.test.BroadcastInterceptingContext; -import com.android.internal.util.test.FsUtil; import com.android.server.net.NetworkStatsService.NetworkStatsSettings; import com.android.server.net.NetworkStatsService.NetworkStatsSettings.Config; import com.android.testutils.HandlerUtils; import com.android.testutils.TestableNetworkStatsProviderBinder; +import libcore.testing.io.TestIoUtils; + import org.junit.After; import org.junit.Before; import org.junit.Ignore; @@ -238,10 +239,7 @@ public class NetworkStatsServiceTest extends NetworkStatsBaseTest { MockitoAnnotations.initMocks(this); final Context context = InstrumentationRegistry.getContext(); mServiceContext = new MockContext(context); - mStatsDir = context.getFilesDir(); - if (mStatsDir.exists()) { - FsUtil.deleteContents(mStatsDir); - } + mStatsDir = TestIoUtils.createTemporaryDirectory(getClass().getSimpleName()); PowerManager powerManager = (PowerManager) mServiceContext.getSystemService( Context.POWER_SERVICE); @@ -310,8 +308,6 @@ public class NetworkStatsServiceTest extends NetworkStatsBaseTest { @After public void tearDown() throws Exception { - FsUtil.deleteContents(mStatsDir); - mServiceContext = null; mStatsDir = null;