Commit Graph

241 Commits

Author SHA1 Message Date
Paul Duffin
e531db3c9a Add additional overriding methods to signature files
This change adds overriding methods that are essential to compile the
stubs generated from the signature files.

More information and the background for this change is available at
go/add-overriding-one-pager.

Ignore-AOSP-First: Needs to be done in udc-mainline-prod first
Test: m checkapi
Bug: 299366704
Change-Id: Idba307148fd9afa87bfb7e0c89e00d9bd97ec204
2023-10-12 21:56:21 +00:00
Paul Duffin
7bd2d108ea Prepare for keeping concrete overrides of abstract methods
Currently, metalava will discard concrete overrides of abstract methods
from the API signature files which causes problems when attempting to
generate stubs from those files and also discards information that may
be important in API reviews. This change is the first step in the
process of changing that behavior.

This change hard codes the current behavior for discarding the concrete
overrides (`add-additional-overrides=no`) into those signature files
that will (or are likely) to be affected by the change in behavior.
That allows the default behavior to be changed for all the other files
without affecting these.

Follow up changes will remove the hard coding from the signature files
and will update the contents which will include the concrete overrides
of the abstract methods.

More information and the background for this change is available at
go/add-overriding-one-pager.

Test: m checkapi
Bug: 299366704
Change-Id: I52c5bbe2e3bbd36019fe44fcb0b2d19876a5a869
2023-10-10 17:11:25 +01:00
Motomu Utsumi
c6dc826c22 Merge changes If3217916,I86023b1f into main
* changes:
  Add java_defaults for @FlaggedApi handling
  Prepare api directory for udc mainline branch
2023-09-12 08:25:42 +00:00
Motomu Utsumi
c480039309 Merge remote-tracking branch 'remotes/aosp/tmp_libs_net_move' into libs_net_move_merge
frameworks/libs/net/common ->
packages/modules/Connectivity/staticlibs

frameworks/libs/net/client-libs ->
packages/modules/Connectivity/staticlbs/client-libs

Test: TH
Bug: 296014682
Change-Id: I5dc78f0c4653e20312ab3d488b1e69262dbb9840
2023-09-11 11:53:46 +09:00
Motomu Utsumi
310f11acfe Add java_defaults for @FlaggedApi handling
This CL is a preparation to ignore @FlaggedApi API in udc mainline
branch

Bug: 299411828
Test: TH
Change-Id: If3217916b2c37ebaa7b48d8387c69cb078af9550
2023-09-08 14:47:03 +09:00
Motomu Utsumi
5dcd14569e Prepare api directory for udc mainline branch
udc-extended-api directory will be used only in udc mainline branch to
hide @FlaggedApi annotated api which is not supported in that branch

Copied api directories from udc mainline branch.

Bug: 299411828
Test: TH
Change-Id: I86023b1fb3e5f9b4b787a564303e6d2e60f74467
2023-09-08 11:42:21 +09:00
Patrick Rohr
740b1d4ac3 cronet: Move cronet defaults to framework/Android.bp
Since cronet has moved out of the tethering jar.

Test: TH
Change-Id: Ibf476c0afd72863b26188dae6838825e6762976a
2023-05-12 10:15:01 -07:00
Patrick Rohr
2e3e2955b8 cronet: delete option to disable cronet in tm-mainline-prod
With the release cut of the July train and the recent automerger
cutover, tm-mainline-prod is now officially an abandoned branch.

This change deletes (most) infrastructure that was put in place to
disable cronet on tm-mainline-prod.

Test: builds
Change-Id: I078f2114b736a634f08d8f704c19beb2224ef645
2023-05-12 10:15:01 -07:00
Motomu Utsumi
73e2e87d56 Move cronet to framework-connectivity
aosp/2384137 added cronet to framework-tethering.
But framework-connectivity is a better place to put cronet since
cronet does not work on R devices (b/270049141) and
framework-tethering is R+, framework-connectivity is S+.

Followup CLs will move some modules (e.g. CronetJavaPrejarjarDefaults)
that use the branch dependent soong variables to framework/Android.bp

Test: TH
Bug: 278070640
Change-Id: I6bc10116759fb9e083c02147908e53022dab740a
2023-04-19 11:32:12 +09:00
Chidera Olibie
ef0074143d Revert "Fix symbol not found error for hidden apis used by MTS"
This reverts commit 5f44ed3e7e.

Reason for revert: The symbol not found error was a transient build failure.

Change-Id: Iada1a0bc9c2282286c1e3b972de42e6387c901d6
2023-04-13 09:38:39 +00:00
Chidera Olibie
5f44ed3e7e Fix symbol not found error for hidden apis used by MTS
This fails to build on git_master when
depending on `sdk_version:module-current` and
`libs:["framework-tethering-pre-jarjar"].

AIUI, some builds use sdk prebuilts that have compiled out
some of the hidden apis. And thus fails with symbol not found.

So we depend on the impl version of frame-tethering so we always
have access to these hidden apis for MTS.

Test: atestNetHttpCoverageTests
Change-Id: Id68a9051b9f8566f9ca42142669150a6db8b0925
2023-03-23 15:53:11 +00:00
Mohannad Farrag
9c6801f81b Revert^2 "gn2bp: Remove soong_namespace"
8484ec4dcd

Change-Id: I490c09179ea6a20ca5fba83c314b552d360be688
2023-03-23 12:47:47 +00:00
Mohannad Farrag
8484ec4dcd Revert "gn2bp: Remove soong_namespace"
Revert submission 2502135-remove_soong_namespace

Reason for revert: Missing line needs to be added

Reverted changes: /q/submissionid:2502135-remove_soong_namespace

Change-Id: I780a21cf7031e04eb368fda4f93ed16ea032ca8d
2023-03-23 12:36:48 +00:00
Mohannad Farrag
16ba062336 gn2bp: Remove soong_namespace
* This was causing the infra to ignore the modules and masking build errors.

Test: TH
Change-Id: Ic5aa3557353488d5370f4d9c4240954820bfe52b
2023-03-23 12:14:04 +00:00
Stefano Duo
a5e1029101 Merge "Reland "Bundle Cronet's boringssl"" 2023-03-20 13:10:30 +00:00
Stefano Duo
43d89f659f Reland "Bundle Cronet's boringssl"
This relands commit 2cd4ac8725

Merged-In: I903369dbad37b663a39e80149e25b0634386df6d
Change-Id: I018121bf4d02ccc59c89de39e3d1598deb9cf67b
Bug: 274094720
2023-03-17 13:46:25 +00:00
Motomu Utsumi
2441e4aea6 cronet: Update APIs naming
Bug: 265674359
Bug: 273937039
Test: TH
Change-Id: I5fc149396511effdfabd462eba80d1a010ee205a
2023-03-17 09:04:56 +00:00
Dan Stahr
9ed7a339a1 Merge "cronet: Fix AutoBoxing API linter issue" 2023-03-16 15:03:55 +00:00
Motomu Utsumi
5cdd07aa26 cronet: Fix AutoBoxing API linter issue
Bug: 265674359
Test: TH
Change-Id: Id2489a2337ff4d0fd0c30929f9e56d8d027dbbc6
2023-03-15 13:54:17 +00:00
Anton Hansson
57f3d69fd5 Use filegroup defaults for framework sources
There's now a shared defaults module for this kind of filegroup. Use
that and remove the previously duplicated prop.

Bug: 271816210
Test: m
Change-Id: Ia4547984a73179fdfc98c427482dd10246f9722c
2023-03-15 10:36:52 +00:00
Treehugger Robot
853ef56fb6 Merge "Revert "Bundle Cronet's boringssl"" 2023-03-15 00:31:21 +00:00
Patrick Rohr
77c084d1f6 Revert "Bundle Cronet's boringssl"
This reverts commit 2cd4ac8725.

Reason for revert: b/273575026

Change-Id: I5b9886465b8a0f71af469d303a39f670a9b0cb68
2023-03-14 22:45:06 +00:00
Treehugger Robot
944d6a3235 Merge "Cronet API: make UrlRequest.Callback an interface." 2023-03-14 15:42:28 +00:00
Dan Stahr
fcfe8c7d8e Cronet API: make UrlRequest.Callback an interface.
For consistency with other Callback classes, and not to force class
hierarchy on users. The historical "callback completeness" issue can be
mnitigate using interface defaults.

Test: atest CtsNetHttpTestCases
Change-Id: Ibf2aaf4396ab9defdeb4e3882cea6b1b2dbd36ee
Merged-In: Id8fcc13567da8878e848f3c6668d865e77b48146
2023-03-14 05:57:19 +00:00
Stefano Duo
2cd4ac8725 Bundle Cronet's boringssl
Test: m && atest CtsNetHttpTestCases
Change-Id: I3c28a52d60128cf4324eda436c1f6e9fa463108e
2023-03-13 13:28:35 +00:00
Motomu Utsumi
d4a1c63c5d cronet: re-enable lint
Bug: 265674359
Test: TH
Change-Id: I867a66518db0eb9fe446aa28e07d4678f0e3af94
2023-03-10 19:01:18 +09:00
Motomu Utsumi
d229268989 cronet: Hide old newUrlRequestBuilder
Bug: 272009719
Bug: 265674359
Test: TH
Change-Id: If98ea3c45d9e181773f9d5877462d4d3c6097302
2023-03-10 13:38:08 +09:00
Motomu Utsumi
04de61f9e9 Merge "cronet: Make BidirectionalStream.Callback interface" 2023-03-09 16:19:07 +00:00
Treehugger Robot
ba0f26fb86 Merge changes from topics "setter_getter_fix", "use_header_block"
* changes:
  cronet: Use HeaderBlock for getHeaders API
  cronet: Address Setter/Getter related API linter issues
2023-03-09 15:03:34 +00:00
Dan Stahr
78cfe3336b Merge "Expose the getter for idle connection timeout." 2023-03-09 11:33:18 +00:00
Dan Stahr
f63b5df622 Expose the getter for idle connection timeout.
Test: m
Bug: 271423645
API-Coverage-Bug: 251012627
Change-Id: I10862786e83e79ced1c4afd9328d6a158bae7232
2023-03-09 11:32:11 +00:00
Motomu Utsumi
d41fa7b77c cronet: Make BidirectionalStream.Callback interface
Bug: 271423645
Bug: 265674359
Test: TH
Change-Id: I0efb1ad4719a62b1e7ad2c96af0660e212dbb966
2023-03-09 18:33:55 +09:00
Motomu Utsumi
444192ad69 cronet: Use HeaderBlock for getHeaders API
Bug: 265674359
API-Coverage-Bug: 251012627
Test: TH
Change-Id: I03bfafdc6c855f38145eb9d35c1f0ac6934d903f
2023-03-09 18:33:55 +09:00
Motomu Utsumi
00b4a97224 cronet: Address Setter/Getter related API linter issues
Bug: 271423645
Bug: 265674359
Test: TH

Change-Id: Id1628dd7af48a8e079636924b66368db0eb2ec4e
2023-03-09 18:33:52 +09:00
Motomu Utsumi
41b5e83be0 cronet: Fix remaining MissingNullability API linter issue
Bug: 265674359
Test: TH
Change-Id: I7e498d12469a974aa5b4f1d94223e6254e072c29
2023-03-08 11:39:51 +09:00
Chidera Olibie
bff88ee900 cronet: Fix some MissingNullability API lineter issues
Bug: 265674359
Test: th
Change-Id: I710b2cfb0bc358ef7ed24ccaf04c91d56e75ecba
2023-03-08 11:39:31 +09:00
Motomu Utsumi
7c1505915c cronet: Fixed AcronymName API linter issue
Bug: 265674359
Test: TH
Change-Id: Icd786451641f32022587ca95714233d476804e67
2023-03-06 17:15:38 +09:00
Motomu Utsumi
73d869f1b2 cronet: Fix ListenerInterface API linter error
Update UrlRequest.StatusListener to interface

Bug: 265674359
Test: TH
Change-Id: Ib3c0f3dcc42add6e529fc4f36e735ce7ab1fc633
2023-03-06 17:15:38 +09:00
Motomu Utsumi
45a35aec20 cronet: Fix ListenerLast API linter error
This CL adds method with the right signature since there's an internal
caller of old API.
Old API will be removed once the caller has been updated.

Bug: 265674359
Test: TH
Change-Id: I5e614530163d4f05fda0bff3966ba34e7a24d34e
2023-03-06 17:14:04 +09:00
Motomu Utsumi
5505063c1b cronet: Addressed StaticFinalBuilder API linter errors
Bug: 265674359
Test: TH
Change-Id: I767e276413112aa4b1a03e7821c4b3992a2e28c1
2023-03-03 20:02:44 +09:00
Motomu Utsumi
15a147ce7a cronet: Fix BuilderSetStyle API lint errors
Bug: 265674359
Test: TH
API-Coverage-Bug: 251012627
Change-Id: Ie420d553d18c88a2fa654ae41cca8812c863af20
2023-03-03 20:02:44 +09:00
Motomu Utsumi
0ace420204 cronet: Fix MissingNullability API linter errors
Bug: 265674359
Test: TH
Change-Id: Ibaceeaf5f851c0d901c09942a63f038b612818cc
2023-03-03 20:02:41 +09:00
Dan Stahr
3cf0829e71 Expose the socket tagging APIs in Android.
Addressing API Councillor feedback, this is necessary for feature parity
between existing networking APIs and AOSP Cronet.

Test: m
API-Coverage-Bug: 251012627
Change-Id: I462a234dd95aad5a1c09838fbca13b6cf9649cbd
2023-02-17 23:06:34 +00:00
Dan Stahr
35e799efbd Merge "Expose additional Cronet APIs in AOSP." 2023-02-17 23:04:01 +00:00
Dan Stahr
62d57d09c2 Expose additional Cronet APIs in AOSP.
This is required to provide a reasonably feature-comnplete
implementation of current org.chromium.net APIs on top of
android.net.http. The main targets for this change are gRPC (mostly
bidirectional streaming) and prospective early adopters.

Test: m
API-Coverage-Bug: 251012627
Change-Id: I66341581501090641c7eea32de5a5b8453cd97d4
2023-02-17 18:34:59 +00:00
Dan Stahr
722a5f2c5e Merge "Expose the network binding APIs in AOSP." 2023-02-14 14:56:23 +00:00
Dan Stahr
0d2d19a706 Reflect changes from r.android.com/2426234 in the API surface.
HttpEngine.getVersion() can be implemented directly as the API and implementation versions don't differ in AOSP.

Test: m
Change-Id: Ide6881f8978cb8890d585f760cd0d1225a4c2542
2023-02-13 13:00:17 +00:00
Dan Stahr
33a98282e5 Expose the network binding APIs in AOSP.
See the other topic CLs for code changes.

Test: m
API-Coverage-Bug: 251012627
Change-Id: Iad5c500139ce17d834e122e373ca6d0ebee28265
2023-02-09 11:54:38 +00:00
Patrick Rohr
ffdeb180a1 cronet: remove cronet_java_defaults_enabled_srcs
external/cronet has been added to the default manifest in
tm-mainline-prod, so this soong variable is not needed anymore.

Test: TH
Merged-In: I5750d87c9cab0e9d4d213b5a81a2d71cc9610a08
Change-Id: I5750d87c9cab0e9d4d213b5a81a2d71cc9610a08
2023-01-25 01:07:04 -08:00
Dan Stahr
e2be25f6a0 Add Cronet to the Tethering apex.
Test: m
API-Coverage-Bug: 258707653

Change-Id: I2d6401ec719ce265abdb30d6ba8fd94861845197
2023-01-17 08:06:53 -08:00