Commit Graph

8650 Commits

Author SHA1 Message Date
Mark Chien
c39e80e64c Merge "Fix NullPointerException in ConnectivityService" am: fe8af96eba
am: d0e6636019

Change-Id: If0c65bd11f5b76e35f6033fa79a8938f7e47a8e7
2019-06-11 23:43:37 -07:00
Mark Chien
fe8af96eba Merge "Fix NullPointerException in ConnectivityService" 2019-06-12 06:24:41 +00:00
Varun Anand
76427a8db9 [automerger skipped] Merge changes from topic "vpn_data_accnt_revert" am: cec619e577 am: 39f9c1c212 -s ours am: e16dc7932b -s ours
am: 4db31acc50 -s ours
am skip reason: change_id Ibdaad3a4cbf0d8ef1ed53cfab1e454b9b878bae9 with SHA1 4c94d3051d is in history

Change-Id: I476f1bf69f0cceaeadbe6dbdd93b5dfa096e955a
2019-06-11 19:22:30 -07:00
Varun Anand
4db31acc50 [automerger skipped] Merge changes from topic "vpn_data_accnt_revert" am: cec619e577 am: 39f9c1c212 -s ours
am: e16dc7932b -s ours
am skip reason: change_id Ibdaad3a4cbf0d8ef1ed53cfab1e454b9b878bae9 with SHA1 4c94d3051d is in history

Change-Id: I48f805c08d46e03a837173f59f411506c9748951
2019-06-11 19:11:23 -07:00
Varun Anand
e16dc7932b [automerger skipped] Merge changes from topic "vpn_data_accnt_revert" am: cec619e577
am: 39f9c1c212 -s ours
am skip reason: change_id Ibdaad3a4cbf0d8ef1ed53cfab1e454b9b878bae9 with SHA1 4c94d3051d is in history

Change-Id: I47d22d76e3525efc7771e6b514ebadc9b2c75e22
2019-06-11 19:03:04 -07:00
Varun Anand
cec619e577 Merge changes from topic "vpn_data_accnt_revert"
* changes:
  Revert "Take all VPN underlying networks into account when migrating traffic for"
  Revert "NetworkStatsService: Fix getDetailedUidStats to take VPNs into account."
  Revert "Addressing comments for http://ag/7700679."
  Revert "Add one more test for VPN usage stats."
2019-06-12 01:05:01 +00:00
Luke Huang
c23ae79df5 Fix race condition caused by fd reused for DnsResolver
There might be a gap between fd close and fd event listener unregister.
If fd is reused for another query during that gap, it might cause the
query failed with no response since addOnFileDescriptorEventListener
method failed. To fix this problem, we must ensure that fd event
listener is unregistered before fd closing.

Bug: 134310704
Test: atest DnsResolverTest

Merged-In: I443bb11b15845b079ee4370a7797e692e62fa3c8
(cherry picked from commit 07de4cf82ac09f8b9f37afa9eb1b7a44b43b6fe6)

Change-Id: I7041e67d8c906cbf88050e7d94245f8e15dcdbb4
2019-06-11 17:33:39 +00:00
Luke Huang
7520cb0a4d Merge "Fix race condition caused by fd reused for DnsResolver" am: 7c98ae7d01 am: f8a2c15ca1 am: bab0336604
am: 419c039992

Change-Id: I443bb11b15845b079ee4370a7797e692e62fa3c8
2019-06-11 09:08:00 -07:00
Luke Huang
419c039992 Merge "Fix race condition caused by fd reused for DnsResolver" am: 7c98ae7d01 am: f8a2c15ca1
am: bab0336604

Change-Id: I6268edd2b0f98694de7c55f8c6fac844cd5f8635
2019-06-11 08:56:50 -07:00
Luke Huang
bab0336604 Merge "Fix race condition caused by fd reused for DnsResolver" am: 7c98ae7d01
am: f8a2c15ca1

Change-Id: I93e0d4a8664a16f2814763346ff00e6c874efd02
2019-06-11 08:52:18 -07:00
Luke Huang
7c98ae7d01 Merge "Fix race condition caused by fd reused for DnsResolver" 2019-06-11 15:32:17 +00:00
Aaron Huang
ede0d5075b Correct value of supported keepalive count for cellular
Cellular only supports 1 keepalive connection so correct the default
supported value to 1.

Bug: 134037217
Test: - atest FrameworksNetTests
      - atest android.net.cts.ConnectivityManagerTest \
        #testSocketKeepaliveLimitTelephony

Change-Id: Ia3761f2e78d54866bb2e156d58004396bbc8adc3
2019-06-11 22:04:34 +08:00
Luke Huang
6c8b770a98 Fix race condition caused by fd reused for DnsResolver
There might be a gap between fd close and fd event listener unregister.
If fd is reused for another query during that gap, it might cause the
query failed with no response since addOnFileDescriptorEventListener
method failed. To fix this problem, we must ensure that fd event
listener is unregistered before fd closing.

Bug: 134310704
Test: atest DnsResolverTest
Change-Id: Ifb6bd34dc54dcf1c61fe8b87785124df4bc0f410
2019-06-11 15:18:28 +08:00
Varun Anand
048c1c6c32 Revert "Take all VPN underlying networks into account when migrating traffic for"
This reverts commit 612520f544.

Reason for revert: This change has been implicated in 4-way deadlocks as seen in b/134244752.

Bug: 134244752
Change-Id: I2f1839d7776a613ca571af8a542755ddc5fc8760
Merged-In: Ibdaad3a4cbf0d8ef1ed53cfab1e454b9b878bae9
2019-06-10 16:00:48 -07:00
Varun Anand
fb0e689ea5 Revert "NetworkStatsService: Fix getDetailedUidStats to take VPNs into account."
This reverts commit 2af0b66aba.

Reason for revert: This change has been implicated in 4-way deadlocks as seen in b/134244752.

Bug: 134244752
Change-Id: I37f75c2b243ea548a88ef1dae88287405c6ef55f
Merged-In: I0c00e8f0e30cee987b71b561079a97bf09d4dae4
2019-06-10 16:00:38 -07:00
Varun Anand
5701cc30bb Revert "Addressing comments for http://ag/7700679."
This reverts commit 4d83f3e073.

Reason for revert: This change has been implicated in 4-way deadlocks as seen in b/134244752.

Bug: 134244752
Change-Id: I12ab724e2ef8a5c1b42078330ba74713ff86fdd1
Merged-In: I5fbb3443a39a21fc9d96442726cd10d20e8d61cd
2019-06-10 16:00:28 -07:00
Varun Anand
5cc78a32d6 Revert "Add one more test for VPN usage stats."
This reverts commit 635b441ff9.

Reason for revert: This change has been implicated in 4-way deadlocks as seen in b/134244752.

Bug: 134244752
Change-Id: I87ddc0af9ff6fbd9b7afd6d4d24985b9b7205416
Merged-In: I64b48d575f2e6ec4cb7d2d100a859a30af0501dc
2019-06-10 15:59:58 -07:00
Benedict Wong
e04ba52d91 Merge changes from topic "am-9a435ce648dc47d49fc32dc2680fa5b7" into qt-r1-dev-plus-aosp
am: 9456c46f2a

Change-Id: I46aebe74e24d39b7fce0c7eb835e282d59f2c169
2019-06-07 02:50:31 -07:00
Benedict Wong
8923e7c842 Revert "Take all VPN underlying networks into account when migrating traffic for" am: 4c94d3051d am: e3f39c01ba
am: 34244e6820

Change-Id: I5306f76761ce4ae3c8a0ec89b6bdea3e004a1d73
2019-06-07 02:48:37 -07:00
Benedict Wong
9bd6c59fae Revert "NetworkStatsService: Fix getDetailedUidStats to take VPNs into account." am: ebf6303f1d am: 74804a8abd
am: ef26279474

Change-Id: I6e9f5b04bbb036c13eedee6e8d079a48f14f5685
2019-06-07 02:48:33 -07:00
Benedict Wong
44bc14cb14 Revert "Addressing comments for http://ag/7700679." am: a293c0644b am: ec59f5f187
am: 999710a122

Change-Id: If2c644ab4b69f385a6e939ca4760530c196f098d
2019-06-07 02:48:29 -07:00
Benedict Wong
9369d55d3e Revert "Add one more test for VPN usage stats." am: f97132185a am: 0d88389136
am: 1a5a76b3c2

Change-Id: I0f46aeeb024e7ca6e694ba8cdf0893b12dc12c0b
2019-06-07 02:48:23 -07:00
Android Build Merger (Role)
9456c46f2a Merge changes from topic "am-9a435ce648dc47d49fc32dc2680fa5b7" into qt-r1-dev-plus-aosp
* changes:
  Revert "Take all VPN underlying networks into account when migrating traffic for" am: 4c94d3051d am: 3e9726c69c
  Revert "NetworkStatsService: Fix getDetailedUidStats to take VPNs into account." am: ebf6303f1d am: 9b8282b7ba
  Revert "Addressing comments for http://ag/7700679." am: a293c0644b am: 25f881d116
  Revert "Add one more test for VPN usage stats." am: f97132185a am: 469ee82902
2019-06-07 09:44:50 +00:00
Benedict Wong
aabe85318d Revert "Take all VPN underlying networks into account when migrating traffic for" am: 4c94d3051d
am: 3e9726c69c

Change-Id: Ia6598f3550d1dcdd42e04f846ac6cfcce18ce7c1
2019-06-07 02:43:37 -07:00
Benedict Wong
34244e6820 Revert "Take all VPN underlying networks into account when migrating traffic for" am: 4c94d3051d
am: e3f39c01ba

Change-Id: I2695c296398aeb6e5378bba0c89c8ae0b3cd55c6
2019-06-07 02:43:33 -07:00
Benedict Wong
23cfa790ee Revert "NetworkStatsService: Fix getDetailedUidStats to take VPNs into account." am: ebf6303f1d
am: 9b8282b7ba

Change-Id: I799bbaed92dfce20690ae5a8b59241d22e5dc6d6
2019-06-07 02:43:33 -07:00
Benedict Wong
ef26279474 Revert "NetworkStatsService: Fix getDetailedUidStats to take VPNs into account." am: ebf6303f1d
am: 74804a8abd

Change-Id: I0bddf9f7c5bdd39eebec5dc6879336896d076e30
2019-06-07 02:43:29 -07:00
Benedict Wong
19555cb37e Revert "Addressing comments for http://ag/7700679." am: a293c0644b
am: 25f881d116

Change-Id: Ib986a6e4bf6f9a66722c612fcae6f79c1cce91b6
2019-06-07 02:43:29 -07:00
Benedict Wong
999710a122 Revert "Addressing comments for http://ag/7700679." am: a293c0644b
am: ec59f5f187

Change-Id: I5348233da5952b4d6cbbecda12c126f0aa4165ff
2019-06-07 02:43:25 -07:00
Benedict Wong
1afbefd264 Revert "Add one more test for VPN usage stats." am: f97132185a
am: 469ee82902

Change-Id: I5b539a1a3416edf5167483888d932b994fd5007b
2019-06-07 02:43:23 -07:00
Benedict Wong
1a5a76b3c2 Revert "Add one more test for VPN usage stats." am: f97132185a
am: 0d88389136

Change-Id: I9061566f5d747e984fcbc8b3e0e428b75d02820b
2019-06-07 02:43:21 -07:00
Benedict Wong
e3f39c01ba Revert "Take all VPN underlying networks into account when migrating traffic for"
am: 4c94d3051d

Change-Id: Ie9e830962e702c5e66faa7239e6c5037ed3d791d
2019-06-07 02:33:33 -07:00
Benedict Wong
74804a8abd Revert "NetworkStatsService: Fix getDetailedUidStats to take VPNs into account."
am: ebf6303f1d

Change-Id: I9bf180aca56a8b5e2c5262beabac3ceaa9b00315
2019-06-07 02:33:30 -07:00
Benedict Wong
ec59f5f187 Revert "Addressing comments for http://ag/7700679."
am: a293c0644b

Change-Id: I56e7736ced431a5dcd78a6a258abfad09745d25e
2019-06-07 02:33:26 -07:00
Benedict Wong
0d88389136 Revert "Add one more test for VPN usage stats."
am: f97132185a

Change-Id: I72ae3f9575fe954f4f1db4b85b0f19d15448fbbf
2019-06-07 02:33:21 -07:00
Benedict Wong
4c94d3051d Revert "Take all VPN underlying networks into account when migrating traffic for"
This reverts commit 97482de1fd.

Reason for revert: This change has been implicated in 4-way deadlocks as seen in b/134244752.

Bug: 134244752
Change-Id: Ibdaad3a4cbf0d8ef1ed53cfab1e454b9b878bae9
2019-06-07 09:18:01 +00:00
Benedict Wong
ebf6303f1d Revert "NetworkStatsService: Fix getDetailedUidStats to take VPNs into account."
This reverts commit e7094673d5.

Reason for revert: This change has been implicated in 4-way deadlocks as seen in b/134244752.

Bug: 134244752
Change-Id: I0c00e8f0e30cee987b71b561079a97bf09d4dae4
2019-06-07 09:17:47 +00:00
Benedict Wong
a293c0644b Revert "Addressing comments for http://ag/7700679."
This reverts commit 78d5ac4f8f.

Reason for revert: This change has been implicated in 4-way deadlocks as seen in b/134244752.

Bug: 134244752
Change-Id: I5fbb3443a39a21fc9d96442726cd10d20e8d61cd
2019-06-07 09:17:31 +00:00
Benedict Wong
f97132185a Revert "Add one more test for VPN usage stats."
This reverts commit 20204cdf6a.

Reason for revert: This change has been implicated in 4-way deadlocks as seen in b/134244752.

Bug: 134244752
Change-Id: I64b48d575f2e6ec4cb7d2d100a859a30af0501dc
2019-06-07 09:16:48 +00:00
Lorenzo Colitti
9e956ae405 Merge "Don't use a high-priority notification on auto-join." am: b1057f505a am: 3c695c1501 am: 85d0f3084e
am: 745f200a43

Change-Id: I6832e7c3c50a648a5583e36966753f7c4521431a
2019-06-07 01:53:44 -07:00
Lorenzo Colitti
745f200a43 Merge "Don't use a high-priority notification on auto-join." am: b1057f505a am: 3c695c1501
am: 85d0f3084e

Change-Id: I4d1d47a536e93403b5817acecbcdc54045e6cc38
2019-06-07 01:49:39 -07:00
Lorenzo Colitti
85d0f3084e Merge "Don't use a high-priority notification on auto-join." am: b1057f505a
am: 3c695c1501

Change-Id: I2da85c5824c9a13c7f17a5872438dbd6490e7d58
2019-06-07 01:44:55 -07:00
Lorenzo Colitti
b1057f505a Merge "Don't use a high-priority notification on auto-join." 2019-06-07 08:26:38 +00:00
Lorenzo Colitti
8a2348f222 Don't use a high-priority notification on auto-join.
If the device connects to a network automatically and not through
user action, a high-priority notification is intrusive and is
inconsistent with other networking notifications, which are
usually only high priority if the network is manually selected.

Bug: 130766237
Test: see next CL in patch series
Change-Id: I8824f2d1a0efeb6cb75e430ef5159ebce0018779
2019-06-07 12:53:30 +09:00
Lorenzo Colitti
8265d4ae44 Merge "Merge "Don't use a high-priority notification on auto-join." into qt-dev am: 831831c76c am: 3d54a3180b" into qt-r1-dev-plus-aosp
am: f3faaf7cfc

Change-Id: I9fda29c3da0a1ecdc7c5b616e1d0d364b797da71
2019-06-06 04:26:14 -07:00
Lorenzo Colitti
eb21c862ac Merge "Don't use a high-priority notification on auto-join." into qt-dev am: 831831c76c am: 71feb6467f
am: 9a0d860735

Change-Id: I605c0570c51f718e0883f540999670768e0a2a4d
2019-06-06 04:24:44 -07:00
Android Build Merger (Role)
f3faaf7cfc Merge "Merge "Don't use a high-priority notification on auto-join." into qt-dev am: 831831c76c am: 3d54a3180b" into qt-r1-dev-plus-aosp 2019-06-06 11:20:49 +00:00
Lorenzo Colitti
9a0d860735 Merge "Don't use a high-priority notification on auto-join." into qt-dev am: 831831c76c
am: 71feb6467f

Change-Id: I9798141003ab3489af55892d76533f3edac575f7
2019-06-06 04:19:44 -07:00
Lorenzo Colitti
42d668cd71 Merge "Don't use a high-priority notification on auto-join." into qt-dev am: 831831c76c
am: 3d54a3180b

Change-Id: Ia96c03d26ecbe0eb8f7d680b5f876d707127e03b
2019-06-06 04:19:43 -07:00
Lorenzo Colitti
3d54a3180b Merge "Don't use a high-priority notification on auto-join." into qt-dev
am: 831831c76c

Change-Id: Ie18c89162fd9db72a9f77db3737cb9054a5316b7
2019-06-06 04:15:44 -07:00