Commit Graph

65 Commits

Author SHA1 Message Date
Motomu Utsumi
424038fe25 Remove TrafficController
BpfNetMaps now updates bpf map by Java library and does not use
TrafficController.

Bug: 217624062
Test: TH
Change-Id: Id727cf7b79592e913c967156e6e224de338f5f65
2023-11-07 20:25:24 +09:00
Ken Chen
d4e5c76c6e Add dns_helper_unit_test in TEST_MAPPING
Enable test in postsubmit.

According to go/test-mapping-slo-guide, the test needs to meet
postsubmit SLO before adding it to presubmit.

Bug: 288340533
Test: run presubmit
Change-Id: Id5fae55fa0cb7c7b15e183bbea66c7a139360d95
2023-11-01 06:23:09 +08:00
Junyu Lai
6809bbde8e Merge "Respect SkipPresubmit annotation for ConnectivityCoverageTests" into main 2023-10-19 06:58:40 +00:00
Junyu Lai
08a4a873b8 Respect SkipPresubmit annotation for ConnectivityCoverageTests
Follow-up from aosp/2788197, the CL does not work since
SkipPresubmit annotation is not excluded from TEST_MAPPING for
ConnectivityCoverageTests.

Test: TH
Bug: 302325928
Change-Id: Ibfa509aadc9e54da14738714be46abd25f46f3fb
2023-10-19 10:33:03 +08:00
Junyu Lai
86298be5f8 Respect SkipPresubmit annotation for ConnectivityCoverageTests
Follow-up from aosp/2788197, the CL does not work since
SkipPresubmit annotation is not excluded from TEST_MAPPING for
ConnectivityCoverageTests.

Test: TH
Bug: 302325928
Change-Id: I2d953f19e5d5eb5f5d8fdf4faf335d603bae42a0
2023-10-17 17:25:10 +08:00
Xiao Ma
432162d5de Add NetworkStackModuleTest exclusion for ConnectivityCoverageTests in TEST_MAPPING.
testTetherZeroLengthDhcpPacket requires to install both Tethering
and NetworkStack modules, add NetworkStackModuleTest annotation for
ConnectivityCoverageTests running as presubmit to exclude the
testTetherZeroLengthDhcpPacket from presubmit.

Bug: 287798985
Test: TH
Change-Id: I2e21e2623b181e678189ca7758210be1b5409ae7
2023-09-29 15:35:21 +09:00
Chidera Olibie
be9f351f36 [Cronet] NetHttpCoverageTests presubmit SLO fixes
- Adds NetHttpCoverageTests to postsubmit. This would allow us
to run tests with @SkipPresubmit in post submit.
- Don't jarjar com.android.testutil so that the annotation can
still be found by the testrunner.

Bug: b/293843426
Test: th
Change-Id: I9e792d338515acba798092bbc4c615aef2cac47a
2023-08-17 14:52:31 +00:00
Remi NGUYEN VAN
dff0f956e3 Merge "Skip presubmit for flaky tests" into main 2023-07-28 03:38:33 +00:00
Junyu Lai
a6be6cd48a Merge changes from topic "hostsidevpntestflaky" into main
* changes:
  Skip presubmit for flaky tests in FrameworksNetTests due to Out of SLO
  Skip presubmit for flaky tests in HostsideVpnTests due to Out of SLO
2023-07-28 02:06:17 +00:00
Remi NGUYEN VAN
8db52a5987 Skip presubmit for flaky tests
Skip presubmit for tests that have been reported to be >0.5% flaky in
presubmit, or in mainline-presubmit. Tests that only meet that criteria
in mainline-presubmit are only marked as @SkipMainlinePresubmit.

Ensure that the tests are still run in postsubmit so they can be moved
back to presubmit after getting fixed.

Test: TH
Bug: 284534251
Bug: 292174275
Bug: 292173706
Bug: 292174832
Bug: 289879947
Bug: 286701510
Bug: 293239598
Bug: 279846955
Bug: 277567450
Bug: 293239828
Bug: 293240365
Change-Id: I986a1079709057d3210016c50b632fe0f3bff1e2
2023-07-27 02:36:38 +00:00
Treehugger Robot
b868a462fd Merge "[Cronet] skip presubmit for flaky tests" into main 2023-07-26 10:29:40 +00:00
Junyu Lai
b8fc755259 Skip presubmit for flaky tests in FrameworksNetTests due to Out of SLO
Test: TH
Bug: 293233390
Change-Id: Ic1d0d86b3f8dfc8e8122c6b05973fab8b57e52b4
2023-07-26 16:31:46 +08:00
Chidera Olibie
cd038a07fb [Cronet] skip presubmit for flaky tests
Bug: b/293141085
Bug: b/292298108
Test: n/a
Change-Id: Ie7190c0222bd75f3f2df0c5b757b1ab9d0114d77
2023-07-25 20:56:29 +00:00
Mike Yu
cc5dbf951d Exclude some DnsResolverTest tests from some CtsNetTestCasesLatestSdk
Some DnsResolverTest tests are flaky because CtsNetTestCasesLatestSdk
doesn't run with the latest resolv module that has some DoH/DoT fixes.

In this change:
1. The DnsResolverTest tests that do DNS lookups (which probably use
   private DNS) and check the results are marked as DnsResolverModuleTest
2. Exclude those tests from mainline-presubmit CtsNetTestCasesLatestSdk
   that doesn't run with the latest resolv module.

Bug: 279846955
Test: TreeHugger
Change-Id: I86942c22195132a5c96e838619c8bcfaaedc7c99
2023-06-26 07:40:06 +00:00
Xiao Ma
161b70c587 Add NetworkStackModuleTest annotation on the specific test case.
EthernetTetheringTest#testTetherZeroLengthDhcpPacket requires the latest
NetworkStack module, otherwise, the test will fail due to the loss of
the fix. Apply @NetworkStackModuleTest to exclude this testcase from
target test suite CtsTetheringTestLatestSdk.

Bug: 283200648
Test: atest CtsTetheringTestLatestSdk
Change-Id: Iebfb043e2b71427a6feaf90788fe79b6ab6b678d
2023-06-01 18:16:24 +09:00
Mark Chien
f8870fa7af Add CtsTetheringTestLatestSdk into mainline-presubmit
Also test CtsTetheringTestLatestSdk on physical devices
physical SIM in mainline-post

Test: TH

Change-Id: Ia9806c46fbe49282017011ea6ca414e2c58fe00b
2023-05-31 03:50:26 +00:00
Chidera Olibie
356b74cd61 [Cronet] Filter out large tests from presubmit
The presubmit timeout per test is 1min and some of these
largeTests take longer than that.

Test: atest NetHttpCoverageTests
Bug: 267353182
Change-Id: Ic355822482d2072d494ac20e0ad3601de45d1c30
2023-04-03 18:10:01 +00:00
Chidera Olibie
7157837e08 [Cronet] Added NetHttpCoverageTests to presubmit
Removes CtsNetHttpTestCases and NetHttpTests from TEST_MAPPING
since these are part of NetHttpCoverageTests.

Test: atest NetHttpCoverageTests
Bug: 267353182
Change-Id: Idfa6db0fdce254e4552c2541b2471f1c71fe248b
2023-03-30 11:58:39 +00:00
Chidera Olibie
d66799a20c Add NetHttpCoverageTests to mainline presubmit
Mainline presubmit runs on older images. So we need to set:
- min_sdk_version to the minimum sdk we support otherwise
it would default to current
- enforce_default_target_sdk_version since mainline needs
all modules to target the latest sdk

Test: presubmit
Bug: 263294440
Change-Id: I20757b13ab9ab45908dae088c6cb6b0bbc51989d
2023-03-06 08:20:56 +00:00
Yuyang Huang
72bc600be2 Verify the access to the mdnsd socket is blocked from Android U
The untrusted apps should not directly access /dev/socket/mdnsd since
Android U(SDK 34). For untrusted apps built with target SDK 33 or less,
it should still be able to access the mdnsd socket. Fix the mts test
suits from mts-networking to mts-tethering. If the test suits is marked
as mts-networking, it would run in NetworkStack MTS, which isn't really
what is tested in the tests.

Test: atest CtsNetTestCases CtsNetTestCasesMaxTargetSdk33
Bug: 267102290
Change-Id: I851c181fa7489115fb1f335a369830078f5a5c14
2023-02-27 18:40:44 +09:00
Yuyang Huang
5c97d6c987 Revert "Verify the access to the mdnsd socket is blocked from Android U"
This reverts commit a7bc64ffcc.

Reason for revert: breaking tm-mainline-prod testsuit build

Change-Id: I38970fa9281f6f2e884e24680fccc86e269f6d7d
2023-02-24 05:19:52 +00:00
Yuyang Huang
a7bc64ffcc Verify the access to the mdnsd socket is blocked from Android U
The untrusted apps should not directly access /dev/socket/mdnsd since
Android U(SDK 34). For untrusted apps built with target SDK 33 or less,
it should still be able to access the mdnsd socket. Fix the mts test
suits from mts-networking to mts-tethering. If the test suits is marked
as mts-networking, it would run in NetworkStack MTS, which isn't really
what is tested in the tests.

Test: atest CtsNetTestCases CtsNetTestCasesMaxTargetSdk33
Bug: 267102290
Change-Id: Icfbce8bb387df4481eef7fae94ffc38539975ce5
2023-02-20 12:03:30 +09:00
Yuyang Huang
655ef33946 Revert "Verify the access to the mdnsd socket is blocked from Android U"
This reverts commit 7cdfc9099f.

Reason for revert: b/269587343

Change-Id: I8e0fbc7148b14d0df60ecd51cfd83f93986594d1
2023-02-17 02:59:39 +00:00
Yuyang Huang
7cdfc9099f Verify the access to the mdnsd socket is blocked from Android U
The untrusted apps should not directly access /dev/socket/mdnsd since
Android U(SDK 34). For untrusted apps built with target SDK 33 or less,
it should still be able to access the mdnsd socket. Fix the mts test
suits from mts-networking to mts-tethering. If the test suits is marked
as mts-networking, it would run in NetworkStack MTS, which isn't really
what is tested in the tests.

Test: atest CtsNetTestCases CtsNetTestCasesMaxTargetSdk33
Bug: 267102290
Change-Id: I895fe51454cca4ea1273215cf3072e688d97e1b8
2023-02-16 11:17:31 +09:00
Chidera Olibie
d46c92f02c Create NetHttpTests target
This will hold Java classes for cronet's mts

Bug: 267353182
Test: atest NetHttpTests
Change-Id: Id2e2bbe2ce6a19c4fcabd25773d90eb0d0901437
2023-02-08 21:06:11 +00:00
Patrick Rohr
05c1ac573a cronet: merge cronet TEST_MAPPING into connectivity TEST_MAPPING
In addition, we may want an import for external/cronet. (Though that
directory isn't currently available in tm-mainline-prod, so that could
potentially cause issues).

Test: TH
Change-Id: I61734094d3b2f92a2d6d87b221b11ae68e81f270
2023-01-24 02:42:00 -08:00
Remi NGUYEN VAN
7d8006337e Move partial train MTS tests to presubmit
Move the MTS tests that are being run with partial train installs (only
NetworkStack+CaptivePortalLogin installed, or only Tethering installed)
to presubmit.

The tests have been passing in postsubmit.

Test: TH needs to test TEST_MAPPING change
Change-Id: Icc79fb430637e3fbf8e0ef2267aab1842a831915
2022-10-03 12:20:17 +00:00
Lorenzo Colitti
35bf22b6b2 Run networkstack hostside GTS tests on module changes.
Test: TH
Bug: 240650496
Change-Id: Ie813aa31ddfd41bb1699611c5361d90fede9f485
2022-08-10 11:10:25 +09:00
Remi NGUYEN VAN
348bbb0231 Add back compat config for NSD
Add back compat config for RUN_NATIVE_NSD_ONLY_IF_LEGACY_APPS, which was
lost when moving NsdManager to framework-connectivity-t.

This causes NsdManager to start mdnsresponder again when used by apps
with target SDK < 31.

The change also changes the compat ID used, to make sure it does not
conflict with the ID already in use in S and below, when the module is
installed on such a platform. This is the only ChangeId used by
framework-t.

Also add a CtsNetTestCasesMaxTargetSdk30 test to verify that behavior.

Bug: 235355681
Test: atest CtsNetTestCasesMaxTargetSdk30
Change-Id: I7ca6051d0a4ba5aff3e44bece2cbac22eb1be32d
2022-07-27 19:53:25 +09:00
Filip
e6b2a04439 Removing automotive networking tests
Bug: 235717579
Test: manual build
Change-Id: I084343c36d6e370c308994a8de230b07e628f10e
2022-06-25 02:59:18 +00:00
Lorenzo Colitti
e051145522 Merge changes from topic "target-sdk-tests"
* changes:
  Run testExcludedRoutesDisabled only in APKs with target SDK < T.
  Create CtsNetTestCasesMaxTargetSdk31.
2022-06-01 02:53:09 +00:00
Lorenzo Colitti
9e61b82404 Create CtsNetTestCasesMaxTargetSdk31.
This APK will only run tests that require target SDK 31 or below.

Bug: 233553525
Test: test-only change
Change-Id: Ia86187de50107748d8053194d3f7a55b7947412e
2022-05-30 23:36:21 +09:00
Hungming Chen
2e6d107ecc Run libclat_test in presubmit
This has been green for a while.

On postsubmit:
https://android-build.googleplex.com/builds/tests/view?testResultId=TR59428013832586062&invocationId=I95700010046253101

Test: treehugger
Change-Id: I343fa24603df493c785e462a6449eb1129f08c11
2022-05-30 16:21:49 +08:00
Florian Mayer
b52114a29e Remove duplicate postsubmit.
Presubmits already get ran on every postsubmit build.

Bug: 233084498
Change-Id: Ia9af32e8355c37047d810f364379b352699af76d
2022-05-18 21:33:09 +00:00
Paul Hu
206e5f0882 Add CtsNetTestCasesLatestSdk to presubmit
CtsNetTestCases is already run in presubmit, but
CtsNetTestCasesLatestSdk should also pass on HEAD. The only differences
are the target SDK and the shims used (LatestSdk uses latest stable
shims, CtsNetTestCases uses unstable shims). Thus, add
CtsNetTestCasesLatestSdk to presubmit to ensure the tests keep
passing.

Bug: 228286975
Test: atest CtsNetTestCasesLatestSdk
Change-Id: Idaca34fb8a907a6f0017747b47ca89d5306f3ecc
2022-05-16 15:51:46 +08:00
markchien
e59f5e36e5 ConnectivityCoverageTests refactoring
ConnectivityCoverageTests is a combination of several test libs, which
are jarjared differently. It causes duplicated classes not to be counted
for coverage properly. Build the test suite directly and apply jarjar
only once on top of everything.

Bug: 227694415
Test: atest ConnectivityCoverageTests

Change-Id: I4350ebdbf98030944ec3857e1ef67d76f26c3b16
2022-04-06 19:35:28 +09:00
Remi NGUYEN VAN
82ef475266 Merge "Merge EthernetServiceTests into FrameworksNetTests" 2022-04-04 08:02:04 +00:00
Remi NGUYEN VAN
40da62da48 Merge EthernetServiceTests into FrameworksNetTests
As per the TODO, merge EthernetServiceTests into the larger
FrameworksNetTests suite.

Similarly to NetworkStats, NSD or IpSec tests, the tests are also marked
as "non-connectivity-module-test", where "module" actually refers to
modules being built for release (from an S-based branch) today. This is
necessary as the tests and associated code cannot build without T APIs.

Also add FrameworksNetTests to presubmit as non-connectivity-module
tests are not run in presubmit without this.

Test: TH
Merged-In: Id533cdb4ac184b963f570af299dea04754ba88e9
Change-Id: I9950fcb49fdc2217134a59e993941cbe5da0b556
2022-04-01 15:12:18 +09:00
Tyler Wear
b4ab4c3a20 Add connectivity_native_test to Presubmit
Test connectivity_native_test during presubmit.

Bug: 179733303
Change-Id: Iac8e024605b8fe7470925c3606f1eb79fe1421b5
2022-03-25 16:17:30 +00:00
Lorenzo Colitti
85c1765b01 Remove out-of-date comment.
Test: m
Change-Id: I1575c85c382b4fb9e9e3c04b5e70dab55cef4c60
2022-02-21 12:50:11 +09:00
Lorenzo Colitti
b81abf3abe Merge "Run bpf_existence_test in presubmit." 2022-02-21 03:45:33 +00:00
Lorenzo Colitti
98c83d0148 Run bpf_existence_test in presubmit.
This has been green for a while. On S:

https://android-build.googleplex.com/builds/tests/view?invocationId=I42200010019333308&testResultId=TR79227903031586436

On R:
https://android-build.googleplex.com/builds/tests/view?invocationId=I28900010019347533&testResultId=TR73127903058200457

Test: treehugger
Change-Id: Iece7be238e069c7a71f150893a0f6cc155e7b09b
2022-02-18 17:35:04 +09:00
Remi NGUYEN VAN
73da478927 Cleanup and refine connectivity test config
Remove the include for Connectivity/Tethering TEST_MAPPING as there is
no such file in that directory, add comments on ConnectivityModuleTest
usage, and skip the whole NetworkAgentTest on non-connectivity module
MTS runs.

Bug: 218611855
Test: atest CtsNetTestCasesLatestSdk
Change-Id: Id96ab8a5ae631b0c64f20faedd4a0430eb9318d4
2022-02-16 20:34:31 +09:00
Remi NGUYEN VAN
3b81323e4a Fix testing with/without connectivity module
Add missing @ConnectivityModuleTest annotations to tests that cover
functionalities that were introduced in a newer connectivity module
update.

Also add CtsNetTestCasesLatestSdk to postsubmit with only APK modules
installed, and with only the connectivity/tethering module installed.
This can then be moved to presubmit to catch such issues before they are
merged.

While doing this cleanup the TEST_MAPPING file in tests/ and merge its
contents into the root TEST_MAPPING file. This does not change anything
for "postsubmit" tests as they are run independently of changes. It only
causes FrameworksNetIntegrationTests to run in presubmit on any change
in modules/Connectivity/ instead of only on modules/Connectivity/tests/
changes, which is how it should be.

Bug: 218611855
Test: TH needs to test TEST_MAPPING
Change-Id: I26629a35d8c2df3db33180ecc22d49d538ad3b8b
2022-02-16 15:22:30 +09:00
Ken Chen
1647f60d66 [NETD-BPF#19] Mainline part of bpf code from netd
1. Add libnetd_updatable.so in com.android.tethering. The library is
loaded by netd. Currently, it mainly targets on a few functions which
access BPF maps. The functionality may extend in the future.

2. Attach gcroup progs from libnetd_updatable.so.

3. Move (privileged)TagSocket and untagSocket implementation to mainline
module. Combine privilegedTagSocket and untagSocket into a single
function.

4. Split related unit tests from netd_unit_test to
libnetd_updatable_unit_test as well.

Bug: 202086915
Test: cd system/netd; atest
Test: atest TrafficStatsTest NetworkUsageStatsTest

Change-Id: Ib556458103a4cbb643c1342d9b689ac692160de0
2022-01-30 09:51:25 +08:00
Ken Chen
f426b2b287 Rename libnetdbpf to libnetworkstats
Two reason for renaming:
1. Avoid module name collision in sc-mainline-prod branch.
2. The libnetdbpf was misnamed before.

Bug: 202086915
Test: atest libnetworkstats_test FrameworksNetTests
      ConnectivityCoverageTests FrameworksNetSmokeTests
      CtsAppOpsTestCases
Change-Id: I87fcf4b1a9d58780a45743a9aa91b9b936e54266
2022-01-24 11:53:59 +08:00
Wayne Ma
320b95dd6d Fix TEST_MAPPING format
Bug: N/A
Test: m
Change-Id: I16760dcea531ff3a20d53dace7b919c877c378b9
2022-01-23 23:45:11 +08:00
Wayne Ma
7be6bce52d [NETD-TC#13] Make TrafficControllerTest as traffic_controller_unit_test
Delete tagSocket(), privilegedTagSocket() and untagSocket() revelant
test cases since thay are moved out of TrafficController in
aosp/1849156.

Bug: 202086915
Test: atest traffic_controller_unit_test passed
Change-Id: I605577ee4d7076f0c8ad75888a4d32bff90f6104
2022-01-23 21:26:09 +08:00
Hungming Chen
aaa8bd8b74 [CLATJ#2] libclat: Add libclat_test to postsubmit
Add native library libclat test to postsubmit.

Bug: 212345928
Test: atest libclat_test
Change-Id: Ied5e0796b01c384b3eee2d40c0c735859709be33
2022-01-20 22:50:12 +08:00
Lorenzo Colitti
08a2e03231 Merge "Make MTS verify expected BPF programs based on OS version." 2022-01-13 08:14:08 +00:00