Commit Graph

2994 Commits

Author SHA1 Message Date
Patrick Rohr
49ca266409 cronet: delete option to disable cronet in tm-mainline-prod
With the release cut of the July train and the recent automerger
cutover, tm-mainline-prod is now officially an abandoned branch.

This change deletes (most) infrastructure that was put in place to
disable cronet on tm-mainline-prod.

Test: builds
Bug: 278639767
(cherry picked from https://android-review.googlesource.com/q/commit:2e3e2955b8cf7ba181788140dd62b2dd20e7b600)
Merged-In: I078f2114b736a634f08d8f704c19beb2224ef645
Change-Id: I078f2114b736a634f08d8f704c19beb2224ef645
2023-05-26 19:44:22 +00:00
Mark
bcebde7f18 Support SAP and LOHS enabled at the same time
Use type + scope as key to build cached address map so that
SAP (key: TETHERING_WIFI + INTERNET) and LOHS
(key: TETHERING_WIFI + LOCAL) can use different address.

Bug: 233175023
Test: atest TetheringTests
(cherry picked from https://android-review.googlesource.com/q/commit:49649c9aeac709abaeb345f89b6a3a0e5a279435)
Merged-In: I46a4b3ee919628092b7540202a43d79f407b09b6
Change-Id: I46a4b3ee919628092b7540202a43d79f407b09b6
2023-05-26 00:51:20 +00:00
Mark
fb8771ffb5 Allow SAP and LOHS wifi clients exist at the same time
This change store localOnly wifi clients in its own field so that
tethered and localOnly hotspot clients can exist at the same time.

Currently, there are no tethered and localOnly hotspot clients at
the same time because PrivateAddressCoordinator does not support
SAP + LOHS. A follow-up change will be made to allow this.

When both SAP and LOHS are enabled, the SAP and LOHS clients from
TetheringEventCallback#onClientsChanged are all TETHERING_WIFI.
Currently, there is no way for the listeners to distinguish between
SAP and LOHS clients.

Bug: 233175023
Test: atest TetheringTests
(cherry picked from https://android-review.googlesource.com/q/commit:ae3abdfa4be2e4867d4cad70be15f90ad36a0b32)
Merged-In: I01b0a6abb084f7135f7825e0c5303e49c16a4c39
Change-Id: I01b0a6abb084f7135f7825e0c5303e49c16a4c39
2023-05-26 00:51:17 +00:00
Mark
3203664480 Add mDesiredServingState field in BaseServingState
As the suggestion from:
https://android-review.git.corp.google.com/c/platform/packages/modules/Connectivity/+/2489359/9/Tethering/src/android/net/ip/IpServer.java#b1176

Make BaseServingState an abstract class to prevent it from being used
directly. Additionally, move the handleNewPrefixRequest method into
BaseServingState because it is the only class that uses it.
To avoid TetheredState and LocalHotspotState from having to implement
their own enter function, add the mDesiredInterfaceState field to
BaseServingState.

Bug: 233175023
Test: atest TetheringTests
(cherry picked from https://android-review.googlesource.com/q/commit:3ec851ef03d60308a9ecc57557f378a186bb9ac0)
Merged-In: I03269c37e666345efb0c61039a2bb213f223a5a2
Change-Id: I03269c37e666345efb0c61039a2bb213f223a5a2
2023-05-26 00:51:14 +00:00
Mark
7e31c3e495 Fix entitlement recheck fail in U
Starting with U, only explicit intents will be allowed to
launch non-exported internal components. Set package name
to entitlement recheck intent so that the intent could be
delivered to tethering itself successfully.

Bug: 278482046
Test: atest TetheringTests
      manual verify entitlement recheck work in U
(cherry picked from https://android-review.googlesource.com/q/commit:e86fb5ef56be064839a639702bbe376448f08bed)
Merged-In: Ife30eee13fe39509ccb5786d2a76fbb7baa022a8
Change-Id: Ife30eee13fe39509ccb5786d2a76fbb7baa022a8
2023-05-22 02:35:35 +00:00
Bill Yi
1432da3dea Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I09dc2ea724f57754d2ae420f29fca9b5f393d51f
2023-05-16 14:16:17 -07:00
Maciej Żenczykowski
8fa8becc20 Merge "remove inprocess tethering" into udc-dev 2023-05-12 15:44:23 +00:00
TreeHugger Robot
06fb19ac39 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-05-11 05:00:09 +00:00
Bill Yi
7ca03cbed3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic83b9ece97693d43abd2d6930b52007631beb9b0
2023-05-09 23:21:09 -07:00
Remi NGUYEN VAN
fc6693065b Add a dependency object in TetheringConfiguration
Address a TODO in TetheringConfiguration to use a dependency object
instead of static mocking on DeviceConfig.

This avoids TetheringConfiguration dependencies on internal
implementation of DeviceConfigUtils, unblocking changes in
DeviceConfigUtils.

Bug: 279108992
Test: atest TetheringTests
(cherry picked from https://android-review.googlesource.com/q/commit:6d38c018523688004b3d43e6794bec5eba8aee03)
Merged-In: I252eaadff85fa47b894e989b4f2527b00c5dca56
Change-Id: I252eaadff85fa47b894e989b4f2527b00c5dca56
2023-05-10 03:11:06 +00:00
Maciej Żenczykowski
8bcaa2926d remove inprocess tethering
It is just a constant source of bugs, with no real tests,
let's stop pretending this is a supported configuration.

The only tested configuration is out-of-process tethering
updatable apex.

Test: TreeHugger
Bug: 279942846
(cherry picked from https://android-review.googlesource.com/q/commit:7a03c187f596049db96acdae3f00dc6ff5e9e672)
Merged-In: I4b659a3cd32b89a65549b56006b926a5ac755f7b
Change-Id: I4b659a3cd32b89a65549b56006b926a5ac755f7b
2023-05-08 21:15:43 +00:00
KH Shi
e9b91a8847 Merge "Remove TODO comment that was already done" am: bcd62d18f4 am: 50c9d02dec
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2506859

Change-Id: I2f71cdc21bb2657e60a3866d9ee4c4373ee07d3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-24 11:03:29 +00:00
KH Shi
50c9d02dec Merge "Remove TODO comment that was already done" am: bcd62d18f4
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2506859

Change-Id: Ibde6d847a3940e879e2e134bc195bfbb1b7d894e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-24 10:23:26 +00:00
KH Shi
bcd62d18f4 Merge "Remove TODO comment that was already done" 2023-04-24 09:32:56 +00:00
Wayne Ma
bf876863d3 Merge "Add tx_bytes and rx_bytes to UpstreamEvent message" am: 0f8a7aaede am: 80e6edbef7
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2547894

Change-Id: Ib2c266e925baac55341fba93115c6f7468b5dd13
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-21 09:35:29 +00:00
Wayne Ma
80e6edbef7 Merge "Add tx_bytes and rx_bytes to UpstreamEvent message" am: 0f8a7aaede
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2547894

Change-Id: Iec983d98eca81fc9d44ce02a9de786c97f4a1d2e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-21 08:55:39 +00:00
Wayne Ma
b5ee365614 Add tx_bytes and rx_bytes to UpstreamEvent message
This commit adds two new fields, tx_bytes and rx_bytes, to the
UpstreamEvent message. These fields provide information about the
amount of data transferred during the event, which can be useful for
network performance analysis. The current tx/rx usages are always
zero, but it will be updated in a later change to reflect the actual
usage. No changes were made to the existing fields upstream_type and
duration_millis.

Test: atest TetheringMetricsTest
Change-Id: I9e1043b3fff5aa3f548b8696bac7e5bc4271c77c
2023-04-21 11:15:56 +08:00
Maciej Żenczykowski
da7b9a60b0 Merge "switch to classic bpf macros" am: ea07e4dff2 am: ef5a6afcd8
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2480336

Change-Id: Id81641723a3b2109cb63702d06ce3b41e1846e81
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-19 20:34:37 +00:00
Maciej Żenczykowski
ef5a6afcd8 Merge "switch to classic bpf macros" am: ea07e4dff2
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2480336

Change-Id: Ic1f267f32710e2dc31249b0b2b1222577cb8b43c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-19 19:48:49 +00:00
Maciej Żenczykowski
ea07e4dff2 Merge "switch to classic bpf macros" 2023-04-19 19:37:02 +00:00
KH Shi
04798a9f43 Add forwarded stats dump in tethering hardware offload am: 11dee200f9 am: deaeffc7ff
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2546751

Change-Id: I5e620e8cde33249bf5182628fe7c6f79037acc2a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-19 13:05:35 +00:00
KH Shi
deaeffc7ff Add forwarded stats dump in tethering hardware offload am: 11dee200f9
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2546751

Change-Id: I7c5a12cf43ee0935b40abf3e1404b68ace0bacfa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-19 12:02:34 +00:00
KH Shi
11dee200f9 Add forwarded stats dump in tethering hardware offload
The information can be useful for issue debugging, it shows the
accumulated traffic offloaded to the hardware for all upstreams.

$ dumpsys tethering
....
    ForwardedStats:
      rmnet_data2: rx:155686981 tx:799922
....

Bug: b/205762647
Test: adb shell dumpsys tethering
Change-Id: I94143329bdc8ad0eff79c32f329fae95ad3acf8a
2023-04-19 09:14:57 +00:00
Motomu Utsumi
43007b14df Merge "Move cronet to framework-connectivity" am: 8b02a2682a am: ceb9f59803
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2535863

Change-Id: I42bfc86f2f004faddf8ce71ace0ce7c3feb1c895
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-19 07:32:33 +00:00
Motomu Utsumi
ceb9f59803 Merge "Move cronet to framework-connectivity" am: 8b02a2682a
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2535863

Change-Id: I0d22e595a4df67e3cf7c4300714b8e6bf736703d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-19 06:47:45 +00:00
Motomu Utsumi
73e2e87d56 Move cronet to framework-connectivity
aosp/2384137 added cronet to framework-tethering.
But framework-connectivity is a better place to put cronet since
cronet does not work on R devices (b/270049141) and
framework-tethering is R+, framework-connectivity is S+.

Followup CLs will move some modules (e.g. CronetJavaPrejarjarDefaults)
that use the branch dependent soong variables to framework/Android.bp

Test: TH
Bug: 278070640
Change-Id: I6bc10116759fb9e083c02147908e53022dab740a
2023-04-19 11:32:12 +09:00
Maciej Żenczykowski
32b46a4d36 switch to classic bpf macros
Note: this switches
  com_android_networkstack_tethering_util_setupIcmpFilter
over to relative cbpf which in turn is called from:
  com_android_networkstack_tethering_util_setupNaSocket
  com_android_networkstack_tethering_util_setupNsSocket
and tested by p/m/C's:
  TetheringUtilsTest.java - testIcmpSocketFilters()

Test: TreeHugger, atest TetheringUtilsTest
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I22a5ea8f8e3b879a37fe4acd84f61020661eaa71
2023-04-19 00:06:15 +00:00
Maciej Żenczykowski
27b0c5f05d No Tethering Offload HAL is not really an error am: b68f73cc17 am: 78f6d40ee1
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2543091

Change-Id: Ia04592dbee0a3ddb01fadfb63f407e84dbf3fdd4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-18 17:47:03 +00:00
Maciej Żenczykowski
78f6d40ee1 No Tethering Offload HAL is not really an error am: b68f73cc17
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2543091

Change-Id: I0d224ee1640c85e6a233edd6276657225676b3a8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-18 17:15:59 +00:00
Maciej Żenczykowski
b68f73cc17 No Tethering Offload HAL is not really an error
Bug: 278660842
Test: TreeHugger
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I978de7fe33b77b432df183b4c7a1966849f17389
2023-04-18 10:05:13 +00:00
Wayne Ma
ce01780bae Merge "Address comment from aosp/2335004" am: c4732276d4 am: 11271d6ffe
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2516795

Change-Id: Ib25ea0d4a21ad0f553a77dd9f23a7a433d4b9975
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-18 06:07:53 +00:00
Wayne Ma
11271d6ffe Merge "Address comment from aosp/2335004" am: c4732276d4
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2516795

Change-Id: Iba107fff893468dcc63978bc0eab1191be5f330e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-18 05:47:10 +00:00
Wayne Ma
c4732276d4 Merge "Address comment from aosp/2335004" 2023-04-18 05:45:42 +00:00
Chidera Olibie
a32fcf3021 Merge "Revert "Fix symbol not found error for hidden apis used by MTS"" am: 02918132de am: 21c42fcba1 am: 4ae9df4a9b
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2535699

Change-Id: Ib5d6458d3ead010bc45100c427aa2e85510ca963
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-17 10:39:27 +00:00
Chidera Olibie
e27a0aa07e Merge "Revert "Fix symbol not found error for hidden apis used by MTS"" am: 02918132de
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2535699

Change-Id: I12c0a24fc42e8530e6722426fd4ffeb5488ecef4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-17 09:39:33 +00:00
Chidera Olibie
02918132de Merge "Revert "Fix symbol not found error for hidden apis used by MTS"" 2023-04-17 09:14:41 +00:00
Spandan Das
edd7d617d3 Add libnetd_updatable to tethering-module-sdk am: b06f9d6b81 am: 620c48e570
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2523496

Change-Id: I069fefa889bbc2b42ae83412c1498d8abf8f4074
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-13 22:48:42 +00:00
Spandan Das
620c48e570 Add libnetd_updatable to tethering-module-sdk am: b06f9d6b81
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2523496

Change-Id: I1bb0d17ef422eb7e5400fe584cc8b790fe157a27
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-13 22:19:33 +00:00
Spandan Das
b06f9d6b81 Add libnetd_updatable to tethering-module-sdk
System libraries and binaries (e.g. netd) have a dependency on this.
Adding it to the sdk module allows an external snapshotting script
to generate prebuilts stubs of this library and commit them to
prebuilts/module_sdk. This allows minimal branch setup to build against
the apis of libnetd_updatable without checking out its source code.

Bug: 273723791
Test: m tethering-module-sdk
Change-Id: I1f235d86abba2c37ca7d750dea7071227e1346fe
2023-04-13 19:37:48 +00:00
Chidera Olibie
ef0074143d Revert "Fix symbol not found error for hidden apis used by MTS"
This reverts commit 5f44ed3e7e.

Reason for revert: The symbol not found error was a transient build failure.

Change-Id: Iada1a0bc9c2282286c1e3b972de42e6387c901d6
2023-04-13 09:38:39 +00:00
Wayne Ma
fab745c8ae Address comment from aosp/2335004
Bug: 263681262
Test: atest TetheringMetricsTest
Change-Id: I7372b7717a903d43a543f82e31a0439725d02e3a
2023-04-13 10:01:36 +08:00
Treehugger Robot
4aa084a04d Merge "offload.c - adjust bytes for l2 header" am: 58d800c94d am: ed21dcf98a
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2370730

Change-Id: I8ea6feddcda1fca40435e9c87ed4927bbdd1d2f3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-04 20:09:30 +00:00
Treehugger Robot
ed21dcf98a Merge "offload.c - adjust bytes for l2 header" am: 58d800c94d
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2370730

Change-Id: I9704463b731d63112a45938f99176f9639a33777
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-04 19:41:27 +00:00
Maciej Żenczykowski
bab0c1ad95 offload.c - adjust bytes for l2 header
Bug: 263884894
Test: TreeHugger
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I5c7bca4e005302a91368d22b9683db5b16d73b3a
2023-04-04 06:18:28 +00:00
Mark Chien
312b2d07e0 Merge "Fix testPhysicalEthernet failure for physical ethernet device" am: 1a978c0300 am: 52fee67b99
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2514919

Change-Id: I7ff5b797770a8bf02c255a89a91c08551f3d146a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-31 05:32:42 +00:00
Mark Chien
52fee67b99 Merge "Fix testPhysicalEthernet failure for physical ethernet device" am: 1a978c0300
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2514919

Change-Id: I3e105e53564e1c933d70ea6688029b12ecc84bdf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-31 05:18:58 +00:00
Mark Chien
1a978c0300 Merge "Fix testPhysicalEthernet failure for physical ethernet device" 2023-03-31 04:48:33 +00:00
Mark
2040551d18 Fix testPhysicalEthernet failure for physical ethernet device
Other virtual interface ethernet test cases stop ethernet tethering
by deleting the virtual interface. To disable ethernet tethering for
testPhysicalEthernet, call stopTethering explicitly.

Bug: 271380398
Test: atest EtherentTetheringTest
Change-Id: I19a73f63227bab6a60d57d38b17a20a3f3f6c1d4
2023-03-30 09:16:47 +00:00
Treehugger Robot
af51fbf7b1 Merge "TetheringUtils jni - clazz type is jclass" am: ec93ad26a7 am: a78dbcaa16
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2510235

Change-Id: I7336ccea6a4a6856b651373d86a78d49361589ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-28 02:19:05 +00:00
Treehugger Robot
a78dbcaa16 Merge "TetheringUtils jni - clazz type is jclass" am: ec93ad26a7
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2510235

Change-Id: I56f2481ae5d854a0133657566490fa002258f3a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-28 01:52:13 +00:00