* I've investigated turning off `allocator_shims` globally for all of Cronet but
this didn't sound like a good option. allocator_shims are used for security measures,
where sometimes malloc caller forget to check for NULL which happens on oom. allocator_shims would
instantly kill the app instead of depending on the caller to do the validity check.
* The solution here was to manually remove the files and add them to `android` and `glibc` only so allocator_shims
is never compiled for musl.
* Chromium does not support musl so there's no flag for `musl` with allocator_shims.
Test: mma
Change-Id: I2a63b14482a526d06a089647e6f61eea9f1691dc
* Some net files have different include_dirs for protos generated. If the generated file is at A/B/C/src/D/E. The net file expect the
export include dir to be A/B/C/src/
Test: None
Change-Id: I9ebe54094ea6bd2b00645be2bf724889dbcb3c1f
* Remove the python3 calls and replace them with the binary right away.
* Fix action_foreach where sources can be used with {{source_file_name}}
Test: None
Change-Id: I0c2e6fd5135de70339168b9ba5d3b7f3a6866fdc
This reverts commit 379d79d1b0.
Reason for revert: This is breaking the symbols of test library.
Test: None
Change-Id: I3a2e8a9a6ec6ce04038ed34489ece6a1ca053cef
Use a more expressive always_disable function to disable unneeded
third_party dependencies.
Test: Android.bp.swp output is equivalent
Change-Id: Ib21646dfa076fc6f745b7871851744d6ed18eaf3
Due to AOSP's FIPS requirements, AOSP-Cronet's BoringSSL must be
built differently than Chromium-Cronet's BoringSSL. The downstream way
of building BoringSSL is manually mantained in
//external/cronet/third_party/boringssl. So, whenever a target depends
on upstream's boringssl translate that to the downstream custom target.
Test: m && CtsNetHttpTestCases
Change-Id: I34a69de79397c35358745388be433934c203d2b2
* cc_objects are more like source-sets. However, they are not commonly used in AOSP which makes it risky to rely on them.
* Clang native code coverage is not working for cc_objects. Which is needed for the dashboard.
Size Delta to .SO
x64: -0.1MB
x86: 0MB
arm: 0MB
arm64: 0MB
Test: m
Bug: 270027426
Change-Id: I1d74e0293dac91334bded73b0e89465b7af7480c
* The generated desc_*.json files except the compiling(not target) cpu architecture to be x64. which
was an issue because Soong tries to compile for both x32 and x64.
Test: mma
Change-Id: I6be5ed045a25e4020e69bf0157f919f43e68e2c0
* Most of the genrules doesn't affect the JNI/jajar. Only genrules that uses
the following scripts must be jarjared
* //base/android/jni_generator/jni_generator.py
* //base/android/jni_generator/jni_registration_generator.py
Test: None
Change-Id: I2f750e151002b8b21fa2bfd557ad1bbaf5110dff
* The current testing situation for Cronet is dire due to the presence of Cronet on the platform,
As cronet is on the platform, we can't run any unit-tests as they'll link against the platform version
and not the statically-linked cronet. We could avoid this by jarjaring the code however this is impossible.
* It's impossible to jar-jar the code as the C++ code which does JNI expects jar-jared java classes. So the
only possible solution here would be to duplicate the C++ modules, one for testing(with no jarjar) and another
for platform(with jarjar)
* Java sources/actions are not collected for testing modules until a proper solution has been figured out.
Test: None
Change-Id: I20bbad13d83e9e3c7956f028f3f0493b24d0f8bc
* This is a test suite containing 90 unit tests which passes currently on AOSP. using a custom test runner that will be pushed
in upcoming commits
Test: m
Change-Id: Ifa2aa82c5a36ab5b5f9f91dc52dfe803a429a074
* The cmd of the `cc_genrule` is now arch-dependent. So we no longer generate a genrule for each arch.
The propagation of the arch-dependent genrule was broken due to an old if-statement.
Test: m
Change-Id: I4b9b522c429f32fe74d141b00bd856f6c39498d7
* This is a python script that runs a binary on files to generate output files for testing.
* The python script is not really needed as we can run the binary right away.
Test: m
Change-Id: I3be64e7f51380f2c028dec3168c924451076db95
* Aidl `local_include_dirs` was hardcoded. This change should handle extracting the srcs and local include dirs for any
aidl action.
Test: m
Change-Id: I7893dd3897f292f96c1934b192d20b97c26c54cb
nss_certs are only used for host net unittestings.
Android.bp is not affected because the tests are not pulled-in yet.
Test: None
Change-Id: Idef23174d1ecd89c2db90318bfb0cf67a4e70145
They are in cflag_allowlist so don't need to be in default
Bug: 265913942
Test: ./update_resutls.sh
Change-Id: Ia3ed3c1f2d1c784832d01405706eb2f30db725a9
