c51a705a45e37e0d0d777776ad22bc75979d5d62
As the review feedback, this commits address below concern. 1. The TCP keepalive code doesn't use the network parameter at all. This parameter doesn't seem meaningful for TCP keepalives. Starting a TCP keepalive with a non-null underpinned network should throw IllegalArgumentException. 2. The feedback mention that the start version which takes a @NonNull network should throw NPE if the network is null. But Starting a NATT keepalive does not always require a underpinned network. A new IkeSession started from Vpn will also not assign the underpinned network at the initial stage which means underpinned will be null until setNetwork() is called. Thus, the underpinned network should be @Nullable instead. Fix: 271797087 Test: atest FrameworksNetTests Change-Id: Ieb57a7b15a06b2ccd94358b65cc00768c4f62e7d
Description
android_packages_modules_Connectivity
Languages
Java
81.4%
Kotlin
7.7%
AIDL
4.5%
C++
4.5%
C
1.7%
Other
0.1%