82c3470df9
Improve the Validation of IpSecAlgorithm by explicitly checking the length in addition to the truncation length (previously an oversight). In addition, we now check the lengths during un-parceling, which will catch someone maliciously manually building a parcel and passing it, bypassing the checks in the constructor. Bug: 68780091 Test: runtest -x IpSecAlgorithmTest.java Change-Id: I8172762617264d34f47d5144336464510f07a701
99 lines
3.8 KiB
Java
99 lines
3.8 KiB
Java
/*
|
|
* Copyright (C) 2017 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package android.net;
|
|
|
|
import static org.junit.Assert.assertEquals;
|
|
import static org.junit.Assert.assertNull;
|
|
import static org.junit.Assert.assertTrue;
|
|
|
|
import android.os.Parcel;
|
|
import android.support.test.filters.SmallTest;
|
|
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.junit.runners.JUnit4;
|
|
|
|
/** Unit tests for {@link IpSecConfig}. */
|
|
@SmallTest
|
|
@RunWith(JUnit4.class)
|
|
public class IpSecConfigTest {
|
|
|
|
@Test
|
|
public void testDefaults() throws Exception {
|
|
IpSecConfig c = new IpSecConfig();
|
|
assertEquals(IpSecTransform.MODE_TRANSPORT, c.getMode());
|
|
assertEquals("", c.getLocalAddress());
|
|
assertEquals("", c.getRemoteAddress());
|
|
assertNull(c.getNetwork());
|
|
assertEquals(IpSecTransform.ENCAP_NONE, c.getEncapType());
|
|
assertEquals(IpSecManager.INVALID_RESOURCE_ID, c.getEncapSocketResourceId());
|
|
assertEquals(0, c.getEncapRemotePort());
|
|
assertEquals(0, c.getNattKeepaliveInterval());
|
|
for (int direction :
|
|
new int[] {IpSecTransform.DIRECTION_OUT, IpSecTransform.DIRECTION_IN}) {
|
|
assertNull(c.getEncryption(direction));
|
|
assertNull(c.getAuthentication(direction));
|
|
assertEquals(IpSecManager.INVALID_RESOURCE_ID, c.getSpiResourceId(direction));
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void testParcelUnparcel() throws Exception {
|
|
assertParcelingIsLossless(new IpSecConfig());
|
|
|
|
IpSecConfig c = new IpSecConfig();
|
|
c.setMode(IpSecTransform.MODE_TUNNEL);
|
|
c.setLocalAddress("0.0.0.0");
|
|
c.setRemoteAddress("1.2.3.4");
|
|
c.setEncapType(android.system.OsConstants.UDP_ENCAP_ESPINUDP);
|
|
c.setEncapSocketResourceId(7);
|
|
c.setEncapRemotePort(22);
|
|
c.setNattKeepaliveInterval(42);
|
|
c.setEncryption(
|
|
IpSecTransform.DIRECTION_OUT,
|
|
new IpSecAlgorithm(
|
|
IpSecAlgorithm.CRYPT_AES_CBC,
|
|
new byte[] {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 0xA, 0xB, 0xC, 0xD, 0xE, 0xF}));
|
|
c.setAuthentication(
|
|
IpSecTransform.DIRECTION_OUT,
|
|
new IpSecAlgorithm(
|
|
IpSecAlgorithm.AUTH_HMAC_MD5,
|
|
new byte[] {1, 2, 3, 4, 5, 6, 7, 8, 9, 0xA, 0xB, 0xC, 0xD, 0xE, 0xF, 0}));
|
|
c.setSpiResourceId(IpSecTransform.DIRECTION_OUT, 1984);
|
|
c.setEncryption(
|
|
IpSecTransform.DIRECTION_IN,
|
|
new IpSecAlgorithm(
|
|
IpSecAlgorithm.CRYPT_AES_CBC,
|
|
new byte[] {2, 1, 2, 3, 4, 5, 6, 7, 8, 9, 0xA, 0xB, 0xC, 0xD, 0xE, 0xF}));
|
|
c.setAuthentication(
|
|
IpSecTransform.DIRECTION_IN,
|
|
new IpSecAlgorithm(
|
|
IpSecAlgorithm.AUTH_HMAC_MD5,
|
|
new byte[] {1, 2, 3, 4, 5, 6, 7, 8, 9, 0xA, 0xB, 0xC, 0xD, 0xE, 0xF, 1}));
|
|
c.setSpiResourceId(IpSecTransform.DIRECTION_IN, 99);
|
|
assertParcelingIsLossless(c);
|
|
}
|
|
|
|
private void assertParcelingIsLossless(IpSecConfig ci) throws Exception {
|
|
Parcel p = Parcel.obtain();
|
|
ci.writeToParcel(p, 0);
|
|
p.setDataPosition(0);
|
|
IpSecConfig co = IpSecConfig.CREATOR.createFromParcel(p);
|
|
assertTrue(IpSecConfig.equals(co, ci));
|
|
}
|
|
}
|