LineageOS/android_packages_modules_common
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

finalize_sdk.py: add --readme option

Browse Source 
Every time an SDK is finalized, a new version history entry should be
added to prebuilts/sdk/extensions/README.md. Introduce a new option,
--readme <msg>, to better enforce this.

Test: manual: run finalized_sdk.py, inspect README.md
Change-Id: I2257dc2bcf710bb2cb616afa9b8e3d3cb307de8e
This commit is contained in:
Mårten Kongstad
2022-04-26 07:33:51 +00:00
parent b1e623fd6d
commit 018e0d0f54
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tools/finalize_sdk.py
View File

@@ -16,6 +16,7 @@ from pathlib import Path
# See go/fetch_artifact for details on this script. # See go/fetch_artifact for details on this script.
FETCH_ARTIFACT = '/google/data/ro/projects/android/fetch_artifact' FETCH_ARTIFACT = '/google/data/ro/projects/android/fetch_artifact'
COMPAT_REPO = Path('prebuilts/sdk') COMPAT_REPO = Path('prebuilts/sdk')
COMPAT_README = Path('extensions/README.md')
# This build target is used when fetching from a train build (TXXXXXXXX) # This build target is used when fetching from a train build (TXXXXXXXX)
BUILD_TARGET_TRAIN = 'train_build' BUILD_TARGET_TRAIN = 'train_build'
# This build target is used when fetching from a non-train build (XXXXXXXX) # This build target is used when fetching from a non-train build (XXXXXXXX)
@@ -81,6 +82,7 @@ if not os.path.isdir('build/soong'):
parser = argparse.ArgumentParser(description=('Finalize an extension SDK with prebuilts')) parser = argparse.ArgumentParser(description=('Finalize an extension SDK with prebuilts'))
parser.add_argument('-f', '--finalize_sdk', type=int, required=True, help='The numbered SDK to finalize.') parser.add_argument('-f', '--finalize_sdk', type=int, required=True, help='The numbered SDK to finalize.')
parser.add_argument('-b', '--bug', type=int, required=True, help='The bug number to add to the commit message.') parser.add_argument('-b', '--bug', type=int, required=True, help='The bug number to add to the commit message.')
parser.add_argument('-r', '--readme', required=True, help='Version history entry to add to %s' % (COMPAT_REPO / COMPAT_README))
parser.add_argument('-a', '--amend_last_commit', action="store_true", help='Amend current HEAD commits instead of making new commits.') parser.add_argument('-a', '--amend_last_commit', action="store_true", help='Amend current HEAD commits instead of making new commits.')
parser.add_argument('-m', '--modules', action='append', help='Modules to include. Can be provided multiple times, or not at all for all modules.') parser.add_argument('-m', '--modules', action='append', help='Modules to include. Can be provided multiple times, or not at all for all modules.')
parser.add_argument('bid', help='Build server build ID') parser.add_argument('bid', help='Build server build ID')
@@ -132,6 +134,12 @@ print('Running git commit')
for repo in created_dirs: for repo in created_dirs:
git = ['git', '-C', str(repo)] git = ['git', '-C', str(repo)]
subprocess.check_output(git + ['add'] + list(created_dirs[repo])) subprocess.check_output(git + ['add'] + list(created_dirs[repo]))
if repo == COMPAT_REPO:
with open(COMPAT_REPO / COMPAT_README, "a") as readme:
readme.write(f"- {args.finalize_sdk}: {args.readme}\n")
subprocess.check_output(git + ['add', COMPAT_README])
if args.amend_last_commit: if args.amend_last_commit:
change_id = '\n' + re.search(r'Change-Id: [^\\n]+', str(subprocess.check_output(git + ['log', '-1']))).group(0) change_id = '\n' + re.search(r'Change-Id: [^\\n]+', str(subprocess.check_output(git + ['log', '-1']))).group(0)
subprocess.check_output(git + ['commit', '--amend', '-m', commit_message + change_id]) subprocess.check_output(git + ['commit', '--amend', '-m', commit_message + change_id])