From d7a929c3e24b3fb7748e6e2fecd37d7754e8a957 Mon Sep 17 00:00:00 2001
From: Gurpreet Singh <gurpreetgs@google.com>
Date: Wed, 8 Jun 2022 12:05:00 +0000
Subject: [PATCH] Code refactoring to build targets in a separate method.

The build_snapshot method is creating a list of targets and building
them by calling soong.
The code sets some environment variables and builds the targets. This
code can be made reusable by putting it into a separate method and
passing the list of targets to be built. This will avoid code
redundancy.

Bug: 230609867
Test: The code builds on the intellij and successfully builds all the
targets passed to this newly added method.

Change-Id: I22566ca438b2da0cf832416466f4e3affb1c976e
---
 build/mainline_modules_sdks.py | 70 +++++++++++++++++-----------------
 1 file changed, 36 insertions(+), 34 deletions(-)

diff --git a/build/mainline_modules_sdks.py b/build/mainline_modules_sdks.py
index eebb389..c7c1a70 100755
--- a/build/mainline_modules_sdks.py
+++ b/build/mainline_modules_sdks.py
@@ -246,6 +246,41 @@ class SnapshotBuilder:
         return os.path.join(self.mainline_sdks_dir,
                             f"{sdk_name}-{sdk_version}.zip")
 
+    def build_target_paths(self, build_release, sdk_version, target_paths):
+        # Extra environment variables to pass to the build process.
+        extraEnv = {
+            # TODO(ngeoffray): remove SOONG_ALLOW_MISSING_DEPENDENCIES, but
+            #  we currently break without it.
+            "SOONG_ALLOW_MISSING_DEPENDENCIES": "true",
+            # Set SOONG_SDK_SNAPSHOT_USE_SRCJAR to generate .srcjars inside
+            # sdk zip files as expected by prebuilt drop.
+            "SOONG_SDK_SNAPSHOT_USE_SRCJAR": "true",
+            # Set SOONG_SDK_SNAPSHOT_VERSION to generate the appropriately
+            # tagged version of the sdk.
+            "SOONG_SDK_SNAPSHOT_VERSION": sdk_version,
+        }
+        extraEnv.update(build_release.soong_env)
+
+        # Unless explicitly specified in the calling environment set
+        # TARGET_BUILD_VARIANT=user.
+        # This MUST be identical to the TARGET_BUILD_VARIANT used to build
+        # the corresponding APEXes otherwise it could result in different
+        # hidden API flags, see http://b/202398851#comment29 for more info.
+        target_build_variant = os.environ.get("TARGET_BUILD_VARIANT", "user")
+        cmd = [
+                  "build/soong/soong_ui.bash",
+                  "--make-mode",
+                  "--soong-only",
+                  f"TARGET_BUILD_VARIANT={target_build_variant}",
+                  "TARGET_PRODUCT=mainline_sdk",
+                  "MODULE_BUILD_FROM_SOURCE=true",
+                  "out/soong/apex/depsinfo/new-allowed-deps.txt.check",
+              ] + target_paths
+        print_command(extraEnv, cmd)
+        env = os.environ.copy()
+        env.update(extraEnv)
+        self.subprocess_runner.run(cmd, env=env)
+
     def build_snapshots(self, build_release, sdk_versions, modules):
         # Build the SDKs once for each version.
         for sdk_version in sdk_versions:
@@ -257,40 +292,7 @@ class SnapshotBuilder:
                 for sdk in module.sdks
             ]
 
-            # Extra environment variables to pass to the build process.
-            extraEnv = {
-                # TODO(ngeoffray): remove SOONG_ALLOW_MISSING_DEPENDENCIES, but
-                #  we currently break without it.
-                "SOONG_ALLOW_MISSING_DEPENDENCIES": "true",
-                # Set SOONG_SDK_SNAPSHOT_USE_SRCJAR to generate .srcjars inside
-                # sdk zip files as expected by prebuilt drop.
-                "SOONG_SDK_SNAPSHOT_USE_SRCJAR": "true",
-                # Set SOONG_SDK_SNAPSHOT_VERSION to generate the appropriately
-                # tagged version of the sdk.
-                "SOONG_SDK_SNAPSHOT_VERSION": sdk_version,
-            }
-            extraEnv.update(build_release.soong_env)
-
-            # Unless explicitly specified in the calling environment set
-            # TARGET_BUILD_VARIANT=user.
-            # This MUST be identical to the TARGET_BUILD_VARIANT used to build
-            # the corresponding APEXes otherwise it could result in different
-            # hidden API flags, see http://b/202398851#comment29 for more info.
-            target_build_variant = os.environ.get("TARGET_BUILD_VARIANT",
-                                                  "user")
-            cmd = [
-                "build/soong/soong_ui.bash",
-                "--make-mode",
-                "--soong-only",
-                f"TARGET_BUILD_VARIANT={target_build_variant}",
-                "TARGET_PRODUCT=mainline_sdk",
-                "MODULE_BUILD_FROM_SOURCE=true",
-                "out/soong/apex/depsinfo/new-allowed-deps.txt.check",
-            ] + paths
-            print_command(extraEnv, cmd)
-            env = os.environ.copy()
-            env.update(extraEnv)
-            self.subprocess_runner.run(cmd, env=env)
+            self.build_target_paths(build_release, sdk_version, paths)
         return self.mainline_sdks_dir
 
     def build_snapshots_for_build_r(self, build_release, sdk_versions, modules):