From 5d3d866c0204cc40a6cc63807541a7bed9231993 Mon Sep 17 00:00:00 2001 From: Pullakavi Srinivas Date: Wed, 7 Mar 2018 15:15:14 +0530 Subject: [PATCH] hwc2: Avoid overwriting metadata refresh rate. -- Compute sanitized metadata refresh rate. -- Populate display's operating refresh rate to all the layers that donot support metadata refresh rate. Change-Id: Iaf17e4e10da543e110fcf6ba7648d60807069f98 --- sdm/libs/hwc2/hwc_display.cpp | 16 +++++++++++++--- sdm/libs/hwc2/hwc_display.h | 1 + sdm/libs/hwc2/hwc_layers.cpp | 1 + sdm/libs/hwc2/hwc_layers.h | 2 ++ 4 files changed, 17 insertions(+), 3 deletions(-) diff --git a/sdm/libs/hwc2/hwc_display.cpp b/sdm/libs/hwc2/hwc_display.cpp index decbe5cf..8f3a5073 100644 --- a/sdm/libs/hwc2/hwc_display.cpp +++ b/sdm/libs/hwc2/hwc_display.cpp @@ -596,11 +596,10 @@ void HWCDisplay::BuildLayerStack() { layer->src_rect.bottom = layer_buffer->height; } - if (layer->frame_rate > metadata_refresh_rate_) { + if (hwc_layer->HasMetaDataRefreshRate() && layer->frame_rate > metadata_refresh_rate_) { metadata_refresh_rate_ = SanitizeRefreshRate(layer->frame_rate); - } else { - layer->frame_rate = current_refresh_rate_; } + display_rect_ = Union(display_rect_, layer->dst_rect); geometry_changes_ |= hwc_layer->GetGeometryChanges(); @@ -1051,6 +1050,7 @@ HWC2::Error HWCDisplay::PrepareLayerStack(uint32_t *out_num_types, uint32_t *out return HWC2::Error::BadDisplay; } + UpdateRefreshRate(); if (!skip_prepare_) { DisplayError error = display_intf_->Prepare(&layer_stack_); if (error != kErrorNone) { @@ -2135,4 +2135,14 @@ bool HWCDisplay::CanSkipValidate() { return true; } +void HWCDisplay::UpdateRefreshRate() { + for (auto hwc_layer : layer_set_) { + if (hwc_layer->HasMetaDataRefreshRate()) { + continue; + } + auto layer = hwc_layer->GetSDMLayer(); + layer->frame_rate = current_refresh_rate_; + } +} + } // namespace sdm diff --git a/sdm/libs/hwc2/hwc_display.h b/sdm/libs/hwc2/hwc_display.h index f3b15658..fda8f054 100644 --- a/sdm/libs/hwc2/hwc_display.h +++ b/sdm/libs/hwc2/hwc_display.h @@ -311,6 +311,7 @@ class HWCDisplay : public DisplayEventHandler { private: void DumpInputBuffers(void); bool CanSkipValidate(); + void UpdateRefreshRate(); qService::QService *qservice_ = NULL; DisplayClass display_class_; uint32_t geometry_changes_ = GeometryChanges::kNone; diff --git a/sdm/libs/hwc2/hwc_layers.cpp b/sdm/libs/hwc2/hwc_layers.cpp index 4250335e..aa4fb063 100644 --- a/sdm/libs/hwc2/hwc_layers.cpp +++ b/sdm/libs/hwc2/hwc_layers.cpp @@ -735,6 +735,7 @@ DisplayError HWCLayer::SetMetaData(const private_handle_t *pvt_handle, Layer *la uint32_t frame_rate = layer->frame_rate; if (getMetaData(handle, GET_REFRESH_RATE, &fps) == 0) { frame_rate = (fps != 0) ? RoundToStandardFPS(fps) : layer->frame_rate; + has_metadata_refresh_rate_ = true; } int32_t interlaced = 0; diff --git a/sdm/libs/hwc2/hwc_layers.h b/sdm/libs/hwc2/hwc_layers.h index 92267445..41ec6ede 100644 --- a/sdm/libs/hwc2/hwc_layers.h +++ b/sdm/libs/hwc2/hwc_layers.h @@ -99,6 +99,7 @@ class HWCLayer { bool IsScalingPresent(); bool IsRotationPresent(); bool IsNonIntegralSourceCrop() { return non_integral_source_crop_; } + bool HasMetaDataRefreshRate() { return has_metadata_refresh_rate_; } private: Layer *layer_ = nullptr; @@ -115,6 +116,7 @@ class HWCLayer { bool single_buffer_ = false; int buffer_fd_ = -1; bool non_integral_source_crop_ = false; + bool has_metadata_refresh_rate_ = false; // Composition requested by client(SF) HWC2::Composition client_requested_ = HWC2::Composition::Device;