LineageOS/android_vendor_qcom_opensource_display-commonsys-intf
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hwc: Initialize yuvIndices properly.

Browse Source 
memset initializes first 32 bytes of yuvIndices array, so remove
memset initialization and initialize yuvIndices whenever it is required.

Change-Id: I2f01a5c3d07cfbc325f4ca06e3c019616b8a7588
This commit is contained in:
Ramkumar Radhakrishnan
2013-06-20 16:56:56 -07:00
parent 66b2e10907
commit 26bdee916c
1 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
libhwcomposer/hwc_utils.cpp
View File

@@ -379,10 +379,7 @@ void setListStats(hwc_context_t *ctx,
ctx->listStats[dpy].extOnlyLayerIndex = -1; ctx->listStats[dpy].extOnlyLayerIndex = -1;
ctx->listStats[dpy].isDisplayAnimating = false; ctx->listStats[dpy].isDisplayAnimating = false;
//reset yuv indices for (size_t i = 0; i < (size_t)ctx->listStats[dpy].numAppLayers; i++) {
memset(ctx->listStats[dpy].yuvIndices, -1, MAX_NUM_APP_LAYERS);
for (size_t i = 0; i < (list->numHwLayers - 1); i++) {
hwc_layer_1_t const* layer = &list->hwLayers[i]; hwc_layer_1_t const* layer = &list->hwLayers[i];
private_handle_t *hnd = (private_handle_t *)layer->handle; private_handle_t *hnd = (private_handle_t *)layer->handle;
@@ -391,14 +388,14 @@ void setListStats(hwc_context_t *ctx,
ctx->listStats[dpy].isDisplayAnimating = true; ctx->listStats[dpy].isDisplayAnimating = true;
} }
#endif #endif
// continue if i reaches MAX_NUM_APP_LAYERS // continue if number of app layers exceeds MAX_NUM_APP_LAYERS
if(i >= MAX_NUM_APP_LAYERS) if(ctx->listStats[dpy].numAppLayers > MAX_NUM_APP_LAYERS)
continue; continue;
if(list->hwLayers[i].compositionType == HWC_FRAMEBUFFER_TARGET) { //reset yuv indices
continue; ctx->listStats[dpy].yuvIndices[i] = -1;
//We disregard FB being skip for now! so the else if
} else if (isSkipLayer(&list->hwLayers[i])) { if (isSkipLayer(&list->hwLayers[i])) {
ctx->listStats[dpy].skipCount++; ctx->listStats[dpy].skipCount++;
} }