LineageOS/android_vendor_qcom_opensource_display-commonsys-intf
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gralloc1: Do not delete on close

Browse Source 
gralloc device is a singleton, initialize it in the constructor
and never close it.
CRs-Fixed: 2022072
Change-Id: I216c235e05c5e60a85a9bd91825a47200d0ab8b0
This commit is contained in:
Naseer Ahmed
2017-03-16 15:13:34 -04:00
committed by Gerrit - the friendly Code Review server
parent 065cff7db9
commit 7df1e404ad
2 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
libgralloc1/gr_device_impl.cpp
View File

@@ -65,10 +65,10 @@ int gralloc_device_open(const struct hw_module_t *module, const char *name, hw_d
if (!strcmp(name, GRALLOC_HARDWARE_MODULE_ID)) {
gralloc1::GrallocImpl * /*gralloc1_device_t*/ dev = gralloc1::GrallocImpl::GetInstance(module);
*device = reinterpret_cast<hw_device_t *>(dev);
if (dev->Init()) {
if (dev) {
status = 0;
} else {
ALOGE(" Error in opening gralloc1 device");
ALOGE("Fatal error opening gralloc1 device");
}
}
return status;
@@ -83,20 +83,20 @@ GrallocImpl::GrallocImpl(const hw_module_t *module) {
common.close = CloseDevice;
getFunction = GetFunction;
getCapabilities = GetCapabilities;
initalized_ = Init();
}
bool GrallocImpl::Init() {
buf_mgr_ = BufferManager::GetInstance();
return true;
return buf_mgr_ != nullptr;
}
GrallocImpl::~GrallocImpl() {
}
int GrallocImpl::CloseDevice(hw_device_t *device) {
GrallocImpl *impl = reinterpret_cast<GrallocImpl *>(device);
delete impl;
int GrallocImpl::CloseDevice(hw_device_t *device __unused) {
// No-op since the gralloc device is a singleton
return 0;
}