LineageOS/android_vendor_qcom_opensource_display-commonsys
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

DisplayConfig: Initialize service intf before registering service

Browse Source 
Initialize service interface before calling registerservice so as
to avoid register client failure due to null service intf, which
can happen in some corner cases due to race condition.

Change-Id: Id3184845af293cb35cab497c1f7bb90eed561640
This commit is contained in:
Baldev Sahu
2023-05-12 14:40:14 +05:30
committed by Michael Bestas
parent 497f60457e
commit fb3f9ff73e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
services/config/src/device_impl.cpp
View File

@@ -30,7 +30,7 @@
/*
* Changes from Qualcomm Innovation Center are provided under the following license:
*
* Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
* Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted (subject to the limitations in the
@@ -82,13 +82,13 @@ int DeviceImpl::CreateInstance(ClientContext *intf) {
return -1;
}
device_obj_->intf_ = intf;
android::status_t status = device_obj_->IDisplayConfig::registerAsService();
// Unable to start Display Config 2.0 service. Fail Init.
if (status != android::OK) {
device_obj_ = nullptr;
return -1;
}
device_obj_->intf_ = intf;
}
return 0;