LineageOS/android_vendor_qcom_opensource_power
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

power: Simplify display_hint_sent

Browse Source 
Check for whether the display hint has been sent at the start
of the set_interactive() function in the common powerHAL.

This gets rid of the need to replicate the same variable in
every target-specific powerHAL that implements the
set_interactive_override() function.

Change-Id: If7dd11fcb578211f4f83847f9257232c4138ce53
This commit is contained in:
Zhao Wei Liew
2016-06-26 21:29:34 +08:00
committed by Michael Bestas
parent f87f9daa0c
commit ba1c2a36fc
4 changed files with 15 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
power-660.c
View File

@@ -51,7 +51,6 @@
#define MIN_VAL(X, Y) ((X > Y) ? (Y) : (X)) #define MIN_VAL(X, Y) ((X > Y) ? (Y) : (X))
static int display_hint_sent;
static int video_encode_hint_sent; static int video_encode_hint_sent;
static void process_video_encode_hint(void* metadata); static void process_video_encode_hint(void* metadata);
@@ -134,17 +133,13 @@ int set_interactive_override(int on) {
memcpy(resource_values, res, MIN_VAL(sizeof(resource_values), sizeof(res))); memcpy(resource_values, res, MIN_VAL(sizeof(resource_values), sizeof(res)));
num_resources = sizeof(res) / sizeof(res[0]); num_resources = sizeof(res) / sizeof(res[0]);
} }
if (!display_hint_sent) {
perform_hint_action(DISPLAY_STATE_HINT_ID, resource_values, num_resources); perform_hint_action(DISPLAY_STATE_HINT_ID, resource_values, num_resources);
display_hint_sent = 1;
}
} }
} else { } else {
/* Display on. */ /* Display on. */
if (is_interactive_governor(governor)) { if (is_interactive_governor(governor)) {
undo_hint_action(DISPLAY_STATE_HINT_ID); undo_hint_action(DISPLAY_STATE_HINT_ID);
display_hint_sent = 0;
} }
} }
return HINT_HANDLED; return HINT_HANDLED;

5
power-8937.c
View File

@@ -51,7 +51,6 @@
#define MIN_VAL(X, Y) ((X > Y) ? (Y) : (X)) #define MIN_VAL(X, Y) ((X > Y) ? (Y) : (X))
static int display_hint_sent;
static int video_encode_hint_sent; static int video_encode_hint_sent;
static void process_video_encode_hint(void* metadata); static void process_video_encode_hint(void* metadata);
@@ -108,18 +107,14 @@ int set_interactive_override(int on) {
INT_OP_CLUSTER1_TIMER_RATE, BIG_LITTLE_TR_MS_50, INT_OP_CLUSTER1_TIMER_RATE, BIG_LITTLE_TR_MS_50,
INT_OP_NOTIFY_ON_MIGRATE, 0x00}; INT_OP_NOTIFY_ON_MIGRATE, 0x00};
if (!display_hint_sent) {
perform_hint_action(DISPLAY_STATE_HINT_ID, resource_values, perform_hint_action(DISPLAY_STATE_HINT_ID, resource_values,
sizeof(resource_values) / sizeof(resource_values[0])); sizeof(resource_values) / sizeof(resource_values[0]));
display_hint_sent = 1;
}
} /* Perf time rate set for CORE0,CORE4 8952 target*/ } /* Perf time rate set for CORE0,CORE4 8952 target*/
} else { } else {
/* Display on. */ /* Display on. */
if (is_interactive_governor(governor)) { if (is_interactive_governor(governor)) {
undo_hint_action(DISPLAY_STATE_HINT_ID); undo_hint_action(DISPLAY_STATE_HINT_ID);
display_hint_sent = 0;
} }
} }

5
power-8953.c
View File

@@ -51,7 +51,6 @@
#define MIN_VAL(X, Y) ((X > Y) ? (Y) : (X)) #define MIN_VAL(X, Y) ((X > Y) ? (Y) : (X))
static int display_hint_sent;
static int video_encode_hint_sent; static int video_encode_hint_sent;
static void process_video_encode_hint(void* metadata); static void process_video_encode_hint(void* metadata);
@@ -110,18 +109,14 @@ int set_interactive_override(int on) {
0x41424000, 0x41424000,
0x28, 0x28,
}; };
if (!display_hint_sent) {
perform_hint_action(DISPLAY_STATE_HINT_ID, resource_values, perform_hint_action(DISPLAY_STATE_HINT_ID, resource_values,
sizeof(resource_values) / sizeof(resource_values[0])); sizeof(resource_values) / sizeof(resource_values[0]));
display_hint_sent = 1;
}
} /* Perf time rate set for CORE0,CORE4 8952 target*/ } /* Perf time rate set for CORE0,CORE4 8952 target*/
} else { } else {
/* Display on. */ /* Display on. */
if (is_interactive_governor(governor)) { if (is_interactive_governor(governor)) {
undo_hint_action(DISPLAY_STATE_HINT_ID); undo_hint_action(DISPLAY_STATE_HINT_ID);
display_hint_sent = 0;
} }
} }

10
power-common.c
View File

@@ -128,6 +128,8 @@ extern void power_set_interactive_ext(int on);
#endif #endif
void set_interactive(int on) { void set_interactive(int on) {
static int display_hint_sent;
if (!on) { if (!on) {
/* Send Display OFF hint to perf HAL */ /* Send Display OFF hint to perf HAL */
perf_hint_enable(VENDOR_HINT_DISPLAY_OFF, 0); perf_hint_enable(VENDOR_HINT_DISPLAY_OFF, 0);
@@ -136,6 +138,14 @@ void set_interactive(int on) {
perf_hint_enable(VENDOR_HINT_DISPLAY_ON, 0); perf_hint_enable(VENDOR_HINT_DISPLAY_ON, 0);
} }
/**
* Ignore consecutive display-off hints
* Consecutive display-on hints are already handled
*/
if (display_hint_sent && !on) return;
display_hint_sent = !on;
#ifdef SET_INTERACTIVE_EXT #ifdef SET_INTERACTIVE_EXT
power_set_interactive_ext(on); power_set_interactive_ext(on);
#endif #endif