Bugfix for "Pre-validate ChangeGC XIDs": off-by-one in loop index.

Signed-off-by: Jamey Sharp <jamey@minilop.net> Tested-by: Colin Harrison <colin.harrison@virgin.net>
2010-05-14 00:18:14 -07:00
parent 795432d4a9
commit 890f536f8d
1 changed files with 1 additions and 1 deletions
--- a/dix/gc.c
+++ b/dix/gc.c
@@ -439,7 +439,7 @@ ChangeGCXIDs(ClientPtr client, GC *pGC, BITS32 mask, CARD32 *pC32)
 	client->errorValue = mask;
 	return BadValue;
    }
-    for (i = Ones(mask); i; --i)
+    for (i = Ones(mask); i--; )
 	vals[i].val = pC32[i];
    for (i = 0; i < sizeof(xidfields) / sizeof(*xidfields); ++i)
    {