sailfishos/ofono
1
0
Fork 1
mirror of https://github.com/sailfishos/ofono synced 2025-11-27 21:12:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdbus: Fix crash in g_dbus_create_error_valist

Browse Source 
Passing NULL format parameter to vsnprintf results in invalid argument
error on glibc. But with some other libc libraries (musl and uClibc)
this results in dereferencing NULL pointer and crash due to
segmentation fault.
This commit is contained in:
Szymon Janc
2015-04-07 22:07:41 +02:00
committed by Slava Monich
parent 11d6e76f0a
commit 4bae61c83e
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ofono/gdbus/object.c
View File

@@ -1412,7 +1412,10 @@ DBusMessage *g_dbus_create_error_valist(DBusMessage *message, const char *name,
{
char str[1024];
vsnprintf(str, sizeof(str), format, args);
if (format)
vsnprintf(str, sizeof(str), format, args);
else
str[0] = '\0';
return dbus_message_new_error(message, name, str);
}