[rilmodem] Fix for Call Barring commit

Signed-off-by: Miia Leinonen <miia.leinonen@oss.tieto.com>

ofono/Makefile.am

@@ -143,8 +143,7 @@ builtin_sources += drivers/rilmodem/rilmodem.h \
 			drivers/rilmodem/call-forwarding.c \
 			drivers/rilmodem/cbs.c \
 			drivers/rilmodem/oemraw-messages.c \
-			drivers/rilmodem/call-barring.c \
+			drivers/rilmodem/call-barring.c
-			drivers/rilmodem/stk.c
 
 endif
 
@@ -514,7 +513,7 @@ if PROVISION
 builtin_sources += plugins/mbpi.h plugins/mbpi.c
 
 builtin_modules += provision
-builtin_sources += plugins/provision.h plugins/provision.c
+builtin_sources += plugins/provision.c
 
 builtin_modules += cdma_provision
 builtin_sources += plugins/cdma-provision.c
@@ -549,13 +548,6 @@ builtin_sources += plugins/smart-messaging.c
 builtin_modules += push_notification
 builtin_sources += plugins/push-notification.c
 
-if PUSHFORWARDER
-builtin_modules += push_forwarder
-builtin_sources += plugins/push-forwarder.c
-builtin_cflags += @WSPCODEC_CFLAGS@
-builtin_libadd += @WSPCODEC_LIBS@
-endif
-
 builtin_modules += sms_history
 builtin_sources += plugins/smshistory.c
 
@@ -587,7 +579,7 @@ src_ofonod_SOURCES = $(builtin_sources) src/ofono.ver \
 			src/cdma-provision.c src/handsfree.c \
 			src/handsfree-audio.c src/bluetooth.h \
 			src/hfp.h src/sim-mnclength.c src/oemraw.c \
-			src/siri.c src/voicecallagent.c
+			src/siri.c
 
 src_ofonod_LDADD = gdbus/libgdbus-internal.la $(builtin_libadd) \
 			@GLIB_LIBS@ @DBUS_LIBS@ -ldl
@@ -726,9 +718,7 @@ test_scripts = test/backtrace \
 		test/hangup-multiparty \
 		test/hangup-call \
 		test/display-icon \
-		test/set-msisdn \
+		test/set-msisdn
-		test/test-voicecallagent \
-		test/get-network-time
 
 if TEST
 testdir = $(pkglibdir)/test
@@ -749,8 +739,7 @@ unit_tests = unit/test-common unit/test-util unit/test-idmap \
 				unit/test-grilrequest \
 				unit/test-grilreply \
 				unit/test-grilunsol \
-				unit/test-sms unit/test-cdmasms \
+				unit/test-sms unit/test-cdmasms
-				unit/test-provision
 
 noinst_PROGRAMS = $(unit_tests) \
 			unit/test-sms-root unit/test-mux unit/test-caif
@@ -817,13 +806,6 @@ unit_test_grilunsol_SOURCES = unit/test-grilunsol.c $(gril_sources) \
 unit_test_grilunsol_LDADD = @GLIB_LIBS@ -ldl
 unit_objects += $(unit_test_grilunsol_OBJECTS)
 
-unit_test_provision_SOURCES = unit/test-provision.c \
-				plugins/provision.h plugins/provision.c \
-				plugins/mbpi.c src/gprs-provision.c \
-				src/log.c
-unit_test_provision_LDADD = @GLIB_LIBS@ -ldl
-unit_objects += $(unit_test_provision_OBJECTS)
-
 TESTS = $(unit_tests)
 
 if TOOLS

ofono/configure.ac

@@ -192,10 +192,7 @@ AM_CONDITIONAL(BLUETOOTH, test "${enable_bluetooth}" != "no")
 AC_ARG_ENABLE(nettime, AC_HELP_STRING([--disable-nettime],
                                 [disable Nettime plugin]),
                                         [enable_nettime=${enableval}])
-if (test "${enable_nettime}" != "no"); then
+AM_CONDITIONAL(NETTIME, test "${enable_netttime}" != "no")
-	AC_SEARCH_LIBS([clock_gettime], [rt])
-fi
-AM_CONDITIONAL(NETTIME, test "${enable_nettime}" != "no")
 
 AC_ARG_WITH([provisiondb], AC_HELP_STRING([--with-provisiondb=FILE],
 	[location of provision database]), [path_provisiondb=${withval}])
@@ -226,17 +223,6 @@ AC_ARG_ENABLE(datafiles, AC_HELP_STRING([--disable-datafiles],
 					[enable_datafiles=${enableval}])
 AM_CONDITIONAL(DATAFILES, test "${enable_datafiles}" != "no")
 
-AC_ARG_ENABLE(pushforwarder, AC_HELP_STRING([--disable-pushforwarder],
-                                [disable Push Forwarder plugin]),
-                                        [enable_pushforwarder=${enableval}])
-AM_CONDITIONAL(PUSHFORWARDER, test "${enable_pushforwarder}" != "no")
-if (test "${enable_pushforwarder}" != "no"); then
-	PKG_CHECK_MODULES(WSPCODEC, libwspcodec >= 2.0, dummy=yes,
-		AC_MSG_ERROR(WSP decoder is required))
-	AC_SUBST(WSPCODEC_CFLAGS)
-	AC_SUBST(WSPCODEC_LIBS)
-fi
-
 if (test "${prefix}" = "NONE"); then
 	dnl no prefix and no localstatedir, so default to /var
 	if (test "$localstatedir" = '${prefix}/var'); then

ofono/doc/voicecallmanager-api.txt

@@ -198,25 +198,6 @@ Methods		dict GetProperties()
 					 [service].Error.InvalidFormat
 					 [service].Error.Failed
 
-		void RegisterVoicecallAgent(object path)
-
-			Registers an agent which will be called whenever a
-			specific voice call related event requiring a client
-			action occurs. Currently, the only such action is
-			playing a ringback tone locally.
-
-			Possible Errors: [service].Error.InProgress
-					 [service].Error.InvalidArguments
-					 [service].Error.InvalidFormat
-					 [service].Error.Failed
-
-		void UnregisterVoicecallAgent(object path)
-
-			Unregisters an agent.
-
-			Possible Errors: [service].Error.InvalidArguments
-					 [service].Error.Failed
-
 Signals		CallAdded(object path, dict properties)
 
 			Signal that is sent when a new call is added.  It
@@ -276,26 +257,3 @@ Properties	array{string} EmergencyNumbers [readonly]
 			of numbers provided by the specification and any
 			extra numbers provisioned by the carrier on the
 			SIM.
-
-VoiceCallAgent Hierarchy
-========================
-
-Service		unique name
-Interface	org.ofono.VoiceCallAgent
-Object path	freely definable
-
-Methods		void RingbackTone(boolean playTone)
-
-			Requests the client to generate an alerting tone locally
-			(3GPP 24.008; 5.2.1.5). This can happen when an outgoing
-			voice call is made and network is not providing the
-			alerting tone. Value 0 stands for "stop playing ringback
-			tone" and 1 for "start playing ringback tone".
-
-		void Release() [noreply]
-
-			Agent is being released, possibly because of oFono
-			terminating, voicecall interface is being torn down or
-			modem is switched off. No UnregisterVoicecallAgent
-			call is needed.
-

ofono/drivers/rilmodem/call-barring.c

@@ -273,7 +273,7 @@ static int ril_call_barring_probe(struct ofono_call_barring *cb,
 
 	bd->ril = g_ril_clone(ril);
 	ofono_call_barring_set_data(cb, bd);
-	bd->timer_id = g_timeout_add_seconds(2, ril_delayed_register, cb);
+	g_timeout_add_seconds(2, ril_delayed_register, cb);
 
 	return 0;
 }

ofono/drivers/rilmodem/call-forwarding.c

@@ -3,7 +3,7 @@
  *  oFono - Open Source Telephony
  *
  *  Copyright (C) 2008-2011  Intel Corporation. All rights reserved.
- *  Copyright (C) 2013-2014 Jolla Ltd
+ *  Copyright (C) 2013 Jolla Ltd
  *  Contact: Jussi Kangas <jussi.kangas@tieto.com>
  *
  *  This program is free software; you can redistribute it and/or modify
@@ -94,10 +94,11 @@ static void ril_registration(struct ofono_call_forwarding *cf, int type,
 	 * or settings made with bearer class
 	 * BEARER_CLASS_DEFAULT. Design decision: If given
 	 * class is BEARER_CLASS_DEFAULT let's map it to
-	 * BEARER_CLASS_VOICE as per RIL design.
+	 * SERVICE_CLASS_NONE as with it e.g. ./send-ussd '*21*<phone_number>#'
+	 * returns cls:53 i.e. 1+4+16+32 as service class.
 	*/
 	if (cls == BEARER_CLASS_DEFAULT)
-		cls = BEARER_CLASS_VOICE;
+		cls = SERVICE_CLASS_NONE;
 
 	parcel_w_int32(&rilp, cls);
 
@@ -139,10 +140,11 @@ static void ril_send_forward_cmd(struct ofono_call_forwarding *cf,
 	 * or settings made with bearer class
 	 * BEARER_CLASS_DEFAULT. Design decision: If given
 	 * class is BEARER_CLASS_DEFAULT let's map it to
-	 * BEARER_CLASS_VOICE as per RIL design.
+	 * SERVICE_CLASS_NONE as with it e.g. ./send-ussd '*21*<phone_number>#'
+	 * returns cls:53 i.e. 1+4+16+32 as service class.
 	*/
 	if (cls == BEARER_CLASS_DEFAULT)
-		cls = BEARER_CLASS_VOICE;
+		cls = SERVICE_CLASS_NONE;
 
 	parcel_w_int32(&rilp, cls);			/* Service class */
 
@@ -235,10 +237,11 @@ static void ril_query_cb(struct ril_msg *message, gpointer user_data)
 				list[i].phone_number.number[
 					OFONO_MAX_PHONE_NUMBER_LENGTH] = '\0';
 
-			}
 				list[i].time = parcel_r_int32(&rilp);
 			}
 
+		}
+
 		CALLBACK_WITH_SUCCESS(cb, nmbr_of_resps, list, cbd->data);
 
 		g_free(list);
@@ -270,7 +273,8 @@ static void ril_query(struct ofono_call_forwarding *cf, int type, int cls,
 	 * or settings made with bearer class
 	 * BEARER_CLASS_DEFAULT. Design decision: If given
 	 * class is BEARER_CLASS_DEFAULT let's map it to
-	 * SERVICE_CLASS_NONE as per RIL design.
+	 * SERVICE_CLASS_NONE as with it e.g. ./send-ussd '*21*<phone_number>#'
+	 * returns cls:53 i.e. 1+4+16+32 as service class.
 	*/
 	if (cls == BEARER_CLASS_DEFAULT)
 		cls = SERVICE_CLASS_NONE;

ofono/drivers/rilmodem/devinfo.c

@@ -98,7 +98,6 @@ static void query_revision_cb(struct ril_msg *message, gpointer user_data)
 	revision = parcel_r_string(&rilp);
 
 	cb(&error, revision, cbd->data);
-	g_free(revision);
 }
 
 static void ril_query_revision(struct ofono_devinfo *info,
@@ -138,10 +137,10 @@ static void query_serial_cb(struct ril_msg *message, gpointer user_data)
 	}
 
 	ril_util_init_parcel(message, &rilp);
+
 	imei = parcel_r_string(&rilp);
 
 	cb(&error, imei, cbd->data);
-	g_free(imei);
 }
 
 static void ril_query_serial(struct ofono_devinfo *info,

ofono/drivers/rilmodem/gprs.c

@@ -237,7 +237,7 @@ static void ril_data_reg_cb(struct ril_msg *message, gpointer user_data)
 			ofono_gprs_detached_notify(gprs);
 			gd->notified = FALSE;
 			gd->ofono_attached = FALSE;
-		} else if (gd->notified && check_if_ok_to_attach()) {
+		} else if (gd->notified) {
 			DBG("hide the searching state");
 			status = NETWORK_REGISTRATION_STATUS_REGISTERED;
 			ofono_gprs_status_notify(gprs, status);

ofono/drivers/rilmodem/network-registration.c

@@ -573,17 +573,6 @@ error:
 	ofono_error("Unable to notify ofono about nitz");
 }
 
-gboolean check_if_ok_to_attach()
-{
-	int status = NETWORK_REGISTRATION_STATUS_SEARCHING;
-	status = ofono_netreg_get_status(current_netreg);
-	if (status == NETWORK_REGISTRATION_STATUS_SEARCHING
-		|| status == NETWORK_REGISTRATION_STATUS_ROAMING
-		|| status == NETWORK_REGISTRATION_STATUS_REGISTERED)
-		return TRUE;
-	return FALSE;
-}
-
 gint check_if_really_roaming(gint status)
 {
 	const char *net_mcc = ofono_netreg_get_mcc(current_netreg);

ofono/drivers/rilmodem/oemraw-messages.c

@@ -38,18 +38,14 @@
 struct oem_raw_data {
 	GRil *ril;
 	unsigned int vendor;
-	guint timer_id;
 };
 
 static gboolean ril_oemraw_delayed_register(gpointer user_data)
 {
 	struct ofono_oem_raw *raw = user_data;
-	struct oem_raw_data *od = ofono_oem_raw_get_data(raw);
 
 	DBG("");
 
-	od->timer_id = 0;
-
 	ofono_oem_raw_dbus_register(raw);
 	return FALSE; /* This makes the timeout a single-shot */
 }
@@ -68,8 +64,7 @@ static int ril_oemraw_probe(struct ofono_oem_raw *raw, unsigned int vendor,
 	od->vendor = vendor;
 	ofono_oem_raw_set_data(raw, od);
 
-	od->timer_id = g_timeout_add_seconds(1, ril_oemraw_delayed_register,
+	g_timeout_add_seconds(1, ril_oemraw_delayed_register, raw);
-									raw);
 
 	return 0;
 }
@@ -84,9 +79,6 @@ static void ril_oemraw_remove(struct ofono_oem_raw *raw)
 
 	ofono_oem_raw_set_data(raw, NULL);
 
-	if (od->timer_id)
-		g_source_remove(od->timer_id);
-
 	g_ril_unref(od->ril);
 	g_free(od);
 }

ofono/drivers/rilmodem/phonebook.c

@@ -162,18 +162,11 @@ void handle_adn(size_t len, char *name, const unsigned char *msg,
 		char *number, struct pb_file_info *next_file,
 		struct pb_data *pbd)
 {
-	uint8_t name_length;
+	const uint8_t name_length = len - 14;
-	uint8_t number_start;
+	const uint8_t number_start = name_length;
 	uint8_t number_length = 0;
 	uint8_t extension_record = UNUSED;
 	uint8_t i, prefix;
-
-	if (len < 14)
-		return;
-
-	name_length = len - 14;
-	number_start = name_length;
-
 	name = sim_string_to_utf8(msg, name_length);
 	/* Length contains also TON&NPI */
 	number_length = msg[number_start];
@@ -263,19 +256,15 @@ void handle_adn(size_t len, char *name, const unsigned char *msg,
 	}
 }
 
-void handle_sne(size_t len, const unsigned char *msg, char *sne)
+void handle_sne(size_t len,
+				const unsigned char *msg,
+				char *sne)
 {
-	uint8_t sne_length;
+	const uint8_t sne_length = len - 2;
-	uint8_t phonebook_entry_nbr;
+	uint8_t phonebook_entry_nbr = msg[len - 1];
 
 	DBG("SNE");
 
-	if (len < 2)
-		return;
-
-	sne_length = len - 2;
-	phonebook_entry_nbr = msg[len - 1];
-
 	sne = sim_string_to_utf8(msg, sne_length);
 
 	if (sne) {
@@ -310,26 +299,20 @@ void handle_sne(size_t len, const unsigned char *msg, char *sne)
 	}
 }
 
-void handle_anr(size_t len,const unsigned char *msg,char *anr,
+void handle_anr(size_t len,
-			struct pb_file_info *next_file, struct pb_data *pbd)
+				const unsigned char *msg,
+				char *anr,
+				struct pb_file_info *next_file,
+				struct pb_data *pbd)
 {
 	uint8_t number_length = 0;
 	uint8_t extension_record = UNUSED;
 	uint8_t aas_record = UNUSED;
 	uint8_t i, prefix;
-	uint8_t phonebook_entry_nbr;
+	uint8_t phonebook_entry_nbr = msg[len - 1];
 	GSList *list_entry;
 
 	DBG("ANR");
-
-	if (!msg)
-		return;
-
-	if (len < 1)
-		return;
-
-	phonebook_entry_nbr = msg[len - 1];
-
 	if (msg[0] == UNUSED)
 		return;
 
@@ -415,18 +398,11 @@ void handle_anr(size_t len,const unsigned char *msg,char *anr,
 	}
 }
 
-void handle_email(size_t len, const unsigned char *msg, char *email)
+void handle_email(size_t len,
+			const unsigned char *msg,
+			char *email)
 {
-	uint8_t phonebook_entry_nbr;
+	uint8_t phonebook_entry_nbr = msg[len - 1];
-
-	if (!msg)
-		return;
-
-	if (len < 1)
-		return;
-
-	phonebook_entry_nbr = msg[len - 1];
-
 	email = sim_string_to_utf8(msg, len - 2);
 
 	/* GSlist nth counts from 0, PB entries from 1 */
@@ -458,13 +434,13 @@ void handle_email(size_t len, const unsigned char *msg, char *email)
 	}
 }
 
-void handle_ext1(struct pb_data *pbd, const unsigned char *msg,
+void handle_ext1(struct pb_data *pbd,
-			char *ext_number, struct pb_file_info *next_file)
+			const unsigned char *msg,
+			char *ext_number,
+			struct pb_file_info *next_file)
 {
 	uint8_t number_length, i, next_extension_record;
 
-	if (!msg)
-		return;
 
 	number_length = msg[1];
 
@@ -1131,7 +1107,6 @@ static void pb_reference_data_cb(const struct ofono_error *error,
 			pbd->pb_reference_file_info.record_length)) {
 		pbd->pb_reference_file_info.record++;
 		DBG("Next EFpbr record %d", pbd->pb_reference_file_info.record);
-		if (RIL_APPTYPE_SIM == ril_get_app_type()) {
 		pbd->sim_driver->read_file_linear(get_sim(),
 						pbd->pb_reference_file_info.
 						file_id,
@@ -1139,19 +1114,8 @@ static void pb_reference_data_cb(const struct ofono_error *error,
 						record,
 						pbd->pb_reference_file_info.
 						record_length,
-					sim_path, sizeof(sim_path),
+						NULL, 0,
 						pb_reference_data_cb, cbd);
-		} else {
-			pbd->sim_driver->read_file_linear(get_sim(),
-					pbd->pb_reference_file_info.
-					file_id,
-					pbd->pb_reference_file_info.
-					record,
-					pbd->pb_reference_file_info.
-					record_length,
-					usim_path, sizeof(usim_path),
-					pb_reference_data_cb, cbd);
-		}
 	} else {
 		struct pb_file_info *file_info;
 		DBG("All EFpbr records read");

ofono/drivers/rilmodem/radio-settings.c

@@ -35,7 +35,6 @@
 #include <ofono/log.h>
 #include <ofono/modem.h>
 #include <ofono/radio-settings.h>
-#include <ofono/sim.h>
 
 #include "gril.h"
 #include "grilutil.h"
@@ -75,7 +74,7 @@ static void ril_set_rat_mode(struct ofono_radio_settings *rs,
 	int pref = rd->ratmode;
 	int ret = 0;
 
-	ofono_info("setting rat mode:%d", mode);
+	ofono_info("setting rat mode");
 
 	parcel_init(&rilp);
 
@@ -201,17 +200,11 @@ static gboolean ril_get_net_config(struct radio_data *rsd)
 {
 	GKeyFile *keyfile;
 	GError *err = NULL;
-	char *config_path = RIL_CONFIG_DIR;
+	char *path = RIL_CONFIG;
 	char **alreadyset = NULL;
 	gboolean needsconfig = FALSE;
 	gboolean value = FALSE;
-	gboolean found = FALSE;
 	rsd->ratmode = PREF_NET_TYPE_GSM_WCDMA_AUTO;
-	GDir *config_dir;
-	const gchar *config_file;
-	gsize length;
-	gchar **codes = NULL;
-	int i;
 
 	/*
 	 * First we need to check should the LTE be on
@@ -222,45 +215,15 @@ static gboolean ril_get_net_config(struct radio_data *rsd)
 
 	g_key_file_set_list_separator(keyfile, ',');
 
-	config_dir = g_dir_open(config_path, 0, NULL);
+	if (g_key_file_load_from_file(keyfile, path, 0, &err)) {
-	while ((config_file = g_dir_read_name(config_dir)) != NULL) {
-		char *path = g_strconcat(RIL_CONFIG_DIR "/", config_file, NULL);
-		DBG("Rilconfig handling %s", path);
-		gboolean ok = g_key_file_load_from_file(keyfile, path, 0, &err);
-
-		g_free(path);
-		if (!ok) {
-			g_error_free(err);
-			DBG("Rilconfig file skipped");
-			continue;
-		}
-
 		if (g_key_file_has_group(keyfile, LTE_FLAG))
-			found = TRUE;
-		else if (g_key_file_has_group(keyfile, MCC_LIST)) {
-			codes = g_key_file_get_string_list(keyfile, MCC_LIST,
-						MCC_KEY, &length, NULL);
-			if (codes) {
-				for (i = 0; codes[i]; i++) {
-					if (g_str_equal(codes[i],
-						ofono_sim_get_mcc(get_sim()))
-							== TRUE) {
-						found = TRUE;
-						break;
-					}
-				}
-				g_strfreev(codes);
-			}
-		}
-
-		if (found) {
 			rsd->ratmode = PREF_NET_TYPE_LTE_GSM_WCDMA;
-			break;
+	} else {
-		}
+		g_error_free(err);
+		needsconfig = TRUE;
 	}
 
 	g_key_file_free(keyfile);
-	g_dir_close(config_dir);
 
 	/* Then we need to check if it already set */
 

ofono/drivers/rilmodem/rilmodem.c

@@ -56,7 +56,6 @@ static int rilmodem_init(void)
 	ril_call_barring_init();
 	ril_cbs_init();
 	ril_oemraw_init();
-	ril_stk_init();
 
 	return 0;
 }
@@ -81,7 +80,6 @@ static void rilmodem_exit(void)
 	ril_call_barring_exit();
 	ril_cbs_exit();
 	ril_oemraw_exit();
-	ril_stk_exit();
 }
 
 OFONO_PLUGIN_DEFINE(rilmodem, "RIL modem driver", VERSION,

ofono/drivers/rilmodem/rilmodem.h

@@ -28,14 +28,9 @@
 /* Shared constants */
 #define EF_STATUS_INVALIDATED 0
 #define EF_STATUS_VALID 1
-#define RIL_HW_CONFIG "/etc/ofono/ril_subscription.conf"
+#define RIL_CONFIG "/etc/ofono/ril_subscription.conf"
-#define RIL_CONFIG_DIR "/etc/ofono/"
 #define RIL_STORE "rilmodem"
 #define LTE_FLAG "4gOn"
-#define MCC_LIST "MCC-whitelist"
-#define MCC_KEY "Countries"
-#define UI_LANG "/var/lib/environment/nemo/locale.conf"
-#define CFG_LANG "LANG="
 
 extern void ril_devinfo_init(void);
 extern void ril_devinfo_exit(void);
@@ -84,7 +79,3 @@ extern void ril_phonebook_exit(void);
 
 extern void ril_oemraw_init(void);
 extern void ril_oemraw_exit(void);
-
-extern void ril_stk_init(void);
-extern void ril_stk_exit(void);
-

ofono/drivers/rilmodem/rilutil.c

@@ -402,25 +402,13 @@ gboolean ril_util_parse_sim_status(GRil *gril,
 
 		apps[i]->app_type = parcel_r_int32(&rilp);
 		apps[i]->app_state = parcel_r_int32(&rilp);
-
-		/*
-		 * Consider RIL_APPSTATE_ILLEGAL also READY. Even if app state
-		 * is  RIL_APPSTATE_ILLEGAL (-1), ICC operations must be
-		 * permitted. Network access requests will anyway be rejected
-		 * and ME will be in limited service.
-		 */
-		if (apps[i]->app_state == RIL_APPSTATE_ILLEGAL) {
-			DBG("RIL_APPSTATE_ILLEGAL => RIL_APPSTATE_READY");
-			apps[i]->app_state = RIL_APPSTATE_READY;
-		}
-
 		apps[i]->perso_substate = parcel_r_int32(&rilp);
 
 		/* TODO: we need a way to instruct parcel to skip
 		 * a string, without allocating memory...
 		 */
-		apps[i]->aid_str = parcel_r_string(&rilp); /* app ID (AID) */
+		apps[i]->aid_str = parcel_r_string(&rilp); /* application ID (AID) */
-		apps[i]->app_str = parcel_r_string(&rilp); /* app label */
+		apps[i]->app_str = parcel_r_string(&rilp); /* application label */
 
 		apps[i]->pin_replaced = parcel_r_int32(&rilp);
 		apps[i]->pin1_state = parcel_r_int32(&rilp);
@@ -471,8 +459,7 @@ gboolean ril_util_parse_reg(GRil *gril,
 	 *   >= 4 for VOICE_REG reply
 	 *   >= 5 for DATA_REG reply
 	 */
-	tmp = parcel_r_int32(&rilp);
+	if ((tmp = parcel_r_int32(&rilp)) < 4) {
-	if (tmp < 4) {
 		DBG("Size of response array is too small: %d", tmp);
 		goto error;
 	}
@@ -495,12 +482,10 @@ gboolean ril_util_parse_reg(GRil *gril,
 	 * voice & data response.
 	 */
 	if (tmp--) {
-		/* TODO: different use for CDMA */
+		sreason = parcel_r_string(&rilp);        /* TODO: different use for CDMA */
-		sreason = parcel_r_string(&rilp);
 
 		if (tmp--) {
-			/* TODO: different use for CDMA */
+			smax = parcel_r_string(&rilp);           /* TODO: different use for CDMA */
-			smax = parcel_r_string(&rilp);
 
 			if (smax && max_calls)
 				*max_calls = atoi(smax);
@@ -674,8 +659,7 @@ gint ril_util_get_signal(GRil *gril, struct ril_msg *message)
 	return -1;
 }
 
-void ril_util_free_sim_apps(struct sim_app **apps, guint num_apps)
+void ril_util_free_sim_apps(struct sim_app **apps, guint num_apps) {
-{
 	guint i;
 
 	for (i = 0; i < num_apps; i++) {

ofono/drivers/rilmodem/rilutil.h

@@ -62,6 +62,29 @@ enum at_util_charset {
 	RIL_UTIL_CHARSET_8859_H =	0x10000,
 };
 
+/* TODO: consider moving these to ril_constants.h */
+enum app_state {
+	APPSTATE_UNKNOWN,
+	APPSTATE_DETECTED,
+	APPSTATE_PIN,
+	APPSTATE_PUK,
+	APPSTATE_SUBSCRIPTION_PERSO,
+	APPSTATE_READY,
+};
+
+enum perso_state {
+	PERSOSUBSTATE_SIM_NETWORK = 3,
+	PERSOSUBSTATE_SIM_NETWORK_SUBSET,
+	PERSOSUBSTATE_SIM_CORPORATE,
+	PERSOSUBSTATE_SIM_SERVICE_PROVIDER,
+	PERSOSUBSTATE_SIM_SIM,
+	PERSOSUBSTATE_SIM_NETWORK_PUK,
+	PERSOSUBSTATE_SIM_NETWORK_SUBSET_PUK,
+	PERSOSUBSTATE_SIM_CORPORATE_PUK,
+	PERSOSUBSTATE_SIM_SERVICE_PROVIDER_PUK,
+	PERSOSUBSTATE_SIM_SIM_PUK,
+};
+
 #define MAX_UICC_APPS 16
 
 struct sim_status {
@@ -123,8 +146,6 @@ struct ofono_sim *get_sim();
 
 gint check_if_really_roaming(gint status);
 
-gboolean check_if_ok_to_attach();
-
 void ril_util_free_sim_apps(struct sim_app **apps, guint num_apps);
 
 struct cb_data {

ofono/drivers/rilmodem/sim.c

@@ -4,7 +4,6 @@
  *
  *  Copyright (C) 2008-2011  Intel Corporation. All rights reserved.
  *  Copyright (C) 2013 Canonical, Ltd. All rights reserved.
- *  Copyright (C) 2014 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -557,42 +556,42 @@ static void configure_active_app(struct sim_data *sd,
 
 	DBG("setting aid_str (AID) to: %s", sd->aid_str);
 	switch (app->app_state) {
-	case RIL_APPSTATE_PIN:
+	case APPSTATE_PIN:
 		sd->passwd_state = OFONO_SIM_PASSWORD_SIM_PIN;
 		break;
-	case RIL_APPSTATE_PUK:
+	case APPSTATE_PUK:
 		sd->passwd_state = OFONO_SIM_PASSWORD_SIM_PUK;
 		break;
-	case RIL_APPSTATE_SUBSCRIPTION_PERSO:
+	case APPSTATE_SUBSCRIPTION_PERSO:
 		switch (app->perso_substate) {
-		case RIL_PERSOSUBSTATE_SIM_NETWORK:
+		case PERSOSUBSTATE_SIM_NETWORK:
 			sd->passwd_state = OFONO_SIM_PASSWORD_PHNET_PIN;
 			break;
-		case RIL_PERSOSUBSTATE_SIM_NETWORK_SUBSET:
+		case PERSOSUBSTATE_SIM_NETWORK_SUBSET:
 			sd->passwd_state = OFONO_SIM_PASSWORD_PHNETSUB_PIN;
 			break;
-		case RIL_PERSOSUBSTATE_SIM_CORPORATE:
+		case PERSOSUBSTATE_SIM_CORPORATE:
 			sd->passwd_state = OFONO_SIM_PASSWORD_PHCORP_PIN;
 			break;
-		case RIL_PERSOSUBSTATE_SIM_SERVICE_PROVIDER:
+		case PERSOSUBSTATE_SIM_SERVICE_PROVIDER:
 			sd->passwd_state = OFONO_SIM_PASSWORD_PHSP_PIN;
 			break;
-		case RIL_PERSOSUBSTATE_SIM_SIM:
+		case PERSOSUBSTATE_SIM_SIM:
 			sd->passwd_state = OFONO_SIM_PASSWORD_PHSIM_PIN;
 			break;
-		case RIL_PERSOSUBSTATE_SIM_NETWORK_PUK:
+		case PERSOSUBSTATE_SIM_NETWORK_PUK:
 			sd->passwd_state = OFONO_SIM_PASSWORD_PHNET_PUK;
 			break;
-		case RIL_PERSOSUBSTATE_SIM_NETWORK_SUBSET_PUK:
+		case PERSOSUBSTATE_SIM_NETWORK_SUBSET_PUK:
 			sd->passwd_state = OFONO_SIM_PASSWORD_PHNETSUB_PUK;
 			break;
-		case RIL_PERSOSUBSTATE_SIM_CORPORATE_PUK:
+		case PERSOSUBSTATE_SIM_CORPORATE_PUK:
 			sd->passwd_state = OFONO_SIM_PASSWORD_PHCORP_PUK;
 			break;
-		case RIL_PERSOSUBSTATE_SIM_SERVICE_PROVIDER_PUK:
+		case PERSOSUBSTATE_SIM_SERVICE_PROVIDER_PUK:
 			sd->passwd_state = OFONO_SIM_PASSWORD_PHSP_PUK;
 			break;
-		case RIL_PERSOSUBSTATE_SIM_SIM_PUK:
+		case PERSOSUBSTATE_SIM_SIM_PUK:
 			sd->passwd_state = OFONO_SIM_PASSWORD_PHFSIM_PUK;
 			break;
 		default:
@@ -600,11 +599,11 @@ static void configure_active_app(struct sim_data *sd,
 			break;
 		};
 		break;
-	case RIL_APPSTATE_READY:
+	case APPSTATE_READY:
 		sd->passwd_state = OFONO_SIM_PASSWORD_NONE;
 		break;
-	case RIL_APPSTATE_UNKNOWN:
+	case APPSTATE_UNKNOWN:
-	case RIL_APPSTATE_DETECTED:
+	case APPSTATE_DETECTED:
 	default:
 		sd->passwd_state = OFONO_SIM_PASSWORD_INVALID;
 		break;
@@ -793,8 +792,10 @@ static void ril_pin_change_state_cb(struct ril_msg *message, gpointer user_data)
 	retries[passwd_type] = retry_count;
 	sd->retries[passwd_type] = retries[passwd_type];
 
-	DBG("result=%d passwd_type=%d retry_count=%d",
+	/*
-		message->error, passwd_type, retry_count);
+	 * TODO: re-bfactor to not use macro for FAILURE; doesn't return error!
+	 */
+
 	if (message->error == RIL_E_SUCCESS) {
 		CALLBACK_WITH_SUCCESS(cb, cbd->data);
 		g_ril_print_response_no_args(sd->ril, message);
@@ -843,53 +844,11 @@ static void ril_pin_send(struct ofono_sim *sim, const char *passwd,
 	}
 }
 
-static int ril_perso_change_state(struct ofono_sim *sim,
-				enum ofono_sim_password_type passwd_type,
-				int enable, const char *passwd,
-				ofono_sim_lock_unlock_cb_t cb, void *data)
-{
-	struct sim_data *sd = ofono_sim_get_data(sim);
-	struct cb_data *cbd = cb_data_new(cb, data);
-	struct parcel rilp;
-	int request = 0;
-	int ret = 0;
-	sd->passwd_type = passwd_type;
-	cbd->user = sd;
-
-	parcel_init(&rilp);
-
-	switch (passwd_type) {
-	case OFONO_SIM_PASSWORD_PHNET_PIN:
-		if (enable) {
-			DBG("Not supported, enable=%d", enable);
-			goto end;
-		}
-		request = RIL_REQUEST_ENTER_NETWORK_DEPERSONALIZATION;
-		parcel_w_int32(&rilp, RIL_PERSOSUBSTATE_SIM_NETWORK);
-		parcel_w_string(&rilp, (char *) passwd);
-		break;
-	default:
-		DBG("Not supported, type=%d", passwd_type);
-		goto end;
-	}
-
-	ret = g_ril_send(sd->ril, request,
-				rilp.data, rilp.size, ril_pin_change_state_cb,
-				cbd, g_free);
-
-	g_ril_print_request(sd->ril, ret, request);
-
-end:
-	parcel_free(&rilp);
-	return ret;
-}
-
 static void ril_pin_change_state(struct ofono_sim *sim,
 				enum ofono_sim_password_type passwd_type,
 				int enable, const char *passwd,
 				ofono_sim_lock_unlock_cb_t cb, void *data)
 {
-	DBG("passwd_type=%d", passwd_type);
 	struct sim_data *sd = ofono_sim_get_data(sim);
 	struct cb_data *cbd = cb_data_new(cb, data);
 	struct parcel rilp;
@@ -927,9 +886,9 @@ static void ril_pin_change_state(struct ofono_sim *sim,
 		parcel_w_string(&rilp, "P2");
 		break;
 	case OFONO_SIM_PASSWORD_PHNET_PIN:
-		ret = ril_perso_change_state(sim, passwd_type, enable, passwd,
+		g_ril_append_print_buf(sd->ril, "(PN,");
-						cb, data);
+		parcel_w_string(&rilp, "PN");
-		goto end;
+		break;
 	case OFONO_SIM_PASSWORD_PHNETSUB_PIN:
 		g_ril_append_print_buf(sd->ril, "(PU,");
 		parcel_w_string(&rilp, "PU");
@@ -943,7 +902,8 @@ static void ril_pin_change_state(struct ofono_sim *sim,
 		parcel_w_string(&rilp, "PC");
 		break;
 	default:
-		goto end;
+		CALLBACK_WITH_FAILURE(cb, data);
+		return;
 	}
 
 	if (enable)
@@ -970,7 +930,6 @@ static void ril_pin_change_state(struct ofono_sim *sim,
 
 	g_ril_print_request(sd->ril, ret, request);
 
-end:
 	parcel_free(&rilp);
 
 	if (ret <= 0) {
@@ -1133,8 +1092,6 @@ static void ril_sim_remove(struct ofono_sim *sim)
 	if (sd->idle_id > 0)
 		g_source_remove(sd->idle_id);
 
-	g_free(sd->aid_str);
-	g_free(sd->app_str);
 	g_ril_unref(sd->ril);
 	g_free(sd);
 }
@@ -1155,6 +1112,17 @@ static struct ofono_sim_driver driver = {
 	.change_passwd		= ril_change_passwd,
 	.query_pin_retries	= ril_query_pin_retries,
 /*
+ * TODO: Implmenting PIN/PUK support requires defining
+ * the following driver methods.
+ *
+ * In the meanwhile, as long as the SIM card is present,
+ * and unlocked, the core SIM code will check for the
+ * presence of query_passwd_state, and if null, then the
+ * function sim_initialize_after_pin() is called.
+ *
+ *	.query_pin_retries	= ril_pin_retries_query,
+ *	.query_locked		= ril_pin_query_enabled,
+ *
  * TODO: Implementing SIM write file IO support requires
  * the following functions to be defined.
  *

ofono/drivers/rilmodem/sms.c

@@ -168,14 +168,10 @@ static void submit_sms_cb(struct ril_msg *message, gpointer user_data)
 	int mr;
 
 	if (message->error == RIL_E_SUCCESS) {
-		ofono_info("sms sending successful");
+		ofono_info("sms sending succesful");
 		decode_ril_error(&error, "OK");
-	} else if (message->error == RIL_E_GENERIC_FAILURE) {
-		ofono_info("not allowed by MO SMS control, do not retry");
-		error.type = OFONO_ERROR_TYPE_CMS;
-		error.error = 500;
 	} else {
-		ofono_error("sms sending failed, retry");
+		ofono_error("sms sending failed");
 		decode_ril_error(&error, "FAIL");
 	}
 
@@ -252,21 +248,19 @@ static void ril_ack_delivery_cb(struct ril_msg *message, gpointer user_data)
 			"SMS acknowledgement failed: Further SMS reception is not guaranteed");
 }
 
-static void ril_ack_delivery(struct ofono_sms *sms, int error)
+static void ril_ack_delivery(struct ofono_sms *sms)
 {
 	struct sms_data *sd = ofono_sms_get_data(sms);
 	struct parcel rilp;
 	int ret;
 	int request = RIL_REQUEST_SMS_ACKNOWLEDGE;
-	int code = 0;
-
-	if (!error)
-		code = 0xFF;
 
 	parcel_init(&rilp);
 	parcel_w_int32(&rilp, 2); /* Number of int32 values in array */
-	parcel_w_int32(&rilp, error); /* Successful (1)/Failed (0) receipt */
+	parcel_w_int32(&rilp, 1); /* Successful receipt */
-	parcel_w_int32(&rilp, code); /* error code */
+	parcel_w_int32(&rilp, 0); /* error code */
+
+	/* TODO: should ACK be sent for either of the error cases? */
 
 	/* ACK the incoming NEW_SMS */
 	ret = g_ril_send(sd->ril, request,
@@ -335,13 +329,11 @@ static void ril_sms_notify(struct ril_msg *message, gpointer user_data)
 						ril_buf_len - smsc_len);
 	}
 
-	ril_ack_delivery(sms, TRUE);
+	ril_ack_delivery(sms);
 
 	return;
 
 error:
-	ril_ack_delivery(sms, FALSE);
-
 	ofono_error("Unable to parse NEW_SMS notification");
 }
 

ofono/drivers/rilmodem/stk.c

@@ -1,337 +0,0 @@
-/*
- *
- *  oFono - Open Source Telephony
- *
- *  Copyright (C) 2008-2011  Intel Corporation. All rights reserved.
- *  Copyright (C) 2014 Jolla Ltd
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
- *
- */
-
-#ifdef HAVE_CONFIG_H
-#include <config.h>
-#endif
-
-#define _GNU_SOURCE
-#include <string.h>
-#include <stdlib.h>
-#include <stdio.h>
-#include <errno.h>
-
-#include <glib.h>
-
-#include <ofono/log.h>
-#include <ofono/modem.h>
-#include <ofono/stk.h>
-
-#include "gril.h"
-#include "util.h"
-
-#include "rilmodem.h"
-#include "ril_constants.h"
-
-struct stk_data {
-	GRil *ril;
-};
-
-gboolean subscribed;
-
-static void ril_envelope_cb(struct ril_msg *message, gpointer user_data)
-{
-	struct cb_data *cbd = user_data;
-	ofono_stk_envelope_cb_t cb = cbd->cb;
-	struct ofono_error error;
-
-	DBG("");
-
-	if (message->error == RIL_E_SUCCESS) {
-		decode_ril_error(&error, "OK");
-	} else {
-		DBG("Envelope reply failure: %s",
-				ril_error_to_string(message->error));
-		decode_ril_error(&error, "FAIL");
-	}
-
-	cb(&error, NULL, 0, cbd->data);
-}
-
-static void ril_stk_envelope(struct ofono_stk *stk, int length,
-				const unsigned char *command,
-				ofono_stk_envelope_cb_t cb, void *data)
-{
-	struct stk_data *sd = ofono_stk_get_data(stk);
-	struct cb_data *cbd = cb_data_new(cb, data);
-	struct parcel rilp;
-	char *hex_envelope = NULL;
-	int request = RIL_REQUEST_STK_SEND_ENVELOPE_COMMAND;
-	guint ret;
-
-	DBG("");
-
-	hex_envelope = encode_hex(command, length, 0);
-
-	DBG("rilmodem envelope: %s", hex_envelope);
-
-	parcel_init(&rilp);
-	parcel_w_string(&rilp, hex_envelope);
-
-	ret = g_ril_send(sd->ril, request,
-				rilp.data, rilp.size, ril_envelope_cb,
-				cbd, g_free);
-
-	parcel_free(&rilp);
-
-	if (ret <= 0) {
-			g_free(cbd);
-			CALLBACK_WITH_FAILURE(cb, NULL, -1, data);
-		}
-}
-
-static void ril_tr_cb(struct ril_msg *message, gpointer user_data)
-{
-	struct cb_data *cbd = user_data;
-	ofono_stk_generic_cb_t cb = cbd->cb;
-	struct ofono_error error;
-
-	DBG("");
-
-	if (message->error == RIL_E_SUCCESS) {
-		decode_ril_error(&error, "OK");
-	} else {
-		DBG("Error in sending terminal response");
-		ofono_error("Error in sending terminal response");
-		decode_ril_error(&error, "FAIL");
-	}
-
-	cb(&error, cbd->data);
-}
-
-static void ril_stk_terminal_response(struct ofono_stk *stk, int length,
-					const unsigned char *resp,
-					ofono_stk_generic_cb_t cb, void *data)
-{
-	struct stk_data *sd = ofono_stk_get_data(stk);
-	struct cb_data *cbd = cb_data_new(cb, data);
-	struct parcel rilp;
-	char *hex_tr = NULL;
-	int request = RIL_REQUEST_STK_SEND_TERMINAL_RESPONSE;
-	guint ret;
-
-	DBG("");
-
-	hex_tr = encode_hex(resp, length, 0);
-
-	DBG("rilmodem terminal response: %s", hex_tr);
-
-	parcel_init(&rilp);
-	parcel_w_string(&rilp, hex_tr);
-
-	ret = g_ril_send(sd->ril, request,
-				rilp.data, rilp.size, ril_tr_cb,
-				cbd, g_free);
-
-	parcel_free(&rilp);
-
-	if (ret <= 0) {
-			g_free(cbd);
-			CALLBACK_WITH_FAILURE(cb, data);
-		}
-}
-
-static void ril_stk_user_confirmation(struct ofono_stk *stk,
-					ofono_bool_t confirm)
-{
-	struct stk_data *sd = ofono_stk_get_data(stk);
-	struct parcel rilp;
-	int request = RIL_REQUEST_STK_HANDLE_CALL_SETUP_REQUESTED_FROM_SIM;
-	int ret;
-
-	DBG("");
-
-	/* Only pcmd needing user confirmation is call set up
-	 * RIL_REQUEST_STK_HANDLE_CALL_SETUP_REQUESTED_FROM_SIM
-	 */
-	parcel_init(&rilp);
-	parcel_w_int32(&rilp, 1);		/* size of array */
-	parcel_w_int32(&rilp, confirm);	/* yes/no */
-
-	/* fire and forget i.e. not waiting for the callback*/
-	ret = g_ril_send(sd->ril, request, rilp.data,
-		 rilp.size, NULL, NULL, NULL);
-
-	g_ril_print_request_no_args(sd->ril, ret, request);
-
-	parcel_free(&rilp);
-}
-
-static void ril_stk_pcmd_notify(struct ril_msg *message, gpointer user_data)
-{
-	struct ofono_stk *stk = user_data;
-	struct parcel rilp;
-	char *pcmd = NULL;
-	guchar *pdu = NULL;
-	long len;
-
-	DBG("");
-
-	ril_util_init_parcel(message, &rilp);
-	pcmd = parcel_r_string(&rilp);
-	DBG("pcmd: %s", pcmd);
-
-	pdu = decode_hex((const char *) pcmd,
-			strlen(pcmd),
-			&len, -1);
-
-	ofono_stk_proactive_command_notify(stk, len, (const guchar *)pdu);
-}
-
-static void ril_stk_event_notify(struct ril_msg *message, gpointer user_data)
-{
-	struct ofono_stk *stk = user_data;
-	struct parcel rilp;
-	char *pcmd = NULL;
-	guchar *pdu = NULL;
-	long len;
-
-	DBG("");
-
-	/* Proactive command has been handled by the modem. */
-	ril_util_init_parcel(message, &rilp);
-	pcmd = parcel_r_string(&rilp);
-	DBG("pcmd: %s", pcmd);
-
-	pdu = decode_hex((const char *) pcmd,
-			strlen(pcmd),
-			&len, -1);
-
-	ofono_stk_proactive_command_handled_notify(stk, len,
-			(const guchar *)pdu);
-}
-
-static void ril_stk_session_end_notify(struct ril_msg *message,
-					gpointer user_data)
-{
-	struct ofono_stk *stk = user_data;
-
-	DBG("");
-
-	ofono_stk_proactive_session_end_notify(stk);
-}
-
-static void ril_stk_agent_ready(struct ofono_stk *stk)
-{
-	struct stk_data *sd = ofono_stk_get_data(stk);
-	int request = RIL_REQUEST_REPORT_STK_SERVICE_IS_RUNNING;
-	int ret;
-
-	DBG("");
-
-	if (!subscribed) {
-		DBG("Subscribing notifications");
-		g_ril_register(sd->ril, RIL_UNSOL_STK_PROACTIVE_COMMAND,
-				ril_stk_pcmd_notify, stk);
-
-		g_ril_register(sd->ril, RIL_UNSOL_STK_SESSION_END,
-				ril_stk_session_end_notify, stk);
-
-		g_ril_register(sd->ril, RIL_UNSOL_STK_EVENT_NOTIFY,
-				ril_stk_event_notify, stk);
-		subscribed = TRUE;
-	}
-
-	/* fire and forget i.e. not waiting for the callback*/
-	ret = g_ril_send(sd->ril, request, NULL, 0,
-		 NULL, NULL, NULL);
-
-	g_ril_print_request_no_args(sd->ril, ret, request);
-}
-
-void ril_stk_set_lang()
-{
-	gchar *contents;
-	GError *err = NULL;
-
-	if (!g_file_get_contents(UI_LANG, &contents, NULL, &err)) {
-		if (err)
-			ofono_error("cannot open %s error: %d: message: %s",
-					UI_LANG, err->code, err->message);
-		g_error_free(err);
-	} else {
-		gchar *pch = g_strrstr(contents, CFG_LANG);
-		/* Set System UI lang to env LANG */
-		if (pch) {
-			setenv("LANG", pch + strlen(CFG_LANG), 1);
-			DBG("LANG %s", getenv("LANG"));
-		}
-		g_free(contents);
-	}
-}
-
-static int ril_stk_probe(struct ofono_stk *stk, unsigned int vendor, void *data)
-{
-	GRil *ril = data;
-	struct stk_data *sd;
-
-	DBG("");
-
-	sd = g_try_new0(struct stk_data, 1);
-	if (sd == NULL)
-		return -ENOMEM;
-
-	sd->ril = g_ril_clone(ril);
-	ofono_stk_set_data(stk, sd);
-
-	/* Register interface in this phase for stk agent */
-	ofono_stk_register(stk);
-
-	subscribed = FALSE;
-
-	/* UI language for local info */
-	ril_stk_set_lang();
-
-	return 0;
-}
-
-static void ril_stk_remove(struct ofono_stk *stk)
-{
-	struct stk_data *sd = ofono_stk_get_data(stk);
-
-	DBG("");
-
-	ofono_stk_set_data(stk, NULL);
-
-	g_ril_unref(sd->ril);
-	g_free(sd);
-}
-
-static struct ofono_stk_driver driver = {
-	.name			= "rilmodem",
-	.probe			= ril_stk_probe,
-	.remove			= ril_stk_remove,
-	.envelope		= ril_stk_envelope,
-	.terminal_response	= ril_stk_terminal_response,
-	.user_confirmation	= ril_stk_user_confirmation,
-	.ready			= ril_stk_agent_ready
-};
-
-void ril_stk_init(void)
-{
-	ofono_stk_driver_register(&driver);
-}
-
-void ril_stk_exit(void)
-{
-	ofono_stk_driver_unregister(&driver);
-}

ofono/drivers/rilmodem/voicecall.c

@@ -4,7 +4,7 @@
  *
  *  Copyright (C) 2008-2011  Intel Corporation. All rights reserved.
  *  Copyright (C) 2012 Canonical Ltd.
- *  Copyright (C) 2014 Jolla Ltd.
+ *  Copyright (C) 2013 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -86,21 +86,6 @@ struct lastcause_req {
 static void send_one_dtmf(struct voicecall_data *vd);
 static void clear_dtmf_queue(struct voicecall_data *vd);
 
-/*
- * structs ofono_voicecall and voicecall are fully defined
- * in src/voicecall.c; we need (read) access to the
- * call objects, so partially redefine them here.
- */
-struct ofono_voicecall {
-	GSList *call_list;
-	/* ... */
-};
-
-struct voicecall {
-	struct ofono_call *call;
-	/* ... */
-};
-
 static void lastcause_cb(struct ril_msg *message, gpointer user_data)
 {
 	struct lastcause_req *reqdata = user_data;
@@ -114,38 +99,11 @@ static void lastcause_cb(struct ril_msg *message, gpointer user_data)
 	if (parcel_r_int32(&rilp) > 0)
 		last_cause = parcel_r_int32(&rilp);
 
-	/*
-	 * Not all call control cause values specified in 3GPP TS 24.008
-	 * "Mobile radio interface Layer 3 specification; Core network protocols",
-	 * Annex H, are properly reflected in the RIL API. For example, cause
-	 * #21 "call rejected" is mapped to CALL_FAIL_ERROR_UNSPECIFIED, and
-	 * thus indistinguishable from a network failure.
-	 * We signal disconnect reason "remote" for cause values
-	 *   - #16 "normal call clearing"
-	 *   - #17 "user busy"
-	 *   - UNSPECIFIED for MO calls that are not yet connected
-	 * , and disconnect reason "network" otherwise.
-	 */
 	ofono_info("Call %d ended with RIL cause %d", id, last_cause);
 	if (last_cause == CALL_FAIL_NORMAL || last_cause == CALL_FAIL_BUSY) {
 		reason = OFONO_DISCONNECT_REASON_REMOTE_HANGUP;
 	}
 
-	if (last_cause == CALL_FAIL_ERROR_UNSPECIFIED) {
-		GSList *l;
-		struct voicecall *v;
-		for (l = vc->call_list; l; l = l->next) {
-			v = l->data;
-			if (v->call->id == id) {
-				if (v->call->status == CALL_STATUS_DIALING
-					|| v->call->status == CALL_STATUS_ALERTING) {
-					reason = OFONO_DISCONNECT_REASON_REMOTE_HANGUP;
-				}
-				break;
-			}
-		}
-	}
-
 	ofono_voicecall_disconnected(vc, id, reason, NULL);
 }
 
@@ -769,23 +727,6 @@ static gboolean enable_supp_svc(gpointer user_data)
 	return FALSE;
 }
 
-static void ril_ringback_tone_notify(struct ril_msg *message,
-	gpointer user_data)
-{
-	struct parcel rilp;
-	struct ofono_voicecall *vc = user_data;
-	gboolean playTone = FALSE;
-
-	ril_util_init_parcel(message, &rilp);
-
-	if (message->req == RIL_UNSOL_RINGBACK_TONE) {
-		if (parcel_r_int32(&rilp) > 0)
-			playTone = parcel_r_int32(&rilp);
-		DBG("play ringback tone: %d", playTone);
-		ofono_voicecall_ringback_tone_notify(vc, playTone);
-	}
-}
-
 static gboolean ril_delayed_register(gpointer user_data)
 {
 	struct ofono_voicecall *vc = user_data;
@@ -806,10 +747,6 @@ static gboolean ril_delayed_register(gpointer user_data)
 	g_ril_register(vd->ril, RIL_UNSOL_SUPP_SVC_NOTIFICATION,
 			ril_ss_notify, vc);
 
-	/* Register for ringback tone notifications */
-	g_ril_register(vd->ril, RIL_UNSOL_RINGBACK_TONE,
-			ril_ringback_tone_notify, vc);
-
 	/* request supplementary service notifications*/
 	enable_supp_svc(vc);
 
@@ -866,7 +803,6 @@ static void ril_voicecall_remove(struct ofono_voicecall *vc)
 	if (vd->timer_id > 0)
 		g_source_remove(vd->timer_id);
 
-	g_free(vd->tone_queue);
 	g_ril_unref(vd->ril);
 	g_free(vd);
 }

ofono/dundee/dundee.service.in

@@ -1,7 +1,6 @@
 [Unit]
 Description=DUN service
-Requires=dbus.service
+After=syslog.target
-After=dbus.service
 
 [Service]
 Type=dbus

ofono/gatchat/gatchat.c

@@ -835,9 +835,6 @@ static gboolean can_write_data(gpointer data)
 	gsize len;
 	char *cr;
 	gboolean wakeup_first = FALSE;
-#ifdef WRITE_SCHEDULER_DEBUG
-	int limiter;
-#endif
 
 	/* Grab the first command off the queue and write as
 	 * much of it as we can
@@ -889,20 +886,13 @@ static gboolean can_write_data(gpointer data)
 		towrite = cr - (cmd->cmd + chat->cmd_bytes_written) + 1;
 
 #ifdef WRITE_SCHEDULER_DEBUG
-	limiter = towrite;
+	if (towrite > 5)
-
+		towrite = 5;
-	if (limiter > 5)
-		limiter = 5;
 #endif
 
 	bytes_written = g_at_io_write(chat->io,
 					cmd->cmd + chat->cmd_bytes_written,
-#ifdef WRITE_SCHEDULER_DEBUG
+					towrite);
-					limiter
-#else
-					towrite
-#endif
-					);
 
 	if (bytes_written == 0)
 		return FALSE;

ofono/gril/gril.c

@@ -355,8 +355,7 @@ static void handle_response(struct ril_s *p, struct ril_msg *message)
 	int i;
 	guint len, id;
 
-	if (!count)
+	g_assert(count > 0);
-		return;
 
 	for (i = 0; i < count; i++) {
 		req = g_queue_peek_nth(p->command_queue, i);
@@ -374,13 +373,13 @@ static void handle_response(struct ril_s *p, struct ril_msg *message)
 							message->error));
 
 			req = g_queue_pop_nth(p->command_queue, i);
-			if (req->callback)
+			if (req->callback) {
 				req->callback(message, req->user_data);
+			}
 
 			len = g_queue_get_length(p->out_queue);
 			for (i = 0; i < len; i++) {
-				id = *(guint *) g_queue_peek_nth(
+				id = *(guint *) g_queue_peek_nth(p->out_queue, i);
-							p->out_queue, i);
 				if (id == req->id) {
 					g_queue_pop_nth(p->out_queue, i);
 					break;
@@ -404,21 +403,14 @@ static void handle_response(struct ril_s *p, struct ril_msg *message)
 
 }
 
-static void notify_call_callback(gpointer data, gpointer user_data)
-{
-	struct ril_notify_node *node = data;
-	struct ril_msg *message = user_data;
-
-	node->callback(message, node->user_data);
-}
-
 static void handle_unsol_req(struct ril_s *p, struct ril_msg *message)
 {
 	GHashTableIter iter;
 	struct ril_notify *notify;
 	int req_key;
 	gpointer key, value;
-	GSList *list_item;
+	GList *list_item;
+	struct ril_notify_node *node;
 	gboolean found = FALSE;
 
 	if (p->notify_list == NULL)
@@ -438,12 +430,15 @@ static void handle_unsol_req(struct ril_s *p, struct ril_msg *message)
 		if (req_key != message->req)
 			continue;
 
-		list_item = notify->nodes;
+		list_item = (GList *) notify->nodes;
 
-		if (list_item)
+		while (list_item != NULL) {
+			node = list_item->data;
+
+			node->callback(message, node->user_data);
 			found = TRUE;
-
+			list_item = (GList *) g_slist_next(list_item);
-		g_slist_foreach(notify->nodes, notify_call_callback, message);
+		}
 	}
 
 	/* Only log events not being listended for... */
@@ -587,8 +582,9 @@ static void new_bytes(struct ring_buffer *rbuf, gpointer user_data)
 	while (p->suspended == FALSE && (p->read_so_far < len)) {
 		gsize rbytes = MIN(len - p->read_so_far, wrap - p->read_so_far);
 
-		if (rbytes < 4)
+		if (rbytes < 4) {
 			return;
+		}
 
 		/* this function attempts to read the next full length
 		 * fixed message from the stream.  if not all bytes are
@@ -599,8 +595,9 @@ static void new_bytes(struct ring_buffer *rbuf, gpointer user_data)
 		message = read_fixed_record(p, buf, &rbytes);
 
 		/* wait for the rest of the record... */
-		if (message == NULL)
+		if (message == NULL) {
 			break;
+		}
 
 		buf += rbytes;
 		p->read_so_far += rbytes;
@@ -645,8 +642,7 @@ static gboolean can_write_data(gpointer data)
 		for (i = 0; i < qlen; i++) {
 			req = g_queue_peek_nth(ril->command_queue, i);
 			if (req) {
-				id = *(guint *) g_queue_peek_head(
+				id = *(guint *) g_queue_peek_head(ril->out_queue);
-							ril->out_queue);
 				if (req->id == id)
 					goto out;
 			} else {

ofono/gril/ril_constants.h

@@ -191,7 +191,6 @@
 #define RIL_PERSOSUBSTATE_RUIM_RUIM_PUK 24
 
 /* SIM - App states */
-#define RIL_APPSTATE_ILLEGAL -1
 #define RIL_APPSTATE_UNKNOWN 0
 #define RIL_APPSTATE_DETECTED 1
 #define RIL_APPSTATE_PIN 2

ofono/include/dbus.h

@@ -80,29 +80,29 @@ extern "C" {
 DBusConnection *ofono_dbus_get_connection(void);
 
 void ofono_dbus_dict_append(DBusMessageIter *dict, const char *key, int type,
-				const void *value);
+				void *value);
 
 void ofono_dbus_dict_append_array(DBusMessageIter *dict, const char *key,
-					int type, const void *val);
+					int type, void *val);
 
 void ofono_dbus_dict_append_dict(DBusMessageIter *dict, const char *key,
-					int type, const void *val);
+					int type, void *val);
 
 int ofono_dbus_signal_property_changed(DBusConnection *conn, const char *path,
 					const char *interface, const char *name,
-					int type, const void *value);
+					int type, void *value);
 
 int ofono_dbus_signal_array_property_changed(DBusConnection *conn,
 						const char *path,
 						const char *interface,
 						const char *name, int type,
-						const void *value);
+						void *value);
 
 int ofono_dbus_signal_dict_property_changed(DBusConnection *conn,
 						const char *path,
 						const char *interface,
 						const char *name, int type,
-						const void *value);
+						void *value);
 
 #ifdef __cplusplus
 }

ofono/include/gprs-provision.h

@@ -31,8 +31,6 @@ extern "C" {
 struct ofono_gprs_provision_data {
 	enum ofono_gprs_context_type type;
 	enum ofono_gprs_proto proto;
-	char *provider_name;
-	ofono_bool_t provider_primary;
 	char *name;
 	char *apn;
 	char *username;

ofono/include/stk.h

@@ -48,7 +48,6 @@ struct ofono_stk_driver {
 					int length, const unsigned char *resp,
 					ofono_stk_generic_cb_t cb, void *data);
 	void (*user_confirmation)(struct ofono_stk *stk, ofono_bool_t confirm);
-	void (*ready)(struct ofono_stk *stk);
 };
 
 int ofono_stk_driver_register(const struct ofono_stk_driver *d);

ofono/include/voicecall.h

@@ -3,7 +3,6 @@
  *  oFono - Open Source Telephony
  *
  *  Copyright (C) 2008-2011  Intel Corporation. All rights reserved.
- *  Copyright (C) 2014 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -172,9 +171,6 @@ void ofono_voicecall_ssn_mt_notify(struct ofono_voicecall *vc, unsigned int id,
 					int code, int index,
 					const struct ofono_phone_number *ph);
 
-void ofono_voicecall_ringback_tone_notify(struct ofono_voicecall *vc,
-						const ofono_bool_t playTone);
-
 #ifdef __cplusplus
 }
 #endif

ofono/plugins/mbpi.c

@@ -53,8 +53,6 @@ enum MBPI_ERROR {
 struct gsm_data {
 	const char *match_mcc;
 	const char *match_mnc;
-	char *provider_name;
-	gboolean provider_primary;
 	GSList *apns;
 	gboolean match_found;
 	gboolean allow_duplicates;
@@ -86,7 +84,6 @@ static GQuark mbpi_error_quark(void)
 
 void mbpi_ap_free(struct ofono_gprs_provision_data *ap)
 {
-	g_free(ap->provider_name);
 	g_free(ap->name);
 	g_free(ap->apn);
 	g_free(ap->username);
@@ -120,7 +117,6 @@ static void text_handler(GMarkupParseContext *context,
 {
 	char **string = userdata;
 
-        g_free(*string);
 	*string = g_strndup(text, text_len);
 }
 
@@ -194,9 +190,7 @@ static void apn_end(GMarkupParseContext *context, const gchar *element_name,
 {
 	if (g_str_equal(element_name, "name") ||
 			g_str_equal(element_name, "username") ||
-			g_str_equal(element_name, "password") ||
+			g_str_equal(element_name, "password"))
-			g_str_equal(element_name, "mmsc") ||
-			g_str_equal(element_name, "mmsproxy"))
 		g_markup_parse_context_pop(context);
 }
 
@@ -292,9 +286,6 @@ static void apn_handler(GMarkupParseContext *context, struct gsm_data *gsm,
 	}
 
 	ap = g_new0(struct ofono_gprs_provision_data, 1);
-	ap->provider_name = g_strdup(gsm->provider_name);
-	ap->provider_primary = gsm->provider_primary;
-
 	ap->apn = g_strdup(apn);
 	ap->type = OFONO_GPRS_CONTEXT_TYPE_INTERNET;
 	ap->proto = OFONO_GPRS_PROTO_IP;
@@ -461,68 +452,27 @@ static const GMarkupParser provider_parser = {
 	NULL,
 };
 
-static void gsm_provider_start(GMarkupParseContext *context,
+static void toplevel_gsm_start(GMarkupParseContext *context,
 					const gchar *element_name,
-					const gchar **attribute_names,
+					const gchar **atribute_names,
 					const gchar **attribute_values,
 					gpointer userdata, GError **error)
 {
 	struct gsm_data *gsm = userdata;
 
-	if (g_str_equal(element_name, "name")) {
+	if (g_str_equal(element_name, "gsm")) {
-		g_free(gsm->provider_name);
-		gsm->provider_name = NULL;
-		g_markup_parse_context_push(context, &text_parser,
-						&gsm->provider_name);
-	} else if (g_str_equal(element_name, "gsm")) {
 		gsm->match_found = FALSE;
 		g_markup_parse_context_push(context, &gsm_parser, gsm);
 	} else if (g_str_equal(element_name, "cdma"))
 		g_markup_parse_context_push(context, &skip_parser, NULL);
 }
 
-static void gsm_provider_end(GMarkupParseContext *context,
-					const gchar *element_name,
-					gpointer userdata, GError **error)
-{
-	if (g_str_equal(element_name, "name") ||
-				g_str_equal(element_name, "gsm") ||
-				g_str_equal(element_name, "cdma"))
-		g_markup_parse_context_pop(context);
-}
-
-static const GMarkupParser gsm_provider_parser = {
-	gsm_provider_start,
-	gsm_provider_end,
-	NULL,
-	NULL,
-	NULL,
-};
-
-static void toplevel_gsm_start(GMarkupParseContext *context,
-					const gchar *element_name,
-					const gchar **attribute_names,
-					const gchar **attribute_values,
-					gpointer userdata, GError **error)
-{
-	struct gsm_data *gsm = userdata;
-
-	if (g_str_equal(element_name, "provider")) {
-		g_markup_collect_attributes(element_name, attribute_names,
-				attribute_values, error,
-				G_MARKUP_COLLECT_BOOLEAN | G_MARKUP_COLLECT_OPTIONAL,
-				"primary", &gsm->provider_primary,
-				G_MARKUP_COLLECT_INVALID);
-
-		g_markup_parse_context_push(context, &gsm_provider_parser, gsm);
-	}
-}
-
 static void toplevel_gsm_end(GMarkupParseContext *context,
 					const gchar *element_name,
 					gpointer userdata, GError **error)
 {
-	if (g_str_equal(element_name, "provider"))
+	if (g_str_equal(element_name, "gsm") ||
+			g_str_equal(element_name, "cdma"))
 		g_markup_parse_context_pop(context);
 }
 
@@ -536,7 +486,7 @@ static const GMarkupParser toplevel_gsm_parser = {
 
 static void toplevel_cdma_start(GMarkupParseContext *context,
 					const gchar *element_name,
-					const gchar **attribute_names,
+					const gchar **atribute_names,
 					const gchar **attribute_values,
 					gpointer userdata, GError **error)
 {
@@ -639,7 +589,6 @@ GSList *mbpi_lookup_apn(const char *mcc, const char *mnc,
 		gsm.apns = NULL;
 	}
 
-	g_free(gsm.provider_name);
 	return gsm.apns;
 }
 

ofono/plugins/nettime.c

@@ -188,11 +188,11 @@ static int nettime_probe(struct ofono_nettime_context *context)
 					NULL, // GDBusPropertyTable *properties
 					NULL, // user data
 					NULL)) { // GDBusDestroyFunction destroy
-		ofono_error("Network time: Could not register interface %s, path %s",
+		ofono_error("Networkt time: Could not register interface %s, path %s",
 				OFONO_NETWORK_TIME_INTERFACE, path);
 		return 1;
 	} else {
-		ofono_info("Network time: Registered interface %s, path %s",
+		ofono_info("Network time: Registered inteface %s, path %s",
 				OFONO_NETWORK_TIME_INTERFACE, path);
 	}
 
@@ -235,12 +235,6 @@ static void nettime_info_received(struct ofono_nettime_context *context,
 
 	netreg = __ofono_atom_get_data(__ofono_modem_find_atom(
 						context->modem, OFONO_ATOM_TYPE_NETREG));
-
-	if (!(ofono_netreg_get_mcc(netreg) && ofono_netreg_get_mnc(netreg))) {
-		DBG("Incomplete network time received, ignoring");
-		return;
-	}
-
 	ntd->path = ofono_modem_get_path(context->modem);
 	ntd->mcc = ofono_netreg_get_mcc(netreg);
 	ntd->mnc = ofono_netreg_get_mnc(netreg);

ofono/plugins/provision.c

@@ -24,7 +24,6 @@
 #include <config.h>
 #endif
 
-#define _GNU_SOURCE
 #include <errno.h>
 #include <string.h>
 
@@ -37,134 +36,9 @@
 #include <ofono/modem.h>
 #include <ofono/gprs-provision.h>
 
-#include "provision.h"
 #include "mbpi.h"
 
-/* Returns the list containing exactly one INTERNET and one MMS access point */
+static int provision_get_settings(const char *mcc, const char *mnc,
-static GSList *provision_normalize_apn_list(GSList *apns, const char* spn)
-{
-	struct ofono_gprs_provision_data *best_internet = NULL;
-	struct ofono_gprs_provision_data *best_mms = NULL;
-	struct ofono_gprs_provision_data *second_best_internet = NULL;
-	struct ofono_gprs_provision_data *second_best_mms = NULL;
-	GSList *best_apns = NULL;
-	GSList *l;
-
-	/* 1. save the first found internet APN and the first MMS APN */
-	l = apns;
-	while (l != NULL) {
-		GSList *next = l->next;
-		struct ofono_gprs_provision_data *ap = l->data;
-
-		if (ap->type == OFONO_GPRS_CONTEXT_TYPE_INTERNET
-				&& !best_internet) {
-			best_internet = ap;
-		} else if (ap->type == OFONO_GPRS_CONTEXT_TYPE_MMS
-				&& !best_mms) {
-			best_mms = ap;
-		}
-		l = next;
-	}
-
-	/*
-	 * 2. look for a "primary" provider (i.e. an MNO, not
-	 * an MVNO on the same radio network)
-	 */
-	second_best_internet = best_internet;
-	best_internet = NULL;
-	second_best_mms = best_mms;
-	best_mms = NULL;
-
-	l = apns;
-	while (l != NULL) {
-		GSList *next = l->next;
-		struct ofono_gprs_provision_data *ap = l->data;
-
-		if (ap->provider_primary) {
-			if (ap->type == OFONO_GPRS_CONTEXT_TYPE_INTERNET
-					&& !best_internet) {
-				best_internet = ap;
-			} else if (ap->type == OFONO_GPRS_CONTEXT_TYPE_MMS
-					&& !best_mms) {
-				best_mms = ap;
-			}
-		}
-		l = next;
-	}
-
-	/* no better match found */
-	if (!best_internet)
-		best_internet = second_best_internet;
-	if (!best_mms)
-		best_mms = second_best_mms;
-
-	/*
-	 * 3. if there is an SPN given, save the first internet APN and the
-	 * first MMS APN matching the SPN (partially, case-insensitively)
-	 * */
-	if (spn) {
-		second_best_internet = best_internet;
-		best_internet = NULL;
-		second_best_mms = best_mms;
-		best_mms = NULL;
-
-		l = apns;
-		while (l != NULL) {
-			GSList *next = l->next;
-			struct ofono_gprs_provision_data *ap = l->data;
-
-			if ((ap->provider_name && strcasestr(ap->provider_name, spn))
-				|| (ap->name && strcasestr(ap->name, spn))
-				|| (ap->apn && strcasestr(ap->apn, spn))) {
-				if (ap->type == OFONO_GPRS_CONTEXT_TYPE_INTERNET
-						&& !best_internet) {
-					best_internet = ap;
-				} else if (ap->type == OFONO_GPRS_CONTEXT_TYPE_MMS
-						&& !best_mms) {
-					best_mms = ap;
-				}
-			}
-			l = next;
-		}
-
-		/* no better match found */
-		if (!best_internet)
-			best_internet = second_best_internet;
-		if (!best_mms)
-			best_mms = second_best_mms;
-	}
-
-	/* 4. if none found yet, create APNs with default values */
-	if (!best_internet) {
-		best_internet = g_try_new0(struct ofono_gprs_provision_data, 1);
-		if (best_internet) {
-			best_internet->type =
-				OFONO_GPRS_CONTEXT_TYPE_INTERNET;
-			best_internet->name =
-				g_strdup("Internet");
-			best_internet->apn =
-				g_strdup("internet");
-		}
-	}
-
-	if (!best_mms) {
-		best_mms = g_try_new0(struct ofono_gprs_provision_data, 1);
-		if (best_mms) {
-			best_mms->type =
-				OFONO_GPRS_CONTEXT_TYPE_MMS;
-			best_mms->name =
-				g_strdup("MMS");
-			best_mms->apn =
-				g_strdup("mms");
-		}
-	}
-
-	best_apns = g_slist_append(best_apns, best_internet);
-	best_apns = g_slist_append(best_apns, best_mms);
-	return best_apns;
-}
-
-int provision_get_settings(const char *mcc, const char *mnc,
 				const char *spn,
 				struct ofono_gprs_provision_data **settings,
 				int *count)
@@ -175,26 +49,36 @@ int provision_get_settings(const char *mcc, const char *mnc,
 	int ap_count;
 	int i;
 
-	ofono_info("Provisioning for MCC %s, MNC %s, SPN '%s'", mcc, mnc, spn);
+	DBG("Provisioning for MCC %s, MNC %s, SPN '%s'", mcc, mnc, spn);
 
 	/*
-	 * Passing FALSE to mbpi_lookup_apn() would return
+	 * TODO: review with upstream.  Default behavior was to
-	 * an empty list if duplicates are found.
+	 * disallow duplicate APN entries, which unfortunately exist
+	 * in the mobile-broadband-provider-info db.
 	 */
 	apns = mbpi_lookup_apn(mcc, mnc, TRUE, &error);
+	if (apns == NULL) {
 		if (error != NULL) {
 			ofono_error("%s", error->message);
 			g_error_free(error);
 		}
 
-	ofono_info("Found %d APs in MBPI", g_slist_length(apns));
-	apns = provision_normalize_apn_list(apns, spn);
-	if (apns == NULL)
 		return -ENOENT;
+	}
 
 	ap_count = g_slist_length(apns);
 
-	ofono_info("Provisioning %d APs", ap_count);
+	ofono_info("GPRS Provisioning found %d matching APNs for SPN: %s MCC: %s MNC: %s",
+			ap_count, spn, mcc, mnc);
+	/*
+	 * Only keep the first APN found.
+	 *
+	 * This allows auto-provisioning to work most of the time vs.
+	 * passing FALSE to mbpi_lookup_apn() which would return an
+	 * an empty list if duplicates are found.
+	 */
+	if (ap_count > 1)
+		ap_count = 1;
 
 	*settings = g_try_new0(struct ofono_gprs_provision_data, ap_count);
 	if (*settings == NULL) {
@@ -213,6 +97,11 @@ int provision_get_settings(const char *mcc, const char *mnc,
 	for (l = apns, i = 0; l; l = l->next, i++) {
 		struct ofono_gprs_provision_data *ap = l->data;
 
+		/*
+		 * Only create a data context for the first matching APN.
+		 * See comment above that restricts restricts apn_count.
+		 */
+		if (i == 0) {
 			ofono_info("Name: '%s'", ap->name);
 			ofono_info("APN: '%s'", ap->apn);
 			ofono_info("Type: %s", mbpi_ap_type(ap->type));
@@ -223,6 +112,10 @@ int provision_get_settings(const char *mcc, const char *mnc,
 				sizeof(struct ofono_gprs_provision_data));
 
 			g_free(ap);
+		} else {
+			mbpi_ap_free(ap);
+		}
+
 	}
 
 	g_slist_free(apns);

ofono/plugins/provision.h

@@ -1,28 +0,0 @@
-/*
- *
- *  oFono - Open Source Telephony
- *
- *  Copyright (C) 2014 Jolla. All rights reserved.
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
- *
- */
-
-struct ofono_gprs_provision_data;
-
-int provision_get_settings(const char *mcc, const char *mnc,
-				const char *spn,
-				struct ofono_gprs_provision_data **settings,
-				int *count);
-

ofono/plugins/push-forwarder.c

@@ -1,541 +0,0 @@
-/*
- *  Copyright (C) 2013-2014 Jolla Ltd.
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *
- */
-
-#ifdef HAVE_CONFIG_H
-#include <config.h>
-#endif
-
-#include <glib.h>
-#include <string.h>
-#include <unistd.h>
-#include <sys/ioctl.h>
-#include <sys/inotify.h>
-#include <wspcodec.h>
-
-#define OFONO_API_SUBJECT_TO_CHANGE
-#include <ofono.h>
-#include <plugin.h>
-
-/*
- * Push forwarder plugin is looking for configuration files in
- * /etc/ofono/push_forwarder.d directory. Confiration files are
- * glib key files that look like this:
- *
- *   [Jolla MMS Handler]
- *   ContentType = application/vnd.wap.mms-message
- *   Interface = com.jolla.MmsEngine.
- *   Service = com.jolla.MmsEngine
- *   Method = HandlePush
- *   Path = /
- *
- * Only files with .conf suffix are loaded. In addition to the keys
- * from the above example, SourcePort and DestinationPort port keys
- * are supported. All other keys are ignored. One file may describe
- * several push handlers. See pf_parse_config() function for details.
- *
- * When push fowarder receives a WAP push, it goes through the list
- * of registered handlers and invokes all of them that match content
- * type and/or port numbers. The rest is up to the D-Bus service
- * handling the call.
- */
-
-#define PF_CONFIG_DIR CONFIGDIR "/push_forwarder.d"
-
-struct pf_modem {
-	struct ofono_modem *modem;
-	struct ofono_sms *sms;
-	struct ofono_sim *sim;
-	unsigned int sim_watch_id;
-	unsigned int sms_watch_id;
-	unsigned int push_watch_id;
-};
-
-struct push_datagram_handler {
-	char *name;
-	char *content_type;
-	char *interface;
-	char *service;
-	char *method;
-	char *path;
-	int dst_port;
-	int src_port;
-};
-
-static GSList *handlers;
-static GSList *modems;
-static unsigned int modem_watch_id;
-static int inotify_fd = -1;
-static int inotify_watch_id = -1;
-static guint inotify_watch_source_id;
-static GIOChannel *inotify_watch_channel;
-
-static void pf_notify_handler(struct push_datagram_handler *h,
-		const char *imsi, const char *from, const struct tm *remote,
-		const struct tm *local, int dst, int src,
-		const char *ct, const void *data, unsigned int len)
-{
-	struct tm remote_tm = *remote;
-	struct tm local_tm = *local;
-	dbus_uint32_t remote_time_arg = mktime(&remote_tm);
-	dbus_uint32_t local_time_arg = mktime(&local_tm);
-	dbus_int32_t dst_arg = dst;
-	dbus_int32_t src_arg = src;
-	DBusMessageIter iter, array;
-	DBusMessage *msg = dbus_message_new_method_call(h->service,
-			h->path, h->interface, h->method);
-
-	dbus_message_append_args(msg,
-				 DBUS_TYPE_STRING, &imsi,
-				 DBUS_TYPE_STRING, &from,
-				 DBUS_TYPE_UINT32, &remote_time_arg,
-				 DBUS_TYPE_UINT32, &local_time_arg,
-				 DBUS_TYPE_INT32,  &dst_arg,
-				 DBUS_TYPE_INT32,  &src_arg,
-				 DBUS_TYPE_STRING, &ct,
-				 DBUS_TYPE_INVALID);
-	dbus_message_iter_init_append(msg, &iter);
-	dbus_message_iter_open_container(&iter, DBUS_TYPE_ARRAY,
-					DBUS_TYPE_BYTE_AS_STRING, &array);
-	dbus_message_iter_append_fixed_array(&array,
-						DBUS_TYPE_BYTE, &data, len);
-	dbus_message_iter_close_container(&iter, &array);
-	dbus_message_set_no_reply(msg, TRUE);
-	dbus_connection_send(ofono_dbus_get_connection(), msg, NULL);
-	dbus_message_unref(msg);
-}
-
-static gboolean pf_match_port(int port, int expected_port)
-{
-	if (expected_port < 0)
-		return TRUE;
-
-	if (expected_port == port)
-		return TRUE;
-
-	return FALSE;
-}
-
-static gboolean pf_match_handler(struct push_datagram_handler *h,
-	const char *ct, int dst, int src)
-{
-	if (pf_match_port(dst, h->dst_port) == FALSE)
-		return FALSE;
-
-	if (pf_match_port(src, h->src_port) == FALSE)
-		return FALSE;
-
-	if (h->content_type == NULL)
-		return TRUE;
-
-	if (strcmp(h->content_type, ct) == 0)
-		return TRUE;
-
-	return FALSE;
-}
-
-static void pf_handle_datagram(const char *from,
-		const struct tm *remote, const struct tm *local, int dst,
-		int src, const unsigned char *buffer, unsigned int len,
-		void *userdata)
-{
-	struct pf_modem *pm = userdata;
-	guint remain;
-	const guint8 *data;
-	unsigned int hdrlen;
-	unsigned int off;
-	const void *ct;
-	const char *imsi;
-	GSList *link;
-
-	DBG("received push of size: %u", len);
-
-	if (pm->sim == NULL)
-		return;
-
-	imsi = ofono_sim_get_imsi(pm->sim);
-	if (len < 3)
-		return;
-
-	if (buffer[1] != 6)
-		return;
-
-	remain = len - 2;
-	data = buffer + 2;
-
-	if (wsp_decode_uintvar(data, remain, &hdrlen, &off) == FALSE)
-		return;
-
-	if ((off + hdrlen) > remain)
-		return;
-
-	data += off;
-	remain -= off;
-
-	DBG("  WAP header %u bytes", hdrlen);
-
-	if (wsp_decode_content_type(data, hdrlen, &ct, &off, NULL) == FALSE)
-		return;
-
-	data += hdrlen;
-	remain -= hdrlen;
-
-	DBG("  content type %s", (char *)ct);
-	DBG("  imsi %s", imsi);
-	DBG("  data size %u", remain);
-
-	link = handlers;
-
-	while (link) {
-		struct push_datagram_handler *h = link->data;
-
-		if (pf_match_handler(h, ct, dst, src) != FALSE) {
-			DBG("notifying %s", h->name);
-			pf_notify_handler(h, imsi, from, remote, local, dst,
-					src, ct, data, remain);
-		}
-		link = link->next;
-	}
-}
-
-static void pf_sms_watch(struct ofono_atom *atom,
-			enum ofono_atom_watch_condition cond, void *userdata)
-{
-	struct pf_modem *pm = userdata;
-
-	if (cond == OFONO_ATOM_WATCH_CONDITION_REGISTERED) {
-		DBG("registered");
-		pm->sms = __ofono_atom_get_data(atom);
-		pm->push_watch_id = __ofono_sms_datagram_watch_add(pm->sms,
-			pf_handle_datagram, -1, -1, pm, NULL);
-	} else if (cond == OFONO_ATOM_WATCH_CONDITION_UNREGISTERED) {
-		DBG("unregistered");
-		pm->sms = NULL;
-		pm->push_watch_id = 0;
-	}
-}
-
-static void pf_sms_watch_done(void *userdata)
-{
-	struct pf_modem *pm = userdata;
-
-	pm->sms_watch_id = 0;
-}
-
-static void pf_sim_watch(struct ofono_atom *atom,
-			enum ofono_atom_watch_condition cond, void *userdata)
-{
-	struct pf_modem *pm = userdata;
-
-	if (cond == OFONO_ATOM_WATCH_CONDITION_REGISTERED) {
-		DBG("registered");
-		pm->sim = __ofono_atom_get_data(atom);
-	} else if (cond == OFONO_ATOM_WATCH_CONDITION_UNREGISTERED) {
-		DBG("unregistered");
-		pm->sim = NULL;
-	}
-}
-
-static void pf_sim_watch_done(void *userdata)
-{
-	struct pf_modem *pm = userdata;
-
-	pm->sim_watch_id = 0;
-}
-
-static void pf_free_modem(struct pf_modem *pm)
-{
-	if (pm == NULL)
-		return;
-
-	if (pm->push_watch_id != 0)
-		__ofono_sms_datagram_watch_remove(pm->sms, pm->push_watch_id);
-
-	if (pm->sim_watch_id != 0)
-		__ofono_modem_remove_atom_watch(pm->modem, pm->sim_watch_id);
-
-	if (pm->sms_watch_id != 0)
-		__ofono_modem_remove_atom_watch(pm->modem, pm->sms_watch_id);
-
-	g_free(pm);
-}
-
-static void pf_modem_watch(struct ofono_modem *modem,
-						gboolean added, void *userdata)
-{
-	DBG("modem: %p, added: %d", modem, added);
-	if (added != FALSE) {
-		struct pf_modem *pm;
-
-		pm = g_try_new0(struct pf_modem, 1);
-		if (pm == NULL)
-			return;
-
-		pm->modem = modem;
-		pm->sms_watch_id = __ofono_modem_add_atom_watch(modem,
-			OFONO_ATOM_TYPE_SMS, pf_sms_watch, pm,
-			pf_sms_watch_done);
-		pm->sim_watch_id = __ofono_modem_add_atom_watch(modem,
-			OFONO_ATOM_TYPE_SIM, pf_sim_watch, pm,
-			pf_sim_watch_done);
-		modems = g_slist_append(modems, pm);
-	} else {
-		GSList *link = modems;
-
-		while (link) {
-			struct pf_modem *pm = link->data;
-
-			if (pm->modem == modem) {
-				modems = g_slist_delete_link(modems, link);
-				pf_free_modem(pm);
-				break;
-			}
-			link = link->next;
-		}
-	}
-}
-
-static void pf_modem_init(struct ofono_modem *modem,
-						void *userdata)
-{
-	pf_modem_watch(modem, TRUE, NULL);
-}
-
-static void pf_free_handler(void *data)
-{
-	struct push_datagram_handler *h = data;
-
-	g_free(h->content_type);
-	g_free(h->interface);
-	g_free(h->service);
-	g_free(h->method);
-	g_free(h->path);
-	g_free(h->name);
-	g_free(h);
-}
-
-static void pf_parse_handler(GKeyFile *conf, const char *g)
-{
-	GError *err = NULL;
-	struct push_datagram_handler *h;
-	char *interface;
-	char *service;
-	char *method;
-	char *path;
-
-	interface = g_key_file_get_string(conf, g, "Interface", NULL);
-	if (interface == NULL)
-		goto no_interface;
-
-	service = g_key_file_get_string(conf, g, "Service", NULL);
-	if (service == NULL)
-		goto no_service;
-
-	method = g_key_file_get_string(conf, g, "Method", NULL);
-	if (method == NULL)
-		goto no_method;
-
-	path = g_key_file_get_string(conf, g, "Path", NULL);
-	if (path == NULL)
-		goto no_path;
-
-	h = g_try_new0(struct push_datagram_handler, 1);
-	if (h == NULL)
-		goto no_memory;
-
-	h->name = g_strdup(g);
-	h->interface = interface;
-	h->service = service;
-	h->method = method;
-	h->path = path;
-	h->content_type = g_key_file_get_string(conf, g, "ContentType", NULL);
-	h->dst_port = g_key_file_get_integer(conf, g, "DestinationPort", &err);
-	if (h->dst_port == 0 && err != NULL) {
-		h->dst_port = -1;
-		g_error_free(err);
-		err = NULL;
-	}
-	h->src_port = g_key_file_get_integer(conf, g, "SourcePort", &err);
-	if (h->src_port == 0 && err != NULL) {
-		h->src_port = -1;
-		g_error_free(err);
-		err = NULL;
-	}
-	DBG("registered %s", h->name);
-	if (h->content_type != NULL)
-		DBG("  ContentType: %s", h->content_type);
-	if (h->dst_port >= 0)
-		DBG("  DestinationPort: %d", h->dst_port);
-	if (h->src_port >= 0)
-		DBG("  SourcePort: %d", h->src_port);
-	DBG("  Interface: %s", interface);
-	DBG("  Service: %s", service);
-	DBG("  Method: %s", method);
-	DBG("  Path: %s", path);
-	handlers = g_slist_append(handlers, h);
-	return;
-
-no_memory:
-	g_free(path);
-
-no_path:
-	g_free(method);
-
-no_method:
-	g_free(service);
-
-no_service:
-	g_free(interface);
-
-no_interface:
-	return;
-}
-
-static void pf_parse_config(void)
-{
-	GDir *dir;
-	const gchar *file;
-
-	g_slist_free_full(handlers, pf_free_handler);
-	handlers = NULL;
-
-	dir = g_dir_open(PF_CONFIG_DIR, 0, NULL);
-	if (dir == NULL) {
-		DBG(PF_CONFIG_DIR " not found.");
-		return;
-	}
-
-	DBG("loading configuration from " PF_CONFIG_DIR);
-	while ((file = g_dir_read_name(dir)) != NULL) {
-		GError *err;
-		GKeyFile *conf;
-		char *path;
-
-		if (g_str_has_suffix(file, ".conf") == FALSE)
-			continue;
-
-		err = NULL;
-		conf = g_key_file_new();
-		path = g_strconcat(PF_CONFIG_DIR "/", file, NULL);
-		DBG("reading %s", file);
-
-		if (g_key_file_load_from_file(conf, path, 0, &err) != FALSE) {
-			gsize i, n;
-			char **names = g_key_file_get_groups(conf, &n);
-
-			for (i = 0; i < n; i++)
-				pf_parse_handler(conf, names[i]);
-			g_strfreev(names);
-		} else {
-			ofono_warn("%s", err->message);
-			g_error_free(err);
-		}
-
-		g_key_file_free(conf);
-		g_free(path);
-	}
-
-	g_dir_close(dir);
-}
-
-static gboolean pf_inotify(GIOChannel *gio, GIOCondition c, gpointer data)
-{
-	int avail;
-	gsize len;
-	void *buf;
-	GError *error;
-
-	if (ioctl(inotify_fd, FIONREAD, &avail) < 0)
-		return FALSE;
-
-	buf = g_try_malloc(avail);
-	if (buf == NULL)
-		return FALSE;
-
-	error = NULL;
-	if (g_io_channel_read_chars(gio, buf, avail, &len, &error) !=
-							G_IO_STATUS_NORMAL) {
-		g_free(buf);
-		return FALSE;
-	}
-
-	pf_parse_config();
-	g_free(buf);
-	return TRUE;
-}
-
-static int pf_plugin_init(void)
-{
-	DBG("");
-	pf_parse_config();
-	modem_watch_id = __ofono_modemwatch_add(pf_modem_watch, NULL, NULL);
-	__ofono_modem_foreach(pf_modem_init, NULL);
-	inotify_fd = inotify_init();
-	if (inotify_fd < 0)
-		return 0;
-
-	inotify_watch_id = inotify_add_watch(inotify_fd,
-					PF_CONFIG_DIR,
-					IN_CLOSE_WRITE | IN_DELETE | IN_MOVE);
-	if (inotify_watch_id < 0)
-		goto no_inotify_watch_id;
-
-	inotify_watch_channel = g_io_channel_unix_new(inotify_fd);
-	if (inotify_watch_channel == NULL)
-		goto no_inotify_watch_channel;
-
-	g_io_channel_set_encoding(inotify_watch_channel, NULL, NULL);
-	g_io_channel_set_buffered(inotify_watch_channel, FALSE);
-	inotify_watch_source_id = g_io_add_watch(inotify_watch_channel,
-						G_IO_IN, pf_inotify, NULL);
-	if (inotify_watch_source_id != 0)
-		return 0;
-
-	g_io_channel_unref(inotify_watch_channel);
-	inotify_watch_channel = NULL;
-
-no_inotify_watch_channel:
-	inotify_rm_watch(inotify_fd, inotify_watch_id);
-	inotify_watch_id = -1;
-
-no_inotify_watch_id:
-	close(inotify_fd);
-	inotify_fd = -1;
-	return 0;
-}
-
-static void pf_plugin_exit(void)
-{
-	DBG("");
-	__ofono_modemwatch_remove(modem_watch_id);
-	modem_watch_id = 0;
-	g_slist_free_full(modems, (GDestroyNotify)pf_free_modem);
-	modems = NULL;
-	g_slist_free_full(handlers, pf_free_handler);
-	handlers = NULL;
-	if (inotify_watch_source_id == 0)
-		return;
-
-	g_source_remove(inotify_watch_source_id);
-	inotify_watch_source_id = 0;
-	g_io_channel_unref(inotify_watch_channel);
-	inotify_watch_channel = NULL;
-	inotify_rm_watch(inotify_fd, inotify_watch_id);
-	inotify_watch_id = -1;
-	close(inotify_fd);
-	inotify_fd = -1;
-}
-
-OFONO_PLUGIN_DEFINE(push_forwarder, "Push Forwarder Plugin", VERSION,
-		OFONO_PLUGIN_PRIORITY_DEFAULT, pf_plugin_init,
-		pf_plugin_exit)

ofono/plugins/ril.c

@@ -63,7 +63,6 @@
 #include <ofono/types.h>
 #include <ofono/message-waiting.h>
 #include <ofono/oemraw.h>
-#include <ofono/stk.h>
 
 #include "drivers/rilmodem/rilmodem.h"
 
@@ -98,10 +97,10 @@ struct ril_data {
 static guint mce_daemon_watch;
 static guint signal_watch;
 static DBusConnection *connection;
-gboolean reconnecting = FALSE;
 
 static int ril_init(void);
-static void ril_exit(void);
+guint reconnect_timer;
+
 static int send_get_sim_status(struct ofono_modem *modem);
 
 static void ril_debug(const char *str, void *user_data)
@@ -222,6 +221,9 @@ static void ril_remove(struct ofono_modem *modem)
 	if (ril->timer_id > 0)
 		g_source_remove(ril->timer_id);
 
+	if (reconnect_timer > 0)
+		g_source_remove(ril->timer_id);
+
 	g_ril_unref(ril->modem);
 
 	g_free(ril);
@@ -268,7 +270,6 @@ static void ril_post_sim(struct ofono_modem *modem)
 	ofono_phonebook_create(modem, 0, "rilmodem", ril->modem);
 	ofono_call_forwarding_create(modem, 0, "rilmodem", ril->modem);
 	ofono_call_barring_create(modem, 0, "rilmodem", ril->modem);
-	ofono_stk_create(modem, 0, "rilmodem", ril->modem);
 
 	mw = ofono_message_waiting_create(modem);
 	if (mw)
@@ -285,6 +286,7 @@ static void ril_post_online(struct ofono_modem *modem)
 	ofono_netreg_create(modem, 0, "rilmodem", ril->modem);
 	ofono_ussd_create(modem, 0, "rilmodem", ril->modem);
 	ofono_call_settings_create(modem, 0, "rilmodem", ril->modem);
+	ofono_cbs_create(modem, 0, "rilmodem", ril->modem);
 	ofono_oem_raw_create(modem, 0, "rilmodem", ril->modem);
 }
 
@@ -412,29 +414,20 @@ static void ril_connected(struct ril_msg *message, gpointer user_data)
 
 static gboolean ril_re_init(gpointer user_data)
 {
-	if (reconnecting) {
 	ril_init();
-		return TRUE;
-	} else {
 	return FALSE;
 }
-}
 
 static void gril_disconnected(gpointer user_data)
 {
-	/* Signal clients modem going down
+	/* Signal clients modem going down */
-	 */
 	struct ofono_modem *modem = user_data;
 	DBusConnection *conn = ofono_dbus_get_connection();
 
-	if (ofono_modem_is_registered(modem)) {
+	if (modem) {
 		ofono_modem_remove(modem);
 		mce_disconnect(conn, user_data);
-	}
+		reconnect_timer = g_timeout_add_seconds(2, ril_re_init, NULL);
-
-	if (!reconnecting) {
-		reconnecting = TRUE;
-		g_timeout_add_seconds(2, ril_re_init, NULL);
 	}
 }
 
@@ -492,8 +485,6 @@ static int ril_enable(struct ofono_modem *modem)
 		return -EIO;
 	}
 
-	reconnecting = FALSE;
-
 	if (getenv("OFONO_RIL_TRACE"))
 		g_ril_set_trace(ril->modem, TRUE);
 
@@ -589,6 +580,23 @@ static int ril_init(void)
 	retval = ofono_modem_register(modem);
 	DBG("ofono_modem_register returned: %d", retval);
 
+	/* kickstart the modem:
+	 * causes core modem code to call
+	 * - set_powered(TRUE) - which in turn
+	 *   calls driver->enable()
+	 *
+	 * - driver->pre_sim()
+	 *
+	 * Could also be done via:
+	 *
+	 * - a DBus call to SetProperties w/"Powered=TRUE" *1
+	 * - sim_state_watch ( handles SIM removal? LOCKED states? **2
+	 * - ofono_modem_set_powered()
+	 */
+	ofono_modem_reset(modem);
+
+	reconnect_timer = 0;
+
 	return retval;
 }
 

ofono/src/call-forwarding.c

@@ -713,12 +713,8 @@ static DBusMessage *set_property_request(struct ofono_call_forwarding *cf,
 	if (ph->number[0] != '\0')
 		cf->driver->registration(cf, type, cls, ph, timeout,
 					set_property_callback, cf);
-	else {
+	else
-		if (cf->query_next == CALL_FORWARDING_TYPE_UNCONDITIONAL)
-			cf->query_end = CALL_FORWARDING_TYPE_NOT_REACHABLE;
-
 		cf->driver->erasure(cf, type, cls, set_property_callback, cf);
-	}
 
 	return NULL;
 }

ofono/src/dbus.c

@@ -48,7 +48,7 @@ struct error_mapping_entry cme_errors_mapping[] = {
 };
 
 static void append_variant(DBusMessageIter *iter,
-				int type, const void *value)
+				int type, void *value)
 {
 	char sig[2];
 	DBusMessageIter valueiter;
@@ -65,7 +65,7 @@ static void append_variant(DBusMessageIter *iter,
 }
 
 void ofono_dbus_dict_append(DBusMessageIter *dict,
-			const char *key, int type, const void *value)
+			const char *key, int type, void *value)
 {
 	DBusMessageIter keyiter;
 
@@ -85,8 +85,7 @@ void ofono_dbus_dict_append(DBusMessageIter *dict,
 	dbus_message_iter_close_container(dict, &keyiter);
 }
 
-static void append_array_variant(DBusMessageIter *iter, int type,
+static void append_array_variant(DBusMessageIter *iter, int type, void *val)
-				const void *val)
 {
 	DBusMessageIter variant, array;
 	char typesig[2];
@@ -114,7 +113,7 @@ static void append_array_variant(DBusMessageIter *iter, int type,
 }
 
 void ofono_dbus_dict_append_array(DBusMessageIter *dict, const char *key,
-				int type, const void *val)
+				int type, void *val)
 {
 	DBusMessageIter entry;
 
@@ -128,8 +127,7 @@ void ofono_dbus_dict_append_array(DBusMessageIter *dict, const char *key,
 	dbus_message_iter_close_container(dict, &entry);
 }
 
-static void append_dict_variant(DBusMessageIter *iter, int type,
+static void append_dict_variant(DBusMessageIter *iter, int type, void *val)
-				const void *val)
 {
 	DBusMessageIter variant, array, entry;
 	char typesig[5];
@@ -184,7 +182,7 @@ static void append_dict_variant(DBusMessageIter *iter, int type,
 }
 
 void ofono_dbus_dict_append_dict(DBusMessageIter *dict, const char *key,
-				int type, const void *val)
+				int type, void *val)
 {
 	DBusMessageIter entry;
 
@@ -202,7 +200,7 @@ int ofono_dbus_signal_property_changed(DBusConnection *conn,
 					const char *path,
 					const char *interface,
 					const char *name,
-					int type, const void *value)
+					int type, void *value)
 {
 	DBusMessage *signal;
 	DBusMessageIter iter;
@@ -227,7 +225,7 @@ int ofono_dbus_signal_array_property_changed(DBusConnection *conn,
 						const char *path,
 						const char *interface,
 						const char *name,
-						int type, const void *value)
+						int type, void *value)
 
 {
 	DBusMessage *signal;
@@ -253,7 +251,7 @@ int ofono_dbus_signal_dict_property_changed(DBusConnection *conn,
 						const char *path,
 						const char *interface,
 						const char *name,
-						int type, const void *value)
+						int type, void *value)
 
 {
 	DBusMessage *signal;

ofono/src/gprs.c

@@ -57,7 +57,6 @@
 #define MAX_MESSAGE_CENTER_LENGTH 255
 #define MAX_CONTEXTS 256
 #define SUSPEND_TIMEOUT 8
-#define MAX_MMS_MTU 1280
 
 /* 27.007 Section 7.29 */
 enum packet_bearer {
@@ -759,31 +758,6 @@ static void pri_reset_context_settings(struct pri_context *ctx)
 	g_free(interface);
 }
 
-static void pri_limit_mtu(const char *interface, int max_mtu)
-{
-	struct ifreq ifr;
-	int sk;
-
-	if (interface == NULL)
-		return;
-
-	sk = socket(PF_INET, SOCK_DGRAM, 0);
-	if (sk < 0)
-		return;
-
-	memset(&ifr, 0, sizeof(ifr));
-	strncpy(ifr.ifr_name, interface, IFNAMSIZ);
-
-	if (ioctl(sk, SIOCGIFMTU, &ifr) < 0 || ifr.ifr_mtu > max_mtu) {
-		ifr.ifr_mtu = max_mtu;
-
-		if (ioctl(sk, SIOCSIFMTU, &ifr) < 0)
-			ofono_error("Failed to set MTU");
-	}
-
-	close(sk);
-}
-
 static void pri_update_mms_context_settings(struct pri_context *ctx)
 {
 	struct ofono_gprs_context *gc = ctx->context_driver;
@@ -800,8 +774,6 @@ static void pri_update_mms_context_settings(struct pri_context *ctx)
 
 	if (ctx->proxy_host)
 		pri_setproxy(settings->interface, ctx->proxy_host);
-
-	pri_limit_mtu(settings->interface, MAX_MMS_MTU);
 }
 
 static void append_context_properties(struct pri_context *ctx,
@@ -3044,56 +3016,14 @@ static void ofono_gprs_finish_register(struct ofono_gprs *gprs)
 	__ofono_atom_register(gprs->atom, gprs_unregister);
 }
 
-static gboolean mms_context_configured(struct ofono_gprs *gprs)
-{
-	GSList *l;
-
-	for (l = gprs->contexts; l; l = l->next) {
-		struct pri_context *ctx = l->data;
-
-		if (ctx->type == OFONO_GPRS_CONTEXT_TYPE_MMS)
-			return TRUE;
-	}
-
-	return FALSE;
-}
-
-static void provision_mms_context(struct ofono_gprs *gprs, const char *mcc,
-				const char *mnc, const char *spn)
-{
-	struct ofono_gprs_provision_data *settings;
-	int count;
-	int i;
-
-	if (__ofono_gprs_provision_get_settings(mcc, mnc, spn,
-						&settings, &count) == FALSE) {
-		ofono_warn("Provisioning failed");
-		return;
-	}
-
-	for (i = 0; i < count; i++) {
-		if (settings[i].type == OFONO_GPRS_CONTEXT_TYPE_MMS) {
-			provision_context(&settings[i], gprs);
-			break;
-		}
-	}
-
-	__ofono_gprs_provision_free_settings(settings, count);
-}
-
 static void spn_read_cb(const char *spn, const char *dc, void *data)
 {
 	struct ofono_gprs *gprs	= data;
 	struct ofono_modem *modem = __ofono_atom_get_modem(gprs->atom);
 	struct ofono_sim *sim = __ofono_atom_find(OFONO_ATOM_TYPE_SIM, modem);
 
-	if (gprs->contexts == NULL) {
 	provision_contexts(gprs, ofono_sim_get_mcc(sim),
 					ofono_sim_get_mnc(sim), spn);
-	} else if (!mms_context_configured(gprs)) {
-		provision_mms_context(gprs, ofono_sim_get_mcc(sim),
-					ofono_sim_get_mnc(sim), spn);
-	}
 
 	ofono_sim_remove_spn_watch(sim, &gprs->spn_watch);
 
@@ -3110,7 +3040,7 @@ void ofono_gprs_register(struct ofono_gprs *gprs)
 
 	gprs_load_settings(gprs, ofono_sim_get_imsi(sim));
 
-	if (mms_context_configured(gprs))
+	if (gprs->contexts)
 		goto finish;
 
 	ofono_sim_add_spn_watch(sim, &gprs->spn_watch, spn_read_cb, gprs, NULL);

ofono/src/log.c

@@ -289,8 +289,7 @@ void __ofono_log_enable(struct ofono_debug_desc *start,
 }
 
 int __ofono_log_init(const char *program, const char *debug,
-						ofono_bool_t detach,
+						ofono_bool_t detach)
-						ofono_bool_t backtrace)
 {
 	static char path[PATH_MAX];
 	int option = LOG_NDELAY | LOG_PID;
@@ -306,7 +305,6 @@ int __ofono_log_init(const char *program, const char *debug,
 	if (detach == FALSE)
 		option |= LOG_PERROR;
 
-	if (backtrace == TRUE)
 	signal_setup(signal_handler);
 
 	openlog(basename(program), option, LOG_DAEMON);
@@ -316,13 +314,12 @@ int __ofono_log_init(const char *program, const char *debug,
 	return 0;
 }
 
-void __ofono_log_cleanup(ofono_bool_t backtrace)
+void __ofono_log_cleanup(void)
 {
 	syslog(LOG_INFO, "Exit");
 
 	closelog();
 
-	if (backtrace == TRUE)
 	signal_setup(SIG_DFL);
 
 	g_strfreev(enabled);

ofono/src/main.c

@@ -133,7 +133,6 @@ static gchar *option_plugin = NULL;
 static gchar *option_noplugin = NULL;
 static gboolean option_detach = TRUE;
 static gboolean option_version = FALSE;
-static gboolean option_backtrace = TRUE;
 
 static gboolean parse_debug(const char *key, const char *value,
 					gpointer user_data, GError **error)
@@ -159,9 +158,6 @@ static GOptionEntry options[] = {
 				"Don't run as daemon in background" },
 	{ "version", 'v', 0, G_OPTION_ARG_NONE, &option_version,
 				"Show version information and exit" },
-	{ "nobacktrace", 0, G_OPTION_FLAG_REVERSE,
-				G_OPTION_ARG_NONE, &option_backtrace,
-				"Don't print out backtrace information" },
 	{ NULL },
 };
 
@@ -217,8 +213,7 @@ int main(int argc, char **argv)
 
 	signal = setup_signalfd();
 
-	__ofono_log_init(argv[0], option_debug, option_detach,
+	__ofono_log_init(argv[0], option_debug, option_detach);
-							option_backtrace);
 
 	dbus_error_init(&error);
 
@@ -269,7 +264,7 @@ cleanup:
 
 	g_main_loop_unref(event_loop);
 
-	__ofono_log_cleanup(option_backtrace);
+	__ofono_log_cleanup();
 
 	return 0;
 }

ofono/src/network.c

@@ -2106,6 +2106,9 @@ void ofono_netreg_register(struct ofono_netreg *netreg)
 		ofono_sim_add_spn_watch(netreg->sim, &netreg->spn_watch,
 						spn_read_cb, netreg, NULL);
 
+		if (__ofono_sim_service_available(netreg->sim,
+				SIM_UST_SERVICE_PROVIDER_DISPLAY_INFO,
+				SIM_SST_SERVICE_PROVIDER_DISPLAY_INFO)) {
 			ofono_sim_read(netreg->sim_context, SIM_EFSPDI_FILEID,
 					OFONO_SIM_FILE_STRUCTURE_TRANSPARENT,
 					sim_spdi_read_cb, netreg);
@@ -2115,6 +2118,7 @@ void ofono_netreg_register(struct ofono_netreg *netreg)
 							sim_spdi_changed,
 							netreg, NULL);
 		}
+	}
 
 	__ofono_atom_register(netreg->atom, netreg_unregister);
 

ofono/src/ofono.conf

@@ -15,7 +15,6 @@
     <allow send_interface="org.ofono.SmartMessagingAgent"/>
     <allow send_interface="org.ofono.PositioningRequestAgent"/>
     <allow send_interface="org.ofono.HandsfreeAudioAgent"/>
-    <allow send_interface="org.ofono.VoiceCallAgent"/>
   </policy>
 
   <policy user="radio">
@@ -26,7 +25,6 @@
     <allow send_interface="org.ofono.SmartMessagingAgent"/>
     <allow send_interface="org.ofono.PositioningRequestAgent"/>
     <allow send_interface="org.ofono.HandsfreeAudioAgent"/>
-    <allow send_interface="org.ofono.VoiceCallAgent"/>
   </policy>
 
   <policy at_console="true">

ofono/src/ofono.h

@@ -38,9 +38,8 @@ void __ofono_modem_shutdown(void);
 #include <ofono/log.h>
 
 int __ofono_log_init(const char *program, const char *debug,
-						ofono_bool_t detach,
+						ofono_bool_t detach);
-						ofono_bool_t backtrace);
+void __ofono_log_cleanup(void);
-void __ofono_log_cleanup(ofono_bool_t backtrace);
 void __ofono_log_enable(struct ofono_debug_desc *start,
 					struct ofono_debug_desc *stop);
 

ofono/src/ofono.service.in

@@ -1,14 +1,13 @@
 [Unit]
 Description=Telephony service
-Requires=dbus.service
+After=syslog.target
-After=dbus.service
 
 [Service]
 Type=dbus
 BusName=org.ofono
 User=root
 EnvironmentFile=-/var/lib/environment/ofono/*.conf
-ExecStart=@prefix@/sbin/ofonod -n --nobacktrace $OFONO_ARGS
+ExecStart=@prefix@/sbin/ofonod -n $OFONO_ARGS
 StandardError=null
 Restart=always
 RestartSec=3

ofono/src/simutil.c

@@ -767,14 +767,12 @@ static char *sim_network_name_parse(const unsigned char *buffer, int length,
 					gboolean *add_ci)
 {
 	char *ret = NULL;
+	unsigned char *endp;
 	unsigned char dcs;
 	int i;
 	gboolean ci = FALSE;
-	unsigned char *unpacked_buf;
-	long num_char, written;
-	int spare_bits;
 
-	if (length < 2)
+	if (length < 1)
 		return NULL;
 
 	dcs = *buffer++;
@@ -789,18 +787,11 @@ static char *sim_network_name_parse(const unsigned char *buffer, int length,
 
 	switch (dcs & (7 << 4)) {
 	case 0x00:
-		spare_bits = dcs & 0x07;
+		endp = memchr(buffer, 0xff, length);
-		num_char = (length * 8 - spare_bits) / 7;
+		if (endp)
-
+			length = endp - buffer;
-		unpacked_buf = unpack_7bit(buffer, length, 0, FALSE,
+		ret = convert_gsm_to_utf8(buffer, length,
-						num_char, &written, 0);
+				NULL, NULL, 0xff);
-		if (unpacked_buf == NULL)
-			break;
-
-		ret = convert_gsm_to_utf8(unpacked_buf, written, NULL, NULL, 0);
-
-		g_free(unpacked_buf);
-
 		break;
 	case 0x10:
 		if ((length % 2) == 1) {

ofono/src/stk.c

@@ -737,11 +737,6 @@ static DBusMessage *stk_register_agent(DBusConnection *conn,
 	if (stk->session_agent == NULL)
 		stk->current_agent = stk->default_agent;
 
-	if (stk->driver && stk->driver->ready) {
-		DBG("Report driver agent is ready");
-		stk->driver->ready(stk);
-	}
-
 	return dbus_message_new_method_return(msg);
 }
 

ofono/src/voicecall.c

@@ -3,7 +3,6 @@
  *  oFono - Open Source Telephony
  *
  *  Copyright (C) 2008-2011  Intel Corporation. All rights reserved.
- *  Copyright (C) 2014 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -39,7 +38,6 @@
 #include "simutil.h"
 #include "smsutil.h"
 #include "storage.h"
-#include "voicecallagent.h"
 
 #define MAX_VOICE_CALLS 16
 
@@ -77,7 +75,6 @@ struct ofono_voicecall {
 	ofono_voicecall_cb_t release_queue_done_cb;
 	struct ofono_emulator *pending_em;
 	unsigned int pending_id;
-	struct voicecall_agent *vc_agent;
 };
 
 struct voicecall {
@@ -558,11 +555,6 @@ static DBusMessage *voicecall_hangup(DBusConnection *conn,
 	struct ofono_voicecall *vc = v->vc;
 	struct ofono_call *call = v->call;
 	gboolean single_call = vc->call_list->next == 0;
-	struct tone_queue_entry *tone_entry = NULL;
-
-	/* clear any remaining tones */
-	while ((tone_entry = g_queue_peek_head(vc->toneq)))
-		tone_request_finish(vc, tone_entry, ENOENT, TRUE);
 
 	if (vc->pending || vc->pending_em)
 		return __ofono_error_busy(msg);
@@ -2148,72 +2140,6 @@ static DBusMessage *manager_get_calls(DBusConnection *conn,
 	return reply;
 }
 
-static void voicecall_agent_notify(gpointer user_data)
-{
-	struct ofono_voicecall *vc = user_data;
-	vc->vc_agent = NULL;
-}
-
-static DBusMessage *voicecall_register_agent(DBusConnection *conn,
-					DBusMessage *msg, void *data)
-{
-	struct ofono_voicecall *vc = data;
-	const char *agent_path;
-
-	if (vc->vc_agent)
-		return __ofono_error_busy(msg);
-
-	if (dbus_message_get_args(msg, NULL, DBUS_TYPE_OBJECT_PATH,
-				&agent_path, DBUS_TYPE_INVALID) == FALSE)
-		return __ofono_error_invalid_args(msg);
-
-	if (!__ofono_dbus_valid_object_path(agent_path))
-		return __ofono_error_invalid_format(msg);
-
-	vc->vc_agent = voicecall_agent_new(agent_path,
-						dbus_message_get_sender(msg));
-
-	if (vc->vc_agent == NULL)
-		return __ofono_error_failed(msg);
-
-	voicecall_agent_set_removed_notify(vc->vc_agent,
-			voicecall_agent_notify, vc);
-
-	return dbus_message_new_method_return(msg);
-}
-
-static DBusMessage *voicecall_unregister_agent(DBusConnection *conn,
-						DBusMessage *msg, void *data)
-{
-	struct ofono_voicecall *vc = data;
-	const char *agent_path;
-	const char *agent_bus = dbus_message_get_sender(msg);
-
-	if (dbus_message_get_args(msg, NULL, DBUS_TYPE_OBJECT_PATH, &agent_path,
-					DBUS_TYPE_INVALID) == FALSE)
-		return __ofono_error_invalid_args(msg);
-
-	if (vc->vc_agent == NULL)
-		return __ofono_error_failed(msg);
-
-	if (!voicecall_agent_matches(vc->vc_agent, agent_path, agent_bus))
-		return __ofono_error_access_denied(msg);
-
-	if (vc->vc_agent) {
-		voicecall_agent_free(vc->vc_agent);
-		vc->vc_agent = NULL;
-	}
-
-	return dbus_message_new_method_return(msg);
-}
-
-void ofono_voicecall_ringback_tone_notify(struct ofono_voicecall *vc,
-						const ofono_bool_t playTone)
-{
-	if (vc->vc_agent)
-		voicecall_agent_ringback_tone(vc->vc_agent, playTone);
-}
-
 static const GDBusMethodTable manager_methods[] = {
 	{ GDBUS_METHOD("GetProperties",
 			NULL, GDBUS_ARGS({ "properties", "a{sv}" }),
@@ -2246,12 +2172,6 @@ static const GDBusMethodTable manager_methods[] = {
 	{ GDBUS_METHOD("GetCalls",
 		NULL, GDBUS_ARGS({ "calls_with_properties", "a(oa{sv})" }),
 		manager_get_calls) },
-	{ GDBUS_ASYNC_METHOD("RegisterVoicecallAgent",
-				GDBUS_ARGS({ "path", "o" }), NULL,
-				voicecall_register_agent) },
-	{ GDBUS_ASYNC_METHOD("UnregisterVoicecallAgent",
-				GDBUS_ARGS({ "path", "o" }), NULL,
-				voicecall_unregister_agent) },
 	{ }
 };
 
@@ -2824,11 +2744,6 @@ static void voicecall_unregister(struct ofono_atom *atom)
 
 	voicecall_close_settings(vc);
 
-	if (vc->vc_agent) {
-		voicecall_agent_free(vc->vc_agent);
-		vc->vc_agent = 0;
-	}
-
 	if (vc->sim_state_watch) {
 		ofono_sim_remove_state_watch(vc->sim, vc->sim_state_watch);
 		vc->sim_state_watch = 0;
@@ -2944,24 +2859,19 @@ static void read_sim_ecc_numbers(int id, void *userdata)
 			ecc_g3_read_cb, vc);
 }
 
-static void get_ecc_numbers(struct ofono_voicecall *vc)
-{
-	if (vc->sim_context == NULL) {
-		vc->sim_context = ofono_sim_context_create(vc->sim);
-		ofono_sim_add_file_watch(vc->sim_context, SIM_EFECC_FILEID,
-					read_sim_ecc_numbers, vc, NULL);
-	}
-
-	read_sim_ecc_numbers(SIM_EFECC_FILEID, vc);
-}
-
 static void sim_state_watch(enum ofono_sim_state new_state, void *user)
 {
 	struct ofono_voicecall *vc = user;
 
 	switch (new_state) {
 	case OFONO_SIM_STATE_INSERTED:
-		get_ecc_numbers(vc);
+		if (vc->sim_context == NULL)
+			vc->sim_context = ofono_sim_context_create(vc->sim);
+
+		read_sim_ecc_numbers(SIM_EFECC_FILEID, vc);
+
+		ofono_sim_add_file_watch(vc->sim_context, SIM_EFECC_FILEID,
+						read_sim_ecc_numbers, vc, NULL);
 		break;
 	case OFONO_SIM_STATE_NOT_PRESENT:
 	case OFONO_SIM_STATE_RESETTING:
@@ -2978,8 +2888,6 @@ static void sim_state_watch(enum ofono_sim_state new_state, void *user)
 		voicecall_close_settings(vc);
 		break;
 	case OFONO_SIM_STATE_READY:
-		get_ecc_numbers(vc);
-
 		voicecall_load_settings(vc);
 		break;
 	case OFONO_SIM_STATE_LOCKED_OUT:

ofono/src/voicecallagent.c

@@ -1,131 +0,0 @@
-/*
- *
- *  oFono - Open Source Telephony
- *
- *  Copyright (C) 2014 Jolla Ltd
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
- *
- */
-
-#include <glib.h>
-#include <gdbus.h>
-
-#include "ofono.h"
-#include "voicecallagent.h"
-
-#define OFONO_VOICECALL_AGENT_INTERFACE "org.ofono.VoiceCallAgent"
-
-struct voicecall_agent {
-	char *path;			/* Agent Path */
-	char *bus;			/* Agent bus */
-	guint disconnect_watch;		/* DBus disconnect watch */
-	ofono_destroy_func removed_cb;
-	void *removed_data;
-};
-
-void voicecall_agent_ringback_tone(struct voicecall_agent *agent,
-					const ofono_bool_t playTone)
-{
-	DBusConnection *conn = ofono_dbus_get_connection();
-	DBusMessage *message = dbus_message_new_method_call(
-			agent->bus, agent->path,
-			OFONO_VOICECALL_AGENT_INTERFACE,
-			"RingbackTone");
-
-	if (message == NULL)
-		return;
-
-	if (!dbus_message_append_args(message, DBUS_TYPE_BOOLEAN, &playTone,
-				DBUS_TYPE_INVALID))
-		return;
-
-	dbus_message_set_no_reply(message, TRUE);
-	g_dbus_send_message(conn, message);
-}
-
-void voicecall_agent_send_release(struct voicecall_agent *agent)
-{
-	DBusConnection *conn = ofono_dbus_get_connection();
-	DBusMessage *message = dbus_message_new_method_call(
-			agent->bus, agent->path,
-			OFONO_VOICECALL_AGENT_INTERFACE,
-			"Release");
-
-	if (message == NULL)
-		return;
-
-	dbus_message_set_no_reply(message, TRUE);
-	g_dbus_send_message(conn, message);
-}
-
-void voicecall_agent_set_removed_notify(struct voicecall_agent *agent,
-					ofono_destroy_func destroy,
-					void *user_data)
-{
-	agent->removed_cb = destroy;
-	agent->removed_data = user_data; /* voicecall atom (not owned) */
-}
-
-void voicecall_agent_free(struct voicecall_agent *agent)
-{
-	DBusConnection *conn = ofono_dbus_get_connection();
-
-	if (agent->disconnect_watch) {
-		voicecall_agent_send_release(agent);
-		g_dbus_remove_watch(conn, agent->disconnect_watch);
-		agent->disconnect_watch = 0;
-	}
-
-	if (agent->removed_cb)
-		agent->removed_cb(agent->removed_data);
-
-	g_free(agent->path);
-	g_free(agent->bus);
-	g_free(agent);
-}
-
-ofono_bool_t voicecall_agent_matches(struct voicecall_agent *agent,
-				const char *path, const char *sender)
-{
-	return g_str_equal(agent->path, path) &&
-			g_str_equal(agent->bus, sender);
-}
-
-void voicecall_agent_disconnect_cb(DBusConnection *conn, void *user_data)
-{
-	struct voicecall_agent *agent = user_data;
-
-	agent->disconnect_watch = 0;
-	voicecall_agent_free(agent);
-}
-
-struct voicecall_agent *voicecall_agent_new(const char *path,
-						const char *sender)
-{
-	struct voicecall_agent *agent = g_try_new0(struct voicecall_agent, 1);
-	DBusConnection *conn = ofono_dbus_get_connection();
-
-	if (agent == NULL)
-		return NULL;
-
-	agent->path = g_strdup(path);
-	agent->bus = g_strdup(sender);
-
-	agent->disconnect_watch = g_dbus_add_disconnect_watch(conn, sender,
-						voicecall_agent_disconnect_cb,
-						agent, NULL);
-
-	return agent;
-}

ofono/src/voicecallagent.h

@@ -1,40 +0,0 @@
-/*
- *
- *  oFono - Open Source Telephony
- *
- *  Copyright (C) 2014 Jolla Ltd
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
- *
- */
-
-struct voicecall_agent;
-
-void voicecall_agent_ringback_tone(struct voicecall_agent *agent,
-					const ofono_bool_t playTone);
-
-void voicecall_agent_set_removed_notify(struct voicecall_agent *agent,
-					ofono_destroy_func removed_cb,
-					void *user_data);
-
-void voicecall_agent_free(struct voicecall_agent *agent);
-
-ofono_bool_t voicecall_agent_matches(struct voicecall_agent *agent,
-					const char *path, const char *sender);
-
-struct voicecall_agent *voicecall_agent_new(const char *path,
-						const char *sender);
-
-void voicecall_agent_disconnect_cb(DBusConnection *conn,
-		void *user_data);

ofono/test/test-voicecallagent

@@ -1,48 +0,0 @@
-#!/usr/bin/python
-
-import gobject
-
-import sys
-import dbus
-import dbus.service
-import dbus.mainloop.glib
-
-class VoiceCallAgent(dbus.service.Object):
-	@dbus.service.method("org.ofono.VoiceCallAgent",
-					in_signature="", out_signature="")
-	def Release(self):
-		print "Agent got Release"
-		mainloop.quit()
-
-	@dbus.service.method("org.ofono.VoiceCallAgent",
-				in_signature="b", out_signature="")
-	def RingbackTone(self, playTone):
-		print "Agent got playTone notification: %d" % playTone
-
-if __name__ == '__main__':
-	dbus.mainloop.glib.DBusGMainLoop(set_as_default=True)
-
-	bus = dbus.SystemBus()
-	manager = dbus.Interface(bus.get_object("org.ofono", "/"),
-							"org.ofono.Manager")
-
-	modems = manager.GetModems()
-
-	for path, properties in modems:
-		if "org.ofono.VoiceCallManager" not in properties["Interfaces"]:
-			continue
-
-		vcm = dbus.Interface(bus.get_object('org.ofono', path),
-					'org.ofono.VoiceCallManager')
-
-	path = "/test/agent"
-	agent = VoiceCallAgent(bus, path)
-	vcm.RegisterVoicecallAgent(agent)
-	print "Agent registered"
-	mainloop = gobject.MainLoop()
-
-	try:
-		mainloop.run()
-	except KeyboardInterrupt:
-		vcm.UnregisterVoicecallAgent(path)
-		print "Agent unregistered (interrupt)"

ofono/unit/test-provision.c

@@ -1,99 +0,0 @@
-/*
- *
- *  oFono - Open Source Telephony
- *
- *  Copyright (C) 2014 Jolla. All rights reserved.
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
- *
- */
-
-#ifdef HAVE_CONFIG_H
-#include <config.h>
-#endif
-
-#include <glib.h>
-struct ofono_modem;
-#include <gprs-provision.h>
-#include "plugins/mbpi.h"
-#include "plugins/provision.h"
-
-
-void get_and_print_settings(const char *mcc, const char *mnc,
-		const char *spn)
-{
-	struct ofono_gprs_provision_data *settings;
-	int count;
-	int i;
-	provision_get_settings(mcc, mnc, spn, &settings, &count);
-	g_print("Found %d contexts for (%s/%s/%s):\n", count, mcc, mnc, spn);
-	for (i = 0; i < count; i++){
-		struct ofono_gprs_provision_data ap = settings[i];
-		g_print("  Name: %s\n", ap.name);
-		g_print("  APN: %s\n", ap.apn);
-		g_print("  Type: %s\n", mbpi_ap_type(ap.type));
-		if (ap.username)
-			g_print("  Username: %s\n", ap.username);
-		if (ap.password)
-			g_print("  Password: %s\n", ap.password);
-		if (ap.message_proxy)
-			g_print("  MMS proxy: %s\n", ap.message_proxy);
-		if (ap.message_center)
-			g_print("  MMS center: %s\n", ap.message_center);
-		g_print("----------\n");
-	}
-}
-
-static void test_get_settings(void)
-{
-	/* not in database */
-	get_and_print_settings("999", "999", NULL);
-
-	/* partial and case-insensitive matching */
-	get_and_print_settings("244", "91", "sonera");
-	get_and_print_settings("244", "91", "sONErA");
-	get_and_print_settings("244", "91", "sone");
-	get_and_print_settings("244", "91", "nera");
-
-	/* related to Sonera/Finland network */
-	get_and_print_settings("244", "91", NULL);
-	get_and_print_settings("244", "91", "sonera");
-	get_and_print_settings("244", "91", "aina");
-
-	/* related to DNA/Finland network */
-	get_and_print_settings("244", "03", NULL);
-	get_and_print_settings("244", "03", "dna");
-	get_and_print_settings("244", "03", "aina");
-	get_and_print_settings("244", "04", NULL);
-	get_and_print_settings("244", "04", "dna");
-	get_and_print_settings("244", "04", "aina");
-
-	/* related to O2/UK network */
-	get_and_print_settings("234", "10", NULL);
-	get_and_print_settings("234", "10", "o2");
-	get_and_print_settings("234", "10", "tesco");
-	get_and_print_settings("234", "10", "giffgaff");
-
-	/* related to E-Plus/Germany network */
-	get_and_print_settings("262", "03", NULL);
-	get_and_print_settings("262", "03", "E-Plus");
-	get_and_print_settings("262", "03", "simyo");
-}
-
-int main(int argc, char **argv)
-{
-	g_test_init(&argc, &argv, NULL);
-	g_test_add_func("/testprovision/get_settings", test_get_settings);
-	return g_test_run();
-}

ofono/unit/test-simutil.c

@@ -345,21 +345,12 @@ const unsigned char valid_efopl[] = {
 };
 
 const unsigned char valid_efpnn[][28] = {
-	{ 0x43, 0x08, 0x00, 0xD4, 0x3A, 0x1E, 0x34, 0x7C, 0xB7, 0xDB,
+	{ 0x43, 0x0a, 0x00, 0x54, 0x75, 0x78, 0x20, 0x43, 0x6f, 0x6d,
-	  0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, },
+	  0x6d, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, },
 	{ 0x43, 0x05, 0x00, 0x4C, 0x6F, 0x6E, 0x67, 0x45, 0x06, 0x00,
 	  0x53, 0x68, 0x6F, 0x72, 0x74, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, }
 };
 
-const unsigned char valid_efpnn_2[][28] = {
-	/* Solavei */
-	{ 0x43, 0x08, 0x87, 0xD3, 0x37, 0x3B, 0x6C, 0x2F, 0xA7, 0x01 },
-	/* T-Mobile / T-Mobile */
-	{ 0x43, 0x08, 0x80, 0xD4, 0x56, 0xF3, 0x2D, 0x4E, 0xB3, 0xCB,
-	0x45, 0x08, 0x80, 0xD4, 0x56, 0xF3, 0x2D, 0x4E, 0xB3, 0xCB,
-	0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF }
-};
-
 static void test_eons(void)
 {
 	const struct sim_eons_operator_info *op_info;
@@ -369,7 +360,6 @@ static void test_eons(void)
 
 	g_assert(sim_eons_pnn_is_empty(eons_info));
 
-	/* 1. a fictious operator */
 	sim_eons_add_pnn_record(eons_info, 1,
 			valid_efpnn[0], sizeof(valid_efpnn[0]));
 	g_assert(!sim_eons_pnn_is_empty(eons_info));
@@ -390,27 +380,6 @@ static void test_eons(void)
 	g_assert(!op_info->shortname);
 	g_assert(!op_info->info);
 
-	/* 2. a real-world MVNO */
-	sim_eons_add_pnn_record(eons_info, 1,
-			valid_efpnn_2[0], sizeof(valid_efpnn_2[0]));
-	g_assert(!sim_eons_pnn_is_empty(eons_info));
-
-	sim_eons_add_pnn_record(eons_info, 2,
-			valid_efpnn_2[1], sizeof(valid_efpnn_2[1]));
-	g_assert(!sim_eons_pnn_is_empty(eons_info));
-
-	sim_eons_add_opl_record(eons_info, valid_efopl, sizeof(valid_efopl));
-	sim_eons_optimize(eons_info);
-
-	op_info = sim_eons_lookup(eons_info, "246", "82");
-	g_assert(op_info == NULL);
-	op_info = sim_eons_lookup(eons_info, "246", "81");
-	g_assert(op_info);
-
-	g_assert(!strcmp(op_info->longname, "Solavei"));
-	g_assert(!op_info->shortname);
-	g_assert(!op_info->info);
-
 	sim_eons_free(eons_info);
 }
 

ofono/unit/test-sms.c

@@ -1769,63 +1769,6 @@ static void test_wap_push(gconstpointer data)
 	g_slist_free(list);
 }
 
-static const char *simple_deliver_unicode = "0791534850020290"
-		"040c915348608475840008412060610141800e0054006500730074002062116211";
-
-static const char *simple_deliver_unicode_surrogate = "0791534850020290"
-		"040c915348608475840008412060610141800e00540065007300740020D83DDE3B";
-
-static void test_decode_unicode(void)
-{
-	struct sms sms;
-	unsigned char *pdu;
-	long pdu_len;
-	gboolean ret;
-	struct sms_assembly *assembly;
-	GSList *l;
-	char *decoded;
-
-	/* contains UCS-2 (Chinese characters) */
-	pdu = decode_hex(simple_deliver_unicode, -1, &pdu_len, 0);
-	g_assert(pdu);
-	g_assert(pdu_len == (long)strlen(simple_deliver_unicode) / 2);
-	ret = sms_decode(pdu, pdu_len, FALSE, 33, &sms);
-	g_free(pdu);
-
-	g_assert(ret);
-	g_assert(sms.type == SMS_TYPE_DELIVER);
-	g_assert(sms.deliver.udl == 14);
-
-	assembly = sms_assembly_new(NULL);
-	l = sms_assembly_add_fragment(assembly, &sms, time(NULL),
-			&sms.deliver.oaddr, 0, 1, 0);
-	g_assert(l);
-	g_assert(g_slist_length(l) == 1);
-	decoded = sms_decode_text(l);
-	sms_assembly_free(assembly);
-	g_assert(strcmp(decoded, "Test 我我") == 0);
-
-	/* contains UTF-16 (a Unicode surrogate pair representing an emoticon) */
-	pdu = decode_hex(simple_deliver_unicode_surrogate, -1, &pdu_len, 0);
-	g_assert(pdu);
-	g_assert(pdu_len == (long)strlen(simple_deliver_unicode_surrogate) / 2);
-	ret = sms_decode(pdu, pdu_len, FALSE, 33, &sms);
-	g_free(pdu);
-
-	g_assert(ret);
-	g_assert(sms.type == SMS_TYPE_DELIVER);
-	g_assert(sms.deliver.udl == 14);
-
-	assembly = sms_assembly_new(NULL);
-	l = sms_assembly_add_fragment(assembly, &sms, time(NULL),
-			&sms.deliver.oaddr, 0, 1, 0);
-	g_assert(l);
-	g_assert(g_slist_length(l) == 1);
-	decoded = sms_decode_text(l);
-	sms_assembly_free(assembly);
-	g_assert(strcmp(decoded, "Test 😻") == 0);
-}
-
 int main(int argc, char **argv)
 {
 	char long_string[152*33 + 1];
@@ -1907,7 +1850,5 @@ int main(int argc, char **argv)
 	g_test_add_data_func("/testsms/Test WAP Push 1", &wap_push_1,
 				test_wap_push);
 
-	g_test_add_func("/testsms/Test Decode Unicode", test_decode_unicode);
-
 	return g_test_run();
 }

rpm/ofono.spec

@@ -1,5 +1,13 @@
+# 
+# Do NOT Edit the Auto-generated Part!
+# Generated by: spectacle version 0.26
+# 
+
 Name:       ofono
 
+# >> macros
+# << macros
+
 Summary:    Open Source Telephony
 Version:    1.14
 Release:    1
@@ -7,6 +15,7 @@ Group:      Communications/Connectivity Adaptation
 License:    GPLv2
 URL:        http://ofono.org
 Source0:    http://www.kernel.org/pub/linux/network/ofono/ofono-%{version}.tar.xz
+Source100:  ofono.yaml
 Requires:   dbus
 Requires:   systemd
 Requires:   ofono-configs
@@ -18,7 +27,6 @@ BuildRequires:  pkgconfig(dbus-1)
 BuildRequires:  pkgconfig(libudev) >= 145
 BuildRequires:  pkgconfig(bluez) >= 4.85
 BuildRequires:  pkgconfig(mobile-broadband-provider-info)
-BuildRequires:  pkgconfig(libwspcodec) >= 2.0
 BuildRequires:  libtool
 BuildRequires:  automake
 BuildRequires:  autoconf
@@ -58,10 +66,14 @@ This package provides default configs for ofono
 %prep
 %setup -q -n %{name}-%{version}/%{name}
 
+# >> setup
 ./bootstrap
+# << setup
 
 %build
+# >> build pre
 autoreconf --force --install
+# << build pre
 
 %configure --disable-static \
     --enable-dundee \
@@ -70,58 +82,63 @@ autoreconf --force --install
 
 make %{?jobs:-j%jobs}
 
-
+# >> build post
-%check
+# << build post
-# run unit tests
-make check
 
 %install
 rm -rf %{buildroot}
+# >> install pre
+# << install pre
 %make_install
 
-mkdir -p %{buildroot}/%{_sysconfdir}/ofono/push_forwarder.d
+# >> install post
 mkdir -p %{buildroot}/%{_lib}/systemd/system/network.target.wants
 ln -s ../ofono.service %{buildroot}/%{_lib}/systemd/system/network.target.wants/ofono.service
+# << install post
 
 %preun
 if [ "$1" -eq 0 ]; then
-systemctl stop ofono.service ||:
+systemctl stop ofono.service
 fi
 
 %post
-systemctl daemon-reload ||:
+systemctl daemon-reload
-# Do not restart during update
+systemctl reload-or-try-restart ofono.service
-# We don't want to break anything during update
-# New daemon is taken in use after reboot
-# systemctl reload-or-try-restart ofono.service ||:
 
 %postun
-systemctl daemon-reload ||:
+systemctl daemon-reload
 
 %files
 %defattr(-,root,root,-)
+# >> files
 %doc COPYING ChangeLog AUTHORS README
-%config %{_sysconfdir}/dbus-1/system.d/*.conf
+%config(noreplace) %{_sysconfdir}/dbus-1/system.d/*.conf
 %{_sbindir}/*
 /%{_lib}/systemd/system/network.target.wants/ofono.service
 /%{_lib}/systemd/system/ofono.service
 /%{_lib}/systemd/system/dundee.service
 %dir %{_sysconfdir}/ofono/
-%dir %{_sysconfdir}/ofono/push_forwarder.d
 # This file is part of phonesim and not needed with ofono.
 %exclude %{_sysconfdir}/ofono/phonesim.conf
 %doc /usr/share/man/man8/ofonod.8.gz
 %dir %attr(775,radio,radio) /var/lib/ofono
+# << files
 
 %files devel
 %defattr(-,root,root,-)
 %{_includedir}/ofono/
 %{_libdir}/pkgconfig/ofono.pc
+# >> files devel
+# << files devel
 
 %files tests
 %defattr(-,root,root,-)
 %{_libdir}/%{name}/test/*
+# >> files tests
+# << files tests
 
 %files configs-mer
 %defattr(-,root,root,-)
 %config /etc/ofono/ril_subscription.conf
+# >> files ofono-configs-mer
+# << files ofono-configs-mer

rpm/ofono.yaml

@@ -0,0 +1,50 @@
+Name: ofono
+Summary: Open Source Telephony
+Description: Telephony stack
+Version: 1.14
+Release: 1
+Group: Communications/Connectivity Adaptation
+License: GPLv2
+URL: http://ofono.org
+Sources:
+    - http://www.kernel.org/pub/linux/network/ofono/ofono-%{version}.tar.xz
+Requires:
+    - dbus
+PkgBR:
+    - libtool
+    - automake
+    - autoconf
+PkgConfigBR:
+    - glib-2.0
+    - dbus-1
+    - libudev >= 145
+    - bluez >= 4.85
+    - mobile-broadband-provider-info
+SetupOptions: -q -n %{name}-%{version}/%{name}
+ConfigOptions:
+    - --enable-dundee
+    - --enable-test
+    - --with-systemdunitdir="/%{_lib}/systemd/system"
+SubPackages:
+    - Name: devel
+      Summary: Headers for oFono
+      Group: Development/Libraries
+      Description: Development headers and libraries for oFono
+      Files:
+         - "%{_includedir}/ofono/"
+         - "%{_libdir}/pkgconfig/ofono.pc"
+
+    - Name: tests
+      Summary: Test Scripts for oFono
+      Group: Development/Libraries
+      Description: Scripts for testing oFono and its functionality
+      Obsoletes: 
+         - "ofono-test < 1.0"
+      Provides:
+         - "ofono-test >= 1.0"
+      Requires: 
+         - dbus-python
+         - pygobject2
+      Files:
+         - "%{_libdir}/%{name}/test/*"
+