[ofono] Access control for SIM Toolkit agent. Fixes JB#49163

Non-privileged process will get org.ofono.Error.AccessDenied from
RegisterAgent. Other methods already check that D-Bus call is coming
from a registered agent.

ofono/Makefile.am

@@ -151,10 +151,8 @@ builtin_sources +=	drivers/ril/ril_call_barring.c \
 			drivers/ril/ril_devinfo.c \
 			drivers/ril/ril_devmon.c \
 			drivers/ril/ril_devmon_auto.c \
-			drivers/ril/ril_devmon_combine.c \
 			drivers/ril/ril_devmon_ds.c \
 			drivers/ril/ril_devmon_ss.c \
-			drivers/ril/ril_devmon_ur.c \
 			drivers/ril/ril_ecclist.c \
 			drivers/ril/ril_gprs.c \
 			drivers/ril/ril_gprs_context.c \

ofono/configure.ac

@@ -189,8 +189,8 @@ CFLAGS="$CFLAGS $GLIBUTIL_CFLAGS"
 LIBS="$LIBS $GLIBUTIL_LIBS"
 
 if (test "${enable_sailfish_rilmodem}" = "yes"); then
-	PKG_CHECK_MODULES(GRILIO, libgrilio >= 1.0.38, dummy=yes,
-				AC_MSG_ERROR(libgrilio >= 1.0.38 is required))
+	PKG_CHECK_MODULES(GRILIO, libgrilio >= 1.0.35, dummy=yes,
+				AC_MSG_ERROR(libgrilio >= 1.0.35 is required))
 	PKG_CHECK_MODULES(LIBMCE, libmce-glib >= 1.0.6, dummy=yes,
 				AC_MSG_ERROR(libmce-glib >= 1.0.6 is required))
 	CFLAGS="$CFLAGS $GRILIO_CFLAGS $LIBMCE_CFLAGS"

ofono/drivers/ril/ril_cbs.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2020 Jolla Ltd.
+ *  Copyright (C) 2015-2017 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -24,7 +24,6 @@ struct ril_cbs {
 	GRilIoChannel *io;
 	GRilIoQueue *q;
 	char *log_prefix;
-	guint register_id;
 	gulong event_id;
 };
 
@@ -52,12 +51,6 @@ static struct ril_cbs_cbd *ril_cbs_cbd_new(struct ril_cbs *cd,
 	return cbd;
 }
 
-static gboolean ril_cbs_retry(GRilIoRequest *request, int ril_status,
-               const void *resp_data, guint resp_len, void *user_data)
-{
-       return ril_status == RIL_E_INVALID_STATE;
-}
-
 static void ril_cbs_request_activation(struct ril_cbs *cd,
 		gboolean activate, GRilIoChannelResponseFunc response,
 		GDestroyNotify destroy, void* user_data)
@@ -68,9 +61,6 @@ static void ril_cbs_request_activation(struct ril_cbs *cd,
 	grilio_request_append_int32(req, activate ? 0 :1);
 
 	DBG_(cd, "%sactivating CB", activate ? "" : "de");
-	grilio_request_set_retry_func(req, ril_cbs_retry);
-	grilio_request_set_retry(req, RIL_CBS_CHECK_RETRY_MS,
-				RIL_CBS_CHECK_RETRY_COUNT);
 	grilio_queue_send_request_full(cd->q, req,
 				RIL_REQUEST_GSM_SMS_BROADCAST_ACTIVATION,
 				response, destroy, user_data);
@@ -107,9 +97,6 @@ static void ril_cbs_set_config(struct ril_cbs *cd, const char *topics,
 	}
 
 	DBG_(cd, "configuring CB");
-	grilio_request_set_retry_func(req, ril_cbs_retry);
-	grilio_request_set_retry(req, RIL_CBS_CHECK_RETRY_MS,
-			RIL_CBS_CHECK_RETRY_COUNT);
 	grilio_queue_send_request_full(cd->q, req,
 			RIL_REQUEST_GSM_SET_BROADCAST_SMS_CONFIG,
 			response, destroy, user_data);
@@ -157,41 +144,27 @@ static void ril_cbs_notify(GRilIoChannel *io, guint code,
 				const void *data, guint len, void *user_data)
 {
 	struct ril_cbs *cd = user_data;
-	GRilIoParser rilp;
-	guint32 pdu_len;
 
 	GASSERT(code == RIL_UNSOL_RESPONSE_NEW_BROADCAST_SMS);
-	grilio_parser_init(&rilp, data, len);
-	if (grilio_parser_get_uint32(&rilp, &pdu_len)) {
-		const void* pdu = grilio_parser_get_bytes(&rilp, pdu_len);
-
-		/*
-		 * By default assume that it's a length followed by the
-		 * binary PDU data.
-		 */
-		if (pdu && grilio_parser_bytes_remaining(&rilp) < 4) {
-			DBG_(cd, "%u bytes", pdu_len);
-			ofono_cbs_notify(cd->cbs, pdu, pdu_len);
-		} else {
-			/*
-			 * But I've seen cell broadcasts arriving without
-			 * the length, simply as a blob.
-			 */
-			ofono_cbs_notify(cd->cbs, data, len);
-		}
-	}
+	DBG_(cd, "%u bytes", len);
+	ofono_cbs_notify(cd->cbs, data, len);
 }
 
-static gboolean ril_cbs_register(void *user_data)
+static void ril_cbs_probe_done_cb(GRilIoChannel *io, int status,
+				const void *data, guint len, void *user_data)
 {
 	struct ril_cbs *cd = user_data;
 
-	DBG_(cd, "registering for CB");
-	cd->register_id = 0;
-	cd->event_id = grilio_channel_add_unsol_event_handler(cd->io,
-		ril_cbs_notify, RIL_UNSOL_RESPONSE_NEW_BROADCAST_SMS, cd);
-	ofono_cbs_register(cd->cbs);
-	return G_SOURCE_REMOVE;
+	if (status == RIL_E_SUCCESS) {
+		DBG_(cd, "registering for CB");
+		cd->event_id = grilio_channel_add_unsol_event_handler(cd->io,
+			ril_cbs_notify, RIL_UNSOL_RESPONSE_NEW_BROADCAST_SMS,
+									cd);
+		ofono_cbs_register(cd->cbs);
+	} else {
+		DBG_(cd, "failed to query CB config");
+		ofono_cbs_remove(cd->cbs);
+	}
 }
 
 static int ril_cbs_probe(struct ofono_cbs *cbs, unsigned int vendor,
@@ -199,6 +172,7 @@ static int ril_cbs_probe(struct ofono_cbs *cbs, unsigned int vendor,
 {
 	struct ril_modem *modem = data;
 	struct ril_cbs *cd = g_try_new0(struct ril_cbs, 1);
+	GRilIoRequest* req = grilio_request_new();
 
 	ofono_cbs_set_data(cbs, cd);
 	cd->log_prefix = (modem->log_prefix && modem->log_prefix[0]) ?
@@ -208,7 +182,20 @@ static int ril_cbs_probe(struct ofono_cbs *cbs, unsigned int vendor,
 	DBG_(cd, "");
 	cd->io = grilio_channel_ref(ril_modem_io(modem));
 	cd->q = grilio_queue_new(cd->io);
-	cd->register_id = g_idle_add(ril_cbs_register, cd);
+
+	/*
+	 * RIL_REQUEST_GSM_GET_BROADCAST_SMS_CONFIG often fails at startup
+	 * especially if other RIL requests are running in parallel. We may
+	 * have to retry a few times. Also, make it blocking in order to
+	 * improve the chance of success.
+	 */
+	grilio_request_set_retry(req, RIL_CBS_CHECK_RETRY_MS,
+						RIL_CBS_CHECK_RETRY_COUNT);
+	grilio_request_set_blocking(req, TRUE);
+	grilio_queue_send_request_full(cd->q, req,
+				RIL_REQUEST_GSM_GET_BROADCAST_SMS_CONFIG,
+				ril_cbs_probe_done_cb, NULL, cd);
+	grilio_request_unref(req);
 	return 0;
 }
 
@@ -217,9 +204,6 @@ static void ril_cbs_remove(struct ofono_cbs *cbs)
 	struct ril_cbs *cd = ofono_cbs_get_data(cbs);
 
 	DBG_(cd, "");
-	if (cd->register_id) {
-		g_source_remove(cd->register_id);
-	}
 	ofono_cbs_set_data(cbs, NULL);
 	grilio_channel_remove_handler(cd->io, cd->event_id);
 	grilio_channel_unref(cd->io);

ofono/drivers/ril/ril_cell_info.c

@@ -1,8 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2016-2020 Jolla Ltd.
- *  Copyright (C) 2020 Open Mobile Platform LLC.
+ *  Copyright (C) 2016-2019 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -345,24 +344,11 @@ static void ril_cell_info_set_rate_cb(GRilIoChannel *io, int status,
 	self->set_rate_id = 0;
 }
 
-static gboolean ril_cell_info_retry(GRilIoRequest* request, int ril_status,
-		const void* response_data, guint response_len, void* user_data)
-{
-	switch (ril_status) {
-	case RIL_E_SUCCESS:
-	case RIL_E_RADIO_NOT_AVAILABLE:
-		return FALSE;
-	default:
-		return TRUE;
-	}
-}
-
 static void ril_cell_info_query(struct ril_cell_info *self)
 {
 	GRilIoRequest *req = grilio_request_new();
 
 	grilio_request_set_retry(req, RIL_RETRY_MS, MAX_RETRIES);
-	grilio_request_set_retry_func(req, ril_cell_info_retry);
 	grilio_channel_cancel_request(self->io, self->query_id, FALSE);
 	self->query_id = grilio_channel_send_request_full(self->io, req,
 		RIL_REQUEST_GET_CELL_INFO_LIST, ril_cell_info_list_cb,
@@ -376,7 +362,6 @@ static void ril_cell_info_set_rate(struct ril_cell_info *self)
 		(self->update_rate_ms > 0) ? self->update_rate_ms : INT_MAX);
 
 	grilio_request_set_retry(req, RIL_RETRY_MS, MAX_RETRIES);
-	grilio_request_set_retry_func(req, ril_cell_info_retry);
 	grilio_channel_cancel_request(self->io, self->set_rate_id, FALSE);
 	self->set_rate_id = grilio_channel_send_request_full(self->io, req,
 			RIL_REQUEST_SET_UNSOL_CELL_INFO_LIST_RATE,

ofono/drivers/ril/ril_config.c

@@ -1,8 +1,8 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2020 Jolla Ltd.
- *  Copyright (C) 2019-2020 Open Mobile Platform LLC.
+ *  Copyright (C) 2015-2019 Jolla Ltd.
+ *  Copyright (C) 2019 Open Mobile Platform LLC.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -186,72 +186,6 @@ gboolean ril_config_get_enum(GKeyFile *file, const char *group,
 	return FALSE;
 }
 
-gboolean ril_config_get_mask(GKeyFile *file, const char *group,
-					const char *key, int *result,
-					const char *name, int value, ...)
-{
-	char *str = ril_config_get_string(file, group, key);
-	gboolean ok = FALSE;
-	
-	if (result) {
-		*result = 0;
-	}
-
-	if (str) {
-		/*
-		 * Some people are thinking that # is a comment
-		 * anywhere on the line, not just at the beginning
-		 */
-		char *comment = strchr(str, '#');
-		char **values, **ptr;
-
-		if (comment) *comment = 0;
-		values = g_strsplit(str, "+", -1);
-
-		for (ok = TRUE, ptr = values; *ptr && ok; ptr++) {
-			const char* found_str = NULL;
-			const char* s = g_strstrip(*ptr);
-
-			if (!strcasecmp(s, name)) {
-				found_str = name;
-				if (result) {
-					*result |= value;
-				}
-			} else {
-				va_list args;
-				const char* known;
-
-				va_start(args, value);
-				while ((known = va_arg(args, char*)) != NULL) {
-					const int bit = va_arg(args, int);
-
-					if (!strcasecmp(s, known)) {
-						found_str = known;
-						if (result) {
-							*result |= bit;
-						}
-						break;
-					}
-				}
-				va_end(args);
-			}
-
-			if (!found_str) {
-				ofono_error("Unknown bit '%s' in %s", s, key);
-				ok = FALSE;
-			}
-		}
-
-		g_strfreev(values);
-		g_free(str);
-	}
-
-	if (!ok && result) {
-		*result = 0;
-	}
-	return ok;
-}
-
 GUtilInts *ril_config_get_ints(GKeyFile *file, const char *group,
 					const char *key)
 {

ofono/drivers/ril/ril_config.h

@@ -1,8 +1,8 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2020 Jolla Ltd.
- *  Copyright (C) 2019-2020 Open Mobile Platform LLC.
+ *  Copyright (C) 2015-2019 Jolla Ltd.
+ *  Copyright (C) 2019 Open Mobile Platform LLC.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -35,12 +35,7 @@ gboolean ril_config_get_flag(GKeyFile *file, const char *group,
 					const char *key, int flag, int *flags);
 gboolean ril_config_get_enum(GKeyFile *file, const char *group,
 					const char *key, int *result,
-					const char *name, int value, ...)
-					G_GNUC_NULL_TERMINATED;
-gboolean ril_config_get_mask(GKeyFile *file, const char *group,
-					const char *key, int *result,
-					const char *name, int value, ...)
-					G_GNUC_NULL_TERMINATED;
+					const char *name, int value, ...);
 GUtilInts *ril_config_get_ints(GKeyFile *file, const char *group,
 					const char *key);
 char *ril_config_ints_to_string(GUtilInts *ints, char separator);

ofono/drivers/ril/ril_constants.h

@@ -375,19 +375,6 @@ enum ril_restricted_state {
 #define RIL_FACILITY_UNLOCK "0"
 #define RIL_FACILITY_LOCK "1"
 
-/* See RIL_REQUEST_SET_UNSOLICITED_RESPONSE_FILTER (RIL_VERSION >= 15) */
-enum  ril_unsolicited_response_filter {
-	RIL_UR_SIGNAL_STRENGTH            = 0x01,
-	RIL_UR_FULL_NETWORK_STATE         = 0x02,
-	RIL_UR_DATA_CALL_DORMANCY_CHANGED = 0x04
-};
-
-/* RIL_REQUEST_QUERY_NETWORK_SELECTION_MODE result */
-enum ril_network_selection_mode {
-	RIL_NETWORK_SELECTION_MODE_AUTO	  = 0,
-	RIL_NETWORK_SELECTION_MODE_MANUAL = 1
-};
-
 #endif /*__RIL_CONSTANTS_H */
 
 /*

ofono/drivers/ril/ril_data.c

@@ -2,7 +2,7 @@
  *  oFono - Open Source Telephony - RIL-based devices
  *
  *  Copyright (C) 2016-2020 Jolla Ltd.
- *  Copyright (C) 2019-2020 Open Mobile Platform LLC.
+ *  Copyright (C) 2019 Open Mobile Platform LLC.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -81,7 +81,6 @@ typedef struct ril_data RilData;
 enum ril_data_io_event_id {
 	IO_EVENT_DATA_CALL_LIST_CHANGED,
 	IO_EVENT_RESTRICTED_STATE_CHANGED,
-	IO_EVENT_EOF,
 	IO_EVENT_COUNT
 };
 
@@ -193,7 +192,6 @@ struct ril_data_request_allow_data {
 
 static void ril_data_manager_check_network_mode(struct ril_data_manager *dm);
 static void ril_data_call_deact_cid(struct ril_data *data, int cid);
-static void ril_data_cancel_all_requests(struct ril_data *self);
 static void ril_data_power_update(struct ril_data *self);
 static void ril_data_signal_emit(struct ril_data *self, enum ril_data_signal id)
 {
@@ -1232,17 +1230,6 @@ static void ril_data_settings_changed(struct ril_sim_settings *settings,
 	ril_data_manager_check_network_mode(RIL_DATA(user_data)->priv->dm);
 }
 
-static void ril_data_ril_disconnected_cb(GRilIoChannel *io, void *user_data)
-{
-	struct ril_data *self = RIL_DATA(user_data);
-	struct ril_data_priv *priv = self->priv;
-
-	DBG_(self, "disconnected");
-	priv->flags = RIL_DATA_FLAG_NONE;
-	priv->restricted_state = 0;
-	ril_data_cancel_all_requests(self);
-}
-
 static gint ril_data_compare_cb(gconstpointer a, gconstpointer b)
 {
 	const struct ril_data *d1 = a;
@@ -1302,9 +1289,6 @@ struct ril_data *ril_data_new(struct ril_data_manager *dm, const char *name,
 			grilio_channel_add_unsol_event_handler(io,
 				ril_data_restricted_state_changed_cb,
 				RIL_UNSOL_RESTRICTED_STATE_CHANGED, self);
-		priv->io_event_id[IO_EVENT_EOF] =
-			grilio_channel_add_disconnected_handler(io,
-				ril_data_ril_disconnected_cb, self);
 
 		priv->settings_event_id[SETTINGS_EVENT_IMSI_CHANGED] =
 			ril_sim_settings_add_imsi_changed_handler(settings,
@@ -1431,20 +1415,6 @@ static void ril_data_cancel_requests(struct ril_data *self,
 	}
 }
 
-static void ril_data_cancel_all_requests(struct ril_data *self)
-{
-	struct ril_data_priv *priv = self->priv;
-	struct ril_data_request *req = priv->req_queue;
-
-	ril_data_request_do_cancel(priv->pending_req);
-	while (req) {
-		struct ril_data_request *next = req->next;
-
-		ril_data_request_do_cancel(req);
-		req = next;
-	}
-}
-
 static void ril_data_disallow(struct ril_data *self)
 {
 	struct ril_data_priv *priv = self->priv;
@@ -1616,11 +1586,24 @@ static void ril_data_dispose(GObject *object)
 	struct ril_data *self = RIL_DATA(object);
 	struct ril_data_priv *priv = self->priv;
 	struct ril_data_manager	*dm = priv->dm;
+	struct ril_network *network = priv->network;
+	struct ril_sim_settings *settings = network->settings;
+	struct ril_data_request *req;
 
+	ril_sim_settings_remove_handlers(settings, priv->settings_event_id,
+					G_N_ELEMENTS(priv->settings_event_id));
+	grilio_channel_remove_all_handlers(priv->io, priv->io_event_id);
 	grilio_queue_cancel_all(priv->q, FALSE);
 	priv->query_id = 0;
 
-	ril_data_cancel_all_requests(self);
+	ril_data_request_do_cancel(priv->pending_req);
+	req = priv->req_queue;
+	while (req) {
+		struct ril_data_request *next = req->next;
+		ril_data_request_do_cancel(req);
+		req = next;
+	}
+
 	dm->data_list = g_slist_remove(dm->data_list, self);
 	ril_data_manager_check_data(dm);
 	g_hash_table_destroy(priv->grab);
@@ -1631,11 +1614,6 @@ static void ril_data_finalize(GObject *object)
 {
 	struct ril_data *self = RIL_DATA(object);
 	struct ril_data_priv *priv = self->priv;
-	struct ril_network *network = priv->network;
-	struct ril_sim_settings *settings = network->settings;
-
-	ril_sim_settings_remove_all_handlers(settings, priv->settings_event_id);
-	grilio_channel_remove_all_handlers(priv->io, priv->io_event_id);
 
 	g_free(priv->log_prefix);
 	grilio_queue_unref(priv->q);
@@ -1721,39 +1699,34 @@ static void ril_data_manager_check_network_mode(struct ril_data_manager *self)
 
 	if ((self->flags & RIL_DATA_MANAGER_FORCE_GSM_ON_OTHER_SLOTS) &&
 		ril_data_manager_handover(self)) {
-		struct ril_network *lte_network = NULL, *best_network = NULL;
-		enum ofono_radio_access_mode best_mode =
-						OFONO_RADIO_ACCESS_MODE_ANY;
+		struct ril_network *lte_network = NULL;
+		int non_gsm_count = 0;
 
-		/* Find a SIM for internet access */
+		/*
+		 * Count number of SIMs for which non-GSM mode is selected
+		 */
 		for (l= self->data_list; l; l = l->next) {
 			struct ril_data *data = l->data;
 			struct ril_data_priv *priv = data->priv;
 			struct ril_network *network = priv->network;
 			struct ril_sim_settings *sim = network->settings;
-			enum ofono_radio_access_mode mode;
 
-			/* Select the first network with internet role */
-			if ((sim->pref_mode != OFONO_RADIO_ACCESS_MODE_GSM) &&
-				(priv->flags & RIL_DATA_FLAG_MAX_SPEED)) {
-				lte_network = network;
-				break;
-			}
-
-			/* At the same time, look for a suitable slot */
-			mode = ril_network_max_supported_mode(network);
-			if (mode > best_mode) {
-				best_network = network;
-				best_mode = mode;
+			if (sim->pref_mode != OFONO_RADIO_ACCESS_MODE_GSM) {
+				non_gsm_count++;
+				if ((priv->flags & RIL_DATA_FLAG_MAX_SPEED) &&
+							!lte_network) {
+					lte_network = network;
+				}
 			}
 		}
 
 		/*
 		 * If there's no SIM selected for internet access
-		 * then use a slot with highest capabilities for LTE.
+		 * then choose the first slot for LTE.
 		 */
 		if (!lte_network) {
-			lte_network = best_network;
+			struct ril_data *data = self->data_list->data;
+			lte_network = data->priv->network;
 		}
 
 		for (l= self->data_list; l; l = l->next) {

ofono/drivers/ril/ril_data.h

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2016-2020 Jolla Ltd.
+ *  Copyright (C) 2016-2019 Jolla Ltd.
  *  Copyright (C) 2019 Open Mobile Platform LLC.
  *
  *  This program is free software; you can redistribute it and/or modify
@@ -79,6 +79,12 @@ struct ril_data_options {
 	unsigned int data_call_retry_delay_ms;
 };
 
+enum ril_data_role {
+	RIL_DATA_ROLE_NONE,    /* Data not allowed */
+	RIL_DATA_ROLE_MMS,     /* Data is allowed at any speed */
+	RIL_DATA_ROLE_INTERNET /* Data is allowed at full speed */
+};
+
 struct ril_data_manager;
 struct ril_data_manager *ril_data_manager_new(enum ril_data_manager_flags flg);
 struct ril_data_manager *ril_data_manager_ref(struct ril_data_manager *dm);

ofono/drivers/ril/ril_devmon.h

@@ -1,8 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2019-2020 Jolla Ltd.
- *  Copyright (C) 2020 Open Mobile Platform LLC.
+ *  Copyright (C) 2019 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -51,22 +50,11 @@ struct ril_devmon *ril_devmon_ss_new(void);
  */
 struct ril_devmon *ril_devmon_ds_new(void);
 
-/*
- * This Device Monitor implementation controls network state updates
- * by sending SET_UNSOLICITED_RESPONSE_FILTER.
- */
-struct ril_devmon *ril_devmon_ur_new(void);
-
 /*
  * This one selects the type based on the RIL version.
  */
 struct ril_devmon *ril_devmon_auto_new(void);
 
-/*
- * This one combines several methods. Takes ownership of ril_devmon objects.
- */
-struct ril_devmon *ril_devmon_combine(struct ril_devmon *devmon[], guint n);
-
 /* Utilities (NULL tolerant) */
 struct ril_devmon_io *ril_devmon_start_io(struct ril_devmon *devmon,
 		GRilIoChannel *channel, struct sailfish_cell_info *cell_info);

ofono/drivers/ril/ril_devmon_combine.c

@@ -1,104 +0,0 @@
-/*
- *  oFono - Open Source Telephony - RIL-based devices
- *
- *  Copyright (C) 2020 Jolla Ltd.
- *  Copyright (C) 2020 Open Mobile Platform LLC.
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- *  GNU General Public License for more details.
- */
-
-#include "ril_devmon.h"
-
-#include <ofono/log.h>
-
-typedef struct ril_devmon_combine {
-	struct ril_devmon pub;
-	struct ril_devmon **impl;
-	guint count;
-} DevMon;
-
-typedef struct ril_devmon_combine_io {
-	struct ril_devmon_io pub;
-	struct ril_devmon_io **impl;
-	guint count;
-} DevMonIo;
-
-static inline DevMon *ril_devmon_combine_cast(struct ril_devmon *dm)
-{
-	return G_CAST(dm, DevMon, pub);
-}
-
-static inline DevMonIo *ril_devmon_ds_io_cast(struct ril_devmon_io *io)
-{
-	return G_CAST(io, DevMonIo, pub);
-}
-
-static void ril_devmon_combine_io_free(struct ril_devmon_io *io)
-{
-	guint i;
-	DevMonIo *self = ril_devmon_ds_io_cast(io);
-
-	for (i = 0; i < self->count; i++) {
-		ril_devmon_io_free(self->impl[i]);
-	}
-	g_free(self);
-}
-
-static struct ril_devmon_io *ril_devmon_combine_start_io(struct ril_devmon *dm,
-			GRilIoChannel *chan, struct sailfish_cell_info *ci)
-{
-	guint i;
-	DevMon *self = ril_devmon_combine_cast(dm);
-	DevMonIo *io = g_malloc0(sizeof(DevMonIo) +
-				sizeof(struct ril_devmon_io *) * self->count);
-
-	io->pub.free = ril_devmon_combine_io_free;
-	io->impl = (struct ril_devmon_io**)(io + 1);
-	io->count = self->count;
-	for (i = 0; i < io->count; i++) {
-		io->impl[i] = ril_devmon_start_io(self->impl[i], chan, ci);
-	}
-	return &io->pub;
-}
-
-static void ril_devmon_combine_free(struct ril_devmon *dm)
-{
-	DevMon *self = ril_devmon_combine_cast(dm);
-	guint i;
-
-	for (i = 0; i < self->count; i++) {
-		ril_devmon_free(self->impl[i]);
-	}
-	g_free(self);
-}
-
-struct ril_devmon *ril_devmon_combine(struct ril_devmon *dm[], guint n)
-{
-	guint i;
-	DevMon *self = g_malloc0(sizeof(DevMon) +
-					sizeof(struct ril_devmon *) * n);
-
-	self->pub.free = ril_devmon_combine_free;
-	self->pub.start_io = ril_devmon_combine_start_io;
-	self->impl = (struct ril_devmon **)(self + 1);
-	self->count = n;
-	for (i = 0; i < n; i++) {
-		self->impl[i] = dm[i];
-	}
-	return &self->pub;
-}
-
-/*
- * Local Variables:
- * mode: C
- * c-basic-offset: 8
- * indent-tabs-mode: t
- * End:
- */

ofono/drivers/ril/ril_devmon_ur.c

@@ -1,254 +0,0 @@
-/*
- *  oFono - Open Source Telephony - RIL-based devices
- *
- *  Copyright (C) 2019 Jolla Ltd.
- *  Copyright (C) 2020 Open Mobile Platform LLC
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- *  GNU General Public License for more details.
- */
-
-#include "ril_devmon.h"
-
-#include <ofono/log.h>
-#include <ofono/ril-constants.h>
-
-#include <mce_battery.h>
-#include <mce_charger.h>
-#include <mce_display.h>
-
-#include <grilio_channel.h>
-#include <grilio_request.h>
-
-#include <gutil_macros.h>
-
-#define RIL_UR_ENABLE_ALL	(RIL_UR_SIGNAL_STRENGTH | \
-				RIL_UR_FULL_NETWORK_STATE | \
-				RIL_UR_DATA_CALL_DORMANCY_CHANGED)
-
-enum ril_devmon_ur_battery_event {
-	BATTERY_EVENT_VALID,
-	BATTERY_EVENT_STATUS,
-	BATTERY_EVENT_COUNT
-};
-
-enum ril_devmon_ur_charger_event {
-	CHARGER_EVENT_VALID,
-	CHARGER_EVENT_STATE,
-	CHARGER_EVENT_COUNT
-};
-
-enum ril_devmon_ur_display_event {
-	DISPLAY_EVENT_VALID,
-	DISPLAY_EVENT_STATE,
-	DISPLAY_EVENT_COUNT
-};
-
-typedef struct ril_devmon_ur {
-	struct ril_devmon pub;
-	MceBattery *battery;
-	MceCharger *charger;
-	MceDisplay *display;
-} DevMon;
-
-typedef struct ril_devmon_ur_io {
-	struct ril_devmon_io pub;
-	struct sailfish_cell_info *cell_info;
-	MceBattery *battery;
-	MceCharger *charger;
-	MceDisplay *display;
-	GRilIoChannel *io;
-	gboolean display_on;
-	gboolean unsol_filter_supported;
-	gulong battery_event_id[BATTERY_EVENT_COUNT];
-	gulong charger_event_id[CHARGER_EVENT_COUNT];
-	gulong display_event_id[DISPLAY_EVENT_COUNT];
-	guint req_id;
-} DevMonIo;
-
-#define DBG_(self,fmt,args...) DBG("%s: " fmt, (self)->io->name, ##args)
-
-inline static DevMon *ril_devmon_ur_cast(struct ril_devmon *pub)
-{
-	return G_CAST(pub, DevMon, pub);
-}
-
-inline static DevMonIo *ril_devmon_ur_io_cast(struct ril_devmon_io *pub)
-{
-	return G_CAST(pub, DevMonIo, pub);
-}
-
-static inline gboolean ril_devmon_ur_battery_ok(MceBattery *battery)
-{
-	return battery->valid && battery->status >= MCE_BATTERY_OK;
-}
-
-static inline gboolean ril_devmon_ur_charging(MceCharger *charger)
-{
-	return charger->valid && charger->state == MCE_CHARGER_ON;
-}
-
-static gboolean ril_devmon_ur_display_on(MceDisplay *display)
-{
-	return display->valid && display->state != MCE_DISPLAY_STATE_OFF;
-}
-
-static void ril_devmon_ur_io_unsol_response_filter_sent(GRilIoChannel *io,
-				int status, const void *data, guint len,
-				void *user_data)
-{
-	DevMonIo *self = user_data;
-
-	self->req_id = 0;
-	if (status == RIL_E_REQUEST_NOT_SUPPORTED) {
-		/* This is a permanent failure */
-		DBG_(self, "Unsolicited response filter is not supported");
-		self->unsol_filter_supported = FALSE;
-	}
-}
-
-static void ril_devmon_ur_io_set_unsol_response_filter(DevMonIo *self)
-{
-	if (self->unsol_filter_supported) {
-		const gint32 value = self->display_on ? RIL_UR_ENABLE_ALL : 0;
-		GRilIoRequest *req = grilio_request_array_int32_new(1, value);
-
-		DBG_(self, "Setting unsolicited response filter: %u", value);
-
-		grilio_channel_cancel_request(self->io, self->req_id, FALSE);
-		self->req_id =
-			grilio_channel_send_request_full(self->io, req,
-				RIL_REQUEST_SET_UNSOLICITED_RESPONSE_FILTER,
-				ril_devmon_ur_io_unsol_response_filter_sent,
-				NULL, self);
-		grilio_request_unref(req);
-	}
-}
-
-static void ril_devmon_ur_io_set_cell_info_update_interval(DevMonIo *self)
-{
-	sailfish_cell_info_set_update_interval(self->cell_info,
-		(self->display_on && (ril_devmon_ur_charging(self->charger) ||
-				ril_devmon_ur_battery_ok(self->battery))) ?
-					RIL_CELL_INFO_INTERVAL_SHORT_MS :
-					RIL_CELL_INFO_INTERVAL_LONG_MS);
-}
-
-static void ril_devmon_ur_io_battery_cb(MceBattery *battery, void *user_data)
-{
-	ril_devmon_ur_io_set_cell_info_update_interval(user_data);
-}
-
-static void ril_devmon_ur_io_charger_cb(MceCharger *charger, void *user_data)
-{
-	ril_devmon_ur_io_set_cell_info_update_interval(user_data);
-}
-
-static void ril_devmon_ur_io_display_cb(MceDisplay *display, void *user_data)
-{
-	DevMonIo *self = user_data;
-	const gboolean display_on = ril_devmon_ur_display_on(display);
-
-	if (self->display_on != display_on) {
-		self->display_on = display_on;
-		ril_devmon_ur_io_set_unsol_response_filter(self);
-		ril_devmon_ur_io_set_cell_info_update_interval(self);
-	}
-}
-
-static void ril_devmon_ur_io_free(struct ril_devmon_io *devmon_io)
-{
-	DevMonIo *self = ril_devmon_ur_io_cast(devmon_io);
-
-	mce_battery_remove_all_handlers(self->battery, self->battery_event_id);
-	mce_battery_unref(self->battery);
-
-	mce_charger_remove_all_handlers(self->charger, self->charger_event_id);
-	mce_charger_unref(self->charger);
-
-	mce_display_remove_all_handlers(self->display, self->display_event_id);
-	mce_display_unref(self->display);
-
-	grilio_channel_cancel_request(self->io, self->req_id, FALSE);
-	grilio_channel_unref(self->io);
-
-	sailfish_cell_info_unref(self->cell_info);
-	g_free(self);
-}
-
-static struct ril_devmon_io *ril_devmon_ur_start_io(struct ril_devmon *devmon,
-		GRilIoChannel *io, struct sailfish_cell_info *cell_info)
-{
-	DevMon *ur = ril_devmon_ur_cast(devmon);
-	DevMonIo *self = g_new0(DevMonIo, 1);
-
-	self->pub.free = ril_devmon_ur_io_free;
-	self->unsol_filter_supported = TRUE;
-	self->io = grilio_channel_ref(io);
-	self->cell_info = sailfish_cell_info_ref(cell_info);
-
-	self->battery = mce_battery_ref(ur->battery);
-	self->battery_event_id[BATTERY_EVENT_VALID] =
-		mce_battery_add_valid_changed_handler(self->battery,
-			ril_devmon_ur_io_battery_cb, self);
-	self->battery_event_id[BATTERY_EVENT_STATUS] =
-		mce_battery_add_status_changed_handler(self->battery,
-			ril_devmon_ur_io_battery_cb, self);
-
-	self->charger = mce_charger_ref(ur->charger);
-	self->charger_event_id[CHARGER_EVENT_VALID] =
-		mce_charger_add_valid_changed_handler(self->charger,
-			ril_devmon_ur_io_charger_cb, self);
-	self->charger_event_id[CHARGER_EVENT_STATE] =
-		mce_charger_add_state_changed_handler(self->charger,
-			ril_devmon_ur_io_charger_cb, self);
-
-	self->display = mce_display_ref(ur->display);
-	self->display_on = ril_devmon_ur_display_on(self->display);
-	self->display_event_id[DISPLAY_EVENT_VALID] =
-		mce_display_add_valid_changed_handler(self->display,
-			ril_devmon_ur_io_display_cb, self);
-	self->display_event_id[DISPLAY_EVENT_STATE] =
-		mce_display_add_state_changed_handler(self->display,
-			ril_devmon_ur_io_display_cb, self);
-
-	ril_devmon_ur_io_set_unsol_response_filter(self);
-	ril_devmon_ur_io_set_cell_info_update_interval(self);
-	return &self->pub;
-}
-
-static void ril_devmon_ur_free(struct ril_devmon *devmon)
-{
-	DevMon *self = ril_devmon_ur_cast(devmon);
-
-	mce_battery_unref(self->battery);
-	mce_charger_unref(self->charger);
-	mce_display_unref(self->display);
-	g_free(self);
-}
-
-struct ril_devmon *ril_devmon_ur_new()
-{
-	DevMon *self = g_new0(DevMon, 1);
-
-	self->pub.free = ril_devmon_ur_free;
-	self->pub.start_io = ril_devmon_ur_start_io;
-	self->battery = mce_battery_new();
-	self->charger = mce_charger_new();
-	self->display = mce_display_new();
-	return &self->pub;
-}
-
-/*
- * Local Variables:
- * mode: C
- * c-basic-offset: 8
- * indent-tabs-mode: t
- * End:
- */

ofono/drivers/ril/ril_modem.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2020 Jolla Ltd.
+ *  Copyright (C) 2015-2019 Jolla Ltd.
  *  Copyright (C) 2019 Open Mobile Platform LLC.
  *
  *  This program is free software; you can redistribute it and/or modify
@@ -29,6 +29,7 @@
 
 #include <ofono/watch.h>
 
+#define MAX_PDP_CONTEXTS        (2)
 #define ONLINE_TIMEOUT_SECS     (15) /* 20 sec is hardcoded in ofono core */
 
 enum ril_modem_power_state {
@@ -218,21 +219,22 @@ static void ril_modem_schedule_online_check(struct ril_modem_data *md)
 static void ril_modem_update_radio_settings(struct ril_modem_data *md)
 {
 	struct ril_modem *m = &md->modem;
-	struct ofono_radio_settings *rs = ril_modem_radio_settings(m);
-
-	if (md->watch->imsi) {
+	if (m->radio->state == RADIO_STATE_ON && md->watch->imsi) {
 		/* radio-settings.c assumes that IMSI is available */
-		if (!rs) {
+		if (!ril_modem_radio_settings(m)) {
 			DBG_(md, "initializing radio settings interface");
 			ofono_radio_settings_create(m->ofono, 0,
 						RILMODEM_DRIVER, md);
 		}
-	} else if (rs) {
-		DBG_(md, "removing radio settings interface");
-		ofono_radio_settings_remove(rs);
 	} else {
 		/* ofono core may remove radio settings atom internally */
-		DBG_(md, "radio settings interface is already gone");
+		struct ofono_radio_settings *rs = ril_modem_radio_settings(m);
+		if (rs) {
+			DBG_(md, "removing radio settings interface");
+			ofono_radio_settings_remove(rs);
+		} else {
+			DBG_(md, "radio settings interface is already gone");
+		}
 	}
 }
 
@@ -241,6 +243,7 @@ static void ril_modem_radio_state_cb(struct ril_radio *radio, void *data)
 	struct ril_modem_data *md = data;
 
 	GASSERT(md->modem.radio == radio);
+	ril_modem_update_radio_settings(md);
 	ril_modem_update_online_state(md);
 }
 
@@ -304,22 +307,15 @@ static void ril_modem_post_sim(struct ofono_modem *modem)
 	ofono_sms_create(modem, 0, RILMODEM_DRIVER, md);
 	gprs = ofono_gprs_create(modem, 0, RILMODEM_DRIVER, md);
 	if (gprs) {
-		guint i;
-		static const enum ofono_gprs_context_type ap_types[] = {
-			OFONO_GPRS_CONTEXT_TYPE_INTERNET,
-			OFONO_GPRS_CONTEXT_TYPE_MMS,
-			OFONO_GPRS_CONTEXT_TYPE_IMS
-		};
+		int i;
 
-		/* Create a context for each type */
-		for (i = 0; i < G_N_ELEMENTS(ap_types); i++) {
+		for (i = 0; i < MAX_PDP_CONTEXTS; i++) {
 			struct ofono_gprs_context *gc =
 				ofono_gprs_context_create(modem, 0,
 						RILMODEM_DRIVER, md);
 			if (gc == NULL)
 				break;
 
-			ofono_gprs_context_set_type(gc, ap_types[i]);
 			ofono_gprs_add_context(gprs, gc);
 		}
 	}
@@ -421,9 +417,7 @@ static void ril_modem_remove(struct ofono_modem *ofono)
 	ofono_modem_set_data(ofono, NULL);
 
 	ril_radio_remove_handler(modem->radio, md->radio_state_event_id);
-	ril_radio_set_online(modem->radio, FALSE);
 	ril_radio_power_off(modem->radio, RADIO_POWER_TAG(md));
-	ril_radio_set_online(modem->radio, FALSE);
 	ril_radio_unref(modem->radio);
 	ril_sim_settings_unref(modem->sim_settings);
 

ofono/drivers/ril/ril_netreg.c

@@ -20,12 +20,10 @@
 #include "ril_vendor.h"
 #include "ril_log.h"
 
-#include "ofono.h"
 #include "common.h"
 #include "simutil.h"
 
-#include <ofono/watch.h>
-
+#define REGISTRATION_TIMEOUT (100*1000) /* ms */
 #define REGISTRATION_MAX_RETRIES (2)
 
 enum ril_netreg_events {
@@ -43,11 +41,9 @@ enum ril_netreg_network_events {
 struct ril_netreg {
 	GRilIoChannel *io;
 	GRilIoQueue *q;
-	gboolean replace_strange_oper;
 	gboolean network_selection_manual_0;
 	int signal_strength_dbm_weak;
 	int signal_strength_dbm_strong;
-	struct ofono_watch *watch;
 	struct ofono_netreg *netreg;
 	struct ril_network *network;
 	struct ril_vendor *vendor;
@@ -57,7 +53,6 @@ struct ril_netreg {
 	guint current_operator_id;
 	gulong ril_event_id[NETREG_RIL_EVENT_COUNT];
 	gulong network_event_id[NETREG_NETWORK_EVENT_COUNT];
-	int network_selection_timeout;
 };
 
 struct ril_netreg_cbd {
@@ -197,74 +192,11 @@ static void ril_netreg_current_operator(struct ofono_netreg *netreg,
 					ril_netreg_cbd_free);
 }
 
-static gboolean ril_netreg_strange(const struct ofono_network_operator *op,
-							struct ofono_sim *sim)
-{
-	gsize mcclen;
-
-	if (sim && op->status != OPERATOR_STATUS_CURRENT) {
-		const char *spn = ofono_sim_get_spn(sim);
-		const char *mcc = ofono_sim_get_mcc(sim);
-		const char *mnc = ofono_sim_get_mnc(sim);
-
-		if (spn && mcc && mnc && !strcmp(op->name, spn) &&
-			(strcmp(op->mcc, mcc) || strcmp(op->mnc, mnc))) {
-			/*
-			 * Status is not "current", SPN matches the SIM, but
-			 * MCC and/or MNC don't (e.g. Sony Xperia X where all
-			 * operators could be reported with the same name
-			 * which equals SPN).
-			 */
-			DBG("%s %s%s (sim spn?)", op->name, op->mcc, op->mnc);
-			return TRUE;
-		}
-	}
-
-	mcclen = strlen(op->mcc);
-	if (!strncmp(op->name, op->mcc, mcclen) &&
-				!strcmp(op->name + mcclen, op->mnc)) {
-		/* Some MediaTek RILs only report numeric operator name */
-		DBG("%s %s%s (numeric?)", op->name, op->mcc, op->mnc);
-		return TRUE;
-	}
-
-	return FALSE;
-}
-
-static void ril_netreg_process_operators(struct ril_netreg *nd,
-			struct ofono_network_operator *ops, int nops)
-{
-	if (nd->replace_strange_oper) {
-		int i;
-
-		for (i = 0; i < nops; i++) {
-			struct ofono_network_operator *op = ops + i;
-			struct ofono_gprs_provision_data *prov = NULL;
-			int np = 0;
-
-			if (ril_netreg_strange(op, nd->watch->sim) &&
-				__ofono_gprs_provision_get_settings(op->mcc,
-						op->mnc, NULL, &prov, &np)) {
-				/* Use the first entry */
-				if (np > 0 && prov->provider_name &&
-						prov->provider_name[0]) {
-					DBG("%s %s%s -> %s", op->name, op->mcc,
-						op->mnc, prov->provider_name);
-					strncpy(op->name, prov->provider_name,
-						OFONO_MAX_OPERATOR_NAME_LENGTH);
-				}
-				__ofono_gprs_provision_free_settings(prov, np);
-			}
-		}
-	}
-}
-
 static void ril_netreg_list_operators_cb(GRilIoChannel *io, int status,
 				const void *data, guint len, void *user_data)
 {
 	struct ril_netreg_cbd *cbd = user_data;
 	ofono_netreg_operator_list_cb_t cb = cbd->cb.operator_list;
-	struct ril_netreg *nd = cbd->nd;
 	struct ofono_network_operator *list;
 	struct ofono_error error;
 	int noperators = 0, i;
@@ -306,23 +238,21 @@ static void ril_netreg_list_operators_cb(GRilIoChannel *io, int status,
 		}
 
 		/* Set the proper status  */
-		if (!status) {
-			op->status = OPERATOR_STATUS_UNKNOWN;
-		} else if (!strcmp(status, "available")) {
-			op->status = OPERATOR_STATUS_AVAILABLE;
+		if (!strcmp(status, "available")) {
+			list[i].status = OPERATOR_STATUS_AVAILABLE;
 		} else if (!strcmp(status, "current")) {
-			op->status = OPERATOR_STATUS_CURRENT;
+			list[i].status = OPERATOR_STATUS_CURRENT;
 		} else if (!strcmp(status, "forbidden")) {
-			op->status = OPERATOR_STATUS_FORBIDDEN;
+			list[i].status = OPERATOR_STATUS_FORBIDDEN;
 		} else {
-			op->status = OPERATOR_STATUS_UNKNOWN;
+			list[i].status = OPERATOR_STATUS_UNKNOWN;
 		}
 
 		op->tech = -1;
 		ok = ril_parse_mcc_mnc(numeric, op);
 		if (ok) {
 			if (op->tech < 0) {
-				op->tech = nd->network->voice.access_tech;
+				op->tech = cbd->nd->network->voice.access_tech;
 			}
 			DBG("[operator=%s, %s, %s, status: %s]", op->name,
 						op->mcc, op->mnc, status);
@@ -337,7 +267,6 @@ static void ril_netreg_list_operators_cb(GRilIoChannel *io, int status,
 	}
 
 	if (ok) {
-		ril_netreg_process_operators(nd, list, noperators);
 		cb(ril_error_ok(&error), noperators, list, cbd->data);
 	} else {
 		cb(ril_error_failure(&error), 0, NULL, cbd->data);
@@ -372,55 +301,18 @@ static void ril_netreg_register_cb(GRilIoChannel *io, int status,
 	}
 }
 
-static void ril_netreg_set_register_auto(struct ril_netreg *nd,
-				ofono_netreg_register_cb_t cb, void *data)
-{
-	GRilIoRequest *req = grilio_request_new();
-
-	ofono_info("nw select automatic");
-	grilio_request_set_timeout(req, nd->network_selection_timeout);
-	grilio_request_set_retry(req, 0, REGISTRATION_MAX_RETRIES);
-	grilio_queue_send_request_full(nd->q, req,
-			RIL_REQUEST_SET_NETWORK_SELECTION_AUTOMATIC,
-			ril_netreg_register_cb, ril_netreg_cbd_free,
-			ril_netreg_cbd_new(nd, cb, data));
-	grilio_request_unref(req);
-}
-
-static void ril_netreg_query_register_auto_cb(GRilIoChannel *io, int status,
-					const void *data, guint len,
-					void *user_data)
-{
-	struct ril_netreg_cbd *cbd = user_data;
-	ofono_netreg_register_cb_t cb = cbd->cb.reg;
-
-	if (status == RIL_E_SUCCESS) {
-		GRilIoParser rilp;
-		gint32 net_mode;
-
-		grilio_parser_init(&rilp, data, len);
-		if (grilio_parser_get_int32(&rilp, NULL) /* Array length */ &&
-				grilio_parser_get_int32(&rilp, &net_mode) && 
-				net_mode == RIL_NETWORK_SELECTION_MODE_AUTO) {
-			struct ofono_error error;
-			ofono_info("nw selection is already auto");
-			cb(ril_error_ok(&error), cbd->data);
-			return;
-		}
-	}
-
-	ril_netreg_set_register_auto(cbd->nd, cb, cbd->data);
-}
-
 static void ril_netreg_register_auto(struct ofono_netreg *netreg,
 				ofono_netreg_register_cb_t cb, void *data)
 {
 	struct ril_netreg *nd = ril_netreg_get_data(netreg);
 	GRilIoRequest *req = grilio_request_new();
 
+	ofono_info("nw select automatic");
+	grilio_request_set_timeout(req, REGISTRATION_TIMEOUT);
+	grilio_request_set_retry(req, 0, REGISTRATION_MAX_RETRIES);
 	grilio_queue_send_request_full(nd->q, req,
-			RIL_REQUEST_QUERY_NETWORK_SELECTION_MODE,
-			ril_netreg_query_register_auto_cb, ril_netreg_cbd_free,
+			RIL_REQUEST_SET_NETWORK_SELECTION_AUTOMATIC,
+			ril_netreg_register_cb, ril_netreg_cbd_free,
 			ril_netreg_cbd_new(nd, cb, data));
 	grilio_request_unref(req);
 }
@@ -435,7 +327,7 @@ static void ril_netreg_register_manual(struct ofono_netreg *netreg,
 
 	ofono_info("nw select manual: %s%s%s", mcc, mnc, suffix);
 	grilio_request_append_format(req, "%s%s%s", mcc, mnc, suffix);
-	grilio_request_set_timeout(req, nd->network_selection_timeout);
+	grilio_request_set_timeout(req, REGISTRATION_TIMEOUT);
 	grilio_request_set_retry(req, 0, REGISTRATION_MAX_RETRIES);
 	grilio_queue_send_request_full(nd->q, req,
 			RIL_REQUEST_SET_NETWORK_SELECTION_MANUAL,
@@ -665,15 +557,12 @@ static int ril_netreg_probe(struct ofono_netreg *netreg, unsigned int vendor,
 	DBG_(nd, "%p", netreg);
 	nd->io = grilio_channel_ref(ril_modem_io(modem));
 	nd->q = grilio_queue_new(nd->io);
-	nd->watch = ofono_watch_new(ril_modem_get_path(modem));
 	nd->vendor = ril_vendor_ref(modem->vendor);
 	nd->network = ril_network_ref(modem->network);
 	nd->netreg = netreg;
-	nd->replace_strange_oper = config->replace_strange_oper;
 	nd->network_selection_manual_0 = config->network_selection_manual_0;
 	nd->signal_strength_dbm_weak = config->signal_strength_dbm_weak;
 	nd->signal_strength_dbm_strong = config->signal_strength_dbm_strong;
-	nd->network_selection_timeout = config->network_selection_timeout;
 
 	ofono_netreg_set_data(netreg, nd);
 	nd->timer_id = g_idle_add(ril_netreg_register, nd);
@@ -700,7 +589,6 @@ static void ril_netreg_remove(struct ofono_netreg *netreg)
 		g_source_remove(nd->current_operator_id);
 	}
 
-	ofono_watch_unref(nd->watch);
 	ril_network_remove_all_handlers(nd->network, nd->network_event_id);
 	ril_network_unref(nd->network);
 	ril_vendor_unref(nd->vendor);

ofono/drivers/ril/ril_network.c

@@ -2,7 +2,7 @@
  *  oFono - Open Source Telephony - RIL-based devices
  *
  *  Copyright (C) 2015-2020 Jolla Ltd.
- *  Copyright (C) 2019-2020 Open Mobile Platform LLC.
+ *  Copyright (C) 2019 Open Mobile Platform LLC.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -18,7 +18,6 @@
 
 #include "ril_network.h"
 #include "ril_radio.h"
-#include "ril_radio_caps.h"
 #include "ril_sim_card.h"
 #include "ril_sim_settings.h"
 #include "ril_vendor.h"
@@ -36,7 +35,6 @@
 #include <ofono/watch.h>
 #include <ofono/gprs.h>
 
-#include "ofono.h"
 #include "common.h"
 
 #define SET_PREF_MODE_HOLDOFF_SEC RIL_RETRY_SECS
@@ -56,12 +54,6 @@ enum ril_network_radio_event {
 	RADIO_EVENT_COUNT
 };
 
-enum ril_network_radio_caps_mgr_events {
-	RADIO_CAPS_MGR_TX_DONE,
-	RADIO_CAPS_MGR_TX_ABORTED,
-	RADIO_CAPS_MGR_EVENT_COUNT
-};
-
 enum ril_network_sim_events {
 	SIM_EVENT_STATUS_CHANGED,
 	SIM_EVENT_IO_ACTIVE_CHANGED,
@@ -70,6 +62,7 @@ enum ril_network_sim_events {
 
 enum ril_network_unsol_event {
 	UNSOL_EVENT_NETWORK_STATE,
+	UNSOL_EVENT_RADIO_CAPABILITY,
 	UNSOL_EVENT_COUNT
 };
 
@@ -97,7 +90,6 @@ struct ril_network_priv {
 	GRilIoChannel *io;
 	GRilIoQueue *q;
 	struct ril_radio *radio;
-	struct ril_radio_caps *caps;
 	struct ril_sim_card *simcard;
 	struct ril_vendor *vendor;
 	struct ofono_watch *watch;
@@ -114,8 +106,6 @@ struct ril_network_priv {
 	gulong set_rat_id;
 	gulong unsol_event_id[UNSOL_EVENT_COUNT];
 	gulong settings_event_id;
-	gulong supported_modes_event_id;
-	gulong caps_mgr_event_id[RADIO_CAPS_MGR_EVENT_COUNT];
 	gulong radio_event_id[RADIO_EVENT_COUNT];
 	gulong simcard_event_id[SIM_EVENT_COUNT];
 	gulong watch_ids[WATCH_EVENT_COUNT];
@@ -135,6 +125,7 @@ enum ril_network_signal {
 	SIGNAL_VOICE_STATE_CHANGED,
 	SIGNAL_DATA_STATE_CHANGED,
 	SIGNAL_PREF_MODE_CHANGED,
+	SIGNAL_MAX_PREF_MODE_CHANGED,
 	SIGNAL_COUNT
 };
 
@@ -142,6 +133,7 @@ enum ril_network_signal {
 #define SIGNAL_VOICE_STATE_CHANGED_NAME   "ril-network-voice-state-changed"
 #define SIGNAL_DATA_STATE_CHANGED_NAME    "ril-network-data-state-changed"
 #define SIGNAL_PREF_MODE_CHANGED_NAME     "ril-network-pref-mode-changed"
+#define SIGNAL_MAX_PREF_MODE_CHANGED_NAME "ril-network-max-pref-mode-changed"
 
 static guint ril_network_signals[SIGNAL_COUNT] = { 0 };
 
@@ -427,18 +419,6 @@ static void ril_network_poll_data_state_cb(GRilIoChannel *io, int req_status,
 	}
 }
 
-static gboolean ril_network_retry(GRilIoRequest* request, int ril_status,
-		const void* response_data, guint response_len, void* user_data)
-{
-	switch (ril_status) {
-	case RIL_E_SUCCESS:
-	case RIL_E_RADIO_NOT_AVAILABLE:
-		return FALSE;
-	default:
-		return TRUE;
-	}
-}
-
 static guint ril_network_poll_and_retry(struct ril_network *self, guint id,
 					int code, GRilIoChannelResponseFunc fn)
 {
@@ -451,7 +431,6 @@ static guint ril_network_poll_and_retry(struct ril_network *self, guint id,
 		GRilIoRequest *req = grilio_request_new();
 
 		grilio_request_set_retry(req, RIL_RETRY_SECS*1000, -1);
-		grilio_request_set_retry_func(req, ril_network_retry);
 		id = grilio_queue_send_request_full(priv->q, req, code, fn,
 								NULL, self);
 		grilio_request_unref(req);
@@ -533,17 +512,6 @@ static int ril_network_mode_to_rat(struct ril_network *self,
 	}
 }
 
-enum ofono_radio_access_mode ril_network_max_supported_mode
-						(struct ril_network *self)
-{
-	struct ril_sim_settings *settings = self->settings;
-	struct ril_network_priv *priv = self->priv;
-	const struct ril_radio_caps *caps = priv->caps;
-
-	return caps ? __ofono_radio_access_max_mode(caps->supported_modes) :
-				__ofono_radio_access_max_mode(settings->techs);
-}
-
 static enum ofono_radio_access_mode ril_network_actual_pref_mode
 						(struct ril_network *self)
 {
@@ -567,16 +535,9 @@ static enum ofono_radio_access_mode ril_network_actual_pref_mode
 	 * and max_pref_mode are not ANY, we pick the smallest value.
 	 * Otherwise we take any non-zero value if there is one.
 	 */
-	const enum ofono_radio_access_mode pref_mode =
-		(settings->pref_mode && max_pref_mode) ?
+	return (settings->pref_mode && max_pref_mode) ?
 		MIN(settings->pref_mode, max_pref_mode) :
 		settings->pref_mode ? settings->pref_mode : max_pref_mode;
-
-	/* Do not try to set unsupported mode */
-	const enum ofono_radio_access_mode max_mode =
-				ril_network_max_supported_mode(self);
-
-	return pref_mode ? MIN(pref_mode, max_mode) : max_mode;
 }
 
 static gboolean ril_network_need_initial_attach_apn(struct ril_network *self)
@@ -587,9 +548,9 @@ static gboolean ril_network_need_initial_attach_apn(struct ril_network *self)
 
 	if (watch->gprs && radio->state == RADIO_STATE_ON) {
 		switch (ril_network_actual_pref_mode(self)) {
+		case OFONO_RADIO_ACCESS_MODE_ANY:
 		case OFONO_RADIO_ACCESS_MODE_LTE:
 			return TRUE;
-		case OFONO_RADIO_ACCESS_MODE_ANY:
 		case OFONO_RADIO_ACCESS_MODE_UMTS:
 		case OFONO_RADIO_ACCESS_MODE_GSM:
 			break;
@@ -994,14 +955,6 @@ static void ril_network_check_pref_mode(struct ril_network *self,
 	}
 }
 
-static void ril_network_assert_pref_mode(struct ril_network *self)
-{
-	struct ril_network_priv *priv = self->priv;
-
-	priv->assert_rat = TRUE;
-	ril_network_check_pref_mode(self, FALSE);
-}
-
 static int ril_network_parse_pref_resp(const void *data, guint len)
 {
 	GRilIoParser rilp;
@@ -1031,10 +984,10 @@ static void ril_network_startup_query_pref_mode_cb(GRilIoChannel *io,
 		}
 
 		/*
-		 * At startup, the device may have an inconsistency between
-		 * voice and data network modes, so it needs to be asserted.
+		 * Unlike ril_network_query_pref_mode_cb, this one always
+		 * checks the preferred mode.
 		 */
-		ril_network_assert_pref_mode(self);
+		ril_network_check_pref_mode(self, FALSE);
 	}
 }
 
@@ -1045,22 +998,22 @@ static void ril_network_query_pref_mode_cb(GRilIoChannel *io, int status,
 	struct ril_network_priv *priv = self->priv;
 	const enum ofono_radio_access_mode pref_mode = self->pref_mode;
 
+	/* This request never fails because in case of error it gets retried */
+	GASSERT(status == RIL_E_SUCCESS);
 	GASSERT(priv->query_rat_id);
-	priv->query_rat_id = 0;
 
-	if (status == RIL_E_SUCCESS) {
-		priv->rat = ril_network_parse_pref_resp(data, len);
-		self->pref_mode = ril_network_rat_to_mode(priv->rat);
-		DBG_(self, "rat mode %d (%s)", priv->rat,
+	priv->query_rat_id = 0;
+	priv->rat = ril_network_parse_pref_resp(data, len);
+	self->pref_mode = ril_network_rat_to_mode(priv->rat);
+	DBG_(self, "rat mode %d (%s)", priv->rat,
 			ofono_radio_access_mode_to_string(self->pref_mode));
 
-		if (self->pref_mode != pref_mode) {
-			ril_network_emit(self, SIGNAL_PREF_MODE_CHANGED);
-		}
+	if (self->pref_mode != pref_mode) {
+		ril_network_emit(self, SIGNAL_PREF_MODE_CHANGED);
+	}
 
-		if (ril_network_can_set_pref_mode(self)) {
-			ril_network_check_pref_mode(self, FALSE);
-		}
+	if (ril_network_can_set_pref_mode(self)) {
+		ril_network_check_pref_mode(self, FALSE);
 	}
 }
 
@@ -1070,7 +1023,6 @@ static void ril_network_query_pref_mode(struct ril_network *self)
 	GRilIoRequest *req = grilio_request_new();
 
 	grilio_request_set_retry(req, RIL_RETRY_SECS*1000, -1);
-	grilio_request_set_retry_func(req, ril_network_retry);
 	grilio_queue_cancel_request(priv->q, priv->query_rat_id, FALSE);
 	priv->query_rat_id = grilio_queue_send_request_full(priv->q, req,
 				RIL_REQUEST_GET_PREFERRED_NETWORK_TYPE,
@@ -1087,79 +1039,19 @@ void ril_network_set_max_pref_mode(struct ril_network *self,
 			DBG_(self, "rat mode %d (%s)", max_mode,
 				ofono_radio_access_mode_to_string(max_mode));
 			self->max_pref_mode = max_mode;
+			ril_network_emit(self, SIGNAL_MAX_PREF_MODE_CHANGED);
 			ril_network_check_initial_attach_apn(self);
 		}
 		ril_network_check_pref_mode(self, TRUE);
 	}
 }
 
-static void ril_network_supported_modes_handler(struct ril_radio_caps *caps,
-							void *user_data)
-{
-	struct ril_network *self = RIL_NETWORK(user_data);
-
-	DBG_(self, "%s", ofono_radio_access_mode_to_string
-						(caps->supported_modes));
-	ril_network_check_pref_mode(self, TRUE);
-}
-
-static void ril_network_radio_capability_tx_done_cb
-		(struct ril_radio_caps_manager *mgr, void *user_data)
-{
-	struct ril_network *self = RIL_NETWORK(user_data);
-
-	DBG_(self, "");
-	ril_network_assert_pref_mode(self);
-}
-
-static void ril_network_release_radio_caps(struct ril_network *self)
-{
-	struct ril_network_priv *priv = self->priv;
-	struct ril_radio_caps *caps = priv->caps;
-
-	if (caps) {
-		ril_radio_caps_manager_remove_all_handlers(caps->mgr,
-					priv->caps_mgr_event_id);
-		ril_radio_caps_remove_handler(caps,
-					priv->supported_modes_event_id);
-		ril_radio_caps_unref(caps);
-
-		priv->caps = NULL;
-		priv->supported_modes_event_id = 0;
-	}
-}
-
-static void ril_network_attach_radio_caps(struct ril_network *self,
-						struct ril_radio_caps *caps)
+void ril_network_assert_pref_mode(struct ril_network *self, gboolean immediate)
 {
 	struct ril_network_priv *priv = self->priv;
 
-	priv->caps = ril_radio_caps_ref(caps);
-	priv->supported_modes_event_id =
-		ril_radio_caps_add_supported_modes_handler(caps,
-			ril_network_supported_modes_handler, self);
-	priv->caps_mgr_event_id[RADIO_CAPS_MGR_TX_DONE] =
-		ril_radio_caps_manager_add_tx_done_handler(caps->mgr,
-			ril_network_radio_capability_tx_done_cb, self);
-	priv->caps_mgr_event_id[RADIO_CAPS_MGR_TX_ABORTED] =
-		ril_radio_caps_manager_add_tx_aborted_handler(caps->mgr,
-			ril_network_radio_capability_tx_done_cb, self);
-}
-
-void ril_network_set_radio_caps(struct ril_network *self,
-						struct ril_radio_caps *caps)
-{
-	if (self) {
-		struct ril_network_priv *priv = self->priv;
-
-		if (priv->caps != caps) {
-			ril_network_release_radio_caps(self);
-			if (caps) {
-				ril_network_attach_radio_caps(self, caps);
-			}
-			ril_network_check_pref_mode(self, TRUE);
-		}
-	}
+	priv->assert_rat = TRUE;
+	ril_network_check_pref_mode(self, immediate);
 }
 
 gulong ril_network_add_operator_changed_handler(struct ril_network *self,
@@ -1190,6 +1082,13 @@ gulong ril_network_add_pref_mode_changed_handler(struct ril_network *self,
 		SIGNAL_PREF_MODE_CHANGED_NAME, G_CALLBACK(cb), arg) : 0;
 }
 
+gulong ril_network_add_max_pref_mode_changed_handler(struct ril_network *self,
+					ril_network_cb_t cb, void *arg)
+{
+	return (G_LIKELY(self) && G_LIKELY(cb)) ? g_signal_connect(self,
+		SIGNAL_MAX_PREF_MODE_CHANGED_NAME, G_CALLBACK(cb), arg) : 0;
+}
+
 void ril_network_remove_handler(struct ril_network *self, gulong id)
 {
 	if (G_LIKELY(self) && G_LIKELY(id)) {
@@ -1212,6 +1111,16 @@ static void ril_network_state_changed_cb(GRilIoChannel *io, guint code,
 	ril_network_poll_state(self);
 }
 
+static void ril_network_radio_capability_changed_cb(GRilIoChannel *io,
+		guint code, const void *data, guint len, void *user_data)
+{
+	struct ril_network *self = RIL_NETWORK(user_data);
+
+	DBG_(self, "");
+	GASSERT(code == RIL_UNSOL_RADIO_CAPABILITY);
+	ril_network_assert_pref_mode(self, FALSE);
+}
+
 static void ril_network_radio_state_cb(struct ril_radio *radio, void *data)
 {
 	struct ril_network *self = RIL_NETWORK(data);
@@ -1344,6 +1253,10 @@ struct ril_network *ril_network_new(const char *path, GRilIoChannel *io,
 		grilio_channel_add_unsol_event_handler(priv->io,
 			ril_network_state_changed_cb,
 			RIL_UNSOL_RESPONSE_VOICE_NETWORK_STATE_CHANGED, self);
+	priv->unsol_event_id[UNSOL_EVENT_RADIO_CAPABILITY] =
+		grilio_channel_add_unsol_event_handler(priv->io,
+			ril_network_radio_capability_changed_cb,
+			RIL_UNSOL_RADIO_CAPABILITY, self);
 
 	priv->radio_event_id[RADIO_EVENT_STATE_CHANGED] =
 		ril_radio_add_state_changed_handler(priv->radio,
@@ -1438,7 +1351,6 @@ static void ril_network_finalize(GObject *object)
 	grilio_channel_remove_all_handlers(priv->io, priv->unsol_event_id);
 	grilio_channel_unref(priv->io);
 	grilio_queue_unref(priv->q);
-	ril_network_release_radio_caps(self);
 	ril_radio_remove_all_handlers(priv->radio, priv->radio_event_id);
 	ril_radio_unref(priv->radio);
 	ril_sim_card_remove_all_handlers(priv->simcard, priv->simcard_event_id);
@@ -1460,6 +1372,7 @@ static void ril_network_class_init(RilNetworkClass *klass)
 	RIL_NETWORK_SIGNAL(klass, VOICE_STATE);
 	RIL_NETWORK_SIGNAL(klass, DATA_STATE);
 	RIL_NETWORK_SIGNAL(klass, PREF_MODE);
+	RIL_NETWORK_SIGNAL(klass, MAX_PREF_MODE);
 }
 
 /*

ofono/drivers/ril/ril_network.h

@@ -1,8 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2020 Jolla Ltd.
- *  Copyright (C) 2020 Open Mobile Platform LLC.
+ *  Copyright (C) 2015-2019 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -22,7 +21,6 @@
 #include <glib-object.h>
 
 struct ofono_network_operator;
-struct ril_radio_caps;
 
 struct ril_registration_state {
 	int status;        /* enum network_registration_status */
@@ -44,6 +42,7 @@ struct ril_network {
 	struct ril_sim_settings *settings;
 };
 
+struct ofono_sim;
 typedef void (*ril_network_cb_t)(struct ril_network *net, void *arg);
 
 struct ril_network *ril_network_new(const char *path, GRilIoChannel *io,
@@ -55,13 +54,10 @@ struct ril_network *ril_network_new(const char *path, GRilIoChannel *io,
 struct ril_network *ril_network_ref(struct ril_network *net);
 void ril_network_unref(struct ril_network *net);
 
-void ril_network_set_radio_caps(struct ril_network *net,
-				struct ril_radio_caps *caps);
 void ril_network_set_max_pref_mode(struct ril_network *net,
 				enum ofono_radio_access_mode max_pref_mode,
 				gboolean force_check);
-enum ofono_radio_access_mode ril_network_max_supported_mode
-						(struct ril_network *self);
+void ril_network_assert_pref_mode(struct ril_network *net, gboolean immediate);
 void ril_network_query_registration_state(struct ril_network *net);
 gulong ril_network_add_operator_changed_handler(struct ril_network *net,
 					ril_network_cb_t cb, void *arg);
@@ -71,6 +67,8 @@ gulong ril_network_add_data_state_changed_handler(struct ril_network *net,
 					ril_network_cb_t cb, void *arg);
 gulong ril_network_add_pref_mode_changed_handler(struct ril_network *net,
 					ril_network_cb_t cb, void *arg);
+gulong ril_network_add_max_pref_mode_changed_handler(struct ril_network *net,
+					ril_network_cb_t cb, void *arg);
 void ril_network_remove_handler(struct ril_network *net, gulong id);
 void ril_network_remove_handlers(struct ril_network *net, gulong *ids, int n);
 

ofono/drivers/ril/ril_oem_raw.c

@@ -1,8 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2020 Jolla Ltd.
- *  Copyright (C) 2020 Open Mobile Platform LLC.
+ *  Copyright (C) 2015-2017 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -33,11 +32,6 @@ struct ril_oem_raw {
 
 #define DBG_(oem,fmt,args...) DBG("%s" fmt, (oem)->log_prefix, ##args)
 
-static void ril_oem_raw_send_done(void *msg)
-{
-	dbus_message_unref(msg);
-}
-
 static void ril_oem_raw_send_cb(GRilIoChannel *io, int ril_status,
 			const void *data, guint len, void *user_data)
 {
@@ -46,13 +40,20 @@ static void ril_oem_raw_send_cb(GRilIoChannel *io, int ril_status,
 
 	if (ril_status == RIL_E_SUCCESS) {
 		DBusMessageIter it, array;
+		const guchar* bytes = data;
+		guint i;
 
 		reply = dbus_message_new_method_return(msg);
 		dbus_message_iter_init_append(reply, &it);
 		dbus_message_iter_open_container(&it, DBUS_TYPE_ARRAY,
 					DBUS_TYPE_BYTE_AS_STRING, &array);
-		dbus_message_iter_append_fixed_array(&array, DBUS_TYPE_BYTE,
-					&data, len);
+
+		for (i = 0; i < len; i++) {
+			guchar byte = bytes[i];
+			dbus_message_iter_append_basic(&array, DBUS_TYPE_BYTE,
+									&byte);
+		}
+
 		dbus_message_iter_close_container(&it, &array);
 	} else if (ril_status == GRILIO_STATUS_TIMEOUT) {
 		DBG("Timed out");
@@ -62,7 +63,7 @@ static void ril_oem_raw_send_cb(GRilIoChannel *io, int ril_status,
 		reply = __ofono_error_failed(msg);
 	}
 
-	g_dbus_send_message(ofono_dbus_get_connection(), reply);
+	__ofono_dbus_pending_reply(&msg, reply);
 }
 
 static DBusMessage *ril_oem_raw_send(DBusConnection *conn, DBusMessage *msg,
@@ -71,12 +72,6 @@ static DBusMessage *ril_oem_raw_send(DBusConnection *conn, DBusMessage *msg,
 	DBusMessageIter it;
 	struct ril_oem_raw *oem = user_data;
 
-	if (!__ofono_dbus_access_method_allowed(dbus_message_get_sender(msg),
-					OFONO_DBUS_ACCESS_INTF_OEMRAW,
-					OFONO_DBUS_ACCESS_OEMRAW_SEND, NULL)) {
-		return __ofono_error_access_denied(msg);
-	}
-
 	dbus_message_iter_init(msg, &it);
 	if (dbus_message_iter_get_arg_type(&it) == DBUS_TYPE_ARRAY &&
 		dbus_message_iter_get_element_type(&it) == DBUS_TYPE_BYTE) {
@@ -99,7 +94,7 @@ static DBusMessage *ril_oem_raw_send(DBusConnection *conn, DBusMessage *msg,
 		grilio_request_append_bytes(req, data, data_len);
 		grilio_queue_send_request_full(oem->q, req,
 				RIL_REQUEST_OEM_HOOK_RAW, ril_oem_raw_send_cb,
-				ril_oem_raw_send_done, dbus_message_ref(msg));
+				NULL, dbus_message_ref(msg));
 		grilio_request_unref(req);
 		return NULL;
 	} else {

ofono/drivers/ril/ril_plugin.c

@@ -73,7 +73,6 @@
 #define RILMODEM_DEFAULT_LTE_MODE   PREF_NET_TYPE_LTE_GSM_WCDMA
 #define RILMODEM_DEFAULT_UMTS_MODE  PREF_NET_TYPE_GSM_WCDMA_AUTO
 #define RILMODEM_DEFAULT_NETWORK_MODE_TIMEOUT (20*1000) /* ms */
-#define RILMODEM_DEFAULT_NETWORK_SELECTION_TIMEOUT (100*1000) /* ms */
 #define RILMODEM_DEFAULT_DBM_WEAK   (-100) /* very weak, 0.0000000001 mW */
 #define RILMODEM_DEFAULT_DBM_STRONG (-60)  /* strong signal, 0.000001 mW */
 #define RILMODEM_DEFAULT_ENABLE_VOICECALL TRUE
@@ -94,7 +93,6 @@
 #define RILMODEM_DEFAULT_LEGACY_IMEI_QUERY FALSE
 #define RILMODEM_DEFAULT_RADIO_POWER_CYCLE TRUE
 #define RILMODEM_DEFAULT_CONFIRM_RADIO_POWER_ON TRUE
-#define RILMODEM_DEFAULT_REPLACE_STRANGE_OPER FALSE
 #define RILMODEM_DEFAULT_NETWORK_SELECTION_MANUAL_0 TRUE
 #define RILMODEM_DEFAULT_FORCE_GSM_WHEN_RADIO_OFF TRUE
 #define RILMODEM_DEFAULT_USE_DATA_PROFILES FALSE
@@ -136,7 +134,6 @@
 #define RILCONF_LTE_MODE                    "lteNetworkMode"
 #define RILCONF_UMTS_MODE                   "umtsNetworkMode"
 #define RILCONF_NETWORK_MODE_TIMEOUT        "networkModeTimeout"
-#define RILCONF_NETWORK_SELECTION_TIMEOUT   "networkSelectionTimeout"
 #define RILCONF_SIGNAL_STRENGTH_RANGE       "signalStrengthRange"
 #define RILCONF_UICC_WORKAROUND             "uiccWorkaround"
 #define RILCONF_ECCLIST_FILE                "ecclistFile"
@@ -152,7 +149,6 @@
 #define RILCONF_RADIO_POWER_CYCLE           "radioPowerCycle"
 #define RILCONF_CONFIRM_RADIO_POWER_ON      "confirmRadioPowerOn"
 #define RILCONF_SINGLE_DATA_CONTEXT         "singleDataContext"
-#define RILCONF_REPLACE_STRANGE_OPER        "replaceStrangeOperatorNames"
 #define RILCONF_NETWORK_SELECTION_MANUAL_0  "networkSelectionManual0"
 #define RILCONF_FORCE_GSM_WHEN_RADIO_OFF    "forceGsmWhenRadioOff"
 #define RILCONF_USE_DATA_PROFILES           "useDataProfiles"
@@ -183,9 +179,10 @@ enum ril_set_radio_cap_opt {
 };
 
 enum ril_devmon_opt {
-	RIL_DEVMON_SS = 0x01,
-	RIL_DEVMON_DS = 0x02,
-	RIL_DEVMON_UR = 0x04
+	RIL_DEVMON_NONE,
+	RIL_DEVMON_AUTO,
+	RIL_DEVMON_SS,
+	RIL_DEVMON_DS
 };
 
 struct ril_plugin_identity {
@@ -230,7 +227,6 @@ typedef struct sailfish_slot_impl {
 	struct ril_modem *modem;
 	struct ril_radio *radio;
 	struct ril_radio_caps *caps;
-	struct ril_radio_caps_request *caps_req;
 	struct ril_network *network;
 	struct ril_sim_card *sim_card;
 	struct ril_sim_settings *sim_settings;
@@ -367,7 +363,6 @@ static void ril_plugin_remove_slot_handler(ril_slot *slot, int id)
 static void ril_plugin_shutdown_slot(ril_slot *slot, gboolean kill_io)
 {
 	if (slot->modem) {
-		ril_data_allow(slot->data, RIL_DATA_ROLE_NONE);
 		ril_modem_delete(slot->modem);
 		/* The above call is expected to result in
 		 * ril_plugin_modem_removed getting called
@@ -387,16 +382,12 @@ static void ril_plugin_shutdown_slot(ril_slot *slot, gboolean kill_io)
 		}
 
 		if (slot->cell_info) {
-			sailfish_manager_set_cell_info(slot->handle, NULL);
 			sailfish_cell_info_unref(slot->cell_info);
 			slot->cell_info = NULL;
 		}
 
 		if (slot->caps) {
-			ril_network_set_radio_caps(slot->network, NULL);
-			ril_radio_caps_request_free(slot->caps_req);
-			ril_radio_caps_drop(slot->caps);
-			slot->caps_req = NULL;
+			ril_radio_caps_unref(slot->caps);
 			slot->caps = NULL;
 		}
 
@@ -910,7 +901,7 @@ static void ril_plugin_radio_caps_cb(const struct ril_radio_capability *cap,
 			plugin->caps_manager = ril_radio_caps_manager_new
 				(plugin->data_manager);
 			plugin->caps_manager_event_id =
-				ril_radio_caps_manager_add_tx_aborted_handler(
+				ril_radio_caps_manager_add_aborted_handler(
 					plugin->caps_manager,
 					ril_plugin_caps_switch_aborted,
 					plugin);
@@ -918,10 +909,9 @@ static void ril_plugin_radio_caps_cb(const struct ril_radio_capability *cap,
 
 		GASSERT(!slot->caps);
 		slot->caps = ril_radio_caps_new(plugin->caps_manager,
-			ril_plugin_log_prefix(slot), slot->io, slot->watch,
-			slot->data, slot->radio, slot->sim_card,
-			slot->sim_settings, &slot->config, cap);
-		ril_network_set_radio_caps(slot->network, slot->caps);
+			ril_plugin_log_prefix(slot), slot->io, slot->data,
+			slot->radio, slot->sim_card, slot->network,
+			&slot->config, cap);
 	}
 }
 
@@ -1049,13 +1039,13 @@ static void ril_plugin_slot_connected(ril_slot *slot)
 				slot->path, slot->config.techs, slot->imei,
 				slot->imeisv, ril_plugin_sim_state(slot),
 				slot->slot_flags);
+		sailfish_manager_set_cell_info(slot->handle, slot->cell_info);
 		grilio_channel_set_enabled(slot->io, slot->handle->enabled);
 
 		/* Check if this was the last slot we were waiting for */
 		ril_plugin_check_if_started(plugin);
 	}
 
-	sailfish_manager_set_cell_info(slot->handle, slot->cell_info);
 	ril_plugin_check_modem(slot);
 	ril_plugin_check_ready(slot);
 }
@@ -1071,11 +1061,8 @@ static void ril_plugin_slot_connected_cb(GRilIoChannel *io, void *user_data)
 static void ril_plugin_init_io(ril_slot *slot)
 {
 	if (!slot->io) {
-		struct grilio_transport *transport =
-			ofono_ril_transport_connect(slot->transport_name,
-						slot->transport_params);
-
-		slot->io = grilio_channel_new(transport);
+		slot->io = grilio_channel_new(ofono_ril_transport_connect
+			(slot->transport_name, slot->transport_params));
 		if (slot->io) {
 			ril_debug_trace_update(slot);
 			ril_debug_dump_update(slot);
@@ -1107,7 +1094,6 @@ static void ril_plugin_init_io(ril_slot *slot)
 						slot);
 			}
 		}
-		grilio_transport_unref(transport);
 	}
 
 	if (!slot->io) {
@@ -1153,8 +1139,6 @@ static void ril_plugin_slot_modem_changed(struct ofono_watch *w,
 
 		slot->modem = NULL;
 		ril_data_allow(slot->data, RIL_DATA_ROLE_NONE);
-		ril_radio_caps_request_free(slot->caps_req);
-		slot->caps_req = NULL;
 	}
 }
 
@@ -1210,8 +1194,6 @@ static ril_slot *ril_plugin_slot_new_take(char *transport,
 	config->lte_network_mode = RILMODEM_DEFAULT_LTE_MODE;
 	config->umts_network_mode = RILMODEM_DEFAULT_UMTS_MODE;
 	config->network_mode_timeout = RILMODEM_DEFAULT_NETWORK_MODE_TIMEOUT;
-	config->network_selection_timeout =
-		RILMODEM_DEFAULT_NETWORK_SELECTION_TIMEOUT;
 	config->signal_strength_dbm_weak = RILMODEM_DEFAULT_DBM_WEAK;
 	config->signal_strength_dbm_strong = RILMODEM_DEFAULT_DBM_STRONG;
 	config->empty_pin_query = RILMODEM_DEFAULT_EMPTY_PIN_QUERY;
@@ -1223,7 +1205,6 @@ static ril_slot *ril_plugin_slot_new_take(char *transport,
 	config->enable_stk = RILMODEM_DEFAULT_ENABLE_STK;
 	config->query_available_band_mode =
 		RILMODEM_DEFAULT_QUERY_AVAILABLE_BAND_MODE;
-	config->replace_strange_oper = RILMODEM_DEFAULT_REPLACE_STRANGE_OPER;
 	config->network_selection_manual_0 =
 		RILMODEM_DEFAULT_NETWORK_SELECTION_MANUAL_0;
 	config->force_gsm_when_radio_off =
@@ -1264,7 +1245,6 @@ static void ril_plugin_slot_apply_vendor_defaults(ril_slot *slot)
 		defaults.empty_pin_query = config->empty_pin_query;
 		defaults.mms_data_profile_id = config->mms_data_profile_id;
 		defaults.use_data_profiles = config->use_data_profiles;
-		defaults.replace_strange_oper = config->replace_strange_oper;
 		defaults.force_gsm_when_radio_off =
 			config->force_gsm_when_radio_off;
 		defaults.query_available_band_mode =
@@ -1277,7 +1257,6 @@ static void ril_plugin_slot_apply_vendor_defaults(ril_slot *slot)
 		config->empty_pin_query = defaults.empty_pin_query;
 		config->use_data_profiles = defaults.use_data_profiles;
 		config->mms_data_profile_id = defaults.mms_data_profile_id;
-		config->replace_strange_oper = defaults.replace_strange_oper;
 		config->force_gsm_when_radio_off =
 			defaults.force_gsm_when_radio_off;
 		config->query_available_band_mode =
@@ -1501,14 +1480,6 @@ static ril_slot *ril_plugin_parse_config_group(GKeyFile *file,
 				config->enable_stk ? "yes" : "no");
 	}
 
-	/* replaceStrangeOperatorNames */
-	if (ril_config_get_boolean(file, group,
-					RILCONF_REPLACE_STRANGE_OPER,
-					&config->replace_strange_oper)) {
-		DBG("%s: " RILCONF_REPLACE_STRANGE_OPER " %s", group,
-			config->replace_strange_oper ? "yes" : "no");
-	}
-
 	/* networkSelectionManual0 */
 	if (ril_config_get_boolean(file, group,
 					RILCONF_NETWORK_SELECTION_MANUAL_0,
@@ -1595,14 +1566,6 @@ static ril_slot *ril_plugin_parse_config_group(GKeyFile *file,
 					config->network_mode_timeout);
 	}
 
-	/* networkSelectionTimeout */
-	if (ril_config_get_integer(file, group,
-				RILCONF_NETWORK_SELECTION_TIMEOUT,
-				&config->network_selection_timeout)) {
-		DBG("%s: " RILCONF_NETWORK_SELECTION_TIMEOUT " %d", group,
-				config->network_selection_timeout);
-	}
-
 	/* signalStrengthRange */
 	ints = ril_config_get_ints(file, group, RILCONF_SIGNAL_STRENGTH_RANGE);
 	if (gutil_ints_get_count(ints) == 2) {
@@ -1743,32 +1706,23 @@ static ril_slot *ril_plugin_parse_config_group(GKeyFile *file,
 	}
 
 	/* deviceStateTracking */
-	if (ril_config_get_mask(file, group, RILCONF_DEVMON, &ival,
+	if (ril_config_get_enum(file, group, RILCONF_DEVMON, &ival,
+				"none", RIL_DEVMON_NONE,
+				"auto", RIL_DEVMON_AUTO,
 				"ds", RIL_DEVMON_DS,
-				"ss", RIL_DEVMON_SS,
-				"ur", RIL_DEVMON_UR, NULL) && ival) {
-		int n = 0;
-		struct ril_devmon *devmon[3];
-
-		if (ival & RIL_DEVMON_DS) devmon[n++] = ril_devmon_ds_new();
-		if (ival & RIL_DEVMON_SS) devmon[n++] = ril_devmon_ss_new();
-		if (ival & RIL_DEVMON_UR) devmon[n++] = ril_devmon_ur_new();
-		DBG("%s: " RILCONF_DEVMON " 0x%x", group, ival);
-		ril_devmon_free(slot->devmon);
-		slot->devmon = ril_devmon_combine(devmon, n);
-	} else {
-		/* Try special values */
-		sval = ril_config_get_string(file, group, RILCONF_DEVMON);
-		if (sval) {
-			if (!g_ascii_strcasecmp(sval, "none")) {
-				DBG("%s: " RILCONF_DEVMON " %s", group, sval);
-				ril_devmon_free(slot->devmon);
-				slot->devmon = NULL;
-			} else if (!g_ascii_strcasecmp(sval, "auto")) {
-				DBG("%s: " RILCONF_DEVMON " %s", group, sval);
-				/* This is the default */
-			}
-			g_free(sval);
+				"ss", RIL_DEVMON_SS, NULL)) {
+		DBG("%s: " RILCONF_DEVMON " %s", group,
+				ival == RIL_DEVMON_NONE ? "off" :
+				ival == RIL_DEVMON_DS ? "on" :
+				ival == RIL_DEVMON_SS ? "legacy" :
+				"auto");
+		if (ival != RIL_DEVMON_AUTO) {
+			/* Default is automatic, reallocate the object */
+			ril_devmon_free(slot->devmon);
+			slot->devmon =
+				(ival == RIL_DEVMON_DS ? ril_devmon_ds_new() :
+				 ival == RIL_DEVMON_SS ? ril_devmon_ss_new() :
+				 NULL);
 		}
 	}
 
@@ -2199,24 +2153,10 @@ static void ril_plugin_manager_free(ril_plugin *plugin)
 
 static void ril_slot_set_data_role(ril_slot *slot, enum sailfish_data_role r)
 {
-	enum ril_data_role role =
+	ril_data_allow(slot->data,
 		(r == SAILFISH_DATA_ROLE_INTERNET) ? RIL_DATA_ROLE_INTERNET :
 		(r == SAILFISH_DATA_ROLE_MMS) ? RIL_DATA_ROLE_MMS :
-		RIL_DATA_ROLE_NONE;
-	ril_data_allow(slot->data, role);
-	ril_radio_caps_request_free(slot->caps_req);
-	if (role == RIL_DATA_ROLE_NONE) {
-		slot->caps_req = NULL;
-	} else {
-		const enum ofono_radio_access_mode mode =
-			(r == SAILFISH_DATA_ROLE_MMS) ?
-				OFONO_RADIO_ACCESS_MODE_GSM :
-				__ofono_radio_access_max_mode
-						(slot->sim_settings->techs);
-
-		slot->caps_req = ril_radio_caps_request_new
-			(slot->caps, mode, role);
-	}
+		RIL_DATA_ROLE_NONE);
 }
 
 static void ril_slot_enabled_changed(struct sailfish_slot_impl *s)

ofono/drivers/ril/ril_radio.c

@@ -241,19 +241,7 @@ static void ril_radio_power_request(struct ril_radio *self, gboolean on,
 void ril_radio_confirm_power_on(struct ril_radio *self)
 {
 	if (G_LIKELY(self) && ril_radio_power_should_be_on(self)) {
-		struct ril_radio_priv *priv = self->priv;
-
-		if (priv->pending_id) {
-			if (!priv->next_state) {
-				/* Wait for the pending request to complete */
-				priv->next_state_valid = TRUE;
-				priv->next_state = TRUE;
-				DBG_(self, "on (queued)");
-			}
-		} else {
-			DBG_(self, "on");
-			ril_radio_submit_power_request(self, TRUE);
-		}
+		ril_radio_power_request(self, TRUE, TRUE);
 	}
 }
 

ofono/drivers/ril/ril_radio_caps.h

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2017-2020 Jolla Ltd.
+ *  Copyright (C) 2017 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -19,16 +19,12 @@
 #include "ril_types.h"
 
 struct ril_data_manager;
-struct ril_sim_settings;
 struct ril_radio_caps;
 struct ril_radio_caps_manager;
 struct ril_radio_capability;
-struct ril_radio_caps_request;
 
-typedef void (*ril_radio_caps_cb_t)(struct ril_radio_caps *caps, void *arg);
 typedef void (*ril_radio_caps_manager_cb_t)(struct ril_radio_caps_manager *mgr,
 							void *user_data);
-
 /* ril_radio_capability pointer is NULL if functionality is unsupported */
 typedef void (*ril_radio_caps_check_cb_t)
 		(const struct ril_radio_capability *cap, void *user_data);
@@ -43,47 +39,21 @@ struct ril_radio_caps_manager *ril_radio_caps_manager_new
 struct ril_radio_caps_manager *ril_radio_caps_manager_ref
 					(struct ril_radio_caps_manager *mgr);
 void ril_radio_caps_manager_unref(struct ril_radio_caps_manager *mgr);
-gulong ril_radio_caps_manager_add_tx_aborted_handler
-				(struct ril_radio_caps_manager *mgr,
-				ril_radio_caps_manager_cb_t cb, void *arg);
-gulong ril_radio_caps_manager_add_tx_done_handler
+gulong ril_radio_caps_manager_add_aborted_handler
 				(struct ril_radio_caps_manager *mgr,
 				ril_radio_caps_manager_cb_t cb, void *arg);
 void ril_radio_caps_manager_remove_handler(struct ril_radio_caps_manager *mgr,
-						gulong id);
-void ril_radio_caps_manager_remove_handlers(struct ril_radio_caps_manager *mgr,
-						gulong *ids, int count);
-#define ril_radio_caps_manager_remove_all_handlers(mgr, ids) \
-	ril_radio_caps_manager_remove_handlers(mgr, ids, G_N_ELEMENTS(ids))
+								gulong id);
 
 /* And one ril_radio_caps object per modem */
-
-struct ril_radio_caps {
-	struct ril_radio_caps_manager *mgr;
-	enum ofono_radio_access_mode supported_modes;
-};
-
 struct ril_radio_caps *ril_radio_caps_new(struct ril_radio_caps_manager *mgr,
 		const char *log_prefix, GRilIoChannel *io,
-		struct ofono_watch *watch,
 		struct ril_data *data, struct ril_radio *radio,
-		struct ril_sim_card *sim, struct ril_sim_settings *settings,
+		struct ril_sim_card *sim, struct ril_network *net,
 		const struct ril_slot_config *config,
 		const struct ril_radio_capability *cap);
 struct ril_radio_caps *ril_radio_caps_ref(struct ril_radio_caps *caps);
 void ril_radio_caps_unref(struct ril_radio_caps *caps);
-void ril_radio_caps_drop(struct ril_radio_caps *caps);
-gulong ril_radio_caps_add_supported_modes_handler
-				(struct ril_radio_caps *caps,
-					ril_radio_caps_cb_t cb, void *arg);
-void ril_radio_caps_remove_handler(struct ril_radio_caps *caps, gulong id);
-
-/* Data requests */
-
-struct ril_radio_caps_request *ril_radio_caps_request_new
-		(struct ril_radio_caps *caps, enum ofono_radio_access_mode mode,
-						enum ril_data_role role);
-void ril_radio_caps_request_free(struct ril_radio_caps_request *req);
 
 #endif /* RIL_RADIO_CAPS_H */
 

ofono/drivers/ril/ril_sim_settings.h

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2016-2020 Jolla Ltd.
+ *  Copyright (C) 2016-2018 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -45,8 +45,6 @@ gulong ril_sim_settings_add_pref_mode_changed_handler(struct ril_sim_settings *s
 void ril_sim_settings_remove_handler(struct ril_sim_settings *s, gulong id);
 void ril_sim_settings_remove_handlers(struct ril_sim_settings *s, gulong *ids,
 								int count);
-#define ril_sim_settings_remove_all_handlers(s,ids) \
-	ril_sim_settings_remove_handlers(s, ids, G_N_ELEMENTS(ids))
 
 #endif /* RIL_SIM_SETTINGS_H */
 

ofono/drivers/ril/ril_subscription.conf

@@ -237,13 +237,6 @@ socket=/dev/socket/rild
 #
 #networkModeTimeout=20000
 
-# Timeout for RIL_REQUEST_SET_NETWORK_SELECTION_AUTOMATIC and
-# RIL_REQUEST_SET_NETWORK_SELECTION_MANUAL, in milliseconds.
-#
-# Default 100000 (100 seconds)
-#
-#networkSelectionTimeout=100000
-
 # Comma-separated signal strength range, in dBm.
 #
 # These values are used for translating dBm values returned by the modem in
@@ -282,16 +275,6 @@ socket=/dev/socket/rild
 #
 #singleDataContext=false
 
-# With some RILs, RIL_REQUEST_QUERY_AVAILABLE_NETWORKS returns strange
-# operator names, i.e. numeric MCC+MNC values or the same name for all
-# operators (which is actually SPN fetched from the SIM). Such strange
-# names can be replaced with operator names from MBPI database, based
-# on the operator's MCC and MNC. That may not be 100% accurate, though.
-#
-# Default false (i.e. trust RIL to report the actual names)
-#
-#replaceStrangeOperatorNames=false
-
 # Configures whether +0 is added to MCCMNC string passed to
 # RIL_REQUEST_SET_NETWORK_SELECTION_MANUAL. Some Qualcomm RILs
 # require it, some MediaTek RILs don't like it.
@@ -319,15 +302,9 @@ socket=/dev/socket/rild
 #
 #   ss = Use legacy device state management (RIL_REQUEST_SCREEN_STATE)
 #   ds = Use newer device state management (RIL_REQUEST_SEND_DEVICE_STATE)
-#   ur = Use URC filter (RIL_REQUEST_SET_UNSOLICITED_RESPONSE_FILTER)
-#        This may be useful on devices with RIL version >= 15 if auto
-#        method fails
-#   auto = Choose ss or ds based on the RIL version
+#   auto = Choose one of the above based on the RIL version
 #   none = Disable device state management
 #
-# In addition to specifying ss, ds or ur method, one can specify a
-# combination of methods, e.g. ds+ur
-#
 # Default auto
 #
 #deviceStateTracking=auto

ofono/drivers/ril/ril_types.h

@@ -24,7 +24,6 @@
 #include <grilio_types.h>
 #include <gutil_macros.h>
 
-struct ofono_watch;
 struct ofono_modem;
 struct ofono_sim;
 
@@ -50,19 +49,12 @@ struct ril_network;
 struct ril_sim_card;
 struct ril_vendor;
 
-enum ril_data_role {
-	RIL_DATA_ROLE_NONE,    /* Mobile data not required */
-	RIL_DATA_ROLE_MMS,     /* Data is needed at any speed */
-	RIL_DATA_ROLE_INTERNET /* Data is needed at full speed */
-};
-
 struct ril_slot_config {
 	guint slot;
 	enum ofono_radio_access_mode techs;
 	enum ril_pref_net_type lte_network_mode;
 	enum ril_pref_net_type umts_network_mode;
 	int network_mode_timeout;
-	int network_selection_timeout;
 	int signal_strength_dbm_weak;
 	int signal_strength_dbm_strong;
 	gboolean query_available_band_mode;
@@ -72,7 +64,6 @@ struct ril_slot_config {
 	gboolean enable_voicecall;
 	gboolean enable_cbs;
 	gboolean enable_stk;
-	gboolean replace_strange_oper;
 	gboolean network_selection_manual_0;
 	gboolean force_gsm_when_radio_off;
 	gboolean use_data_profiles;

ofono/drivers/ril/ril_vendor.h

@@ -1,8 +1,8 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2016-2020 Jolla Ltd.
- *  Copyright (C) 2019-2020 Open Mobile Platform LLC.
+ *  Copyright (C) 2016-2019 Jolla Ltd.
+ *  Copyright (C) 2019 Open Mobile Platform LLC.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -24,7 +24,6 @@ struct ril_vendor_defaults {
 	gboolean legacy_imei_query;
 	gboolean enable_cbs;
 	gboolean enable_stk;
-	gboolean replace_strange_oper;
 	gboolean query_available_band_mode;
 	gboolean use_data_profiles;
 	gboolean force_gsm_when_radio_off;

ofono/drivers/ril/ril_vendor_mtk.c

@@ -1,8 +1,8 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2016-2020 Jolla Ltd.
- *  Copyright (C) 2019-2020 Open Mobile Platform LLC.
+ *  Copyright (C) 2016-2019 Jolla Ltd.
+ *  Copyright (C) 2019 Open Mobile Platform LLC.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -509,7 +509,6 @@ static void ril_vendor_mtk_get_defaults(struct ril_vendor_defaults *defaults)
 	defaults->empty_pin_query = FALSE;
 	defaults->legacy_imei_query = TRUE;
 	defaults->force_gsm_when_radio_off = FALSE;
-	defaults->replace_strange_oper = TRUE;
 }
 
 static void ril_vendor_mtk_base_init(RilVendorMtk *self, GRilIoChannel *io,

ofono/include/dbus-access.h

@@ -40,7 +40,6 @@ enum ofono_dbus_access_intf {
 	OFONO_DBUS_ACCESS_INTF_MODEM,         /* org.ofono.Modem */
 	OFONO_DBUS_ACCESS_INTF_RADIOSETTINGS, /* org.ofono.RadioSettings */
 	OFONO_DBUS_ACCESS_INTF_STK,           /* org.ofono.SimToolkit */
-	OFONO_DBUS_ACCESS_INTF_OEMRAW,        /* org.ofono.OemRaw */
 	OFONO_DBUS_ACCESS_INTF_COUNT
 };
 
@@ -125,12 +124,6 @@ enum ofono_dbus_access_stk_method {
 	OFONO_DBUS_ACCESS_STK_METHOD_COUNT
 };
 
-/* OFONO_DBUS_ACCESS_INTF_OEMRAW */
-enum ofono_dbus_access_oemraw_method {
-	OFONO_DBUS_ACCESS_OEMRAW_SEND,
-	OFONO_DBUS_ACCESS_OEMRAW_METHOD_COUNT
-};
-
 #define OFONO_DBUS_ACCESS_PRIORITY_LOW     (-100)
 #define OFONO_DBUS_ACCESS_PRIORITY_DEFAULT (0)
 #define OFONO_DBUS_ACCESS_PRIORITY_HIGH    (100)

ofono/plugins/mbpi.c

@@ -3,7 +3,7 @@
  *  oFono - Open Source Telephony
  *
  *  Copyright (C) 2008-2011  Intel Corporation. All rights reserved.
- *  Copyright (C) 2015-2020  Jolla Ltd.
+ *  Copyright (C) 2015-2017  Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -60,7 +60,6 @@ const char *mbpi_database = MBPI_DATABASE;
  */
 enum ofono_gprs_proto mbpi_default_internet_proto = OFONO_GPRS_PROTO_IPV4V6;
 enum ofono_gprs_proto mbpi_default_mms_proto = OFONO_GPRS_PROTO_IP;
-enum ofono_gprs_proto mbpi_default_ims_proto = OFONO_GPRS_PROTO_IPV4V6;
 enum ofono_gprs_proto mbpi_default_proto = OFONO_GPRS_PROTO_IP;
 enum ofono_gprs_auth_method mbpi_default_auth_method = OFONO_GPRS_AUTH_METHOD_ANY;
 
@@ -247,9 +246,6 @@ static void usage_start(GMarkupParseContext *context,
 	} else if (strcmp(text, "mms") == 0) {
 		apn->type = OFONO_GPRS_CONTEXT_TYPE_MMS;
 		apn->proto = mbpi_default_mms_proto;
-	} else if (strcmp(text, "ims") == 0) {
-		apn->type = OFONO_GPRS_CONTEXT_TYPE_IMS;
-		apn->proto = mbpi_default_ims_proto;
 	} else if (strcmp(text, "wap") == 0)
 		apn->type = OFONO_GPRS_CONTEXT_TYPE_WAP;
 	else

ofono/plugins/mbpi.h

@@ -3,7 +3,6 @@
  *  oFono - Open Source Telephony
  *
  *  Copyright (C) 2008-2011  Intel Corporation. All rights reserved.
- *  Copyright (C) 2013-2020  Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -23,7 +22,6 @@
 extern const char *mbpi_database;
 extern enum ofono_gprs_proto mbpi_default_internet_proto;
 extern enum ofono_gprs_proto mbpi_default_mms_proto;
-extern enum ofono_gprs_proto mbpi_default_ims_proto;
 extern enum ofono_gprs_proto mbpi_default_proto;
 extern enum ofono_gprs_auth_method mbpi_default_auth_method;
 

ofono/plugins/sailfish_provision.c

@@ -2,7 +2,7 @@
  *  oFono - Open Source Telephony
  *
  *  Copyright (C) 2008-2011  Intel Corporation. All rights reserved.
- *  Copyright (C) 2013-2020  Jolla Ltd.
+ *  Copyright (C) 2013-2017  Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -136,56 +136,38 @@ static GSList *provision_pick_best_ap(GSList *list, const char *spn,
 	}
 }
 
-/**
- * Returns the list containing INTERNET, MMS and IMS access points,
- * always all three of them and always in this order.
- */
+/* Returns the list containing exactly one INTERNET and one MMS access point */
 static GSList *provision_normalize_apn_list(GSList *apns, const char *spn)
 {
 	static const struct provision_ap_defaults internet_defaults =
 		{ OFONO_GPRS_CONTEXT_TYPE_INTERNET, "Internet", "internet" };
 	static const struct provision_ap_defaults mms_defaults =
 		{ OFONO_GPRS_CONTEXT_TYPE_MMS, "MMS", "mms" };
-	static const struct provision_ap_defaults ims_defaults =
-		{ OFONO_GPRS_CONTEXT_TYPE_IMS, "IMS", "ims" };
 
 	GSList *internet_apns = NULL;
 	GSList *mms_apns = NULL;
-	GSList *ims_apns = NULL;
 
-	/* Build separate apn list for each type */
+	/* Split internet and mms apns, delete all others */
 	while (apns) {
 		GSList *link = apns;
 		struct ofono_gprs_provision_data *ap = link->data;
 
 		apns = g_slist_remove_link(apns, link);
-		switch (ap->type) {
-		case OFONO_GPRS_CONTEXT_TYPE_INTERNET:
+		if (ap->type == OFONO_GPRS_CONTEXT_TYPE_INTERNET) {
 			internet_apns = g_slist_concat(internet_apns, link);
-			break;
-		case OFONO_GPRS_CONTEXT_TYPE_MMS:
+		} else if (ap->type == OFONO_GPRS_CONTEXT_TYPE_MMS) {
 			mms_apns = g_slist_concat(mms_apns, link);
-			break;
-		case OFONO_GPRS_CONTEXT_TYPE_IMS:
-			ims_apns = g_slist_concat(ims_apns, link);
-			break;
-		default:
+		} else {
 			g_slist_free_full(link, provision_free_ap);
-			break;
 		}
 	}
 
-	/* Pick the best ap of each type */
-	internet_apns = provision_pick_best_ap(internet_apns, spn,
-			mbpi_default_internet_proto, &internet_defaults);
-	mms_apns = provision_pick_best_ap(mms_apns, spn,
-			mbpi_default_mms_proto, &mms_defaults);
-	ims_apns = provision_pick_best_ap(ims_apns, spn,
-			mbpi_default_ims_proto, &ims_defaults);
-
-	/* And concatenate them in the right order */
-	return g_slist_concat(internet_apns, g_slist_concat(mms_apns,
-								ims_apns));
+	/* Pick the best ap of each type and concatenate them */
+	return g_slist_concat(
+		provision_pick_best_ap(internet_apns, spn,
+			mbpi_default_internet_proto, &internet_defaults),
+		provision_pick_best_ap(mms_apns, spn,
+			mbpi_default_mms_proto, &mms_defaults));
 }
 
 int provision_get_settings(const char *mcc, const char *mnc,

ofono/plugins/smshistory.c

@@ -4,7 +4,6 @@
  *
  *  Copyright (C) 2008-2011  Intel Corporation. All rights reserved.
  *  Copyright (C) 2013  Jolla Ltd. All rights reserved.
- *  Copyright (C) 2020  Open Mobile Platform LLС. All rights reserved.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -27,7 +26,6 @@
 
 #include <string.h>
 #include <stdio.h>
-#include <errno.h>
 #include <glib.h>
 #include <gdbus.h>
 
@@ -42,42 +40,58 @@
 
 #define SMS_HISTORY_INTERFACE "org.ofono.SmsHistory"
 
+gboolean sms_history_interface_registered = FALSE;
+
 static const GDBusSignalTable sms_history_signals[] = {
 	{ GDBUS_SIGNAL("StatusReport",
 		GDBUS_ARGS({ "message", "s" }, { "Delivered", "a{b}" })) },
 	{ }
 };
 
-static int sms_history_probe(struct ofono_history_context *context)
+static void sms_history_cleanup(gpointer user)
 {
+	struct ofono_modem *modem = user;
+	DBG("modem %p", modem);
+	ofono_modem_remove_interface(modem, SMS_HISTORY_INTERFACE);
+	sms_history_interface_registered = FALSE;
+}
+
+static gboolean sms_history_ensure_interface(
+		struct ofono_modem *modem) {
+
+	if (sms_history_interface_registered)
+		return TRUE;
+
+	/* Late initialization of the D-Bus interface */
 	DBusConnection *conn = ofono_dbus_get_connection();
-	struct ofono_modem *modem = context->modem;
-
-	ofono_debug("SMS History Probe for modem: %p", modem);
-
+	if (conn == NULL)
+		return FALSE;
 	if (!g_dbus_register_interface(conn,
 					ofono_modem_get_path(modem),
 					SMS_HISTORY_INTERFACE,
-					NULL, sms_history_signals,
-					NULL, NULL, NULL)) {
+					NULL, sms_history_signals, NULL,
+					modem, sms_history_cleanup)) {
 		ofono_error("Could not create %s interface",
 				SMS_HISTORY_INTERFACE);
-		return -EIO;
+		return FALSE;
 	}
-
+	sms_history_interface_registered = TRUE;
 	ofono_modem_add_interface(modem, SMS_HISTORY_INTERFACE);
+
+	return TRUE;
+}
+
+
+static int sms_history_probe(struct ofono_history_context *context)
+{
+	ofono_debug("SMS History Probe for modem: %p", context->modem);
+	sms_history_ensure_interface(context->modem);
 	return 0;
 }
 
 static void sms_history_remove(struct ofono_history_context *context)
 {
-	DBusConnection *conn = ofono_dbus_get_connection();
-	struct ofono_modem *modem = context->modem;
-
-	ofono_debug("SMS History remove for modem: %p", modem);
-	ofono_modem_remove_interface(modem, SMS_HISTORY_INTERFACE);
-	g_dbus_unregister_interface(conn, ofono_modem_get_path(modem),
-					SMS_HISTORY_INTERFACE);
+	ofono_debug("SMS History Remove for modem: %p", context->modem);
 }
 
 static void sms_history_sms_send_status(
@@ -88,6 +102,9 @@ static void sms_history_sms_send_status(
 {
 	DBG("");
 
+	if (!sms_history_ensure_interface(context->modem))
+		return;
+
 	if ((s == OFONO_HISTORY_SMS_STATUS_DELIVERED) 
 			|| (s == OFONO_HISTORY_SMS_STATUS_DELIVER_FAILED)) {
 
@@ -157,3 +174,4 @@ static void sms_history_exit(void)
 OFONO_PLUGIN_DEFINE(sms_history, "SMS History Plugin",
 			VERSION, OFONO_PLUGIN_PRIORITY_DEFAULT,
 			sms_history_init, sms_history_exit)
+

ofono/src/dbus-access.c

@@ -44,8 +44,6 @@ const char *ofono_dbus_access_intf_name(enum ofono_dbus_access_intf intf)
 		return OFONO_RADIO_SETTINGS_INTERFACE;
 	case OFONO_DBUS_ACCESS_INTF_STK:
 		return OFONO_STK_INTERFACE;
-	case OFONO_DBUS_ACCESS_INTF_OEMRAW:
-		return "org.ofono.OemRaw";
 	case OFONO_DBUS_ACCESS_INTF_COUNT:
 		break;
 	}
@@ -178,14 +176,6 @@ const char *ofono_dbus_access_method_name(enum ofono_dbus_access_intf intf,
 			break;
 		}
 		break;
-	case OFONO_DBUS_ACCESS_INTF_OEMRAW:
-		switch ((enum ofono_dbus_access_oemraw_method)method) {
-		case OFONO_DBUS_ACCESS_OEMRAW_SEND:
-			return "Send";
-		case OFONO_DBUS_ACCESS_OEMRAW_METHOD_COUNT:
-			break;
-		}
-		break;
 	case OFONO_DBUS_ACCESS_INTF_COUNT:
 		break;
 	}

ofono/src/gprs.c

@@ -3,7 +3,7 @@
  *  oFono - Open Source Telephony
  *
  *  Copyright (C) 2008-2011  Intel Corporation. All rights reserved.
- *  Copyright (C) 2015-2020  Jolla Ltd.
+ *  Copyright (C) 2015-2019  Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -2874,53 +2874,12 @@ static void provision_contexts(struct ofono_gprs *gprs, const char *mcc,
 		return;
 	}
 
-	for (i = 0; i < count; i++) {
-		const struct ofono_gprs_provision_data *ap = settings + i;
-
-		if (!ofono_gprs_context_settings_by_type(gprs, ap->type)) {
-			provision_context(ap, gprs);
-		}
-	}
+	for (i = 0; i < count; i++)
+		provision_context(&settings[i], gprs);
 
 	__ofono_gprs_provision_free_settings(settings, count);
 }
 
-static gboolean all_contexts_configured(struct ofono_gprs *gprs)
-{
-	GSList *l;
-
-	for (l = gprs->context_drivers; l; l = l->next) {
-		struct ofono_gprs_context *gc = l->data;
-
-		if (gc->type != OFONO_GPRS_CONTEXT_TYPE_ANY &&
-			!ofono_gprs_context_settings_by_type(gprs, gc->type)) {
-			return FALSE; /* Not yet */
-		}
-	}
-
-	return TRUE;
-}
-
-static void configure_remaining_contexts(struct ofono_gprs *gprs)
-{
-	GSList *l;
-
-	for (l = gprs->context_drivers; l; l = l->next) {
-		struct ofono_gprs_context *gc = l->data;
-
-		if (gc->type != OFONO_GPRS_CONTEXT_TYPE_ANY &&
-			!ofono_gprs_context_settings_by_type(gprs, gc->type)) {
-			add_context(gprs, NULL, gc->type);
-		}
-	}
-
-	/* Make sure internet context is there */
-	if (!ofono_gprs_context_settings_by_type(gprs,
-					OFONO_GPRS_CONTEXT_TYPE_INTERNET)) {
-		add_context(gprs, NULL, OFONO_GPRS_CONTEXT_TYPE_INTERNET);
-	}
-}
-
 static void remove_non_active_context(struct ofono_gprs *gprs,
 				struct pri_context *ctx, DBusConnection *conn)
 {
@@ -3001,7 +2960,8 @@ static DBusMessage *gprs_reset_contexts(DBusConnection *conn,
 	provision_contexts(gprs, ofono_sim_get_mcc(sim),
 				ofono_sim_get_mnc(sim), ofono_sim_get_spn(sim));
 
-	configure_remaining_contexts(gprs);
+	if (gprs->contexts == NULL) /* Automatic provisioning failed */
+		add_context(gprs, NULL, OFONO_GPRS_CONTEXT_TYPE_INTERNET);
 
 	for (l = gprs->contexts; l; l = l->next) {
 		struct pri_context *ctx = l->data;
@@ -3872,7 +3832,8 @@ static void ofono_gprs_finish_register(struct ofono_gprs *gprs)
 	struct ofono_modem *modem = __ofono_atom_get_modem(gprs->atom);
 	const char *path = __ofono_atom_get_path(gprs->atom);
 
-	configure_remaining_contexts(gprs);
+	if (gprs->contexts == NULL) /* Automatic provisioning failed */
+		add_context(gprs, NULL, OFONO_GPRS_CONTEXT_TYPE_INTERNET);
 
 	if (!g_dbus_register_interface(conn, path,
 					OFONO_CONNECTION_MANAGER_INTERFACE,
@@ -3895,14 +3856,56 @@ static void ofono_gprs_finish_register(struct ofono_gprs *gprs)
 	__ofono_atom_register(gprs->atom, gprs_unregister);
 }
 
+static gboolean mms_context_configured(struct ofono_gprs *gprs)
+{
+	GSList *l;
+
+	for (l = gprs->contexts; l; l = l->next) {
+		struct pri_context *ctx = l->data;
+
+		if (ctx->type == OFONO_GPRS_CONTEXT_TYPE_MMS)
+			return TRUE;
+	}
+
+	return FALSE;
+}
+
+static void provision_mms_context(struct ofono_gprs *gprs, const char *mcc,
+				const char *mnc, const char *spn)
+{
+	struct ofono_gprs_provision_data *settings;
+	int count;
+	int i;
+
+	if (__ofono_gprs_provision_get_settings(mcc, mnc, spn,
+						&settings, &count) == FALSE) {
+		ofono_warn("Provisioning failed");
+		return;
+	}
+
+	for (i = 0; i < count; i++) {
+		if (settings[i].type == OFONO_GPRS_CONTEXT_TYPE_MMS) {
+			provision_context(&settings[i], gprs);
+			break;
+		}
+	}
+
+	__ofono_gprs_provision_free_settings(settings, count);
+}
+
 static void spn_read_cb(const char *spn, const char *dc, void *data)
 {
 	struct ofono_gprs *gprs	= data;
 	struct ofono_modem *modem = __ofono_atom_get_modem(gprs->atom);
 	struct ofono_sim *sim = __ofono_atom_find(OFONO_ATOM_TYPE_SIM, modem);
 
-	provision_contexts(gprs, ofono_sim_get_mcc(sim),
+	if (gprs->contexts == NULL) {
+		provision_contexts(gprs, ofono_sim_get_mcc(sim),
 					ofono_sim_get_mnc(sim), spn);
+	} else if (!mms_context_configured(gprs)) {
+		provision_mms_context(gprs, ofono_sim_get_mcc(sim),
+					ofono_sim_get_mnc(sim), spn);
+	}
 
 	ofono_sim_remove_spn_watch(sim, &gprs->spn_watch);
 
@@ -3924,7 +3927,7 @@ void ofono_gprs_register(struct ofono_gprs *gprs)
 
 	gprs_load_settings(gprs, ofono_sim_get_imsi(sim));
 
-	if (all_contexts_configured(gprs))
+	if (mms_context_configured(gprs))
 		goto finish;
 
 	ofono_sim_add_spn_watch(sim, &gprs->spn_watch, spn_read_cb, gprs, NULL);

ofono/src/ofono.h

@@ -283,10 +283,6 @@ enum ofono_gprs_context_type __ofono_gprs_context_get_assigned_type(
 						struct ofono_gprs_context *gc);
 
 #include <ofono/radio-settings.h>
-
-enum ofono_radio_access_mode __ofono_radio_access_max_mode(
-					enum ofono_radio_access_mode modes);
-
 #include <ofono/audio-settings.h>
 #include <ofono/ctm.h>
 #include <ofono/location-reporting.h>

ofono/src/plugin.c

@@ -30,8 +30,6 @@
 
 #include "ofono.h"
 
-#pragma message("PLUGINDIR="PLUGINDIR)
-
 static GSList *plugins = NULL;
 
 struct ofono_plugin {

ofono/src/radio-settings.c

@@ -2,8 +2,7 @@
  *
  *  oFono - Open Source Telephony
  *
- *  Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
- *  Copyright (C) 2014-2020 Jolla Ltd.
+ *  Copyright (C) 2010  Nokia Corporation and/or its subsidiary(-ies).
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -62,22 +61,10 @@ struct ofono_radio_settings {
 	struct ofono_atom *atom;
 };
 
-enum ofono_radio_access_mode __ofono_radio_access_max_mode(
-					enum ofono_radio_access_mode mask)
-{
-	return	(mask & OFONO_RADIO_ACCESS_MODE_LTE) ?
-					OFONO_RADIO_ACCESS_MODE_LTE :
-		(mask & OFONO_RADIO_ACCESS_MODE_UMTS) ?
-					OFONO_RADIO_ACCESS_MODE_UMTS :
-		(mask & OFONO_RADIO_ACCESS_MODE_GSM) ?
-					OFONO_RADIO_ACCESS_MODE_GSM :
-					OFONO_RADIO_ACCESS_MODE_ANY;
-}
-
 #define radio_access_mode_to_string ofono_radio_access_mode_to_string
 const char *ofono_radio_access_mode_to_string(enum ofono_radio_access_mode m)
 {
-	switch (__ofono_radio_access_max_mode(m)) {
+	switch (m) {
 	case OFONO_RADIO_ACCESS_MODE_ANY:
 		return "any";
 	case OFONO_RADIO_ACCESS_MODE_GSM:
@@ -89,10 +76,6 @@ const char *ofono_radio_access_mode_to_string(enum ofono_radio_access_mode m)
 	default:
 		return NULL;
 	}
-	return (m == OFONO_RADIO_ACCESS_MODE_ANY) ? "any" :
-			(m & OFONO_RADIO_ACCESS_MODE_LTE) ?  "lte" :
-			(m & OFONO_RADIO_ACCESS_MODE_UMTS) ? "umts" :
-			(m & OFONO_RADIO_ACCESS_MODE_GSM) ? "gsm" : NULL;
 }
 #define radio_access_mode_from_string ofono_radio_access_mode_from_string
 ofono_bool_t ofono_radio_access_mode_from_string(const char *str,

ofono/src/smsutil.c

@@ -3,7 +3,6 @@
  *  oFono - Open Source Telephony
  *
  *  Copyright (C) 2008-2011  Intel Corporation. All rights reserved.
- *  Copyright (C) 2015-2020  Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -1758,7 +1757,7 @@ gboolean sms_udh_iter_init_from_cbs(const struct cbs *cbs,
 		return FALSE;
 
 	hdr = cbs->ud;
-	max_ud_len = cbs->udlen;
+	max_ud_len = 82;
 
 	/* Must have at least one information-element if udhi is true */
 	if (hdr[0] < 2)
@@ -3857,8 +3856,8 @@ gboolean cbs_dcs_decode(guint8 dcs, gboolean *udhi, enum sms_class *cls,
 
 gboolean cbs_decode(const unsigned char *pdu, int len, struct cbs *out)
 {
-	/* CBS is (almost) always a fixed length of 88 bytes */
-	if (len < 6 || len > 88)
+	/* CBS is always a fixed length of 88 bytes */
+	if (len != 88)
 		return FALSE;
 
 	out->gs = (enum cbs_geo_scope) ((pdu[0] >> 6) & 0x03);
@@ -3869,10 +3868,6 @@ gboolean cbs_decode(const unsigned char *pdu, int len, struct cbs *out)
 	out->max_pages = pdu[5] & 0xf;
 	out->page = (pdu[5] >> 4) & 0xf;
 
-	/* Allow the last fragment to be truncated */
-	if (len != 88 && out->max_pages != out->page)
-		return FALSE;
-
 	/*
 	 * If a mobile receives the code 0000 in either the first field or
 	 * the second field then it shall treat the CBS message exactly the
@@ -3884,10 +3879,7 @@ gboolean cbs_decode(const unsigned char *pdu, int len, struct cbs *out)
 		out->page = 1;
 	}
 
-	out->udlen = (guint8)(len - 6);
-	memcpy(out->ud, pdu + 6, out->udlen);
-	if (out->udlen < 82)
-		memset(out->ud + out->udlen, 0, 82 - out->udlen);
+	memcpy(out->ud, pdu + 6, 82);
 
 	return TRUE;
 }
@@ -4080,7 +4072,7 @@ char *cbs_decode_text(GSList *cbs_list, char *iso639_lang)
 			if (iso639)
 				bufsize -= 3;
 		} else {
-			bufsize += cbs->udlen;
+			bufsize += 82;
 
 			if (iso639)
 				bufsize -= 2;
@@ -4097,7 +4089,7 @@ char *cbs_decode_text(GSList *cbs_list, char *iso639_lang)
 			if (sms_udh_iter_init_from_cbs(cbs, &iter))
 				taken = sms_udh_iter_get_udh_length(&iter) + 1;
 
-			unpack_7bit_own_buf(cbs->ud + taken, cbs->udlen - taken,
+			unpack_7bit_own_buf(cbs->ud + taken, 82 - taken,
 						taken, FALSE, 2,
 						NULL, 0,
 						(unsigned char *)iso639_lang);
@@ -4130,7 +4122,7 @@ char *cbs_decode_text(GSList *cbs_list, char *iso639_lang)
 			max_chars =
 				sms_text_capacity_gsm(CBS_MAX_GSM_CHARS, taken);
 
-			unpack_7bit_own_buf(ud + taken, cbs->udlen - taken,
+			unpack_7bit_own_buf(ud + taken, 82 - taken,
 						taken, FALSE, max_chars,
 						&written, 0, unpacked);
 
@@ -4164,7 +4156,7 @@ char *cbs_decode_text(GSList *cbs_list, char *iso639_lang)
 			 * the check here since the specification isn't clear
 			 */
 		} else {
-			int num_ucs2_chars = (cbs->udlen - taken) >> 1;
+			int num_ucs2_chars = (82 - taken) >> 1;
 			int i = taken;
 			int max_offset = taken + num_ucs2_chars * 2;
 

ofono/src/smsutil.h

@@ -3,7 +3,6 @@
  *  oFono - Open Source Telephony
  *
  *  Copyright (C) 2008-2011  Intel Corporation. All rights reserved.
- *  Copyright (C) 2015-2020  Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -399,7 +398,6 @@ struct cbs {
 	guint8 dcs;				/* 8 bits */
 	guint8 max_pages;			/* 4 bits */
 	guint8 page;				/* 4 bits */
-	guint8 udlen;
 	guint8 ud[82];
 };
 

ofono/src/voicecall.c

@@ -349,12 +349,12 @@ static int tone_queue(struct ofono_voicecall *vc, const char *tone_str,
 
 	/*
 	 * Tones can be 0-9, *, #, A-D according to 27.007 C.2.11,
-	 * and p for Pause (also , for Pause as per ITU-T V.250 6.3.1.2).
+	 * and p for Pause.
 	 */
 	for (i = 0; tone_str[i]; i++)
 		if (!g_ascii_isdigit(tone_str[i]) && tone_str[i] != 'p' &&
 				tone_str[i] != 'P' && tone_str[i] != '*' &&
-				tone_str[i] != ',' &&
+				tone_str[i] != '.' && tone_str[i] != ',' &&
 				tone_str[i] != '#' && (tone_str[i] < 'A' ||
 				tone_str[i] > 'D'))
 			return -EINVAL;
@@ -4389,7 +4389,7 @@ static void tone_request_cb(const struct ofono_error *error, void *data)
 		goto done;
 	}
 
-	len = strspn(entry->left, "pP,");
+	len = strspn(entry->left, "pP.,");
 	entry->left += len;
 
 done:
@@ -4423,7 +4423,7 @@ static gboolean tone_request_run(gpointer user_data)
 	if (entry == NULL)
 		return FALSE;
 
-	len = strcspn(entry->left, "pP,");
+	len = strcspn(entry->left, "pP.,");
 
 	if (len) {
 		if (len > 8) /* Arbitrary length limit per request */

ofono/unit/test-dbus-access.c

@@ -34,12 +34,6 @@ static enum ofono_dbus_access deny_method_access(const char *sender,
 	return OFONO_DBUS_ACCESS_DENY;
 }
 
-static enum ofono_dbus_access broken_method_access(const char *sender,
-	enum ofono_dbus_access_intf intf, int method, const char *arg)
-{
-	return (enum ofono_dbus_access)(-1);
-}
-
 struct ofono_dbus_access_plugin access_inval;
 struct ofono_dbus_access_plugin access_dontcare = {
 	.name = "DontCare",
@@ -57,12 +51,6 @@ struct ofono_dbus_access_plugin access_deny = {
 	.method_access = deny_method_access
 };
 
-struct ofono_dbus_access_plugin access_broken = {
-	.name = "Broken",
-	.priority = OFONO_DBUS_ACCESS_PRIORITY_LOW,
-	.method_access = broken_method_access
-};
-
 /*==========================================================================*
  * Tests
  *==========================================================================*/
@@ -119,9 +107,6 @@ static const struct test_method_name_data method_name_tests[] = {
 	},{
 		OFONO_DBUS_ACCESS_INTF_STK,
 		OFONO_DBUS_ACCESS_STK_METHOD_COUNT
-	},{
-		OFONO_DBUS_ACCESS_INTF_OEMRAW,
-		OFONO_DBUS_ACCESS_OEMRAW_METHOD_COUNT
 	}
 };
 
@@ -171,13 +156,6 @@ static void test_register()
 	ofono_dbus_access_plugin_unregister(&access_deny);
 	ofono_dbus_access_plugin_unregister(&access_dontcare);
 
-	/* And here too */
-	g_assert(!ofono_dbus_access_plugin_register(&access_broken));
-	g_assert(!ofono_dbus_access_plugin_register(&access_deny));
-	g_assert(!__ofono_dbus_access_method_allowed(":1.0", 0, 1, NULL));
-	ofono_dbus_access_plugin_unregister(&access_deny);
-	ofono_dbus_access_plugin_unregister(&access_dontcare);
-
 	/* DontCare will allow everything */
 	g_assert(!ofono_dbus_access_plugin_register(&access_dontcare));
 	g_assert(__ofono_dbus_access_method_allowed(":1.0", 0, 1, NULL));

ofono/unit/test-provision.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony
  *
- *  Copyright (C) 2014-2020 Jolla. All rights reserved.
+ *  Copyright (C) 2014-2017 Jolla. All rights reserved.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -105,21 +105,21 @@ static void test_provision(gconstpointer test_data)
 
 			g_assert(actual->type == expected->type);
 			g_assert(actual->proto == expected->proto);
-			g_assert_cmpstr(actual->provider_name, ==,
-						expected->provider_name);
-			g_assert_cmpstr(actual->name, ==, expected->name);
+			g_assert(!g_strcmp0(actual->provider_name,
+						expected->provider_name));
+			g_assert(!g_strcmp0(actual->name, expected->name));
 			g_assert(actual->provider_primary ==
 						expected->provider_primary);
-			g_assert_cmpstr(actual->apn, ==, expected->apn);
-			g_assert_cmpstr(actual->username, ==,
-						expected->username);
-			g_assert_cmpstr(actual->password, ==,
-						expected->password);
+			g_assert(!g_strcmp0(actual->apn, expected->apn));
+			g_assert(!g_strcmp0(actual->username,
+						expected->username));
+			g_assert(!g_strcmp0(actual->password,
+						expected->password));
 			g_assert(actual->auth_method == expected->auth_method);
-			g_assert_cmpstr(actual->message_proxy, ==,
-						expected->message_proxy);
-			g_assert_cmpstr(actual->message_center, ==,
-						expected->message_center);
+			g_assert(!g_strcmp0(actual->message_proxy,
+						expected->message_proxy));
+			g_assert(!g_strcmp0(actual->message_center,
+						expected->message_center));
 		}
 	} else {
 		g_assert(!__ofono_gprs_provision_get_settings(test->mcc,
@@ -212,14 +212,6 @@ static char telia_fi_message_center [] = "http://mms/";
 	.apn = "mms", \
 	.auth_method = OFONO_GPRS_AUTH_METHOD_NONE
 
-/* Default IMS settings */
-#define DEFAULT_IMS_SETTINGS \
-	.type = OFONO_GPRS_CONTEXT_TYPE_IMS, \
-	.proto = OFONO_GPRS_PROTO_IPV4V6, \
-	.name = "IMS", \
-	.apn = "ims", \
-	.auth_method = OFONO_GPRS_AUTH_METHOD_NONE
-
 static const struct ofono_gprs_provision_data telia_fi_internet_mms_p[] = {
 	{
 		.type = OFONO_GPRS_CONTEXT_TYPE_INTERNET,
@@ -239,8 +231,7 @@ static const struct ofono_gprs_provision_data telia_fi_internet_mms_p[] = {
 		.auth_method = OFONO_GPRS_AUTH_METHOD_NONE,
 		.message_proxy = telia_fi_message_proxy,
 		.message_center = telia_fi_message_center
-	},
-	{ DEFAULT_IMS_SETTINGS }
+	}
 };
 
 static const struct ofono_gprs_provision_data telia_fi_internet_mms[] = {
@@ -260,8 +251,7 @@ static const struct ofono_gprs_provision_data telia_fi_internet_mms[] = {
 		.auth_method = OFONO_GPRS_AUTH_METHOD_NONE,
 		.message_proxy = telia_fi_message_proxy,
 		.message_center = telia_fi_message_center
-	},
-	{ DEFAULT_IMS_SETTINGS }
+	}
 };
 
 static const struct ofono_gprs_provision_data telia_fi_internet[] = {
@@ -273,8 +263,7 @@ static const struct ofono_gprs_provision_data telia_fi_internet[] = {
 		.apn = telia_fi_apn_internet,
 		.auth_method = OFONO_GPRS_AUTH_METHOD_NONE
 	},
-	{ DEFAULT_MMS_SETTINGS },
-	{ DEFAULT_IMS_SETTINGS }
+	{ DEFAULT_MMS_SETTINGS }
 };
 
 static const struct ofono_gprs_provision_data telia_fi_mms[] = {
@@ -288,14 +277,12 @@ static const struct ofono_gprs_provision_data telia_fi_mms[] = {
 		.auth_method = OFONO_GPRS_AUTH_METHOD_NONE,
 		.message_proxy = telia_fi_message_proxy,
 		.message_center = telia_fi_message_center
-	},
-	{ DEFAULT_IMS_SETTINGS }
+	}
 };
 
 static const struct ofono_gprs_provision_data default_settings[] = {
 	{ DEFAILT_INTERNET_SETTINGS },
-	{ DEFAULT_MMS_SETTINGS },
-	{ DEFAULT_IMS_SETTINGS }
+	{ DEFAULT_MMS_SETTINGS }
 };
 
 static const struct ofono_gprs_provision_data no_auth_settings[] = {
@@ -313,8 +300,7 @@ static const struct ofono_gprs_provision_data no_auth_settings[] = {
 		.name = "MMS",
 		.apn = "mms",
 		.auth_method = OFONO_GPRS_AUTH_METHOD_NONE
-	},
-	{ DEFAULT_IMS_SETTINGS }
+	}
 };
 
 static const struct ofono_gprs_provision_data auth_settings[] = {
@@ -332,8 +318,7 @@ static const struct ofono_gprs_provision_data auth_settings[] = {
 		.apn = "mms",
 		.password = "password",
 		.auth_method = OFONO_GPRS_AUTH_METHOD_ANY
-	},
-	{ DEFAULT_IMS_SETTINGS }
+	}
 };
 
 static const struct ofono_gprs_provision_data settings_ip[] = {
@@ -344,8 +329,7 @@ static const struct ofono_gprs_provision_data settings_ip[] = {
 		.apn = "internet",
 		.auth_method = OFONO_GPRS_AUTH_METHOD_NONE
 	},
-	{ DEFAULT_MMS_SETTINGS },
-	{ DEFAULT_IMS_SETTINGS }
+	{ DEFAULT_MMS_SETTINGS }
 };
 
 static const struct ofono_gprs_provision_data settings_ipv6[] = {
@@ -361,8 +345,7 @@ static const struct ofono_gprs_provision_data settings_ipv6[] = {
 		.name = "MMS",
 		.apn = "mms",
 		.auth_method = OFONO_GPRS_AUTH_METHOD_NONE
-	},
-	{ DEFAULT_IMS_SETTINGS }
+	}
 };
 
 static const struct ofono_gprs_provision_data settings_ipv4v6[] = {
@@ -373,40 +356,7 @@ static const struct ofono_gprs_provision_data settings_ipv4v6[] = {
 		.name = "MMS",
 		.apn = "mms",
 		.auth_method = OFONO_GPRS_AUTH_METHOD_NONE
-	},
-	{ DEFAULT_IMS_SETTINGS }
-};
-
-static char beeline_provider_name [] = "Beeline";
-static const struct ofono_gprs_provision_data beeline_ims[] = {
-	{
-		.type = OFONO_GPRS_CONTEXT_TYPE_INTERNET,
-		.proto = OFONO_GPRS_PROTO_IPV4V6,
-		.provider_name = beeline_provider_name,
-		.name = "Beeline Internet",
-		.apn = "internet.beeline.ru",
-                .username = "beeline",
-                .password = "beeline",
-		.auth_method = OFONO_GPRS_AUTH_METHOD_ANY
-	}, {
-		.type = OFONO_GPRS_CONTEXT_TYPE_MMS,
-		.proto = OFONO_GPRS_PROTO_IP,
-		.provider_name = beeline_provider_name,
-		.name = "Beeline MMS",
-		.apn = "mms.beeline.ru",
-                .username = "beeline",
-                .password = "beeline",
-		.auth_method = OFONO_GPRS_AUTH_METHOD_PAP,
-		.message_proxy = "192.168.94.23:8080",
-		.message_center = "http://mms/"
-	}, {
-		.type = OFONO_GPRS_CONTEXT_TYPE_IMS,
-		.proto = OFONO_GPRS_PROTO_IPV4V6,
-		.provider_name = beeline_provider_name,
-		.name = "Beeline IMS",
-		.apn = "ims.beeline.ru",
-		.auth_method = OFONO_GPRS_AUTH_METHOD_NONE
-        }
+	}
 };
 
 static char test_provider_name[] = "Test provider";
@@ -432,8 +382,7 @@ static const struct ofono_gprs_provision_data test_username_password[] = {
 		.auth_method = OFONO_GPRS_AUTH_METHOD_CHAP,
 		.message_proxy = test_message_proxy,
 		.message_center = test_message_center
-	},
-	{ DEFAULT_IMS_SETTINGS }
+	}
 };
 
 static const char telia_fi_internet_xml[] =
@@ -857,42 +806,6 @@ static const struct provision_test_case test_cases[] = {
 		.mnc = "91",
 		.settings = telia_fi_mms,
 		.count = G_N_ELEMENTS(telia_fi_mms)
-	},{
-		.name = TEST_SUITE "ims",
-		.xml =
-"<serviceproviders format=\"2.0\">\n\
-<country code=\"ru\">\n\
-  <provider>\n\
-    <name>Beeline</name>\n\
-    <gsm>\n\
-      <network-id mcc=\"250\" mnc=\"99\"/>\n\
-      <apn value=\"internet.beeline.ru\">\n\
-        <usage type=\"internet\"/>\n\
-        <name>Beeline Internet</name>\n\
-        <username>beeline</username>\n\
-        <password>beeline</password>\n\
-      </apn>\n\
-      <apn value=\"mms.beeline.ru\">\n\
-        <usage type=\"mms\"/>\n\
-        <name>Beeline MMS</name>\n\
-        <authentication method=\"pap\"/>\n\
-        <username>beeline</username>\n\
-        <password>beeline</password>\n\
-        <mmsc>http://mms/</mmsc>\n\
-        <mmsproxy>192.168.94.23:8080</mmsproxy>\n\
-      </apn>\n\
-      <apn value=\"ims.beeline.ru\">\n\
-        <usage type=\"ims\"/>\n\
-        <name>Beeline IMS</name>\n\
-      </apn>\n\
-    </gsm>\n\
-  </provider>\n\
-</country>\n\
-</serviceproviders>\n",
-		.mcc = "250",
-		.mnc = "99",
-		.settings = beeline_ims,
-		.count = G_N_ELEMENTS(beeline_ims)
 	},{
 		.name = TEST_SUITE "not_found_mcc",
 		.xml = telia_fi_internet_xml,
@@ -1384,11 +1297,3 @@ int main(int argc, char **argv)
 	}
 	return g_test_run();
 }
-
-/*
- * Local Variables:
- * mode: C
- * c-basic-offset: 8
- * indent-tabs-mode: t
- * End:
- */

ofono/unit/test-ril_config.c

@@ -1,8 +1,8 @@
 /*
  *  oFono - Open Source Telephony
  *
- *  Copyright (C) 2018-2020 Jolla Ltd.
- *  Copyright (C) 2019-2020 Open Mobile Platform LLC.
+ *  Copyright (C) 2018-2019 Jolla Ltd.
+ *  Copyright (C) 2019 Open Mobile Platform LLC.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -377,39 +377,6 @@ static void test_get_enum(void)
 	test_get_value(conf, test_get_enum_cb);
 }
 
-/* ==== get_mask ==== */
-
-static void test_get_mask_cb(GKeyFile *k)
-{
-	int v = 0;
-
-	g_assert(!ril_config_get_mask(k, "g1", "k", NULL, "x",1, "y",2, NULL));
-	g_assert(!ril_config_get_mask(k, "g1", "k", &v, "x",1, "y",2, NULL));
-	g_assert_cmpint(v, ==, 0);
-
-	g_assert(ril_config_get_mask(k, "g", "k", NULL, "x",1, "y",2, NULL));
-	g_assert(ril_config_get_mask(k, "g", "k", &v, "x",1, "y",2, NULL));
-	g_assert_cmpint(v, ==, 1);
-
-	g_assert(ril_config_get_mask(k, "g", "k1", NULL, "x",1, "y",2, NULL));
-	g_assert(ril_config_get_mask(k, "g", "k1", &v, "x",1, "y",2, NULL));
-	g_assert_cmpint(v, ==, 3);
-
-	g_assert(!ril_config_get_mask(k, "g", "k2", NULL, "x",1, "y",2, NULL));
-	g_assert(!ril_config_get_mask(k, "g", "k2", &v, "x",1, "y",2, NULL));
-	g_assert_cmpint(v, ==, 0);
-}
-
-static void test_get_mask(void)
-{
-	static const char conf [] = "[g]\n"
-		"k = x# comment\n"
-		"k1 = x+y\n"
-		"k2 = x+z+y\n";
-
-	test_get_value(conf, test_get_mask_cb);
-}
-
 /* ==== get_ints ==== */
 
 static void test_get_ints_cb(GKeyFile *k)
@@ -484,7 +451,6 @@ int main(int argc, char *argv[])
 	g_test_add_func(TEST_("get_boolean3"), test_get_boolean3);
 	g_test_add_func(TEST_("get_flag"), test_get_flag);
 	g_test_add_func(TEST_("get_enum"), test_get_enum);
-	g_test_add_func(TEST_("get_mask"), test_get_mask);
 	g_test_add_func(TEST_("get_ints"), test_get_ints);
 	g_test_add_func(TEST_("ints_to_string"), test_ints_to_string);
 

rpm/ofono.spec

@@ -2,11 +2,12 @@ Name:       ofono
 Summary:    Open Source Telephony
 Version:    1.23
 Release:    1
+Group:      Communications/Connectivity Adaptation
 License:    GPLv2
 URL:        https://git.sailfishos.org/mer-core/ofono
 Source:     %{name}-%{version}.tar.bz2
 
-%define libgrilio_version 1.0.38
+%define libgrilio_version 1.0.35
 %define libglibutil_version 1.0.30
 %define libmce_version 1.0.6
 
@@ -37,13 +38,13 @@ BuildRequires:  pkgconfig(mobile-broadband-provider-info)
 BuildRequires:  libtool
 BuildRequires:  automake
 BuildRequires:  autoconf
-BuildRequires:  systemd
 
 %description
 Telephony stack
 
 %package devel
 Summary:    Headers for oFono
+Group:      Development/Libraries
 Requires:   %{name} = %{version}-%{release}
 
 %description devel
@@ -51,6 +52,7 @@ Development headers and libraries for oFono
 
 %package tests
 Summary:    Test Scripts for oFono
+Group:      Development/Libraries
 Requires:   %{name} = %{version}-%{release}
 Requires:   dbus-python3
 Requires:   python3-gobject
@@ -62,6 +64,7 @@ Scripts for testing oFono and its functionality
 
 %package configs-mer
 Summary:    Package to provide default configs for ofono
+Group:      Development/Tools
 Provides:   ofono-configs
 
 %description configs-mer
@@ -69,6 +72,7 @@ This package provides default configs for ofono
 
 %package doc
 Summary:   Documentation for %{name}
+Group:     Documentation
 Requires:  %{name} = %{version}-%{release}
 
 %description doc
@@ -94,9 +98,9 @@ autoreconf --force --install
     --disable-add-remove-context \
     --disable-isimodem \
     --disable-qmimodem \
-    --with-systemdunitdir=%{_unitdir}
+    --with-systemdunitdir="/%{_lib}/systemd/system"
 
-%make_build
+make %{_smp_mflags}
 
 %check
 # run unit tests
@@ -107,9 +111,9 @@ rm -rf %{buildroot}
 %make_install
 
 mkdir -p %{buildroot}/%{_sysconfdir}/ofono/push_forwarder.d
-mkdir -p %{buildroot}%{_unitdir}/network.target.wants
+mkdir -p %{buildroot}/%{_lib}/systemd/system/network.target.wants
 mkdir -p %{buildroot}/var/lib/ofono
-ln -s ../ofono.service %{buildroot}%{_unitdir}/network.target.wants/ofono.service
+ln -s ../ofono.service %{buildroot}/%{_lib}/systemd/system/network.target.wants/ofono.service
 
 mkdir -p %{buildroot}%{_docdir}/%{name}-%{version}
 install -m0644 -t %{buildroot}%{_docdir}/%{name}-%{version} \
@@ -135,8 +139,8 @@ systemctl daemon-reload ||:
 %license COPYING
 %config %{_sysconfdir}/dbus-1/system.d/*.conf
 %{_sbindir}/*
-%{_unitdir}/network.target.wants/ofono.service
-%{_unitdir}/ofono.service
+/%{_lib}/systemd/system/network.target.wants/ofono.service
+/%{_lib}/systemd/system/ofono.service
 %dir %{_sysconfdir}/ofono/
 %dir %{_sysconfdir}/ofono/push_forwarder.d
 # This file is part of phonesim and not needed with ofono.