[ril] Don't auto-select the data sim on a multisim phone. JB#38719

This kind of behavior is reserved for single sim phone (for now).

.gitignore

@@ -0,0 +1,61 @@
+*.o
+*.lo
+*.la
+.deps
+.libs
+.dirstamp
+Makefile
+Makefile.in
+aclocal.m4
+config.guess
+config.h
+config.h.in
+config.log
+config.status
+config.sub
+configure
+depcomp
+compile
+install-sh
+libtool
+ltmain.sh
+missing
+stamp-h1
+autom4te.cache
+test-driver
+test-suite.log
+
+ofono.pc
+include/ofono
+include/version.h
+src/builtin.h
+src/ofonod
+src/ofono.service
+dundee/dundee
+dundee/dundee.service
+
+unit/test-common
+unit/test-util
+unit/test-idmap
+unit/test-sms
+unit/test-sms-root
+unit/test-simutil
+unit/test-mux
+unit/test-caif
+unit/test-stkutil
+unit/test-cdmasms
+unit/test-*.log
+unit/test-*.trs
+
+tools/huawei-audio
+tools/auto-enable
+tools/get-location
+tools/lookup-apn
+tools/lookup-provider-name
+tools/tty-redirector
+tools/qmi
+tools/stktest
+
+gatchat/gsmdial
+gatchat/test-server
+gatchat/test-qcdm

.mailmap

@@ -0,0 +1,7 @@
+Luiz Augusto von Dentz <luiz.dentz-von@nokia.com>	<luiz.dentz-von@nokia.com>
+Zhenhua Zhang <zhenhua.zhang@intel.com>			<zhenhua.zhang@intel.com>
+Pekka Pessi <pekka.pessi@nokia.com>			<Pekka.Pessi@nokia.com>
+Pekka Pessi <pekka.pessi@nokia.com>			<ppessi@hamsa.research.nokia.com>
+Lasse Kunnasluoto <lasse.kunnasluoto@tieto.com>		<Lasse.Kunnasluoto@tieto.com>
+Syam Sidhardhan <s.syam@samsung.com>			<syamsidhardh@gmail.com>
+Michael Dietrich <mdt@emdete.de>			<mdt@emdete.de>

ofono/.gitignore

@@ -32,8 +32,6 @@ src/ofono.service
 dundee/dundee
 dundee/dundee.service
 
-test-driver
-test-suite.log
 unit/test-common
 unit/test-util
 unit/test-idmap
@@ -44,44 +42,13 @@ unit/test-mux
 unit/test-caif
 unit/test-stkutil
 unit/test-cdmasms
-unit/test-dbus-queue
-unit/test-gprs-filter
-unit/test-ril_config
-unit/test-ril_util
-unit/test-ril-transport
 unit/test-rilmodem-cb
 unit/test-rilmodem-cs
 unit/test-rilmodem-gprs
 unit/test-rilmodem-sms
-unit/test-sailfish_cell_info
-unit/test-sailfish_cell_info_dbus
-unit/test-sailfish_manager
-unit/test-sailfish_sim_info
-unit/test-sailfish_sim_info_dbus
-unit/test-sailfish_watch
-unit/test-sms-filter
-unit/test-voicecall-filter
 unit/test-*.log
 unit/test-*.trs
 
-unit/test-grilreply
-unit/test-grilrequest
-unit/test-grilunsol
-unit/test-provision
-unit/html
-
-plugins/sailfish_manager/*.gcda
-plugins/sailfish_manager/*.gcno
-drivers/*/*.gcda
-drivers/*/*.gcno
-drivers/*/*.gcov
-plugins/*/*.gcda
-plugins/*/*.gcno
-plugins/*/*.gcov
-*/*.gcda
-*/*.gcno
-*/*.gcov
-
 tools/huawei-audio
 tools/auto-enable
 tools/get-location

ofono/AUTHORS

@@ -116,13 +116,3 @@ Martin Chaplet <m.chaplet@kerlink.fr>
 Suman Mallela <suman.m@intel.com>
 Rajagopal Aravindan <rajagopalx.aravindan@intel.com>
 Antoine Aubert <a.aubert@overkiz.com>
-Djalal Harouni <djalal@endocode.com>
-Christophe Ronco <c.ronco@kerlink.fr>
-Vincent Cesson <vincent.cesson@smile.fr>
-Piotr Haber <gluedig@gmail.com>
-André Draszik <git@andred.net>
-Lukasz Nowak <lnowak@tycoint.com>
-Jonas Bonn <jonas@southpole.se>
-Matthijs Kooijman <matthijs@stdin.nl>
-Clayton Craft <clayton@craftyguy.net>
-Joey Hewitt <joey@joeyhewitt.com>

ofono/ChangeLog

@@ -1,36 +1,3 @@
-ver 1.21:
-	Fix issue with USSD notification received handling.
-	Fix issue with crashing SIM filesystem notifications.
-	Fix issue with LTE bearer reporting and Huawei modems.
-	Fix issue with invalid memory access and QMI.
-	Add support for QMI SIM writing functionality.
-	Add support for RAT selection for QMI modems.
-	Add support for network monitor agent interface.
-	Add support for Cinterion Hardware Monitor interface.
-	Add support for LTE atom driver for Huawei modems.
-	Add support for LTE atom driver for AT modems.
-	Add support for Intel xmm7xxx series modems.
-
-ver 1.20:
-	Fix issue with context removal before activation.
-	Fix issue with update during GPRS context activation.
-	Fix issue with receiving UTF-16 encoded messages.
-	Fix issue with invalid access in CBS decoding.
-	Fix issue with signal strength on QMI modems.
-	Fix issue with PIN handling with QMI modems.
-	Fix issue with QMI notification message handling.
-	Fix issue with facility lock query on SIM removal.
-	Fix issue with parsing +CLCC and +CCWA fields.
-	Add support for obtaining IMSI via EF reading.
-	Add support for additional netmon info types.
-	Add support for provisioning via configuration files.
-	Add support for Gemalto P-family series of modems.
-	Add support for Telit HE910 and UE910 variants.
-	Add support for Intel SoFIA SIM Toolkit interfaces.
-	Add support for Intel SoFIA LTE features.
-	Add support for U-Blox TOBY-L2 LTE feature.
-	Add support for dedicated LTE atom.
-
 ver 1.19:
 	Fix issue with DHCP parsing and Huawei modems.
 	Fix issue with detecting Huawei E3372 modem.

ofono/Makefile.am

@@ -23,20 +23,10 @@ pkginclude_HEADERS = include/log.h include/plugin.h include/history.h \
 			include/cdma-provision.h include/handsfree.h \
 			include/sim-mnclength.h \
 			include/handsfree-audio.h include/siri.h \
-			include/sms-filter.h include/gprs-filter.h \
-			include/voicecall-filter.h \
-			include/ril-constants.h include/ril-transport.h \
-			include/netmon.h include/lte.h \
-			include/storage.h \
-			gdbus/gdbus.h
+			include/netmon.h
 
 nodist_pkginclude_HEADERS = include/version.h
 
-if SAILFISH_MANAGER
-nodist_pkginclude_HEADERS += include/sailfish_cell_info.h \
-			include/sailfish_manager.h include/sailfish_watch.h
-endif
-
 local_headers = $(foreach file,$(pkginclude_HEADERS) \
 				$(nodist_pkginclude_HEADERS), \
 					include/ofono/$(notdir $(file)))
@@ -117,6 +107,8 @@ gril_sources = gril/gril.h gril/gril.c \
 btio_sources = btio/btio.h btio/btio.c
 
 if UDEV
+builtin_modules += udev
+builtin_sources += plugins/udev.c
 builtin_cflags += @UDEV_CFLAGS@
 builtin_libadd += @UDEV_LIBS@
 
@@ -124,19 +116,8 @@ builtin_modules += udevng
 builtin_sources += plugins/udevng.c
 endif
 
-if SAILFISH_MANAGER
-builtin_modules += sailfish_manager
-builtin_sources += plugins/sailfish_manager/sailfish_cell_info.c \
-			plugins/sailfish_manager/sailfish_cell_info_dbus.c \
-			plugins/sailfish_manager/sailfish_manager.c \
-			plugins/sailfish_manager/sailfish_manager_dbus.c \
-			plugins/sailfish_manager/sailfish_sim_info.c \
-			plugins/sailfish_manager/sailfish_sim_info_dbus.c \
-			plugins/sailfish_manager/sailfish_watch.c
-endif
-
 if RILMODEM
-if SAILFISH_RILMODEM
+if JOLLA_RILMODEM
 
 builtin_modules += ril
 builtin_sources +=	drivers/ril/ril_call_barring.c \
@@ -144,6 +125,7 @@ builtin_sources +=	drivers/ril/ril_call_barring.c \
 			drivers/ril/ril_call_settings.c \
 			drivers/ril/ril_call_volume.c \
 			drivers/ril/ril_cell_info.c \
+			drivers/ril/ril_cell_info_dbus.c \
 			drivers/ril/ril_config.c \
 			drivers/ril/ril_cbs.c \
 			drivers/ril/ril_data.c \
@@ -152,28 +134,27 @@ builtin_sources +=	drivers/ril/ril_call_barring.c \
 			drivers/ril/ril_gprs.c \
 			drivers/ril/ril_gprs_context.c \
 			drivers/ril/ril_modem.c \
+			drivers/ril/ril_mtu.c \
 			drivers/ril/ril_netmon.c \
 			drivers/ril/ril_netreg.c \
 			drivers/ril/ril_network.c \
 			drivers/ril/ril_oem_raw.c \
 			drivers/ril/ril_phonebook.c \
 			drivers/ril/ril_plugin.c \
+			drivers/ril/ril_plugin_dbus.c \
 			drivers/ril/ril_radio.c \
-			drivers/ril/ril_radio_caps.c \
 			drivers/ril/ril_radio_settings.c \
 			drivers/ril/ril_sim.c \
 			drivers/ril/ril_sim_card.c \
+			drivers/ril/ril_sim_info.c \
+			drivers/ril/ril_sim_info_dbus.c \
 			drivers/ril/ril_sim_settings.c \
 			drivers/ril/ril_sms.c \
 			drivers/ril/ril_stk.c \
 			drivers/ril/ril_ussd.c \
 			drivers/ril/ril_util.c \
-			drivers/ril/ril_vendor.c \
 			drivers/ril/ril_voicecall.c
 
-# Vendor specific extensions
-builtin_sources +=	drivers/ril/ril_vendor_mtk.c
-
 if DATAFILES
 dist_conf_DATA += drivers/ril/ril_subscription.conf
 endif
@@ -191,8 +172,8 @@ builtin_sources += plugins/ril.c plugins/ril.h
 builtin_modules += infineon
 builtin_sources += plugins/infineon.c
 
-builtin_modules += ril_intel
-builtin_sources += plugins/ril_intel.c
+builtin_modules += ril_sofia3gr
+builtin_sources += plugins/ril_sofia3gr.c
 
 builtin_modules += rilmodem
 builtin_sources += drivers/rilmodem/rilmodem.h \
@@ -217,8 +198,7 @@ builtin_sources += drivers/rilmodem/rilmodem.h \
 			drivers/rilmodem/netmon.c \
 			drivers/rilmodem/stk.c \
 			drivers/rilmodem/cbs.c \
-			drivers/infineonmodem/infineon_constants.h \
-			drivers/rilmodem/lte.c
+			drivers/infineonmodem/infineon_constants.h
 endif
 endif
 
@@ -277,13 +257,11 @@ qmi_sources = drivers/qmimodem/qmi.h drivers/qmimodem/qmi.c \
 					drivers/qmimodem/ctl.h \
 					drivers/qmimodem/dms.h \
 					drivers/qmimodem/nas.h \
-					drivers/qmimodem/nas.c \
 					drivers/qmimodem/uim.h \
 					drivers/qmimodem/wms.h \
 					drivers/qmimodem/wds.h \
 					drivers/qmimodem/pds.h \
-					drivers/qmimodem/common.h \
-					drivers/qmimodem/wda.h
+					drivers/qmimodem/common.h
 
 builtin_modules += qmimodem
 builtin_sources += $(qmi_sources) \
@@ -300,8 +278,7 @@ builtin_sources += $(qmi_sources) \
 			drivers/qmimodem/gprs.c \
 			drivers/qmimodem/gprs-context.c \
 			drivers/qmimodem/radio-settings.c \
-			drivers/qmimodem/location-reporting.c \
-			drivers/qmimodem/netmon.c
+			drivers/qmimodem/location-reporting.c
 
 builtin_modules += gobi
 builtin_sources += plugins/gobi.c
@@ -332,8 +309,7 @@ builtin_sources += 	drivers/atmodem/atmodem.h \
 			drivers/atmodem/gprs.c \
 			drivers/atmodem/gprs-context.c \
 			drivers/atmodem/sim-auth.c \
-			drivers/atmodem/gnss.c \
-			drivers/atmodem/lte.c
+			drivers/atmodem/gnss.c
 
 builtin_modules += nwmodem
 builtin_sources += drivers/atmodem/atutil.h \
@@ -390,8 +366,7 @@ builtin_modules += telitmodem
 builtin_sources += drivers/atmodem/atutil.h \
 			drivers/telitmodem/telitmodem.h \
 			drivers/telitmodem/telitmodem.c \
-			drivers/telitmodem/location-reporting.c \
-			drivers/telitmodem/gprs-context-ncm.c
+			drivers/telitmodem/location-reporting.c
 
 builtin_modules += hsomodem
 builtin_sources += drivers/atmodem/atutil.h \
@@ -453,23 +428,9 @@ builtin_modules += ubloxmodem
 builtin_sources += drivers/atmodem/atutil.h \
 			drivers/ubloxmodem/ubloxmodem.h \
 			drivers/ubloxmodem/ubloxmodem.c \
-			drivers/ubloxmodem/gprs-context.c \
-			drivers/ubloxmodem/netmon.c \
-			drivers/ubloxmodem/lte.c
+			drivers/ubloxmodem/gprs-context.c
 
 
-builtin_modules += gemaltomodem
-builtin_sources += drivers/atmodem/atutil.h \
-			drivers/gemaltomodem/gemaltomodem.h \
-			drivers/gemaltomodem/gemaltomodem.c \
-			drivers/gemaltomodem/location-reporting.c
-
-builtin_modules += xmm7modem
-builtin_sources += drivers/atmodem/atutil.h \
-			drivers/xmm7modem/xmm7modem.h \
-			drivers/xmm7modem/xmm7modem.c \
-			drivers/xmm7modem/radio-settings.c
-
 if PHONESIM
 builtin_modules += phonesim
 builtin_sources += plugins/phonesim.c
@@ -534,9 +495,6 @@ builtin_sources += plugins/caif.c
 builtin_modules += cinterion
 builtin_sources += plugins/cinterion.c
 
-builtin_modules += gemalto
-builtin_sources += plugins/gemalto.c
-
 builtin_modules += nokia
 builtin_sources += plugins/nokia.c
 
@@ -564,30 +522,24 @@ builtin_sources += plugins/samsung.c
 builtin_modules += sim900
 builtin_sources += plugins/sim900.c
 
-builtin_modules += connman
-builtin_sources += plugins/connman.c
-
-builtin_modules += telit
-builtin_sources += plugins/telit.c
-
 builtin_modules += quectel
 builtin_sources += plugins/quectel.c
 
 builtin_modules += ublox
 builtin_sources += plugins/ublox.c
 
-builtin_modules += xmm7xxx
-builtin_sources += plugins/xmm7xxx.c
+builtin_modules += he910
+builtin_sources += plugins/he910.c
 endif
 
 builtin_modules += connman
 builtin_sources += plugins/connman.c
 
-builtin_modules += mnclength
-builtin_sources += plugins/mnclength.c
-
 if BLUETOOTH
 if BLUEZ4
+builtin_modules += telit
+builtin_sources += plugins/telit.c plugins/bluez4.h
+
 builtin_modules += sap
 builtin_sources += plugins/sap.c plugins/bluez4.h
 
@@ -624,9 +576,9 @@ builtin_sources += plugins/bluez5.c plugins/bluez5.h
 builtin_modules += hfp_ag_bluez5
 builtin_sources += plugins/hfp_ag_bluez5.c plugins/bluez5.h
 
-if SAILFISH_BT
+if SAILFISHFOS
 builtin_modules += sfos_bt
-builtin_sources += plugins/sailfish_bt.c
+builtin_sources += plugins/sfos_bt.c
 endif
 endif
 
@@ -641,32 +593,17 @@ builtin_modules += nettime
 builtin_sources += plugins/nettime.c
 endif
 
-if SAILFISH_DEBUGLOG
-builtin_modules += debuglog
-builtin_sources += plugins/sailfish_debuglog.c
-endif
-
-if SAILFISH_PROVISION
-builtin_sources += plugins/sailfish_provision.c
-PROVISION = 1
-else
-if PROVISION
-builtin_sources += plugins/provision.c
-endif
-endif
-
 if PROVISION
 builtin_sources += plugins/mbpi.h plugins/mbpi.c
 
 builtin_modules += provision
-builtin_sources += plugins/provision.h
+builtin_sources += plugins/provision.h plugins/provision.c
 
 builtin_modules += cdma_provision
 builtin_sources += plugins/cdma-provision.c
 
-builtin_modules += file_provision
-builtin_sources += plugins/file-provision.c
-
+builtin_modules += mnclength
+builtin_sources += plugins/mnclength.c
 endif
 
 if MAINTAINER_MODE
@@ -698,9 +635,16 @@ builtin_sources += plugins/smart-messaging.c
 builtin_modules += push_notification
 builtin_sources += plugins/push-notification.c
 
-if SAILFISH_PUSHFORWARDER
-builtin_modules += pushforwarder
-builtin_sources += plugins/sailfish_pushforwarder.c
+if PUSHFORWARDER
+builtin_modules += push_forwarder
+builtin_sources += plugins/push-forwarder.c
+builtin_cflags += @WSPCODEC_CFLAGS@
+builtin_libadd += @WSPCODEC_LIBS@
+endif
+
+if DEBUGLOG
+builtin_modules += debuglog
+builtin_sources += plugins/debuglog.c
 endif
 
 builtin_modules += sms_history
@@ -712,7 +656,6 @@ builtin_sources += plugins/allowed-apns.c
 sbin_PROGRAMS = src/ofonod
 
 src_ofonod_SOURCES = $(builtin_sources) $(gatchat_sources) src/ofono.ver \
-			src/mtu-watch.c \
 			src/main.c src/ofono.h src/log.c src/plugin.c \
 			src/modem.c src/common.h src/common.c \
 			src/manager.c src/dbus.c src/util.h src/util.c \
@@ -738,11 +681,8 @@ src_ofonod_SOURCES = $(builtin_sources) $(gatchat_sources) src/ofono.ver \
 			src/cdma-provision.c src/handsfree.c \
 			src/handsfree-audio.c src/bluetooth.h \
 			src/sim-mnclength.c src/voicecallagent.c \
-			src/sms-filter.c src/gprs-filter.c src/dbus-queue.c \
-			src/voicecall-filter.c src/ril-transport.c \
 			src/hfp.h src/siri.c \
-			src/netmon.c src/lte.c \
-			src/netmonagent.c src/netmonagent.h
+			src/netmon.c
 
 src_ofonod_LDADD = gdbus/libgdbus-internal.la $(builtin_libadd) \
 			@GLIB_LIBS@ @DBUS_LIBS@ -ldl
@@ -752,8 +692,7 @@ src_ofonod_LDFLAGS = -Wl,--export-dynamic \
 
 BUILT_SOURCES = $(local_headers) src/builtin.h
 
-CLEANFILES = $(BUILT_SOURCES) $(rules_DATA) \
-	$(shell find . -name "*.gcda") $(shell find . -name "*.gcno")
+CLEANFILES = $(BUILT_SOURCES) $(rules_DATA)
 
 plugindir = $(pkglibdir)/plugins
 
@@ -791,9 +730,7 @@ doc_files = doc/overview.txt doc/ofono-paper.txt doc/release-faq.txt \
 			doc/certification.txt doc/siri-api.txt \
 			doc/telit-modem.txt \
 			doc/networkmonitor-api.txt \
-			doc/allowed-apns-api.txt \
-			doc/lte-api.txt \
-			doc/cinterion-hardware-monitor-api.txt
+			doc/allowed-apns-api.txt
 
 
 test_scripts = test/backtrace \
@@ -900,10 +837,7 @@ test_scripts = test/backtrace \
 		test/get-serving-cell-info \
 		test/list-allowed-access-points \
 		test/enable-throttling \
-		test/disable-throttling \
-		test/set-lte-property \
-		test/test-serving-cell-info
-
+		test/disable-throttling
 
 if TEST
 testdir = $(pkglibdir)/test
@@ -915,103 +849,17 @@ EXTRA_DIST = src/genbuiltin plugins/ofono.rules plugins/ofono-speedup.rules \
 
 dist_man_MANS = doc/ofonod.8
 
-if TEST_COVERAGE
-COVERAGE_OPT = --coverage
-endif
 
 unit_objects =
 
 unit_tests = unit/test-common unit/test-util unit/test-idmap \
 				unit/test-simutil unit/test-stkutil \
-				unit/test-sms unit/test-cdmasms
-
-if SAILFISH_MANAGER
-
-unit_test_sailfish_cell_info_SOURCES = unit/test-sailfish_cell_info.c \
-			plugins/sailfish_manager/sailfish_cell_info.c
-unit_test_sailfish_cell_info_CFLAGS = $(AM_CFLAGS) $(COVERAGE_OPT) \
-			-Iplugins/sailfish_manager
-unit_test_sailfish_cell_info_LDADD = @GLIB_LIBS@ -ldl
-unit_objects += $(unit_test_sailfish_cell_info_OBJECTS)
-unit_tests += unit/test-sailfish_cell_info
-
-unit_test_sailfish_cell_info_dbus_SOURCES = unit/test-dbus.c \
-			unit/test-sailfish_cell_info_dbus.c \
-			unit/fake_sailfish_cell_info.c \
-			plugins/sailfish_manager/sailfish_cell_info.c \
-			plugins/sailfish_manager/sailfish_cell_info_dbus.c \
-			gdbus/object.c \
-			src/dbus.c src/log.c
-unit_test_sailfish_cell_info_dbus_CFLAGS = $(AM_CFLAGS) $(COVERAGE_OPT) \
-			@DBUS_GLIB_CFLAGS@ -Iplugins/sailfish_manager
-unit_test_sailfish_cell_info_dbus_LDADD = @DBUS_GLIB_LIBS@ @GLIB_LIBS@ -ldl
-unit_objects += $(unit_test_sailfish_cell_info_dbus_OBJECTS)
-unit_tests += unit/test-sailfish_cell_info_dbus
-
-unit_test_sailfish_sim_info_SOURCES = unit/test-sailfish_sim_info.c \
-			unit/fake_sailfish_watch.c \
-			plugins/sailfish_manager/sailfish_sim_info.c \
-			src/storage.c src/watch.c src/log.c
-unit_test_sailfish_sim_info_CFLAGS = $(COVERAGE_OPT) $(AM_CFLAGS) \
-			-DSTORAGEDIR='"/tmp/ofono"' -Iplugins/sailfish_manager
-unit_test_sailfish_sim_info_LDADD = @GLIB_LIBS@ -ldl
-unit_objects += $(unit_test_sailfish_sim_info_OBJECTS)
-unit_tests += unit/test-sailfish_sim_info
-
-unit_test_sailfish_sim_info_dbus_SOURCES = unit/test-sailfish_sim_info_dbus.c \
-			unit/test-dbus.c unit/fake_sailfish_watch.c \
-			plugins/sailfish_manager/sailfish_sim_info.c \
-			plugins/sailfish_manager/sailfish_sim_info_dbus.c \
-			gdbus/object.c \
-			src/dbus.c src/storage.c src/watch.c src/log.c
-unit_test_sailfish_sim_info_dbus_CFLAGS = $(COVERAGE_OPT) $(AM_CFLAGS) \
-			@DBUS_GLIB_CFLAGS@ -DSTORAGEDIR='"/tmp/ofono"' \
-			-Iplugins/sailfish_manager
-unit_test_sailfish_sim_info_dbus_LDADD = @DBUS_GLIB_LIBS@ @GLIB_LIBS@ -ldl
-unit_objects += $(unit_test_sailfish_sim_info_dbus_OBJECTS)
-unit_tests += unit/test-sailfish_sim_info_dbus
-
-unit_test_sailfish_manager_SOURCES = unit/test-sailfish_manager.c \
-			unit/fake_sailfish_watch.c \
-			plugins/sailfish_manager/sailfish_manager.c \
-			plugins/sailfish_manager/sailfish_cell_info.c \
-			plugins/sailfish_manager/sailfish_sim_info.c \
-			src/storage.c src/log.c
-unit_test_sailfish_manager_CFLAGS = $(AM_CFLAGS) $(COVERAGE_OPT) \
-			-DSTORAGEDIR='"/tmp/ofono"' -Iplugins/sailfish_manager
-unit_test_sailfish_manager_LDADD = @GLIB_LIBS@ -ldl
-unit_objects += $(unit_test_sailfish_manager_OBJECTS)
-unit_tests += unit/test-sailfish_manager
-
-unit_test_sailfish_watch_SOURCES = unit/test-sailfish_watch.c \
-			plugins/sailfish_manager/sailfish_watch.c \
-			src/log.c src/watch.c
-unit_test_sailfish_watch_CFLAGS = $(AM_CFLAGS) $(COVERAGE_OPT) \
-			-DSTORAGEDIR='"/tmp/ofono"' -Iplugins/sailfish_manager
-unit_test_sailfish_watch_LDADD = @GLIB_LIBS@ -ldl
-unit_objects += $(unit_test_sailfish_watch_OBJECTS)
-unit_tests += unit/test-sailfish_watch
-
-endif
+				unit/test-sms unit/test-cdmasms \
+				unit/test-provision
 
 if RILMODEM
-if SAILFISH_RILMODEM
+if JOLLA_RILMODEM
 
-unit_test_ril_config_SOURCES = unit/test-ril_config.c drivers/ril/ril_util.c \
-				drivers/ril/ril_config.c src/log.c
-unit_test_ril_config_CFLAGS = $(COVERAGE_OPT) $(AM_CFLAGS)
-unit_test_ril_config_LDADD = @GLIB_LIBS@ -ldl
-unit_objects += $(unit_test_ril_config_OBJECTS)
-unit_tests += unit/test-ril_config
-
-unit_test_ril_util_SOURCES = unit/test-ril_util.c drivers/ril/ril_util.c \
-				src/log.c
-unit_test_ril_util_CFLAGS = $(COVERAGE_OPT) $(AM_CFLAGS)
-unit_test_ril_util_LDADD = @GLIB_LIBS@ -ldl
-unit_objects += $(unit_test_ril_util_OBJECTS)
-unit_tests += unit/test-ril_util
-
-else
 unit_tests += unit/test-rilmodem-cs \
 				unit/test-rilmodem-cs \
 				unit/test-rilmodem-sms \
@@ -1025,23 +873,19 @@ noinst_PROGRAMS = $(unit_tests) \
 			unit/test-sms-root unit/test-mux unit/test-caif
 
 unit_test_common_SOURCES = unit/test-common.c src/common.c src/util.c
-unit_test_common_CFLAGS = $(COVERAGE_OPT) $(AM_CFLAGS)
 unit_test_common_LDADD = @GLIB_LIBS@
 unit_objects += $(unit_test_common_OBJECTS)
 
 unit_test_util_SOURCES = unit/test-util.c src/util.c
-unit_test_util_CFLAGS = $(COVERAGE_OPT) $(AM_CFLAGS)
 unit_test_util_LDADD = @GLIB_LIBS@
 unit_objects += $(unit_test_utils_OBJECTS)
 
 unit_test_idmap_SOURCES = unit/test-idmap.c src/idmap.c
-unit_test_idmap_CFLAGS = $(COVERAGE_OPT) $(AM_CFLAGS)
 unit_test_idmap_LDADD = @GLIB_LIBS@
 unit_objects += $(unit_test_idmap_OBJECTS)
 
 unit_test_simutil_SOURCES = unit/test-simutil.c src/util.c \
                                 src/simutil.c src/smsutil.c src/storage.c
-unit_test_simutil_CFLAGS = $(COVERAGE_OPT) $(AM_CFLAGS)
 unit_test_simutil_LDADD = @GLIB_LIBS@
 unit_objects += $(unit_test_simutil_OBJECTS)
 
@@ -1049,23 +893,19 @@ unit_test_stkutil_SOURCES = unit/test-stkutil.c unit/stk-test-data.h \
 				src/util.c \
                                 src/storage.c src/smsutil.c \
                                 src/simutil.c src/stkutil.c
-unit_test_stkutil_CFLAGS = $(COVERAGE_OPT) $(AM_CFLAGS)
 unit_test_stkutil_LDADD = @GLIB_LIBS@
 unit_objects += $(unit_test_stkutil_OBJECTS)
 
 unit_test_sms_SOURCES = unit/test-sms.c src/util.c src/smsutil.c src/storage.c
-unit_test_sms_CFLAGS = $(COVERAGE_OPT) $(AM_CFLAGS)
 unit_test_sms_LDADD = @GLIB_LIBS@
 unit_objects += $(unit_test_sms_OBJECTS)
 
 unit_test_cdmasms_SOURCES = unit/test-cdmasms.c src/cdma-smsutil.c
-unit_test_cdmasms_CFLAGS = $(COVERAGE_OPT) $(AM_CFLAGS)
 unit_test_cdmasms_LDADD = @GLIB_LIBS@
 unit_objects += $(unit_test_cdmasms_OBJECTS)
 
 unit_test_sms_root_SOURCES = unit/test-sms-root.c \
 					src/util.c src/smsutil.c src/storage.c
-unit_test_sms_root_CFLAGS = -DSTORAGEDIR='"/tmp/ofono"' $(COVERAGE_OPT) $(AM_CFLAGS)
 unit_test_sms_root_LDADD = @GLIB_LIBS@
 unit_objects += $(unit_test_sms_root_OBJECTS)
 
@@ -1076,55 +916,15 @@ unit_objects += $(unit_test_mux_OBJECTS)
 unit_test_caif_SOURCES = unit/test-caif.c $(gatchat_sources) \
 					drivers/stemodem/caif_socket.h \
 					drivers/stemodem/if_caif.h
-unit_test_caif_CFLAGS = $(COVERAGE_OPT) $(AM_CFLAGS)
 unit_test_caif_LDADD = @GLIB_LIBS@
 unit_objects += $(unit_test_caif_OBJECTS)
 
-unit_test_dbus_queue_SOURCES = unit/test-dbus-queue.c unit/test-dbus.c \
-				src/dbus-queue.c gdbus/object.c \
-				src/dbus.c src/log.c
-unit_test_dbus_queue_CFLAGS =  @DBUS_GLIB_CFLAGS@ $(COVERAGE_OPT) $(AM_CFLAGS)
-unit_test_dbus_queue_LDADD = @DBUS_GLIB_LIBS@ @GLIB_LIBS@ -ldl
-unit_objects += $(unit_test_dbus_queue_OBJECTS)
-unit_tests += unit/test-dbus-queue
-
 unit_test_provision_SOURCES = unit/test-provision.c \
-				plugins/provision.h plugins/mbpi.c \
-				plugins/sailfish_provision.c \
-				src/gprs-provision.c src/log.c
-unit_test_provision_CFLAGS = $(COVERAGE_OPT) $(AM_CFLAGS)
+				plugins/provision.h plugins/provision.c \
+				plugins/mbpi.c src/gprs-provision.c \
+				src/log.c
 unit_test_provision_LDADD = @GLIB_LIBS@ -ldl
 unit_objects += $(unit_test_provision_OBJECTS)
-unit_tests += unit/test-provision
-
-unit_test_ril_transport_SOURCES = unit/test-ril-transport.c \
-				src/ril-transport.c src/log.c
-unit_test_ril_transport_CFLAGS = $(COVERAGE_OPT) $(AM_CFLAGS)
-unit_test_ril_transport_LDADD = @GLIB_LIBS@ -ldl
-unit_objects += $(unit_test_ril_transport_OBJECTS)
-unit_tests += unit/test-ril-transport
-
-unit_test_sms_filter_SOURCES = unit/test-sms-filter.c \
-				src/sms-filter.c src/log.c
-unit_test_sms_filter_CFLAGS = $(COVERAGE_OPT) $(AM_CFLAGS)
-unit_test_sms_filter_LDADD = @GLIB_LIBS@ -ldl
-unit_objects += $(unit_test_sms_filter_OBJECTS)
-unit_tests += unit/test-sms-filter
-
-unit_test_gprs_filter_SOURCES = unit/test-gprs-filter.c \
-				src/gprs-filter.c src/log.c
-unit_test_gprs_filter_CFLAGS = $(COVERAGE_OPT) $(AM_CFLAGS)
-unit_test_gprs_filter_LDADD = @GLIB_LIBS@ -ldl
-unit_objects += $(unit_test_gprs_filter_OBJECTS)
-unit_tests += unit/test-gprs-filter
-
-unit_test_voicecall_filter_SOURCES = unit/test-voicecall-filter.c \
-				src/voicecall-filter.c src/log.c \
-				src/common.c src/util.c
-unit_test_voicecall_filter_CFLAGS = $(COVERAGE_OPT) $(AM_CFLAGS)
-unit_test_voicecall_filter_LDADD = @GLIB_LIBS@ -ldl
-unit_objects += $(unit_test_voicecall_filter_OBJECTS)
-unit_tests += unit/test-voicecall-filter
 
 test_rilmodem_sources = $(gril_sources) src/log.c src/common.c src/util.c \
 				gatchat/ringbuffer.h gatchat/ringbuffer.c \
@@ -1189,6 +989,13 @@ tools_lookup_provider_name_LDADD = @GLIB_LIBS@
 tools_tty_redirector_SOURCES = tools/tty-redirector.c
 tools_tty_redirector_LDADD = @GLIB_LIBS@
 
+if QMIMODEM
+noinst_PROGRAMS += tools/qmi
+
+tools_qmi_SOURCES = $(qmi_sources) tools/qmi.c
+tools_qmi_LDADD = @GLIB_LIBS@
+endif
+
 if MAINTAINER_MODE
 noinst_PROGRAMS += tools/stktest
 
@@ -1257,10 +1064,6 @@ include/ofono/version.h: include/version.h
 	$(AM_V_at)$(MKDIR_P) include/ofono
 	$(AM_V_GEN)$(LN_S) $(abs_top_builddir)/$< $@
 
-include/ofono/gdbus.h: $(abs_top_srcdir)/gdbus/gdbus.h
-	$(AM_V_at)$(MKDIR_P) include/ofono
-	$(AM_V_GEN)$(LN_S) $< $@
-
 include/ofono/%.h: $(abs_top_srcdir)/include/%.h
 	$(AM_V_at)$(MKDIR_P) include/ofono
 	$(AM_V_GEN)$(LN_S) $< $@

ofono/acinclude.m4

@@ -22,7 +22,6 @@ AC_DEFUN([COMPILER_FLAGS], [
 		CFLAGS="$CFLAGS -Wmissing-declarations"
 		CFLAGS="$CFLAGS -Wredundant-decls"
 		CFLAGS="$CFLAGS -Wcast-align"
-		CFLAGS="$CFLAGS -Wno-format-truncation"
 		CFLAGS="$CFLAGS -DG_DISABLE_DEPRECATED"
 	fi
 ])

ofono/configure.ac

@@ -1,5 +1,5 @@
 AC_PREREQ(2.60)
-AC_INIT(ofono, 1.21)
+AC_INIT(ofono, 1.19)
 
 AM_INIT_AUTOMAKE([foreign subdir-objects color-tests])
 AC_CONFIG_HEADERS(config.h)
@@ -69,16 +69,6 @@ PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.32, dummy=yes,
 AC_SUBST(GLIB_CFLAGS)
 AC_SUBST(GLIB_LIBS)
 
-PKG_CHECK_MODULES(GOBJECT, gobject-2.0, dummy=yes,
-				AC_MSG_ERROR(GObject is required))
-GLIB_CFLAGS="$GLIB_CFLAGS $GOBJECT_CFLAGS"
-GLIB_LIBS="$GLIB_LIBS $GOBJECT_LIBS"
-
-PKG_CHECK_MODULES(GIO, gio-2.0, dummy=yes,
-				AC_MSG_ERROR(GIO is required))
-GLIB_CFLAGS="$GLIB_CFLAGS $GIO_CFLAGS"
-GLIB_LIBS="$GLIB_LIBS $GIO_LIBS"
-
 if (test "${enable_threads}" = "yes"); then
 	AC_DEFINE(NEED_THREADS, 1, [Define if threading support is required])
 	PKG_CHECK_MODULES(GTHREAD, gthread-2.0 >= 2.16, dummy=yes,
@@ -177,36 +167,20 @@ AC_ARG_ENABLE(rilmodem, AC_HELP_STRING([--disable-rilmodem],
                                         [enable_rilmodem=${enableval}])
 AM_CONDITIONAL(RILMODEM, test "${enable_rilmodem}" != "no")
 
-AC_ARG_ENABLE(sailfish-rilmodem, AC_HELP_STRING([--enable-sailfish-rilmodem],
-				[enable Sailfish RIL modem]),
-				[enable_sailfish_rilmodem=${enableval}],
-				[enable_sailfish_rilmodem="no"])
-AM_CONDITIONAL(SAILFISH_RILMODEM, test "${enable_sailfish_rilmodem}" != "no")
+AC_ARG_ENABLE(jolla-rilmodem,
+        AC_HELP_STRING([--enable-jolla-rilmodem], [enable Jolla RIL modem]),
+        [enable_jolla_rilmodem=${enableval}], [enable_jolla_rilmodem="no"])
+AM_CONDITIONAL(JOLLA_RILMODEM, test "${enable_jolla_rilmodem}" != "no")
 
-if (test "${enable_sailfish_rilmodem}" = "yes"); then
-	PKG_CHECK_MODULES(GRILIO, libgrilio >= 1.0.25, dummy=yes,
-				AC_MSG_ERROR(libgrilio >= 1.0.25 is required))
-	PKG_CHECK_MODULES(GLIBUTIL, libglibutil >= 1.0.30, dummy=yes,
-				AC_MSG_ERROR(libglibutil >= 1.0.30 is required))
-	PKG_CHECK_MODULES(LIBMCE, libmce-glib >= 1.0.5, dummy=yes,
-				AC_MSG_ERROR(libmce-glib >= 1.0.5 is required))
-	CFLAGS="$CFLAGS $GRILIO_CFLAGS $LIBMCE_CFLAGS"
-	LIBS="$LIBS $GRILIO_LIBS $LIBMCE_LIBS"
-	enable_sailfish_manager=yes
-	need_glibutil=yes
-fi
-
-AC_ARG_ENABLE(sailfish-manager,
-		AC_HELP_STRING([--enable-sailfish-manager],
-			[enable Sailfish OS modem manager plugin]),
-					[enable_sailfish_manager=${enableval}])
-AM_CONDITIONAL(SAILFISH_MANAGER, test "${enable_sailfish_manager}" = "yes")
-
-if (test "${enable_sailfish_manager}" = "yes"); then
-	PKG_CHECK_MODULES(DBUS_GLIB, dbus-glib-1, dummy=yes,
-			AC_MSG_ERROR(dbus-glib is required by unit tests))
-	AC_SUBST(DBUS_GLIB_CFLAGS)
-	AC_SUBST(DBUS_GLIB_LIBS)
+if (test "${enable_jolla_rilmodem}" = "yes"); then
+	PKG_CHECK_MODULES(GRILIO, libgrilio >= 1.0.6, dummy=yes,
+				AC_MSG_ERROR(libgrilio >= 1.0.6 is required))
+	PKG_CHECK_MODULES(GLIBUTIL, libglibutil >= 1.0.5, dummy=yes,
+				AC_MSG_ERROR(libglibutil >= 1.0.5 is required))
+	PKG_CHECK_MODULES(LIBMCE, libmce-glib, dummy=yes,
+				AC_MSG_ERROR(libmce-glib is required))
+	CFLAGS="$CFLAGS $GRILIO_CFLAGS $GLIBUTIL_CFLAGS $LIBMCE_CFLAGS"
+	LIBS="$LIBS $GRILIO_LIBS $GLIBUTIL_LIBS $LIBMCE_LIBS"
 fi
 
 AC_ARG_ENABLE(add-remove-context, AC_HELP_STRING([--disable-add-remove-context],
@@ -216,12 +190,6 @@ AC_ARG_ENABLE(add-remove-context, AC_HELP_STRING([--disable-add-remove-context],
 	fi
 ])
 
-AC_ARG_ENABLE(test-coverage,
-	AC_HELP_STRING([--enable-test-coverage], [enable test code coverage]),
-				[enable_test_coverage=${enableval}],
-					[enable_test_coverage="no"])
-AM_CONDITIONAL(TEST_COVERAGE, test "${enable_test_coverage}" != "no")
-
 AC_ARG_ENABLE(qmimodem, AC_HELP_STRING([--disable-qmimodem],
 				[disable Qualcomm QMI modem support]),
 					[enable_qmimodem=${enableval}])
@@ -245,15 +213,9 @@ fi
 AM_CONDITIONAL(BLUEZ4, test "${enable_bluetooth}" != "no" && test "${enable_bluez4}" = "yes")
 AM_CONDITIONAL(BLUETOOTH, test "${enable_bluetooth}" != "no")
 
-AC_ARG_ENABLE(sailfish-bt, AC_HELP_STRING([--enable-sailfish-bt],
-			[enable Sailfish OS Bluetooth plugin]),
-					[enable_sailfish_bt=${enableval}])
-AM_CONDITIONAL(SAILFISH_BT, test "${enable_sailfish_bt}" = "yes")
-
-AC_ARG_ENABLE(sailfish-provision, AC_HELP_STRING([--enable-sailfish-provision],
-			[enable Sailfish OS provisioning plugin]),
-				[enable_sailfish_provision=${enableval}])
-AM_CONDITIONAL(SAILFISH_PROVISION, test "${enable_sailfish_provision=$}" = "yes")
+AC_ARG_ENABLE(sailfishos, AC_HELP_STRING([--enable-sailfishos],
+                [enable sailfishos plugin]), [enable_sailfishos=${enableval}])
+AM_CONDITIONAL(SAILFISHFOS, test "${enable_sailfishos}" = "yes")
 
 AC_ARG_ENABLE(nettime, AC_HELP_STRING([--disable-nettime],
                                 [disable Nettime plugin]),
@@ -297,38 +259,28 @@ AC_ARG_ENABLE(datafiles, AC_HELP_STRING([--disable-datafiles],
 					[enable_datafiles=${enableval}])
 AM_CONDITIONAL(DATAFILES, test "${enable_datafiles}" != "no")
 
-AC_ARG_ENABLE(sailfish-pushforwarder, AC_HELP_STRING([--enable-sailfish-pushforwarder],
-			[enable Sailfish OS push forwarder plugin]),
-			[enable_sailfish_pushforwarder=${enableval}],
-			[enable_sailfish_pushforwarder="no"])
-AM_CONDITIONAL(SAILFISH_PUSHFORWARDER, test "${enable_sailfish_pushforwarder}" != "no")
-if (test "${enable_sailfish_pushforwarder}" != "no"); then
-	PKG_CHECK_MODULES(GLIBUTIL, libglibutil >= 1.0.15, dummy=yes,
-			AC_MSG_ERROR(libglibutil >= 1.0.15 is required))
+AC_ARG_ENABLE(pushforwarder, AC_HELP_STRING([--disable-pushforwarder],
+                                [disable Push Forwarder plugin]),
+                                        [enable_pushforwarder=${enableval}])
+AM_CONDITIONAL(PUSHFORWARDER, test "${enable_pushforwarder}" != "no")
+if (test "${enable_pushforwarder}" != "no"); then
 	PKG_CHECK_MODULES(WSPCODEC, libwspcodec >= 2.0, dummy=yes,
-			AC_MSG_ERROR(WSP decoder is required))
-	CFLAGS="$CFLAGS $WSPCODEC_CFLAGS"
-	LIBS="$LIBS $WSPCODEC_LIBS"
-	need_glibutil=yes
+		AC_MSG_ERROR(WSP decoder is required))
+	AC_SUBST(WSPCODEC_CFLAGS)
+	AC_SUBST(WSPCODEC_LIBS)
 fi
 
-AC_ARG_ENABLE(sailfish-debuglog, AC_HELP_STRING([--enable-sailfish-debuglog],
-			[enable Sailfish OS debug log plugin]),
-			[enable_sailfish_debuglog=${enableval}],
-			[enable_sailfish_debuglog="no"])
-AM_CONDITIONAL(SAILFISH_DEBUGLOG, test "${enable_sailfish_debuglog}" != "no")
-if (test "${enable_sailfish_debuglog}" = "yes"); then
+AC_ARG_ENABLE(debuglog,
+	AC_HELP_STRING([--enable-debuglog], [enable log control plugin]),
+			[enable_debuglog=${enableval}], [enable_debuglog="no"])
+AM_CONDITIONAL(DEBUGLOG, test "${enable_debuglog}" != "no")
+if (test "${enable_debuglog}" = "yes"); then
 	PKG_CHECK_MODULES(DBUSLOG, libdbuslogserver-dbus, dummy=yes,
 				AC_MSG_ERROR(libdbuslogserver-dbus is required))
 	CFLAGS="$CFLAGS $DBUSLOG_CFLAGS"
 	LIBS="$LIBS $DBUSLOG_LIBS"
 fi
 
-if (test "${need_glibutil}" = "yes"); then
-	CFLAGS="$CFLAGS $GLIBUTIL_CFLAGS"
-	LIBS="$LIBS $GLIBUTIL_LIBS"
-fi
-
 if (test "${prefix}" = "NONE"); then
 	dnl no prefix and no localstatedir, so default to /var
 	if (test "$localstatedir" = '${prefix}/var'); then
@@ -343,7 +295,7 @@ if (test "$localstatedir" = '${prefix}/var'); then
 else
 	storagedir="${localstatedir}/lib/ofono"
 fi
-AC_DEFINE_UNQUOTED(DEFAULT_STORAGEDIR, "${storagedir}",
+AC_DEFINE_UNQUOTED(STORAGEDIR, "${storagedir}",
 			[Directory for the storage files])
 
 if (test "$sysconfdir" = '${prefix}/etc'); then

ofono/doc/cinterion-hardware-monitor-api.txt

@@ -1,16 +0,0 @@
-
-HardwareMonitor hierarchy
-=========================
-
-Service		org.ofono
-Interface	org.ofono.cinterion.HardwareMonitor
-Object path	/{device0,device1,...}
-
-Methods		array{string,variant} GetStatistics
-
-			Returns an array of dict entries representing the
-			current temperature and supply voltage of the modem.
-
-			Units:
-			Temperature: Celsius
-			Voltage: mV

ofono/doc/coding-style.txt

@@ -19,7 +19,7 @@ Besides the kernel coding style above, oFono has special flavors for its own.
 Some of them are mandatory (marked as 'M'), while some others are optional
 (marked as 'O'), but generally preferred.
 
-M1: Blank line before and after an if/while/do/for/switch statement
+M1: Blank line before and after an if/while/do/for statement
 ============================================================
 There should be a blank line before if statement unless the if is nested and
 not preceded by an expression or variable declaration.

ofono/doc/handsfree-audio-api.txt

@@ -76,22 +76,6 @@ Methods		dict GetProperties()
 					 [service].Error.NotImplemented
 					 [service].Error.NotAllowed
 
-		fd, byte Acquire()
-
-			Attempts to establish the SCO audio connection
-			returning the filedescriptor of the connection and the
-			codec in use.
-
-			Note: Contrary to Connect this does not call
-			NewConnection so it can be called in a blocking
-			manner.
-
-			Possible Errors: [service].Error.InProgress
-					 [service].Error.Failed
-					 [service].Error.NotAvailable
-					 [service].Error.NotImplemented
-					 [service].Error.NotAllowed
-
 Signals		PropertyChanged(string name, variant value)
 
 			This signal indicates a changed value of the given

ofono/doc/lte-api.txt

@@ -1,35 +0,0 @@
-LongTermEvolution Hierarchy
-
-Service		org.ofono
-Interface	org.ofono.LongTermEvolution
-Object path	[variable prefix]/{modem0,modem1,...}
-
-
-Methods		dict GetProperties()
-
-			Returns all LongTermEvolution configuration properties.
-
-		void SetProperty(string property, variant value)
-
-			Changes the value of the specified property. Only
-			properties that are listed as readwrite are
-			changeable. On success a PropertyChanged signal
-			will be emitted.
-
-			Possible Errors: [service].Error.InProgress
-					 [service].Error.InvalidArguments
-					 [service].Error.Failed
-
-Signals		PropertyChanged(string property, variant value)
-
-			This signal indicates a changed value of the given
-			property.
-
-Properties	string DefaultAccessPointName [readwrite]
-
-			On LongTermEvolution, contexts activate automatically.
-			This property allows selection of an APN to be used on
-			next automatic activation.
-
-			Setting this property to an empty string clears the
-			default APN from the modem.

ofono/doc/networkmonitor-api.txt

@@ -22,34 +22,6 @@ Methods		a{sv} GetServingCellInformation()
 			are available, their valid value ranges and
 			applicability to different cell types.
 
-		void RegisterAgent(object path)
-
-			Registers an agent which will be called whenever the
-			modem registers to or moves to a new cell.
-
-		void UnregisterAgent(object path)
-
-			Unregisters an agent.
-
-NetworkMonitorAgent Hierarchy [experimental]
-=============================
-
-Service		unique name
-Interface	org.ofono.NetworkMonitorAgent
-Object path	freely definable
-
-Methods		void ServingCellInformationChanged(a{sv}) [noreply]
-
-			This method is called whenever the serving cell
-			information has been updated.
-
-			Possible Errors: None
-
-		void Release() [noreply]
-
-			Agent is being released, possibly because of oFono
-			terminating, NetworkMonitor interface is being torn
-			down or modem off.  No UnregisterAgent call is needed.
 
 Network Monitor Property Types
 ==============================
@@ -105,46 +77,7 @@ byte TimingAdvance [optional, gsm]
 
 	Contains the Timing Advance.  Valid range of values is 0-219.
 
-byte Strength [optional, gsm, umts, lte]
+byte Strength [optional, gsm, umts]
 
 	Contains the signal strength.  Valid values are 0-31.  Refer to <rssi>
 	in 27.007, Section 8.5.
-
-byte ReceivedSignalCodePower [optional, umts]
-
-        Contains the Received Signal Code Power.  Valid range of values
-        is 0-96. Refer to <rscp> in 27.007, Section 8.69 for more details.
-
-byte ReceivedEnergyRatio [optional, umts]
-
-        Contains the Ratio of received energy per PN chip to the total
-        received power spectral density.  Valid range of values is 0-49.
-        Refer to <ecno> in 27.007, Section 8.69 for more details.
-
-byte ReferenceSignalReceivedQuality [optional, lte]
-
-        Contains the Reference Signal Received Quality.  Valid range of
-        values is 0-34. Refer to <rsrq> in 27.007, Section 8.69 for more
-        details.
-
-byte ReferenceSignalReceivedPower [optional, lte]
-
-        Contains the Reference Signal Received Power.  Valid range of values
-        is 0-97. Refer to <rsrp> in 27.007, Section 8.69 for more details.
-
-uint16 EARFCN [optional, lte]
-
-	Contains E-UTRA Absolute Radio Frequency Channel Number.  Valid
-	range of values is 0-65535. Refer to Carrier frequency and
-	EARFCN in 36.101, Section 5.7.3 for more details.
-
-byte EBand [optional, lte]
-
-	Contains E-UTRA operating Band.  Valid range of values is 1-43.
-	Refer to Operating bands in 36.101, Section 5.5 for more
-	details.
-
-byte ChannelQualityIndicator [optional, lte]
-
-	Contains Channel Quality Indicator.  Refer to Channel Quality
-	Indicator definition in 36.213, Section 7.2.3 for more details.

ofono/doc/telit-modem.txt

@@ -17,30 +17,3 @@ GPS:
   After setting the configuration, a power cycle is required.
   Port Configiuration #8 is available since firmware 12.00.004. Firmware version
   can be checked using 'AT+CGMR'.
-
-LE910 V2
-========
-
-Default USB composition of LE910V2 uses PID 0x36 (AT#PORTCFG=0)
-and consists of 6 serial ports (CDC-ACM standard, /dev/ttyACMx)
-and 1 network adapter using CDC-NCM standard (wwanx or usbx).
-
-NCM interface configuration follows Telit documentation
-(both documents available on Telit Download Zone - registration required)
-"GE/HE/UE910, UL865, LE910 V2 Linux USB Driver - User Guide r0"
-(document 1VV0301255 Rev.0 - 2016-01-22)
-and "Telit LE910-V2 NCM SETUP r3"
-(document 1VV0301246 Rev.3 - 2016-11-29).
-
-After context is setup, NCM mode activated and PDP context activated
-connection configuration can be read using
-AT+CGPADDR=context_id and AT+CGCONTRDP=context_id commands.
-This is done automatically and results available via
-org.ofono.ConnectionContext.GetProperties DBus method.
-
-Then Linux network interface needs to be configured:
-    ifconfig <Interface> <Address> netmask <Netmask> up
-    route add default gw <Gateway>
-    arp -s <Gateway> 11:22:33:44:55:66
-
-Only after these steps network interface is usable.

ofono/drivers/atmodem/atmodem.c

@@ -52,7 +52,6 @@ static int atmodem_init(void)
 	at_gprs_context_init();
 	at_sim_auth_init();
 	at_gnss_init();
-	at_lte_init();
 
 	return 0;
 }
@@ -77,7 +76,6 @@ static void atmodem_exit(void)
 	at_gprs_exit();
 	at_gprs_context_exit();
 	at_gnss_exit();
-	at_lte_exit();
 }
 
 OFONO_PLUGIN_DEFINE(atmodem, "AT modem driver", VERSION,

ofono/drivers/atmodem/atmodem.h

@@ -74,6 +74,3 @@ extern void at_sim_auth_exit(void);
 
 extern void at_gnss_init(void);
 extern void at_gnss_exit(void);
-
-extern void at_lte_init(void);
-extern void at_lte_exit(void);

ofono/drivers/atmodem/atutil.c

@@ -27,7 +27,6 @@
 #include <gatchat.h>
 #include <string.h>
 #include <stdlib.h>
-#include <errno.h>
 
 #define OFONO_API_SUBJECT_TO_CHANGE
 #include <ofono/log.h>
@@ -615,42 +614,3 @@ void at_util_sim_state_query_free(struct at_util_sim_state_query *req)
 
 	g_free(req);
 }
-
-/*
- * CGCONTRDP returns addr + netmask in the same string in the form
- * of "a.b.c.d.m.m.m.m" for IPv4.
- * address/netmask must be able to hold
- * 255.255.255.255 + null = 16 characters
- */
-int at_util_get_ipv4_address_and_netmask(const char *addrnetmask,
-						char *address, char *netmask)
-{
-	const char *s = addrnetmask;
-	const char *net = NULL;
-
-	int ret = -EINVAL;
-	int i;
-
-	/* Count 7 dots for ipv4, less or more means error. */
-	for (i = 0; i < 9; i++, s++) {
-		s = strchr(s, '.');
-
-		if (!s)
-			break;
-
-		if (i == 3) {
-			/* set netmask ptr and break the string */
-			net = s + 1;
-		}
-	}
-
-	if (i == 7) {
-		memcpy(address, addrnetmask, net - addrnetmask);
-		address[net - addrnetmask - 1] = '\0';
-		strcpy(netmask, net);
-
-		ret = 0;
-	}
-
-	return ret;
-}

ofono/drivers/atmodem/atutil.h

@@ -83,9 +83,6 @@ struct at_util_sim_state_query *at_util_sim_state_query_new(GAtChat *chat,
 						GDestroyNotify destroy);
 void at_util_sim_state_query_free(struct at_util_sim_state_query *req);
 
-int at_util_get_ipv4_address_and_netmask(const char *addrnetmask,
-						char *address, char *netmask);
-
 struct cb_data {
 	void *cb;
 	void *data;

ofono/drivers/atmodem/gprs-context.c

@@ -43,11 +43,10 @@
 #include "atmodem.h"
 #include "vendor.h"
 
-#define TUN_DEV "/dev/net/tun"
+#define TUN_SYSFS_DIR "/sys/devices/virtual/misc/tun"
 
 #define STATIC_IP_NETMASK "255.255.255.255"
 
-static const char *cgdata_prefix[] = { "+CGDATA:", NULL };
 static const char *none_prefix[] = { NULL };
 
 enum state {
@@ -68,7 +67,6 @@ struct gprs_context_data {
 	ofono_gprs_context_cb_t cb;
 	void *cb_data;                                  /* Callback data */
 	unsigned int vendor;
-	gboolean use_atd99;
 };
 
 static void ppp_debug(const char *str, void *data)
@@ -212,7 +210,7 @@ static void at_cgdcont_cb(gboolean ok, GAtResult *result, gpointer user_data)
 		return;
 	}
 
-	if (gcd->use_atd99)
+	if (gcd->vendor == OFONO_VENDOR_SIMCOM_SIM900)
 		sprintf(buf, "ATD*99***%u#", gcd->active_context);
 	else
 		sprintf(buf, "AT+CGDATA=\"PPP\",%u", gcd->active_context);
@@ -249,8 +247,6 @@ static void at_gprs_activate_primary(struct ofono_gprs_context *gc,
 
 	/* We only support CHAP and PAP */
 	switch (ctx->auth_method) {
-	case OFONO_GPRS_AUTH_METHOD_ANY:
-	case OFONO_GPRS_AUTH_METHOD_NONE:
 	case OFONO_GPRS_AUTH_METHOD_CHAP:
 		gcd->auth_method = G_AT_PPP_AUTH_METHOD_CHAP;
 		break;
@@ -298,8 +294,6 @@ static void at_gprs_activate_primary(struct ofono_gprs_context *gc,
 			 * prefix, this is the least invasive place to set it.
 			 */
 			switch (ctx->auth_method) {
-			case OFONO_GPRS_AUTH_METHOD_ANY:
-			case OFONO_GPRS_AUTH_METHOD_NONE:
 			case OFONO_GPRS_AUTH_METHOD_CHAP:
 				snprintf(buf + len, sizeof(buf) - len - 3,
 						",\"CHAP:%s\"", ctx->apn);
@@ -384,43 +378,6 @@ static void cgev_notify(GAtResult *result, gpointer user_data)
 		g_at_ppp_shutdown(gcd->ppp);
 }
 
-static void at_cgdata_test_cb(gboolean ok, GAtResult *result,
-				gpointer user_data)
-{
-	struct ofono_gprs_context *gc = user_data;
-	struct gprs_context_data *gcd = ofono_gprs_context_get_data(gc);
-	GAtResultIter iter;
-	const char *data_type;
-	gboolean found = FALSE;
-
-	gcd->use_atd99 = TRUE;
-
-	if (!ok) {
-		DBG("not ok");
-		goto error;
-	}
-
-	g_at_result_iter_init(&iter, result);
-	if (!g_at_result_iter_next(&iter, "+CGDATA:")) {
-		DBG("no +CGDATA line");
-		goto error;
-	}
-
-	if (!g_at_result_iter_open_list(&iter)) {
-		DBG("no list found");
-		goto error;
-	}
-
-	while (!found && g_at_result_iter_next_string(&iter, &data_type)) {
-		if (g_str_equal(data_type, "PPP")) {
-			found = TRUE;
-			gcd->use_atd99 = FALSE;
-		}
-	}
-error:
-	DBG("use_atd99:%d", gcd->use_atd99);
-}
-
 static int at_gprs_context_probe(struct ofono_gprs_context *gc,
 					unsigned int vendor, void *data)
 {
@@ -430,7 +387,7 @@ static int at_gprs_context_probe(struct ofono_gprs_context *gc,
 
 	DBG("");
 
-	if (stat(TUN_DEV, &st) < 0) {
+	if (stat(TUN_SYSFS_DIR, &st) < 0) {
 		ofono_error("Missing support for TUN/TAP devices");
 		return -ENODEV;
 	}
@@ -448,15 +405,6 @@ static int at_gprs_context_probe(struct ofono_gprs_context *gc,
 	if (chat == NULL)
 		return 0;
 
-	switch (vendor) {
-	case OFONO_VENDOR_SIMCOM_SIM900:
-		gcd->use_atd99 = FALSE;
-		break;
-	default:
-		g_at_chat_send(chat, "AT+CGDATA=?", cgdata_prefix,
-						at_cgdata_test_cb, gc, NULL);
-	}
-
 	g_at_chat_register(chat, "+CGEV:", cgev_notify, FALSE, gc, NULL);
 
 	return 0;

ofono/drivers/atmodem/gprs.c

@@ -50,8 +50,6 @@ struct gprs_data {
 	GAtChat *chat;
 	unsigned int vendor;
 	unsigned int last_auto_context_id;
-	gboolean telit_try_reattach;
-	int attached;
 };
 
 static void at_cgatt_cb(gboolean ok, GAtResult *result, gpointer user_data)
@@ -75,10 +73,8 @@ static void at_gprs_set_attached(struct ofono_gprs *gprs, int attached,
 	snprintf(buf, sizeof(buf), "AT+CGATT=%i", attached ? 1 : 0);
 
 	if (g_at_chat_send(gd->chat, buf, none_prefix,
-				at_cgatt_cb, cbd, g_free) > 0) {
-		gd->attached = attached;
+				at_cgatt_cb, cbd, g_free) > 0)
 		return;
-	}
 
 	g_free(cbd);
 
@@ -198,28 +194,6 @@ static void cgreg_notify(GAtResult *result, gpointer user_data)
 				NULL, NULL, NULL, gd->vendor) == FALSE)
 		return;
 
-	/*
-	 * Telit AT modem firmware (tested with UE910-EUR) generates
-	 * +CGREG: 0\r\n\r\n+CGEV: NW DETACH
-	 * after a context is de-activated and ppp connection closed.
-	 * Then, after a random amount of time (observed from a few seconds
-	 * to a few hours), an unsolicited +CGREG: 1 arrives.
-	 * Attempt to fix the problem, by sending AT+CGATT=1 once.
-	 * This does not re-activate the context, but if a network connection
-	 * is still correct, will generate an immediate +CGREG: 1.
-	 */
-	if (gd->vendor == OFONO_VENDOR_TELIT) {
-		if (gd->attached && !status && !gd->telit_try_reattach) {
-			DBG("Trying to re-attach gprs network");
-			gd->telit_try_reattach = TRUE;
-			g_at_chat_send(gd->chat, "AT+CGATT=1", none_prefix,
-					NULL, NULL, NULL);
-			return;
-		}
-
-		gd->telit_try_reattach = FALSE;
-	}
-
 	ofono_gprs_status_notify(gprs, status);
 }
 
@@ -240,11 +214,6 @@ static void cgev_notify(GAtResult *result, gpointer user_data)
 
 	if (g_str_equal(event, "NW DETACH") ||
 			g_str_equal(event, "ME DETACH")) {
-		if (gd->vendor == OFONO_VENDOR_TELIT &&
-				gd->telit_try_reattach)
-			return;
-
-		gd->attached = FALSE;
 		ofono_gprs_detached_notify(gprs);
 		return;
 	} else if (g_str_has_prefix(event, "ME PDN ACT")) {
@@ -327,26 +296,6 @@ static void huawei_mode_notify(GAtResult *result, gpointer user_data)
 	ofono_gprs_bearer_notify(gprs, bearer);
 }
 
-static void huawei_hcsq_notify(GAtResult *result, gpointer user_data)
-{
-	struct ofono_gprs *gprs = user_data;
-	GAtResultIter iter;
-	const char *mode;
-
-	g_at_result_iter_init(&iter, result);
-
-	if (!g_at_result_iter_next(&iter, "^HCSQ:"))
-		return;
-
-	if (!g_at_result_iter_next_string(&iter, &mode))
-		return;
-
-	if (!strcmp("LTE", mode))
-		ofono_gprs_bearer_notify(gprs, 7); /* LTE */
-
-	/* in other modes, notification ^MODE is used */
-}
-
 static void telit_mode_notify(GAtResult *result, gpointer user_data)
 {
 	struct ofono_gprs *gprs = user_data;
@@ -374,9 +323,6 @@ static void telit_mode_notify(GAtResult *result, gpointer user_data)
 	case 3:
 		bearer = 5;    /* HSDPA */
 		break;
-	case 4:
-		bearer = 7;    /* LTE */
-		break;
 	default:
 		bearer = 0;
 		break;
@@ -452,8 +398,6 @@ static void gprs_initialized(gboolean ok, GAtResult *result, gpointer user_data)
 	case OFONO_VENDOR_HUAWEI:
 		g_at_chat_register(gd->chat, "^MODE:", huawei_mode_notify,
 						FALSE, gprs, NULL);
-		g_at_chat_register(gd->chat, "^HCSQ:", huawei_hcsq_notify,
-						FALSE, gprs, NULL);
 		break;
 	case OFONO_VENDOR_UBLOX:
 	case OFONO_VENDOR_UBLOX_TOBY_L2:
@@ -467,7 +411,6 @@ static void gprs_initialized(gboolean ok, GAtResult *result, gpointer user_data)
 						FALSE, gprs, NULL);
 		g_at_chat_send(gd->chat, "AT#PSNT=1", none_prefix,
 						NULL, NULL, NULL);
-		break;
 	default:
 		g_at_chat_register(gd->chat, "+CPSB:", cpsb_notify,
 						FALSE, gprs, NULL);
@@ -579,7 +522,7 @@ static void at_cgdcont_test_cb(gboolean ok, GAtResult *result,
 		if (g_at_result_iter_next_range(&iter, &min, &max) == FALSE)
 			continue;
 
-		if (!g_at_result_iter_skip_next(&iter))
+		if (!g_at_result_iter_close_list(&iter))
 			continue;
 
 		if (g_at_result_iter_open_list(&iter))

ofono/drivers/atmodem/lte.c

@@ -1,142 +0,0 @@
-/*
- *
- *  oFono - Open Source Telephony
- *
- *  Copyright (C) 2017  Intel Corporation. All rights reserved.
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
- *
- */
-
-#ifdef HAVE_CONFIG_H
-#include <config.h>
-#endif
-
-#define _GNU_SOURCE
-#include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
-#include <errno.h>
-
-#include <glib.h>
-
-#include <ofono/modem.h>
-#include <ofono/gprs-context.h>
-#include <ofono/log.h>
-#include <ofono/lte.h>
-
-#include "gatchat.h"
-#include "gatresult.h"
-
-#include "atmodem.h"
-
-struct lte_driver_data {
-	GAtChat *chat;
-};
-
-static void at_lte_set_default_attach_info_cb(gboolean ok, GAtResult *result,
-							gpointer user_data)
-{
-	struct cb_data *cbd = user_data;
-	ofono_lte_cb_t cb = cbd->cb;
-	struct ofono_error error;
-
-	DBG("ok %d", ok);
-
-	decode_at_error(&error, g_at_result_final_response(result));
-	cb(&error, cbd->data);
-}
-
-static void at_lte_set_default_attach_info(const struct ofono_lte *lte,
-			const struct ofono_lte_default_attach_info *info,
-			ofono_lte_cb_t cb, void *data)
-{
-	struct lte_driver_data *ldd = ofono_lte_get_data(lte);
-	char buf[32 + OFONO_GPRS_MAX_APN_LENGTH + 1];
-	struct cb_data *cbd = cb_data_new(cb, data);
-
-	DBG("LTE config with APN: %s", info->apn);
-
-	if (strlen(info->apn) > 0)
-		snprintf(buf, sizeof(buf), "AT+CGDCONT=0,\"IP\",\"%s\"",
-				info->apn);
-	else
-		snprintf(buf, sizeof(buf), "AT+CGDCONT=0,\"IP\"");
-
-	/* We can't do much in case of failure so don't check response. */
-	if (g_at_chat_send(ldd->chat, buf, NULL,
-			at_lte_set_default_attach_info_cb, cbd, g_free) > 0)
-		return;
-
-	CALLBACK_WITH_FAILURE(cb, data);
-}
-
-static gboolean lte_delayed_register(gpointer user_data)
-{
-	struct ofono_lte *lte = user_data;
-
-	ofono_lte_register(lte);
-
-	return FALSE;
-}
-
-static int at_lte_probe(struct ofono_lte *lte, void *data)
-{
-	GAtChat *chat = data;
-	struct lte_driver_data *ldd;
-
-	DBG("at lte probe");
-
-	ldd = g_try_new0(struct lte_driver_data, 1);
-	if (!ldd)
-		return -ENOMEM;
-
-	ldd->chat = g_at_chat_clone(chat);
-
-	ofono_lte_set_data(lte, ldd);
-
-	g_idle_add(lte_delayed_register, lte);
-
-	return 0;
-}
-
-static void at_lte_remove(struct ofono_lte *lte)
-{
-	struct lte_driver_data *ldd = ofono_lte_get_data(lte);
-
-	DBG("at lte remove");
-
-	g_at_chat_unref(ldd->chat);
-
-	ofono_lte_set_data(lte, NULL);
-
-	g_free(ldd);
-}
-
-static struct ofono_lte_driver driver = {
-	.name				= "atmodem",
-	.probe				= at_lte_probe,
-	.remove				= at_lte_remove,
-	.set_default_attach_info	= at_lte_set_default_attach_info,
-};
-
-void at_lte_init(void)
-{
-	ofono_lte_driver_register(&driver);
-}
-
-void at_lte_exit(void)
-{
-	ofono_lte_driver_unregister(&driver);
-}

ofono/drivers/atmodem/network-registration.c

@@ -1088,27 +1088,6 @@ static void huawei_mode_notify(GAtResult *result, gpointer user_data)
 	}
 }
 
-static void huawei_hcsq_notify(GAtResult *result, gpointer user_data)
-{
-	struct ofono_netreg *netreg = user_data;
-	struct netreg_data *nd = ofono_netreg_get_data(netreg);
-	GAtResultIter iter;
-	const char *mode;
-
-	g_at_result_iter_init(&iter, result);
-
-	if (!g_at_result_iter_next(&iter, "^HCSQ:"))
-		return;
-
-	if (!g_at_result_iter_next_string(&iter, &mode))
-		return;
-
-	if (!strcmp("LTE", mode))
-		nd->tech = ACCESS_TECHNOLOGY_EUTRAN;
-
-	/* for other technologies, notification ^MODE is used */
-}
-
 static void huawei_nwtime_notify(GAtResult *result, gpointer user_data)
 {
 	struct ofono_netreg *netreg = user_data;
@@ -1917,10 +1896,6 @@ static void at_creg_set_cb(gboolean ok, GAtResult *result, gpointer user_data)
 		g_at_chat_register(nd->chat, "^MODE:", huawei_mode_notify,
 						FALSE, netreg, NULL);
 
-		/* Register for 4G system mode reports */
-		g_at_chat_register(nd->chat, "^HCSQ:", huawei_hcsq_notify,
-						FALSE, netreg, NULL);
-
 		/* Register for network time reports */
 		g_at_chat_register(nd->chat, "^NWTIME:", huawei_nwtime_notify,
 						FALSE, netreg, NULL);

ofono/drivers/atmodem/sim.c

@@ -51,7 +51,6 @@ struct sim_data {
 	GAtChat *chat;
 	unsigned int vendor;
 	guint ready_id;
-	guint passwd_type_mask;
 	struct at_util_sim_state_query *sim_state_query;
 };
 
@@ -1294,15 +1293,14 @@ static void sim_state_cb(gboolean present, gpointer user_data)
 	struct cb_data *cbd = user_data;
 	struct sim_data *sd = cbd->user;
 	ofono_sim_lock_unlock_cb_t cb = cbd->cb;
-	void *data = cbd->data;
 
 	at_util_sim_state_query_free(sd->sim_state_query);
 	sd->sim_state_query = NULL;
 
 	if (present == 1)
-		CALLBACK_WITH_SUCCESS(cb, data);
+		CALLBACK_WITH_SUCCESS(cb, cbd->data);
 	else
-		CALLBACK_WITH_FAILURE(cb, data);
+		CALLBACK_WITH_FAILURE(cb, cbd->data);
 }
 
 static void at_pin_send_cb(gboolean ok, GAtResult *result,
@@ -1460,8 +1458,9 @@ static void at_pin_enable(struct ofono_sim *sim,
 	struct cb_data *cbd = cb_data_new(cb, data);
 	char buf[64];
 	int ret;
+	unsigned int len = sizeof(at_clck_cpwd_fac) / sizeof(*at_clck_cpwd_fac);
 
-	if (!(sd->passwd_type_mask & (1 << passwd_type)))
+	if (passwd_type >= len || at_clck_cpwd_fac[passwd_type] == NULL)
 		goto error;
 
 	snprintf(buf, sizeof(buf), "AT+CLCK=\"%s\",%i,\"%s\"",
@@ -1490,8 +1489,10 @@ static void at_change_passwd(struct ofono_sim *sim,
 	struct cb_data *cbd = cb_data_new(cb, data);
 	char buf[64];
 	int ret;
+	unsigned int len = sizeof(at_clck_cpwd_fac) / sizeof(*at_clck_cpwd_fac);
 
-	if (!(sd->passwd_type_mask & (1 << passwd_type)))
+	if (passwd_type >= len ||
+			at_clck_cpwd_fac[passwd_type] == NULL)
 		goto error;
 
 	snprintf(buf, sizeof(buf), "AT+CPWD=\"%s\",\"%s\",\"%s\"",
@@ -1548,8 +1549,9 @@ static void at_query_clck(struct ofono_sim *sim,
 	struct sim_data *sd = ofono_sim_get_data(sim);
 	struct cb_data *cbd = cb_data_new(cb, data);
 	char buf[64];
+	unsigned int len = sizeof(at_clck_cpwd_fac) / sizeof(*at_clck_cpwd_fac);
 
-	if (!(sd->passwd_type_mask & (1 << passwd_type)))
+	if (passwd_type >= len || at_clck_cpwd_fac[passwd_type] == NULL)
 		goto error;
 
 	snprintf(buf, sizeof(buf), "AT+CLCK=\"%s\",2",
@@ -1565,42 +1567,13 @@ error:
 	CALLBACK_WITH_FAILURE(cb, -1, data);
 }
 
-static void at_clck_query_cb(gboolean ok, GAtResult *result, gpointer user)
+static gboolean at_sim_register(gpointer user)
 {
 	struct ofono_sim *sim = user;
-	struct sim_data *sd = ofono_sim_get_data(sim);
-	GAtResultIter iter;
-	const char *fac;
 
-	if (!ok)
-		goto done;
-
-	g_at_result_iter_init(&iter, result);
-
-	/* e.g. +CLCK: ("SC","FD","PN","PU","PP","PC","PF") */
-	if (!g_at_result_iter_next(&iter, "+CLCK:") ||
-				!g_at_result_iter_open_list(&iter))
-		goto done;
-
-	/* Clear the default mask */
-	sd->passwd_type_mask = 0;
-
-	/* Set the bits for <fac>s that are actually supported */
-	while (g_at_result_iter_next_string(&iter, &fac)) {
-		unsigned int i;
-
-		/* Find it in the list of known <fac>s */
-		for (i = 0; i < ARRAY_SIZE(at_clck_cpwd_fac); i++) {
-			if (!g_strcmp0(at_clck_cpwd_fac[i], fac)) {
-				sd->passwd_type_mask |= (1 << i);
-				DBG("found %s", fac);
-				break;
-			}
-		}
-	}
-
-done:
 	ofono_sim_register(sim);
+
+	return FALSE;
 }
 
 static int at_sim_probe(struct ofono_sim *sim, unsigned int vendor,
@@ -1608,7 +1581,6 @@ static int at_sim_probe(struct ofono_sim *sim, unsigned int vendor,
 {
 	GAtChat *chat = data;
 	struct sim_data *sd;
-	unsigned int i;
 
 	sd = g_new0(struct sim_data, 1);
 	sd->chat = g_at_chat_clone(chat);
@@ -1618,15 +1590,9 @@ static int at_sim_probe(struct ofono_sim *sim, unsigned int vendor,
 		g_at_chat_send(sd->chat, "AT*EPEE=1", NULL, NULL, NULL, NULL);
 
 	ofono_sim_set_data(sim, sd);
+	g_idle_add(at_sim_register, sim);
 
-	/* <fac>s supported by default */
-	for (i = 0; i < ARRAY_SIZE(at_clck_cpwd_fac); i++)
-		if (at_clck_cpwd_fac[i])
-			sd->passwd_type_mask |= (1 << i);
-
-	/* Query supported <fac>s */
-	return g_at_chat_send(sd->chat, "AT+CLCK=?", clck_prefix,
-				at_clck_query_cb, sim, NULL) ? 0 : -1;
+	return 0;
 }
 
 static void at_sim_remove(struct ofono_sim *sim)

ofono/drivers/atmodem/sms.c

@@ -319,6 +319,26 @@ static void at_cnma_cb(gboolean ok, GAtResult *result, gpointer user_data)
 				"Further SMS reception is not guaranteed");
 }
 
+static gboolean at_parse_cmt(GAtResult *result,	const char **pdu, int *pdulen)
+{
+	GAtResultIter iter;
+
+	g_at_result_iter_init(&iter, result);
+
+	if (!g_at_result_iter_next(&iter, "+CMT:"))
+		return FALSE;
+
+	if (!g_at_result_iter_skip_next(&iter))
+		return FALSE;
+
+	if (!g_at_result_iter_next_number(&iter, pdulen))
+		return FALSE;
+
+	*pdu = g_at_result_pdu(result);
+
+	return TRUE;
+}
+
 static inline void at_ack_delivery(struct ofono_sms *sms)
 {
 	struct sms_data *data = ofono_sms_get_data(sms);
@@ -327,21 +347,11 @@ static inline void at_ack_delivery(struct ofono_sms *sms)
 	DBG("");
 
 	/* We must acknowledge the PDU using CNMA */
-	if (data->cnma_ack_pdu) {
-		switch (data->vendor) {
-		case OFONO_VENDOR_CINTERION:
-			snprintf(buf, sizeof(buf), "AT+CNMA=1");
-			break;
-		default:
-			snprintf(buf, sizeof(buf), "AT+CNMA=1,%d\r%s",
-					data->cnma_ack_pdu_len,
-					data->cnma_ack_pdu);
-			break;
-		}
-	} else {
-		/* Should be a safe fallback */
+	if (data->cnma_ack_pdu)
+		snprintf(buf, sizeof(buf), "AT+CNMA=1,%d\r%s",
+				data->cnma_ack_pdu_len, data->cnma_ack_pdu);
+	else /* Should be a safe fallback */
 		snprintf(buf, sizeof(buf), "AT+CNMA=0");
-	}
 
 	g_at_chat_send(data->chat, buf, none_prefix, at_cnma_cb, NULL, NULL);
 }
@@ -399,34 +409,16 @@ static void at_cmt_notify(GAtResult *result, gpointer user_data)
 {
 	struct ofono_sms *sms = user_data;
 	struct sms_data *data = ofono_sms_get_data(sms);
-	GAtResultIter iter;
 	const char *hexpdu;
-	unsigned char pdu[176];
 	long pdu_len;
 	int tpdu_len;
+	unsigned char pdu[176];
 
-	g_at_result_iter_init(&iter, result);
-
-	if (!g_at_result_iter_next(&iter, "+CMT:"))
-		goto err;
-
-	switch (data->vendor) {
-	case OFONO_VENDOR_CINTERION:
-		if (!g_at_result_iter_next_number(&iter, &tpdu_len))
-			goto err;
-		break;
-	default:
-		if (!g_at_result_iter_skip_next(&iter))
-			goto err;
-
-		if (!g_at_result_iter_next_number(&iter, &tpdu_len))
-			goto err;
-
-		break;
+	if (!at_parse_cmt(result, &hexpdu, &tpdu_len)) {
+		ofono_error("Unable to parse CMT notification");
+		return;
 	}
 
-	hexpdu = g_at_result_pdu(result);
-
 	if (strlen(hexpdu) > sizeof(pdu) * 2) {
 		ofono_error("Bad PDU length in CMT notification");
 		return;
@@ -439,9 +431,6 @@ static void at_cmt_notify(GAtResult *result, gpointer user_data)
 
 	if (data->vendor != OFONO_VENDOR_SIMCOM)
 		at_ack_delivery(sms);
-
-err:
-	ofono_error("Unable to parse CMT notification");
 }
 
 static void at_cmgr_notify(GAtResult *result, gpointer user_data)
@@ -753,7 +742,7 @@ static void at_sms_initialized(struct ofono_sms *sms)
 
 static void at_sms_not_supported(struct ofono_sms *sms)
 {
-	ofono_error("SMS not supported by this modem.  If this is an error"
+	ofono_error("SMS not supported by this modem.  If this is in error"
 			" please submit patches to support this hardware");
 
 	ofono_sms_remove(sms);

ofono/drivers/atmodem/vendor.h

@@ -47,5 +47,4 @@ enum ofono_vendor {
 	OFONO_VENDOR_UBLOX,
 	OFONO_VENDOR_UBLOX_TOBY_L2,
 	OFONO_VENDOR_CINTERION,
-	OFONO_VENDOR_XMM,
 };

ofono/drivers/cdmamodem/connman.c

@@ -43,7 +43,7 @@
 #include "cdmamodem.h"
 #include "drivers/atmodem/vendor.h"
 
-#define TUN_DEV "/dev/net/tun"
+#define TUN_SYSFS_DIR "/sys/devices/virtual/misc/tun"
 
 #define STATIC_IP_NETMASK "255.255.255.255"
 
@@ -285,7 +285,7 @@ static int cdma_connman_probe(struct ofono_cdma_connman *cm,
 
 	DBG("");
 
-	if (stat(TUN_DEV, &st) < 0) {
+	if (stat(TUN_SYSFS_DIR, &st) < 0) {
 		ofono_error("Missing support for TUN/TAP devices");
 		return -ENODEV;
 	}

ofono/drivers/gemaltomodem/gemaltomodem.c

@@ -1,49 +0,0 @@
-/*
- *
- *  oFono - Open Source Telephony
- *
- *  Copyright (C) 2017 Vincent Cesson. All rights reserved.
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
- *
- */
-
-#ifdef HAVE_CONFIG_H
-#include <config.h>
-#endif
-
-#include <glib.h>
-#include <gatchat.h>
-
-#define OFONO_API_SUBJECT_TO_CHANGE
-#include <ofono/plugin.h>
-#include <ofono/types.h>
-
-#include "gemaltomodem.h"
-
-static int gemaltomodem_init(void)
-{
-	gemalto_location_reporting_init();
-
-	return 0;
-}
-
-static void gemaltomodem_exit(void)
-{
-	gemalto_location_reporting_exit();
-}
-
-OFONO_PLUGIN_DEFINE(gemaltomodem, "Gemalto modem driver", VERSION,
-			OFONO_PLUGIN_PRIORITY_DEFAULT,
-			gemaltomodem_init, gemaltomodem_exit)

ofono/drivers/gemaltomodem/location-reporting.c

@@ -1,237 +0,0 @@
-/*
- *
- *  oFono - Open Source Telephony
- *
- *  Copyright (C) 2017 Vincent Cesson. All rights reserved.
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
- *
- */
-
-#ifdef HAVE_CONFIG_H
-#include <config.h>
-#endif
-
-#define _GNU_SOURCE
-#include <string.h>
-#include <stdlib.h>
-#include <stdio.h>
-#include <errno.h>
-#include <unistd.h>
-
-#include <glib.h>
-
-#include <ofono/log.h>
-#include <ofono/modem.h>
-#include <ofono/location-reporting.h>
-
-#include "gatchat.h"
-#include "gatresult.h"
-#include "gattty.h"
-
-#include "gemaltomodem.h"
-
-static const char *sgpsc_prefix[] = { "^SGPSC:", NULL };
-
-struct gps_data {
-	GAtChat *chat;
-};
-
-static void gemalto_gps_disable_cb(gboolean ok, GAtResult *result,
-							gpointer user_data)
-{
-	struct cb_data *cbd = user_data;
-	struct ofono_location_reporting *lr = cbd->user;
-	ofono_location_reporting_disable_cb_t cb = cbd->cb;
-
-	DBG("lr=%p, ok=%d", lr, ok);
-
-	if (!ok) {
-		struct ofono_error error;
-
-		decode_at_error(&error, g_at_result_final_response(result));
-		cb(&error, cbd->data);
-
-		return;
-	}
-
-	CALLBACK_WITH_SUCCESS(cb, cbd->data);
-}
-
-static void gemalto_location_reporting_disable(
-				struct ofono_location_reporting *lr,
-				ofono_location_reporting_disable_cb_t cb,
-				void *data)
-{
-	struct gps_data *gd = ofono_location_reporting_get_data(lr);
-	struct cb_data *cbd = cb_data_new(cb, data);
-
-	DBG("lr=%p", lr);
-
-	cbd->user = lr;
-
-	if (g_at_chat_send(gd->chat, "AT^SGPSC=\"Engine\",0", sgpsc_prefix,
-				gemalto_gps_disable_cb, cbd, g_free) > 0)
-		return;
-
-	CALLBACK_WITH_FAILURE(cb, data);
-
-	g_free(cbd);
-}
-
-static int enable_data_stream(struct ofono_location_reporting *lr)
-{
-	struct ofono_modem *modem;
-	const char *gps_dev;
-	GHashTable *options;
-	GIOChannel *channel;
-	int fd;
-
-	modem = ofono_location_reporting_get_modem(lr);
-	gps_dev = ofono_modem_get_string(modem, "GPS");
-
-	options = g_hash_table_new(g_str_hash, g_str_equal);
-	if (options == NULL)
-		return -1;
-
-	g_hash_table_insert(options, "Baud", "115200");
-
-	channel = g_at_tty_open(gps_dev, options);
-
-	g_hash_table_destroy(options);
-
-	if (channel == NULL)
-		return -1;
-
-	fd = g_io_channel_unix_get_fd(channel);
-
-	g_io_channel_set_close_on_unref(channel, FALSE);
-	g_io_channel_unref(channel);
-
-	return fd;
-}
-
-static void gemalto_sgpsc_cb(gboolean ok, GAtResult *result,
-					gpointer user_data)
-{
-	struct cb_data *cbd = user_data;
-	ofono_location_reporting_enable_cb_t cb = cbd->cb;
-	struct ofono_location_reporting *lr = cbd->user;
-	struct ofono_error error;
-	int fd;
-
-	DBG("lr=%p ok=%d", lr, ok);
-
-	decode_at_error(&error, g_at_result_final_response(result));
-
-	if (!ok) {
-		cb(&error, -1, cbd->data);
-
-		return;
-	}
-
-	fd = enable_data_stream(lr);
-
-	if (fd < 0) {
-		CALLBACK_WITH_FAILURE(cb, -1, cbd->data);
-
-		return;
-	}
-
-	cb(&error, fd, cbd->data);
-	close(fd);
-}
-
-static void gemalto_location_reporting_enable(struct ofono_location_reporting *lr,
-					ofono_location_reporting_enable_cb_t cb,
-					void *data)
-{
-	struct gps_data *gd = ofono_location_reporting_get_data(lr);
-	struct cb_data *cbd = cb_data_new(cb, data);
-
-	DBG("lr=%p", lr);
-
-	cbd->user = lr;
-
-	if (g_at_chat_send(gd->chat, "AT^SGPSC=\"Engine\",2", sgpsc_prefix,
-				gemalto_sgpsc_cb, cbd, NULL) > 0)
-		return;
-
-	CALLBACK_WITH_FAILURE(cb, -1, cbd->data);
-	g_free(cbd);
-}
-
-static void gemalto_location_reporting_support_cb(gboolean ok, GAtResult *result,
-							gpointer user_data)
-{
-	struct ofono_location_reporting *lr = user_data;
-
-	if (!ok) {
-		ofono_location_reporting_remove(lr);
-
-		return;
-	}
-
-	ofono_location_reporting_register(lr);
-}
-
-static int gemalto_location_reporting_probe(struct ofono_location_reporting *lr,
-						unsigned int vendor, void *data)
-{
-	GAtChat *chat = data;
-	struct gps_data *gd;
-
-	gd = g_try_new0(struct gps_data, 1);
-	if (gd == NULL)
-		return -ENOMEM;
-
-	gd->chat = g_at_chat_clone(chat);
-
-	ofono_location_reporting_set_data(lr, gd);
-
-	g_at_chat_send(gd->chat, "AT^SGPSC=?", sgpsc_prefix,
-					gemalto_location_reporting_support_cb,
-					lr, NULL);
-
-	return 0;
-}
-
-static void gemalto_location_reporting_remove(struct ofono_location_reporting *lr)
-{
-	struct gps_data *gd = ofono_location_reporting_get_data(lr);
-
-	ofono_location_reporting_set_data(lr, NULL);
-
-	g_at_chat_unref(gd->chat);
-	g_free(gd);
-}
-
-static struct ofono_location_reporting_driver driver = {
-	.name			= "gemaltomodem",
-	.type			= OFONO_LOCATION_REPORTING_TYPE_NMEA,
-	.probe			= gemalto_location_reporting_probe,
-	.remove			= gemalto_location_reporting_remove,
-	.enable			= gemalto_location_reporting_enable,
-	.disable		= gemalto_location_reporting_disable,
-};
-
-void gemalto_location_reporting_init()
-{
-	ofono_location_reporting_driver_register(&driver);
-}
-
-void gemalto_location_reporting_exit()
-{
-	ofono_location_reporting_driver_unregister(&driver);
-}

ofono/drivers/huaweimodem/radio-settings.c

@@ -42,13 +42,11 @@
 
 static const char *none_prefix[] = { NULL };
 static const char *syscfg_prefix[] = { "^SYSCFG:", NULL };
-static const char *syscfgex_prefix[] = { "^SYSCFGEX:", NULL };
 
 #define HUAWEI_BAND_ANY 0x3FFFFFFF
 
 struct radio_settings_data {
 	GAtChat *chat;
-	ofono_bool_t syscfgex_cap;
 };
 
 static const struct huawei_band_gsm_table {
@@ -178,76 +176,20 @@ error:
 	CALLBACK_WITH_FAILURE(cb, -1, cbd->data);
 }
 
-static void syscfgex_query_mode_cb(gboolean ok, GAtResult *result,
-					gpointer user_data)
-{
-	struct cb_data *cbd = user_data;
-	ofono_radio_settings_rat_mode_query_cb_t cb = cbd->cb;
-	enum ofono_radio_access_mode mode;
-	struct ofono_error error;
-	GAtResultIter iter;
-	const char *acqorder;
-
-	decode_at_error(&error, g_at_result_final_response(result));
-
-	if (!ok) {
-		cb(&error, -1, cbd->data);
-		return;
-	}
-
-	g_at_result_iter_init(&iter, result);
-
-	if (g_at_result_iter_next(&iter, "^SYSCFGEX:") == FALSE)
-		goto error;
-
-	if (g_at_result_iter_next_string(&iter, &acqorder) == FALSE)
-		goto error;
-
-	if ((strcmp(acqorder, "00") == 0) ||
-			(strstr(acqorder, "01") &&
-				strstr(acqorder, "02") &&
-				strstr(acqorder, "03")))
-		mode = OFONO_RADIO_ACCESS_MODE_ANY;
-	else if (strstr(acqorder, "03"))
-		mode = OFONO_RADIO_ACCESS_MODE_LTE;
-	else if (strstr(acqorder, "02"))
-		mode = OFONO_RADIO_ACCESS_MODE_UMTS;
-	else if (strstr(acqorder, "01"))
-		mode = OFONO_RADIO_ACCESS_MODE_GSM;
-	else
-		goto error;
-
-	cb(&error, mode, cbd->data);
-
-	return;
-
-error:
-	CALLBACK_WITH_FAILURE(cb, -1, cbd->data);
-}
-
 static void huawei_query_rat_mode(struct ofono_radio_settings *rs,
 			ofono_radio_settings_rat_mode_query_cb_t cb, void *data)
 {
 	struct radio_settings_data *rsd = ofono_radio_settings_get_data(rs);
 	struct cb_data *cbd = cb_data_new(cb, data);
 
-	if (rsd->syscfgex_cap && g_at_chat_send(rsd->chat, "AT^SYSCFGEX?",
-					syscfgex_prefix,
-					syscfgex_query_mode_cb,
-					cbd, g_free) > 0)
-		return;
-
-	if (!rsd->syscfgex_cap && g_at_chat_send(rsd->chat, "AT^SYSCFG?",
-					syscfg_prefix,
-					syscfg_query_mode_cb,
-					cbd, g_free) > 0)
-		return;
-
-	CALLBACK_WITH_FAILURE(cb, -1, data);
-	g_free(cbd);
+	if (g_at_chat_send(rsd->chat, "AT^SYSCFG?", syscfg_prefix,
+				syscfg_query_mode_cb, cbd, g_free) == 0) {
+		CALLBACK_WITH_FAILURE(cb, -1, data);
+		g_free(cbd);
+	}
 }
 
-static void syscfgxx_modify_mode_cb(gboolean ok, GAtResult *result,
+static void syscfg_modify_mode_cb(gboolean ok, GAtResult *result,
 							gpointer user_data)
 {
 	struct cb_data *cbd = user_data;
@@ -258,11 +200,12 @@ static void syscfgxx_modify_mode_cb(gboolean ok, GAtResult *result,
 	cb(&error, cbd->data);
 }
 
-static void syscfg_set_rat_mode(struct radio_settings_data *rsd,
+static void huawei_set_rat_mode(struct ofono_radio_settings *rs,
 				enum ofono_radio_access_mode mode,
 				ofono_radio_settings_rat_mode_set_cb_t cb,
 				void *data)
 {
+	struct radio_settings_data *rsd = ofono_radio_settings_get_data(rs);
 	struct cb_data *cbd = cb_data_new(cb, data);
 	char buf[40];
 	unsigned int value = 2, acq_order = 0;
@@ -288,7 +231,7 @@ static void syscfg_set_rat_mode(struct radio_settings_data *rsd,
 							value, acq_order);
 
 	if (g_at_chat_send(rsd->chat, buf, none_prefix,
-				syscfgxx_modify_mode_cb, cbd, g_free) > 0)
+					syscfg_modify_mode_cb, cbd, g_free) > 0)
 		return;
 
 error:
@@ -296,55 +239,7 @@ error:
 	g_free(cbd);
 }
 
-static void syscfgex_set_rat_mode(struct radio_settings_data *rsd,
-				enum ofono_radio_access_mode mode,
-				ofono_radio_settings_rat_mode_set_cb_t cb,
-				void *data)
-{
-	struct cb_data *cbd = cb_data_new(cb, data);
-	char buf[50];
-	char *atcmd = "AT^SYSCFGEX=\"%s\",40000000,2,4,40000000,,";
-	char *acqorder = "030201";
-
-	switch (mode) {
-	case OFONO_RADIO_ACCESS_MODE_ANY:
-		acqorder = "00";
-		break;
-	case OFONO_RADIO_ACCESS_MODE_GSM:
-		acqorder = "01";
-		break;
-	case OFONO_RADIO_ACCESS_MODE_UMTS:
-		acqorder = "02";
-		break;
-	case OFONO_RADIO_ACCESS_MODE_LTE:
-		acqorder = "03";
-		break;
-	}
-
-	snprintf(buf, sizeof(buf), atcmd, acqorder);
-
-	if (g_at_chat_send(rsd->chat, buf, none_prefix,
-			syscfgxx_modify_mode_cb, cbd, g_free) > 0)
-		return;
-
-	CALLBACK_WITH_FAILURE(cb, data);
-	g_free(cbd);
-}
-
-static void huawei_set_rat_mode(struct ofono_radio_settings *rs,
-				enum ofono_radio_access_mode mode,
-				ofono_radio_settings_rat_mode_set_cb_t cb,
-				void *data)
-{
-	struct radio_settings_data *rsd = ofono_radio_settings_get_data(rs);
-
-	if (rsd->syscfgex_cap)
-		syscfgex_set_rat_mode(rsd, mode, cb, data);
-	else
-		syscfg_set_rat_mode(rsd, mode, cb, data);
-}
-
-static void syscfgxx_modify_band_cb(gboolean ok, GAtResult *result,
+static void syscfg_modify_band_cb(gboolean ok, GAtResult *result,
 							gpointer user_data)
 {
 	struct cb_data *cbd = user_data;
@@ -355,54 +250,13 @@ static void syscfgxx_modify_band_cb(gboolean ok, GAtResult *result,
 	cb(&error, cbd->data);
 }
 
-static void syscfgex_set_band(struct radio_settings_data *rsd,
-					enum ofono_radio_band_gsm band_gsm,
-					enum ofono_radio_band_umts band_umts,
-					ofono_radio_settings_band_set_cb_t cb,
-					void *data)
-{
-	struct cb_data *cbd = cb_data_new(cb, data);
-	char buf[50];
-	char *atcmd = "AT^SYSCFGEX=\"99\",%x,2,4,40000000,,";
-	unsigned int huawei_band;
-
-	if (band_gsm == OFONO_RADIO_BAND_GSM_ANY
-			&& band_umts == OFONO_RADIO_BAND_UMTS_ANY) {
-		huawei_band = HUAWEI_BAND_ANY;
-	} else {
-		unsigned int huawei_band_gsm;
-		unsigned int huawei_band_umts;
-
-		huawei_band_gsm = band_gsm_to_huawei(band_gsm);
-
-		if (!huawei_band_gsm)
-			goto error;
-
-		huawei_band_umts = band_umts_to_huawei(band_umts);
-
-		if (!huawei_band_umts)
-			goto error;
-
-		huawei_band = huawei_band_gsm | huawei_band_umts;
-	}
-
-	snprintf(buf, sizeof(buf), atcmd, huawei_band);
-
-	if (g_at_chat_send(rsd->chat, buf, none_prefix,
-			syscfgxx_modify_band_cb, cbd, g_free) > 0)
-		return;
-
-error:
-	CALLBACK_WITH_FAILURE(cb, data);
-	g_free(cbd);
-}
-
-static void syscfg_set_band(struct radio_settings_data *rsd,
+static void huawei_set_band(struct ofono_radio_settings *rs,
 					enum ofono_radio_band_gsm band_gsm,
 					enum ofono_radio_band_umts band_umts,
 					ofono_radio_settings_band_set_cb_t cb,
 					void *data)
 {
+	struct radio_settings_data *rsd = ofono_radio_settings_get_data(rs);
 	struct cb_data *cbd = cb_data_new(cb, data);
 	char buf[40];
 	unsigned int huawei_band;
@@ -430,7 +284,7 @@ static void syscfg_set_band(struct radio_settings_data *rsd,
 	snprintf(buf, sizeof(buf), "AT^SYSCFG=16,3,%x,2,4", huawei_band);
 
 	if (g_at_chat_send(rsd->chat, buf, none_prefix,
-				syscfgxx_modify_band_cb, cbd, g_free) > 0)
+					syscfg_modify_band_cb, cbd, g_free) > 0)
 		return;
 
 error:
@@ -438,20 +292,6 @@ error:
 	g_free(cbd);
 }
 
-static void huawei_set_band(struct ofono_radio_settings *rs,
-					enum ofono_radio_band_gsm band_gsm,
-					enum ofono_radio_band_umts band_umts,
-					ofono_radio_settings_band_set_cb_t cb,
-					void *data)
-{
-	struct radio_settings_data *rsd = ofono_radio_settings_get_data(rs);
-
-	if (rsd->syscfgex_cap)
-		syscfgex_set_band(rsd, band_gsm, band_umts, cb, data);
-	else
-		syscfg_set_band(rsd, band_gsm, band_umts, cb, data);
-}
-
 static void syscfg_query_band_cb(gboolean ok, GAtResult *result,
 					gpointer user_data)
 {
@@ -524,21 +364,6 @@ static void syscfg_support_cb(gboolean ok, GAtResult *result,
 	ofono_radio_settings_register(rs);
 }
 
-static void syscfgex_support_cb(gboolean ok, GAtResult *result,
-				gpointer user_data)
-{
-	struct ofono_radio_settings *rs = user_data;
-	struct radio_settings_data *rsd = ofono_radio_settings_get_data(rs);
-
-	if (!ok) {
-		g_at_chat_send(rsd->chat, "AT^SYSCFG=?", syscfg_prefix,
-					syscfg_support_cb, rs, NULL);
-	}
-
-	rsd->syscfgex_cap = 1;
-	ofono_radio_settings_register(rs);
-}
-
 static int huawei_radio_settings_probe(struct ofono_radio_settings *rs,
 					unsigned int vendor, void *data)
 {
@@ -553,8 +378,8 @@ static int huawei_radio_settings_probe(struct ofono_radio_settings *rs,
 
 	ofono_radio_settings_set_data(rs, rsd);
 
-	g_at_chat_send(rsd->chat, "AT^SYSCFGEX=?", syscfgex_prefix,
-					syscfgex_support_cb, rs, NULL);
+	g_at_chat_send(rsd->chat, "AT^SYSCFG=?", syscfg_prefix,
+					syscfg_support_cb, rs, NULL);
 
 	return 0;
 }
@@ -575,8 +400,8 @@ static struct ofono_radio_settings_driver driver = {
 	.remove			= huawei_radio_settings_remove,
 	.query_rat_mode		= huawei_query_rat_mode,
 	.set_rat_mode		= huawei_set_rat_mode,
-	.query_band		= huawei_query_band,
-	.set_band		= huawei_set_band,
+	.query_band             = huawei_query_band,
+	.set_band               = huawei_set_band,
 };
 
 void huawei_radio_settings_init(void)

ofono/drivers/ifxmodem/gprs-context.c

@@ -42,14 +42,13 @@
 
 #include "ifxmodem.h"
 
-#define TUN_DEV "/dev/net/tun"
+#define TUN_SYSFS_DIR "/sys/devices/virtual/misc/tun"
 
 #define STATIC_IP_NETMASK "255.255.255.255"
 
 static const char *none_prefix[] = { NULL };
 static const char *xdns_prefix[] = { "+XDNS:", NULL };
 static const char *cgpaddr_prefix[] = { "+CGPADDR:", NULL };
-static const char *cgcontrdp_prefix[] = { "+CGCONTRDP:", NULL };
 
 enum state {
 	STATE_IDLE,
@@ -60,20 +59,17 @@ enum state {
 
 struct gprs_context_data {
 	GAtChat *chat;
-	unsigned int vendor;
 	unsigned int active_context;
 	char username[OFONO_GPRS_MAX_USERNAME_LENGTH + 1];
 	char password[OFONO_GPRS_MAX_PASSWORD_LENGTH + 1];
 	GAtRawIP *rawip;
 	enum state state;
 	enum ofono_gprs_proto proto;
-	char address[64];
-	char gateway[64];
-	char netmask[64];
-	char dns1[64];
-	char dns2[64];
+	char address[32];
+	char dns1[32];
+	char dns2[32];
 	ofono_gprs_context_cb_t cb;
-	void *cb_data;
+	void *cb_data;                                  /* Callback data */
 };
 
 static void rawip_debug(const char *str, void *data)
@@ -261,136 +257,11 @@ error:
 	failed_setup(gc, NULL, TRUE);
 }
 
-static void cgcontrdp_cb(gboolean ok, GAtResult *result, gpointer user_data)
-{
-	struct ofono_gprs_context *gc = user_data;
-	struct ofono_modem *modem = ofono_gprs_context_get_modem(gc);
-	struct gprs_context_data *gcd = ofono_gprs_context_get_data(gc);
-	GAtResultIter iter;
-
-	const char *laddrnetmask = NULL;
-	const char *gw = NULL;
-	const char *interface;
-	const char *dns[3];
-
-	DBG("ok %d", ok);
-
-	if (!ok) {
-		struct ofono_error error;
-
-		decode_at_error(&error, g_at_result_final_response(result));
-		gcd->cb(&error, gcd->cb_data);
-
-		return;
-	}
-
-	g_at_result_iter_init(&iter, result);
-
-	while (g_at_result_iter_next(&iter, "+CGCONTRDP:")) {
-		/* skip cid, bearer_id, apn */
-		g_at_result_iter_skip_next(&iter);
-		g_at_result_iter_skip_next(&iter);
-		g_at_result_iter_skip_next(&iter);
-
-		if (!g_at_result_iter_next_string(&iter, &laddrnetmask))
-			break;
-
-		if (!g_at_result_iter_next_string(&iter, &gw))
-			break;
-
-		if (!g_at_result_iter_next_string(&iter, &dns[0]))
-			break;
-
-		if (!g_at_result_iter_next_string(&iter, &dns[1]))
-			break;
-	}
-
-	strncpy(gcd->dns1, dns[0], sizeof(gcd->dns1));
-	strncpy(gcd->dns2, dns[1], sizeof(gcd->dns2));
-	dns[2] = 0;
-
-	DBG("DNS: %s, %s\n", gcd->dns1, gcd->dns2);
-
-	if (!laddrnetmask || at_util_get_ipv4_address_and_netmask(laddrnetmask,
-					gcd->address, gcd->netmask) < 0) {
-		failed_setup(gc, NULL, TRUE);
-		return;
-	}
-
-	if (gw)
-		strncpy(gcd->gateway, gw, sizeof(gcd->gateway));
-
-	gcd->state = STATE_ACTIVE;
-
-	DBG("address: %s\n", gcd->address);
-	DBG("netmask: %s\n", gcd->netmask);
-	DBG("DNS1: %s\n", gcd->dns1);
-	DBG("DNS2: %s\n", gcd->dns2);
-	DBG("Gateway: %s\n", gcd->gateway);
-
-	interface = ofono_modem_get_string(modem, "NetworkInterface");
-
-	ofono_gprs_context_set_interface(gc, interface);
-	ofono_gprs_context_set_ipv4_address(gc, gcd->address, TRUE);
-
-	if (gcd->netmask[0])
-		ofono_gprs_context_set_ipv4_netmask(gc, gcd->netmask);
-
-	if (gcd->gateway[0])
-		ofono_gprs_context_set_ipv4_gateway(gc, gcd->gateway);
-
-	ofono_gprs_context_set_ipv4_dns_servers(gc, dns);
-
-	CALLBACK_WITH_SUCCESS(gcd->cb, gcd->cb_data);
-}
-
-static void ifx_read_settings(struct ofono_gprs_context *gc)
-{
-	struct gprs_context_data *gcd = ofono_gprs_context_get_data(gc);
-	char buf[64];
-
-	gcd->address[0] = '\0';
-	gcd->gateway[0] = '\0';
-	gcd->netmask[0] = '\0';
-	gcd->dns1[0] = '\0';
-	gcd->dns2[0] = '\0';
-
-	/* read IP configuration info */
-	if(gcd->vendor == OFONO_VENDOR_XMM) {
-		snprintf(buf, sizeof(buf), "AT+CGCONTRDP=%u",
-							gcd->active_context);
-
-		if (g_at_chat_send(gcd->chat, buf, cgcontrdp_prefix,
-					cgcontrdp_cb, gc, NULL) > 0)
-			return;
-	} else {
-		sprintf(buf, "AT+CGPADDR=%u", gcd->active_context);
-
-		if (g_at_chat_send(gcd->chat, buf, cgpaddr_prefix,
-						address_cb, gc, NULL) > 0)
-			return;
-	}
-
-	failed_setup(gc, NULL, TRUE);
-}
-
-static void ifx_gprs_read_settings(struct ofono_gprs_context *gc,
-					unsigned int cid,
-					ofono_gprs_context_cb_t cb, void *data)
-{
-	struct gprs_context_data *gcd = ofono_gprs_context_get_data(gc);
-	DBG("cid %u", cid);
-
-	gcd->active_context = cid;
-	gcd->cb = cb;
-	gcd->cb_data = data;
-
-	ifx_read_settings(gc);
-}
-
 static void activate_cb(gboolean ok, GAtResult *result, gpointer user_data)
 {
 	struct ofono_gprs_context *gc = user_data;
+	struct gprs_context_data *gcd = ofono_gprs_context_get_data(gc);
+	char buf[64];
 
 	DBG("ok %d", ok);
 
@@ -400,14 +271,19 @@ static void activate_cb(gboolean ok, GAtResult *result, gpointer user_data)
 		return;
 	}
 
-	ifx_read_settings(gc);
+	sprintf(buf, "AT+CGPADDR=%u", gcd->active_context);
+	if (g_at_chat_send(gcd->chat, buf, cgpaddr_prefix,
+					address_cb, gc, NULL) > 0)
+		return;
+
+	failed_setup(gc, NULL, TRUE);
 }
 
 static void setup_cb(gboolean ok, GAtResult *result, gpointer user_data)
 {
 	struct ofono_gprs_context *gc = user_data;
 	struct gprs_context_data *gcd = ofono_gprs_context_get_data(gc);
-	char buf[384];
+	char buf[128];
 
 	DBG("ok %d", ok);
 
@@ -511,8 +387,7 @@ static void deactivate_cb(gboolean ok, GAtResult *result, gpointer user_data)
 	gcd->active_context = 0;
 	gcd->state = STATE_IDLE;
 
-	if (gcd->vendor != OFONO_VENDOR_XMM)
-		g_at_chat_resume(gcd->chat);
+	g_at_chat_resume(gcd->chat);
 
 	CALLBACK_WITH_SUCCESS(gcd->cb, gcd->cb_data);
 }
@@ -534,25 +409,11 @@ static void ifx_gprs_deactivate_primary(struct ofono_gprs_context *gc,
 	g_at_rawip_shutdown(gcd->rawip);
 
 	sprintf(buf, "AT+CGACT=0,%u", gcd->active_context);
-
-	if (gcd->vendor == OFONO_VENDOR_XMM) {
-		if (g_at_chat_send(gcd->chat, buf, none_prefix,
+	if (g_at_chat_send(chat, buf, none_prefix,
 				deactivate_cb, gc, NULL) > 0)
-			return;
-	} else {
-		if (g_at_chat_send(chat, buf, none_prefix,
-				deactivate_cb, gc, NULL) > 0)
-			return;
-	}
+		return;
 
-	CALLBACK_WITH_FAILURE(cb, data);
-}
-
-static void ifx_gprs_detach_shutdown(struct ofono_gprs_context *gc,
-						unsigned int cid)
-{
-	DBG("");
-	ifx_gprs_deactivate_primary(gc, cid, NULL, NULL);
+	CALLBACK_WITH_SUCCESS(cb, data);
 }
 
 static void cgev_notify(GAtResult *result, gpointer user_data)
@@ -590,13 +451,14 @@ static void cgev_notify(GAtResult *result, gpointer user_data)
 
 		g_at_rawip_unref(gcd->rawip);
 		gcd->rawip = NULL;
-		g_at_chat_resume(gcd->chat);
 	}
 
 	ofono_gprs_context_deactivated(gc, gcd->active_context);
 
 	gcd->active_context = 0;
 	gcd->state = STATE_IDLE;
+
+	g_at_chat_resume(gcd->chat);
 }
 
 static int ifx_gprs_context_probe(struct ofono_gprs_context *gc,
@@ -608,27 +470,23 @@ static int ifx_gprs_context_probe(struct ofono_gprs_context *gc,
 
 	DBG("");
 
-	if (stat(TUN_DEV, &st) < 0) {
+	if (stat(TUN_SYSFS_DIR, &st) < 0) {
 		ofono_error("Missing support for TUN/TAP devices");
 		return -ENODEV;
 	}
 
-	if (vendor != OFONO_VENDOR_XMM) {
-		if (g_at_chat_get_slave(chat) == NULL)
-			return -EINVAL;
-	}
+	if (g_at_chat_get_slave(chat) == NULL)
+		return -EINVAL;
 
 	gcd = g_try_new0(struct gprs_context_data, 1);
 	if (gcd == NULL)
 		return -ENOMEM;
 
-	gcd->vendor = vendor;
 	gcd->chat = g_at_chat_clone(chat);
 
 	ofono_gprs_context_set_data(gc, gcd);
 
-	if (vendor != OFONO_VENDOR_XMM)
-		chat = g_at_chat_get_slave(gcd->chat);
+	chat = g_at_chat_get_slave(gcd->chat);
 
 	g_at_chat_register(chat, "+CGEV:", cgev_notify, FALSE, gc, NULL);
 
@@ -658,8 +516,6 @@ static struct ofono_gprs_context_driver driver = {
 	.remove			= ifx_gprs_context_remove,
 	.activate_primary	= ifx_gprs_activate_primary,
 	.deactivate_primary	= ifx_gprs_deactivate_primary,
-	.read_settings		= ifx_gprs_read_settings,
-	.detach_shutdown	= ifx_gprs_detach_shutdown
 };
 
 void ifx_gprs_context_init(void)

ofono/drivers/ifxmodem/ifxmodem.h

@@ -20,7 +20,6 @@
  */
 
 #include <drivers/atmodem/atutil.h>
-#include <drivers/atmodem/vendor.h>
 
 extern void ifx_voicecall_init(void);
 extern void ifx_voicecall_exit(void);

ofono/drivers/isimodem/sim.c

@@ -646,31 +646,8 @@ error:
 /* ISI callback: PIN state (enabled/disabled) query */
 static void sec_code_state_resp_cb(const GIsiMessage *msg, void *opaque)
 {
-	struct isi_cb_data *cbd = opaque;
-	ofono_query_facility_lock_cb_t cb = cbd->cb;
-	int locked;
-	uint8_t state;
-	uint8_t status;
-
-	if (!g_isi_msg_data_get_byte(msg, 0, &state) ||
-			!g_isi_msg_data_get_byte(msg, 1, &status))
-		goto error;
-
-	if (state != SEC_CODE_STATE_OK_RESP)
-		goto error;
-
-	if (status == SEC_CODE_ENABLE)
-		locked = 1;
-	else if (status == SEC_CODE_DISABLE)
-		locked = 0;
-	else
-		goto error;
-
-	CALLBACK_WITH_SUCCESS(cb, locked, cbd->data);
-	return;
-
-error:
-	CALLBACK_WITH_FAILURE(cb, -1, cbd->data);
+	check_sec_response(msg, opaque, SEC_CODE_STATE_OK_RESP,
+				SEC_CODE_STATE_FAIL_RESP);
 }
 
 static void isi_query_locked(struct ofono_sim *sim,

ofono/drivers/qmimodem/devinfo.c

@@ -23,8 +23,6 @@
 #include <config.h>
 #endif
 
-#include <string.h>
-
 #include <ofono/log.h>
 #include <ofono/modem.h>
 #include <ofono/devinfo.h>
@@ -127,8 +125,7 @@ static void get_ids_cb(struct qmi_result *result, void *user_data)
 	}
 
 	str = qmi_result_get_string(result, QMI_DMS_RESULT_ESN);
-	/* Telit qmi modems return a "0" string when ESN is not available. */
-	if (!str || strcmp(str, "0") == 0) {
+	if (!str) {
 		str = qmi_result_get_string(result, QMI_DMS_RESULT_IMEI);
 		if (!str) {
 			CALLBACK_WITH_FAILURE(cb, NULL, cbd->data);

ofono/drivers/qmimodem/gprs-context.c

@@ -24,22 +24,18 @@
 #endif
 
 #include <string.h>
-#include <arpa/inet.h>
 
 #include <ofono/log.h>
 #include <ofono/modem.h>
 #include <ofono/gprs-context.h>
 
 #include "qmi.h"
-#include "wda.h"
 #include "wds.h"
 
 #include "qmimodem.h"
 
 struct gprs_context_data {
 	struct qmi_service *wds;
-	struct qmi_service *wda;
-	struct qmi_device *dev;
 	unsigned int active_context;
 	uint32_t pkt_handle;
 };
@@ -65,12 +61,8 @@ static void pkt_status_notify(struct qmi_result *result, void *user_data)
 
 	switch (status->status) {
 	case QMI_WDS_CONN_STATUS_DISCONNECTED:
-		if (data->pkt_handle) {
-			/* The context has been disconnected by the network */
-			ofono_gprs_context_deactivated(gc, data->active_context);
-			data->pkt_handle = 0;
-			data->active_context = 0;
-		}
+		ofono_gprs_context_deactivated(gc, data->active_context);
+		data->active_context = 0;
 		break;
 	}
 }
@@ -83,68 +75,18 @@ static void get_settings_cb(struct qmi_result *result, void *user_data)
 	struct ofono_modem *modem;
 	const char *interface;
 	uint8_t pdp_type, ip_family;
-	uint32_t ip_addr;
-	struct in_addr addr;
-	char* straddr;
-	char* apn;
-	const char *dns[3] = { NULL, NULL, NULL };
 
 	DBG("");
 
 	if (qmi_result_set_error(result, NULL))
 		goto done;
 
-	apn = qmi_result_get_string(result, QMI_WDS_RESULT_APN);
-	if (apn) {
-		DBG("APN: %s", apn);
-		g_free(apn);
-	}
-
 	if (qmi_result_get_uint8(result, QMI_WDS_RESULT_PDP_TYPE, &pdp_type))
 		DBG("PDP type %d", pdp_type);
 
 	if (qmi_result_get_uint8(result, QMI_WDS_RESULT_IP_FAMILY, &ip_family))
 		DBG("IP family %d", ip_family);
 
-	if (qmi_result_get_uint32(result,QMI_WDS_RESULT_IP_ADDRESS, &ip_addr)) {
-		addr.s_addr = htonl(ip_addr);
-		straddr = inet_ntoa(addr);
-		DBG("IP addr: %s", straddr);
-		ofono_gprs_context_set_ipv4_address(gc, straddr, 1);
-	}
-
-	if (qmi_result_get_uint32(result,QMI_WDS_RESULT_GATEWAY, &ip_addr)) {
-		addr.s_addr = htonl(ip_addr);
-		straddr = inet_ntoa(addr);
-		DBG("Gateway: %s", straddr);
-		ofono_gprs_context_set_ipv4_gateway(gc, straddr);
-	}
-
-	if (qmi_result_get_uint32(result,
-				QMI_WDS_RESULT_GATEWAY_NETMASK, &ip_addr)) {
-		addr.s_addr = htonl(ip_addr);
-		straddr = inet_ntoa(addr);
-		DBG("Gateway netmask: %s", straddr);
-		ofono_gprs_context_set_ipv4_netmask(gc, straddr);
-	}
-
-	if (qmi_result_get_uint32(result,
-				QMI_WDS_RESULT_PRIMARY_DNS, &ip_addr)) {
-		addr.s_addr = htonl(ip_addr);
-		dns[0] = inet_ntoa(addr);
-		DBG("Primary DNS: %s", dns[0]);
-	}
-
-	if (qmi_result_get_uint32(result,
-				QMI_WDS_RESULT_SECONDARY_DNS, &ip_addr)) {
-		addr.s_addr = htonl(ip_addr);
-		dns[1] = inet_ntoa(addr);
-		DBG("Secondary DNS: %s", dns[1]);
-	}
-
-	if (dns[0])
-		ofono_gprs_context_set_ipv4_dns_servers(gc, dns);
-
 done:
 	modem = ofono_gprs_context_get_modem(gc);
 	interface = ofono_modem_get_string(modem, "NetworkInterface");
@@ -152,6 +94,8 @@ done:
 	ofono_gprs_context_set_interface(gc, interface);
 
 	CALLBACK_WITH_SUCCESS(cb, cbd->data);
+
+	g_free(cbd);
 }
 
 static void start_net_cb(struct qmi_result *result, void *user_data)
@@ -176,12 +120,8 @@ static void start_net_cb(struct qmi_result *result, void *user_data)
 
 	data->pkt_handle = handle;
 
-	/* Duplicate cbd, the old one will be freed when this method returns */
-	cbd = cb_data_new(cb, cbd->data);
-	cbd->user = gc;
-
 	if (qmi_service_send(data->wds, QMI_WDS_GET_SETTINGS, NULL,
-					get_settings_cb, cbd, g_free) > 0)
+					get_settings_cb, cbd, NULL) > 0)
 		return;
 
 	modem = ofono_gprs_context_get_modem(gc);
@@ -191,39 +131,12 @@ static void start_net_cb(struct qmi_result *result, void *user_data)
 
 	CALLBACK_WITH_SUCCESS(cb, cbd->data);
 
+	g_free(cbd);
+
 	return;
 
 error:
 	data->active_context = 0;
-	CALLBACK_WITH_FAILURE(cb, cbd->data);
-}
-
-/*
- * This function gets called for "automatic" contexts, those which are
- * not activated via activate_primary.  For these, we will still need
- * to call start_net in order to get the packet handle for the context.
- * The process for automatic contexts is essentially identical to that
- * for others.
- */
-static void qmi_gprs_read_settings(struct ofono_gprs_context* gc,
-					unsigned int cid,
-					ofono_gprs_context_cb_t cb,
-					void *user_data)
-{
-	struct gprs_context_data *data = ofono_gprs_context_get_data(gc);
-	struct cb_data *cbd = cb_data_new(cb, user_data);
-
-	DBG("cid %u", cid);
-
-	data->active_context = cid;
-
-	cbd->user = gc;
-
-	if (qmi_service_send(data->wds, QMI_WDS_START_NET, NULL,
-					start_net_cb, cbd, g_free) > 0)
-		return;
-
-	data->active_context = 0;
 
 	CALLBACK_WITH_FAILURE(cb, cbd->data);
 
@@ -238,7 +151,6 @@ static void qmi_activate_primary(struct ofono_gprs_context *gc,
 	struct cb_data *cbd = cb_data_new(cb, user_data);
 	struct qmi_param *param;
 	uint8_t ip_family;
-	uint8_t auth;
 
 	DBG("cid %u", ctx->cid);
 
@@ -266,31 +178,8 @@ static void qmi_activate_primary(struct ofono_gprs_context *gc,
 
 	qmi_param_append_uint8(param, QMI_WDS_PARAM_IP_FAMILY, ip_family);
 
-	switch (ctx->auth_method) {
-	case OFONO_GPRS_AUTH_METHOD_CHAP:
-		auth = QMI_WDS_AUTHENTICATION_CHAP;
-		break;
-	case OFONO_GPRS_AUTH_METHOD_PAP:
-		auth = QMI_WDS_AUTHENTICATION_PAP;
-		break;
-	default:
-		auth = QMI_WDS_AUTHENTICATION_NONE;
-		break;
-	}
-
-	qmi_param_append_uint8(param, QMI_WDS_PARAM_AUTHENTICATION_PREFERENCE,
-					auth);
-
-	if (ctx->username[0] != '\0')
-		qmi_param_append(param, QMI_WDS_PARAM_USERNAME,
-					strlen(ctx->username), ctx->username);
-
-	if (ctx->password[0] != '\0')
-		qmi_param_append(param, QMI_WDS_PARAM_PASSWORD,
-					strlen(ctx->password), ctx->password);
-
 	if (qmi_service_send(data->wds, QMI_WDS_START_NET, param,
-					start_net_cb, cbd, g_free) > 0)
+					start_net_cb, cbd, NULL) > 0)
 		return;
 
 	qmi_param_free(param);
@@ -313,19 +202,17 @@ static void stop_net_cb(struct qmi_result *result, void *user_data)
 	DBG("");
 
 	if (qmi_result_set_error(result, NULL)) {
-		if (cb)
-			CALLBACK_WITH_FAILURE(cb, cbd->data);
+		CALLBACK_WITH_FAILURE(cb, cbd->data);
 		return;
 	}
 
+	data->active_context = 0;
+
 	data->pkt_handle = 0;
 
-	if (cb)
-		CALLBACK_WITH_SUCCESS(cb, cbd->data);
-	else
-		ofono_gprs_context_deactivated(gc, data->active_context);
+	CALLBACK_WITH_SUCCESS(cb, cbd->data);
 
-	data->active_context = 0;
+	g_free(cbd);
 }
 
 static void qmi_deactivate_primary(struct ofono_gprs_context *gc,
@@ -346,26 +233,17 @@ static void qmi_deactivate_primary(struct ofono_gprs_context *gc,
 		goto error;
 
 	if (qmi_service_send(data->wds, QMI_WDS_STOP_NET, param,
-					stop_net_cb, cbd, g_free) > 0)
+					stop_net_cb, cbd, NULL) > 0)
 		return;
 
 	qmi_param_free(param);
 
 error:
-	if (cb)
-		CALLBACK_WITH_FAILURE(cb, user_data);
+	CALLBACK_WITH_FAILURE(cb, cbd->data);
 
 	g_free(cbd);
 }
 
-static void qmi_gprs_context_detach_shutdown(struct ofono_gprs_context *gc,
-						unsigned int cid)
-{
-	DBG("");
-
-	qmi_deactivate_primary(gc, cid, NULL, NULL);
-}
-
 static void create_wds_cb(struct qmi_service *service, void *user_data)
 {
 	struct ofono_gprs_context *gc = user_data;
@@ -385,69 +263,6 @@ static void create_wds_cb(struct qmi_service *service, void *user_data)
 					pkt_status_notify, gc, NULL);
 }
 
-static void get_data_format_cb(struct qmi_result *result, void *user_data)
-{
-	struct ofono_gprs_context *gc = user_data;
-	struct gprs_context_data *data = ofono_gprs_context_get_data(gc);
-	uint32_t llproto;
-	enum qmi_device_expected_data_format expected_llproto;
-
-	DBG("");
-
-	if (qmi_result_set_error(result, NULL))
-		goto done;
-
-	if (!qmi_result_get_uint32(result, QMI_WDA_LL_PROTOCOL, &llproto))
-		goto done;
-
-	expected_llproto = qmi_device_get_expected_data_format(data->dev);
-
-	if ((llproto == QMI_WDA_DATA_LINK_PROTOCOL_802_3) &&
-			(expected_llproto ==
-				QMI_DEVICE_EXPECTED_DATA_FORMAT_RAW_IP)) {
-		if (!qmi_device_set_expected_data_format(data->dev,
-					QMI_DEVICE_EXPECTED_DATA_FORMAT_802_3))
-			DBG("Fail to set expected data to 802.3");
-		else
-			DBG("expected data set to 802.3");
-	} else if ((llproto == QMI_WDA_DATA_LINK_PROTOCOL_RAW_IP) &&
-			(expected_llproto ==
-				QMI_DEVICE_EXPECTED_DATA_FORMAT_802_3)) {
-		if (!qmi_device_set_expected_data_format(data->dev,
-					QMI_DEVICE_EXPECTED_DATA_FORMAT_RAW_IP))
-			DBG("Fail to set expected data to raw-ip");
-		else
-			DBG("expected data set to raw-ip");
-	}
-
-done:
-	qmi_service_create_shared(data->dev, QMI_SERVICE_WDS, create_wds_cb, gc,
-									NULL);
-}
-
-static void create_wda_cb(struct qmi_service *service, void *user_data)
-{
-	struct ofono_gprs_context *gc = user_data;
-	struct gprs_context_data *data = ofono_gprs_context_get_data(gc);
-
-	DBG("");
-
-	if (!service) {
-		DBG("Failed to request WDA service, continue initialization");
-		goto error;
-	}
-
-	data->wda = qmi_service_ref(service);
-
-	if (qmi_service_send(data->wda, QMI_WDA_GET_DATA_FORMAT, NULL,
-					get_data_format_cb, gc, NULL) > 0)
-		return;
-
-error:
-	qmi_service_create_shared(data->dev, QMI_SERVICE_WDS, create_wds_cb, gc,
-									NULL);
-}
-
 static int qmi_gprs_context_probe(struct ofono_gprs_context *gc,
 					unsigned int vendor, void *user_data)
 {
@@ -459,9 +274,8 @@ static int qmi_gprs_context_probe(struct ofono_gprs_context *gc,
 	data = g_new0(struct gprs_context_data, 1);
 
 	ofono_gprs_context_set_data(gc, data);
-	data->dev = device;
 
-	qmi_service_create(device, QMI_SERVICE_WDA, create_wda_cb, gc, NULL);
+	qmi_service_create(device, QMI_SERVICE_WDS, create_wds_cb, gc, NULL);
 
 	return 0;
 }
@@ -474,15 +288,9 @@ static void qmi_gprs_context_remove(struct ofono_gprs_context *gc)
 
 	ofono_gprs_context_set_data(gc, NULL);
 
-	if (data->wds) {
-		qmi_service_unregister_all(data->wds);
-		qmi_service_unref(data->wds);
-	}
+	qmi_service_unregister_all(data->wds);
 
-	if (data->wda) {
-		qmi_service_unregister_all(data->wda);
-		qmi_service_unref(data->wda);
-	}
+	qmi_service_unref(data->wds);
 
 	g_free(data);
 }
@@ -493,8 +301,6 @@ static struct ofono_gprs_context_driver driver = {
 	.remove			= qmi_gprs_context_remove,
 	.activate_primary	= qmi_activate_primary,
 	.deactivate_primary	= qmi_deactivate_primary,
-	.read_settings		= qmi_gprs_read_settings,
-	.detach_shutdown	= qmi_gprs_context_detach_shutdown,
 };
 
 void qmi_gprs_context_init(void)

ofono/drivers/qmimodem/gprs.c

@@ -30,18 +30,16 @@
 #include "qmi.h"
 #include "nas.h"
 
-#include "src/common.h"
 #include "qmimodem.h"
 
 struct gprs_data {
 	struct qmi_service *nas;
 };
 
-static bool extract_ss_info(struct qmi_result *result, int *status, int *tech)
+static bool extract_ss_info(struct qmi_result *result, int *status)
 {
 	const struct qmi_nas_serving_system *ss;
 	uint16_t len;
-	int i;
 
 	DBG("");
 
@@ -49,46 +47,14 @@ static bool extract_ss_info(struct qmi_result *result, int *status, int *tech)
 	if (!ss)
 		return false;
 
-	if (ss->ps_state == QMI_NAS_ATTACH_STATE_ATTACHED)
-		*status = NETWORK_REGISTRATION_STATUS_REGISTERED;
+	if (ss->ps_state == QMI_NAS_ATTACH_STATUS_ATTACHED)
+		*status = 0x01;
 	else
-		*status = NETWORK_REGISTRATION_STATUS_NOT_REGISTERED;
-
-	*tech = -1;
-	for (i = 0; i < ss->radio_if_count; i++) {
-		DBG("radio in use %d", ss->radio_if[i]);
-
-		*tech = qmi_nas_rat_to_tech(ss->radio_if[i]);
-	}
+		*status = 0x00;
 
 	return true;
 }
 
-static int handle_ss_info(struct qmi_result *result, struct ofono_gprs *gprs)
-{
-	int status;
-	int tech;
-
-	DBG("");
-
-	if (!extract_ss_info(result, &status, &tech))
-		return -1;
-
-	if (status == NETWORK_REGISTRATION_STATUS_REGISTERED)
-		if (tech == ACCESS_TECHNOLOGY_EUTRAN) {
-			/* On LTE we are effectively always attached; and
-			 * the default bearer is established as soon as the
-			 * network is joined.
-			 */
-			/* FIXME: query default profile number and APN
-			 * instead of assuming profile 1 and ""
-			 */
-			ofono_gprs_cid_activated(gprs, 1 , "automatic");
-		}
-
-	return status;
-}
-
 static void ss_info_notify(struct qmi_result *result, void *user_data)
 {
 	struct ofono_gprs *gprs = user_data;
@@ -96,10 +62,10 @@ static void ss_info_notify(struct qmi_result *result, void *user_data)
 
 	DBG("");
 
-	status = handle_ss_info(result, gprs);
+	if (!extract_ss_info(result, &status))
+		return;
 
-	if (status >= 0)
-		ofono_gprs_status_notify(gprs, status);
+	ofono_gprs_status_notify(gprs, status);
 }
 
 static void attach_detach_cb(struct qmi_result *result, void *user_data)
@@ -158,26 +124,22 @@ error:
 static void get_ss_info_cb(struct qmi_result *result, void *user_data)
 {
 	struct cb_data *cbd = user_data;
-	struct ofono_gprs *gprs = cbd->user;
 	ofono_gprs_status_cb_t cb = cbd->cb;
 	int status;
 
 	DBG("");
 
-	if (qmi_result_set_error(result, NULL))
-		goto error;
+	if (qmi_result_set_error(result, NULL)) {
+		CALLBACK_WITH_FAILURE(cb, -1, cbd->data);
+		return;
+	}
 
-	status = handle_ss_info(result, gprs);
-
-	if (status < 0)
-		goto error;
+	if (!extract_ss_info(result, &status)) {
+		CALLBACK_WITH_FAILURE(cb, -1, cbd->data);
+		return;
+	}
 
 	CALLBACK_WITH_SUCCESS(cb, status, cbd->data);
-
-	return;
-
-error:
-	CALLBACK_WITH_FAILURE(cb, -1, cbd->data);
 }
 
 static void qmi_attached_status(struct ofono_gprs *gprs,
@@ -188,7 +150,6 @@ static void qmi_attached_status(struct ofono_gprs *gprs,
 
 	DBG("");
 
-	cbd->user = gprs;
 	if (qmi_service_send(data->nas, QMI_NAS_GET_SS_INFO, NULL,
 					get_ss_info_cb, cbd, g_free) > 0)
 		return;
@@ -213,13 +174,6 @@ static void create_nas_cb(struct qmi_service *service, void *user_data)
 
 	data->nas = qmi_service_ref(service);
 
-	/*
-	 * First get the SS info - the modem may already be connected,
-	 * and the state-change notification may never arrive
-	 */
-	qmi_service_send(data->nas, QMI_NAS_GET_SS_INFO, NULL,
-					ss_info_notify, gprs, NULL);
-
 	qmi_service_register(data->nas, QMI_NAS_SS_INFO_IND,
 					ss_info_notify, gprs, NULL);
 
@@ -240,8 +194,7 @@ static int qmi_gprs_probe(struct ofono_gprs *gprs,
 
 	ofono_gprs_set_data(gprs, data);
 
-	qmi_service_create_shared(device, QMI_SERVICE_NAS,
-						create_nas_cb, gprs, NULL);
+	qmi_service_create(device, QMI_SERVICE_NAS, create_nas_cb, gprs, NULL);
 
 	return 0;
 }

ofono/drivers/qmimodem/nas.c

@@ -1,38 +0,0 @@
-/*
- *
- *  oFono - Open Source Telephony
- *
- *  Copyright (C) 2017  Jonas Bonn. All rights reserved.
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
- *
- */
-
-#include "nas.h"
-
-#include "src/common.h"
-
-int qmi_nas_rat_to_tech(uint8_t rat)
-{
-	switch (rat) {
-	case QMI_NAS_NETWORK_RAT_GSM:
-		return ACCESS_TECHNOLOGY_GSM;
-	case QMI_NAS_NETWORK_RAT_UMTS:
-		return ACCESS_TECHNOLOGY_UTRAN;
-	case QMI_NAS_NETWORK_RAT_LTE:
-		return ACCESS_TECHNOLOGY_EUTRAN;
-	}
-
-	return -1;
-}

ofono/drivers/qmimodem/nas.h

@@ -19,8 +19,6 @@
  *
  */
 
-#include <stdint.h>
-
 #define QMI_NAS_RESET			0	/* Reset NAS service state variables */
 #define QMI_NAS_ABORT			1	/* Abort previously issued NAS command */
 #define QMI_NAS_EVENT			2	/* Connection state report indication */
@@ -35,8 +33,6 @@
 #define QMI_NAS_SS_INFO_IND		36	/* Current serving system info indication */
 #define QMI_NAS_GET_HOME_INFO		37	/* Get info about home network */
 
-#define QMI_NAS_SET_SYSTEM_SELECTION_PREF 51
-#define QMI_NAS_GET_SYSTEM_SELECTION_PREF 52
 
 /* Set NAS state report conditions */
 #define QMI_NAS_PARAM_REPORT_SIGNAL_STRENGTH	0x10
@@ -67,7 +63,7 @@ struct qmi_nas_rf_info {
 } __attribute__((__packed__));
 
 /* Get the signal strength */
-#define QMI_NAS_RESULT_SIGNAL_STRENGTH		0x01
+#define QMI_NAS_RESULT_SIGNAL_STRENGTH		0x10
 
 /* Scan for visible network */
 #define QMI_NAS_PARAM_NETWORK_MASK		0x10	/* uint8 bitmask */
@@ -99,7 +95,6 @@ struct qmi_nas_network_rat {
 	} __attribute__((__packed__)) info[0];
 } __attribute__((__packed__));
 
-#define QMI_NAS_NETWORK_RAT_NONE		0x00
 #define QMI_NAS_NETWORK_RAT_GSM			0x04
 #define QMI_NAS_NETWORK_RAT_UMTS		0x05
 #define QMI_NAS_NETWORK_RAT_LTE			0x08
@@ -145,29 +140,9 @@ struct qmi_nas_current_plmn {
 #define QMI_NAS_RESULT_LOCATION_AREA_CODE	0x1d	/* uint16 */
 #define QMI_NAS_RESULT_CELL_ID			0x1e	/* uint32 */
 
-/* qmi_nas_serving_system.status */
-#define QMI_NAS_REGISTRATION_STATE_NOT_REGISTERED	0x00
-#define QMI_NAS_REGISTRATION_STATE_REGISTERED		0x01
-#define QMI_NAS_REGISTRATION_STATE_SEARCHING		0x02
-#define QMI_NAS_REGISTRATION_STATE_DENIED		0x03
-#define QMI_NAS_REGISTRATION_STATE_UNKNOWN		0x04
-
-#define QMI_NAS_RESULT_3GGP_DST 0x1b
-#define QMI_NAS_RESULT_3GPP_TIME 0x1c
-struct qmi_nas_3gpp_time {
-	uint16_t year;
-	uint8_t month;
-	uint8_t day;
-	uint8_t hour;
-	uint8_t minute;
-	uint8_t second;
-	uint8_t timezone;
-} __attribute__((__packed__));
-
-/* cs_state/ps_state */
-#define QMI_NAS_ATTACH_STATE_INVALID		0x00
-#define QMI_NAS_ATTACH_STATE_ATTACHED		0x01
-#define QMI_NAS_ATTACH_STATE_DETACHED		0x02
+#define QMI_NAS_ATTACH_STATUS_INVALID		0x00
+#define QMI_NAS_ATTACH_STATUS_ATTACHED		0x01
+#define QMI_NAS_ATTACH_STATUS_DETACHED		0x02
 
 /* Get info about home network */
 #define QMI_NAS_RESULT_HOME_NETWORK		0x01
@@ -177,14 +152,3 @@ struct qmi_nas_home_network {
 	uint8_t desc_len;
 	char desc[0];
 } __attribute__((__packed__));
-
-#define QMI_NAS_RAT_MODE_PREF_ANY		(-1)
-#define QMI_NAS_RAT_MODE_PREF_GSM		(1 << 2)
-#define QMI_NAS_RAT_MODE_PREF_UMTS		(1 << 3)
-#define QMI_NAS_RAT_MODE_PREF_LTE		(1 << 4)
-
-#define QMI_NAS_PARAM_SYSTEM_SELECTION_PREF_MODE	0x11
-
-#define QMI_NAS_RESULT_SYSTEM_SELECTION_PREF_MODE	0x11
-
-int qmi_nas_rat_to_tech(uint8_t rat);

ofono/drivers/qmimodem/netmon.c

@@ -1,286 +0,0 @@
-/*
- *
- *  oFono - Open Source Telephony
- *
- *  Copyright (C) 2017  Jonas Bonn. All rights reserved.
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
- *
- */
-
-#ifdef HAVE_CONFIG_H
-#include <config.h>
-#endif
-
-#define _GNU_SOURCE
-#include <stdio.h>
-#include <stdlib.h>
-#include <stdint.h>
-#include <string.h>
-#include <errno.h>
-
-#include <glib.h>
-
-#include <ofono/log.h>
-#include <ofono/modem.h>
-#include <ofono/netmon.h>
-
-#include "qmi.h"
-#include "nas.h"
-
-#include "qmimodem.h"
-#include "src/common.h"
-
-struct netmon_data {
-	struct qmi_service *nas;
-};
-
-static void get_rssi_cb(struct qmi_result *result, void *user_data)
-{
-	struct cb_data *cbd = user_data;
-	struct ofono_netmon *netmon = cbd->user;
-	ofono_netmon_cb_t cb = cbd->cb;
-	struct {
-		enum ofono_netmon_cell_type type;
-		int rssi;
-		int ber;
-		int rsrq;
-		int rsrp;
-	} props;
-	uint16_t len;
-	int16_t rsrp;
-	const struct {
-		int8_t value;
-		int8_t rat;
-	} __attribute__((__packed__)) *rsrq;
-	const struct {
-		uint16_t count;
-		struct {
-			uint8_t rssi;
-			int8_t rat;
-		} __attribute__((__packed__)) info[0];
-	} __attribute__((__packed__)) *rssi;
-	const struct {
-		uint16_t count;
-		struct {
-			uint16_t rate;
-			int8_t rat;
-		} __attribute__((__packed__)) info[0];
-	} __attribute__((__packed__)) *ber;
-	int i;
-	uint16_t num;
-
-	DBG("");
-
-	if (qmi_result_set_error(result, NULL)) {
-		CALLBACK_WITH_FAILURE(cb, cbd->data);
-		return;
-	}
-
-	/* RSSI */
-	rssi = qmi_result_get(result, 0x11, &len);
-	num = GUINT16_FROM_LE(rssi->count);
-	if (rssi) {
-		for (i = 0; i < num; i++) {
-			DBG("RSSI: %hhu on RAT %hhd",
-				rssi->info[i].rssi,
-				rssi->info[i].rat);
-		}
-
-		/* Get cell type from RSSI info... it will be the same
-		 * for all the other entries
-		 */
-		props.type = qmi_nas_rat_to_tech(rssi->info[0].rat);
-		switch (rssi->info[0].rat) {
-		case QMI_NAS_NETWORK_RAT_GSM:
-			props.type = OFONO_NETMON_CELL_TYPE_GSM;
-			break;
-		case QMI_NAS_NETWORK_RAT_UMTS:
-			props.type = OFONO_NETMON_CELL_TYPE_UMTS;
-			break;
-		case QMI_NAS_NETWORK_RAT_LTE:
-			props.type = OFONO_NETMON_CELL_TYPE_LTE;
-			break;
-		default:
-			props.type = OFONO_NETMON_CELL_TYPE_GSM;
-			break;
-		}
-
-		props.rssi = (rssi->info[0].rssi + 113) / 2;
-		if (props.rssi > 31) props.rssi = 31;
-		if (props.rssi < 0) props.rssi = 0;
-	} else {
-		props.type = QMI_NAS_NETWORK_RAT_GSM;
-		props.rssi = -1;
-	}
-
-	/* Bit error rate */
-	ber = qmi_result_get(result, 0x15, &len);
-	num = GUINT16_FROM_LE(ber->count);
-	if (ber) {
-		for (i = 0; i < ber->count; i++) {
-			DBG("Bit error rate: %hu on RAT %hhd",
-				GUINT16_FROM_LE(ber->info[i].rate),
-				ber->info[i].rat);
-		}
-
-		props.ber = GUINT16_FROM_LE(ber->info[0].rate);
-		if (props.ber > 7)
-			props.ber = -1;
-	} else {
-		props.ber = -1;
-	}
-
-	/* LTE RSRQ */
-	rsrq = qmi_result_get(result, 0x16, &len);
-	if (rsrq) {
-		DBG("RSRQ: %hhd on RAT %hhd",
-			rsrq->value,
-			rsrq->rat);
-
-		if (rsrq->value == 0) {
-			props.rsrq = -1;
-		} else {
-			props.rsrq = (rsrq->value + 19) * 2;
-			if (props.rsrq > 34) props.rsrq = 34;
-			if (props.rsrq < 0) props.rsrq = 0;
-		}
-	} else {
-		props.rsrq = -1;
-	}
-
-	/* LTE RSRP */
-	if (qmi_result_get_int16(result, 0x18, &rsrp)) {
-		DBG("Got LTE RSRP: %hd", rsrp);
-
-		if (rsrp == 0) {
-			props.rsrp = -1;
-		} else {
-			props.rsrp = rsrp + 140;
-			if (props.rsrp > 97) props.rsrp = 97;
-			if (props.rsrp < 0) props.rsrp = 0;
-		}
-	} else {
-		props.rsrp = -1;
-	}
-
-	ofono_netmon_serving_cell_notify(netmon,
-				props.type,
-				OFONO_NETMON_INFO_RSSI, props.rssi,
-				OFONO_NETMON_INFO_BER, props.ber,
-				OFONO_NETMON_INFO_RSRQ, props.rsrq,
-				OFONO_NETMON_INFO_RSRP, props.rsrp,
-				OFONO_NETMON_INFO_INVALID);
-
-	CALLBACK_WITH_SUCCESS(cb, cbd->data);
-}
-
-static void qmi_netmon_request_update(struct ofono_netmon *netmon,
-					ofono_netmon_cb_t cb,
-					void *user_data)
-{
-	struct netmon_data *data = ofono_netmon_get_data(netmon);
-	struct cb_data *cbd = cb_data_new(cb, user_data);
-	struct qmi_param *param;
-
-	DBG("");
-
-	cbd->user = netmon;
-
-	param = qmi_param_new();
-	if (!param)
-		goto out;
-
-	/* Request all signal strength items: mask=0xff */
-	qmi_param_append_uint16(param, 0x10, 255);
-
-	if (qmi_service_send(data->nas, QMI_NAS_GET_RSSI, param,
-					get_rssi_cb, cbd, g_free) > 0)
-		return;
-
-	qmi_param_free(param);
-
-out:
-	CALLBACK_WITH_FAILURE(cb, cbd->data);
-
-	g_free(cbd);
-}
-
-static void create_nas_cb(struct qmi_service *service, void *user_data)
-{
-	struct ofono_netmon *netmon = user_data;
-	struct netmon_data *nmd = ofono_netmon_get_data(netmon);
-
-	DBG("");
-
-	if (!service) {
-		ofono_error("Failed to request NAS service");
-		ofono_netmon_remove(netmon);
-		return;
-	}
-
-	nmd->nas = qmi_service_ref(service);
-
-	ofono_netmon_register(netmon);
-}
-
-static int qmi_netmon_probe(struct ofono_netmon *netmon,
-					unsigned int vendor, void *user_data)
-{
-	struct qmi_device *device = user_data;
-	struct netmon_data *nmd;
-
-	DBG("");
-
-	nmd = g_new0(struct netmon_data, 1);
-
-	ofono_netmon_set_data(netmon, nmd);
-
-	qmi_service_create_shared(device, QMI_SERVICE_NAS,
-					create_nas_cb, netmon, NULL);
-
-	return 0;
-}
-
-static void qmi_netmon_remove(struct ofono_netmon *netmon)
-{
-	struct netmon_data *nmd = ofono_netmon_get_data(netmon);
-
-	DBG("");
-
-	ofono_netmon_set_data(netmon, NULL);
-
-	qmi_service_unregister_all(nmd->nas);
-
-	qmi_service_unref(nmd->nas);
-
-	g_free(nmd);
-}
-
-static struct ofono_netmon_driver driver = {
-	.name			= "qmimodem",
-	.probe			= qmi_netmon_probe,
-	.remove			= qmi_netmon_remove,
-	.request_update		= qmi_netmon_request_update,
-};
-
-void qmi_netmon_init(void)
-{
-	ofono_netmon_driver_register(&driver);
-}
-
-void qmi_netmon_exit(void)
-{
-	ofono_netmon_driver_unregister(&driver);
-}

ofono/drivers/qmimodem/network-registration.c

@@ -23,7 +23,6 @@
 #include <config.h>
 #endif
 
-#include <endian.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ -44,36 +43,18 @@ struct netreg_data {
 	uint8_t current_rat;
 };
 
-static bool extract_ss_info_time(
-		struct qmi_result *result,
-		struct ofono_network_time *time)
+static int rat_to_tech(uint8_t rat)
 {
-	const struct qmi_nas_3gpp_time *time_3gpp = NULL;
-	uint8_t dst_3gpp;
-	bool dst_3gpp_valid;
-	uint16_t len;
-
-	/* parse 3gpp time & dst */
-	dst_3gpp_valid = qmi_result_get_uint8(result, QMI_NAS_RESULT_3GGP_DST,
-						&dst_3gpp);
-
-	time_3gpp = qmi_result_get(result, QMI_NAS_RESULT_3GPP_TIME, &len);
-	if (time_3gpp && len == sizeof(struct qmi_nas_3gpp_time) &&
-			dst_3gpp_valid) {
-		time->year = le16toh(time_3gpp->year);
-		time->mon = time_3gpp->month;
-		time->mday = time_3gpp->day;
-		time->hour = time_3gpp->hour;
-		time->min = time_3gpp->minute;
-		time->sec = time_3gpp->second;
-		time->utcoff = time_3gpp->timezone * 15 * 60;
-		time->dst = dst_3gpp;
-		return true;
+	switch (rat) {
+	case QMI_NAS_NETWORK_RAT_GSM:
+		return ACCESS_TECHNOLOGY_GSM;
+	case QMI_NAS_NETWORK_RAT_UMTS:
+		return ACCESS_TECHNOLOGY_UTRAN;
+	case QMI_NAS_NETWORK_RAT_LTE:
+		return ACCESS_TECHNOLOGY_EUTRAN;
 	}
 
-	/* TODO: 3gpp2 */
-
-	return false;
+	return -1;
 }
 
 static bool extract_ss_info(struct qmi_result *result, int *status,
@@ -83,7 +64,7 @@ static bool extract_ss_info(struct qmi_result *result, int *status,
 	const struct qmi_nas_serving_system *ss;
 	const struct qmi_nas_current_plmn *plmn;
 	uint8_t i, roaming;
-	uint16_t value16, len, opname_len;
+	uint16_t value16, len;
 	uint32_t value32;
 
 	DBG("");
@@ -101,13 +82,13 @@ static bool extract_ss_info(struct qmi_result *result, int *status,
 	for (i = 0; i < ss->radio_if_count; i++) {
 		DBG("radio in use %d", ss->radio_if[i]);
 
-		*tech = qmi_nas_rat_to_tech(ss->radio_if[i]);
+		*tech = rat_to_tech(ss->radio_if[i]);
 	}
 
 	if (qmi_result_get_uint8(result, QMI_NAS_RESULT_ROAMING_STATUS,
 								&roaming)) {
 		if (ss->status == 1 && roaming == 0)
-			*status = NETWORK_REGISTRATION_STATUS_ROAMING;
+			*status = 5;
 	}
 
 	if (!operator)
@@ -119,21 +100,8 @@ static bool extract_ss_info(struct qmi_result *result, int *status,
 						GUINT16_FROM_LE(plmn->mcc));
 		snprintf(operator->mnc, OFONO_MAX_MNC_LENGTH + 1, "%02d",
 						GUINT16_FROM_LE(plmn->mnc));
-		opname_len = plmn->desc_len;
-		if (opname_len > OFONO_MAX_OPERATOR_NAME_LENGTH)
-			opname_len = OFONO_MAX_OPERATOR_NAME_LENGTH;
-
-		/*
-		 * Telit QMI modems can return non-utf-8 characters in
-		 * plmn-desc. When that happens, libdbus will abort ofono.
-		 * If non-utf-8 characters are detected, use mccmnc string.
-		 */
-		if (g_utf8_validate(plmn->desc, opname_len, NULL)) {
-			strncpy(operator->name, plmn->desc, opname_len);
-			operator->name[opname_len] = '\0';
-		} else
-			snprintf(operator->name, OFONO_MAX_OPERATOR_NAME_LENGTH,
-					"%s%s",	operator->mcc, operator->mnc);
+		strncpy(operator->name, plmn->desc, plmn->desc_len);
+		operator->name[plmn->desc_len] = '\0';
 
 		DBG("%s (%s:%s)", operator->name, operator->mcc, operator->mnc);
 	}
@@ -157,15 +125,11 @@ static bool extract_ss_info(struct qmi_result *result, int *status,
 static void ss_info_notify(struct qmi_result *result, void *user_data)
 {
 	struct ofono_netreg *netreg = user_data;
-	struct ofono_network_time net_time;
 	struct netreg_data *data = ofono_netreg_get_data(netreg);
 	int status, lac, cellid, tech;
 
 	DBG("");
 
-	if (extract_ss_info_time(result, &net_time))
-		ofono_netreg_time_notify(netreg, &net_time);
-
 	if (!extract_ss_info(result, &status, &lac, &cellid, &tech,
 							&data->operator))
 		return;
@@ -301,7 +265,7 @@ static void scan_nets_cb(struct qmi_result *result, void *user_data)
 		DBG("%03d:%02d %d", netrat->info[i].mcc, netrat->info[i].mnc,
 							netrat->info[i].rat);
 
-		list[i].tech = qmi_nas_rat_to_tech(netrat->info[i].rat);
+		list[i].tech = rat_to_tech(netrat->info[i].rat);
 	}
 
 done:
@@ -393,7 +357,7 @@ static void qmi_register_manual(struct ofono_netreg *netreg,
 
 	info.mcc = atoi(mcc);
 	info.mnc = atoi(mnc);
-	info.rat = QMI_NAS_NETWORK_RAT_NO_CHANGE;
+	info.rat = data->current_rat;
 
 	qmi_param_append(param, QMI_NAS_PARAM_REGISTER_MANUAL_INFO,
 						sizeof(info), &info);
@@ -487,10 +451,9 @@ static void event_notify(struct qmi_result *result, void *user_data)
         if (ss) {
 		int strength;
 
-		strength = dbm_to_strength(ss->dbm);
+		DBG("signal with %d dBm on %d", ss->dbm, ss->rat);
 
-		DBG("signal with %d%%(%d dBm) on %d",
-				strength, ss->dbm, ss->rat);
+		strength = dbm_to_strength(ss->dbm);
 
 		ofono_netreg_strength_notify(netreg, strength);
 	}
@@ -511,17 +474,10 @@ static void event_notify(struct qmi_result *result, void *user_data)
 static void set_event_cb(struct qmi_result *result, void *user_data)
 {
 	struct ofono_netreg *netreg = user_data;
-	struct netreg_data *data = ofono_netreg_get_data(netreg);
 
 	DBG("");
 
 	ofono_netreg_register(netreg);
-
-	qmi_service_register(data->nas, QMI_NAS_EVENT,
-					event_notify, netreg, NULL);
-
-	qmi_service_register(data->nas, QMI_NAS_SS_INFO_IND,
-					ss_info_notify, netreg, NULL);
 }
 
 static void create_nas_cb(struct qmi_service *service, void *user_data)
@@ -543,6 +499,12 @@ static void create_nas_cb(struct qmi_service *service, void *user_data)
 
 	data->nas = qmi_service_ref(service);
 
+	qmi_service_register(data->nas, QMI_NAS_EVENT,
+					event_notify, netreg, NULL);
+
+	qmi_service_register(data->nas, QMI_NAS_SS_INFO_IND,
+					ss_info_notify, netreg, NULL);
+
 	param = qmi_param_new();
 	if (!param)
 		goto done;
@@ -581,7 +543,7 @@ static int qmi_netreg_probe(struct ofono_netreg *netreg,
 
 	ofono_netreg_set_data(netreg, data);
 
-	qmi_service_create_shared(device, QMI_SERVICE_NAS,
+	qmi_service_create(device, QMI_SERVICE_NAS,
 					create_nas_cb, netreg, NULL);
 
 	return 0;

ofono/drivers/qmimodem/qmi.c

@@ -26,8 +26,6 @@
 #define _GNU_SOURCE
 #include <stdio.h>
 #include <ctype.h>
-#include <dirent.h>
-#include <errno.h>
 #include <fcntl.h>
 #include <unistd.h>
 #include <stdlib.h>
@@ -35,18 +33,12 @@
 
 #include <glib.h>
 
-#include <ofono/log.h>
-
 #include "qmi.h"
 #include "ctl.h"
 
 typedef void (*qmi_message_func_t)(uint16_t message, uint16_t length,
 					const void *buffer, void *user_data);
 
-struct discovery {
-	qmi_destroy_func_t destroy;
-};
-
 struct qmi_device {
 	int ref_count;
 	int fd;
@@ -57,7 +49,6 @@ struct qmi_device {
 	GQueue *req_queue;
 	GQueue *control_queue;
 	GQueue *service_queue;
-	GQueue *discovery_queue;
 	uint8_t next_control_tid;
 	uint16_t next_service_tid;
 	qmi_debug_func_t debug_func;
@@ -69,12 +60,6 @@ struct qmi_device {
 	uint8_t version_count;
 	GHashTable *service_list;
 	unsigned int release_users;
-	qmi_shutdown_func_t shutdown_func;
-	void *shutdown_user_data;
-	qmi_destroy_func_t shutdown_destroy;
-	guint shutdown_source;
-	bool shutting_down : 1;
-	bool destroyed : 1;
 };
 
 struct qmi_service {
@@ -224,14 +209,6 @@ static gint __request_compare(gconstpointer a, gconstpointer b)
 	return req->tid - tid;
 }
 
-static void __discovery_free(gpointer data, gpointer user_data)
-{
-	struct discovery *d = data;
-	qmi_destroy_func_t destroy = d->destroy;
-
-	destroy(d);
-}
-
 static void __notify_free(gpointer data, gpointer user_data)
 {
 	struct qmi_notify *notify = data;
@@ -336,12 +313,8 @@ static const char *__service_type_to_string(uint8_t type)
 		return "UIM";
 	case QMI_SERVICE_PBM:
 		return "PBM";
-	case QMI_SERVICE_QCHAT:
-		return "QCHAT";
 	case QMI_SERVICE_RMTFS:
 		return "RMTFS";
-	case QMI_SERVICE_TEST:
-		return "TEST";
 	case QMI_SERVICE_LOC:
 		return "LOC";
 	case QMI_SERVICE_SAR:
@@ -353,21 +326,9 @@ static const char *__service_type_to_string(uint8_t type)
 	case QMI_SERVICE_TS:
 		return "TS";
 	case QMI_SERVICE_TMD:
-		return "TMD";
-	case QMI_SERVICE_WDA:
-		return "WDA";
-	case QMI_SERVICE_CSVT:
-		return "CSVT";
-	case QMI_SERVICE_COEX:
-		return "COEX";
+		return "TMS";
 	case QMI_SERVICE_PDC:
 		return "PDC";
-	case QMI_SERVICE_RFRPE:
-		return "RFRPE";
-	case QMI_SERVICE_DSD:
-		return "DSD";
-	case QMI_SERVICE_SSCTL:
-		return "SSCTL";
 	case QMI_SERVICE_CAT_OLD:
 		return "CAT";
 	case QMI_SERVICE_RMS:
@@ -797,7 +758,7 @@ static void handle_packet(struct qmi_device *device,
 
 		tid = GUINT16_FROM_LE(service->transaction);
 
-		if (service->type == 0x04) {
+		if (service->type == 0x04 && tid == 0x0000) {
 			handle_indication(device, hdr->service, hdr->client,
 							message, length, data);
 			return;
@@ -877,21 +838,6 @@ static void read_watch_destroy(gpointer user_data)
 	device->read_watch = 0;
 }
 
-static void __qmi_device_discovery_started(struct qmi_device *device,
-						struct discovery *d)
-{
-	g_queue_push_tail(device->discovery_queue, d);
-}
-
-static void __qmi_device_discovery_complete(struct qmi_device *device,
-						struct discovery *d)
-{
-	if (g_queue_remove(device->discovery_queue, d) != TRUE)
-		return;
-
-	__discovery_free(d, NULL);
-}
-
 static void service_destroy(gpointer data)
 {
 	struct qmi_service *service = data;
@@ -945,7 +891,6 @@ struct qmi_device *qmi_device_new(int fd)
 	device->req_queue = g_queue_new();
 	device->control_queue = g_queue_new();
 	device->service_queue = g_queue_new();
-	device->discovery_queue = g_queue_new();
 
 	device->service_list = g_hash_table_new_full(g_direct_hash,
 					g_direct_equal, NULL, service_destroy);
@@ -982,9 +927,6 @@ void qmi_device_unref(struct qmi_device *device)
 	g_queue_foreach(device->req_queue, __request_free, NULL);
 	g_queue_free(device->req_queue);
 
-	g_queue_foreach(device->discovery_queue, __discovery_free, NULL);
-	g_queue_free(device->discovery_queue);
-
 	if (device->write_watch > 0)
 		g_source_remove(device->write_watch);
 
@@ -994,18 +936,12 @@ void qmi_device_unref(struct qmi_device *device)
 	if (device->close_on_unref)
 		close(device->fd);
 
-	if (device->shutdown_source)
-		g_source_remove(device->shutdown_source);
-
 	g_hash_table_destroy(device->service_list);
 
 	g_free(device->version_str);
 	g_free(device->version_list);
 
-	if (device->shutting_down)
-		device->destroyed = true;
-	else
-		g_free(device);
+	g_free(device);
 }
 
 void qmi_device_set_debug(struct qmi_device *device,
@@ -1026,23 +962,6 @@ void qmi_device_set_close_on_unref(struct qmi_device *device, bool do_close)
 	device->close_on_unref = do_close;
 }
 
-void qmi_result_print_tlvs(struct qmi_result *result)
-{
-	const void *ptr = result->data;
-	uint16_t len = result->length;
-
-	while (len > QMI_TLV_HDR_SIZE) {
-		const struct qmi_tlv_hdr *tlv = ptr;
-		uint16_t tlv_length = GUINT16_FROM_LE(tlv->length);
-
-		DBG("tlv: 0x%02x len 0x%04x", tlv->type, tlv->length);
-
-		ptr += QMI_TLV_HDR_SIZE + tlv_length;
-		len -= QMI_TLV_HDR_SIZE + tlv_length;
-	}
-}
-
-
 static const void *tlv_get(const void *data, uint16_t size,
 					uint8_t type, uint16_t *length)
 {
@@ -1068,7 +987,6 @@ static const void *tlv_get(const void *data, uint16_t size,
 }
 
 struct discover_data {
-	struct discovery super;
 	struct qmi_device *device;
 	qmi_discover_func_t func;
 	void *user_data;
@@ -1076,21 +994,6 @@ struct discover_data {
 	guint timeout;
 };
 
-static void discover_data_free(gpointer user_data)
-{
-	struct discover_data *data = user_data;
-
-	if (data->timeout) {
-		g_source_remove(data->timeout);
-		data->timeout = 0;
-	}
-
-	if (data->destroy)
-		data->destroy(data->user_data);
-
-	g_free(data);
-}
-
 static void discover_callback(uint16_t message, uint16_t length,
 					const void *buffer, void *user_data)
 {
@@ -1104,6 +1007,8 @@ static void discover_callback(uint16_t message, uint16_t length,
 	uint8_t count;
 	unsigned int i;
 
+	g_source_remove(data->timeout);
+
 	count = 0;
 	list = NULL;
 
@@ -1174,7 +1079,10 @@ done:
 	if (data->func)
 		data->func(count, list, data->user_data);
 
-	__qmi_device_discovery_complete(data->device, &data->super);
+	if (data->destroy)
+		data->destroy(data->user_data);
+
+	g_free(data);
 }
 
 static gboolean discover_reply(gpointer user_data)
@@ -1188,7 +1096,10 @@ static gboolean discover_reply(gpointer user_data)
 		data->func(device->version_count,
 				device->version_list, data->user_data);
 
-	__qmi_device_discovery_complete(data->device, &data->super);
+	if (data->destroy)
+		data->destroy(data->user_data);
+
+	g_free(data);
 
 	return FALSE;
 }
@@ -1209,15 +1120,13 @@ bool qmi_device_discover(struct qmi_device *device, qmi_discover_func_t func,
 	if (!data)
 		return false;
 
-	data->super.destroy = discover_data_free;
 	data->device = device;
 	data->func = func;
 	data->user_data = user_data;
 	data->destroy = destroy;
 
 	if (device->version_list) {
-		data->timeout = g_timeout_add_seconds(0, discover_reply, data);
-		__qmi_device_discovery_started(device, &data->super);
+		g_timeout_add_seconds(0, discover_reply, data);
 		return true;
 	}
 
@@ -1238,7 +1147,6 @@ bool qmi_device_discover(struct qmi_device *device, qmi_discover_func_t func,
 	__request_submit(device, req, hdr->transaction);
 
 	data->timeout = g_timeout_add_seconds(5, discover_reply, data);
-	__qmi_device_discovery_started(device, &data->super);
 
 	return true;
 }
@@ -1269,254 +1177,61 @@ static void release_client(struct qmi_device *device,
 	__request_submit(device, req, hdr->transaction);
 }
 
-static void shutdown_destroy(gpointer user_data)
+struct shutdown_data {
+	struct qmi_device *device;
+	qmi_shutdown_func_t func;
+	void *user_data;
+	qmi_destroy_func_t destroy;
+};
+
+static gboolean shutdown_reply(gpointer user_data)
 {
-	struct qmi_device *device = user_data;
+	struct shutdown_data *data = user_data;
 
-	if (device->shutdown_destroy)
-		device->shutdown_destroy(device->shutdown_user_data);
+	if (data->func)
+		data->func(data->user_data);
 
-	device->shutdown_source = 0;
+	g_free(data);
 
-	if (device->destroyed)
-		g_free(device);
+	return FALSE;
 }
 
-static gboolean shutdown_callback(gpointer user_data)
+static gboolean shutdown_timeout(gpointer user_data)
 {
-	struct qmi_device *device = user_data;
+	struct shutdown_data *data = user_data;
+	struct qmi_device *device = data->device;
 
 	if (device->release_users > 0)
 		return TRUE;
 
-	device->shutting_down = true;
-
-	if (device->shutdown_func)
-		device->shutdown_func(device->shutdown_user_data);
-
-	device->shutting_down = true;
-
-	return FALSE;
+	return shutdown_reply(data);
 }
 
 bool qmi_device_shutdown(struct qmi_device *device, qmi_shutdown_func_t func,
 				void *user_data, qmi_destroy_func_t destroy)
 {
-	if (!device)
-		return false;
+	struct shutdown_data *data;
 
-	if (device->shutdown_source > 0)
+	if (!device)
 		return false;
 
 	__debug_device(device, "device %p shutdown", device);
 
-	device->shutdown_source = g_timeout_add_seconds_full(G_PRIORITY_DEFAULT,
-						0, shutdown_callback, device,
-						shutdown_destroy);
-	if (device->shutdown_source == 0)
+	data = g_try_new0(struct shutdown_data, 1);
+	if (!data)
 		return false;
 
-	device->shutdown_func = func;
-	device->shutdown_user_data = user_data;
-	device->shutdown_destroy = destroy;
+	data->device = device;
+	data->func = func;
+	data->user_data = user_data;
+	data->destroy = destroy;
 
-	return true;
-}
-
-static bool get_device_file_name(struct qmi_device *device,
-					char *file_name, int size)
-{
-	pid_t pid;
-	char temp[100];
-	ssize_t result;
-
-	if (size <= 0)
-		return false;
-
-	pid = getpid();
-
-	snprintf(temp, 100, "/proc/%d/fd/%d", (int) pid, device->fd);
-	temp[99] = 0;
-
-	result = readlink(temp, file_name, size - 1);
-
-	if (result == -1 || result >= size - 1) {
-		DBG("Error %d in readlink", errno);
-		return false;
-	}
-
-	file_name[result] = 0;
-
-	return true;
-}
-
-static char *get_first_dir_in_directory(char *dir_path)
-{
-	DIR *dir;
-	struct dirent *dir_entry;
-	char *dir_name = NULL;
-
-	dir = opendir(dir_path);
-
-	if (!dir)
-		return NULL;
-
-	dir_entry = readdir(dir);
-
-	while ((dir_entry != NULL)) {
-		if (dir_entry->d_type == DT_DIR &&
-				strcmp(dir_entry->d_name, ".") != 0 &&
-				strcmp(dir_entry->d_name, "..") != 0) {
-			dir_name = g_strdup(dir_entry->d_name);
-			break;
-		}
-
-		dir_entry = readdir(dir);
-	}
-
-	closedir(dir);
-	return dir_name;
-}
-
-static char *get_device_interface(struct qmi_device *device)
-{
-	char * const driver_names[] = { "usbmisc", "usb" };
-	unsigned int i;
-	char file_path[PATH_MAX];
-	char *file_name;
-	char *interface = NULL;
-
-	if (!get_device_file_name(device, file_path, sizeof(file_path)))
-		return NULL;
-
-	file_name = basename(file_path);
-
-	for (i = 0; i < G_N_ELEMENTS(driver_names) && !interface; i++) {
-		gchar *sysfs_path;
-
-		sysfs_path = g_strdup_printf("/sys/class/%s/%s/device/net/",
-						driver_names[i], file_name);
-		interface = get_first_dir_in_directory(sysfs_path);
-		g_free(sysfs_path);
-	}
-
-	return interface;
-}
-
-enum qmi_device_expected_data_format qmi_device_get_expected_data_format(
-						struct qmi_device *device)
-{
-	char *sysfs_path = NULL;
-	char *interface = NULL;
-	int fd = -1;
-	char value;
-	enum qmi_device_expected_data_format expected =
-					QMI_DEVICE_EXPECTED_DATA_FORMAT_UNKNOWN;
-
-	if (!device)
-		goto done;
-
-	interface = get_device_interface(device);
-
-	if (!interface) {
-		DBG("Error while getting interface name");
-		goto done;
-	}
-
-	/* Build sysfs file path and open it */
-	sysfs_path = g_strdup_printf("/sys/class/net/%s/qmi/raw_ip", interface);
-
-	fd = open(sysfs_path, O_RDONLY);
-	if (fd < 0) {
-		/* maybe not supported by kernel */
-		DBG("Error %d in open(%s)", errno, sysfs_path);
-		goto done;
-	}
-
-	if (read(fd, &value, 1) != 1) {
-		DBG("Error %d in read(%s)", errno, sysfs_path);
-		goto done;
-	}
-
-	if (value == 'Y')
-		expected = QMI_DEVICE_EXPECTED_DATA_FORMAT_RAW_IP;
-	else if (value == 'N')
-		expected = QMI_DEVICE_EXPECTED_DATA_FORMAT_802_3;
+	if (device->release_users > 0)
+		g_timeout_add_seconds(0, shutdown_timeout, data);
 	else
-		DBG("Unexpected sysfs file contents");
+		g_timeout_add_seconds(0, shutdown_reply, data);
 
-done:
-	if (fd >= 0)
-		close(fd);
-
-	if (sysfs_path)
-		g_free(sysfs_path);
-
-	if (interface)
-		g_free(interface);
-
-	return expected;
-}
-
-bool qmi_device_set_expected_data_format(struct qmi_device *device,
-			enum qmi_device_expected_data_format format)
-{
-	bool res = false;
-	char *sysfs_path = NULL;
-	char *interface = NULL;
-	int fd = -1;
-	char value;
-
-	if (!device)
-		goto done;
-
-	switch (format) {
-	case QMI_DEVICE_EXPECTED_DATA_FORMAT_802_3:
-		value = 'N';
-		break;
-	case QMI_DEVICE_EXPECTED_DATA_FORMAT_RAW_IP:
-		value = 'Y';
-		break;
-	default:
-		DBG("Unhandled format: %d", (int) format);
-		goto done;
-	}
-
-	interface = get_device_interface(device);
-
-	if (!interface) {
-		DBG("Error while getting interface name");
-		goto done;
-	}
-
-	/* Build sysfs file path and open it */
-	sysfs_path = g_strdup_printf("/sys/class/net/%s/qmi/raw_ip", interface);
-
-	fd = open(sysfs_path, O_WRONLY);
-	if (fd < 0) {
-		/* maybe not supported by kernel */
-		DBG("Error %d in open(%s)", errno, sysfs_path);
-		goto done;
-	}
-
-	if (write(fd, &value, 1) != 1) {
-		DBG("Error %d in write(%s)", errno, sysfs_path);
-		goto done;
-	}
-
-	res = true;
-
-done:
-	if (fd >= 0)
-		close(fd);
-
-	if (sysfs_path)
-		g_free(sysfs_path);
-
-	if (interface)
-		g_free(interface);
-
-	return res;
+	return true;
 }
 
 struct qmi_param *qmi_param_new(void)
@@ -1720,27 +1435,6 @@ bool qmi_result_get_uint8(struct qmi_result *result, uint8_t type,
 	return true;
 }
 
-bool qmi_result_get_int16(struct qmi_result *result, uint8_t type,
-							int16_t *value)
-{
-	const unsigned char *ptr;
-	uint16_t len, tmp;
-
-	if (!result || !type)
-		return false;
-
-	ptr = tlv_get(result->data, result->length, type, &len);
-	if (!ptr)
-		return false;
-
-	memcpy(&tmp, ptr, 2);
-
-	if (value)
-		*value = GINT16_FROM_LE(tmp);
-
-	return true;
-}
-
 bool qmi_result_get_uint16(struct qmi_result *result, uint8_t type,
 							uint16_t *value)
 {
@@ -1807,7 +1501,6 @@ bool qmi_result_get_uint64(struct qmi_result *result, uint8_t type,
 }
 
 struct service_create_data {
-	struct discovery super;
 	struct qmi_device *device;
 	bool shared;
 	uint8_t type;
@@ -1819,29 +1512,16 @@ struct service_create_data {
 	guint timeout;
 };
 
-static void service_create_data_free(gpointer user_data)
+static gboolean service_create_reply(gpointer user_data)
 {
 	struct service_create_data *data = user_data;
 
-	if (data->timeout) {
-		g_source_remove(data->timeout);
-		data->timeout = 0;
-	}
+	data->func(NULL, data->user_data);
 
 	if (data->destroy)
 		data->destroy(data->user_data);
 
 	g_free(data);
-}
-
-static gboolean service_create_reply(gpointer user_data)
-{
-	struct service_create_data *data = user_data;
-
-	data->timeout = 0;
-	data->func(NULL, data->user_data);
-
-	__qmi_device_discovery_complete(data->device, &data->super);
 
 	return FALSE;
 }
@@ -1857,6 +1537,8 @@ static void service_create_callback(uint16_t message, uint16_t length,
 	uint16_t len;
 	unsigned int hash_id;
 
+	g_source_remove(data->timeout);
+
 	result_code = tlv_get(buffer, length, 0x02, &len);
 	if (!result_code)
 		goto done;
@@ -1898,9 +1580,13 @@ static void service_create_callback(uint16_t message, uint16_t length,
 
 done:
 	data->func(service, data->user_data);
+
 	qmi_service_unref(service);
 
-	__qmi_device_discovery_complete(data->device, &data->super);
+	if (data->destroy)
+		data->destroy(data->user_data);
+
+	g_free(data);
 }
 
 static void service_create_discover(uint8_t count,
@@ -1931,9 +1617,7 @@ static void service_create_discover(uint8_t count,
 		if (data->timeout > 0)
 			g_source_remove(data->timeout);
 
-		data->timeout = g_timeout_add_seconds(0,
-						service_create_reply, data);
-		__qmi_device_discovery_started(device, &data->super);
+		g_timeout_add_seconds(0, service_create_reply, data);
 		return;
 	}
 
@@ -1956,7 +1640,6 @@ static bool service_create(struct qmi_device *device, bool shared,
 	if (!data)
 		return false;
 
-	data->super.destroy = service_create_data_free;
 	data->device = device;
 	data->shared = shared;
 	data->type = type;
@@ -1979,7 +1662,6 @@ static bool service_create(struct qmi_device *device, bool shared,
 
 done:
 	data->timeout = g_timeout_add_seconds(8, service_create_reply, data);
-	__qmi_device_discovery_started(device, &data->super);
 
 	return true;
 }
@@ -1998,23 +1680,17 @@ bool qmi_service_create(struct qmi_device *device,
 }
 
 struct service_create_shared_data {
-	struct discovery super;
 	struct qmi_service *service;
-	struct qmi_device *device;
 	qmi_create_func_t func;
 	void *user_data;
 	qmi_destroy_func_t destroy;
-	guint timeout;
 };
 
-static void service_create_shared_data_free(gpointer user_data)
+static gboolean service_create_shared_reply(gpointer user_data)
 {
 	struct service_create_shared_data *data = user_data;
 
-	if (data->timeout) {
-		g_source_remove(data->timeout);
-		data->timeout = 0;
-	}
+	data->func(data->service, data->user_data);
 
 	qmi_service_unref(data->service);
 
@@ -2022,16 +1698,6 @@ static void service_create_shared_data_free(gpointer user_data)
 		data->destroy(data->user_data);
 
 	g_free(data);
-}
-
-static gboolean service_create_shared_reply(gpointer user_data)
-{
-	struct service_create_shared_data *data = user_data;
-
-	data->timeout = 0;
-	data->func(data->service, data->user_data);
-
-	__qmi_device_discovery_complete(data->device, &data->super);
 
 	return FALSE;
 }
@@ -2058,16 +1724,13 @@ bool qmi_service_create_shared(struct qmi_device *device,
 		if (!data)
 			return false;
 
-		data->super.destroy = service_create_shared_data_free;
 		data->service = qmi_service_ref(service);
-		data->device = device;
+
 		data->func = func;
 		data->user_data = user_data;
 		data->destroy = destroy;
 
-		data->timeout = g_timeout_add(0,
-					service_create_shared_reply, data);
-		__qmi_device_discovery_started(device, &data->super);
+		g_timeout_add(0, service_create_shared_reply, data);
 
 		return 0;
 	}

ofono/drivers/qmimodem/qmi.h

@@ -35,32 +35,18 @@
 #define QMI_SERVICE_CAT		10	/* Card application toolkit service */
 #define QMI_SERVICE_UIM		11	/* UIM service */
 #define QMI_SERVICE_PBM		12	/* Phonebook service */
-#define QMI_SERVICE_QCHAT	13
 #define QMI_SERVICE_RMTFS	14	/* Remote file system service */
-#define QMI_SERVICE_TEST	15
 #define QMI_SERVICE_LOC		16	/* Location service */
 #define QMI_SERVICE_SAR		17	/* Specific absorption rate service */
 #define QMI_SERVICE_CSD		20	/* Core sound driver service */
 #define QMI_SERVICE_EFS		21	/* Embedded file system service */
 #define QMI_SERVICE_TS		23	/* Thermal sensors service */
 #define QMI_SERVICE_TMD		24	/* Thermal mitigation device service */
-#define QMI_SERVICE_WDA		26	/* Wireless data administrative service */
-#define QMI_SERVICE_CSVT	29
-#define QMI_SERVICE_COEX	34
 #define QMI_SERVICE_PDC		36	/* Persistent device configuration service */
-#define QMI_SERVICE_RFRPE	41
-#define QMI_SERVICE_DSD		42
-#define QMI_SERVICE_SSCTL	43
 #define QMI_SERVICE_CAT_OLD	224	/* Card application toolkit service */
 #define QMI_SERVICE_RMS		225	/* Remote management service */
 #define QMI_SERVICE_OMA		226	/* OMA device management service */
 
-enum qmi_device_expected_data_format {
-	QMI_DEVICE_EXPECTED_DATA_FORMAT_UNKNOWN,
-	QMI_DEVICE_EXPECTED_DATA_FORMAT_802_3,
-	QMI_DEVICE_EXPECTED_DATA_FORMAT_RAW_IP,
-};
-
 struct qmi_version {
 	uint8_t type;
 	uint16_t major;
@@ -96,10 +82,6 @@ bool qmi_device_discover(struct qmi_device *device, qmi_discover_func_t func,
 bool qmi_device_shutdown(struct qmi_device *device, qmi_shutdown_func_t func,
 				void *user_data, qmi_destroy_func_t destroy);
 
-enum qmi_device_expected_data_format qmi_device_get_expected_data_format(
-						struct qmi_device *device);
-bool qmi_device_set_expected_data_format(struct qmi_device *device,
-			enum qmi_device_expected_data_format format);
 
 struct qmi_param;
 
@@ -130,15 +112,13 @@ const void *qmi_result_get(struct qmi_result *result, uint8_t type,
 char *qmi_result_get_string(struct qmi_result *result, uint8_t type);
 bool qmi_result_get_uint8(struct qmi_result *result, uint8_t type,
 							uint8_t *value);
-bool qmi_result_get_int16(struct qmi_result *result, uint8_t type,
-							int16_t *value);
 bool qmi_result_get_uint16(struct qmi_result *result, uint8_t type,
 							uint16_t *value);
 bool qmi_result_get_uint32(struct qmi_result *result, uint8_t type,
 							uint32_t *value);
 bool qmi_result_get_uint64(struct qmi_result *result, uint8_t type,
 							uint64_t *value);
-void qmi_result_print_tlvs(struct qmi_result *result);
+
 
 struct qmi_service;
 

ofono/drivers/qmimodem/qmimodem.c

@@ -41,14 +41,12 @@ static int qmimodem_init(void)
 	qmi_gprs_context_init();
 	qmi_radio_settings_init();
 	qmi_location_reporting_init();
-	qmi_netmon_init();
 
 	return 0;
 }
 
 static void qmimodem_exit(void)
 {
-	qmi_netmon_exit();
 	qmi_location_reporting_exit();
 	qmi_radio_settings_exit();
 	qmi_gprs_context_exit();

ofono/drivers/qmimodem/qmimodem.h

@@ -53,6 +53,3 @@ extern void qmi_radio_settings_exit(void);
 
 extern void qmi_location_reporting_init(void);
 extern void qmi_location_reporting_exit(void);
-
-extern void qmi_netmon_init(void);
-extern void qmi_netmon_exit(void);

ofono/drivers/qmimodem/radio-settings.c

@@ -29,202 +29,15 @@
 
 #include "qmi.h"
 #include "nas.h"
-#include "dms.h"
 
 #include "qmimodem.h"
 
 struct settings_data {
 	struct qmi_service *nas;
-	struct qmi_service *dms;
 	uint16_t major;
 	uint16_t minor;
 };
 
-static void get_system_selection_pref_cb(struct qmi_result *result,
-							void* user_data)
-{
-	struct cb_data *cbd = user_data;
-	ofono_radio_settings_rat_mode_query_cb_t cb = cbd->cb;
-	enum ofono_radio_access_mode mode = OFONO_RADIO_ACCESS_MODE_ANY;
-	uint16_t pref;
-
-	DBG("");
-
-	if (qmi_result_set_error(result, NULL)) {
-		CALLBACK_WITH_FAILURE(cb, -1, cbd->data);
-		return;
-	}
-
-	qmi_result_get_uint16(result,
-			QMI_NAS_RESULT_SYSTEM_SELECTION_PREF_MODE, &pref);
-
-	switch (pref) {
-	case QMI_NAS_RAT_MODE_PREF_GSM:
-		mode = OFONO_RADIO_ACCESS_MODE_GSM;
-		break;
-	case QMI_NAS_RAT_MODE_PREF_UMTS:
-		mode = OFONO_RADIO_ACCESS_MODE_UMTS;
-		break;
-	case QMI_NAS_RAT_MODE_PREF_LTE:
-		mode = OFONO_RADIO_ACCESS_MODE_LTE;
-		break;
-	}
-
-	CALLBACK_WITH_SUCCESS(cb, mode, cbd->data);
-}
-
-static void qmi_query_rat_mode(struct ofono_radio_settings *rs,
-			ofono_radio_settings_rat_mode_query_cb_t cb,
-			void *user_data)
-{
-	struct settings_data *data = ofono_radio_settings_get_data(rs);
-	struct cb_data *cbd = cb_data_new(cb, user_data);
-
-	DBG("");
-
-	if (qmi_service_send(data->nas,
-				QMI_NAS_GET_SYSTEM_SELECTION_PREF, NULL,
-				get_system_selection_pref_cb, cbd, g_free) > 0)
-		return;
-
-	CALLBACK_WITH_FAILURE(cb, -1, data);
-}
-
-static void set_system_selection_pref_cb(struct qmi_result *result,
-							void* user_data)
-{
-	struct cb_data *cbd = user_data;
-	ofono_radio_settings_rat_mode_set_cb_t cb = cbd->cb;
-
-	DBG("");
-
-	if (qmi_result_set_error(result, NULL)) {
-		CALLBACK_WITH_FAILURE(cb, cbd->data);
-		return;
-	}
-
-	CALLBACK_WITH_SUCCESS(cb, cbd->data);
-}
-
-static void qmi_set_rat_mode(struct ofono_radio_settings *rs,
-			enum ofono_radio_access_mode mode,
-			ofono_radio_settings_rat_mode_set_cb_t cb,
-			void *user_data)
-{
-	struct settings_data *data = ofono_radio_settings_get_data(rs);
-	struct cb_data *cbd = cb_data_new(cb, user_data);
-	uint16_t pref = QMI_NAS_RAT_MODE_PREF_ANY;
-	struct qmi_param *param;
-
-	DBG("");
-
-	switch (mode) {
-	case OFONO_RADIO_ACCESS_MODE_ANY:
-		pref = QMI_NAS_RAT_MODE_PREF_ANY;
-		break;
-	case OFONO_RADIO_ACCESS_MODE_GSM:
-		pref = QMI_NAS_RAT_MODE_PREF_GSM;
-		break;
-	case OFONO_RADIO_ACCESS_MODE_UMTS:
-		pref = QMI_NAS_RAT_MODE_PREF_UMTS;
-		break;
-	case OFONO_RADIO_ACCESS_MODE_LTE:
-		pref = QMI_NAS_RAT_MODE_PREF_LTE;
-		break;
-	}
-
-	param = qmi_param_new();
-	if (!param) {
-		CALLBACK_WITH_FAILURE(cb, user_data);
-		return;
-	}
-
-	qmi_param_append_uint16(param, QMI_NAS_PARAM_SYSTEM_SELECTION_PREF_MODE,
-			pref);
-
-	if (qmi_service_send(data->nas,
-				QMI_NAS_SET_SYSTEM_SELECTION_PREF, param,
-				set_system_selection_pref_cb, cbd, g_free) > 0)
-		return;
-
-	qmi_param_free(param);
-	CALLBACK_WITH_FAILURE(cb, user_data);
-	g_free(cbd);
-}
-
-static void get_caps_cb(struct qmi_result *result, void *user_data)
-{
-	struct cb_data *cbd = user_data;
-	ofono_radio_settings_available_rats_query_cb_t cb = cbd->cb;
-	const struct qmi_dms_device_caps *caps;
-	unsigned int available_rats;
-	uint16_t len;
-	uint8_t i;
-
-	DBG("");
-
-	if (qmi_result_set_error(result, NULL))
-		goto error;
-
-	caps = qmi_result_get(result, QMI_DMS_RESULT_DEVICE_CAPS, &len);
-	if (!caps)
-		goto error;
-
-	available_rats = 0;
-	for (i = 0; i < caps->radio_if_count; i++) {
-		switch (caps->radio_if[i]) {
-		case QMI_DMS_RADIO_IF_GSM:
-			available_rats |= OFONO_RADIO_ACCESS_MODE_GSM;
-			break;
-		case QMI_DMS_RADIO_IF_UMTS:
-			available_rats |= OFONO_RADIO_ACCESS_MODE_UMTS;
-			break;
-		case QMI_DMS_RADIO_IF_LTE:
-			available_rats |= OFONO_RADIO_ACCESS_MODE_LTE;
-			break;
-		}
-	}
-
-	CALLBACK_WITH_SUCCESS(cb, available_rats, cbd->data);
-
-	return;
-
-error:
-	CALLBACK_WITH_FAILURE(cb, -1, cbd->data);
-}
-
-static void qmi_query_available_rats(struct ofono_radio_settings *rs,
-			ofono_radio_settings_available_rats_query_cb_t cb,
-			void *data)
-{
-	struct settings_data *rsd = ofono_radio_settings_get_data(rs);
-	struct cb_data *cbd = cb_data_new(cb, data);
-
-	if (!rsd->dms)
-		goto error;
-
-	if (qmi_service_send(rsd->dms, QMI_DMS_GET_CAPS, NULL,
-					get_caps_cb, cbd, g_free) > 0)
-		return;
-
-error:
-	g_free(cbd);
-	CALLBACK_WITH_FAILURE(cb, -1, data);
-}
-
-static void create_dms_cb(struct qmi_service *service, void *user_data)
-{
-	struct ofono_radio_settings *rs = user_data;
-	struct settings_data *data = ofono_radio_settings_get_data(rs);
-
-	DBG("");
-
-	if (!service)
-		return;
-
-	data->dms = qmi_service_ref(service);
-}
-
 static void create_nas_cb(struct qmi_service *service, void *user_data)
 {
 	struct ofono_radio_settings *rs = user_data;
@@ -261,12 +74,10 @@ static int qmi_radio_settings_probe(struct ofono_radio_settings *rs,
 
 	ofono_radio_settings_set_data(rs, data);
 
-	qmi_service_create_shared(device, QMI_SERVICE_DMS,
-						create_dms_cb, rs, NULL);
-	qmi_service_create_shared(device, QMI_SERVICE_NAS,
-						create_nas_cb, rs, NULL);
+	qmi_service_create(device, QMI_SERVICE_NAS, create_nas_cb, rs, NULL);
 
 	return 0;
+
 }
 
 static void qmi_radio_settings_remove(struct ofono_radio_settings *rs)
@@ -288,9 +99,6 @@ static struct ofono_radio_settings_driver driver = {
 	.name		= "qmimodem",
 	.probe		= qmi_radio_settings_probe,
 	.remove		= qmi_radio_settings_remove,
-	.set_rat_mode	= qmi_set_rat_mode,
-	.query_rat_mode = qmi_query_rat_mode,
-	.query_available_rats = qmi_query_available_rats,
 };
 
 void qmi_radio_settings_init(void)

ofono/drivers/qmimodem/sim.c

@@ -30,7 +30,6 @@
 #include <ofono/sim.h>
 
 #include "qmi.h"
-#include "dms.h"
 #include "uim.h"
 
 #include "qmimodem.h"
@@ -39,36 +38,15 @@
 #define EF_STATUS_INVALIDATED 0
 #define EF_STATUS_VALID 1
 
-/* max number of retry of commands that can temporary fail */
-#define MAX_RETRY_COUNT 100
-
-enum get_card_status_result {
-	GET_CARD_STATUS_RESULT_OK, /* No error */
-	GET_CARD_STATUS_RESULT_ERROR, /* Definitive error */
-	GET_CARD_STATUS_RESULT_TEMP_ERROR, /* error, a retry could work */
-};
-
-/* information from QMI_UIM_GET_CARD_STATUS command */
-struct sim_status {
+struct sim_data {
+	struct qmi_service *uim;
+	uint32_t event_mask;
 	uint8_t card_state;
 	uint8_t app_type;
 	uint8_t passwd_state;
 	int retries[OFONO_SIM_PASSWORD_INVALID];
 };
 
-struct sim_data {
-	struct qmi_device *qmi_dev;
-	struct qmi_service *dms;
-	struct qmi_service *uim;
-	uint32_t event_mask;
-	uint8_t app_type;
-	uint32_t retry_count;
-	guint poll_source;
-};
-
-static void qmi_query_passwd_state(struct ofono_sim *sim,
-				ofono_sim_passwd_cb_t cb, void *user_data);
-
 static int create_fileid_data(uint8_t app_type, int fileid,
 					const unsigned char *path,
 					unsigned int path_len,
@@ -168,7 +146,7 @@ static void qmi_read_attributes(struct ofono_sim *sim, int fileid,
 {
 	struct sim_data *data = ofono_sim_get_data(sim);
 	struct cb_data *cbd = cb_data_new(cb, user_data);
-	unsigned char aid_data[2] = { 0x00, 0x00 };
+	unsigned char aid_data[2] = { 0x06, 0x00 };
 	unsigned char fileid_data[9];
 	int fileid_len;
 	struct qmi_param *param;
@@ -233,7 +211,7 @@ static void qmi_read_transparent(struct ofono_sim *sim,
 {
 	struct sim_data *data = ofono_sim_get_data(sim);
 	struct cb_data *cbd = cb_data_new(cb, user_data);
-	unsigned char aid_data[2] = { 0x00, 0x00 };
+	unsigned char aid_data[2] = { 0x06, 0x00 };
 	unsigned char read_data[4];
 	unsigned char fileid_data[9];
 	int fileid_len;
@@ -279,7 +257,7 @@ static void qmi_read_record(struct ofono_sim *sim,
 {
 	struct sim_data *data = ofono_sim_get_data(sim);
 	struct cb_data *cbd = cb_data_new(cb, user_data);
-	unsigned char aid_data[2] = { 0x00, 0x00 };
+	unsigned char aid_data[2] = { 0x06, 0x00 };
 	unsigned char read_data[4];
 	unsigned char fileid_data[9];
 	int fileid_len;
@@ -317,214 +295,76 @@ error:
 	g_free(cbd);
 }
 
-static void write_generic_cb(struct qmi_result *result, void *user_data)
-{
-	struct cb_data *cbd = user_data;
-	ofono_sim_write_cb_t cb = cbd->cb;
-	uint16_t len;
-	const uint8_t *card_result;
-	uint8_t sw1, sw2;
-
-	card_result = qmi_result_get(result, 0x10, &len);
-	if (card_result == NULL || len != 2) {
-		DBG("card_result: %p, len: %d", card_result, (int) len);
-		CALLBACK_WITH_FAILURE(cb, cbd->data);
-		return;
-	}
-
-	sw1 = card_result[0];
-	sw2 = card_result[1];
-
-	DBG("%02x, %02x", sw1, sw2);
-
-	if ((sw1 != 0x90 && sw1 != 0x91 && sw1 != 0x92 && sw1 != 0x9f) ||
-			(sw1 == 0x90 && sw2 != 0x00)) {
-		struct ofono_error error;
-
-		ofono_error("%s: error sw1 %02x sw2 %02x", __func__, sw1, sw2);
-
-		error.type = OFONO_ERROR_TYPE_SIM;
-		error.error = (sw1 << 8) | sw2;
-
-		cb(&error, cbd->data);
-		return;
-	}
-
-	CALLBACK_WITH_SUCCESS(cb, cbd->data);
-}
-
-static void write_generic(struct ofono_sim *sim,
-			uint16_t qmi_message, int fileid,
-			int start_or_recordnum,
-			int length, const unsigned char *value,
-			const unsigned char *path, unsigned int path_len,
-			ofono_sim_write_cb_t cb, void *user_data)
+static void qmi_query_passwd_state(struct ofono_sim *sim,
+				ofono_sim_passwd_cb_t cb, void *user_data)
 {
 	struct sim_data *data = ofono_sim_get_data(sim);
-	struct cb_data *cbd = cb_data_new(cb, user_data);
-	unsigned char aid_data[2] = { 0x00, 0x00 };
-	unsigned char write_data[4 + length];
-	unsigned char fileid_data[9];
-	int fileid_len;
-	struct qmi_param *param;
 
-	DBG("file id 0x%04x path len %d", fileid, path_len);
+	DBG("passwd state %d", data->passwd_state);
 
-	fileid_len = create_fileid_data(data->app_type, fileid,
-			path, path_len, fileid_data);
-
-	if (fileid_len < 0)
-		goto error;
-
-	write_data[0] = start_or_recordnum & 0xff;
-	write_data[1] = (start_or_recordnum & 0xff00) >> 8;
-	write_data[2] = length & 0xff;
-	write_data[3] = (length & 0xff00) >> 8;
-	memcpy(&write_data[4], value, length);
-
-	param = qmi_param_new();
-	if (!param)
-		goto error;
-
-	qmi_param_append(param, 0x01, sizeof(aid_data), aid_data);
-	qmi_param_append(param, 0x02, fileid_len, fileid_data);
-	qmi_param_append(param, 0x03, 4 + length, write_data);
-
-	if (qmi_service_send(data->uim, qmi_message, param,
-					write_generic_cb, cbd, g_free) > 0)
-		return;
-
-	qmi_param_free(param);
-
-error:
-	CALLBACK_WITH_FAILURE(cb, user_data);
-
-	g_free(cbd);
-}
-
-static void qmi_write_transparent(struct ofono_sim *sim,
-				int fileid, int start, int length,
-				const unsigned char *value,
-				const unsigned char *path,
-				unsigned int path_len,
-				ofono_sim_write_cb_t cb, void *user_data)
-{
-	write_generic(sim, QMI_UIM_WRITE_TRANSPARENT, fileid, start,
-				length, value, path, path_len, cb, user_data);
-}
-
-static void qmi_write_linear(struct ofono_sim *sim,
-				int fileid, int record, int length,
-				const unsigned char *value,
-				const unsigned char *path,
-				unsigned int path_len,
-				ofono_sim_write_cb_t cb, void *user_data)
-{
-	write_generic(sim, QMI_UIM_WRITE_RECORD, fileid, record,
-				length, value, path, path_len, cb, user_data);
-}
-
-static void qmi_write_cyclic(struct ofono_sim *sim,
-				int fileid, int length,
-				const unsigned char *value,
-				const unsigned char *path,
-				unsigned int path_len,
-				ofono_sim_write_cb_t cb, void *user_data)
-{
-	write_generic(sim, QMI_UIM_WRITE_RECORD, fileid, 0,
-				length, value, path, path_len, cb, user_data);
-}
-
-static void get_imsi_cb(struct qmi_result *result, void *user_data)
-{
-	struct cb_data *cbd = user_data;
-	ofono_sim_imsi_cb_t cb = cbd->cb;
-	char *str;
-
-	DBG("");
-
-	if (qmi_result_set_error(result, NULL)) {
-		CALLBACK_WITH_FAILURE(cb, NULL, cbd->data);
+	if (data->passwd_state == OFONO_SIM_PASSWORD_INVALID) {
+		CALLBACK_WITH_FAILURE(cb, -1, user_data);
 		return;
 	}
 
-	str = qmi_result_get_string(result, QMI_DMS_RESULT_IMSI);
-	if (!str) {
-		CALLBACK_WITH_FAILURE(cb, NULL, cbd->data);
-		return;
-	}
-
-	CALLBACK_WITH_SUCCESS(cb, str, cbd->data);
-
-	qmi_free(str);
+	CALLBACK_WITH_SUCCESS(cb, data->passwd_state, user_data);
 }
 
-static void qmi_read_imsi(struct ofono_sim *sim,
-				ofono_sim_imsi_cb_t cb, void *user_data)
+static void qmi_query_pin_retries(struct ofono_sim *sim,
+				ofono_sim_pin_retries_cb_t cb, void *user_data)
 {
 	struct sim_data *data = ofono_sim_get_data(sim);
-	struct cb_data *cbd = cb_data_new(cb, user_data);
 
-	DBG("");
+	DBG("passwd state %d", data->passwd_state);
 
-	if (qmi_service_send(data->dms, QMI_DMS_GET_IMSI, NULL,
-					get_imsi_cb, cbd, g_free) > 0)
+	if (data->passwd_state == OFONO_SIM_PASSWORD_INVALID) {
+		CALLBACK_WITH_FAILURE(cb, NULL, user_data);
 		return;
+	}
 
-	CALLBACK_WITH_FAILURE(cb, NULL, cbd->data);
-
-	g_free(cbd);
+	CALLBACK_WITH_SUCCESS(cb, data->retries, user_data);
 }
 
-/* Return true if a retry could give another (better) result */
-static bool get_card_status(const struct qmi_uim_slot_info *slot,
+static void card_setup(const struct qmi_uim_slot_info *slot,
 					const struct qmi_uim_app_info1 *info1,
 					const struct qmi_uim_app_info2 *info2,
-					struct sim_status *sim_stat)
+							struct sim_data *data)
 {
-	bool need_retry = false;
-	sim_stat->card_state = slot->card_state;
-	sim_stat->app_type = info1->app_type;
+	data->card_state = slot->card_state;
+	data->app_type = info1->app_type;
 
 	switch (info1->app_state) {
 	case 0x02:	/* PIN1 or UPIN is required */
-		sim_stat->passwd_state = OFONO_SIM_PASSWORD_SIM_PIN;
+		data->passwd_state = OFONO_SIM_PASSWORD_SIM_PIN;
 		break;
 	case 0x03:	/* PUK1 or PUK for UPIN is required */
-		sim_stat->passwd_state = OFONO_SIM_PASSWORD_SIM_PUK;
-		break;
-	case 0x04:	/* Personalization state must be checked. */
-		/* This is temporary, we could retry and get another result */
-		sim_stat->passwd_state = OFONO_SIM_PASSWORD_INVALID;
-		need_retry = true;
+		data->passwd_state = OFONO_SIM_PASSWORD_SIM_PUK;
 		break;
 	case 0x07:	/* Ready */
-		sim_stat->passwd_state = OFONO_SIM_PASSWORD_NONE;
+		data->passwd_state = OFONO_SIM_PASSWORD_NONE;
 		break;
 	default:
-		DBG("info1->app_state:0x%x: OFONO_SIM_PASSWORD_INVALID",
-			info1->app_state);
-		sim_stat->passwd_state = OFONO_SIM_PASSWORD_INVALID;
+		data->passwd_state = OFONO_SIM_PASSWORD_INVALID;
 		break;
 	}
 
-	sim_stat->retries[OFONO_SIM_PASSWORD_SIM_PIN] = info2->pin1_retries;
-	sim_stat->retries[OFONO_SIM_PASSWORD_SIM_PUK] = info2->puk1_retries;
+	data->retries[OFONO_SIM_PASSWORD_SIM_PIN] = info2->pin1_retries;
+	data->retries[OFONO_SIM_PASSWORD_SIM_PUK] = info2->puk1_retries;
 
-	sim_stat->retries[OFONO_SIM_PASSWORD_SIM_PIN2] = info2->pin2_retries;
-	sim_stat->retries[OFONO_SIM_PASSWORD_SIM_PUK2] = info2->puk2_retries;
-
-	return need_retry;
+	data->retries[OFONO_SIM_PASSWORD_SIM_PIN2] = info2->pin2_retries;
+	data->retries[OFONO_SIM_PASSWORD_SIM_PUK2] = info2->puk2_retries;
 }
 
-static enum get_card_status_result handle_get_card_status_result(
-		struct qmi_result *result, struct sim_status *sim_stat)
+static void get_card_status_cb(struct qmi_result *result, void *user_data)
 {
+	struct ofono_sim *sim = user_data;
+	struct sim_data *data = ofono_sim_get_data(sim);
 	const void *ptr;
 	const struct qmi_uim_card_status *status;
 	uint16_t len, offset;
 	uint8_t i;
-	enum get_card_status_result res = GET_CARD_STATUS_RESULT_ERROR;
+
+	DBG("");
 
 	if (qmi_result_set_error(result, NULL))
 		goto done;
@@ -557,211 +397,15 @@ static enum get_card_status_result handle_get_card_status_result(
 
 			index = GUINT16_FROM_LE(status->index_gw_pri);
 
-			if ((index & 0xff) == i && (index >> 8) == n) {
-				if (get_card_status(slot, info1, info2,
-								sim_stat))
-					res = GET_CARD_STATUS_RESULT_TEMP_ERROR;
-				else
-					res = GET_CARD_STATUS_RESULT_OK;
-			}
+			if ((index & 0xff) == i && (index >> 8) == n)
+				card_setup(slot, info1, info2, data);
 		}
 	}
 
 done:
-	return res;
-}
-
-static gboolean query_passwd_state_retry(gpointer userdata)
-{
-	struct cb_data *cbd = userdata;
-	ofono_sim_passwd_cb_t cb = cbd->cb;
-	struct ofono_sim *sim = cbd->user;
-	struct sim_data *data = ofono_sim_get_data(sim);
-
-	data->poll_source = 0;
-
-	qmi_query_passwd_state(sim, cb, cbd->data);
-
-	return FALSE;
-}
-
-static void query_passwd_state_cb(struct qmi_result *result,
-					void *user_data)
-{
-	struct cb_data *cbd = user_data;
-	ofono_sim_passwd_cb_t cb = cbd->cb;
-	struct ofono_sim *sim = cbd->user;
-	struct sim_data *data = ofono_sim_get_data(sim);
-	struct sim_status sim_stat;
-	enum get_card_status_result res;
-	struct cb_data *retry_cbd;
-
-	res = handle_get_card_status_result(result, &sim_stat);
-	switch (res) {
-	case GET_CARD_STATUS_RESULT_OK:
-		DBG("passwd state %d", sim_stat.passwd_state);
-		data->retry_count = 0;
-		CALLBACK_WITH_SUCCESS(cb, sim_stat.passwd_state, cbd->data);
-		break;
-	case GET_CARD_STATUS_RESULT_TEMP_ERROR:
-		data->retry_count++;
-		if (data->retry_count > MAX_RETRY_COUNT) {
-			DBG("Failed after %d attempts", data->retry_count);
-			data->retry_count = 0;
-			CALLBACK_WITH_FAILURE(cb, -1, cbd->data);
-		} else {
-			DBG("Retry command");
-			retry_cbd = cb_data_new(cb, cbd->data);
-			retry_cbd->user = sim;
-			data->poll_source = g_timeout_add(20,
-						query_passwd_state_retry,
-						retry_cbd);
-		}
-		break;
-	case GET_CARD_STATUS_RESULT_ERROR:
-		DBG("Command failed");
-		data->retry_count = 0;
-		CALLBACK_WITH_FAILURE(cb, -1, cbd->data);
-		break;
-	}
-}
-
-static void qmi_query_passwd_state(struct ofono_sim *sim,
-				ofono_sim_passwd_cb_t cb, void *user_data)
-{
-	struct sim_data *data = ofono_sim_get_data(sim);
-	struct cb_data *cbd = cb_data_new(cb, user_data);
-
-	DBG("");
-
-	cbd->user = sim;
-
-	if (qmi_service_send(data->uim, QMI_UIM_GET_CARD_STATUS, NULL,
-					query_passwd_state_cb, cbd, g_free) > 0)
-		return;
-
-	CALLBACK_WITH_FAILURE(cb, -1, cbd->data);
-
-	g_free(cbd);
-}
-
-static void query_pin_retries_cb(struct qmi_result *result, void *user_data)
-{
-	struct cb_data *cbd = user_data;
-	ofono_sim_pin_retries_cb_t cb = cbd->cb;
-	struct sim_status sim_stat;
-
-	DBG("");
-
-	if (handle_get_card_status_result(result, &sim_stat) !=
-					GET_CARD_STATUS_RESULT_OK) {
-		CALLBACK_WITH_FAILURE(cb, NULL, cbd->data);
-		return;
-	}
-
-	CALLBACK_WITH_SUCCESS(cb, sim_stat.retries, cbd->data);
-}
-
-static void qmi_query_pin_retries(struct ofono_sim *sim,
-				ofono_sim_pin_retries_cb_t cb, void *user_data)
-{
-	struct sim_data *data = ofono_sim_get_data(sim);
-	struct cb_data *cbd = cb_data_new(cb, user_data);
-
-	DBG("");
-
-	if (qmi_service_send(data->uim, QMI_UIM_GET_CARD_STATUS, NULL,
-					query_pin_retries_cb, cbd, g_free) > 0)
-		return;
-
-	CALLBACK_WITH_FAILURE(cb, NULL, cbd->data);
-
-	g_free(cbd);
-}
-
-static void pin_send_cb(struct qmi_result *result, void *user_data)
-{
-	struct cb_data *cbd = user_data;
-	ofono_sim_lock_unlock_cb_t cb = cbd->cb;
-
-	DBG("");
-
-	if (qmi_result_set_error(result, NULL)) {
-		CALLBACK_WITH_FAILURE(cb, cbd->data);
-		return;
-	}
-
-	CALLBACK_WITH_SUCCESS(cb, cbd->data);
-}
-
-static void qmi_pin_send(struct ofono_sim *sim, const char *passwd,
-			ofono_sim_lock_unlock_cb_t cb, void *user_data)
-{
-	struct sim_data *data = ofono_sim_get_data(sim);
-	struct cb_data *cbd = cb_data_new(cb, user_data);
-	int passwd_len;
-	struct qmi_param *param;
-	struct qmi_uim_param_message_info *info_data;
-	unsigned char session_info_data[2];
-
-	DBG("");
-
-	if (!passwd)
-		goto error;
-
-	passwd_len = strlen(passwd);
-
-	if (passwd_len <= 0 || passwd_len > 0xFF)
-		goto error;
-
-	param = qmi_param_new();
-	if (!param)
-		goto error;
-
-	/* param info */
-	info_data = alloca(2 + passwd_len);
-	info_data->pin_id = 0x01; /* PIN 1 */
-	info_data->length = (uint8_t) passwd_len;
-	memcpy(info_data->pin_value, passwd, passwd_len);
-	qmi_param_append(param, QMI_UIM_PARAM_MESSAGE_INFO, 2 + passwd_len,
-					info_data);
-	/* param Session Information */
-	session_info_data[0] = 0x6;
-	session_info_data[1] = 0x0;
-	qmi_param_append(param, QMI_UIM_PARAM_MESSAGE_SESSION_INFO, 2,
-					session_info_data);
-
-	if (qmi_service_send(data->uim, QMI_UIM_VERIFY_PIN, param,
-					pin_send_cb, cbd, g_free) > 0)
-		return;
-
-	qmi_param_free(param);
-
-error:
-	CALLBACK_WITH_FAILURE(cb, cbd->data);
-
-	g_free(cbd);
-}
-
-static void get_card_status_cb(struct qmi_result *result, void *user_data)
-{
-	struct ofono_sim *sim = user_data;
-	struct sim_data *data = ofono_sim_get_data(sim);
-	struct sim_status sim_stat;
-
-	DBG("");
-
-	if (handle_get_card_status_result(result, &sim_stat) !=
-					GET_CARD_STATUS_RESULT_OK) {
-		data->app_type = 0;	/* Unknown */
-		sim_stat.card_state = 0x00;	/* Absent */
-	} else {
-		data->app_type = sim_stat.app_type;
-	}
-
 	ofono_sim_register(sim);
 
-	switch (sim_stat.card_state) {
+	switch (data->card_state) {
 	case 0x00:	/* Absent */
 	case 0x02:	/* Error */
 		break;
@@ -821,44 +465,30 @@ static void create_uim_cb(struct qmi_service *service, void *user_data)
 		return;
 
 error:
+	qmi_service_unref(data->uim);
+
 	ofono_sim_remove(sim);
 }
 
-static void create_dms_cb(struct qmi_service *service, void *user_data)
-{
-	struct ofono_sim *sim = user_data;
-	struct sim_data *data = ofono_sim_get_data(sim);
-
-	DBG("");
-
-	if (!service) {
-		ofono_error("Failed to request DMS service");
-		ofono_sim_remove(sim);
-		return;
-	}
-
-	data->dms = qmi_service_ref(service);
-
-	qmi_service_create(data->qmi_dev, QMI_SERVICE_UIM, create_uim_cb, sim,
-					NULL);
-}
-
 static int qmi_sim_probe(struct ofono_sim *sim,
 				unsigned int vendor, void *user_data)
 {
 	struct qmi_device *device = user_data;
 	struct sim_data *data;
+	int i;
 
 	DBG("");
 
 	data = g_new0(struct sim_data, 1);
 
-	data->qmi_dev = device;
+	data->passwd_state = OFONO_SIM_PASSWORD_INVALID;
+
+	for (i = 0; i < OFONO_SIM_PASSWORD_INVALID; i++)
+		data->retries[i] = -1;
 
 	ofono_sim_set_data(sim, data);
 
-	qmi_service_create_shared(device, QMI_SERVICE_DMS,
-						create_dms_cb, sim, NULL);
+	qmi_service_create(device, QMI_SERVICE_UIM, create_uim_cb, sim, NULL);
 
 	return 0;
 }
@@ -871,18 +501,9 @@ static void qmi_sim_remove(struct ofono_sim *sim)
 
 	ofono_sim_set_data(sim, NULL);
 
-	if (data->poll_source > 0)
-		g_source_remove(data->poll_source);
+	qmi_service_unregister_all(data->uim);
 
-	if (data->uim) {
-		qmi_service_unregister_all(data->uim);
-		qmi_service_unref(data->uim);
-		data->uim = NULL;
-	}
-	if (data->dms) {
-		qmi_service_unregister_all(data->dms);
-		qmi_service_unref(data->dms);
-	}
+	qmi_service_unref(data->uim);
 
 	g_free(data);
 }
@@ -895,13 +516,8 @@ static struct ofono_sim_driver driver = {
 	.read_file_transparent	= qmi_read_transparent,
 	.read_file_linear	= qmi_read_record,
 	.read_file_cyclic	= qmi_read_record,
-	.write_file_transparent = qmi_write_transparent,
-	.write_file_linear	= qmi_write_linear,
-	.write_file_cyclic	= qmi_write_cyclic,
-	.read_imsi		= qmi_read_imsi,
 	.query_passwd_state	= qmi_query_passwd_state,
 	.query_pin_retries	= qmi_query_pin_retries,
-	.send_passwd		= qmi_pin_send,
 };
 
 void qmi_sim_init(void)

ofono/drivers/qmimodem/sms.c

@@ -277,7 +277,7 @@ static void qmi_bearer_query(struct ofono_sms *sms,
 
 	DBG("");
 
-	if (data->major < 1 || (data->major == 1 && data->minor < 2))
+	if (data->major < 1 && data->minor < 2)
 		goto error;
 
 	if (qmi_service_send(data->wms, QMI_WMS_GET_DOMAIN_PREF, NULL,
@@ -315,7 +315,7 @@ static void qmi_bearer_set(struct ofono_sms *sms, int bearer,
 
 	DBG("bearer %d", bearer);
 
-	if (data->major < 1 || (data->major == 1 && data->minor < 2))
+	if (data->major < 1 && data->minor < 2)
 		goto error;
 
 	domain = bearer_to_domain(bearer);
@@ -411,7 +411,7 @@ static void get_routes_cb(struct qmi_result *result, void *user_data)
 	new_list->count = GUINT16_TO_LE(1);
 	new_list->route[0].msg_type = QMI_WMS_MSG_TYPE_P2P;
 	new_list->route[0].msg_class = QMI_WMS_MSG_CLASS_NONE;
-	new_list->route[0].storage_type = QMI_WMS_STORAGE_TYPE_NONE;
+	new_list->route[0].storage_type = QMI_WMS_STORAGE_TYPE_NV;
 	new_list->route[0].action = QMI_WMS_ACTION_TRANSFER_AND_ACK;
 
 	param = qmi_param_new();

ofono/drivers/qmimodem/uim.h

@@ -25,8 +25,6 @@
 #define QMI_UIM_WRITE_RECORD		35	/* Write a record */
 #define QMI_UIM_GET_FILE_ATTRIBUTES	36	/* Get file attributes */
 
-#define QMI_UIM_VERIFY_PIN		38	/* Verify PIN */
-
 #define QMI_UIM_EVENT_REGISTRATION	46	/* Register for indications */
 #define QMI_UIM_GET_CARD_STATUS		47	/* Get card status */
 
@@ -93,12 +91,3 @@ struct qmi_uim_file_attributes {
 	uint16_t raw_len;
 	uint8_t raw_value[0];
 } __attribute__((__packed__));
-
-/* Verify PIN parameter */
-#define QMI_UIM_PARAM_MESSAGE_SESSION_INFO	0x01
-#define QMI_UIM_PARAM_MESSAGE_INFO	0x02
-struct qmi_uim_param_message_info {
-	uint8_t pin_id;
-	uint8_t length;
-	uint8_t pin_value[0];
-} __attribute__((__packed__));

ofono/drivers/qmimodem/wda.h

@@ -1,25 +0,0 @@
-/*
- *
- *  oFono - Open Source Telephony
- *
- *  Copyright (C) 2017  Kerlink SA. All rights reserved.
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *
- */
-
-#define QMI_WDA_SET_DATA_FORMAT	32	/* Set data format */
-#define QMI_WDA_GET_DATA_FORMAT	33	/* Get data format */
-
-/* Get and set data format interface */
-#define QMI_WDA_LL_PROTOCOL	0x11	/* uint32_t */
-#define QMI_WDA_DATA_LINK_PROTOCOL_UNKNOWN	0
-#define QMI_WDA_DATA_LINK_PROTOCOL_802_3	1
-#define QMI_WDA_DATA_LINK_PROTOCOL_RAW_IP	2

ofono/drivers/qmimodem/wds.h

@@ -30,13 +30,6 @@
 /* Start WDS network interface */
 #define QMI_WDS_PARAM_APN			0x14	/* string */
 #define QMI_WDS_PARAM_IP_FAMILY			0x19	/* uint8 */
-#define QMI_WDS_PARAM_USERNAME			0x17	/* string */
-#define QMI_WDS_PARAM_PASSWORD			0x18	/* string */
-#define QMI_WDS_PARAM_AUTHENTICATION_PREFERENCE	0x16	/* uint8 */
-
-#define QMI_WDS_AUTHENTICATION_NONE		0x0
-#define QMI_WDS_AUTHENTICATION_PAP		0x1
-#define QMI_WDS_AUTHENTICATION_CHAP		0x2
 
 #define QMI_WDS_RESULT_PKT_HANDLE		0x01	/* uint32 */
 
@@ -58,12 +51,10 @@ struct qmi_wds_notify_conn_status {
 
 /* Get the runtime data session settings */
 #define QMI_WDS_RESULT_PDP_TYPE			0x11	/* uint8 */
-#define QMI_WDS_RESULT_APN			0x14	/* string */
 #define QMI_WDS_RESULT_PRIMARY_DNS		0x15	/* uint32 IPv4 */
 #define QMI_WDS_RESULT_SECONDARY_DNS		0x16	/* uint32 IPv4 */
 #define QMI_WDS_RESULT_IP_ADDRESS		0x1e	/* uint32 IPv4 */
 #define QMI_WDS_RESULT_GATEWAY			0x20	/* uint32 IPv4 */
-#define QMI_WDS_RESULT_GATEWAY_NETMASK		0x21	/* uint32 IPv4 */
 #define QMI_WDS_RESULT_IP_FAMILY		0x2b	/* uint8 */
 
 #define QMI_WDS_PDP_TYPE_IPV4			0x00

ofono/drivers/qmimodem/wms.h

@@ -62,7 +62,6 @@ struct qmi_wms_param_message {
 #define QMI_WMS_STORAGE_TYPE_UIM		0
 #define QMI_WMS_STORAGE_TYPE_NV			1
 #define QMI_WMS_STORAGE_TYPE_UNKNOWN		2
-#define QMI_WMS_STORAGE_TYPE_NONE		255
 
 #define QMI_WMS_MESSAGE_MODE_GSMWCDMA		1
 

ofono/drivers/ril/ril_call_barring.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2018 Jolla Ltd.
+ *  Copyright (C) 2015 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -14,9 +14,9 @@
  */
 
 #include "ril_plugin.h"
-#include "ril_sim_card.h"
 #include "ril_util.h"
 #include "ril_log.h"
+#include "ril_constants.h"
 
 #include "common.h"
 
@@ -27,11 +27,11 @@
  * ril.h does not state that string count must be given, but that is
  * still expected by the modem
  */
+#define RIL_QUERY_STRING_COUNT 4
 #define RIL_SET_STRING_COUNT 5
 #define RIL_SET_PW_STRING_COUNT 3
 
 struct ril_call_barring {
-	struct ril_sim_card *card;
 	GRilIoQueue *q;
 	guint timer_id;
 };
@@ -107,7 +107,7 @@ static void ril_call_barring_query(struct ofono_call_barring *b,
 {
 	struct ril_call_barring *bd = ofono_call_barring_get_data(b);
 	char cls_textual[RIL_MAX_SERVICE_LENGTH];
-	GRilIoRequest *req;
+	GRilIoRequest *req = grilio_request_new();
 
 	DBG("lock: %s, services to query: %d", lock, cls);
 
@@ -124,9 +124,15 @@ static void ril_call_barring_query(struct ofono_call_barring *b,
 
 	/*
 	 * See 3GPP 27.007 7.4 for parameter descriptions.
+	 * According to ril.h password should be empty string "" when not
+	 * needed, but in reality we only need to give string length as 0
 	 */
-	req = grilio_request_array_utf8_new(4, lock, "", cls_textual,
-					ril_sim_card_app_aid(bd->card));
+	grilio_request_append_int32(req, RIL_QUERY_STRING_COUNT);
+	grilio_request_append_utf8(req, lock);    /* Facility code */
+	grilio_request_append_int32(req, 0);      /* Password length */
+	grilio_request_append_utf8(req, cls_textual);
+	grilio_request_append_utf8(req, NULL);    /* AID (not yet supported) */
+
 	ril_call_barring_submit_request(bd, req,
 				RIL_REQUEST_QUERY_FACILITY_LOCK,
 				ril_call_barring_query_cb, cb, data);
@@ -177,7 +183,7 @@ static void ril_call_barring_set(struct ofono_call_barring *b,
 					RIL_FACILITY_UNLOCK);
 	grilio_request_append_utf8(req, passwd);
 	grilio_request_append_utf8(req, cls_textual);
-	grilio_request_append_utf8(req, ril_sim_card_app_aid(bd->card));
+	grilio_request_append_utf8(req, NULL);  /* AID (not yet supported) */
 
 	ril_call_barring_submit_request(bd, req,
 				RIL_REQUEST_SET_FACILITY_LOCK,
@@ -238,7 +244,6 @@ static int ril_call_barring_probe(struct ofono_call_barring *b,
 	struct ril_call_barring *bd = g_new0(struct ril_call_barring, 1);
 
 	DBG("");
-	bd->card = ril_sim_card_ref(modem->sim_card);
 	bd->q = grilio_queue_new(ril_modem_io(modem));
 	bd->timer_id = g_idle_add(ril_call_barring_register, b);
 	ofono_call_barring_set_data(b, bd);
@@ -256,7 +261,6 @@ static void ril_call_barring_remove(struct ofono_call_barring *b)
 		g_source_remove(bd->timer_id);
 	}
 
-	ril_sim_card_unref(bd->card);
 	grilio_queue_cancel_all(bd->q, FALSE);
 	grilio_queue_unref(bd->q);
 	g_free(bd);

ofono/drivers/ril/ril_call_forward.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2017 Jolla Ltd.
+ *  Copyright (C) 2015-2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -16,6 +16,7 @@
 #include "ril_plugin.h"
 #include "ril_util.h"
 #include "ril_log.h"
+#include "ril_constants.h"
 
 #include "common.h"
 

ofono/drivers/ril/ril_call_settings.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2017 Jolla Ltd.
+ *  Copyright (C) 2015 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -16,6 +16,7 @@
 #include "ril_plugin.h"
 #include "ril_util.h"
 #include "ril_log.h"
+#include "ril_constants.h"
 
 #include "common.h"
 

ofono/drivers/ril/ril_call_volume.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2017 Jolla Ltd.
+ *  Copyright (C) 2015 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -16,6 +16,7 @@
 #include "ril_plugin.h"
 #include "ril_util.h"
 #include "ril_log.h"
+#include "ril_constants.h"
 
 struct ril_call_volume {
 	struct ofono_call_volume *v;

ofono/drivers/ril/ril_cbs.c

@@ -184,14 +184,11 @@ static int ril_cbs_probe(struct ofono_cbs *cbs, unsigned int vendor,
 	cd->q = grilio_queue_new(cd->io);
 
 	/*
-	 * RIL_REQUEST_GSM_GET_BROADCAST_SMS_CONFIG often fails at startup
-	 * especially if other RIL requests are running in parallel. We may
-	 * have to retry a few times. Also, make it blocking in order to
-	 * improve the chance of success.
+	 * RIL_REQUEST_GSM_GET_BROADCAST_SMS_CONFIG often fails at startup.
+	 * We may have to retry a few times.
 	 */
 	grilio_request_set_retry(req, RIL_CBS_CHECK_RETRY_MS,
 						RIL_CBS_CHECK_RETRY_COUNT);
-	grilio_request_set_blocking(req, TRUE);
 	grilio_queue_send_request_full(cd->q, req,
 				RIL_REQUEST_GSM_GET_BROADCAST_SMS_CONFIG,
 				ril_cbs_probe_done_cb, NULL, cd);

ofono/drivers/ril/ril_cell_info.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2016-2018 Jolla Ltd.
+ *  Copyright (C) 2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -23,19 +23,15 @@
 #include <grilio_request.h>
 #include <grilio_parser.h>
 
-#include <gutil_idlepool.h>
 #include <gutil_misc.h>
 
 #define DISPLAY_ON_UPDATE_RATE  (1000)  /* 1 sec */
 #define DISPLAY_OFF_UPDATE_RATE (60000) /* 1 min */
-#define MAX_RETRIES             (5)
 
 typedef GObjectClass RilCellInfoClass;
 typedef struct ril_cell_info RilCellInfo;
 
-struct ril_cell_info {
-	GObject object;
-	struct sailfish_cell_info info;
+struct ril_cell_info_priv {
 	GRilIoChannel *io;
 	MceDisplay *display;
 	struct ril_radio *radio;
@@ -64,36 +60,63 @@ G_DEFINE_TYPE(RilCellInfo, ril_cell_info, G_TYPE_OBJECT)
 #define RIL_CELL_INFO(obj) (G_TYPE_CHECK_INSTANCE_CAST((obj),\
 	RIL_CELL_INFO_TYPE, RilCellInfo))
 
-#define DBG_(self,fmt,args...) DBG("%s" fmt, (self)->log_prefix, ##args)
+#define DBG_(self,fmt,args...) DBG("%s" fmt, (self)->priv->log_prefix, ##args)
 
-static inline void ril_cell_free(struct sailfish_cell *cell)
+gint ril_cell_compare_location(const struct ril_cell *c1,
+					const struct ril_cell *c2)
 {
-	g_slice_free(struct sailfish_cell, cell);
-}
+	if (c1 && c2) {
+		if (c1->type != c2->type) {
+			return c1->type - c2->type;
+		} else if (c1->type == RIL_CELL_INFO_TYPE_GSM) {
+			const struct ril_cell_info_gsm *g1 = &c1->info.gsm;
+			const struct ril_cell_info_gsm *g2 = &c2->info.gsm;
 
-static void ril_cell_free1(gpointer cell)
-{
-	ril_cell_free(cell);
-}
+			if (g1->lac != g2->lac) {
+				return g1->lac - g2->lac;
+			} else {
+				return g1->cid - g2->cid;
+			}
+		} else if (c2->type == RIL_CELL_INFO_TYPE_WCDMA) {
+			const struct ril_cell_info_wcdma *w1 = &c1->info.wcdma;
+			const struct ril_cell_info_wcdma *w2 = &c2->info.wcdma;
 
-static const char *ril_cell_info_int_format(int value, const char *format)
-{
-	if (value == SAILFISH_CELL_INVALID_VALUE) {
-		return "";
+			if (w1->lac != w2->lac) {
+				return w1->lac - w2->lac;
+			} else {
+				return w1->cid - w2->cid;
+			}
+		} else {
+			const struct ril_cell_info_lte *l1 = &c1->info.lte;
+			const struct ril_cell_info_lte *l2 = &c2->info.lte;
+
+			GASSERT(c1->type == RIL_CELL_INFO_TYPE_LTE);
+			if (l1->ci != l2->ci) {
+				return l1->ci - l2->ci;
+			} else if (l1->pci != l2->pci) {
+				return l1->pci - l2->pci;
+			} else {
+				return l1->tac - l2->tac;
+			}
+		}
+	} else if (c1) {
+		return 1;
+	} else if (c2) {
+		return -1;
 	} else {
-		static GUtilIdlePool *ril_cell_info_pool = NULL;
-		GUtilIdlePool *pool = gutil_idle_pool_get(&ril_cell_info_pool);
-		char *str = g_strdup_printf(format, value);
-
-		gutil_idle_pool_add(pool, str, g_free);
-		return str;
+		return 0;
 	}
 }
 
+gint ril_cell_compare_func(gconstpointer v1, gconstpointer v2)
+{
+	return ril_cell_compare_location(v1, v2);
+}
+
 static gboolean ril_cell_info_list_identical(GSList *l1, GSList *l2)
 {
 	while (l1 && l2) {
-		if (memcmp(l1->data, l2->data, sizeof(struct sailfish_cell))) {
+		if (memcmp(l1->data, l2->data, sizeof(struct ril_cell))) {
 			return FALSE;
 		}
 		l1 = l1->next;
@@ -104,166 +127,121 @@ static gboolean ril_cell_info_list_identical(GSList *l1, GSList *l2)
 
 static void ril_cell_info_update_cells(struct ril_cell_info *self, GSList *l)
 {
-	if (!ril_cell_info_list_identical(self->info.cells, l)) {
-		g_slist_free_full(self->info.cells, ril_cell_free1);
-		self->info.cells = l;
-		g_signal_emit(self, ril_cell_info_signals
-			[SIGNAL_CELLS_CHANGED], 0);
+	if (!ril_cell_info_list_identical(self->cells, l)) {
+		g_slist_free_full(self->cells, g_free);
+		self->cells = l;
+		g_signal_emit(self, ril_cell_info_signals[
+						SIGNAL_CELLS_CHANGED], 0);
 	} else {
-		g_slist_free_full(l, ril_cell_free1);
+		g_slist_free_full(l, g_free);
 	}
 }
 
-static struct sailfish_cell *ril_cell_info_parse_cell_gsm(GRilIoParser *rilp,
-					guint version, gboolean registered)
+static struct ril_cell *ril_cell_info_parse_cell_gsm(GRilIoParser *rilp,
+							gboolean registered)
 {
-	struct sailfish_cell *cell = g_slice_new0(struct sailfish_cell);
-	struct sailfish_cell_info_gsm *gsm = &cell->info.gsm;
+	struct ril_cell *cell = g_new0(struct ril_cell, 1);
+	struct ril_cell_info_gsm *gsm = &cell->info.gsm;
 
-	/* Optional RIL_CellIdentityGsm_v12 part */
-	gsm->arfcn = SAILFISH_CELL_INVALID_VALUE;
-	gsm->bsic = SAILFISH_CELL_INVALID_VALUE;
-	/* Optional RIL_GSM_SignalStrength_v12 part */
-	gsm->timingAdvance = SAILFISH_CELL_INVALID_VALUE;
-	/* RIL_CellIdentityGsm */
 	if (grilio_parser_get_int32(rilp, &gsm->mcc) &&
 		grilio_parser_get_int32(rilp, &gsm->mnc) &&
 		grilio_parser_get_int32(rilp, &gsm->lac) &&
 		grilio_parser_get_int32(rilp, &gsm->cid) &&
-		(version < 12 || /* RIL_CellIdentityGsm_v12 part */
-			(grilio_parser_get_int32(rilp, &gsm->arfcn) &&
-			grilio_parser_get_int32(rilp, &gsm->bsic))) &&
-		/* RIL_GW_SignalStrength */
 		grilio_parser_get_int32(rilp, &gsm->signalStrength) &&
-		grilio_parser_get_int32(rilp, &gsm->bitErrorRate) &&
-		(version < 12 || /* RIL_GSM_SignalStrength_v12 part */
-			grilio_parser_get_int32(rilp, &gsm->timingAdvance))) {
-		DBG("[gsm] reg=%d%s%s%s%s%s%s%s%s%s", registered,
-			ril_cell_info_int_format(gsm->mcc, ",mcc=%d"),
-			ril_cell_info_int_format(gsm->mnc, ",mnc=%d"),
-			ril_cell_info_int_format(gsm->lac, ",lac=%d"),
-			ril_cell_info_int_format(gsm->cid, ",cid=%d"),
-			ril_cell_info_int_format(gsm->arfcn, ",arfcn=%d"),
-			ril_cell_info_int_format(gsm->bsic, ",bsic=%d"),
-			ril_cell_info_int_format(gsm->signalStrength,
-							",strength=%d"),
-			ril_cell_info_int_format(gsm->bitErrorRate, ",err=%d"),
-			ril_cell_info_int_format(gsm->timingAdvance, ",t=%d"));
-		cell->type = SAILFISH_CELL_TYPE_GSM;
+		grilio_parser_get_int32(rilp, &gsm->bitErrorRate)) {
+		DBG("[gsm] reg=%d,mcc=%d,mnc=%d,lac=%d,cid=%d,"
+			"strength=%d,err=%d", registered, gsm->mcc, gsm->mnc,
+			gsm->lac, gsm->cid, gsm->signalStrength,
+			gsm->bitErrorRate);
+		cell->type = RIL_CELL_INFO_TYPE_GSM;
 		cell->registered = registered;
 		return cell;
 	}
 
 	ofono_error("failed to parse GSM cell info");
-	ril_cell_free(cell);
+	g_free(cell);
 	return NULL;
 }
 
-static struct sailfish_cell *ril_cell_info_parse_cell_wcdma(GRilIoParser *rilp,
-					guint version, gboolean registered)
+static struct ril_cell *ril_cell_info_parse_cell_wcdma(GRilIoParser *rilp,
+							gboolean registered)
 {
-	struct sailfish_cell *cell = g_slice_new0(struct sailfish_cell);
-	struct sailfish_cell_info_wcdma *wcdma = &cell->info.wcdma;
+	struct ril_cell *cell = g_new0(struct ril_cell, 1);
+	struct ril_cell_info_wcdma *wcdma = &cell->info.wcdma;
 
-	/* Optional RIL_CellIdentityWcdma_v12 part */
-	wcdma->uarfcn = SAILFISH_CELL_INVALID_VALUE;
 	if (grilio_parser_get_int32(rilp, &wcdma->mcc) &&
 		grilio_parser_get_int32(rilp, &wcdma->mnc) &&
 		grilio_parser_get_int32(rilp, &wcdma->lac) &&
 		grilio_parser_get_int32(rilp, &wcdma->cid) &&
 		grilio_parser_get_int32(rilp, &wcdma->psc) &&
-		(version < 12 || /* RIL_CellIdentityWcdma_v12 part */
-			grilio_parser_get_int32(rilp, &wcdma->uarfcn)) &&
 		grilio_parser_get_int32(rilp, &wcdma->signalStrength) &&
 		grilio_parser_get_int32(rilp, &wcdma->bitErrorRate)) {
-		DBG("[wcdma] reg=%d%s%s%s%s%s%s%s", registered,
-			ril_cell_info_int_format(wcdma->mcc, ",mcc=%d"),
-			ril_cell_info_int_format(wcdma->mnc, ",mnc=%d"),
-			ril_cell_info_int_format(wcdma->lac, ",lac=%d"),
-			ril_cell_info_int_format(wcdma->cid, ",cid=%d"),
-			ril_cell_info_int_format(wcdma->psc, ",psc=%d"),
-			ril_cell_info_int_format(wcdma->signalStrength,
-							",strength=%d"),
-			ril_cell_info_int_format(wcdma->bitErrorRate,
-							",err=%d"));
-		cell->type = SAILFISH_CELL_TYPE_WCDMA;
+		DBG("[wcdma] reg=%d,mcc=%d,mnc=%d,lac=%d,cid=%d,psc=%d,"
+			"strength=%d,err=%d", registered, wcdma->mcc,
+			wcdma->mnc, wcdma->lac, wcdma->cid, wcdma->psc,
+			wcdma->signalStrength, wcdma->bitErrorRate);
+		cell->type = RIL_CELL_INFO_TYPE_WCDMA;
 		cell->registered = registered;
 		return cell;
 	}
 
 	ofono_error("failed to parse WCDMA cell info");
-	ril_cell_free(cell);
+	g_free(cell);
 	return NULL;
 }
 
-static struct sailfish_cell *ril_cell_info_parse_cell_lte(GRilIoParser *rilp,
-					guint version, gboolean registered)
+static struct ril_cell *ril_cell_info_parse_cell_lte(GRilIoParser *rilp,
+							gboolean registered)
 {
-	struct sailfish_cell *cell = g_slice_new0(struct sailfish_cell);
-	struct sailfish_cell_info_lte *lte = &cell->info.lte;
+	struct ril_cell *cell = g_new0(struct ril_cell, 1);
+	struct ril_cell_info_lte *lte = &cell->info.lte;
 
-	/* Optional RIL_CellIdentityLte_v12 part */
-	lte->earfcn = SAILFISH_CELL_INVALID_VALUE;
 	if (grilio_parser_get_int32(rilp, &lte->mcc) &&
 		grilio_parser_get_int32(rilp, &lte->mnc) &&
 		grilio_parser_get_int32(rilp, &lte->ci) &&
 		grilio_parser_get_int32(rilp, &lte->pci) &&
 		grilio_parser_get_int32(rilp, &lte->tac) &&
-		(version < 12 || /* RIL_CellIdentityLte_v12 part */
-			grilio_parser_get_int32(rilp, &lte->earfcn)) &&
 		grilio_parser_get_int32(rilp, &lte->signalStrength) &&
 		grilio_parser_get_int32(rilp, &lte->rsrp) &&
 		grilio_parser_get_int32(rilp, &lte->rsrq) &&
 		grilio_parser_get_int32(rilp, &lte->rssnr) &&
 		grilio_parser_get_int32(rilp, &lte->cqi) &&
 		grilio_parser_get_int32(rilp, &lte->timingAdvance)) {
-		DBG("[lte] reg=%d%s%s%s%s%s%s%s%s%s%s%s", registered,
-			ril_cell_info_int_format(lte->mcc, ",mcc=%d"),
-			ril_cell_info_int_format(lte->mnc, ",mnc=%d"),
-			ril_cell_info_int_format(lte->ci, ",ci=%d"),
-			ril_cell_info_int_format(lte->pci, ",pci=%d"),
-			ril_cell_info_int_format(lte->tac, ",tac=%d"),
-			ril_cell_info_int_format(lte->signalStrength,
-							",strength=%d"),
-			ril_cell_info_int_format(lte->rsrp, ",rsrp=%d"),
-			ril_cell_info_int_format(lte->rsrq, ",rsrq=%d"),
-			ril_cell_info_int_format(lte->rssnr, ",rssnr=%d"),
-			ril_cell_info_int_format(lte->cqi, ",cqi=%d"),
-			ril_cell_info_int_format(lte->timingAdvance, ",t=%d"));
-		cell->type = SAILFISH_CELL_TYPE_LTE;
+		DBG("[lte] reg=%d,mcc=%d,mnc=%d,ci=%d,pci=%d,tac=%d,"
+			"strength=%d,rsrp=%d,rsrq=0x%x,rssnr=0x%x,cqi=%d,"
+			"t=0x%x", registered, lte->mcc, lte->mnc, lte->ci,
+			lte->pci, lte->tac, lte->signalStrength, lte->rsrp,
+			lte->rsrq, lte->rssnr, lte->cqi, lte->timingAdvance);
+		cell->type = RIL_CELL_INFO_TYPE_LTE;
 		cell->registered = registered;
 		return cell;
 	}
 
 	ofono_error("failed to parse LTE cell info");
-	ril_cell_free(cell);
+	g_free(cell);
 	return NULL;
 }
 
-static gboolean ril_cell_info_parse_cell(GRilIoParser *rilp, guint v,
-					struct sailfish_cell **cell_ptr)
+static enum ril_cell_info_type ril_cell_info_parse_cell(GRilIoParser *rilp,
+						struct ril_cell **cell_ptr)
 {
 	int type, reg;
 
 	if (grilio_parser_get_int32(rilp, &type) &&
 			grilio_parser_get_int32(rilp, &reg) &&
-			/* Skip timestamp */
 			grilio_parser_get_int32_array(rilp, NULL, 3)) {
 		int skip = 0;
-		struct sailfish_cell *cell = NULL;
-
-		/* Normalize the boolean value */
-		reg = (reg != FALSE);
+		struct ril_cell *cell = NULL;
 
 		switch (type) {
 		case RIL_CELL_INFO_TYPE_GSM:
-			cell = ril_cell_info_parse_cell_gsm(rilp, v, reg);
+			cell = ril_cell_info_parse_cell_gsm(rilp, reg);
 			break;
 		case RIL_CELL_INFO_TYPE_WCDMA:
-			cell = ril_cell_info_parse_cell_wcdma(rilp, v, reg);
+			cell = ril_cell_info_parse_cell_wcdma(rilp, reg);
 			break;
 		case RIL_CELL_INFO_TYPE_LTE:
-			cell = ril_cell_info_parse_cell_lte(rilp, v, reg);
+			cell = ril_cell_info_parse_cell_lte(rilp, reg);
 			break;
 		case RIL_CELL_INFO_TYPE_CDMA:
 			skip = 10;
@@ -278,20 +256,20 @@ static gboolean ril_cell_info_parse_cell(GRilIoParser *rilp, guint v,
 
 		if (cell) {
 			*cell_ptr = cell;
-			return TRUE;
+			return type;
 		}
 
 		if (skip && grilio_parser_get_int32_array(rilp, NULL, skip)) {
 			*cell_ptr = NULL;
-			return TRUE;
+			return type;
 		}
 	}
 
 	*cell_ptr = NULL;
-	return FALSE;
+	return RIL_CELL_INFO_TYPE_NONE;
 }
 
-static GSList *ril_cell_info_parse_list(guint v, const void *data, guint len)
+static GSList *ril_cell_info_parse_list(const void *data, guint len)
 {
 	GSList *l = NULL;
 	GRilIoParser rilp;
@@ -299,18 +277,17 @@ static GSList *ril_cell_info_parse_list(guint v, const void *data, guint len)
 
 	grilio_parser_init(&rilp, data, len);
 	if (grilio_parser_get_int32(&rilp, &n) && n > 0) {
-		struct sailfish_cell *c;
+		struct ril_cell *c;
 
 		DBG("%d cell(s):", n);
-		for (i=0; i<n && ril_cell_info_parse_cell(&rilp, v, &c); i++) {
+		for (i=0; i<n && ril_cell_info_parse_cell(&rilp, &c); i++) {
 			if (c) {
 				l = g_slist_insert_sorted(l, c,
-						sailfish_cell_compare_func);
+						ril_cell_compare_func);
 			}
 		}
 	}
 
-	GASSERT(grilio_parser_at_end(&rilp));
 	return l;
 }
 
@@ -320,39 +297,40 @@ static void ril_cell_info_list_changed_cb(GRilIoChannel *io, guint code,
 	struct ril_cell_info *self = RIL_CELL_INFO(user_data);
 
 	DBG_(self, "");
-	ril_cell_info_update_cells(self, ril_cell_info_parse_list
-						(io->ril_version, data, len));
+	ril_cell_info_update_cells(self, ril_cell_info_parse_list(data, len));
 }
 
 static void ril_cell_info_list_cb(GRilIoChannel *io, int status,
 				const void *data, guint len, void *user_data)
 {
 	struct ril_cell_info *self = RIL_CELL_INFO(user_data);
+	struct ril_cell_info_priv *priv = self->priv;
 
 	DBG_(self, "");
-	GASSERT(self->query_id);
-	self->query_id = 0;
-	ril_cell_info_update_cells(self, (status == RIL_E_SUCCESS) ?
-		ril_cell_info_parse_list(io->ril_version, data, len) : NULL);
+	GASSERT(priv->query_id);
+	priv->query_id = 0;
+	ril_cell_info_update_cells(self, ril_cell_info_parse_list(data, len));
 }
 
 static void ril_cell_info_set_rate_cb(GRilIoChannel *io, int status,
 				const void *data, guint len, void *user_data)
 {
 	struct ril_cell_info *self = RIL_CELL_INFO(user_data);
+	struct ril_cell_info_priv *priv = self->priv;
 
 	DBG_(self, "");
-	GASSERT(self->set_rate_id);
-	self->set_rate_id = 0;
+	GASSERT(priv->set_rate_id);
+	priv->set_rate_id = 0;
 }
 
 static void ril_cell_info_query(struct ril_cell_info *self)
 {
+	struct ril_cell_info_priv *priv = self->priv;
 	GRilIoRequest *req = grilio_request_new();
 
-	grilio_request_set_retry(req, RIL_RETRY_MS, MAX_RETRIES);
-	grilio_channel_cancel_request(self->io, self->query_id, FALSE);
-	self->query_id = grilio_channel_send_request_full(self->io, req,
+	grilio_request_set_retry(req, RIL_RETRY_MS, -1);
+	grilio_channel_cancel_request(priv->io, priv->query_id, FALSE);
+	priv->query_id = grilio_channel_send_request_full(priv->io, req,
 		RIL_REQUEST_GET_CELL_INFO_LIST, ril_cell_info_list_cb,
 		NULL, self);
 	grilio_request_unref(req);
@@ -360,13 +338,14 @@ static void ril_cell_info_query(struct ril_cell_info *self)
 
 static void ril_cell_info_set_rate(struct ril_cell_info *self, int ms)
 {
+	struct ril_cell_info_priv *priv = self->priv;
 	GRilIoRequest *req = grilio_request_sized_new(8);
 
 	grilio_request_append_int32(req, 1);
 	grilio_request_append_int32(req, ms);
-	grilio_request_set_retry(req, RIL_RETRY_MS, MAX_RETRIES);
-	grilio_channel_cancel_request(self->io, self->set_rate_id, FALSE);
-	self->set_rate_id = grilio_channel_send_request_full(self->io, req,
+	grilio_request_set_retry(req, RIL_RETRY_MS, -1);
+	grilio_channel_cancel_request(priv->io, priv->set_rate_id, FALSE);
+	priv->set_rate_id = grilio_channel_send_request_full(priv->io, req,
 			RIL_REQUEST_SET_UNSOL_CELL_INFO_LIST_RATE,
 			ril_cell_info_set_rate_cb, NULL, self);
 	grilio_request_unref(req);
@@ -374,22 +353,29 @@ static void ril_cell_info_set_rate(struct ril_cell_info *self, int ms)
 
 static void ril_cell_info_update_rate(struct ril_cell_info *self)
 {
-	if (self->sim_card_ready) {
-		ril_cell_info_set_rate(self,
-			(self->display->state == MCE_DISPLAY_STATE_OFF) ?
-			DISPLAY_OFF_UPDATE_RATE : DISPLAY_ON_UPDATE_RATE);
-	}
+	struct ril_cell_info_priv *priv = self->priv;
+
+	ril_cell_info_set_rate(self,
+		(priv->display->state == MCE_DISPLAY_STATE_OFF) ?
+		DISPLAY_OFF_UPDATE_RATE : DISPLAY_ON_UPDATE_RATE);
 }
 
 static void ril_cell_info_display_state_cb(MceDisplay *display, void *arg)
 {
-	ril_cell_info_update_rate(RIL_CELL_INFO(arg));
+	struct ril_cell_info *self = RIL_CELL_INFO(arg);
+	struct ril_cell_info_priv *priv = self->priv;
+
+	if (priv->sim_card_ready) {
+		ril_cell_info_update_rate(self);
+	}
 }
 
 static void ril_cell_info_refresh(struct ril_cell_info *self)
 {
+	struct ril_cell_info_priv *priv = self->priv;
+
 	/* RIL_REQUEST_GET_CELL_INFO_LIST fails without SIM card */
-	if (self->radio->state == RADIO_STATE_ON && self->sim_card_ready) {
+	if (priv->radio->state == RADIO_STATE_ON && priv->sim_card_ready) {
 		ril_cell_info_query(self);
 	} else {
 		ril_cell_info_update_cells(self, NULL);
@@ -407,153 +393,124 @@ static void ril_cell_info_radio_state_cb(struct ril_radio *radio, void *arg)
 static void ril_cell_info_sim_status_cb(struct ril_sim_card *sim, void *arg)
 {
 	struct ril_cell_info *self = RIL_CELL_INFO(arg);
+	struct ril_cell_info_priv *priv = self->priv;
+	const gboolean sim_card_was_ready = priv->sim_card_ready;
 
-	self->sim_card_ready = ril_sim_card_ready(sim);
-	DBG_(self, "%sready", self->sim_card_ready ? "" : "not ");
-	ril_cell_info_refresh(self);
-	ril_cell_info_update_rate(self);
-}
-
-/* sailfish_cell_info interface callbacks */
-
-struct ril_cell_info_signal_data {
-	sailfish_cell_info_cb_t cb;
-	void *arg;
-};
-
-static inline struct ril_cell_info *ril_cell_info_cast
-					(struct sailfish_cell_info *info)
-{
-	return G_CAST(info, struct ril_cell_info, info);
-}
-
-static void ril_cell_info_ref_proc(struct sailfish_cell_info *info)
-{
-	g_object_ref(ril_cell_info_cast(info));
-}
-
-static void ril_cell_info_unref_proc(struct sailfish_cell_info *info)
-{
-	g_object_unref(ril_cell_info_cast(info));
-}
-
-static void ril_cell_info_cells_changed_cb(struct ril_cell_info *self,
-							void *user_data)
-{
-	struct ril_cell_info_signal_data *data = user_data;
-
-	data->cb(&self->info, data->arg);
-}
-
-static void ril_cell_info_cells_disconnect_notify(gpointer  data,
-							GClosure *closure)
-{
-	g_slice_free1(sizeof(struct ril_cell_info_signal_data), data);
-}
-
-static gulong ril_cell_info_add_cells_changed_handler_proc
-				(struct sailfish_cell_info *info,
-					sailfish_cell_info_cb_t cb, void *arg)
-{
-	if (cb) {
-		struct ril_cell_info_signal_data *data =
-			g_slice_new(struct ril_cell_info_signal_data);
-
-		data->cb = cb;
-		data->arg = arg;
-		return g_signal_connect_data(ril_cell_info_cast(info),
-				SIGNAL_CELLS_CHANGED_NAME,
-				G_CALLBACK(ril_cell_info_cells_changed_cb),
-				data, ril_cell_info_cells_disconnect_notify,
-				G_CONNECT_AFTER);
-	} else {
-		return 0;
+	DBG_(self, "%sready", ril_sim_card_ready(sim) ? "" : "not ");
+	priv->sim_card_ready = ril_sim_card_ready(sim);
+	if (priv->sim_card_ready != sim_card_was_ready) {
+		ril_cell_info_refresh(self);
+		if (priv->sim_card_ready) {
+			ril_cell_info_update_rate(self);
+		}
 	}
 }
 
-static void ril_cell_info_remove_handler_proc(struct sailfish_cell_info *info,
-								gulong id)
+gulong ril_cell_info_add_cells_changed_handler(struct ril_cell_info *self,
+					ril_cell_info_cb_t cb, void *arg)
 {
-	if (G_LIKELY(id)) {
-		g_signal_handler_disconnect(ril_cell_info_cast(info), id);
+	return (G_LIKELY(self) && G_LIKELY(cb)) ? g_signal_connect(self,
+		SIGNAL_CELLS_CHANGED_NAME, G_CALLBACK(cb), arg) : 0;
+}
+
+void ril_cell_info_remove_handler(struct ril_cell_info *self, gulong id)
+{
+	if (G_LIKELY(self) && G_LIKELY(id)) {
+		g_signal_handler_disconnect(self, id);
 	}
 }
 
-struct sailfish_cell_info *ril_cell_info_new(GRilIoChannel *io,
+struct ril_cell_info *ril_cell_info_new(GRilIoChannel *io,
 		const char *log_prefix, MceDisplay *display,
 		struct ril_radio *radio, struct ril_sim_card *sim_card)
 {
-	static const struct sailfish_cell_info_proc ril_cell_info_proc = {
-		ril_cell_info_ref_proc,
-		ril_cell_info_unref_proc,
-		ril_cell_info_add_cells_changed_handler_proc,
-		ril_cell_info_remove_handler_proc
-	};
-
 	struct ril_cell_info *self = g_object_new(RIL_CELL_INFO_TYPE, 0);
+	struct ril_cell_info_priv *priv = self->priv;
 
-	self->info.proc = &ril_cell_info_proc;
-	self->io = grilio_channel_ref(io);
-	self->display = mce_display_ref(display);
-	self->radio = ril_radio_ref(radio);
-	self->sim_card = ril_sim_card_ref(sim_card);
-	self->log_prefix = (log_prefix && log_prefix[0]) ?
+	priv->io = grilio_channel_ref(io);
+	priv->display = mce_display_ref(display);
+	priv->radio = ril_radio_ref(radio);
+	priv->sim_card = ril_sim_card_ref(sim_card);
+	priv->log_prefix = (log_prefix && log_prefix[0]) ?
 		g_strconcat(log_prefix, " ", NULL) : g_strdup("");
 	DBG_(self, "");
-	self->event_id = grilio_channel_add_unsol_event_handler(self->io,
+	priv->event_id = grilio_channel_add_unsol_event_handler(priv->io,
 		ril_cell_info_list_changed_cb, RIL_UNSOL_CELL_INFO_LIST, self);
-	self->display_state_event_id =
+	priv->display_state_event_id =
 		mce_display_add_state_changed_handler(display,
 			ril_cell_info_display_state_cb, self);
-	self->radio_state_event_id =
+	priv->radio_state_event_id =
 		ril_radio_add_state_changed_handler(radio,
 			ril_cell_info_radio_state_cb, self);
-	self->sim_status_event_id =
-		ril_sim_card_add_status_changed_handler(self->sim_card,
+	priv->sim_status_event_id =
+		ril_sim_card_add_status_changed_handler(priv->sim_card,
 			ril_cell_info_sim_status_cb, self);
-	self->sim_card_ready = ril_sim_card_ready(sim_card);
-	ril_cell_info_refresh(self);
-	ril_cell_info_update_rate(self);
-	return &self->info;
+	priv->sim_card_ready = ril_sim_card_ready(sim_card);
+	if (priv->sim_card_ready) {
+		ril_cell_info_query(self);
+		ril_cell_info_update_rate(self);
+	}
+	return self;
+}
+
+struct ril_cell_info *ril_cell_info_ref(struct ril_cell_info *self)
+{
+	if (G_LIKELY(self)) {
+		g_object_ref(RIL_CELL_INFO(self));
+		return self;
+	} else {
+		return NULL;
+	}
+}
+
+void ril_cell_info_unref(struct ril_cell_info *self)
+{
+	if (G_LIKELY(self)) {
+		g_object_unref(RIL_CELL_INFO(self));
+	}
 }
 
 static void ril_cell_info_init(struct ril_cell_info *self)
 {
+	self->priv = G_TYPE_INSTANCE_GET_PRIVATE(self, RIL_CELL_INFO_TYPE,
+						struct ril_cell_info_priv);
 }
 
 static void ril_cell_info_dispose(GObject *object)
 {
 	struct ril_cell_info *self = RIL_CELL_INFO(object);
+	struct ril_cell_info_priv *priv = self->priv;
 
-	grilio_channel_remove_handlers(self->io, &self->event_id, 1);
-	if (self->query_id) {
-		grilio_channel_cancel_request(self->io, self->query_id, FALSE);
-		self->query_id = 0;
+	grilio_channel_remove_handlers(priv->io, &priv->event_id, 1);
+	if (priv->query_id) {
+		grilio_channel_cancel_request(priv->io, priv->query_id, FALSE);
+		priv->query_id = 0;
 	}
-	if (self->set_rate_id) {
-		grilio_channel_cancel_request(self->io, self->set_rate_id,
+	if (priv->set_rate_id) {
+		grilio_channel_cancel_request(priv->io, priv->set_rate_id,
 									FALSE);
-		self->set_rate_id = 0;
+		priv->set_rate_id = 0;
 	}
-	gutil_disconnect_handlers(self->display,
-					&self->display_state_event_id, 1);
-	ril_radio_remove_handlers(self->radio, &self->radio_state_event_id, 1);
-	ril_sim_card_remove_handlers(self->sim_card,
-					&self->sim_status_event_id, 1);
+	gutil_disconnect_handlers(priv->display,
+					&priv->display_state_event_id, 1);
+	ril_radio_remove_handlers(priv->radio, &priv->radio_state_event_id, 1);
+	ril_sim_card_remove_handlers(priv->sim_card,
+					&priv->sim_status_event_id, 1);
 	G_OBJECT_CLASS(ril_cell_info_parent_class)->dispose(object);
 }
 
 static void ril_cell_info_finalize(GObject *object)
 {
 	struct ril_cell_info *self = RIL_CELL_INFO(object);
+	struct ril_cell_info_priv *priv = self->priv;
 
 	DBG_(self, "");
-	g_free(self->log_prefix);
-	grilio_channel_unref(self->io);
-	mce_display_unref(self->display);
-	ril_radio_unref(self->radio);
-	ril_sim_card_unref(self->sim_card);
-	g_slist_free_full(self->info.cells, ril_cell_free1);
+	g_free(priv->log_prefix);
+	grilio_channel_unref(priv->io);
+	mce_display_unref(priv->display);
+	ril_radio_unref(priv->radio);
+	ril_sim_card_unref(priv->sim_card);
+	g_slist_free_full(self->cells, g_free);
 	G_OBJECT_CLASS(ril_cell_info_parent_class)->finalize(object);
 }
 
@@ -563,6 +520,7 @@ static void ril_cell_info_class_init(RilCellInfoClass *klass)
 
 	object_class->dispose = ril_cell_info_dispose;
 	object_class->finalize = ril_cell_info_finalize;
+	g_type_class_add_private(klass, sizeof(struct ril_cell_info_priv));
 	ril_cell_info_signals[SIGNAL_CELLS_CHANGED] =
 		g_signal_new(SIGNAL_CELLS_CHANGED_NAME,
 			G_OBJECT_CLASS_TYPE(klass), G_SIGNAL_RUN_FIRST,

ofono/drivers/ril/ril_cell_info.h

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2016-2017 Jolla Ltd.
+ *  Copyright (C) 2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -18,11 +18,40 @@
 
 #include "ril_types.h"
 #include <mce_display.h>
-#include <sailfish_cell_info.h>
 
-struct sailfish_cell_info *ril_cell_info_new(GRilIoChannel *io,
+struct ril_cell {
+	enum ril_cell_info_type type;
+	gboolean registered;
+	union {
+		struct ril_cell_info_gsm gsm;
+		struct ril_cell_info_wcdma wcdma;
+		struct ril_cell_info_lte lte;
+	} info;
+};
+
+struct ril_cell_info_priv;
+struct ril_cell_info {
+	GObject object;
+	struct ril_cell_info_priv *priv;
+	GSList *cells;
+};
+
+typedef void (*ril_cell_info_cb_t)(struct ril_cell_info *info, void *arg);
+
+gint ril_cell_compare_func(gconstpointer v1, gconstpointer v2);
+gint ril_cell_compare_location(const struct ril_cell *c1,
+					const struct ril_cell *c2);
+
+struct ril_cell_info *ril_cell_info_new(GRilIoChannel *io,
 		const char *log_prefix, MceDisplay *display,
 		struct ril_radio *radio, struct ril_sim_card *sim_card);
+struct ril_cell_info *ril_cell_info_ref(struct ril_cell_info *info);
+void ril_cell_info_unref(struct ril_cell_info *info);
+struct ril_cell *ril_cell_find_cell(struct ril_cell_info *info,
+						const struct ril_cell *cell);
+gulong ril_cell_info_add_cells_changed_handler(struct ril_cell_info *info,
+					ril_cell_info_cb_t cb, void *arg);
+void ril_cell_info_remove_handler(struct ril_cell_info *info, gulong id);
 
 #endif /* RIL_CELL_INFO_H */
 

ofono/drivers/ril/ril_cell_info_dbus.c

@@ -0,0 +1,586 @@
+/*
+ *  oFono - Open Source Telephony - RIL-based devices
+ *
+ *  Copyright (C) 2016 Jolla Ltd.
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License version 2 as
+ *  published by the Free Software Foundation.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ *  GNU General Public License for more details.
+ */
+
+#include "ril_plugin.h"
+#include "ril_cell_info.h"
+#include "ril_log.h"
+
+#include <ofono/dbus.h>
+
+#include <gdbus.h>
+
+struct ril_cell_entry {
+	guint cell_id;
+	char *path;
+	struct ril_cell cell;
+};
+
+struct ril_cell_info_dbus {
+	struct ril_modem *md;
+	struct ril_cell_info *info;
+	DBusConnection *conn;
+	char *path;
+	gulong handler_id;
+	guint next_cell_id;
+	GSList *entries;
+};
+
+#define RIL_CELL_INFO_DBUS_INTERFACE             "org.nemomobile.ofono.CellInfo"
+#define RIL_CELL_INFO_DBUS_CELLS_ADDED_SIGNAL    "CellsAdded"
+#define RIL_CELL_INFO_DBUS_CELLS_REMOVED_SIGNAL  "CellsRemoved"
+
+#define RIL_CELL_DBUS_INTERFACE_VERSION          (1)
+#define RIL_CELL_DBUS_INTERFACE                  "org.nemomobile.ofono.Cell"
+#define RIL_CELL_DBUS_REGISTERED_CHANGED_SIGNAL  "RegisteredChanged"
+#define RIL_CELL_DBUS_PROPERTY_CHANGED_SIGNAL    "PropertyChanged"
+#define RIL_CELL_DBUS_REMOVED_SIGNAL             "Removed"
+
+struct ril_cell_property {
+	const char *name;
+	glong off;
+	int flag;
+};
+
+#define RIL_CELL_GSM_PROPERTY(value,name) \
+	{ #name, G_STRUCT_OFFSET(struct ril_cell_info_gsm,name), value }
+#define RIL_CELL_WCDMA_PROPERTY(value,name) \
+	{ #name, G_STRUCT_OFFSET(struct ril_cell_info_wcdma,name), value }
+#define RIL_CELL_LTE_PROPERTY(value,name) \
+	{ #name, G_STRUCT_OFFSET(struct ril_cell_info_lte,name), value }
+
+static const struct ril_cell_property ril_cell_gsm_properties [] = {
+	RIL_CELL_GSM_PROPERTY(0x01,mcc),
+	RIL_CELL_GSM_PROPERTY(0x02,mnc),
+	RIL_CELL_GSM_PROPERTY(0x04,lac),
+	RIL_CELL_GSM_PROPERTY(0x08,cid),
+	RIL_CELL_GSM_PROPERTY(0x10,signalStrength),
+	RIL_CELL_GSM_PROPERTY(0x20,bitErrorRate)
+};
+
+static const struct ril_cell_property ril_cell_wcdma_properties [] = {
+	RIL_CELL_WCDMA_PROPERTY(0x01,mcc),
+	RIL_CELL_WCDMA_PROPERTY(0x02,mnc),
+	RIL_CELL_WCDMA_PROPERTY(0x04,lac),
+	RIL_CELL_WCDMA_PROPERTY(0x08,cid),
+	RIL_CELL_WCDMA_PROPERTY(0x10,psc),
+	RIL_CELL_WCDMA_PROPERTY(0x20,signalStrength),
+	RIL_CELL_WCDMA_PROPERTY(0x40,bitErrorRate)
+};
+
+static const struct ril_cell_property ril_cell_lte_properties [] = {
+	RIL_CELL_LTE_PROPERTY(0x001,mcc),
+	RIL_CELL_LTE_PROPERTY(0x002,mnc),
+	RIL_CELL_LTE_PROPERTY(0x004,ci),
+	RIL_CELL_LTE_PROPERTY(0x008,pci),
+	RIL_CELL_LTE_PROPERTY(0x010,tac),
+	RIL_CELL_LTE_PROPERTY(0x020,signalStrength),
+	RIL_CELL_LTE_PROPERTY(0x040,rsrp),
+	RIL_CELL_LTE_PROPERTY(0x080,rsrq),
+	RIL_CELL_LTE_PROPERTY(0x100,rssnr),
+	RIL_CELL_LTE_PROPERTY(0x200,cqi),
+	RIL_CELL_LTE_PROPERTY(0x400,timingAdvance)
+};
+
+#define RIL_CELL_PROPERTY_REGISTERED 0x1000
+
+typedef void (*ril_cell_info_dbus_append_fn)(DBusMessageIter *it,
+					const struct ril_cell_entry *entry);
+
+static const char *ril_cell_info_dbus_cell_type_str(enum ril_cell_info_type t)
+{
+	switch (t) {
+	case RIL_CELL_INFO_TYPE_GSM:
+		return "gsm";
+	case RIL_CELL_INFO_TYPE_CDMA:
+		return "cdma";
+	case RIL_CELL_INFO_TYPE_LTE:
+		return "lte";
+	case RIL_CELL_INFO_TYPE_WCDMA:
+		return "wcdma";
+	case RIL_CELL_INFO_TYPE_TD_SCDMA:
+		return "tdscdma";
+	case RIL_CELL_INFO_TYPE_NONE:
+	default:
+		return "unknown";
+	}
+};
+
+static const struct ril_cell_property *ril_cell_info_dbus_cell_properties(
+				enum ril_cell_info_type type, int *count)
+{
+	switch (type) {
+	case RIL_CELL_INFO_TYPE_GSM:
+		*count = G_N_ELEMENTS(ril_cell_gsm_properties);
+		return ril_cell_gsm_properties;
+	case RIL_CELL_INFO_TYPE_WCDMA:
+		*count = G_N_ELEMENTS(ril_cell_wcdma_properties);
+		return ril_cell_wcdma_properties;
+	case RIL_CELL_INFO_TYPE_LTE:
+		*count = G_N_ELEMENTS(ril_cell_lte_properties);
+		return ril_cell_lte_properties;
+	default:
+		*count = 0;
+		return NULL;
+	}
+};
+
+static void ril_cell_info_destroy_entry(struct ril_cell_entry *entry)
+{
+	if (entry) {
+		g_free(entry->path);
+		g_free(entry);
+	}
+}
+
+static DBusMessage *ril_cell_info_dbus_reply(DBusMessage *msg,
+				const struct ril_cell_entry *entry,
+				ril_cell_info_dbus_append_fn append)
+{
+	DBusMessage *reply = dbus_message_new_method_return(msg);
+	DBusMessageIter it;
+
+	dbus_message_iter_init_append(reply, &it);
+	append(&it, entry);
+	return reply;
+}
+
+static void ril_cell_info_dbus_append_version(DBusMessageIter *it,
+					const struct ril_cell_entry *entry)
+{
+	dbus_int32_t version = RIL_CELL_DBUS_INTERFACE_VERSION;
+
+	dbus_message_iter_append_basic(it, DBUS_TYPE_INT32, &version);
+}
+
+static void ril_cell_info_dbus_append_type(DBusMessageIter *it,
+					const struct ril_cell_entry *entry)
+{
+	const char *type = ril_cell_info_dbus_cell_type_str(entry->cell.type);
+
+	dbus_message_iter_append_basic(it, DBUS_TYPE_STRING, &type);
+}
+
+static void ril_cell_info_dbus_append_registered(DBusMessageIter *it,
+					const struct ril_cell_entry *entry)
+{
+	dbus_bool_t registered = entry->cell.registered;
+
+	dbus_message_iter_append_basic(it, DBUS_TYPE_BOOLEAN, &registered);
+}
+
+static void ril_cell_info_dbus_append_properties(DBusMessageIter *it,
+					const struct ril_cell_entry *entry)
+{
+	int i, n;
+	DBusMessageIter dict;
+	const struct ril_cell *cell = &entry->cell;
+	const struct ril_cell_property *prop =
+		ril_cell_info_dbus_cell_properties(cell->type, &n);
+
+	dbus_message_iter_open_container(it, DBUS_TYPE_ARRAY, "{sv}", &dict);
+	for (i = 0; i < n; i++) {
+		gint32 value = G_STRUCT_MEMBER(int, &cell->info, prop[i].off);
+		if (value != INT_MAX) {
+			ofono_dbus_dict_append(&dict, prop[i].name,
+						DBUS_TYPE_INT32, &value);
+		}
+	}
+	dbus_message_iter_close_container(it, &dict);
+}
+
+static void ril_cell_info_dbus_append_all(DBusMessageIter *it,
+					const struct ril_cell_entry *entry)
+{
+	ril_cell_info_dbus_append_version(it, entry);
+	ril_cell_info_dbus_append_type(it, entry);
+	ril_cell_info_dbus_append_registered(it, entry);
+	ril_cell_info_dbus_append_properties(it, entry);
+}
+
+static DBusMessage *ril_cell_info_dbus_cell_get_all(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	return ril_cell_info_dbus_reply(msg, (struct ril_cell_entry*)data,
+				ril_cell_info_dbus_append_all);
+}
+
+static DBusMessage *ril_cell_info_dbus_cell_get_version(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	return ril_cell_info_dbus_reply(msg, (struct ril_cell_entry*)data,
+				ril_cell_info_dbus_append_version);
+}
+
+static DBusMessage *ril_cell_info_dbus_cell_get_type(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	return ril_cell_info_dbus_reply(msg, (struct ril_cell_entry*)data,
+				ril_cell_info_dbus_append_type);
+}
+
+static DBusMessage *ril_cell_info_dbus_cell_get_registered(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	return ril_cell_info_dbus_reply(msg, (struct ril_cell_entry*)data,
+				ril_cell_info_dbus_append_registered);
+}
+
+static DBusMessage *ril_cell_info_dbus_cell_get_properties(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	return ril_cell_info_dbus_reply(msg, (struct ril_cell_entry*)data,
+				ril_cell_info_dbus_append_properties);
+}
+
+static const GDBusMethodTable ril_cell_info_dbus_cell_methods[] = {
+	{ GDBUS_METHOD("GetAll", NULL,
+			GDBUS_ARGS({ "version", "i" },
+			           { "type", "s" },
+			           { "registered", "b" },
+			           { "properties", "a{sv}" }),
+			ril_cell_info_dbus_cell_get_all) },
+	{ GDBUS_METHOD("GetInterfaceVersion", NULL,
+			GDBUS_ARGS({ "version", "i" }),
+			ril_cell_info_dbus_cell_get_version) },
+	{ GDBUS_METHOD("GetType", NULL,
+			GDBUS_ARGS({ "type", "s" }),
+			ril_cell_info_dbus_cell_get_type) },
+	{ GDBUS_METHOD("GetRegistered", NULL,
+			GDBUS_ARGS({ "registered", "b" }),
+			ril_cell_info_dbus_cell_get_registered) },
+	{ GDBUS_METHOD("GetProperties", NULL,
+			GDBUS_ARGS({ "properties", "a{sv}" }),
+			ril_cell_info_dbus_cell_get_properties) },
+	{ }
+};
+
+static const GDBusSignalTable ril_cell_info_dbus_cell_signals[] = {
+	{ GDBUS_SIGNAL(RIL_CELL_DBUS_REGISTERED_CHANGED_SIGNAL,
+			GDBUS_ARGS({ "registered", "b" })) },
+	{ GDBUS_SIGNAL(RIL_CELL_DBUS_PROPERTY_CHANGED_SIGNAL,
+			GDBUS_ARGS({ "name", "s" }, { "value", "v" })) },
+	{ GDBUS_SIGNAL(RIL_CELL_DBUS_REMOVED_SIGNAL,
+			GDBUS_ARGS({})) },
+	{ }
+};
+
+static struct ril_cell_entry *ril_cell_info_dbus_find_id(
+		struct ril_cell_info_dbus *dbus, guint id)
+{
+	GSList *l;
+	for (l = dbus->entries; l; l = l->next) {
+		struct ril_cell_entry *entry = l->data;
+		if (entry->cell_id == id) {
+			return entry;
+		}
+	}
+	return NULL;
+}
+
+static guint ril_cell_info_dbus_next_cell_id(struct ril_cell_info_dbus *dbus)
+{
+	while (ril_cell_info_dbus_find_id(dbus, dbus->next_cell_id)) {
+		dbus->next_cell_id++;
+	}
+	return dbus->next_cell_id++;
+}
+
+static struct ril_cell_entry *ril_cell_info_dbus_find_cell(
+		struct ril_cell_info_dbus *dbus, const struct ril_cell *cell)
+{
+	if (cell) {
+		GSList *l;
+		for (l = dbus->entries; l; l = l->next) {
+			struct ril_cell_entry *entry = l->data;
+			if (!ril_cell_compare_location(&entry->cell, cell)) {
+				return entry;
+			}
+		}
+	}
+	return NULL;
+}
+
+static void ril_cell_info_dbus_emit_path_list(struct ril_cell_info_dbus *dbus,
+					const char *name, GPtrArray *list)
+{
+	guint i;
+	DBusMessageIter it, array;
+	DBusMessage *signal = dbus_message_new_signal(dbus->path,
+					RIL_CELL_INFO_DBUS_INTERFACE, name);
+
+	dbus_message_iter_init_append(signal, &it);
+	dbus_message_iter_open_container(&it, DBUS_TYPE_ARRAY, "o", &array);
+	for (i = 0; i < list->len; i++) {
+		const char* path = list->pdata[i];
+		dbus_message_iter_append_basic(&array, DBUS_TYPE_OBJECT_PATH,
+								&path);
+	}
+	dbus_message_iter_close_container(&it, &array);
+
+	g_dbus_send_message(dbus->conn, signal);
+}
+
+static int ril_cell_info_dbus_compare(const struct ril_cell *c1,
+					const struct ril_cell *c2)
+{
+	if (c1->type == c2->type) {
+		int i, n, mask = 0;
+		const struct ril_cell_property *prop =
+			ril_cell_info_dbus_cell_properties(c1->type, &n);
+
+		if (c1->registered != c2->registered) {
+			mask |= RIL_CELL_PROPERTY_REGISTERED;
+		}
+
+		for (i = 0; i < n; i++) {
+			const glong offset = prop[i].off;
+			gint32 v1 = G_STRUCT_MEMBER(int, &c1->info, offset);
+			gint32 v2 = G_STRUCT_MEMBER(int, &c2->info, offset);
+			if (v1 != v2) {
+				mask |= prop[i].flag;
+			}
+		}
+
+		return mask;
+	} else {
+		return -1;
+	}
+}
+
+static void ril_cell_info_dbus_property_changed(struct ril_cell_info_dbus *dbus,
+				const struct ril_cell_entry *entry, int mask)
+{
+	int i, n;
+	const struct ril_cell *cell = &entry->cell;
+	const struct ril_cell_property *prop =
+		ril_cell_info_dbus_cell_properties(cell->type, &n);
+
+	if (mask & RIL_CELL_PROPERTY_REGISTERED) {
+		dbus_bool_t registered = cell->registered;
+		g_dbus_emit_signal(dbus->conn, entry->path,
+			RIL_CELL_DBUS_INTERFACE,
+			RIL_CELL_DBUS_REGISTERED_CHANGED_SIGNAL,
+			DBUS_TYPE_BOOLEAN, &registered, DBUS_TYPE_INVALID);
+		mask &= ~RIL_CELL_PROPERTY_REGISTERED;
+	}
+
+	for (i = 0; i < n && mask; i++) {
+		if (mask & prop[i].flag) {
+			ofono_dbus_signal_property_changed(dbus->conn,
+				entry->path, RIL_CELL_DBUS_INTERFACE,
+				prop[i].name, DBUS_TYPE_INT32,
+				G_STRUCT_MEMBER_P(&cell->info, prop[i].off));
+			mask &= ~prop[i].flag;
+		}
+	}
+}
+
+static void ril_cell_info_dbus_update_entries(struct ril_cell_info_dbus *dbus,
+							gboolean emit_signals)
+{
+	GSList *l;
+	GPtrArray* added = NULL;
+	GPtrArray* removed = NULL;
+
+	/* Remove non-existent cells */
+	l = dbus->entries;
+	while (l) {
+		GSList *next = l->next;
+		struct ril_cell_entry *entry = l->data;
+		if (!g_slist_find_custom(dbus->info->cells, &entry->cell,
+						ril_cell_compare_func)) {
+			DBG("%s removed", entry->path);
+			dbus->entries = g_slist_delete_link(dbus->entries, l);
+			g_dbus_emit_signal(dbus->conn, entry->path,
+					RIL_CELL_DBUS_INTERFACE,
+					RIL_CELL_DBUS_REMOVED_SIGNAL,
+					DBUS_TYPE_INVALID);
+			g_dbus_unregister_interface(dbus->conn, entry->path,
+						RIL_CELL_DBUS_INTERFACE);
+			if (emit_signals) {
+				if (!removed) {
+					removed =
+						g_ptr_array_new_with_free_func(
+								g_free);
+				}
+				/* Steal the path */
+				g_ptr_array_add(removed, entry->path);
+				entry->path = NULL;
+			}
+			ril_cell_info_destroy_entry(entry);
+		}
+		l = next;
+	}
+
+	/* Add new cells */
+	for (l = dbus->info->cells; l; l = l->next) {
+		const struct ril_cell *cell = l->data;
+		struct ril_cell_entry *entry =
+			ril_cell_info_dbus_find_cell(dbus, cell);
+
+		if (entry) {
+			if (emit_signals) {
+				int diff = ril_cell_info_dbus_compare(cell,
+								&entry->cell);
+				entry->cell = *cell;
+				ril_cell_info_dbus_property_changed(dbus,
+								entry, diff);
+			} else {
+				entry->cell = *cell;
+			}
+		} else {
+			entry = g_new0(struct ril_cell_entry, 1);
+			entry->cell = *cell;
+			entry->cell_id = ril_cell_info_dbus_next_cell_id(dbus);
+			entry->path = g_strdup_printf("%s/cell_%u", dbus->path,
+							entry->cell_id);
+			dbus->entries = g_slist_append(dbus->entries, entry);
+			DBG("%s added", entry->path);
+			g_dbus_register_interface(dbus->conn, entry->path,
+					RIL_CELL_DBUS_INTERFACE,
+					ril_cell_info_dbus_cell_methods,
+					ril_cell_info_dbus_cell_signals, NULL,
+					entry, NULL);
+			if (emit_signals) {
+				if (!added) {
+					added = g_ptr_array_new();
+				}
+				g_ptr_array_add(added, entry->path);
+			}
+		}
+	}
+
+	if (removed) {
+		ril_cell_info_dbus_emit_path_list(dbus,
+			RIL_CELL_INFO_DBUS_CELLS_REMOVED_SIGNAL, removed);
+		g_ptr_array_free(removed, TRUE);
+	}
+
+	if (added) {
+		ril_cell_info_dbus_emit_path_list(dbus,
+			RIL_CELL_INFO_DBUS_CELLS_ADDED_SIGNAL, added);
+		g_ptr_array_free(added, TRUE);
+	}
+}
+
+static void ril_cell_info_dbus_cells_changed_cb(struct ril_cell_info *info,
+								void *arg)
+{
+	DBG("");
+	ril_cell_info_dbus_update_entries((struct ril_cell_info_dbus *)arg,
+								TRUE);
+}
+
+static DBusMessage *ril_cell_info_dbus_get_cells(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	struct ril_cell_info_dbus *dbus = data;
+	DBusMessage *reply = dbus_message_new_method_return(msg);
+	DBusMessageIter it, array;
+	GSList *l;
+
+	dbus_message_iter_init_append(reply, &it);
+	dbus_message_iter_open_container(&it, DBUS_TYPE_ARRAY, "o", &array);
+	for (l = dbus->entries; l; l = l->next) {
+		const struct ril_cell_entry *entry = l->data;
+		dbus_message_iter_append_basic(&array, DBUS_TYPE_OBJECT_PATH,
+								&entry->path);
+	}
+	dbus_message_iter_close_container(&it, &array);
+	return reply;
+}
+
+static const GDBusMethodTable ril_cell_info_dbus_methods[] = {
+	{ GDBUS_METHOD("GetCells", NULL,
+			GDBUS_ARGS({ "paths", "ao" }),
+			ril_cell_info_dbus_get_cells) },
+	{ }
+};
+
+static const GDBusSignalTable ril_cell_info_dbus_signals[] = {
+	{ GDBUS_SIGNAL(RIL_CELL_INFO_DBUS_CELLS_ADDED_SIGNAL,
+			GDBUS_ARGS({ "paths", "ao" })) },
+	{ GDBUS_SIGNAL(RIL_CELL_INFO_DBUS_CELLS_REMOVED_SIGNAL,
+			GDBUS_ARGS({ "paths", "ao" })) },
+	{ }
+};
+
+struct ril_cell_info_dbus *ril_cell_info_dbus_new(struct ril_modem *md,
+						struct ril_cell_info *info)
+{
+	struct ril_cell_info_dbus *dbus = g_new0(struct ril_cell_info_dbus, 1);
+
+	DBG("%s", ril_modem_get_path(md));
+	dbus->md = md;
+	dbus->path = g_strdup(ril_modem_get_path(md));
+	dbus->conn = dbus_connection_ref(ofono_dbus_get_connection());
+	dbus->info = ril_cell_info_ref(info);
+	dbus->handler_id = ril_cell_info_add_cells_changed_handler(info,
+				ril_cell_info_dbus_cells_changed_cb, dbus);
+
+	/* Register D-Bus interface */
+	if (g_dbus_register_interface(dbus->conn, dbus->path,
+			RIL_CELL_INFO_DBUS_INTERFACE, ril_cell_info_dbus_methods,
+			ril_cell_info_dbus_signals, NULL, dbus, NULL)) {
+		ofono_modem_add_interface(md->ofono,
+						RIL_CELL_INFO_DBUS_INTERFACE);
+		ril_cell_info_dbus_update_entries(dbus, FALSE);
+		return dbus;
+	} else {
+		ofono_error("RIL D-Bus register failed");
+		ril_cell_info_dbus_free(dbus);
+		return NULL;
+	}
+}
+
+void ril_cell_info_dbus_free(struct ril_cell_info_dbus *dbus)
+{
+	if (dbus) {
+		GSList *l;
+
+		DBG("%s", dbus->path);
+		g_dbus_unregister_interface(dbus->conn, dbus->path,
+						RIL_CELL_INFO_DBUS_INTERFACE);
+		ofono_modem_remove_interface(dbus->md->ofono,
+						RIL_CELL_INFO_DBUS_INTERFACE);
+
+		/* Unregister cells */
+		l = dbus->entries;
+		while (l) {
+			struct ril_cell_entry *entry = l->data;
+			g_dbus_unregister_interface(dbus->conn, entry->path,
+						RIL_CELL_DBUS_INTERFACE);
+			ril_cell_info_destroy_entry(entry);
+			l = l->next;
+		}
+		g_slist_free(dbus->entries);
+
+		dbus_connection_unref(dbus->conn);
+
+		ril_cell_info_remove_handler(dbus->info, dbus->handler_id);
+		ril_cell_info_unref(dbus->info);
+
+		g_free(dbus->path);
+		g_free(dbus);
+	}
+}
+
+/*
+ * Local Variables:
+ * mode: C
+ * c-basic-offset: 8
+ * indent-tabs-mode: t
+ * End:
+ */

ofono/drivers/ril/ril_config.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2018 Jolla Ltd.
+ *  Copyright (C) 2015-2017 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -14,20 +14,13 @@
  */
 
 #include "ril_config.h"
-#include "ril_util.h"
-#include "ril_log.h"
 
 #include <gutil_intarray.h>
 #include <gutil_ints.h>
-#include <gutil_misc.h>
-
-#include <sys/types.h>
-#include <sys/stat.h>
-#include <unistd.h>
 
 /* Utilities for parsing ril_subscription.conf */
 
-char *ril_config_get_string(GKeyFile *file, const char *group, const char *key)
+char* ril_config_get_string(GKeyFile *file, const char *group, const char *key)
 {
 	char *val = g_key_file_get_string(file, group, key, NULL);
 
@@ -39,31 +32,6 @@ char *ril_config_get_string(GKeyFile *file, const char *group, const char *key)
 	return val;
 }
 
-char **ril_config_get_strings(GKeyFile *file, const char *group,
-					const char *key, char delimiter)
-{
-	char *str = ril_config_get_string(file, group, key);
-
-	if (str) {
-		char **strv, **p;
-		char delimiter_str[2];
-
-		delimiter_str[0] = delimiter;
-		delimiter_str[1] = 0;
-		strv = g_strsplit(str, delimiter_str, -1);
-
-		/* Strip whitespaces */
-		for (p = strv; *p; p++) {
-			*p = g_strstrip(*p);
-		}
-
-		g_free(str);
-		return strv;
-	}
-
-	return NULL;
-}
-
 gboolean ril_config_get_integer(GKeyFile *file, const char *group,
 					const char *key, int *out_value)
 {
@@ -141,74 +109,23 @@ gboolean ril_config_get_flag(GKeyFile *file, const char *group,
 	}
 }
 
-gboolean ril_config_get_enum(GKeyFile *file, const char *group,
-					const char *key, int *result,
-					const char *name, int value, ...)
-{
-	char *str = ril_config_get_string(file, group, key);
-
-	if (str) {
-		/*
-		 * Some people are thinking that # is a comment
-		 * anywhere on the line, not just at the beginning
-		 */
-		char *comment = strchr(str, '#');
-
-		if (comment) *comment = 0;
-		g_strstrip(str);
-		if (strcasecmp(str, name)) {
-			va_list args;
-			va_start(args, value);
-			while ((name = va_arg(args, char*)) != NULL) {
-				value = va_arg(args, int);
-				if (!strcasecmp(str, name)) {
-					break;
-				}
-			}
-			va_end(args);
-		}
-
-		if (!name) {
-			ofono_error("Invalid %s config value (%s)", key, str);
-		}
-
-		g_free(str);
-
-		if (name) {
-			if (result) {
-				*result = value;
-			}
-			return TRUE;
-		}
-	}
-
-	return FALSE;
-}
-
 GUtilInts *ril_config_get_ints(GKeyFile *file, const char *group,
 					const char *key)
 {
-	char *value = ril_config_get_string(file, group, key);
+	char* value = ril_config_get_string(file, group, key);
 
 	if (value) {
-		GUtilIntArray *array = gutil_int_array_new();
-		char **values, **ptr;
-
-		/*
-		 * Some people are thinking that # is a comment
-		 * anywhere on the line, not just at the beginning
-		 */
-		char *comment = strchr(value, '#');
-
-		if (comment) *comment = 0;
-		values = g_strsplit(value, ",", -1);
-		ptr = values;
+		char **values = g_strsplit(value, ",", -1);
+		char **ptr = values;
+		GUtilIntArray* array = gutil_int_array_new();
 
 		while (*ptr) {
-			int val;
+			const char *str = *ptr++;
+			char *end = NULL;
+			long ival = strtol(str, &end, 0);
 
-			if (gutil_parse_int(*ptr++, 0, &val)) {
-				gutil_int_array_append(array, val);
+			if (str[0] && !end[0]) {
+				gutil_int_array_append(array, ival);
 			}
 		}
 
@@ -224,7 +141,7 @@ char *ril_config_ints_to_string(GUtilInts *ints, char separator)
 	if (ints) {
 		guint i, n;
 		const int *data = gutil_ints_get_data(ints, &n);
-		GString *buf = g_string_new(NULL);
+		GString* buf = g_string_new(NULL);
 
 		for (i=0; i<n; i++) {
 			if (buf->len > 0) {
@@ -237,337 +154,6 @@ char *ril_config_ints_to_string(GUtilInts *ints, char separator)
 	return NULL;
 }
 
-/**
- * The ril_config_merge_files() function does the following:
- *
- * 1. Loads the specified key file (say, "/etc/foo.conf")
- * 2. Scans the subdirectory named after the file (e.g. "/etc/foo.d/")
- *    for the files with the same suffix as the main file (e.g. "*.conf")
- * 3. Sorts the files from the subdirectory (alphabetically)
- * 4. Merges the contents of the additional files with the main file
- *    according to their sort order.
- *
- * When the entries are merged, keys and groups overwrite the exising
- * ones by default. Keys can be suffixed with special characters to
- * remove or modify the existing entries instead:
- *
- * ':' Sets the (default) value if the key is missing
- * '+' Appends values to the string list
- * '?' Appends only new (non-existent) values to the string list
- * '-' Removes the values from the string list
- *
- * Both keys and groups can be prefixed with '!' to remove the entire key
- * or group.
- *
- * For example if we merge these two files:
- *
- *   /etc/foo.conf:
- *
- *   [foo]
- *   a=1
- *   b=2,3
- *   c=4
- *   d=5
- *   [bar]
- *   e=5
- *
- *   /etc/foo.d/bar.conf:
- *
- *   [foo]
- *   a+=2
- *   b-=2
- *   c=5
- *   !d
- *   [!bar]
- *
- * we end up with this:
- *
- *   [foo]
- *   a=1
- *   b=2,3
- *   c=5
- *
- * Not that the list separator is assumed to be ',' (rather than default ';').
- * The keyfile passed to ril_config_merge_files() should use the same list
- * separator, because the default values are copied from the config files
- * as is.
- */
-
-static gint ril_config_sort_files(gconstpointer a, gconstpointer b)
-{
-	/* The comparison function for g_ptr_array_sort() doesn't take
-	 * the pointers from the array as arguments, it takes pointers
-	 * to the pointers in the array. */
-	return strcmp(*(char**)a, *(char**)b);
-}
-
-static char **ril_config_collect_files(const char *path, const char *suffix)
-{
-	/* Returns sorted list of regular files in the directory,
-	 * optionally having the specified suffix (e.g. ".conf").
-	 * Returns NULL if nothing appropriate has been found. */
-	char **files = NULL;
-	DIR *d = opendir(path);
-
-	if (d) {
-		GPtrArray *list = g_ptr_array_new();
-		const struct dirent *p;
-
-		while ((p = readdir(d)) != NULL) {
-			/* No need to even stat . and .. */
-			if (strcmp(p->d_name, ".") &&
-				strcmp(p->d_name, "..") && (!suffix ||
-					g_str_has_suffix(p->d_name, suffix))) {
-				struct stat st;
-				char *buf = g_strconcat(path, "/", p->d_name,
-									NULL);
-
-				if (!stat(buf, &st) && S_ISREG(st.st_mode)) {
-					g_ptr_array_add(list, buf);
-				} else {
-					g_free(buf);
-				}
-			}
-                }
-
-		if (list->len > 0) {
-			g_ptr_array_sort(list, ril_config_sort_files);
-			g_ptr_array_add(list, NULL);
-			files = (char**)g_ptr_array_free(list, FALSE);
-		} else {
-			g_ptr_array_free(list, TRUE);
-		}
-
-                closedir(d);
-        }
-	return files;
-}
-
-static int ril_config_list_find(char **list, gsize len, const char *value)
-{
-	guint i;
-
-	for (i = 0; i < len; i++) {
-		if (!strcmp(list[i], value)) {
-			return i;
-		}
-	}
-
-	return -1;
-}
-
-static void ril_config_list_append(GKeyFile *conf, GKeyFile *k,
-				const char *group, const char *key,
-				char **values, gsize n, gboolean unique)
-{
-	/* Note: will steal strings from values */
-	if (n > 0) {
-		int i;
-		gsize len = 0;
-		gchar **list = g_key_file_get_string_list(conf, group, key,
-							&len, NULL);
-		GPtrArray *newlist = g_ptr_array_new_full(0, g_free);
-
-		for (i = 0; i < (int)len; i++) {
-			g_ptr_array_add(newlist, list[i]);
-		}
-
-		for (i = 0; i < (int)n; i++) {
-			char *val = values[i];
-
-			if (!unique || ril_config_list_find((char**)
-				newlist->pdata, newlist->len, val) < 0) {
-				/* Move the string to the new list */
-				g_ptr_array_add(newlist, val);
-				memmove(values + i, values + i + 1,
-						sizeof(char*) * (n - i));
-				i--;
-				n--;
-			}
-		}
-
-		if (newlist->len > len) {
-			g_key_file_set_string_list(conf, group, key,
-				(const gchar * const *) newlist->pdata,
-				newlist->len);
-		}
-
-		/* Strings are deallocated by GPtrArray */
-		g_ptr_array_free(newlist, TRUE);
-		g_free(list);
-	}
-}
-
-static void ril_config_list_remove(GKeyFile *conf, GKeyFile *k,
-		const char *group, const char *key, char **values, gsize n)
-{
-	if (n > 0) {
-		gsize len = 0;
-		gchar **list = g_key_file_get_string_list(conf, group, key,
-								&len, NULL);
-
-		if (len > 0) {
-			gsize i;
-			const gsize oldlen = len;
-
-			for (i = 0; i < n; i++) {
-				int pos;
-
-				/* Remove all matching values */
-				while ((pos = ril_config_list_find(list, len,
-							values[i])) >= 0) {
-					g_free(list[pos]);
-					memmove(list + pos, list + pos + 1,
-						sizeof(char*) * (len - pos));
-					len--;
-				}
-			}
-
-			if (len < oldlen) {
-				g_key_file_set_string_list(conf, group, key,
-					(const gchar * const *) list, len);
-			}
-		}
-
-		g_strfreev(list);
-	}
-}
-
-static void ril_config_merge_group(GKeyFile *conf, GKeyFile *k,
-							const char *group)
-{
-	gsize i, n = 0;
-	char **keys = g_key_file_get_keys(k, group, &n, NULL);
-
-	for (i=0; i<n; i++) {
-		char *key = keys[i];
-
-		if (key[0] == '!') {
-			if (key[1]) {
-				g_key_file_remove_key(conf, group, key+1, NULL);
-			}
-		} else {
-			const gsize len = strlen(key);
-			const char last = (len > 0) ? key[len-1] : 0;
-
-			if (last == '+' || last == '?') {
-				gsize count = 0;
-				gchar **values = g_key_file_get_string_list(k,
-						group, key, &count, NULL);
-
-				key[len-1] = 0;
-				ril_config_list_append(conf, k, group, key,
-						values, count, last == '?');
-				g_strfreev(values);
-			} else if (last == '-') {
-				gsize count = 0;
-				gchar **values = g_key_file_get_string_list(k,
-						group, key, &count, NULL);
-
-				key[len-1] = 0;
-				ril_config_list_remove(conf, k, group, key,
-							values, count);
-				g_strfreev(values);
-			} else {
-				/* Overwrite the value (it must exist in k) */
-				gchar *value = g_key_file_get_value(k, group,
-								key, NULL);
-
-				if (last == ':') {
-					/* Default value */
-					key[len-1] = 0;
-					if (!g_key_file_has_key(conf,
-							group, key, NULL)) {
-						g_key_file_set_value(conf,
-							group, key, value);
-					}
-				} else {
-					g_key_file_set_value(conf, group, key,
-									value);
-				}
-				g_free(value);
-			}
-		}
-	}
-
-	g_strfreev(keys);
-}
-
-static void ril_config_merge_keyfile(GKeyFile *conf, GKeyFile *k)
-{
-	gsize i, n = 0;
-	char **groups = g_key_file_get_groups(k, &n);
-
-	for (i=0; i<n; i++) {
-		const char *group = groups[i];
-
-		if (group[0] == '!') {
-			g_key_file_remove_group(conf, group + 1, NULL);
-		} else {
-			ril_config_merge_group(conf, k, group);
-		}
-	}
-
-	g_strfreev(groups);
-}
-
-static void ril_config_merge_file(GKeyFile *conf, const char *file)
-{
-	GKeyFile *k = g_key_file_new();
-
-	g_key_file_set_list_separator(k, ',');
-
-	if (g_key_file_load_from_file(k, file, 0, NULL)) {
-		ril_config_merge_keyfile(conf, k);
-	}
-
-	g_key_file_unref(k);
-}
-
-void ril_config_merge_files(GKeyFile *conf, const char *file)
-{
-	if (conf && file && file[0]) {
-		char *dot = strrchr(file, '.');
-		const char *suffix;
-		char *dir;
-		char **files;
-
-		if (!dot) {
-			dir = g_strconcat(file, ".d", NULL);
-			suffix = NULL;
-		} else if (!dot[1]) {
-			dir = g_strconcat(file, "d", NULL);
-			suffix = NULL;
-		} else {
-			/* 2 bytes for ".d" and 1 for NULL terminator */
-			dir = g_malloc(dot - file + 3);
-			strncpy(dir, file, dot - file);
-			strcpy(dir + (dot - file), ".d");
-			suffix = dot + 1;
-		}
-
-		files = ril_config_collect_files(dir, suffix);
-		g_free(dir);
-
-		/* Load the main config */
-		if (g_file_test(file, G_FILE_TEST_EXISTS)) {
-			DBG("Loading %s", file);
-			ril_config_merge_file(conf, file);
-		}
-
-		if (files) {
-			char **ptr;
-
-			for (ptr = files; *ptr; ptr++) {
-				DBG("Merging %s", *ptr);
-				ril_config_merge_file(conf, *ptr);
-			}
-
-			g_strfreev(files);
-		}
-	}
-}
-
 /*
  * Local Variables:
  * mode: C

ofono/drivers/ril/ril_config.h

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2018 Jolla Ltd.
+ *  Copyright (C) 2015-2017 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -22,21 +22,13 @@
 
 #define RILCONF_SETTINGS_GROUP      "Settings"
 
-void ril_config_merge_files(GKeyFile *conf, const char *file);
-
-char *ril_config_get_string(GKeyFile *file, const char *group,
-					const char *key);
-char **ril_config_get_strings(GKeyFile *file, const char *group,
-			      const char *key, char delimiter);
+char *ril_config_get_string(GKeyFile *file, const char *group, const char *key);
 gboolean ril_config_get_integer(GKeyFile *file, const char *group,
 					const char *key, int *value);
 gboolean ril_config_get_boolean(GKeyFile *file, const char *group,
 					const char *key, gboolean *value);
 gboolean ril_config_get_flag(GKeyFile *file, const char *group,
 					const char *key, int flag, int *flags);
-gboolean ril_config_get_enum(GKeyFile *file, const char *group,
-					const char *key, int *result,
-					const char *name, int value, ...);
 GUtilInts *ril_config_get_ints(GKeyFile *file, const char *group,
 					const char *key);
 char *ril_config_ints_to_string(GUtilInts *ints, char separator);

ofono/drivers/ril/ril_constants.h

@@ -1,6 +1,10 @@
 /*
+ *  RIL constants adopted from AOSP's header:
+ *
+ *  /hardware/ril/reference_ril/ril.h
+ *
  *  Copyright (C) 2013 Canonical Ltd.
- *  Copyright (C) 2013-2018 Jolla Ltd.
+ *  Copyright (C) 2013-2017 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -15,9 +19,47 @@
 #ifndef __RIL_CONSTANTS_H
 #define __RIL_CONSTANTS_H 1
 
-#include <ofono/ril-constants.h>
+/* Error Codes */
+#define RIL_E_SUCCESS 0
+#define RIL_E_RADIO_NOT_AVAILABLE 1
+#define RIL_E_GENERIC_FAILURE 2
+#define RIL_E_PASSWORD_INCORRECT 3
+#define RIL_E_SIM_PIN2 4
+#define RIL_E_SIM_PUK2 5
+#define RIL_E_REQUEST_NOT_SUPPORTED 6
+#define RIL_E_CANCELLED 7
+#define RIL_E_OP_NOT_ALLOWED_DURING_VOICE_CALL 8
+#define RIL_E_OP_NOT_ALLOWED_BEFORE_REG_TO_NW 9
+#define RIL_E_SMS_SEND_FAIL_RETRY 10
+#define RIL_E_SIM_ABSENT 11
+#define RIL_E_SUBSCRIPTION_NOT_AVAILABLE 12
+#define RIL_E_MODE_NOT_SUPPORTED 13
+#define RIL_E_FDN_CHECK_FAILURE 14
+#define RIL_E_ILLEGAL_SIM_OR_ME 15
+#define RIL_E_UNUSED 16
+#define RIL_E_DIAL_MODIFIED_TO_USSD 17
+#define RIL_E_DIAL_MODIFIED_TO_SS 18
+#define RIL_E_DIAL_MODIFIED_TO_DIAL 19
+#define RIL_E_USSD_MODIFIED_TO_DIAL 20
+#define RIL_E_USSD_MODIFIED_TO_SS 21
+#define RIL_E_USSD_MODIFIED_TO_USSD 22
+#define RIL_E_SS_MODIFIED_TO_DIAL 23
+#define RIL_E_SS_MODIFIED_TO_USSD 24
+#define RIL_E_SS_MODIFIED_TO_SS 25
+#define RIL_E_SUBSCRIPTION_NOT_SUPPORTED 26
+#define RIL_E_MISSING_RESOURCE 27
+#define RIL_E_NO_SUCH_ELEMENT 28
+#define RIL_E_INVALID_PARAMETER 29
 
-#define RIL_MAX_UUID_LENGTH 64
+/* call states */
+enum ril_call_state {
+	RIL_CALL_ACTIVE   = 0,
+	RIL_CALL_HOLDING  = 1,
+	RIL_CALL_DIALING  = 2,
+	RIL_CALL_ALERTING = 3,
+	RIL_CALL_INCOMING = 4,
+	RIL_CALL_WAITING  = 5
+};
 
 /* Radio state */
 enum ril_radio_state {
@@ -71,60 +113,7 @@ enum ril_radio_tech {
 	RADIO_TECH_HSPAP    = 15,
 	RADIO_TECH_GSM      = 16,
 	RADIO_TECH_TD_SCDMA = 17,
-	RADIO_TECH_IWLAN    = 18,
-	RADIO_TECH_LTE_CA   = 19
-};
-
-/* Radio capabilities */
-enum ril_radio_access_family {
-	RAF_GPRS     = (1 << RADIO_TECH_GPRS),
-	RAF_EDGE     = (1 << RADIO_TECH_EDGE),
-	RAF_UMTS     = (1 << RADIO_TECH_UMTS),
-	RAF_IS95A    = (1 << RADIO_TECH_IS95A),
-	RAF_IS95B    = (1 << RADIO_TECH_IS95B),
-	RAF_1xRTT    = (1 << RADIO_TECH_1xRTT),
-	RAF_EVDO_0   = (1 << RADIO_TECH_EVDO_0),
-	RAF_EVDO_A   = (1 << RADIO_TECH_EVDO_A),
-	RAF_HSDPA    = (1 << RADIO_TECH_HSDPA),
-	RAF_HSUPA    = (1 << RADIO_TECH_HSUPA),
-	RAF_HSPA     = (1 << RADIO_TECH_HSPA),
-	RAF_EVDO_B   = (1 << RADIO_TECH_EVDO_B),
-	RAF_EHRPD    = (1 << RADIO_TECH_EHRPD),
-	RAF_LTE      = (1 << RADIO_TECH_LTE),
-	RAF_HSPAP    = (1 << RADIO_TECH_HSPAP),
-	RAF_GSM      = (1 << RADIO_TECH_GSM),
-	RAF_TD_SCDMA = (1 << RADIO_TECH_TD_SCDMA),
-	RAF_LTE_CA   = (1 << RADIO_TECH_LTE_CA)
-};
-
-enum ril_radio_capability_phase {
-	RC_PHASE_CONFIGURED = 0,
-	RC_PHASE_START      = 1,
-	RC_PHASE_APPLY      = 2,
-	RC_PHASE_UNSOL_RSP  = 3,
-	RC_PHASE_FINISH     = 4
-};
-
-enum ril_radio_capability_status {
-	RC_STATUS_NONE      = 0,
-	RC_STATUS_SUCCESS   = 1,
-	RC_STATUS_FAIL      = 2
-};
-
-#define RIL_RADIO_CAPABILITY_VERSION 1
-
-struct ril_radio_capability {
-	int version;
-	int session;
-	enum ril_radio_capability_phase phase;
-	enum ril_radio_access_family rat;
-	char logicalModemUuid[RIL_MAX_UUID_LENGTH];
-	int status;
-};
-
-enum ril_uicc_subscription_action {
-	RIL_UICC_SUBSCRIPTION_DEACTIVATE = 0,
-	RIL_UICC_SUBSCRIPTION_ACTIVATE = 1
+	RADIO_TECH_IWLAN    = 18
 };
 
 /* See RIL_REQUEST_LAST_CALL_FAIL_CAUSE */
@@ -192,30 +181,30 @@ enum ril_call_fail_cause {
 };
 
 enum ril_data_call_fail_cause {
-	PDP_FAIL_NONE = 0,
-	PDP_FAIL_OPERATOR_BARRED = 0x08,
-	PDP_FAIL_INSUFFICIENT_RESOURCES = 0x1A,
-	PDP_FAIL_MISSING_UKNOWN_APN = 0x1B,
-	PDP_FAIL_UNKNOWN_PDP_ADDRESS_TYPE = 0x1C,
-	PDP_FAIL_USER_AUTHENTICATION = 0x1D,
-	PDP_FAIL_ACTIVATION_REJECT_GGSN = 0x1E,
-	PDP_FAIL_ACTIVATION_REJECT_UNSPECIFIED = 0x1F,
-	PDP_FAIL_SERVICE_OPTION_NOT_SUPPORTED = 0x20,
-	PDP_FAIL_SERVICE_OPTION_NOT_SUBSCRIBED = 0x21,
-	PDP_FAIL_SERVICE_OPTION_OUT_OF_ORDER = 0x22,
-	PDP_FAIL_NSAPI_IN_USE = 0x23,
-	PDP_FAIL_REGULAR_DEACTIVATION = 0x24,
-	PDP_FAIL_ONLY_IPV4_ALLOWED = 0x32,
-	PDP_FAIL_ONLY_IPV6_ALLOWED = 0x33,
-	PDP_FAIL_ONLY_SINGLE_BEARER_ALLOWED = 0x34,
-	PDP_FAIL_PROTOCOL_ERRORS = 0x6F,
-	PDP_FAIL_VOICE_REGISTRATION_FAIL = -1,
-	PDP_FAIL_DATA_REGISTRATION_FAIL = -2,
-	PDP_FAIL_SIGNAL_LOST = -3,
-	PDP_FAIL_PREF_RADIO_TECH_CHANGED = -4,
-	PDP_FAIL_RADIO_POWER_OFF = -5,
-	PDP_FAIL_TETHERED_CALL_ACTIVE = -6,
-	PDP_FAIL_ERROR_UNSPECIFIED = 0xffff
+    PDP_FAIL_NONE = 0,
+    PDP_FAIL_OPERATOR_BARRED = 0x08,
+    PDP_FAIL_INSUFFICIENT_RESOURCES = 0x1A,
+    PDP_FAIL_MISSING_UKNOWN_APN = 0x1B,
+    PDP_FAIL_UNKNOWN_PDP_ADDRESS_TYPE = 0x1C,
+    PDP_FAIL_USER_AUTHENTICATION = 0x1D,
+    PDP_FAIL_ACTIVATION_REJECT_GGSN = 0x1E,
+    PDP_FAIL_ACTIVATION_REJECT_UNSPECIFIED = 0x1F,
+    PDP_FAIL_SERVICE_OPTION_NOT_SUPPORTED = 0x20,
+    PDP_FAIL_SERVICE_OPTION_NOT_SUBSCRIBED = 0x21,
+    PDP_FAIL_SERVICE_OPTION_OUT_OF_ORDER = 0x22,
+    PDP_FAIL_NSAPI_IN_USE = 0x23,
+    PDP_FAIL_REGULAR_DEACTIVATION = 0x24,
+    PDP_FAIL_ONLY_IPV4_ALLOWED = 0x32,
+    PDP_FAIL_ONLY_IPV6_ALLOWED = 0x33,
+    PDP_FAIL_ONLY_SINGLE_BEARER_ALLOWED = 0x34,
+    PDP_FAIL_PROTOCOL_ERRORS = 0x6F,
+    PDP_FAIL_VOICE_REGISTRATION_FAIL = -1,
+    PDP_FAIL_DATA_REGISTRATION_FAIL = -2,
+    PDP_FAIL_SIGNAL_LOST = -3,
+    PDP_FAIL_PREF_RADIO_TECH_CHANGED = -4,
+    PDP_FAIL_RADIO_POWER_OFF = -5,
+    PDP_FAIL_TETHERED_CALL_ACTIVE = -6,
+    PDP_FAIL_ERROR_UNSPECIFIED = 0xffff
 };
 
 /* RIL_REQUEST_DEACTIVATE_DATA_CALL parameter */
@@ -320,14 +309,222 @@ enum ril_cell_info_type {
 	RIL_CELL_INFO_TYPE_TD_SCDMA = 5
 };
 
-enum ril_restricted_state {
-	RIL_RESTRICTED_STATE_NONE         = 0x00,
-	RIL_RESTRICTED_STATE_CS_EMERGENCY = 0x01,
-	RIL_RESTRICTED_STATE_CS_NORMAL    = 0x02,
-	RIL_RESTRICTED_STATE_CS_ALL       = 0x04,
-	RIL_RESTRICTED_STATE_PS_ALL       = 0x10
+struct ril_cell_info_gsm {
+	int mcc;            /* Mobile Country Code (0..999) */
+	int mnc;            /* Mobile Network Code (0..999) */
+	int lac;            /* Location Area Code (0..65535) */
+	int cid;            /* GSM Cell Identity (0..65535) TS 27.007 */
+	int signalStrength; /* (0-31, 99) TS 27.007 */
+	int bitErrorRate;   /* (0-7, 99) TS 27.007 */
 };
 
+struct ril_cell_info_wcdma {
+	int mcc;            /* Mobile Country Code (0..999) */
+	int mnc;            /* Mobile Network Code (0..999) */
+	int lac;            /* Location Area Code (0..65535) */
+	int cid;            /* UMTS Cell Identity (0..268435455) TS 25.331 */
+	int psc;            /* Primary Scrambling Code (0..511) TS 25.331) */
+	int signalStrength; /* (0-31, 99) TS 27.007 */
+	int bitErrorRate;   /* (0-7, 99) TS 27.007 */
+};
+
+struct ril_cell_info_lte {
+	int mcc;            /* Mobile Country Code (0..999) */
+	int mnc;            /* Mobile Network Code (0..999) */
+	int ci;             /* Cell Identity */
+	int pci;            /* Physical cell id (0..503) */
+	int tac;            /* Tracking area code */
+	int signalStrength; /* (0-31, 99) TS 27.007 8.5 */
+	int rsrp;           /* Reference Signal Receive Power TS 36.133 */
+	int rsrq;           /* Reference Signal Receive Quality TS 36.133 */
+	int rssnr;          /* Reference Signal-to-Noise Ratio TS 36.101*/
+	int cqi;            /* Channel Quality Indicator TS 36.101 */
+	int timingAdvance;  /* (Distance = 300m/us) TS 36.321 */
+};
+
+/* RIL Request Messages */
+#define RIL_REQUEST_GET_SIM_STATUS 1
+#define RIL_REQUEST_ENTER_SIM_PIN 2
+#define RIL_REQUEST_ENTER_SIM_PUK 3
+#define RIL_REQUEST_ENTER_SIM_PIN2 4
+#define RIL_REQUEST_ENTER_SIM_PUK2 5
+#define RIL_REQUEST_CHANGE_SIM_PIN 6
+#define RIL_REQUEST_CHANGE_SIM_PIN2 7
+#define RIL_REQUEST_ENTER_NETWORK_DEPERSONALIZATION 8
+#define RIL_REQUEST_GET_CURRENT_CALLS 9
+#define RIL_REQUEST_DIAL 10
+#define RIL_REQUEST_GET_IMSI 11
+#define RIL_REQUEST_HANGUP 12
+#define RIL_REQUEST_HANGUP_WAITING_OR_BACKGROUND 13
+#define RIL_REQUEST_HANGUP_FOREGROUND_RESUME_BACKGROUND 14
+#define RIL_REQUEST_SWITCH_HOLDING_AND_ACTIVE 15
+#define RIL_REQUEST_CONFERENCE 16
+#define RIL_REQUEST_UDUB 17
+#define RIL_REQUEST_LAST_CALL_FAIL_CAUSE 18
+#define RIL_REQUEST_SIGNAL_STRENGTH 19
+#define RIL_REQUEST_VOICE_REGISTRATION_STATE 20
+#define RIL_REQUEST_DATA_REGISTRATION_STATE 21
+#define RIL_REQUEST_OPERATOR 22
+#define RIL_REQUEST_RADIO_POWER 23
+#define RIL_REQUEST_DTMF 24
+#define RIL_REQUEST_SEND_SMS 25
+#define RIL_REQUEST_SEND_SMS_EXPECT_MORE 26
+#define RIL_REQUEST_SETUP_DATA_CALL 27
+#define RIL_REQUEST_SIM_IO 28
+#define RIL_REQUEST_SEND_USSD 29
+#define RIL_REQUEST_CANCEL_USSD 30
+#define RIL_REQUEST_GET_CLIR 31
+#define RIL_REQUEST_SET_CLIR 32
+#define RIL_REQUEST_QUERY_CALL_FORWARD_STATUS 33
+#define RIL_REQUEST_SET_CALL_FORWARD 34
+#define RIL_REQUEST_QUERY_CALL_WAITING 35
+#define RIL_REQUEST_SET_CALL_WAITING 36
+#define RIL_REQUEST_SMS_ACKNOWLEDGE  37
+#define RIL_REQUEST_GET_IMEI 38
+#define RIL_REQUEST_GET_IMEISV 39
+#define RIL_REQUEST_ANSWER 40
+#define RIL_REQUEST_DEACTIVATE_DATA_CALL 41
+#define RIL_REQUEST_QUERY_FACILITY_LOCK 42
+#define RIL_REQUEST_SET_FACILITY_LOCK 43
+#define RIL_REQUEST_CHANGE_BARRING_PASSWORD 44
+#define RIL_REQUEST_QUERY_NETWORK_SELECTION_MODE 45
+#define RIL_REQUEST_SET_NETWORK_SELECTION_AUTOMATIC 46
+#define RIL_REQUEST_SET_NETWORK_SELECTION_MANUAL 47
+#define RIL_REQUEST_QUERY_AVAILABLE_NETWORKS 48
+#define RIL_REQUEST_DTMF_START 49
+#define RIL_REQUEST_DTMF_STOP 50
+#define RIL_REQUEST_BASEBAND_VERSION 51
+#define RIL_REQUEST_SEPARATE_CONNECTION 52
+#define RIL_REQUEST_SET_MUTE 53
+#define RIL_REQUEST_GET_MUTE 54
+#define RIL_REQUEST_QUERY_CLIP 55
+#define RIL_REQUEST_LAST_DATA_CALL_FAIL_CAUSE 56
+#define RIL_REQUEST_DATA_CALL_LIST 57
+#define RIL_REQUEST_RESET_RADIO 58
+#define RIL_REQUEST_OEM_HOOK_RAW 59
+#define RIL_REQUEST_OEM_HOOK_STRINGS 60
+#define RIL_REQUEST_SCREEN_STATE 61
+#define RIL_REQUEST_SET_SUPP_SVC_NOTIFICATION 62
+#define RIL_REQUEST_WRITE_SMS_TO_SIM 63
+#define RIL_REQUEST_DELETE_SMS_ON_SIM 64
+#define RIL_REQUEST_SET_BAND_MODE 65
+#define RIL_REQUEST_QUERY_AVAILABLE_BAND_MODE 66
+#define RIL_REQUEST_STK_GET_PROFILE 67
+#define RIL_REQUEST_STK_SET_PROFILE 68
+#define RIL_REQUEST_STK_SEND_ENVELOPE_COMMAND 69
+#define RIL_REQUEST_STK_SEND_TERMINAL_RESPONSE 70
+#define RIL_REQUEST_STK_HANDLE_CALL_SETUP_REQUESTED_FROM_SIM 71
+#define RIL_REQUEST_EXPLICIT_CALL_TRANSFER 72
+#define RIL_REQUEST_SET_PREFERRED_NETWORK_TYPE 73
+#define RIL_REQUEST_GET_PREFERRED_NETWORK_TYPE 74
+#define RIL_REQUEST_GET_NEIGHBORING_CELL_IDS 75
+#define RIL_REQUEST_SET_LOCATION_UPDATES 76
+#define RIL_REQUEST_CDMA_SET_SUBSCRIPTION_SOURCE 77
+#define RIL_REQUEST_CDMA_SET_ROAMING_PREFERENCE 78
+#define RIL_REQUEST_CDMA_QUERY_ROAMING_PREFERENCE 79
+#define RIL_REQUEST_SET_TTY_MODE 80
+#define RIL_REQUEST_QUERY_TTY_MODE 81
+#define RIL_REQUEST_CDMA_SET_PREFERRED_VOICE_PRIVACY_MODE 82
+#define RIL_REQUEST_CDMA_QUERY_PREFERRED_VOICE_PRIVACY_MODE 83
+#define RIL_REQUEST_CDMA_FLASH 84
+#define RIL_REQUEST_CDMA_BURST_DTMF 85
+#define RIL_REQUEST_CDMA_VALIDATE_AND_WRITE_AKEY 86
+#define RIL_REQUEST_CDMA_SEND_SMS 87
+#define RIL_REQUEST_CDMA_SMS_ACKNOWLEDGE 88
+#define RIL_REQUEST_GSM_GET_BROADCAST_SMS_CONFIG 89
+#define RIL_REQUEST_GSM_SET_BROADCAST_SMS_CONFIG 90
+#define RIL_REQUEST_GSM_SMS_BROADCAST_ACTIVATION 91
+#define RIL_REQUEST_CDMA_GET_BROADCAST_SMS_CONFIG 92
+#define RIL_REQUEST_CDMA_SET_BROADCAST_SMS_CONFIG 93
+#define RIL_REQUEST_CDMA_SMS_BROADCAST_ACTIVATION 94
+#define RIL_REQUEST_CDMA_SUBSCRIPTION 95
+#define RIL_REQUEST_CDMA_WRITE_SMS_TO_RUIM 96
+#define RIL_REQUEST_CDMA_DELETE_SMS_ON_RUIM 97
+#define RIL_REQUEST_DEVICE_IDENTITY 98
+#define RIL_REQUEST_EXIT_EMERGENCY_CALLBACK_MODE 99
+#define RIL_REQUEST_GET_SMSC_ADDRESS 100
+#define RIL_REQUEST_SET_SMSC_ADDRESS 101
+#define RIL_REQUEST_REPORT_SMS_MEMORY_STATUS 102
+#define RIL_REQUEST_REPORT_STK_SERVICE_IS_RUNNING 103
+#define RIL_REQUEST_CDMA_GET_SUBSCRIPTION_SOURCE 104
+#define RIL_REQUEST_ISIM_AUTHENTICATION 105
+#define RIL_REQUEST_ACKNOWLEDGE_INCOMING_GSM_SMS_WITH_PDU 106
+#define RIL_REQUEST_STK_SEND_ENVELOPE_WITH_STATUS 107
+#define RIL_REQUEST_VOICE_RADIO_TECH 108
+#define RIL_REQUEST_GET_CELL_INFO_LIST 109
+#define RIL_REQUEST_SET_UNSOL_CELL_INFO_LIST_RATE 110
+#define RIL_REQUEST_SET_INITIAL_ATTACH_APN 111
+#define RIL_REQUEST_IMS_REGISTRATION_STATE 112
+#define RIL_REQUEST_IMS_SEND_SMS 113
+#define RIL_REQUEST_SIM_TRANSMIT_APDU_BASIC 114
+#define RIL_REQUEST_SIM_OPEN_CHANNEL 115
+#define RIL_REQUEST_SIM_CLOSE_CHANNEL 116
+#define RIL_REQUEST_SIM_TRANSMIT_APDU_CHANNEL 117
+#define RIL_REQUEST_NV_READ_ITEM 118
+#define RIL_REQUEST_NV_WRITE_ITEM 119
+#define RIL_REQUEST_NV_WRITE_CDMA_PRL 120
+#define RIL_REQUEST_NV_RESET_CONFIG 121
+/* SET_UICC_SUBSCRIPTION was 115 in v9 and 122 in v10 and later */
+#define RIL_REQUEST_V9_SET_UICC_SUBSCRIPTION  115
+#define RIL_REQUEST_SET_UICC_SUBSCRIPTION  122
+#define RIL_REQUEST_ALLOW_DATA  123
+#define RIL_REQUEST_GET_HARDWARE_CONFIG 124
+#define RIL_REQUEST_SIM_AUTHENTICATION 125
+#define RIL_REQUEST_GET_DC_RT_INFO 126
+#define RIL_REQUEST_SET_DC_RT_INFO_RATE 127
+#define RIL_REQUEST_SET_DATA_PROFILE 128
+#define RIL_REQUEST_SHUTDOWN 129
+#define RIL_REQUEST_GET_RADIO_CAPABILITY 130
+#define RIL_REQUEST_SET_RADIO_CAPABILITY 131
+
+/* RIL Unsolicited Messages */
+#define RIL_UNSOL_RESPONSE_BASE 1000
+#define RIL_UNSOL_RESPONSE_RADIO_STATE_CHANGED 1000
+#define RIL_UNSOL_RESPONSE_CALL_STATE_CHANGED 1001
+#define RIL_UNSOL_RESPONSE_VOICE_NETWORK_STATE_CHANGED 1002
+#define RIL_UNSOL_RESPONSE_NEW_SMS 1003
+#define RIL_UNSOL_RESPONSE_NEW_SMS_STATUS_REPORT 1004
+#define RIL_UNSOL_RESPONSE_NEW_SMS_ON_SIM 1005
+#define RIL_UNSOL_ON_USSD 1006
+#define RIL_UNSOL_ON_USSD_REQUEST 1007
+#define RIL_UNSOL_NITZ_TIME_RECEIVED  1008
+#define RIL_UNSOL_SIGNAL_STRENGTH  1009
+#define RIL_UNSOL_DATA_CALL_LIST_CHANGED 1010
+#define RIL_UNSOL_SUPP_SVC_NOTIFICATION 1011
+#define RIL_UNSOL_STK_SESSION_END 1012
+#define RIL_UNSOL_STK_PROACTIVE_COMMAND 1013
+#define RIL_UNSOL_STK_EVENT_NOTIFY 1014
+#define RIL_UNSOL_STK_CALL_SETUP 1015
+#define RIL_UNSOL_SIM_SMS_STORAGE_FULL 1016
+#define RIL_UNSOL_SIM_REFRESH 1017
+#define RIL_UNSOL_CALL_RING 1018
+#define RIL_UNSOL_RESPONSE_SIM_STATUS_CHANGED 1019
+#define RIL_UNSOL_RESPONSE_CDMA_NEW_SMS 1020
+#define RIL_UNSOL_RESPONSE_NEW_BROADCAST_SMS 1021
+#define RIL_UNSOL_CDMA_RUIM_SMS_STORAGE_FULL 1022
+#define RIL_UNSOL_RESTRICTED_STATE_CHANGED 1023
+#define RIL_UNSOL_ENTER_EMERGENCY_CALLBACK_MODE 1024
+#define RIL_UNSOL_CDMA_CALL_WAITING 1025
+#define RIL_UNSOL_CDMA_OTA_PROVISION_STATUS 1026
+#define RIL_UNSOL_CDMA_INFO_REC 1027
+#define RIL_UNSOL_OEM_HOOK_RAW 1028
+#define RIL_UNSOL_RINGBACK_TONE 1029
+#define RIL_UNSOL_RESEND_INCALL_MUTE 1030
+#define RIL_UNSOL_CDMA_SUBSCRIPTION_SOURCE_CHANGED 1031
+#define RIL_UNSOL_CDMA_PRL_CHANGED 1032
+#define RIL_UNSOL_EXIT_EMERGENCY_CALLBACK_MODE 1033
+#define RIL_UNSOL_RIL_CONNECTED 1034
+#define RIL_UNSOL_VOICE_RADIO_TECH_CHANGED 1035
+#define RIL_UNSOL_CELL_INFO_LIST 1036
+#define RIL_UNSOL_RESPONSE_IMS_NETWORK_STATE_CHANGED 1037
+#define RIL_UNSOL_UICC_SUBSCRIPTION_STATUS_CHANGED 1038
+#define RIL_UNSOL_SRVCC_STATE_NOTIFY 1039
+#define RIL_UNSOL_HARDWARE_CONFIG_CHANGED 1040
+#define RIL_UNSOL_DC_RT_INFO_CHANGED 1041
+#define RIL_UNSOL_RADIO_CAPABILITY 1042
+#define RIL_UNSOL_ON_SS 1043
+#define RIL_UNSOL_STK_CC_ALPHA_NOTIFY 1044
+
 /* Suplementary services Service class*/
 #define SERVICE_CLASS_NONE 0
 

ofono/drivers/ril/ril_data.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2016-2018 Jolla Ltd.
+ *  Copyright (C) 2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -18,7 +18,6 @@
 #include "ril_network.h"
 #include "ril_sim_settings.h"
 #include "ril_util.h"
-#include "ril_vendor.h"
 #include "ril_log.h"
 
 #include <gutil_strv.h>
@@ -28,7 +27,9 @@
 #include <grilio_parser.h>
 #include <grilio_request.h>
 
+#define SETUP_DATA_CALL_PARAMS 7
 #define DATA_PROFILE_DEFAULT_STR "0"
+#define DEACTIVATE_DATA_CALL_PARAMS 2
 
 #define PROTO_IP_STR "IP"
 #define PROTO_IPV6_STR "IPV6"
@@ -76,12 +77,6 @@ enum ril_data_priv_flags {
 typedef GObjectClass RilDataClass;
 typedef struct ril_data RilData;
 
-enum ril_data_io_event_id {
-	IO_EVENT_DATA_CALL_LIST_CHANGED,
-	IO_EVENT_RESTRICTED_STATE_CHANGED,
-	IO_EVENT_COUNT
-};
-
 enum ril_data_settings_event_id {
 	SETTINGS_EVENT_IMSI_CHANGED,
 	SETTINGS_EVENT_PREF_MODE,
@@ -100,10 +95,7 @@ struct ril_data_priv {
 	struct ril_radio *radio;
 	struct ril_network *network;
 	struct ril_data_manager *dm;
-	struct ril_vendor_hook *vendor_hook;
-
 	enum ril_data_priv_flags flags;
-	enum ril_restricted_state restricted_state;
 
 	struct ril_data_request *req_queue;
 	struct ril_data_request *pending_req;
@@ -112,9 +104,8 @@ struct ril_data_priv {
 	guint slot;
 	char *log_prefix;
 	guint query_id;
-	gulong io_event_id[IO_EVENT_COUNT];
+	gulong io_event_id;
 	gulong settings_event_id[SETTINGS_EVENT_COUNT];
-	GHashTable* grab;
 };
 
 enum ril_data_signal {
@@ -179,53 +170,28 @@ struct ril_data_request_deact {
 	int cid;
 };
 
-struct ril_data_request_allow_data {
+struct ril_data_request_2g {
 	struct ril_data_request req;
-	gboolean allow;
+	gulong handler_id;
 };
 
 static void ril_data_manager_check_data(struct ril_data_manager *dm);
 static void ril_data_manager_check_network_mode(struct ril_data_manager *dm);
-static void ril_data_call_deact_cid(struct ril_data *data, int cid);
+
 static void ril_data_power_update(struct ril_data *self);
 static void ril_data_signal_emit(struct ril_data *self, enum ril_data_signal id)
 {
 	g_signal_emit(self, ril_data_signals[id], 0);
 }
 
-/*==========================================================================*
- * RIL requests
- *==========================================================================*/
-
-GRilIoRequest *ril_request_allow_data_new(gboolean allow)
-{
-	return grilio_request_array_int32_new(1, allow);
-}
-
-GRilIoRequest *ril_request_deactivate_data_call_new(int cid)
-{
-	GRilIoRequest *req = grilio_request_new();
-
-	grilio_request_append_int32(req, 2 /* Parameter count */);
-	grilio_request_append_format(req, "%d", cid);
-	grilio_request_append_format(req, "%d",
-					RIL_DEACTIVATE_DATA_CALL_NO_REASON);
-	return req;
-}
-
 /*==========================================================================*
  * ril_data_call
  *==========================================================================*/
 
-static struct ril_data_call *ril_data_call_new()
-{
-	return g_new0(struct ril_data_call, 1);
-}
-
 struct ril_data_call *ril_data_call_dup(const struct ril_data_call *call)
 {
 	if (call) {
-		struct ril_data_call *dc = ril_data_call_new();
+		struct ril_data_call *dc = g_new0(struct ril_data_call, 1);
 		dc->cid = call->cid;
 		dc->status = call->status;
 		dc->active = call->active;
@@ -242,18 +208,13 @@ struct ril_data_call *ril_data_call_dup(const struct ril_data_call *call)
 	}
 }
 
-static void ril_data_call_destroy(struct ril_data_call *call)
-{
-	g_free(call->ifname);
-	g_strfreev(call->dnses);
-	g_strfreev(call->addresses);
-	g_strfreev(call->gateways);
-}
-
 void ril_data_call_free(struct ril_data_call *call)
 {
 	if (call) {
-		ril_data_call_destroy(call);
+		g_free(call->ifname);
+		g_strfreev(call->dnses);
+		g_strfreev(call->addresses);
+		g_strfreev(call->gateways);
 		g_free(call);
 	}
 }
@@ -271,7 +232,7 @@ static void ril_data_call_list_free(struct ril_data_call_list *list)
 	}
 }
 
-static gint ril_data_call_compare(gconstpointer a, gconstpointer b)
+static gint ril_data_call_parse_compare(gconstpointer a, gconstpointer b)
 {
 	const struct ril_data_call *ca = a;
 	const struct ril_data_call *cb = b;
@@ -285,7 +246,7 @@ static gint ril_data_call_compare(gconstpointer a, gconstpointer b)
 	}
 }
 
-const char *ril_data_ofono_protocol_to_ril(enum ofono_gprs_proto proto)
+static const char *ril_data_ofono_protocol_to_ril(enum ofono_gprs_proto proto)
 {
 	switch (proto) {
 	case OFONO_GPRS_PROTO_IPV6:
@@ -299,7 +260,7 @@ const char *ril_data_ofono_protocol_to_ril(enum ofono_gprs_proto proto)
 	}
 }
 
-int ril_data_protocol_to_ofono(const gchar *str)
+static int ril_data_protocol_to_ofono(gchar *str)
 {
 	if (str) {
 		if (!strcmp(str, PROTO_IPV6_STR)) {
@@ -313,13 +274,14 @@ int ril_data_protocol_to_ofono(const gchar *str)
 	return -1;
 }
 
-static gboolean ril_data_call_parse_default(struct ril_data_call *call,
-					int version, GRilIoParser *rilp)
+static struct ril_data_call *ril_data_call_parse(int version,
+							GRilIoParser *rilp)
 {
 	int prot;
 	char *prot_str;
 	guint32 status = PDP_FAIL_ERROR_UNSPECIFIED;
 	guint32 active = RIL_DATA_CALL_INACTIVE;
+	struct ril_data_call *call = g_new0(struct ril_data_call, 1);
 
 	/* RIL_Data_Call_Response_v6 (see ril.h) */
 	grilio_parser_get_uint32(rilp, &status);
@@ -354,49 +316,13 @@ static gboolean ril_data_call_parse_default(struct ril_data_call *call,
 	}
 
 	g_free(prot_str);
-	return TRUE;
-}
-
-static struct ril_data_call *ril_data_call_parse(struct ril_vendor_hook *hook,
-					int version, GRilIoParser *parser)
-{
-	GRilIoParser copy = *parser;
-	struct ril_data_call *call = ril_data_call_new();
-	gboolean parsed = ril_vendor_hook_data_call_parse(hook, call,
-							version, parser);
-
-	if (!parsed) {
-		/* Try the default parser */
-		ril_data_call_destroy(call);
-		memset(call, 0, sizeof(*call));
-		*parser = copy;
-		parsed = ril_data_call_parse_default(call, version, parser);
-	}
-
-	if (parsed) {
-		DBG("[status=%d,retry=%d,cid=%d,active=%d,type=%s,ifname=%s,"
-			"mtu=%d,address=%s,dns=%s %s,gateways=%s]",
-			call->status, call->retry_time,
-			call->cid, call->active,
-			ril_data_ofono_protocol_to_ril(call->prot),
-			call->ifname, call->mtu,
-			call->addresses ? call->addresses[0] : NULL,
-			call->dnses ? call->dnses[0] : NULL,
-			(call->dnses && call->dnses[0] &&
-			call->dnses[1]) ? call->dnses[1] : "",
-			call->gateways ? call->gateways[0] : NULL);
-		return call;
-	} else {
-		ril_data_call_free(call);
-		return NULL;
-	}
+	return call;
 }
 
 static struct ril_data_call_list *ril_data_call_list_parse(const void *data,
-				guint len, struct ril_vendor_hook *hook,
-				enum ril_data_call_format format)
+			guint len, enum ril_data_call_format format)
 {
-	guint32 version, n, i;
+	unsigned int version, n, i;
 	GRilIoParser rilp;
 
 	grilio_parser_init(&rilp, data, len);
@@ -414,14 +340,25 @@ static struct ril_data_call_list *ril_data_call_list_parse(const void *data,
 		}
 
 		for (i = 0; i < n && !grilio_parser_at_end(&rilp); i++) {
-			struct ril_data_call *call = ril_data_call_parse(hook,
-							list->version, &rilp);
+			struct ril_data_call *call =
+				ril_data_call_parse(list->version, &rilp);
 
-			if (call) {
-				list->num++;
-				list->calls = g_slist_insert_sorted(list->calls,
-						call, ril_data_call_compare);
-			}
+			DBG("[status=%d,retry=%d,cid=%d,"
+				"active=%d,type=%s,ifname=%s,mtu=%d,"
+				"address=%s, dns=%s %s,gateways=%s]",
+				call->status, call->retry_time,
+				call->cid, call->active,
+				ril_data_ofono_protocol_to_ril(call->prot),
+				call->ifname, call->mtu,
+				call->addresses ? call->addresses[0] : NULL,
+				call->dnses ? call->dnses[0] : NULL,
+				(call->dnses && call->dnses[0] &&
+				call->dnses[1]) ? call->dnses[1] : "",
+				call->gateways ? call->gateways[0] : NULL);
+
+			list->num++;
+			list->calls = g_slist_insert_sorted(list->calls, call,
+					ril_data_call_parse_compare);
 		}
 
 		if (list->calls) {
@@ -515,7 +452,7 @@ static int ril_data_call_list_move_calls(struct ril_data_call_list *dest,
 				dest->num++;
 				src->calls = g_slist_delete_link(src->calls, l);
 				dest->calls = g_slist_insert_sorted(dest->calls,
-					call, ril_data_call_compare);
+					call, ril_data_call_parse_compare);
 			}
 
 			l = next;
@@ -546,10 +483,6 @@ struct ril_data_call *ril_data_call_find(struct ril_data_call_list *list,
 static void ril_data_set_calls(struct ril_data *self,
 					struct ril_data_call_list *list)
 {
-	struct ril_data_priv *priv = self->priv;
-	GHashTableIter it;
-	gpointer key;
-
 	if (!ril_data_call_list_equal(self->data_calls, list)) {
 		DBG("data calls changed");
 		ril_data_call_list_free(self->data_calls);
@@ -558,63 +491,6 @@ static void ril_data_set_calls(struct ril_data *self,
 	} else {
 		ril_data_call_list_free(list);
 	}
-
-	/* Clean up the grab table */
-	g_hash_table_iter_init(&it, priv->grab);
-	while (g_hash_table_iter_next(&it, &key, NULL)) {
-		const int cid = GPOINTER_TO_INT(key);
-
-		if (!ril_data_call_find(self->data_calls, cid)) {
-			g_hash_table_iter_remove(&it);
-		}
-	}
-
-	if (self->data_calls) {
-		GSList *l;
-
-		/* Disconnect stray calls (one at a time) */
-		for (l = self->data_calls->calls; l; l = l->next) {
-			struct ril_data_call *dc = l->data;
-
-			key = GINT_TO_POINTER(dc->cid);
-			if (!g_hash_table_contains(priv->grab, key)) {
-				DBG_(self, "stray call %u", dc->cid);
-				ril_data_call_deact_cid(self, dc->cid);
-				break;
-			}
-		}
-	}
-}
-
-static void ril_data_check_allowed(struct ril_data *self, gboolean was_allowed)
-{
-	if (ril_data_allowed(self) != was_allowed) {
-		ril_data_signal_emit(self, SIGNAL_ALLOW_CHANGED);
-	}
-}
-
-static void ril_data_restricted_state_changed_cb(GRilIoChannel *io, guint event,
-				const void *data, guint len, void *user_data)
-{
-	struct ril_data *self = RIL_DATA(user_data);
-	GRilIoParser rilp;
-	guint32 count, state;
-
-	GASSERT(event == RIL_UNSOL_RESTRICTED_STATE_CHANGED);
-	grilio_parser_init(&rilp, data, len);
-	if (grilio_parser_get_uint32(&rilp, &count) && count == 1 &&
-				grilio_parser_get_uint32(&rilp, &state) &&
-				grilio_parser_at_end(&rilp)) {
-		struct ril_data_priv *priv = self->priv;
-
-		if (priv->restricted_state != state) {
-			const gboolean was_allowed = ril_data_allowed(self);
-
-			DBG_(self, "restricted state 0x%02x", state);
-			priv->restricted_state = state;
-			ril_data_check_allowed(self, was_allowed);
-		}
-	}
 }
 
 static void ril_data_call_list_changed_cb(GRilIoChannel *io, guint event,
@@ -632,7 +508,7 @@ static void ril_data_call_list_changed_cb(GRilIoChannel *io, guint event,
 	}
 
 	ril_data_set_calls(self, ril_data_call_list_parse(data, len,
-			priv->vendor_hook, priv->options.data_call_format));
+	       				priv->options.data_call_format));
 }
 
 static void ril_data_query_data_calls_cb(GRilIoChannel *io, int ril_status,
@@ -641,18 +517,11 @@ static void ril_data_query_data_calls_cb(GRilIoChannel *io, int ril_status,
 	struct ril_data *self = RIL_DATA(user_data);
 	struct ril_data_priv *priv = self->priv;
 
-	/*
-	 * Only RIL_E_SUCCESS and RIL_E_RADIO_NOT_AVAILABLE are expected here,
-	 * all other errors are filtered out by ril_voicecall_clcc_retry()
-	 */
 	GASSERT(priv->query_id);
 	priv->query_id = 0;
 	if (ril_status == RIL_E_SUCCESS) {
 		ril_data_set_calls(self, ril_data_call_list_parse(data, len,
-			priv->vendor_hook, priv->options.data_call_format));
-	} else {
-		/* RADIO_NOT_AVAILABLE == no calls */
-		ril_data_set_calls(self, NULL);
+       					priv->options.data_call_format));
 	}
 }
 
@@ -855,7 +724,7 @@ static void ril_data_call_setup_cb(GRilIoChannel *io, int ril_status,
 
 	if (ril_status == RIL_E_SUCCESS) {
 		list = ril_data_call_list_parse(data, len,
-			priv->vendor_hook, priv->options.data_call_format);
+					priv->options.data_call_format);
 	}
 
 	if (list) {
@@ -918,8 +787,8 @@ static gboolean ril_data_call_setup_submit(struct ril_data_request *req)
 		G_CAST(req, struct ril_data_request_setup, req);
 	struct ril_data_priv *priv = req->data->priv;
 	const char *proto_str = ril_data_ofono_protocol_to_ril(setup->proto);
-	GRilIoRequest *ioreq;
-	int tech, auth = RIL_AUTH_NONE;
+	GRilIoRequest* ioreq;
+	int tech, auth;
 
 	GASSERT(proto_str);
 
@@ -942,40 +811,28 @@ static gboolean ril_data_call_setup_submit(struct ril_data_request *req)
 		tech = RADIO_TECH_HSPA;
 	}
 
-	if (setup->username && setup->username[0]) {
-		switch (setup->auth_method) {
-		case OFONO_GPRS_AUTH_METHOD_ANY:
-			auth = RIL_AUTH_BOTH;
-			break;
-		case OFONO_GPRS_AUTH_METHOD_NONE:
-			auth = RIL_AUTH_NONE;
-			break;
-		case OFONO_GPRS_AUTH_METHOD_CHAP:
-			auth = RIL_AUTH_CHAP;
-			break;
-		case OFONO_GPRS_AUTH_METHOD_PAP:
-			auth = RIL_AUTH_PAP;
-			break;
-		}
-	}
+        /*
+         * We do the same as in $AOSP/frameworks/opt/telephony/src/java/com/
+         * android/internal/telephony/dataconnection/DataConnection.java,
+         * onConnect(), and use authentication or not depending on whether
+         * the user field is empty or not.
+         */
+	auth = (setup->username && setup->username[0]) ?
+					RIL_AUTH_BOTH : RIL_AUTH_NONE;
 
-	/* Give vendor code a chance to build a vendor specific packet */
-	ioreq = ril_vendor_hook_data_call_req(priv->vendor_hook, tech,
-			DATA_PROFILE_DEFAULT_STR, setup->apn, setup->username,
-			setup->password, auth, proto_str);
-
-	if (!ioreq) {
-		/* The default one */
-		ioreq = grilio_request_new();
-		grilio_request_append_int32(ioreq, 7 /* Parameter count */);
-		grilio_request_append_format(ioreq, "%d", tech);
-		grilio_request_append_utf8(ioreq, DATA_PROFILE_DEFAULT_STR);
-		grilio_request_append_utf8(ioreq, setup->apn);
-		grilio_request_append_utf8(ioreq, setup->username);
-		grilio_request_append_utf8(ioreq, setup->password);
-		grilio_request_append_format(ioreq, "%d", auth);
-		grilio_request_append_utf8(ioreq, proto_str);
-	}
+	/*
+	 * TODO: add comments about tethering, other non-public
+	 * profiles...
+	 */
+	ioreq = grilio_request_new();
+	grilio_request_append_int32(ioreq, SETUP_DATA_CALL_PARAMS);
+	grilio_request_append_format(ioreq, "%d", tech);
+	grilio_request_append_utf8(ioreq, DATA_PROFILE_DEFAULT_STR);
+	grilio_request_append_utf8(ioreq, setup->apn);
+	grilio_request_append_utf8(ioreq, setup->username);
+	grilio_request_append_utf8(ioreq, setup->password);
+	grilio_request_append_format(ioreq, "%d", auth);
+	grilio_request_append_utf8(ioreq, proto_str);
 
 	GASSERT(!req->pending_id);
 	req->pending_id = grilio_queue_send_request_full(priv->q, ioreq,
@@ -1067,10 +924,6 @@ static void ril_data_call_deact_cb(GRilIoChannel *io, int ril_status,
 			ril_data_call_free(call);
 			ril_data_signal_emit(data, SIGNAL_CALLS_CHANGED);
 		}
-	} else {
-		/* Something seems to be slightly broken, request the
-		 * current state */
-		ril_data_poll_call_state(data);
 	}
 
 	if (req->cb.deact) {
@@ -1085,8 +938,12 @@ static gboolean ril_data_call_deact_submit(struct ril_data_request *req)
 	struct ril_data_request_deact *deact =
 		G_CAST(req, struct ril_data_request_deact, req);
 	struct ril_data_priv *priv = req->data->priv;
-	GRilIoRequest *ioreq =
-		ril_request_deactivate_data_call_new(deact->cid);
+	GRilIoRequest* ioreq = grilio_request_new();
+
+	grilio_request_append_int32(ioreq, DEACTIVATE_DATA_CALL_PARAMS);
+	grilio_request_append_format(ioreq, "%d", deact->cid);
+	grilio_request_append_format(ioreq, "%d",
+					RIL_DEACTIVATE_DATA_CALL_NO_REASON);
 
 	req->pending_id = grilio_queue_send_request_full(priv->q, ioreq,
 				RIL_REQUEST_DEACTIVATE_DATA_CALL,
@@ -1114,15 +971,19 @@ static struct ril_data_request *ril_data_call_deact_new(struct ril_data *data,
 	return req;
 }
 
-static void ril_data_call_deact_cid(struct ril_data *data, int cid)
-{
-	ril_data_request_queue(ril_data_call_deact_new(data, cid, NULL, NULL));
-}
-
 /*==========================================================================*
  * ril_data_allow_request
  *==========================================================================*/
 
+static GRilIoRequest *ril_data_allow_req(gboolean allow)
+{
+	GRilIoRequest *req = grilio_request_sized_new(8);
+
+	grilio_request_append_int32(req, 1);
+	grilio_request_append_int32(req, allow != FALSE);
+	return req;
+}
+
 static void ril_data_allow_cb(GRilIoChannel *io, int ril_status,
 			const void *req_data, guint len, void *user_data)
 {
@@ -1132,20 +993,13 @@ static void ril_data_allow_cb(GRilIoChannel *io, int ril_status,
 
 	ril_data_request_completed(req);
 
-	if (ril_status == RIL_E_SUCCESS) {
-		const gboolean was_allowed = ril_data_allowed(data);
-		struct ril_data_request_allow_data *ad =
-			G_CAST(req, struct ril_data_request_allow_data, req);
-
-		if (ad->allow) {
-			priv->flags |= RIL_DATA_FLAG_ON;
-			DBG_(data, "data on");
-		} else {
-			priv->flags &= ~RIL_DATA_FLAG_ON;
-			DBG_(data, "data off");
-		}
-
-		ril_data_check_allowed(data, was_allowed);
+	if (ril_status == RIL_E_SUCCESS &&
+				(priv->flags & RIL_DATA_FLAG_ALLOWED)) {
+		GASSERT(!ril_data_allowed(data));
+		priv->flags |= RIL_DATA_FLAG_ON;
+		GASSERT(ril_data_allowed(data));
+		DBG_(data, "data on");
+		ril_data_signal_emit(data, SIGNAL_ALLOW_CHANGED);
 	}
 
 	ril_data_request_finish(req);
@@ -1153,32 +1007,25 @@ static void ril_data_allow_cb(GRilIoChannel *io, int ril_status,
 
 static gboolean ril_data_allow_submit(struct ril_data_request *req)
 {
-	struct ril_data_request_allow_data *ad =
-		G_CAST(req, struct ril_data_request_allow_data, req);
-	GRilIoRequest *ioreq = ril_request_allow_data_new(ad->allow);
+	GRilIoRequest *ioreq = ril_data_allow_req(TRUE);
 	struct ril_data_priv *priv = req->data->priv;
 
 	grilio_request_set_retry(ioreq, RIL_RETRY_SECS*1000, -1);
-	grilio_request_set_blocking(ioreq, TRUE);
 	req->pending_id = grilio_queue_send_request_full(priv->q, ioreq,
 		RIL_REQUEST_ALLOW_DATA, ril_data_allow_cb, NULL, req);
 	grilio_request_unref(ioreq);
 	return TRUE;
 }
 
-static struct ril_data_request *ril_data_allow_new(struct ril_data *data,
-							gboolean allow)
+static struct ril_data_request *ril_data_allow_new(struct ril_data *data)
 {
-	struct ril_data_request_allow_data *ad =
-		g_new0(struct ril_data_request_allow_data, 1);
-	struct ril_data_request *req = &ad->req;
+	struct ril_data_request *req = g_new0(struct ril_data_request, 1);
 
 	req->name = "ALLOW_DATA";
 	req->data = data;
 	req->submit = ril_data_allow_submit;
 	req->cancel = ril_data_request_cancel_io;
 	req->flags = DATA_REQUEST_FLAG_CANCEL_WHEN_DISALLOWED;
-	ad->allow = allow;
 	return req;
 }
 
@@ -1226,19 +1073,19 @@ static gint ril_data_compare_cb(gconstpointer a, gconstpointer b)
 struct ril_data *ril_data_new(struct ril_data_manager *dm, const char *name,
 		struct ril_radio *radio, struct ril_network *network,
 		GRilIoChannel *io, const struct ril_data_options *options,
-		const struct ril_slot_config *config,
-		struct ril_vendor_hook *vendor_hook)
+		const struct ril_slot_config *config)
 {
 	GASSERT(dm);
 	if (G_LIKELY(dm)) {
 		struct ril_data *self = g_object_new(RIL_DATA_TYPE, NULL);
 		struct ril_data_priv *priv = self->priv;
 		struct ril_sim_settings *settings = network->settings;
+		GRilIoRequest *req = grilio_request_new();
 
 		priv->options = *options;
 		switch (priv->options.allow_data) {
-		case RIL_ALLOW_DATA_ENABLED:
-		case RIL_ALLOW_DATA_DISABLED:
+		case RIL_ALLOW_DATA_ON:
+		case RIL_ALLOW_DATA_OFF:
 			break;
 		default:
 			/*
@@ -1246,8 +1093,7 @@ struct ril_data *ril_data_new(struct ril_data_manager *dm, const char *name,
 			 * RIL_VERSION was 10
 			 */
 			priv->options.allow_data = (io->ril_version > 10) ?
-						RIL_ALLOW_DATA_ENABLED :
-						RIL_ALLOW_DATA_DISABLED;
+				RIL_ALLOW_DATA_ON : RIL_ALLOW_DATA_OFF;
 			break;
 		}
 
@@ -1260,16 +1106,9 @@ struct ril_data *ril_data_new(struct ril_data_manager *dm, const char *name,
 		priv->dm = ril_data_manager_ref(dm);
 		priv->radio = ril_radio_ref(radio);
 		priv->network = ril_network_ref(network);
-		priv->vendor_hook = ril_vendor_hook_ref(vendor_hook);
-
-		priv->io_event_id[IO_EVENT_DATA_CALL_LIST_CHANGED] =
-			grilio_channel_add_unsol_event_handler(io,
+		priv->io_event_id = grilio_channel_add_unsol_event_handler(io,
 				ril_data_call_list_changed_cb,
 				RIL_UNSOL_DATA_CALL_LIST_CHANGED, self);
-		priv->io_event_id[IO_EVENT_RESTRICTED_STATE_CHANGED] =
-			grilio_channel_add_unsol_event_handler(io,
-				ril_data_restricted_state_changed_cb,
-				RIL_UNSOL_RESTRICTED_STATE_CHANGED, self);
 
 		priv->settings_event_id[SETTINGS_EVENT_IMSI_CHANGED] =
 			ril_sim_settings_add_imsi_changed_handler(settings,
@@ -1279,7 +1118,12 @@ struct ril_data *ril_data_new(struct ril_data_manager *dm, const char *name,
 					ril_data_settings_changed, self);
 
 		/* Request the current state */
-		ril_data_poll_call_state(self);
+		grilio_request_set_retry(req, RIL_RETRY_SECS*1000, -1);
+		priv->query_id = grilio_queue_send_request_full(priv->q, req,
+					RIL_REQUEST_DATA_CALL_LIST,
+					ril_data_query_data_calls_cb,
+					NULL, self);
+		grilio_request_unref(req);
 
 		/* Order data contexts according to slot numbers */
 		dm->data_list = g_slist_insert_sorted(dm->data_list, self,
@@ -1290,39 +1134,6 @@ struct ril_data *ril_data_new(struct ril_data_manager *dm, const char *name,
 	return NULL;
 }
 
-static gboolean ril_data_poll_call_state_retry(GRilIoRequest* req,
-	int ril_status, const void* resp_data, guint resp_len, void* user_data)
-{
-	switch (ril_status) {
-	case RIL_E_SUCCESS:
-	case RIL_E_RADIO_NOT_AVAILABLE:
-		return FALSE;
-	default:
-		return TRUE;
-	}
-}
-
-void ril_data_poll_call_state(struct ril_data *self)
-{
-	if (G_LIKELY(self)) {
-		struct ril_data_priv *priv = self->priv;
-
-		if (!priv->query_id) {
-			GRilIoRequest *req = grilio_request_new();
-
-			grilio_request_set_retry(req, RIL_RETRY_SECS*1000, -1);
-			grilio_request_set_retry_func(req,
-					ril_data_poll_call_state_retry);
-			priv->query_id =
-				grilio_queue_send_request_full(priv->q, req,
-					RIL_REQUEST_DATA_CALL_LIST,
-					ril_data_query_data_calls_cb,
-					NULL, self);
-			grilio_request_unref(req);
-		}
-	}
-}
-
 struct ril_data *ril_data_ref(struct ril_data *self)
 {
 	if (G_LIKELY(self)) {
@@ -1343,8 +1154,6 @@ void ril_data_unref(struct ril_data *self)
 gboolean ril_data_allowed(struct ril_data *self)
 {
 	return G_LIKELY(self) &&
-		(self->priv->restricted_state &
-			RIL_RESTRICTED_STATE_PS_ALL) == 0 &&
 		(self->priv->flags &
 			(RIL_DATA_FLAG_ALLOWED | RIL_DATA_FLAG_ON)) ==
 			(RIL_DATA_FLAG_ALLOWED | RIL_DATA_FLAG_ON);
@@ -1359,7 +1168,9 @@ static void ril_data_deactivate_all(struct ril_data *self)
 			struct ril_data_call *call = l->data;
 			if (call->status == PDP_FAIL_NONE) {
 				DBG_(self, "deactivating call %u", call->cid);
-				ril_data_call_deact_cid(self, call->cid);
+				ril_data_request_queue(
+					ril_data_call_deact_new(self,
+						call->cid, NULL, NULL));
 			}
 		}
 	}
@@ -1369,7 +1180,8 @@ static void ril_data_power_update(struct ril_data *self)
 {
 	struct ril_data_priv *priv = self->priv;
 
-	if (priv->pending_req || priv->req_queue) {
+	if (priv->pending_req || priv->req_queue ||
+				(priv->flags & RIL_DATA_FLAG_ALLOWED)) {
 		ril_radio_power_on(priv->radio, self);
 	} else {
 		ril_radio_power_off(priv->radio, self);
@@ -1399,11 +1211,10 @@ static void ril_data_cancel_requests(struct ril_data *self,
 static void ril_data_disallow(struct ril_data *self)
 {
 	struct ril_data_priv *priv = self->priv;
-	const gboolean was_allowed = ril_data_allowed(self);
 
 	DBG_(self, "disallowed");
 	GASSERT(priv->flags & RIL_DATA_FLAG_ALLOWED);
-	priv->flags &= ~RIL_DATA_FLAG_ALLOWED;
+	priv->flags &= ~(RIL_DATA_FLAG_ALLOWED | RIL_DATA_FLAG_ON);
 
 	/*
 	 * Cancel all requests that can be canceled.
@@ -1416,18 +1227,7 @@ static void ril_data_disallow(struct ril_data *self)
 	 * requests are already pending? That's quite unlikely though)
 	 */
 	ril_data_deactivate_all(self);
-
-	if (priv->options.allow_data == RIL_ALLOW_DATA_ENABLED) {
-		/* Tell rild that the data is now disabled */
-		ril_data_request_queue(ril_data_allow_new(self, FALSE));
-	} else {
-		priv->flags &= ~RIL_DATA_FLAG_ON;
-		GASSERT(!ril_data_allowed(self));
-		DBG_(self, "data off");
-		ril_data_power_update(self);
-	}
-
-	ril_data_check_allowed(self, was_allowed);
+	ril_data_power_update(self);
 }
 
 static void ril_data_max_speed_cb(gpointer data, gpointer max_speed)
@@ -1444,7 +1244,12 @@ static void ril_data_disallow_cb(gpointer data_ptr, gpointer allowed)
 		struct ril_data *data = data_ptr;
 
 		if (data->priv->flags & RIL_DATA_FLAG_ALLOWED) {
+			const gboolean was_allowed = ril_data_allowed(data);
 			ril_data_disallow(data);
+			if (was_allowed) {
+				ril_data_signal_emit(data,
+						SIGNAL_ALLOW_CHANGED);
+			}
 		}
 	}
 }
@@ -1498,7 +1303,13 @@ void ril_data_allow(struct ril_data *self, enum ril_data_role role)
 			}
 		} else {
 			if (priv->flags & RIL_DATA_FLAG_ALLOWED) {
+				gboolean was_allowed = ril_data_allowed(self);
+
 				ril_data_disallow(self);
+				if (was_allowed) {
+					ril_data_signal_emit(self,
+							SIGNAL_ALLOW_CHANGED);
+				}
 				ril_data_manager_check_data(dm);
 			}
 		}
@@ -1526,39 +1337,12 @@ struct ril_data_request *ril_data_call_deactivate(struct ril_data *self,
 	return req;
 }
 
-gboolean ril_data_call_grab(struct ril_data *self, int cid, void *cookie)
-{
-	if (self && cookie && ril_data_call_find(self->data_calls, cid)) {
-		struct ril_data_priv *priv = self->priv;
-		gpointer key = GINT_TO_POINTER(cid);
-		void *prev = g_hash_table_lookup(priv->grab, key);
-
-		if (!prev) {
-			g_hash_table_insert(priv->grab, key, cookie);
-			return TRUE;
-		} else {
-			return (prev == cookie);
-		}
-	}
-	return FALSE;
-}
-
-void ril_data_call_release(struct ril_data *self, int cid, void *cookie)
-{
-	if (self && cookie) {
-		struct ril_data_priv *priv = self->priv;
-
-		g_hash_table_remove(priv->grab, GUINT_TO_POINTER(cid));
-	}
-}
-
 static void ril_data_init(struct ril_data *self)
 {
 	struct ril_data_priv *priv = G_TYPE_INSTANCE_GET_PRIVATE(self,
 		RIL_DATA_TYPE, struct ril_data_priv);
 
 	self->priv = priv;
-	priv->grab = g_hash_table_new(g_direct_hash, g_direct_equal);
 }
 
 static void ril_data_dispose(GObject *object)
@@ -1572,7 +1356,7 @@ static void ril_data_dispose(GObject *object)
 
 	ril_sim_settings_remove_handlers(settings, priv->settings_event_id,
 					G_N_ELEMENTS(priv->settings_event_id));
-	grilio_channel_remove_all_handlers(priv->io, priv->io_event_id);
+	grilio_channel_remove_handlers(priv->io, &priv->io_event_id, 1);
 	grilio_queue_cancel_all(priv->q, FALSE);
 	priv->query_id = 0;
 
@@ -1586,7 +1370,6 @@ static void ril_data_dispose(GObject *object)
 
 	dm->data_list = g_slist_remove(dm->data_list, self);
 	ril_data_manager_check_data(dm);
-	g_hash_table_destroy(priv->grab);
 	G_OBJECT_CLASS(ril_data_parent_class)->dispose(object);
 }
 
@@ -1603,7 +1386,6 @@ static void ril_data_finalize(GObject *object)
 	ril_network_unref(priv->network);
 	ril_data_manager_unref(priv->dm);
 	ril_data_call_list_free(self->data_calls);
-	ril_vendor_hook_unref(priv->vendor_hook);
 	G_OBJECT_CLASS(ril_data_parent_class)->finalize(object);
 }
 
@@ -1756,8 +1538,9 @@ static void ril_data_manager_switch_data_on(struct ril_data_manager *self,
 					OFONO_RADIO_ACCESS_MODE_ANY, TRUE);
 	}
 
-	if (priv->options.allow_data == RIL_ALLOW_DATA_ENABLED) {
-		ril_data_request_queue(ril_data_allow_new(data, TRUE));
+
+	if (priv->options.allow_data == RIL_ALLOW_DATA_ON) {
+		ril_data_request_queue(ril_data_allow_new(data));
 	} else {
 		priv->flags |= RIL_DATA_FLAG_ON;
 		GASSERT(ril_data_allowed(data));
@@ -1780,16 +1563,6 @@ static void ril_data_manager_check_data(struct ril_data_manager *self)
 	}
 }
 
-void ril_data_manager_assert_data_on(struct ril_data_manager *self)
-{
-	if (self) {
-		struct ril_data *data = ril_data_manager_allowed(self);
-		if (data) {
-			ril_data_request_queue(ril_data_allow_new(data, TRUE));
-		}
-	}
-}
-
 /*
  * Local Variables:
  * mode: C

ofono/drivers/ril/ril_data.h

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2016-2018 Jolla Ltd.
+ *  Copyright (C) 2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -17,11 +17,8 @@
 #define RIL_DATA_H
 
 #include "ril_types.h"
-
 #include <ofono/gprs-context.h>
 
-#include <glib-object.h>
-
 enum ril_data_call_active {
 	RIL_DATA_CALL_INACTIVE = 0,
 	RIL_DATA_CALL_LINK_DOWN = 1,
@@ -59,8 +56,8 @@ enum ril_data_manager_flags {
 
 enum ril_data_allow_data_opt {
 	RIL_ALLOW_DATA_AUTO,
-	RIL_ALLOW_DATA_ENABLED,
-	RIL_ALLOW_DATA_DISABLED
+	RIL_ALLOW_DATA_ON,
+	RIL_ALLOW_DATA_OFF
 };
 
 enum ril_data_call_format {
@@ -87,7 +84,6 @@ struct ril_data_manager;
 struct ril_data_manager *ril_data_manager_new(enum ril_data_manager_flags flg);
 struct ril_data_manager *ril_data_manager_ref(struct ril_data_manager *dm);
 void ril_data_manager_unref(struct ril_data_manager *dm);
-void ril_data_manager_assert_data_on(struct ril_data_manager *dm);
 
 typedef void (*ril_data_cb_t)(struct ril_data *data, void *arg);
 typedef void (*ril_data_call_setup_cb_t)(struct ril_data *data,
@@ -99,12 +95,10 @@ typedef void (*ril_data_call_deactivate_cb_t)(struct ril_data *data,
 struct ril_data *ril_data_new(struct ril_data_manager *dm, const char *name,
 		struct ril_radio *radio, struct ril_network *network,
 		GRilIoChannel *io, const struct ril_data_options *options,
-		const struct ril_slot_config *config,
-		struct ril_vendor_hook *vendor_hook);
+		const struct ril_slot_config *config);
 struct ril_data *ril_data_ref(struct ril_data *data);
 void ril_data_unref(struct ril_data *data);
 gboolean ril_data_allowed(struct ril_data *data);
-void ril_data_poll_call_state(struct ril_data *data);
 
 gulong ril_data_add_allow_changed_handler(struct ril_data *data,
 					ril_data_cb_t cb, void *arg);
@@ -123,21 +117,11 @@ struct ril_data_request *ril_data_call_deactivate(struct ril_data *data,
 void ril_data_request_detach(struct ril_data_request *req);
 void ril_data_request_cancel(struct ril_data_request *req);
 
-gboolean ril_data_call_grab(struct ril_data *data, int cid, void *cookie);
-void ril_data_call_release(struct ril_data *data, int cid, void *cookie);
-
 void ril_data_call_free(struct ril_data_call *call);
 struct ril_data_call *ril_data_call_dup(const struct ril_data_call *call);
 struct ril_data_call *ril_data_call_find(struct ril_data_call_list *list,
 								int cid);
 
-const char *ril_data_ofono_protocol_to_ril(enum ofono_gprs_proto proto);
-int ril_data_protocol_to_ofono(const gchar *str);
-
-/* Constructors of various kinds of RIL requests */
-GRilIoRequest *ril_request_allow_data_new(gboolean allow);
-GRilIoRequest *ril_request_deactivate_data_call_new(int cid);
-
 #endif /* RIL_DATA_H */
 
 /*

ofono/drivers/ril/ril_ecclist.h

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2016-2018 Jolla Ltd.
+ *  Copyright (C) 2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -18,8 +18,6 @@
 
 #include "ril_types.h"
 
-#include <glib-object.h>
-
 struct ril_ecclist_priv;
 
 struct ril_ecclist {

ofono/drivers/ril/ril_gprs_context.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2018 Jolla Ltd.
+ *  Copyright (C) 2015-2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -17,15 +17,14 @@
 #include "ril_network.h"
 #include "ril_data.h"
 #include "ril_util.h"
+#include "ril_mtu.h"
 #include "ril_log.h"
 
 #include <gutil_strv.h>
 
 #include <arpa/inet.h>
 
-#include "ofono.h"
 #include "common.h"
-#include "mtu-watch.h"
 
 #define CTX_ID_NONE ((unsigned int)(-1))
 
@@ -44,7 +43,7 @@ struct ril_gprs_context {
 	struct ril_data *data;
 	guint active_ctx_cid;
 	gulong calls_changed_id;
-	struct mtu_watch *mtu_watch;
+	struct ril_mtu_watch *mtu_watch;
 	struct ril_data_call *active_call;
 	struct ril_gprs_context_call activate;
 	struct ril_gprs_context_call deactivate;
@@ -64,7 +63,7 @@ static char *ril_gprs_context_netmask(const char *bits)
 			const char* str;
 			struct in_addr in;
 			in.s_addr = htonl((nbits == 32) ? 0xffffffff :
-					((1u << nbits)-1) << (32-nbits));
+					((1 << nbits)-1) << (32-nbits));
 			str = inet_ntoa(in);
 			if (str) {
 				return g_strdup(str);
@@ -88,7 +87,6 @@ static int ril_gprs_context_address_family(const char *addr)
 static void ril_gprs_context_free_active_call(struct ril_gprs_context *gcd)
 {
 	if (gcd->active_call) {
-		ril_data_call_release(gcd->data, gcd->active_call->cid, gcd);
 		ril_data_call_free(gcd->active_call);
 		gcd->active_call = NULL;
 	}
@@ -97,7 +95,7 @@ static void ril_gprs_context_free_active_call(struct ril_gprs_context *gcd)
 		gcd->calls_changed_id = 0;
 	}
 	if (gcd->mtu_watch) {
-		mtu_watch_free(gcd->mtu_watch);
+		ril_mtu_watch_free(gcd->mtu_watch);
 		gcd->mtu_watch = NULL;
 	}
 }
@@ -109,10 +107,9 @@ static void ril_gprs_context_set_active_call(struct ril_gprs_context *gcd,
 		ril_data_call_free(gcd->active_call);
 		gcd->active_call = ril_data_call_dup(call);
 		if (!gcd->mtu_watch) {
-			gcd->mtu_watch = mtu_watch_new(MAX_MTU);
+			gcd->mtu_watch = ril_mtu_watch_new(MAX_MTU);
 		}
-		mtu_watch_set_ifname(gcd->mtu_watch, call->ifname);
-		ril_data_call_grab(gcd->data, call->cid, gcd);
+		ril_mtu_watch_set_ifname(gcd->mtu_watch, call->ifname);
 	} else {
 		ril_gprs_context_free_active_call(gcd);
 	}
@@ -380,7 +377,7 @@ static void ril_gprs_context_call_list_changed(struct ril_data *data, void *arg)
 		ril_gprs_context_set_dns_servers(gc, call);
 	}
 
-	ofono_gprs_context_signal_change(gc, gcd->active_ctx_cid);
+	ofono_gprs_context_signal_change(gc, call->cid);
 	ril_data_call_free(prev_call);
 }
 
@@ -398,8 +395,6 @@ static void ril_gprs_context_activate_primary_cb(struct ril_data *data,
 	if (ril_status != RIL_E_SUCCESS) {
 		ofono_error("GPRS context: Reply failure: %s",
 					ril_error_to_string(ril_status));
-	} else if (!call) {
-		ofono_error("Unexpected data call failure");
 	} else if (call->status != PDP_FAIL_NONE) {
 		ofono_error("Unexpected data call status %d", call->status);
 		error.type = OFONO_ERROR_TYPE_CMS;
@@ -449,7 +444,7 @@ static void ril_gprs_context_activate_primary(struct ofono_gprs_context *gc,
 	/* Let's make sure that we aren't connecting when roaming not allowed */
 	if (rs == NETWORK_REGISTRATION_STATUS_ROAMING) {
 		struct ofono_gprs *gprs = ril_modem_ofono_gprs(gcd->modem);
-		if (!__ofono_gprs_get_roaming_allowed(gprs) &&
+		if (!ofono_gprs_get_roaming_allowed(gprs) &&
 			ril_netreg_check_if_really_roaming(netreg, rs) ==
 					NETWORK_REGISTRATION_STATUS_ROAMING) {
 			struct ofono_error error;
@@ -580,7 +575,7 @@ static void ril_gprs_context_remove(struct ofono_gprs_context *gc)
 	ril_data_unref(gcd->data);
 	ril_network_unref(gcd->network);
 	ril_data_call_free(gcd->active_call);
-	mtu_watch_free(gcd->mtu_watch);
+	ril_mtu_watch_free(gcd->mtu_watch);
 	g_free(gcd);
 }
 

ofono/drivers/ril/ril_modem.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2018 Jolla Ltd.
+ *  Copyright (C) 2015-2017 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -25,8 +25,6 @@
 
 #include "ofono.h"
 
-#include "sailfish_watch.h"
-
 #define MAX_PDP_CONTEXTS        (2)
 #define ONLINE_TIMEOUT_SECS     (15) /* 20 sec is hardcoded in ofono core */
 
@@ -52,18 +50,25 @@ struct ril_modem_online_request {
 
 struct ril_modem_data {
 	struct ril_modem modem;
-	struct sailfish_watch *watch;
 	GRilIoQueue *q;
 	char *log_prefix;
 	char *imeisv;
 	char *imei;
 	char *ecclist_file;
-	gulong imsi_event_id;
+	gboolean pre_sim_done;
+	gboolean allow_data;
+	gulong sim_imsi_event_id;
 
 	guint online_check_id;
 	enum ril_modem_power_state power_state;
 	gulong radio_state_event_id;
 
+	ril_modem_cb_t removed_cb;
+	void *removed_cb_data;
+
+	ril_modem_online_cb_t online_cb;
+	void *online_cb_data;
+
 	struct ril_modem_online_request set_online;
 	struct ril_modem_online_request set_offline;
 };
@@ -79,6 +84,11 @@ static struct ril_modem_data *ril_modem_data_from_ofono(struct ofono_modem *o)
 	return md;
 }
 
+static struct ril_modem_data *ril_modem_data_from_modem(struct ril_modem *m)
+{
+	return m ? G_CAST(m, struct ril_modem_data, modem) : NULL;
+}
+
 static void *ril_modem_get_atom_data(struct ril_modem *modem,
 						enum ofono_atom_type type)
 {
@@ -122,6 +132,24 @@ void ril_modem_delete(struct ril_modem *md)
 	}
 }
 
+void ril_modem_set_removed_cb(struct ril_modem *modem, ril_modem_cb_t cb,
+								void *data)
+{
+	struct ril_modem_data *md = ril_modem_data_from_modem(modem);
+
+	md->removed_cb = cb;
+	md->removed_cb_data = data;
+}
+
+void ril_modem_set_online_cb(struct ril_modem *modem, ril_modem_online_cb_t cb,
+								void *data)
+{
+	struct ril_modem_data *md = ril_modem_data_from_modem(modem);
+
+	md->online_cb = cb;
+	md->online_cb_data = data;
+}
+
 static void ril_modem_online_request_ok(struct ril_modem_online_request *req)
 {
 	if (req->timeout_id) {
@@ -206,7 +234,7 @@ static void ril_modem_schedule_online_check(struct ril_modem_data *md)
 static void ril_modem_update_radio_settings(struct ril_modem_data *md)
 {
 	struct ril_modem *m = &md->modem;
-	if (m->radio->state == RADIO_STATE_ON && md->watch->imsi) {
+	if (m->radio->state == RADIO_STATE_ON && m->sim_settings->imsi) {
 		/* radio-settings.c assumes that IMSI is available */
 		if (!ril_modem_radio_settings(m)) {
 			DBG_(md, "initializing radio settings interface");
@@ -234,11 +262,11 @@ static void ril_modem_radio_state_cb(struct ril_radio *radio, void *data)
 	ril_modem_update_online_state(md);
 }
 
-static void ril_modem_imsi_cb(struct sailfish_watch *watch, void *data)
+static void ril_modem_imsi_cb(struct ril_sim_settings *settings, void *data)
 {
 	struct ril_modem_data *md = data;
 
-	GASSERT(md->watch == watch);
+	GASSERT(md->modem.sim_settings == settings);
 	ril_modem_update_radio_settings(md);
 }
 
@@ -247,11 +275,10 @@ static void ril_modem_pre_sim(struct ofono_modem *modem)
 	struct ril_modem_data *md = ril_modem_data_from_ofono(modem);
 
 	DBG("%s", ofono_modem_get_path(modem));
+	md->pre_sim_done = TRUE;
 	ofono_devinfo_create(modem, 0, RILMODEM_DRIVER, md);
 	ofono_sim_create(modem, 0, RILMODEM_DRIVER, md);
-	if (md->modem.config.enable_voicecall) {
-		ofono_voicecall_create(modem, 0, RILMODEM_DRIVER, md);
-	}
+	ofono_voicecall_create(modem, 0, RILMODEM_DRIVER, md);
 	if (!md->radio_state_event_id) {
 		md->radio_state_event_id =
 			ril_radio_add_state_changed_handler(md->modem.radio,
@@ -285,10 +312,8 @@ static void ril_modem_post_sim(struct ofono_modem *modem)
 	ofono_call_forwarding_create(modem, 0, RILMODEM_DRIVER, md);
 	ofono_call_barring_create(modem, 0, RILMODEM_DRIVER, md);
 	ofono_stk_create(modem, 0, RILMODEM_DRIVER, md);
+	ofono_cbs_create(modem, 0, RILMODEM_DRIVER, md);
 	ofono_message_waiting_register(ofono_message_waiting_create(modem));
-	if (md->modem.config.enable_cbs) {
-		ofono_cbs_create(modem, 0, RILMODEM_DRIVER, md);
-	}
 }
 
 static void ril_modem_post_online(struct ofono_modem *modem)
@@ -307,18 +332,20 @@ static void ril_modem_set_online(struct ofono_modem *modem, ofono_bool_t online,
 				ofono_modem_online_cb_t cb, void *data)
 {
 	struct ril_modem_data *md = ril_modem_data_from_ofono(modem);
-	struct ril_radio *radio = md->modem.radio;
 	struct ril_modem_online_request *req;
 
 	DBG("%s going %sline", ofono_modem_get_path(modem),
 						online ? "on" : "off");
 
-	ril_radio_set_online(radio, online);
+	if (md->online_cb) {
+		md->online_cb(&md->modem, online, md->online_cb_data);
+	}
+
 	if (online) {
-		ril_radio_power_on(radio, RADIO_POWER_TAG(md));
+		ril_radio_power_on(md->modem.radio, RADIO_POWER_TAG(md));
 		req = &md->set_online;
 	} else {
-		ril_radio_power_off(radio, RADIO_POWER_TAG(md));
+		ril_radio_power_off(md->modem.radio, RADIO_POWER_TAG(md));
 		req = &md->set_offline;
 	}
 
@@ -367,15 +394,24 @@ static void ril_modem_remove(struct ofono_modem *ofono)
 	struct ril_modem *modem = &md->modem;
 
 	DBG("%s", ril_modem_get_path(modem));
+	if (md->removed_cb) {
+		ril_modem_cb_t cb = md->removed_cb;
+		void *data = md->removed_cb_data;
+
+		md->removed_cb = NULL;
+		md->removed_cb_data = NULL;
+		cb(modem, data);
+	}
+
 	ofono_modem_set_data(ofono, NULL);
 
 	ril_radio_remove_handler(modem->radio, md->radio_state_event_id);
 	ril_radio_power_off(modem->radio, RADIO_POWER_TAG(md));
 	ril_radio_unref(modem->radio);
-	ril_sim_settings_unref(modem->sim_settings);
 
-	sailfish_watch_remove_handler(md->watch, md->imsi_event_id);
-	sailfish_watch_unref(md->watch);
+	ril_sim_settings_remove_handler(modem->sim_settings,
+					md->sim_imsi_event_id);
+	ril_sim_settings_unref(modem->sim_settings);
 
 	if (md->online_check_id) {
 		g_source_remove(md->online_check_id);
@@ -391,8 +427,8 @@ static void ril_modem_remove(struct ofono_modem *ofono)
 
 	ril_network_unref(modem->network);
 	ril_sim_card_unref(modem->sim_card);
+	ril_cell_info_unref(modem->cell_info);
 	ril_data_unref(modem->data);
-	sailfish_cell_info_unref(modem->cell_info);
 	grilio_channel_unref(modem->io);
 	grilio_queue_cancel_all(md->q, FALSE);
 	grilio_queue_unref(md->q);
@@ -404,15 +440,13 @@ static void ril_modem_remove(struct ofono_modem *ofono)
 }
 
 struct ril_modem *ril_modem_create(GRilIoChannel *io, const char *log_prefix,
-		const char *path, const char *imei, const char *imeisv,
-		const char *ecclist_file, const struct ril_slot_config *config,
-		struct ril_radio *radio, struct ril_network *network,
-		struct ril_sim_card *card, struct ril_data *data,
-		struct ril_sim_settings *settings,
-		struct sailfish_cell_info *cell_info)
+		const struct ril_slot_info *slot, struct ril_radio *radio,
+		struct ril_network *network, struct ril_sim_card *card,
+		struct ril_data *data, struct ril_sim_settings *settings,
+		struct ril_cell_info *cell_info)
 {
 	/* Skip the slash from the path, it looks like "/ril_0" */
-	struct ofono_modem *ofono = ofono_modem_create(path + 1,
+	struct ofono_modem *ofono = ofono_modem_create(slot->path + 1,
 							RILMODEM_DRIVER);
 	if (ofono) {
 		int err;
@@ -423,14 +457,15 @@ struct ril_modem *ril_modem_create(GRilIoChannel *io, const char *log_prefix,
 		 * ril_plugin.c must wait until IMEI becomes known before
 		 * creating the modem
 		 */
-		GASSERT(imei);
+		GASSERT(slot->imei);
 
 		/* Copy config */
-		modem->config = *config;
-		modem->imei = md->imei = g_strdup(imei);
-		modem->imeisv = md->imeisv = g_strdup(imeisv);
-		modem->log_prefix = log_prefix;     /* No need to strdup */
-		modem->ecclist_file = ecclist_file; /* No need to strdup */
+		modem->config = *slot->config;
+		modem->imei = md->imei = g_strdup(slot->imei);
+		modem->imeisv = md->imeisv = g_strdup(slot->imeisv);
+		modem->log_prefix = log_prefix;
+		modem->ecclist_file =
+		md->ecclist_file = g_strdup(slot->ecclist_file);
 		md->log_prefix = (log_prefix && log_prefix[0]) ?
 			g_strconcat(log_prefix, " ", NULL) : g_strdup("");
 
@@ -439,14 +474,18 @@ struct ril_modem *ril_modem_create(GRilIoChannel *io, const char *log_prefix,
 		modem->network = ril_network_ref(network);
 		modem->sim_card = ril_sim_card_ref(card);
 		modem->sim_settings = ril_sim_settings_ref(settings);
-		modem->cell_info = sailfish_cell_info_ref(cell_info);
+		modem->cell_info = ril_cell_info_ref(cell_info);
 		modem->data = ril_data_ref(data);
 		modem->io = grilio_channel_ref(io);
 		md->q = grilio_queue_new(io);
-		md->watch = sailfish_watch_new(path);
 
-		md->imsi_event_id =
-			sailfish_watch_add_imsi_changed_handler(md->watch,
+		/*
+		 * modem->sim_settings->imsi follows IMSI known to the ofono
+		 * core, unlike ril_sim_info->imsi which may point to the
+		 * cached IMSI even before the PIN code is entered.
+		 */
+		md->sim_imsi_event_id =
+			ril_sim_settings_add_imsi_changed_handler(settings,
 						ril_modem_imsi_cb, md);
 
 		md->set_online.md = md;
@@ -454,10 +493,8 @@ struct ril_modem *ril_modem_create(GRilIoChannel *io, const char *log_prefix,
 		ofono_modem_set_data(ofono, md);
 		err = ofono_modem_register(ofono);
 		if (!err) {
+			ril_radio_power_cycle(modem->radio);
 			GASSERT(io->connected);
-			if (config->radio_power_cycle) {
-				ril_radio_power_cycle(modem->radio);
-			}
 
 			/*
 			 * ofono_modem_reset sets Powered to TRUE without
@@ -470,12 +507,11 @@ struct ril_modem *ril_modem_create(GRilIoChannel *io, const char *log_prefix,
 			/*
 			 * With some RIL implementations, querying available
 			 * band modes causes some magic Android properties to
-			 * appear.
+			 * appear. Otherwise this request is pretty harmless
+			 * and useless.
 			 */
-			if (config->query_available_band_mode) {
-				grilio_queue_send_request(md->q, NULL,
-					RIL_REQUEST_QUERY_AVAILABLE_BAND_MODE);
-			}
+			grilio_queue_send_request(md->q, NULL,
+				RIL_REQUEST_QUERY_AVAILABLE_BAND_MODE);
 
 			ril_modem_update_radio_settings(md);
 			return modem;

ofono/drivers/ril/ril_mtu.c

@@ -1,7 +1,7 @@
 /*
- *  oFono - Open Source Telephony
+ *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2016-2017 Jolla Ltd.
+ *  Copyright (C) 2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -13,23 +13,16 @@
  *  GNU General Public License for more details.
  */
 
-#include "mtu-watch.h"
+#include "ril_mtu.h"
+#include "ril_log.h"
 
-#include <ofono/log.h>
-
-#include <glib.h>
-
-#include <unistd.h>
-#include <string.h>
-#include <errno.h>
-#include <sys/ioctl.h>
-#include <sys/types.h>
 #include <net/if.h>
+#include <sys/ioctl.h>
 
 #include <linux/netlink.h>
 #include <linux/rtnetlink.h>
 
-struct mtu_watch {
+struct ril_mtu_watch {
 	int max_mtu;
 	char *ifname;
 	void *buf;
@@ -39,7 +32,7 @@ struct mtu_watch {
 	int fd;
 };
 
-static void mtu_watch_limit_mtu(struct mtu_watch *self)
+static void ril_mtu_watch_limit_mtu(struct ril_mtu_watch *self)
 {
 	int fd = socket(PF_INET, SOCK_DGRAM, 0);
 	if (fd >= 0) {
@@ -59,8 +52,8 @@ static void mtu_watch_limit_mtu(struct mtu_watch *self)
 	}
 }
 
-static void mtu_watch_handle_rtattr(struct mtu_watch *self,
-				const struct rtattr *rta, unsigned int len)
+static void ril_mtu_watch_handle_rtattr(struct ril_mtu_watch *self,
+					const struct rtattr *rta, int len)
 {
 	int mtu = 0;
 	const char *ifname = NULL;
@@ -77,43 +70,43 @@ static void mtu_watch_handle_rtattr(struct mtu_watch *self,
 	}
 	if (mtu > self->max_mtu && !g_strcmp0(ifname, self->ifname)) {
 		DBG("%s %d", ifname, mtu);
-		mtu_watch_limit_mtu(self);
+		ril_mtu_watch_limit_mtu(self);
 	}
 }
 
-static void mtu_watch_handle_ifinfomsg(struct mtu_watch *self,
-				const struct ifinfomsg *ifi, unsigned int len)
+static void ril_mtu_watch_handle_ifinfomsg(struct ril_mtu_watch *self,
+					const struct ifinfomsg *ifi, int len)
 {
 	if (ifi->ifi_flags & IFF_UP) {
 		const struct rtattr *rta = IFLA_RTA(ifi);
-		mtu_watch_handle_rtattr(self, rta,
+		ril_mtu_watch_handle_rtattr(self, rta,
 					len - ((char*)rta - (char*)ifi));
 	}
 }
 
-static void mtu_watch_handle_nlmsg(struct mtu_watch *self,
-				const struct nlmsghdr *hdr, unsigned int len)
+static void ril_mtu_watch_handle_nlmsg(struct ril_mtu_watch *self,
+					const struct nlmsghdr *hdr, int len)
 {
 	while (len > 0 && NLMSG_OK(hdr, len)) {
 		if (hdr->nlmsg_type == RTM_NEWLINK) {
-			mtu_watch_handle_ifinfomsg(self, NLMSG_DATA(hdr),
+			ril_mtu_watch_handle_ifinfomsg(self, NLMSG_DATA(hdr),
 						IFLA_PAYLOAD(hdr));
 		}
 		hdr = NLMSG_NEXT(hdr, len);
         }
 }
 
-static gboolean mtu_watch_event(GIOChannel *ch, GIOCondition cond,
+static gboolean ril_mtu_watch_event(GIOChannel *ch, GIOCondition cond,
 							gpointer data)
 {
-	struct mtu_watch *self = data;
+	struct ril_mtu_watch *self = data;
 	struct sockaddr_nl addr;
 	socklen_t addrlen = sizeof(addr);
 	ssize_t result = recvfrom(self->fd, self->buf, self->bufsize, 0,
 				(struct sockaddr *)&addr, &addrlen);
 	if (result > 0) {
 		if (!addr.nl_pid) {
-			mtu_watch_handle_nlmsg(self, self->buf, result);
+			ril_mtu_watch_handle_nlmsg(self, self->buf, result);
 		}
 		return G_SOURCE_CONTINUE;
 	} else if (result == 0 || errno == EINTR || errno == EAGAIN) {
@@ -125,8 +118,9 @@ static gboolean mtu_watch_event(GIOChannel *ch, GIOCondition cond,
 	}
 }
 
-static gboolean mtu_watch_open_socket(struct mtu_watch *self)
+static gboolean ril_mtu_watch_open_socket(struct ril_mtu_watch *self)
 {
+	GASSERT(self->fd < 0);
 	self->fd = socket(PF_NETLINK, SOCK_RAW, NETLINK_ROUTE);
 	if (self->fd >= 0) {
 		struct sockaddr_nl nl;
@@ -146,18 +140,20 @@ static gboolean mtu_watch_open_socket(struct mtu_watch *self)
 	return FALSE;
 }
 
-static gboolean mtu_watch_start(struct mtu_watch *self)
+static gboolean ril_mtu_watch_start(struct ril_mtu_watch *self)
 {
 	if (self->fd >= 0) {
 		return TRUE;
-	} else if (mtu_watch_open_socket(self)) {
+	} else if (ril_mtu_watch_open_socket(self)) {
+		GASSERT(!self->channel);
+		GASSERT(!self->io_watch);
 		self->channel = g_io_channel_unix_new(self->fd);
 		if (self->channel) {
 			g_io_channel_set_encoding(self->channel, NULL, NULL);
 			g_io_channel_set_buffered(self->channel, FALSE);
 			self->io_watch = g_io_add_watch(self->channel,
 					G_IO_IN | G_IO_NVAL | G_IO_HUP,
-					mtu_watch_event, self);
+					ril_mtu_watch_event, self);
 			return TRUE;
 		}
 		close(self->fd);
@@ -166,7 +162,7 @@ static gboolean mtu_watch_start(struct mtu_watch *self)
 	return FALSE;
 }
 
-static void mtu_watch_stop(struct mtu_watch *self)
+static void ril_mtu_watch_stop(struct ril_mtu_watch *self)
 {
 	if (self->io_watch) {
 		g_source_remove(self->io_watch);
@@ -183,9 +179,9 @@ static void mtu_watch_stop(struct mtu_watch *self)
 	}
 }
 
-struct mtu_watch *mtu_watch_new(int max_mtu)
+struct ril_mtu_watch *ril_mtu_watch_new(int max_mtu)
 {
-	struct mtu_watch *self = g_new0(struct mtu_watch, 1);
+	struct ril_mtu_watch *self = g_new0(struct ril_mtu_watch, 1);
 	self->fd = -1;
 	self->max_mtu = max_mtu;
 	self->bufsize = 4096;
@@ -193,27 +189,35 @@ struct mtu_watch *mtu_watch_new(int max_mtu)
 	return self;
 }
 
-void mtu_watch_free(struct mtu_watch *self)
+void ril_mtu_watch_free(struct ril_mtu_watch *self)
 {
 	if (self) {
-		mtu_watch_stop(self);
+		ril_mtu_watch_stop(self);
 		g_free(self->ifname);
 		g_free(self->buf);
 		g_free(self);
 	}
 }
 
-void mtu_watch_set_ifname(struct mtu_watch *self, const char *ifname)
+void ril_mtu_watch_set_ifname(struct ril_mtu_watch *self, const char *ifname)
 {
 	if (self && g_strcmp0(self->ifname, ifname)) {
 		g_free(self->ifname);
 		if (ifname) {
 			self->ifname = g_strdup(ifname);
-			mtu_watch_limit_mtu(self);
-			mtu_watch_start(self);
+			ril_mtu_watch_limit_mtu(self);
+			ril_mtu_watch_start(self);
 		} else {
 			self->ifname = NULL;
-			mtu_watch_stop(self);
+			ril_mtu_watch_stop(self);
 		}
 	}
 }
+
+/*
+ * Local Variables:
+ * mode: C
+ * c-basic-offset: 8
+ * indent-tabs-mode: t
+ * End:
+ */

ofono/drivers/ril/ril_mtu.h

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2016-2017 Jolla Ltd.
+ *  Copyright (C) 2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -13,19 +13,16 @@
  *  GNU General Public License for more details.
  */
 
-#ifndef SAILFISH_CELL_INFO_DBUS_H
-#define SAILFISH_CELL_INFO_DBUS_H
+#ifndef RIL_MTU_H
+#define RIL_MTU_H
 
-struct ofono_modem;
+#include "ril_types.h"
 
-struct sailfish_cell_info;
-struct sailfish_cell_info_dbus;
+struct ril_mtu_watch *ril_mtu_watch_new(int max_mtu);
+void ril_mtu_watch_free(struct ril_mtu_watch *mw);
+void ril_mtu_watch_set_ifname(struct ril_mtu_watch *mw, const char *ifname);
 
-struct sailfish_cell_info_dbus *sailfish_cell_info_dbus_new
-		(struct ofono_modem *modem, struct sailfish_cell_info *info);
-void sailfish_cell_info_dbus_free(struct sailfish_cell_info_dbus *dbus);
-
-#endif /* SAILFISH_CELL_INFO_DBUS_H */
+#endif /* RIL_MTU_H */
 
 /*
  * Local Variables:

ofono/drivers/ril/ril_netmon.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2016-2018 Jolla Ltd.
+ *  Copyright (C) 2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -14,27 +14,18 @@
  */
 
 #include "ril_plugin.h"
+#include "ril_cell_info.h"
 #include "ril_util.h"
 #include "ril_log.h"
 
-#include <sailfish_cell_info.h>
-
 #include "ofono.h"
 
 struct ril_netmon {
 	struct ofono_netmon *netmon;
-	struct sailfish_cell_info *cell_info;
+	struct ril_cell_info *cell_info;
 	guint register_id;
 };
 
-/* This number must be in sync with ril_netmon_notify_ofono: */
-#define RIL_NETMON_MAX_OFONO_PARAMS (8)
-
-struct ril_netmon_ofono_param {
-	enum ofono_netmon_info type;
-	int value;
-};
-
 static inline struct ril_netmon *ril_netmon_get_data(struct ofono_netmon *ofono)
 {
 	return ofono ? ofono_netmon_get_data(ofono) : NULL;
@@ -48,7 +39,7 @@ static void ril_netmon_format_mccmnc(char *s_mcc, char *s_mnc, int mcc, int mnc)
 	if (mcc >= 0 && mcc <= 999) {
 		snprintf(s_mcc, OFONO_MAX_MCC_LENGTH + 1, "%03d", mcc);
 		if (mnc >= 0 && mnc <= 999) {
-			const unsigned int mnclen = mnclength(mcc, mnc);
+			const int mnclen = mnclength(mcc, mnc);
 			const char *format[] = { "%d", "%02d", "%03d" };
 			const char *fmt = (mnclen > 0 &&
 				mnclen <= G_N_ELEMENTS(format)) ? 
@@ -58,171 +49,58 @@ static void ril_netmon_format_mccmnc(char *s_mcc, char *s_mnc, int mcc, int mnc)
 	}
 }
 
-static void ril_netmon_notify_ofono(struct ofono_netmon *netmon,
-		enum ofono_netmon_cell_type type, int mcc, int mnc,
-		struct ril_netmon_ofono_param *params, int nparams)
+static void ril_netmon_notify_gsm(struct ofono_netmon *netmon,
+				const struct ril_cell_info_gsm *gsm)
 {
-	char s_mcc[OFONO_MAX_MCC_LENGTH + 1];
-	char s_mnc[OFONO_MAX_MNC_LENGTH + 1];
-	int i;
+	char mcc[OFONO_MAX_MCC_LENGTH + 1];
+	char mnc[OFONO_MAX_MNC_LENGTH + 1];
 
-	/* Better not to push uninitialized data to the stack ... */
-	for (i = nparams; i < RIL_NETMON_MAX_OFONO_PARAMS; i++) {
-		params[i].type = OFONO_NETMON_INFO_INVALID;
-		params[i].value = SAILFISH_CELL_INVALID_VALUE;
-	}
-
-	ril_netmon_format_mccmnc(s_mcc, s_mnc, mcc, mnc);
-	ofono_netmon_serving_cell_notify(netmon, type,
-			OFONO_NETMON_INFO_MCC, s_mcc,
-			OFONO_NETMON_INFO_MNC, s_mnc,
-			params[0].type, params[0].value,
-			params[1].type, params[1].value,
-			params[2].type, params[2].value,
-			params[3].type, params[3].value,
-			params[4].type, params[4].value,
-			params[5].type, params[5].value,
-			params[6].type, params[6].value,
-			params[7].type, params[7].value,
+	ril_netmon_format_mccmnc(mcc, mnc, gsm->mcc, gsm->mnc);
+	ofono_netmon_serving_cell_notify(netmon,
+			OFONO_NETMON_CELL_TYPE_GSM,
+			OFONO_NETMON_INFO_MCC, mcc,
+			OFONO_NETMON_INFO_MNC, mnc,
+			OFONO_NETMON_INFO_LAC, gsm->lac,
+			OFONO_NETMON_INFO_CI, gsm->cid,
+			OFONO_NETMON_INFO_RSSI, gsm->signalStrength,
+			OFONO_NETMON_INFO_BER, gsm->bitErrorRate,
 			OFONO_NETMON_INFO_INVALID);
 }
 
-static void ril_netmon_notify_gsm(struct ofono_netmon *netmon,
-				const struct sailfish_cell_info_gsm *gsm)
-{
-	struct ril_netmon_ofono_param params[RIL_NETMON_MAX_OFONO_PARAMS];
-	int n = 0;
-
-	if (gsm->lac != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_LAC;
-		params[n].value = gsm->lac;
-		n++;
-	}
-
-	if (gsm->cid != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_CI;
-		params[n].value = gsm->cid;
-		n++;
-	}
-
-	if (gsm->arfcn != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_ARFCN;
-		params[n].value = gsm->arfcn;
-		n++;
-	}
-
-	if (gsm->signalStrength != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_RSSI;
-		params[n].value = gsm->signalStrength;
-		n++;
-	}
-
-	if (gsm->bitErrorRate != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_BER;
-		params[n].value = gsm->bitErrorRate;
-		n++;
-	}
-
-	ril_netmon_notify_ofono(netmon, OFONO_NETMON_CELL_TYPE_GSM,
-					gsm->mcc, gsm->mnc, params, n);
-}
-
 static void ril_netmon_notify_wcdma(struct ofono_netmon *netmon,
-				const struct sailfish_cell_info_wcdma *wcdma)
+				const struct ril_cell_info_wcdma *wcdma)
 {
-	struct ril_netmon_ofono_param params[RIL_NETMON_MAX_OFONO_PARAMS];
-	int n = 0;
+	char mcc[OFONO_MAX_MCC_LENGTH + 1];
+	char mnc[OFONO_MAX_MNC_LENGTH + 1];
 
-	if (wcdma->lac != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_LAC;
-		params[n].value = wcdma->lac;
-		n++;
-	}
-
-	if (wcdma->cid != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_CI;
-		params[n].value = wcdma->cid;
-		n++;
-	}
-
-	if (wcdma->psc != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_PSC;
-		params[n].value = wcdma->psc;
-		n++;
-	}
-
-	if (wcdma->uarfcn != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_ARFCN;
-		params[n].value = wcdma->uarfcn;
-		n++;
-	}
-
-	if (wcdma->signalStrength != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_RSSI;
-		params[n].value = wcdma->signalStrength;
-		n++;
-	}
-
-	if (wcdma->bitErrorRate != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_BER;
-		params[n].value = wcdma->bitErrorRate;
-		n++;
-	}
-
-	ril_netmon_notify_ofono(netmon, OFONO_NETMON_CELL_TYPE_UMTS,
-					wcdma->mcc, wcdma->mnc, params, n);
+	ril_netmon_format_mccmnc(mcc, mnc, wcdma->mcc, wcdma->mnc);
+	ofono_netmon_serving_cell_notify(netmon,
+			OFONO_NETMON_CELL_TYPE_UMTS,
+			OFONO_NETMON_INFO_MCC, mcc,
+			OFONO_NETMON_INFO_MNC, mnc,
+			OFONO_NETMON_INFO_LAC, wcdma->lac,
+			OFONO_NETMON_INFO_CI, wcdma->cid,
+			OFONO_NETMON_INFO_PSC, wcdma->psc,
+			OFONO_NETMON_INFO_RSSI, wcdma->signalStrength,
+			OFONO_NETMON_INFO_BER, wcdma->bitErrorRate,
+			OFONO_NETMON_INFO_INVALID);
 }
 
 static void ril_netmon_notify_lte(struct ofono_netmon *netmon,
-				const struct sailfish_cell_info_lte *lte)
+				const struct ril_cell_info_lte *lte)
 {
-	struct ril_netmon_ofono_param params[RIL_NETMON_MAX_OFONO_PARAMS];
-	int n = 0;
+	char mcc[OFONO_MAX_MCC_LENGTH + 1];
+	char mnc[OFONO_MAX_MNC_LENGTH + 1];
 
-	if (lte->ci != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_CI;
-		params[n].value = lte->ci;
-		n++;
-	}
-
-	if (lte->earfcn != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_EARFCN;
-		params[n].value = lte->earfcn;
-		n++;
-	}
-
-	if (lte->signalStrength != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_RSSI;
-		params[n].value = lte->signalStrength;
-		n++;
-	}
-
-	if (lte->rsrp != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_RSRQ;
-		params[n].value = lte->rsrp;
-		n++;
-	}
-
-	if (lte->rsrq != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_RSRP;
-		params[n].value = lte->rsrq;
-		n++;
-	}
-
-	if (lte->cqi != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_CQI;
-		params[n].value = lte->cqi;
-		n++;
-	}
-
-	if (lte->timingAdvance != SAILFISH_CELL_INVALID_VALUE) {
-		params[n].type = OFONO_NETMON_INFO_TIMING_ADVANCE;
-		params[n].value = lte->timingAdvance;
-		n++;
-	}
-
-	ril_netmon_notify_ofono(netmon, OFONO_NETMON_CELL_TYPE_LTE,
-					lte->mcc, lte->mnc, params, n);
+	ril_netmon_format_mccmnc(mcc, mnc, lte->mcc, lte->mnc);
+	ofono_netmon_serving_cell_notify(netmon,
+			OFONO_NETMON_CELL_TYPE_LTE,
+			OFONO_NETMON_INFO_MCC, mcc,
+			OFONO_NETMON_INFO_MNC, mnc,
+			OFONO_NETMON_INFO_CI, lte->ci,
+			OFONO_NETMON_INFO_RSSI, lte->signalStrength,
+			OFONO_NETMON_INFO_TIMING_ADVANCE, lte->timingAdvance,
+			OFONO_NETMON_INFO_INVALID);
 }
 
 static void ril_netmon_request_update(struct ofono_netmon *netmon,
@@ -233,19 +111,19 @@ static void ril_netmon_request_update(struct ofono_netmon *netmon,
 	GSList *l;
 
 	for (l = nm->cell_info->cells; l; l = l->next) {
-		const struct sailfish_cell *cell = l->data;
+		const struct ril_cell *cell = l->data;
 
 		if (cell->registered) {
 			switch (cell->type) {
-			case SAILFISH_CELL_TYPE_GSM:
+			case RIL_CELL_INFO_TYPE_GSM:
 				ril_netmon_notify_gsm(netmon,
 							&cell->info.gsm);
 				break;
-			case SAILFISH_CELL_TYPE_WCDMA:
+			case RIL_CELL_INFO_TYPE_WCDMA:
 				ril_netmon_notify_wcdma(netmon,
 							&cell->info.wcdma);
 				break;
-			case SAILFISH_CELL_TYPE_LTE:
+			case RIL_CELL_INFO_TYPE_LTE:
 				ril_netmon_notify_lte(netmon,
 							&cell->info.lte);
 				break;
@@ -278,7 +156,7 @@ static int ril_netmon_probe(struct ofono_netmon *netmon, unsigned int vendor,
 	if (modem->cell_info) {
 		struct ril_netmon *nm = g_slice_new0(struct ril_netmon);
 
-		nm->cell_info = sailfish_cell_info_ref(modem->cell_info);
+		nm->cell_info = ril_cell_info_ref(modem->cell_info);
 		nm->netmon = netmon;
 
 		ofono_netmon_set_data(netmon, nm);
@@ -304,7 +182,7 @@ static void ril_netmon_remove(struct ofono_netmon *netmon)
 		g_source_remove(nm->register_id);
 	}
 
-	sailfish_cell_info_unref(nm->cell_info);
+	ril_cell_info_unref(nm->cell_info);
 	g_slice_free(struct ril_netmon, nm);
 }
 

ofono/drivers/ril/ril_netreg.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2018 Jolla Ltd.
+ *  Copyright (C) 2015-2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -61,8 +61,6 @@ struct ril_netreg_cbd {
 
 #define ril_netreg_cbd_free g_free
 
-#define DBG_(nd,fmt,args...) DBG("%s" fmt, (nd)->log_prefix, ##args)
-
 static inline struct ril_netreg *ril_netreg_get_data(struct ofono_netreg *ofono)
 {
 	return ofono ? ofono_netreg_get_data(ofono) : NULL;
@@ -111,7 +109,7 @@ static gboolean ril_netreg_status_notify_cb(gpointer user_data)
 	struct ril_netreg *nd = user_data;
 	const struct ril_registration_state *reg = &nd->network->voice;
 
-	DBG_(nd, "");
+	DBG("%s", nd->log_prefix);
 	GASSERT(nd->notify_id);
 	nd->notify_id = 0;
 	ofono_netreg_status_notify(nd->netreg,
@@ -126,9 +124,9 @@ static void ril_netreg_status_notify(struct ril_network *net, void *user_data)
 
 	/* Coalesce multiple notifications into one */
 	if (nd->notify_id) {
-		DBG_(nd, "notification aready queued");
+		DBG("%snotification aready queued", nd->log_prefix);
 	} else {
-		DBG_(nd, "queuing notification");
+		DBG("%squeuing notification", nd->log_prefix);
 		nd->notify_id = g_idle_add(ril_netreg_status_notify_cb, nd);
 	}
 }
@@ -140,7 +138,7 @@ static void ril_netreg_registration_status(struct ofono_netreg *netreg,
 	const struct ril_registration_state *reg = &nd->network->voice;
 	struct ofono_error error;
 
-	DBG_(nd, "");
+	DBG("%s", nd->log_prefix);
 	cb(ril_error_ok(&error),
 			ril_netreg_check_status(nd, reg->status),
 			reg->lac, reg->ci, reg->access_tech, data);
@@ -153,7 +151,7 @@ static gboolean ril_netreg_current_operator_cb(void *user_data)
 	ofono_netreg_operator_cb_t cb = cbd->cb.operator;
 	struct ofono_error error;
 
-	DBG_(nd, "");
+	DBG("%s", nd->log_prefix);
 	GASSERT(nd->current_operator_id);
 	nd->current_operator_id = 0;
 
@@ -324,7 +322,6 @@ static int ril_netreg_get_signal_strength(const void *data, guint len)
 {
 	GRilIoParser rilp;
 	int gw_signal = 0, cdma_dbm = 0, evdo_dbm = 0, lte_signal = 0;
-	int rsrp = 0;
 
 	grilio_parser_init(&rilp, data, len);
 
@@ -344,41 +341,23 @@ static int ril_netreg_get_signal_strength(const void *data, guint len)
 
 	/* LTE_SignalStrength */
 	grilio_parser_get_int32(&rilp, &lte_signal);
-	grilio_parser_get_int32(&rilp, &rsrp);
-	/* The rest is ignored */
+	grilio_parser_get_int32(&rilp, NULL); /* rsrp */
+	grilio_parser_get_int32(&rilp, NULL); /* rsrq */
+	grilio_parser_get_int32(&rilp, NULL); /* rssnr */
+	grilio_parser_get_int32(&rilp, NULL); /* cqi */
 
-	if (rsrp == INT_MAX) {
-		DBG("gw: %d, cdma: %d, evdo: %d, lte: %d", gw_signal,
-					cdma_dbm, evdo_dbm, lte_signal);
-	}  else {
-		DBG("gw: %d, cdma: %d, evdo: %d, lte: %d rsrp: %d", gw_signal,
-					cdma_dbm, evdo_dbm, lte_signal, rsrp);
-	}
+	DBG("gw: %d, cdma: %d, evdo: %d, lte: %d", gw_signal, cdma_dbm,
+							evdo_dbm, lte_signal);
 
 	/* Return the first valid one */
-
-	/* Some RILs (namely, from MediaTek) report 0 here AND a valid LTE
-	 * RSRP value. If we've got zero, don't report it just yet. */
-	if (gw_signal >= 1 && gw_signal <= 31) {
-		/* Valid values are (0-31, 99) as defined in TS 27.007 */
+	if (gw_signal != 99 && gw_signal != -1) {
 		return (gw_signal * 100) / 31;
 	}
 
-	/* Valid values are (0-31, 99) as defined in TS 27.007 */
-	if (lte_signal >= 0 && lte_signal <= 31) {
+	if (lte_signal != 99 && lte_signal != -1) {
 		return (lte_signal * 100) / 31;
 	}
 
-	/* RSRP range: 44 to 140 dBm as defined in 3GPP TS 36.133 */
-	if (lte_signal == 99 && rsrp >= 44 && rsrp <= 140) {
-		return 140 - rsrp;
-	}
-
-	/* If we've got zero strength and no valid RSRP, then so be it */
-	if (gw_signal == 0) {
-		return 0;
-	}
-
 	/* In case of dbm, return the value directly */
 	if (cdma_dbm != -1) {
 		return MIN(cdma_dbm, 100);
@@ -399,7 +378,7 @@ static void ril_netreg_strength_notify(GRilIoChannel *io, guint ril_event,
 
 	GASSERT(ril_event == RIL_UNSOL_SIGNAL_STRENGTH);
 	strength = ril_netreg_get_signal_strength(data, len);
-	DBG_(nd, "%d", strength);
+	DBG("%d", strength);
 	ofono_netreg_strength_notify(nd->netreg, strength);
 }
 
@@ -438,8 +417,9 @@ static void ril_netreg_nitz_notify(GRilIoChannel *io, guint ril_event,
 {
 	struct ril_netreg *nd = user_data;
 	GRilIoParser rilp;
-	int year, mon, mday, hour, min, sec, tzi, dst = 0;
-	char tzs;
+	struct ofono_network_time time;
+	int year, mon, mday, hour, min, sec, dst, tzi;
+	char tzs, tz[4];
 	gchar *nitz;
 
 	GASSERT(ril_event == RIL_UNSOL_NITZ_TIME_RECEIVED);
@@ -447,33 +427,21 @@ static void ril_netreg_nitz_notify(GRilIoChannel *io, guint ril_event,
 	grilio_parser_init(&rilp, data, len);
 	nitz = grilio_parser_get_utf8(&rilp);
 
-	DBG_(nd, "%s", nitz);
+	DBG("%s", nitz);
+	sscanf(nitz, "%u/%u/%u,%u:%u:%u%c%u,%u", &year, &mon, &mday,
+			&hour, &min, &sec, &tzs, &tzi, &dst);
+	snprintf(tz, sizeof(tz), "%c%d", tzs, tzi);
 
-	/*
-	 * Format: yy/mm/dd,hh:mm:ss(+/-)tz[,ds]
-	 * The ds part is considered optional, initialized to zero.
-	 */
-	if (nitz && sscanf(nitz, "%u/%u/%u,%u:%u:%u%c%u,%u",
-			&year, &mon, &mday, &hour, &min, &sec, &tzs, &tzi,
-			&dst) >= 8 && (tzs == '+' || tzs == '-')) {
-		struct ofono_network_time time;
-		char tz[4];
-
-		snprintf(tz, sizeof(tz), "%c%d", tzs, tzi);
-		time.utcoff = atoi(tz) * 15 * 60;
-		time.dst = dst;
-		time.sec = sec;
-		time.min = min;
-		time.hour = hour;
-		time.mday = mday;
-		time.mon = mon;
-		time.year = 2000 + year;
-
-		ofono_netreg_time_notify(nd->netreg, &time);
-	} else {
-		ofono_warn("Failed to parse NITZ string \"%s\"", nitz);
-	}
+	time.utcoff = atoi(tz) * 15 * 60;
+	time.dst = dst;
+	time.sec = sec;
+	time.min = min;
+	time.hour = hour;
+	time.mday = mday;
+	time.mon = mon;
+	time.year = 2000 + year;
 
+	ofono_netreg_time_notify(nd->netreg, &time);
 	g_free(nitz);
 }
 
@@ -514,11 +482,10 @@ static int ril_netreg_probe(struct ofono_netreg *netreg, unsigned int vendor,
 {
 	struct ril_modem *modem = data;
 	struct ril_netreg *nd = g_new0(struct ril_netreg, 1);
+	guint slot = ril_modem_slot(modem);
 
-	nd->log_prefix = (modem->log_prefix && modem->log_prefix[0]) ?
-		g_strconcat(modem->log_prefix, " ", NULL) : g_strdup("");
-
-	DBG_(nd, "%p", netreg);
+	DBG("[%u] %p", slot, netreg);
+	nd->log_prefix = g_strdup_printf("%s_%u ", RILMODEM_DRIVER, slot);
 	nd->io = grilio_channel_ref(ril_modem_io(modem));
 	nd->q = grilio_queue_new(nd->io);
 	nd->network = ril_network_ref(modem->network);
@@ -532,8 +499,9 @@ static int ril_netreg_probe(struct ofono_netreg *netreg, unsigned int vendor,
 static void ril_netreg_remove(struct ofono_netreg *netreg)
 {
 	struct ril_netreg *nd = ril_netreg_get_data(netreg);
+	int i;
 
-	DBG_(nd, "%p", netreg);
+	DBG("%p", netreg);
 	grilio_queue_cancel_all(nd->q, FALSE);
 	ofono_netreg_set_data(netreg, NULL);
 
@@ -549,10 +517,14 @@ static void ril_netreg_remove(struct ofono_netreg *netreg)
 		g_source_remove(nd->current_operator_id);
 	}
 
-	ril_network_remove_all_handlers(nd->network, nd->network_event_id);
+	for (i=0; i<G_N_ELEMENTS(nd->network_event_id); i++) {
+		ril_network_remove_handler(nd->network, nd->network_event_id[i]);
+	}
 	ril_network_unref(nd->network);
 
-	grilio_channel_remove_all_handlers(nd->io, nd->ril_event_id);
+	grilio_channel_remove_handlers(nd->io, nd->ril_event_id,
+						G_N_ELEMENTS(nd->ril_event_id));
+
 	grilio_channel_unref(nd->io);
 	grilio_queue_unref(nd->q);
 	g_free(nd->log_prefix);

ofono/drivers/ril/ril_network.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2018 Jolla Ltd.
+ *  Copyright (C) 2015-2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -47,26 +47,13 @@ enum ril_network_radio_event {
 	RADIO_EVENT_COUNT
 };
 
-enum ril_network_sim_events {
-	SIM_EVENT_STATUS_CHANGED,
-	SIM_EVENT_IO_ACTIVE_CHANGED,
-	SIM_EVENT_COUNT
-};
-
-enum ril_network_unsol_event {
-	UNSOL_EVENT_NETWORK_STATE,
-	UNSOL_EVENT_RADIO_CAPABILITY,
-	UNSOL_EVENT_COUNT
-};
-
 struct ril_network_priv {
 	GRilIoChannel *io;
 	GRilIoQueue *q;
 	struct ril_radio *radio;
-	struct ril_sim_card *simcard;
+	struct ril_sim_card *sim_card;
+	enum ofono_radio_access_mode max_pref_mode;
 	int rat;
-	int lte_network_mode;
-	int network_mode_timeout;
 	char *log_prefix;
 	guint operator_poll_id;
 	guint voice_poll_id;
@@ -74,12 +61,11 @@ struct ril_network_priv {
 	guint timer[TIMER_COUNT];
 	gulong query_rat_id;
 	gulong set_rat_id;
-	gulong unsol_event_id[UNSOL_EVENT_COUNT];
+	gulong ril_event_id;
 	gulong settings_event_id;
+	gulong sim_status_event_id;
 	gulong radio_event_id[RADIO_EVENT_COUNT];
-	gulong simcard_event_id[SIM_EVENT_COUNT];
 	struct ofono_network_operator operator;
-	gboolean assert_rat;
 };
 
 enum ril_network_signal {
@@ -87,15 +73,13 @@ enum ril_network_signal {
 	SIGNAL_VOICE_STATE_CHANGED,
 	SIGNAL_DATA_STATE_CHANGED,
 	SIGNAL_PREF_MODE_CHANGED,
-	SIGNAL_MAX_PREF_MODE_CHANGED,
 	SIGNAL_COUNT
 };
 
-#define SIGNAL_OPERATOR_CHANGED_NAME      "ril-network-operator-changed"
-#define SIGNAL_VOICE_STATE_CHANGED_NAME   "ril-network-voice-state-changed"
-#define SIGNAL_DATA_STATE_CHANGED_NAME    "ril-network-data-state-changed"
-#define SIGNAL_PREF_MODE_CHANGED_NAME     "ril-network-pref-mode-changed"
-#define SIGNAL_MAX_PREF_MODE_CHANGED_NAME "ril-network-max-pref-mode-changed"
+#define SIGNAL_OPERATOR_CHANGED_NAME    "ril-network-operator-changed"
+#define SIGNAL_VOICE_STATE_CHANGED_NAME "ril-network-voice-state-changed"
+#define SIGNAL_DATA_STATE_CHANGED_NAME  "ril-network-data-state-changed"
+#define SIGNAL_PREF_MODE_CHANGED_NAME   "ril-network-pref-mode-changed"
 
 static guint ril_network_signals[SIGNAL_COUNT] = { 0 };
 
@@ -119,8 +103,7 @@ G_STATIC_ASSERT(OFONO_RADIO_ACCESS_MODE_UMTS > OFONO_RADIO_ACCESS_MODE_GSM);
 G_STATIC_ASSERT(OFONO_RADIO_ACCESS_MODE_LTE > OFONO_RADIO_ACCESS_MODE_UMTS);
 
 static void ril_network_query_pref_mode(struct ril_network *self);
-static void ril_network_check_pref_mode(struct ril_network *self,
-							gboolean immediate);
+static void ril_network_set_pref_mode(struct ril_network *self, int rat);
 
 static void ril_network_emit(struct ril_network *self,
 						enum ril_network_signal sig)
@@ -217,14 +200,8 @@ static gboolean ril_network_parse_response(struct ril_network *self,
 		reg->max_calls = 2;
 	}
 
-	if (!gutil_parse_int(slac, 16, &reg->lac)) {
-		reg->lac = -1;
-	}
-
-	if (!gutil_parse_int(sci, 16, &reg->ci)) {
-		reg->ci = -1;
-	}
-
+	reg->lac = slac ? strtol(slac, NULL, 16) : -1;
+	reg->ci = sci ? strtol(sci, NULL, 16) : -1;
 	reg->access_tech = ril_parse_tech(stech, &reg->ril_tech);
 
 	DBG_(self, "%s,%s,%s,%d,%s,%s,%s",
@@ -409,25 +386,12 @@ static void ril_network_poll_state(struct ril_network *self)
 	priv->operator_poll_id = ril_network_poll_and_retry(self,
 		priv->operator_poll_id, RIL_REQUEST_OPERATOR,
 		ril_network_poll_operator_cb);
-
-	ril_network_query_registration_state(self);
-}
-
-void ril_network_query_registration_state(struct ril_network *self)
-{
-	if (self) {
-		struct ril_network_priv *priv = self->priv;
-
-		DBG_(self, "");
-		priv->voice_poll_id = ril_network_poll_and_retry(self,
-			priv->voice_poll_id,
-			RIL_REQUEST_VOICE_REGISTRATION_STATE,
-			ril_network_poll_voice_state_cb);
-		priv->data_poll_id = ril_network_poll_and_retry(self,
-			priv->data_poll_id,
-			RIL_REQUEST_DATA_REGISTRATION_STATE,
-			ril_network_poll_data_state_cb);
-	}
+	priv->voice_poll_id = ril_network_poll_and_retry(self,
+		priv->voice_poll_id, RIL_REQUEST_VOICE_REGISTRATION_STATE,
+		ril_network_poll_voice_state_cb);
+	priv->data_poll_id = ril_network_poll_and_retry(self,
+		priv->data_poll_id, RIL_REQUEST_DATA_REGISTRATION_STATE,
+		ril_network_poll_data_state_cb);
 }
 
 static enum ofono_radio_access_mode ril_network_rat_to_mode(int rat)
@@ -456,16 +420,13 @@ static int ril_network_mode_to_rat(struct ril_network *self,
 	switch (mode) {
 	case OFONO_RADIO_ACCESS_MODE_ANY:
 	case OFONO_RADIO_ACCESS_MODE_LTE:
-		if (self->settings->techs & OFONO_RADIO_ACCESS_MODE_LTE) {
-			return self->priv->lte_network_mode;
+		if (self->settings->enable_4g) {
+			return PREF_NET_TYPE_LTE_GSM_WCDMA;
 		}
 		/* no break */
 	default:
 	case OFONO_RADIO_ACCESS_MODE_UMTS:
-		if (self->settings->techs & OFONO_RADIO_ACCESS_MODE_UMTS) {
-			return PREF_NET_TYPE_GSM_WCDMA_AUTO;
-		}
-		/* no break */
+		return PREF_NET_TYPE_GSM_WCDMA_AUTO;
 	case OFONO_RADIO_ACCESS_MODE_GSM:
 		return PREF_NET_TYPE_GSM_ONLY;
 	}
@@ -486,7 +447,7 @@ static int ril_network_pref_mode_expected(struct ril_network *self)
 	 * it becomes necessary.
 	 */
 	const enum ofono_radio_access_mode max_pref_mode =
-		(priv->radio->state == RADIO_STATE_ON) ? self->max_pref_mode :
+		(priv->radio->state == RADIO_STATE_ON) ? priv->max_pref_mode :
 		OFONO_RADIO_ACCESS_MODE_GSM;
 
 	/*
@@ -506,28 +467,37 @@ static gboolean ril_network_can_set_pref_mode(struct ril_network *self)
 {
 	struct ril_network_priv *priv = self->priv;
 
-	/*
-	 * With some modems an attempt to set rat significantly slows
-	 * down SIM I/O, let's avoid that.
-	 */
-	return priv->radio->online && ril_sim_card_ready(priv->simcard) &&
-				!priv->simcard->sim_io_active &&
-				!priv->timer[TIMER_SET_RAT_HOLDOFF] ;
+	return priv->radio->online && ril_sim_card_ready(priv->sim_card);
 }
 
 static gboolean ril_network_set_rat_holdoff_cb(gpointer user_data)
 {
 	struct ril_network *self = RIL_NETWORK(user_data);
 	struct ril_network_priv *priv = self->priv;
+	const int rat = ril_network_pref_mode_expected(self);
 
+	DBG_(self, "rat mode %d, expected %d", priv->rat, rat);
 	GASSERT(priv->timer[TIMER_SET_RAT_HOLDOFF]);
 	priv->timer[TIMER_SET_RAT_HOLDOFF] = 0;
 
-	ril_network_check_pref_mode(self, FALSE);
+	/*
+	 * Don't retry the request if modem is offline or SIM card isn't
+	 * ready, to avoid spamming system log with error messages. Radio
+	 * and SIM card state change callbacks will schedule a new check
+	 * when it's appropriate.
+	 */
+	if (priv->rat != rat) {
+		if (ril_network_can_set_pref_mode(self)) {
+			ril_network_set_pref_mode(self, rat);
+		} else {
+			DBG_(self, "giving up");
+		}
+	}
+
 	return G_SOURCE_REMOVE;
 }
 
-static void ril_network_set_rat_cb(GRilIoChannel *io, int status,
+static void ril_network_set_pref_mode_cb(GRilIoChannel *io, int status,
 				const void *data, guint len, void *user_data)
 {
 	struct ril_network *self = RIL_NETWORK(user_data);
@@ -542,53 +512,30 @@ static void ril_network_set_rat_cb(GRilIoChannel *io, int status,
 	ril_network_query_pref_mode(self);
 }
 
-static void ril_network_set_rat(struct ril_network *self, int rat)
-{
-	struct ril_network_priv *priv = self->priv;
-
-	if (!priv->set_rat_id && priv->radio->online &&
-		ril_sim_card_ready(priv->simcard) &&
-		/*
-		 * With some modems an attempt to set rat significantly
-		 * slows down SIM I/O, let's avoid that.
-		 */
-		!priv->simcard->sim_io_active &&
-		!priv->timer[TIMER_SET_RAT_HOLDOFF]) {
-		GRilIoRequest *req = grilio_request_sized_new(8);
-
-		DBG_(self, "setting rat mode %d", rat);
-		grilio_request_append_int32(req, 1);   /* count */
-		grilio_request_append_int32(req, rat);
-
-		grilio_request_set_timeout(req, priv->network_mode_timeout);
-		priv->set_rat_id = grilio_queue_send_request_full(priv->q, req,
-					RIL_REQUEST_SET_PREFERRED_NETWORK_TYPE,
-					ril_network_set_rat_cb, NULL, self);
-		grilio_request_unref(req);
-
-		/* We have submitted the request, clear the assertion flag */
-		priv->assert_rat = FALSE;
-
-		/* And don't do it too often */
-		priv->timer[TIMER_SET_RAT_HOLDOFF] =
-			g_timeout_add_seconds(SET_PREF_MODE_HOLDOFF_SEC,
-				ril_network_set_rat_holdoff_cb, self);
-	} else {
-		DBG_(self, "need to set rat mode %d", rat);
-	}
-}
-
 static void ril_network_set_pref_mode(struct ril_network *self, int rat)
 {
 	struct ril_network_priv *priv = self->priv;
+	GRilIoRequest *req = grilio_request_sized_new(8);
 
-	if (priv->rat != rat || priv->assert_rat) {
-		ril_network_set_rat(self, rat);
-	}
+	DBG_(self, "setting rat mode %d", rat);
+	grilio_request_append_int32(req, 1);    /* Number of params */
+	grilio_request_append_int32(req, rat);
+
+	grilio_queue_cancel_request(priv->q, priv->set_rat_id, FALSE);
+	priv->set_rat_id = grilio_queue_send_request_full(priv->q, req,
+				RIL_REQUEST_SET_PREFERRED_NETWORK_TYPE,
+				ril_network_set_pref_mode_cb, NULL, self);
+	grilio_request_unref(req);
+
+	/* Don't do it too often */
+	GASSERT(!priv->timer[TIMER_SET_RAT_HOLDOFF]);
+	priv->timer[TIMER_SET_RAT_HOLDOFF] =
+		g_timeout_add_seconds(SET_PREF_MODE_HOLDOFF_SEC,
+			ril_network_set_rat_holdoff_cb, self);
 }
 
 static void ril_network_check_pref_mode(struct ril_network *self,
-							gboolean immediate)
+							gboolean force)
 {
 	struct ril_network_priv *priv = self->priv;
 	const int rat = ril_network_pref_mode_expected(self);
@@ -600,18 +547,15 @@ static void ril_network_check_pref_mode(struct ril_network *self,
 		 * ril_network_pref_mode_changed_cb and is meant
 		 * to force radio tech check right now.
 		 */
-		immediate = TRUE;
+		force = TRUE;
 	}
 
-	if (priv->rat != rat) {
-		DBG_(self, "rat mode %d, expected %d", priv->rat, rat);
-	}
-
-	if (immediate) {
+	if (priv->rat == rat || force) {
 		ril_network_stop_timer(self, TIMER_SET_RAT_HOLDOFF);
 	}
 
-	if (priv->rat != rat || priv->assert_rat) {
+	if (priv->rat != rat) {
+		/* Something isn't right, we need to fix it */
 		if (!priv->timer[TIMER_SET_RAT_HOLDOFF]) {
 			ril_network_set_pref_mode(self, rat);
 		} else {
@@ -700,25 +644,17 @@ void ril_network_set_max_pref_mode(struct ril_network *self,
 				enum ofono_radio_access_mode max_mode,
 				gboolean force_check)
 {
-	if (self && (self->max_pref_mode != max_mode || force_check)) {
-		if (self->max_pref_mode != max_mode) {
+	if (G_LIKELY(self)) {
+		struct ril_network_priv *priv = self->priv;
+		if (priv->max_pref_mode != max_mode || force_check) {
 			DBG_(self, "rat mode %d (%s)", max_mode,
 				ofono_radio_access_mode_to_string(max_mode));
-			self->max_pref_mode = max_mode;
-			ril_network_emit(self, SIGNAL_MAX_PREF_MODE_CHANGED);
+			priv->max_pref_mode = max_mode;
+			ril_network_check_pref_mode(self, TRUE);
 		}
-		ril_network_check_pref_mode(self, TRUE);
 	}
 }
 
-void ril_network_assert_pref_mode(struct ril_network *self, gboolean immediate)
-{
-	struct ril_network_priv *priv = self->priv;
-
-	priv->assert_rat = TRUE;
-	ril_network_check_pref_mode(self, immediate);
-}
-
 gulong ril_network_add_operator_changed_handler(struct ril_network *self,
 					ril_network_cb_t cb, void *arg)
 {
@@ -747,13 +683,6 @@ gulong ril_network_add_pref_mode_changed_handler(struct ril_network *self,
 		SIGNAL_PREF_MODE_CHANGED_NAME, G_CALLBACK(cb), arg) : 0;
 }
 
-gulong ril_network_add_max_pref_mode_changed_handler(struct ril_network *self,
-					ril_network_cb_t cb, void *arg)
-{
-	return (G_LIKELY(self) && G_LIKELY(cb)) ? g_signal_connect(self,
-		SIGNAL_MAX_PREF_MODE_CHANGED_NAME, G_CALLBACK(cb), arg) : 0;
-}
-
 void ril_network_remove_handler(struct ril_network *self, gulong id)
 {
 	if (G_LIKELY(self) && G_LIKELY(id)) {
@@ -766,7 +695,7 @@ void ril_network_remove_handlers(struct ril_network *self, gulong *ids, int n)
 	gutil_disconnect_handlers(self, ids, n);
 }
 
-static void ril_network_state_changed_cb(GRilIoChannel *io, guint code,
+static void ril_network_voice_state_changed_cb(GRilIoChannel *io, guint code,
 				const void *data, guint len, void *user_data)
 {
 	struct ril_network *self = RIL_NETWORK(user_data);
@@ -776,16 +705,6 @@ static void ril_network_state_changed_cb(GRilIoChannel *io, guint code,
 	ril_network_poll_state(self);
 }
 
-static void ril_network_radio_capability_changed_cb(GRilIoChannel *io,
-		guint code, const void *data, guint len, void *user_data)
-{
-	struct ril_network *self = RIL_NETWORK(user_data);
-
-	DBG_(self, "");
-	GASSERT(code == RIL_UNSOL_RADIO_CAPABILITY);
-	ril_network_assert_pref_mode(self, FALSE);
-}
-
 static void ril_network_radio_state_cb(struct ril_radio *radio, void *data)
 {
 	struct ril_network *self = RIL_NETWORK(data);
@@ -848,11 +767,9 @@ static void ril_network_sim_status_changed_cb(struct ril_sim_card *sc,
 	}
 }
 
-struct ril_network *ril_network_new(const char *path, GRilIoChannel *io,
-			const char *log_prefix, struct ril_radio *radio,
-			struct ril_sim_card *simcard,
-			struct ril_sim_settings *settings,
-			const struct ril_slot_config *config)
+struct ril_network *ril_network_new(GRilIoChannel *io, const char *log_prefix,
+			struct ril_radio *radio, struct ril_sim_card *sim_card,
+			struct ril_sim_settings *settings)
 {
 	struct ril_network *self = g_object_new(RIL_NETWORK_TYPE, NULL);
 	struct ril_network_priv *priv = self->priv;
@@ -861,39 +778,25 @@ struct ril_network *ril_network_new(const char *path, GRilIoChannel *io,
 	priv->io = grilio_channel_ref(io);
 	priv->q = grilio_queue_new(priv->io);
 	priv->radio = ril_radio_ref(radio);
-	priv->simcard = ril_sim_card_ref(simcard);
+	priv->sim_card = ril_sim_card_ref(sim_card);
 	priv->log_prefix = (log_prefix && log_prefix[0]) ?
 		g_strconcat(log_prefix, " ", NULL) : g_strdup("");
 	DBG_(self, "");
-
-	/* Copy relevant config values */
-	priv->lte_network_mode = config->lte_network_mode;
-	priv->network_mode_timeout = config->network_mode_timeout;
-
-	/* Register listeners */
-	priv->unsol_event_id[UNSOL_EVENT_NETWORK_STATE] =
-		grilio_channel_add_unsol_event_handler(priv->io,
-			ril_network_state_changed_cb,
+	priv->ril_event_id = grilio_channel_add_unsol_event_handler(priv->io,
+			ril_network_voice_state_changed_cb,
 			RIL_UNSOL_RESPONSE_VOICE_NETWORK_STATE_CHANGED, self);
-	priv->unsol_event_id[UNSOL_EVENT_RADIO_CAPABILITY] =
-		grilio_channel_add_unsol_event_handler(priv->io,
-			ril_network_radio_capability_changed_cb,
-			RIL_UNSOL_RADIO_CAPABILITY, self);
 	priv->radio_event_id[RADIO_EVENT_STATE_CHANGED] =
 		ril_radio_add_state_changed_handler(priv->radio,
 			ril_network_radio_state_cb, self);
 	priv->radio_event_id[RADIO_EVENT_ONLINE_CHANGED] =
 		ril_radio_add_online_changed_handler(priv->radio,
 			ril_network_radio_online_cb, self);
-	priv->simcard_event_id[SIM_EVENT_STATUS_CHANGED] =
-		ril_sim_card_add_status_changed_handler(priv->simcard,
-			ril_network_sim_status_changed_cb, self);
-	priv->simcard_event_id[SIM_EVENT_IO_ACTIVE_CHANGED] =
-		ril_sim_card_add_sim_io_active_changed_handler(priv->simcard,
-			ril_network_sim_status_changed_cb, self);
 	priv->settings_event_id =
 		ril_sim_settings_add_pref_mode_changed_handler(settings,
 			ril_network_pref_mode_changed_cb, self);
+	priv->sim_status_event_id =
+		ril_sim_card_add_status_changed_handler(priv->sim_card,
+			ril_network_sim_status_changed_cb, self);
 
 	/*
 	 * Query the initial state. Querying network state before the radio
@@ -937,42 +840,57 @@ static void ril_network_init(struct ril_network *self)
 	priv->rat = -1;
 }
 
-static void ril_network_finalize(GObject *object)
+static void ril_network_dispose(GObject *object)
 {
 	struct ril_network *self = RIL_NETWORK(object);
 	struct ril_network_priv *priv = self->priv;
 	enum ril_network_timer tid;
 
-	DBG_(self, "");
+	grilio_channel_remove_handlers(priv->io, &priv->ril_event_id, 1);
+	ril_radio_remove_handlers(priv->radio, priv->radio_event_id,
+					G_N_ELEMENTS(priv->radio_event_id));
+	ril_sim_settings_remove_handlers(self->settings,
+						&priv->settings_event_id, 1);
+	ril_sim_card_remove_handlers(priv->sim_card,
+						&priv->sim_status_event_id, 1);
 
 	for (tid=0; tid<TIMER_COUNT; tid++) {
 		ril_network_stop_timer(self, tid);
 	}
 
 	grilio_queue_cancel_all(priv->q, FALSE);
-	grilio_channel_remove_all_handlers(priv->io, priv->unsol_event_id);
+	priv->set_rat_id = 0;
+	priv->query_rat_id = 0;
+
+	G_OBJECT_CLASS(ril_network_parent_class)->dispose(object);
+}
+
+static void ril_network_finalize(GObject *object)
+{
+	struct ril_network *self = RIL_NETWORK(object);
+	struct ril_network_priv *priv = self->priv;
+
+	DBG_(self, "");
+	g_free(priv->log_prefix);
 	grilio_channel_unref(priv->io);
 	grilio_queue_unref(priv->q);
-	ril_radio_remove_all_handlers(priv->radio, priv->radio_event_id);
 	ril_radio_unref(priv->radio);
-	ril_sim_card_remove_all_handlers(priv->simcard, priv->simcard_event_id);
-	ril_sim_card_unref(priv->simcard);
-	ril_sim_settings_remove_handler(self->settings,
-						priv->settings_event_id);
+	ril_sim_card_unref(priv->sim_card);
 	ril_sim_settings_unref(self->settings);
-	g_free(priv->log_prefix);
 	G_OBJECT_CLASS(ril_network_parent_class)->finalize(object);
 }
 
 static void ril_network_class_init(RilNetworkClass *klass)
 {
-	G_OBJECT_CLASS(klass)->finalize = ril_network_finalize;
+	GObjectClass *object_class = G_OBJECT_CLASS(klass);
+
+	object_class->dispose = ril_network_dispose;
+	object_class->finalize = ril_network_finalize;
 	g_type_class_add_private(klass, sizeof(struct ril_network_priv));
 	RIL_NETWORK_SIGNAL(klass, OPERATOR);
 	RIL_NETWORK_SIGNAL(klass, VOICE_STATE);
 	RIL_NETWORK_SIGNAL(klass, DATA_STATE);
 	RIL_NETWORK_SIGNAL(klass, PREF_MODE);
-	RIL_NETWORK_SIGNAL(klass, MAX_PREF_MODE);
 }
 
 /*

ofono/drivers/ril/ril_network.h

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2018 Jolla Ltd.
+ *  Copyright (C) 2015-2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -18,7 +18,7 @@
 
 #include "ril_types.h"
 
-#include <glib-object.h>
+#include <ofono/radio-settings.h>
 
 struct ofono_network_operator;
 
@@ -38,26 +38,21 @@ struct ril_network {
 	struct ril_registration_state data;
 	const struct ofono_network_operator *operator;
 	enum ofono_radio_access_mode pref_mode;
-	enum ofono_radio_access_mode max_pref_mode;
 	struct ril_sim_settings *settings;
 };
 
 struct ofono_sim;
 typedef void (*ril_network_cb_t)(struct ril_network *net, void *arg);
 
-struct ril_network *ril_network_new(const char *path, GRilIoChannel *io,
-			const char *log_prefix, struct ril_radio *radio,
-			struct ril_sim_card *sim_card,
-			struct ril_sim_settings *settings,
-			const struct ril_slot_config *ril_slot_config);
+struct ril_network *ril_network_new(GRilIoChannel *io, const char *log_prefix,
+			struct ril_radio *radio, struct ril_sim_card *sim_card,
+			struct ril_sim_settings *settings);
 struct ril_network *ril_network_ref(struct ril_network *net);
 void ril_network_unref(struct ril_network *net);
 
 void ril_network_set_max_pref_mode(struct ril_network *net,
 				enum ofono_radio_access_mode max_pref_mode,
 				gboolean force_check);
-void ril_network_assert_pref_mode(struct ril_network *net, gboolean immediate);
-void ril_network_query_registration_state(struct ril_network *net);
 gulong ril_network_add_operator_changed_handler(struct ril_network *net,
 					ril_network_cb_t cb, void *arg);
 gulong ril_network_add_voice_state_changed_handler(struct ril_network *net,
@@ -66,14 +61,9 @@ gulong ril_network_add_data_state_changed_handler(struct ril_network *net,
 					ril_network_cb_t cb, void *arg);
 gulong ril_network_add_pref_mode_changed_handler(struct ril_network *net,
 					ril_network_cb_t cb, void *arg);
-gulong ril_network_add_max_pref_mode_changed_handler(struct ril_network *net,
-					ril_network_cb_t cb, void *arg);
 void ril_network_remove_handler(struct ril_network *net, gulong id);
 void ril_network_remove_handlers(struct ril_network *net, gulong *ids, int n);
 
-#define ril_network_remove_all_handlers(net, ids) \
-	ril_network_remove_handlers(net, ids, G_N_ELEMENTS(ids))
-
 #endif /* RIL_NETWORK_H */
 
 /*

ofono/drivers/ril/ril_oem_raw.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2017 Jolla Ltd.
+ *  Copyright (C) 2015-2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -24,6 +24,7 @@
 #define RIL_OEM_RAW_TIMEOUT   (60*1000) /* 60 sec */
 
 struct ril_oem_raw {
+	struct ril_modem *modem;
 	GRilIoQueue *q;
 	DBusConnection *conn;
 	char *path;
@@ -117,6 +118,7 @@ struct ril_oem_raw *ril_oem_raw_new(struct ril_modem *modem,
 	struct ril_oem_raw *oem = g_new0(struct ril_oem_raw, 1);
 
 	DBG("%s", ril_modem_get_path(modem));
+	oem->modem = modem;
 	oem->path = g_strdup(ril_modem_get_path(modem));
 	oem->conn = dbus_connection_ref(ofono_dbus_get_connection());
 	oem->q = grilio_queue_new(ril_modem_io(modem));
@@ -142,6 +144,8 @@ void ril_oem_raw_free(struct ril_oem_raw *oem)
 		DBG("%s", oem->path);
 		g_dbus_unregister_interface(oem->conn, oem->path,
 						RIL_OEM_RAW_INTERFACE);
+		ofono_modem_remove_interface(oem->modem->ofono,
+						RIL_OEM_RAW_INTERFACE);
 		dbus_connection_unref(oem->conn);
 
 		grilio_queue_cancel_all(oem->q, TRUE);

ofono/drivers/ril/ril_plugin.h

@@ -17,7 +17,6 @@
 #define RIL_PLUGIN_H
 
 #include "ril_types.h"
-#include "sailfish_manager.h"
 
 #include <ofono/modem.h>
 #include <ofono/call-barring.h>
@@ -44,6 +43,30 @@
 
 #define RILMODEM_DRIVER         "ril"
 
+typedef struct ril_slot_info const *ril_slot_info_ptr;
+
+struct ril_slot_info {
+	const char *path;
+	const char *imei;
+	const char *imeisv;
+	const char *ecclist_file;
+	gboolean enabled;
+	gboolean sim_present;
+	const struct ril_slot_config *config;
+	GHashTable *errors;
+};
+
+struct ril_plugin {
+	const char *mms_imsi;
+	const char *mms_path;
+	const char *default_voice_imsi;
+	const char *default_data_imsi;
+	const char *default_voice_path;
+	const char *default_data_path;
+	const ril_slot_info_ptr *slots;
+	gboolean ready;
+};
+
 struct ril_modem {
 	GRilIoChannel *io;
 	const char *imei;
@@ -51,31 +74,74 @@ struct ril_modem {
 	const char *log_prefix;
 	const char *ecclist_file;
 	struct ofono_modem *ofono;
-	struct sailfish_cell_info *cell_info;
 	struct ril_radio *radio;
 	struct ril_data *data;
 	struct ril_network *network;
 	struct ril_sim_card *sim_card;
 	struct ril_sim_settings *sim_settings;
+	struct ril_cell_info *cell_info;
 	struct ril_slot_config config;
 };
 
+#define RIL_PLUGIN_SIGNAL_VOICE_IMSI    (0x01)
+#define RIL_PLUGIN_SIGNAL_DATA_IMSI     (0x02)
+#define RIL_PLUGIN_SIGNAL_VOICE_PATH    (0x04)
+#define RIL_PLUGIN_SIGNAL_DATA_PATH     (0x08)
+#define RIL_PLUGIN_SIGNAL_ENABLED_SLOTS (0x10)
+#define RIL_PLUGIN_SIGNAL_MMS_IMSI      (0x20)
+#define RIL_PLUGIN_SIGNAL_MMS_PATH      (0x40)
+#define RIL_PLUGIN_SIGNAL_READY         (0x80)
+
+typedef void (*ril_modem_cb_t)(struct ril_modem *modem, void *data);
+typedef void (*ril_modem_online_cb_t)(struct ril_modem *modem, gboolean online,
+								void *data);
+
+void ril_plugin_set_enabled_slots(struct ril_plugin *plugin, char **slots);
+gboolean ril_plugin_set_mms_imsi(struct ril_plugin *plugin, const char *imsi);
+void ril_plugin_set_default_voice_imsi(struct ril_plugin *plugin,
+							const char *imsi);
+void ril_plugin_set_default_data_imsi(struct ril_plugin *plugin,
+							const char *imsi);
+
 struct ril_oem_raw;
-struct ril_oem_raw *ril_oem_raw_new(struct ril_modem *modem,
+struct ril_oem_raw *ril_oem_raw_new(struct ril_modem *md,
 						const char *log_prefix);
 void ril_oem_raw_free(struct ril_oem_raw *raw);
 
+struct ril_sim_info_dbus;
+struct ril_sim_info_dbus *ril_sim_info_dbus_new(struct ril_modem *md,
+						struct ril_sim_info *info);
+void ril_sim_info_dbus_free(struct ril_sim_info_dbus *dbus);
+
+struct ril_cell_info_dbus;
+struct ril_cell_info_dbus *ril_cell_info_dbus_new(struct ril_modem *md,
+						struct ril_cell_info *info);
+void ril_cell_info_dbus_free(struct ril_cell_info_dbus *dbus);
+
+struct ril_plugin_dbus;
+struct ril_plugin_dbus *ril_plugin_dbus_new(struct ril_plugin *plugin);
+void ril_plugin_dbus_free(struct ril_plugin_dbus *dbus);
+void ril_plugin_dbus_block_imei_requests(struct ril_plugin_dbus *dbus,
+							gboolean clock);
+void ril_plugin_dbus_signal(struct ril_plugin_dbus *dbus, int mask);
+void ril_plugin_dbus_signal_sim(struct ril_plugin_dbus *dbus, int index,
+							gboolean present);
+void ril_plugin_dbus_signal_modem_error(struct ril_plugin_dbus *dbus,
+			int index, const char *id, const char *message);
+
 struct ril_modem *ril_modem_create(GRilIoChannel *io, const char *log_prefix,
-		const char *path, const char *imei, const char *imeisv,
-		const char *ecclist_file, const struct ril_slot_config *config,
-		struct ril_radio *radio, struct ril_network *network,
-		struct ril_sim_card *card, struct ril_data *data,
-		struct ril_sim_settings *settings,
-		struct sailfish_cell_info *cell_info);
+		const struct ril_slot_info *slot, struct ril_radio *radio,
+		struct ril_network *network, struct ril_sim_card *card,
+		struct ril_data *data, struct ril_sim_settings *settings,
+		struct ril_cell_info *cell_info);
 void ril_modem_delete(struct ril_modem *modem);
 struct ofono_sim *ril_modem_ofono_sim(struct ril_modem *modem);
 struct ofono_gprs *ril_modem_ofono_gprs(struct ril_modem *modem);
 struct ofono_netreg *ril_modem_ofono_netreg(struct ril_modem *modem);
+void ril_modem_set_removed_cb(struct ril_modem *modem, ril_modem_cb_t cb,
+								void *data);
+void ril_modem_set_online_cb(struct ril_modem *modem, ril_modem_online_cb_t cb,
+								void *data);
 
 #define ril_modem_get_path(modem) ofono_modem_get_path((modem)->ofono)
 #define ril_modem_4g_enabled(modem) ((modem)->config.enable_4g)
@@ -83,7 +149,7 @@ struct ofono_netreg *ril_modem_ofono_netreg(struct ril_modem *modem);
 #define ril_modem_io(modem) ((modem)->io)
 
 int ril_sim_app_type(struct ofono_sim *sim);
-int ril_netreg_check_if_really_roaming(struct ofono_netreg *reg, gint status);
+int ril_netreg_check_if_really_roaming(struct ofono_netreg *netreg, gint status);
 
 extern const struct ofono_call_barring_driver ril_call_barring_driver;
 extern const struct ofono_call_forwarding_driver ril_call_forwarding_driver;

ofono/drivers/ril/ril_plugin_dbus.c

@@ -0,0 +1,956 @@
+/*
+ *  oFono - Open Source Telephony - RIL-based devices
+ *
+ *  Copyright (C) 2015-2017 Jolla Ltd.
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License version 2 as
+ *  published by the Free Software Foundation.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ */
+
+#include "ril_plugin.h"
+
+#include <ofono/log.h>
+#include <ofono/dbus.h>
+
+#include <gutil_strv.h>
+#include <gutil_log.h>
+#include <gdbus.h>
+
+#include "ofono.h"
+
+typedef void (*ril_plugin_dbus_append_fn)(DBusMessageIter *it,
+					struct ril_plugin_dbus *dbus);
+typedef gboolean (*ril_plugin_dbus_slot_select_fn)
+					(const struct ril_slot_info *slot);
+typedef const char *(*ril_plugin_dbus_slot_string_fn)
+					(const struct ril_slot_info *slot);
+
+struct ril_plugin_dbus_request {
+	DBusMessage *msg;
+	ril_plugin_dbus_append_fn fn;
+};
+
+struct ril_plugin_dbus {
+	struct ril_plugin *plugin;
+	DBusConnection *conn;
+	gboolean block_imei_req;
+	GSList *blocked_imei_req;
+	guint mms_watch;
+};
+
+#define RIL_DBUS_PATH               "/"
+#define RIL_DBUS_INTERFACE          "org.nemomobile.ofono.ModemManager"
+#define RIL_DBUS_INTERFACE_VERSION  (6)
+
+#define RIL_DBUS_SIGNAL_ENABLED_MODEMS_CHANGED      "EnabledModemsChanged"
+#define RIL_DBUS_SIGNAL_PRESENT_SIMS_CHANGED        "PresentSimsChanged"
+#define RIL_DBUS_SIGNAL_DEFAULT_VOICE_SIM_CHANGED   "DefaultVoiceSimChanged"
+#define RIL_DBUS_SIGNAL_DEFAULT_DATA_SIM_CHANGED    "DefaultDataSimChanged"
+#define RIL_DBUS_SIGNAL_DEFAULT_VOICE_MODEM_CHANGED "DefaultVoiceModemChanged"
+#define RIL_DBUS_SIGNAL_DEFAULT_DATA_MODEM_CHANGED  "DefaultDataModemChanged"
+#define RIL_DBUS_SIGNAL_MMS_SIM_CHANGED             "MmsSimChanged"
+#define RIL_DBUS_SIGNAL_MMS_MODEM_CHANGED           "MmsModemChanged"
+#define RIL_DBUS_SIGNAL_READY_CHANGED               "ReadyChanged"
+#define RIL_DBUS_SIGNAL_MODEM_ERROR                 "ModemError"
+#define RIL_DBUS_IMSI_AUTO                          "auto"
+
+#define RIL_DBUS_ERROR_SIGNATURE                    "si"
+
+static gboolean ril_plugin_dbus_enabled(const struct ril_slot_info *slot)
+{
+	return slot->enabled;
+}
+
+static gboolean ril_plugin_dbus_present(const struct ril_slot_info *slot)
+{
+	return slot->sim_present;
+}
+
+static const char *ril_plugin_dbus_imei(const struct ril_slot_info *slot)
+{
+	return slot->imei;
+}
+
+static void ril_plugin_dbus_append_path_array(DBusMessageIter *it,
+	struct ril_plugin_dbus *dbus, ril_plugin_dbus_slot_select_fn selector)
+{
+	DBusMessageIter array;
+	const struct ril_slot_info *const *ptr = dbus->plugin->slots;
+
+	dbus_message_iter_open_container(it, DBUS_TYPE_ARRAY,
+				DBUS_TYPE_OBJECT_PATH_AS_STRING, &array);
+
+	while (*ptr) {
+		const struct ril_slot_info *slot = *ptr++;
+		if (!selector || selector(slot)) {
+			const char *path = slot->path;
+			dbus_message_iter_append_basic(&array,
+						DBUS_TYPE_OBJECT_PATH, &path);
+		}
+	}
+
+	dbus_message_iter_close_container(it, &array);
+}
+
+static void ril_plugin_dbus_append_string_array(DBusMessageIter *it,
+	struct ril_plugin_dbus *dbus, ril_plugin_dbus_slot_string_fn fn)
+{
+	DBusMessageIter array;
+	const struct ril_slot_info *const *ptr = dbus->plugin->slots;
+
+	dbus_message_iter_open_container(it, DBUS_TYPE_ARRAY,
+				DBUS_TYPE_STRING_AS_STRING, &array);
+
+	while (*ptr) {
+		const struct ril_slot_info *slot = *ptr++;
+		const char *str = fn(slot);
+
+		if (!str) str = "";
+		dbus_message_iter_append_basic(&array, DBUS_TYPE_STRING, &str);
+	}
+
+	dbus_message_iter_close_container(it, &array);
+}
+
+static void ril_plugin_dbus_append_boolean_array(DBusMessageIter *it,
+	struct ril_plugin_dbus *dbus, ril_plugin_dbus_slot_select_fn value)
+{
+	DBusMessageIter array;
+	const struct ril_slot_info *const *ptr = dbus->plugin->slots;
+
+	dbus_message_iter_open_container(it, DBUS_TYPE_ARRAY,
+				DBUS_TYPE_BOOLEAN_AS_STRING, &array);
+
+	while (*ptr) {
+		const struct ril_slot_info *slot = *ptr++;
+		dbus_bool_t b = value(slot);
+
+		dbus_message_iter_append_basic(&array, DBUS_TYPE_BOOLEAN, &b);
+	}
+
+	dbus_message_iter_close_container(it, &array);
+}
+
+static void ril_plugin_dbus_append_boolean(DBusMessageIter *it, dbus_bool_t b)
+{
+	dbus_message_iter_append_basic(it, DBUS_TYPE_BOOLEAN, &b);
+}
+
+static void ril_plugin_dbus_append_string(DBusMessageIter *it, const char *str)
+{
+	if (!str) str = "";
+	dbus_message_iter_append_basic(it, DBUS_TYPE_STRING, &str);
+}
+
+static void ril_plugin_dbus_append_imsi(DBusMessageIter *it, const char *imsi)
+{
+	if (!imsi) imsi = RIL_DBUS_IMSI_AUTO;
+	dbus_message_iter_append_basic(it, DBUS_TYPE_STRING, &imsi);
+}
+
+static void ril_plugin_dbus_append_path(DBusMessageIter *it, const char *path)
+{
+	if (!path) path = "";
+	/* It's DBUS_TYPE_STRING because DBUS_TYPE_OBJECT_PATH can't be empty */
+	dbus_message_iter_append_basic(it, DBUS_TYPE_STRING, &path);
+}
+
+static void ril_plugin_dbus_message_append_path_array(DBusMessage *msg,
+	struct ril_plugin_dbus *dbus, ril_plugin_dbus_slot_select_fn fn)
+{
+	DBusMessageIter iter;
+
+	dbus_message_iter_init_append(msg, &iter);
+	ril_plugin_dbus_append_path_array(&iter, dbus, fn);
+}
+
+static void ril_plugin_dbus_append_modem_error(DBusMessageIter *it,
+					const char *id, dbus_uint32_t count)
+{
+	DBusMessageIter sub;
+	dbus_message_iter_open_container(it, DBUS_TYPE_STRUCT, NULL, &sub);
+	dbus_message_iter_append_basic(&sub, DBUS_TYPE_STRING, &id);
+	dbus_message_iter_append_basic(&sub, DBUS_TYPE_INT32, &count);
+	dbus_message_iter_close_container(it, &sub);
+}
+
+static void ril_plugin_dbus_append_modem_errors(DBusMessageIter *it,
+						struct ril_plugin_dbus *dbus)
+{
+	DBusMessageIter slots;
+	const struct ril_slot_info *const *ptr = dbus->plugin->slots;
+
+	dbus_message_iter_open_container(it, DBUS_TYPE_ARRAY,
+				"a(" RIL_DBUS_ERROR_SIGNATURE ")", &slots);
+
+	while (*ptr) {
+		const struct ril_slot_info *slot = *ptr++;
+		DBusMessageIter errors;
+
+		dbus_message_iter_open_container(&slots, DBUS_TYPE_ARRAY,
+				"(" RIL_DBUS_ERROR_SIGNATURE ")", &errors);
+
+		if (g_hash_table_size(slot->errors)) {
+			gpointer key, value;
+			GHashTableIter iter;
+			g_hash_table_iter_init(&iter, slot->errors);
+			while (g_hash_table_iter_next(&iter, &key, &value)) {
+				ril_plugin_dbus_append_modem_error(&errors,
+						key, GPOINTER_TO_INT(value));
+			}
+		}
+
+		dbus_message_iter_close_container(&slots, &errors);
+	}
+
+	dbus_message_iter_close_container(it, &slots);
+}
+
+static void ril_plugin_dbus_signal_path_array(struct ril_plugin_dbus *dbus,
+			const char *name, ril_plugin_dbus_slot_select_fn fn)
+{
+	DBusMessage *signal = dbus_message_new_signal(RIL_DBUS_PATH,
+						RIL_DBUS_INTERFACE, name);
+
+	ril_plugin_dbus_message_append_path_array(signal, dbus, fn);
+	g_dbus_send_message(dbus->conn, signal);
+}
+
+static inline void ril_plugin_dbus_signal_imsi(struct ril_plugin_dbus *dbus,
+				const char *name, const char *imsi)
+{
+	if (!imsi) imsi = RIL_DBUS_IMSI_AUTO;
+	g_dbus_emit_signal(dbus->conn, RIL_DBUS_PATH, RIL_DBUS_INTERFACE,
+			name, DBUS_TYPE_STRING, &imsi, DBUS_TYPE_INVALID);
+}
+
+static inline void ril_plugin_dbus_signal_string(struct ril_plugin_dbus *dbus,
+				const char *name, const char *str)
+{
+	if (!str) str = "";
+	g_dbus_emit_signal(dbus->conn, RIL_DBUS_PATH, RIL_DBUS_INTERFACE,
+			name, DBUS_TYPE_STRING, &str, DBUS_TYPE_INVALID);
+}
+
+static inline void ril_plugin_dbus_signal_boolean(struct ril_plugin_dbus *dbus,
+				const char *name, dbus_bool_t value)
+{
+	g_dbus_emit_signal(dbus->conn, RIL_DBUS_PATH, RIL_DBUS_INTERFACE,
+			name, DBUS_TYPE_BOOLEAN, &value, DBUS_TYPE_INVALID);
+}
+
+void ril_plugin_dbus_signal(struct ril_plugin_dbus *dbus, int mask)
+{
+	if (dbus) {
+		if (mask & RIL_PLUGIN_SIGNAL_VOICE_IMSI) {
+			ril_plugin_dbus_signal_imsi(dbus,
+				RIL_DBUS_SIGNAL_DEFAULT_VOICE_SIM_CHANGED,
+				dbus->plugin->default_voice_imsi);
+		}
+		if (mask & RIL_PLUGIN_SIGNAL_DATA_IMSI) {
+			ril_plugin_dbus_signal_imsi(dbus,
+				RIL_DBUS_SIGNAL_DEFAULT_DATA_SIM_CHANGED,
+				dbus->plugin->default_data_imsi);
+		}
+		if (mask & RIL_PLUGIN_SIGNAL_MMS_IMSI) {
+			ril_plugin_dbus_signal_string(dbus,
+				RIL_DBUS_SIGNAL_MMS_SIM_CHANGED,
+				dbus->plugin->mms_imsi);
+		}
+		if (mask & RIL_PLUGIN_SIGNAL_ENABLED_SLOTS) {
+			ril_plugin_dbus_signal_path_array(dbus,
+				RIL_DBUS_SIGNAL_ENABLED_MODEMS_CHANGED,
+				ril_plugin_dbus_enabled);
+		}
+		if (mask & RIL_PLUGIN_SIGNAL_VOICE_PATH) {
+			ril_plugin_dbus_signal_string(dbus,
+				RIL_DBUS_SIGNAL_DEFAULT_VOICE_MODEM_CHANGED,
+				dbus->plugin->default_voice_path);
+		}
+		if (mask & RIL_PLUGIN_SIGNAL_DATA_PATH) {
+			ril_plugin_dbus_signal_string(dbus,
+				RIL_DBUS_SIGNAL_DEFAULT_DATA_MODEM_CHANGED,
+				dbus->plugin->default_data_path);
+		}
+		if (mask & RIL_PLUGIN_SIGNAL_MMS_PATH) {
+			ril_plugin_dbus_signal_string(dbus,
+				RIL_DBUS_SIGNAL_MMS_MODEM_CHANGED,
+				dbus->plugin->mms_path);
+		}
+		if (mask & RIL_PLUGIN_SIGNAL_READY) {
+			ril_plugin_dbus_signal_boolean(dbus,
+				RIL_DBUS_SIGNAL_READY_CHANGED,
+				dbus->plugin->ready);
+		}
+	}
+}
+
+void ril_plugin_dbus_signal_sim(struct ril_plugin_dbus *dbus, int index,
+							gboolean present)
+{
+	dbus_bool_t value = present;
+	g_dbus_emit_signal(dbus->conn, RIL_DBUS_PATH, RIL_DBUS_INTERFACE,
+			RIL_DBUS_SIGNAL_PRESENT_SIMS_CHANGED,
+			DBUS_TYPE_INT32, &index,
+			DBUS_TYPE_BOOLEAN, &value,
+			DBUS_TYPE_INVALID);
+}
+
+void ril_plugin_dbus_signal_modem_error(struct ril_plugin_dbus *dbus,
+			int index, const char *id, const char *message)
+{
+	const char *path = dbus->plugin->slots[index]->path;
+	if (!message) message = "";
+	g_dbus_emit_signal(dbus->conn, RIL_DBUS_PATH, RIL_DBUS_INTERFACE,
+			RIL_DBUS_SIGNAL_MODEM_ERROR,
+			DBUS_TYPE_OBJECT_PATH, &path,
+			DBUS_TYPE_STRING, &id,
+			DBUS_TYPE_STRING, &message,
+			DBUS_TYPE_INVALID);
+}
+
+static DBusMessage *ril_plugin_dbus_reply_with_path_array(DBusMessage *msg,
+	struct ril_plugin_dbus *dbus, ril_plugin_dbus_slot_select_fn fn)
+{
+	DBusMessage *reply = dbus_message_new_method_return(msg);
+
+	ril_plugin_dbus_message_append_path_array(reply, dbus, fn);
+	return reply;
+}
+
+static DBusMessage *ril_plugin_dbus_reply(DBusMessage *msg,
+		struct ril_plugin_dbus *dbus, ril_plugin_dbus_append_fn append)
+{
+	DBusMessage *reply = dbus_message_new_method_return(msg);
+	DBusMessageIter iter;
+
+	dbus_message_iter_init_append(reply, &iter);
+	append(&iter, dbus);
+	return reply;
+}
+
+static void ril_plugin_dbus_unblock_request(gpointer data, gpointer user_data)
+{
+	struct ril_plugin_dbus_request *req = data;
+
+	DBG("unblocking IMEI request %p", req);
+	__ofono_dbus_pending_reply(&req->msg, ril_plugin_dbus_reply(req->msg,
+				(struct ril_plugin_dbus *)user_data, req->fn));
+	g_free(req);
+}
+
+static void ril_plugin_dbus_cancel_request(gpointer data)
+{
+	struct ril_plugin_dbus_request *req = data;
+
+	DBG("canceling IMEI request %p", req);
+	__ofono_dbus_pending_reply(&req->msg, __ofono_error_canceled(req->msg));
+	g_free(req);
+}
+
+void ril_plugin_dbus_block_imei_requests(struct ril_plugin_dbus *dbus,
+								gboolean block)
+{
+	dbus->block_imei_req = block;
+	if (!block && dbus->blocked_imei_req) {
+		g_slist_foreach(dbus->blocked_imei_req,
+				ril_plugin_dbus_unblock_request, dbus);
+		g_slist_free(dbus->blocked_imei_req);
+		dbus->blocked_imei_req = NULL;
+	}
+}
+
+static DBusMessage *ril_plugin_dbus_imei_reply(DBusMessage *msg,
+		struct ril_plugin_dbus *dbus, ril_plugin_dbus_append_fn fn)
+{
+	if (dbus->block_imei_req) {
+		struct ril_plugin_dbus_request *req =
+			g_new(struct ril_plugin_dbus_request, 1);
+
+		req->msg = dbus_message_ref(msg);
+		req->fn = fn;
+		dbus->blocked_imei_req = g_slist_append(dbus->blocked_imei_req,
+									req);
+		DBG("blocking IMEI request %p", req);
+		return NULL;
+	} else {
+		return ril_plugin_dbus_reply(msg, dbus, fn);
+	}
+}
+
+static void ril_plugin_dbus_append_version(DBusMessageIter *it,
+						struct ril_plugin_dbus *dbus)
+{
+	dbus_int32_t version = RIL_DBUS_INTERFACE_VERSION;
+
+	dbus_message_iter_append_basic(it, DBUS_TYPE_INT32, &version);
+}
+
+static void ril_plugin_dbus_append_all(DBusMessageIter *it,
+						struct ril_plugin_dbus *dbus)
+{
+	ril_plugin_dbus_append_version(it, dbus);
+	ril_plugin_dbus_append_path_array(it, dbus, NULL);
+	ril_plugin_dbus_append_path_array(it, dbus, ril_plugin_dbus_enabled);
+	ril_plugin_dbus_append_imsi(it, dbus->plugin->default_data_imsi);
+	ril_plugin_dbus_append_imsi(it, dbus->plugin->default_voice_imsi);
+	ril_plugin_dbus_append_path(it, dbus->plugin->default_data_path);
+	ril_plugin_dbus_append_path(it, dbus->plugin->default_voice_path);
+}
+
+static void ril_plugin_dbus_append_all2(DBusMessageIter *it,
+						struct ril_plugin_dbus *dbus)
+{
+	ril_plugin_dbus_append_all(it, dbus);
+	ril_plugin_dbus_append_boolean_array(it, dbus, ril_plugin_dbus_present);
+}
+
+static void ril_plugin_dbus_append_all3(DBusMessageIter *it,
+						struct ril_plugin_dbus *dbus)
+{
+	ril_plugin_dbus_append_all2(it, dbus);
+	ril_plugin_dbus_append_string_array(it, dbus, ril_plugin_dbus_imei);
+}
+
+static void ril_plugin_dbus_append_all4(DBusMessageIter *it,
+						struct ril_plugin_dbus *dbus)
+{
+	ril_plugin_dbus_append_all3(it, dbus);
+	ril_plugin_dbus_append_string(it, dbus->plugin->mms_imsi);
+	ril_plugin_dbus_append_path(it, dbus->plugin->mms_path);
+}
+
+static void ril_plugin_dbus_append_all5(DBusMessageIter *it,
+						struct ril_plugin_dbus *dbus)
+{
+	ril_plugin_dbus_append_all4(it, dbus);
+	ril_plugin_dbus_append_boolean(it, dbus->plugin->ready);
+}
+
+static void ril_plugin_dbus_append_all6(DBusMessageIter *it,
+						struct ril_plugin_dbus *dbus)
+{
+	ril_plugin_dbus_append_all5(it, dbus);
+	ril_plugin_dbus_append_modem_errors(it, dbus);
+}
+
+static DBusMessage *ril_plugin_dbus_get_all(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	return ril_plugin_dbus_reply(msg, (struct ril_plugin_dbus *)data,
+						ril_plugin_dbus_append_all);
+}
+
+static DBusMessage *ril_plugin_dbus_get_all2(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	return ril_plugin_dbus_reply(msg, (struct ril_plugin_dbus *)data,
+						ril_plugin_dbus_append_all2);
+}
+
+static DBusMessage *ril_plugin_dbus_get_all3(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	return ril_plugin_dbus_imei_reply(msg, (struct ril_plugin_dbus *)data,
+						ril_plugin_dbus_append_all3);
+}
+
+static DBusMessage *ril_plugin_dbus_get_all4(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	return ril_plugin_dbus_imei_reply(msg, (struct ril_plugin_dbus *)data,
+						ril_plugin_dbus_append_all4);
+}
+
+static DBusMessage *ril_plugin_dbus_get_all5(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	return ril_plugin_dbus_imei_reply(msg, (struct ril_plugin_dbus *)data,
+						ril_plugin_dbus_append_all5);
+}
+
+static DBusMessage *ril_plugin_dbus_get_all6(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	return ril_plugin_dbus_imei_reply(msg, (struct ril_plugin_dbus *)data,
+						ril_plugin_dbus_append_all6);
+}
+
+static DBusMessage *ril_plugin_dbus_get_interface_version(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	return ril_plugin_dbus_reply(msg, (struct ril_plugin_dbus *)data,
+						ril_plugin_dbus_append_version);
+}
+
+static DBusMessage *ril_plugin_dbus_get_available_modems(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	return ril_plugin_dbus_reply_with_path_array(msg,
+					(struct ril_plugin_dbus *)data, NULL);
+}
+
+static DBusMessage *ril_plugin_dbus_get_enabled_modems(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	return ril_plugin_dbus_reply_with_path_array(msg,
+		(struct ril_plugin_dbus *)data, ril_plugin_dbus_enabled);
+}
+
+static void ril_plugin_dbus_append_present_sims(DBusMessageIter *it,
+						struct ril_plugin_dbus *dbus)
+{
+	ril_plugin_dbus_append_boolean_array(it, dbus, ril_plugin_dbus_present);
+}
+
+static DBusMessage *ril_plugin_dbus_get_present_sims(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	return ril_plugin_dbus_reply(msg, (struct ril_plugin_dbus *)data,
+				ril_plugin_dbus_append_present_sims);
+}
+
+static void ril_plugin_dbus_append_imei_array(DBusMessageIter *it,
+						struct ril_plugin_dbus *dbus)
+{
+	ril_plugin_dbus_append_string_array(it, dbus, ril_plugin_dbus_imei);
+}
+
+static DBusMessage *ril_plugin_dbus_get_imei(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	return ril_plugin_dbus_imei_reply(msg, (struct ril_plugin_dbus *)data,
+					ril_plugin_dbus_append_imei_array);
+}
+
+static DBusMessage *ril_plugin_dbus_reply_with_string(DBusMessage *msg,
+							const char *str)
+{
+	DBusMessage *reply = dbus_message_new_method_return(msg);
+	DBusMessageIter iter;
+
+	dbus_message_iter_init_append(reply, &iter);
+	ril_plugin_dbus_append_string(&iter, str);
+	return reply;
+}
+
+static DBusMessage *ril_plugin_dbus_reply_with_imsi(DBusMessage *msg,
+							const char *imsi)
+{
+	DBusMessage *reply = dbus_message_new_method_return(msg);
+	DBusMessageIter iter;
+
+	dbus_message_iter_init_append(reply, &iter);
+	ril_plugin_dbus_append_imsi(&iter, imsi);
+	return reply;
+}
+
+static DBusMessage *ril_plugin_dbus_get_default_data_sim(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	struct ril_plugin_dbus *dbus = data;
+
+	return ril_plugin_dbus_reply_with_imsi(msg,
+					dbus->plugin->default_data_imsi);
+}
+
+static DBusMessage *ril_plugin_dbus_get_default_voice_sim(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	struct ril_plugin_dbus *dbus = data;
+
+	return ril_plugin_dbus_reply_with_imsi(msg,
+					dbus->plugin->default_voice_imsi);
+}
+
+static DBusMessage *ril_plugin_dbus_get_mms_sim(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	struct ril_plugin_dbus *dbus = data;
+
+	return ril_plugin_dbus_reply_with_string(msg, dbus->plugin->mms_imsi);
+}
+
+static DBusMessage *ril_plugin_dbus_reply_with_path(DBusMessage *msg,
+							const char *path)
+{
+	DBusMessage *reply = dbus_message_new_method_return(msg);
+	DBusMessageIter iter;
+
+	dbus_message_iter_init_append(reply, &iter);
+	ril_plugin_dbus_append_path(&iter, path);
+	return reply;
+}
+
+static DBusMessage *ril_plugin_dbus_get_default_data_modem(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	struct ril_plugin_dbus *dbus = data;
+
+	return ril_plugin_dbus_reply_with_path(msg,
+					dbus->plugin->default_data_path);
+}
+
+static DBusMessage *ril_plugin_dbus_get_default_voice_modem(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	struct ril_plugin_dbus *dbus = data;
+
+	return ril_plugin_dbus_reply_with_path(msg,
+					dbus->plugin->default_voice_path);
+}
+
+static DBusMessage *ril_plugin_dbus_get_mms_modem(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	struct ril_plugin_dbus *dbus = data;
+
+	return ril_plugin_dbus_reply_with_path(msg, dbus->plugin->mms_path);
+}
+
+static DBusMessage *ril_plugin_dbus_get_ready(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	struct ril_plugin_dbus *dbus = data;
+	DBusMessage *reply = dbus_message_new_method_return(msg);
+	DBusMessageIter it;
+
+	dbus_message_iter_init_append(reply, &it);
+	ril_plugin_dbus_append_boolean(&it, dbus->plugin->ready);
+	return reply;
+}
+
+static DBusMessage *ril_plugin_dbus_get_modem_errors(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	return ril_plugin_dbus_reply(msg, (struct ril_plugin_dbus *)data,
+					ril_plugin_dbus_append_modem_errors);
+}
+
+static DBusMessage *ril_plugin_dbus_set_enabled_modems(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	struct ril_plugin_dbus *dbus = data;
+	DBusMessageIter iter;
+
+	dbus_message_iter_init(msg, &iter);
+	if (dbus_message_iter_get_arg_type(&iter) == DBUS_TYPE_ARRAY) {
+		char **paths = NULL;
+		DBusMessageIter array;
+
+		dbus_message_iter_recurse(&iter, &array);
+		while (dbus_message_iter_get_arg_type(&array) ==
+						DBUS_TYPE_OBJECT_PATH) {
+			DBusBasicValue value;
+
+			dbus_message_iter_get_basic(&array, &value);
+			paths = gutil_strv_add(paths, value.str);
+			dbus_message_iter_next(&array);
+		}
+
+		ril_plugin_set_enabled_slots(dbus->plugin, paths);
+		g_strfreev(paths);
+		return dbus_message_new_method_return(msg);
+	} else {
+		return __ofono_error_invalid_args(msg);
+	}
+}
+
+static DBusMessage *ril_plugin_dbus_set_imsi(struct ril_plugin_dbus *dbus,
+		DBusMessage *msg, void (*apply)(struct ril_plugin *plugin,
+							const char *imsi))
+{
+	DBusMessageIter iter;
+
+	dbus_message_iter_init(msg, &iter);
+	if (dbus_message_iter_get_arg_type(&iter) == DBUS_TYPE_STRING) {
+		DBusBasicValue value;
+		const char *imsi;
+
+		dbus_message_iter_get_basic(&iter, &value);
+		imsi = value.str;
+		if (!g_strcmp0(imsi, RIL_DBUS_IMSI_AUTO)) imsi = NULL; 
+		apply(dbus->plugin, imsi);
+		return dbus_message_new_method_return(msg);
+	} else {
+		return __ofono_error_invalid_args(msg);
+	}
+}
+
+static DBusMessage *ril_plugin_dbus_set_default_voice_sim(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	struct ril_plugin_dbus *dbus = data;
+
+	GASSERT(conn == dbus->conn);
+	return ril_plugin_dbus_set_imsi(dbus, msg,
+					ril_plugin_set_default_voice_imsi);
+}
+
+static DBusMessage *ril_plugin_dbus_set_default_data_sim(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	struct ril_plugin_dbus *dbus = data;
+
+	GASSERT(conn == dbus->conn);
+	return ril_plugin_dbus_set_imsi(dbus, msg,
+					ril_plugin_set_default_data_imsi);
+}
+
+static void ril_plugin_dbus_mms_disconnect(DBusConnection *conn, void *data)
+{
+	struct ril_plugin_dbus *dbus = data;
+
+	dbus->mms_watch = 0;
+	if (dbus->plugin->mms_imsi) {
+		DBG("MMS client is gone");
+		ril_plugin_set_mms_imsi(dbus->plugin, NULL);
+	}
+}
+
+static DBusMessage *ril_plugin_dbus_set_mms_sim(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	DBusMessageIter iter;
+	struct ril_plugin_dbus *dbus = data;
+
+	GASSERT(conn == dbus->conn);
+	dbus_message_iter_init(msg, &iter);
+	if (dbus_message_iter_get_arg_type(&iter) == DBUS_TYPE_STRING) {
+		DBusBasicValue value;
+		const char *imsi;
+
+		dbus_message_iter_get_basic(&iter, &value);
+		imsi = value.str;
+
+		/*
+		 * MMS IMSI is not persistent and has to be eventually
+		 * reset by the client or cleaned up if the client
+		 * unexpectedly disappears.
+		 */
+		if (ril_plugin_set_mms_imsi(dbus->plugin, imsi)) {
+
+			/*
+			 * Clear the previous MMS owner
+			 */
+			if (dbus->mms_watch) {
+				g_dbus_remove_watch(dbus->conn, dbus->mms_watch);
+				dbus->mms_watch = 0;
+			}
+
+			if (dbus->plugin->mms_imsi &&
+						dbus->plugin->mms_imsi[0]) {
+				/*
+				 * This client becomes the owner
+				 */
+				DBG("Owner: %s", dbus_message_get_sender(msg));
+				dbus->mms_watch =
+					g_dbus_add_disconnect_watch(dbus->conn,
+						dbus_message_get_sender(msg),
+						ril_plugin_dbus_mms_disconnect,
+						dbus, NULL);
+			}
+
+			return ril_plugin_dbus_reply_with_string(msg,
+						dbus->plugin->mms_path);
+		} else {
+			return __ofono_error_not_available(msg);
+		}
+	} else {
+		return __ofono_error_invalid_args(msg);
+	}
+}
+
+/*
+ * The client can call GetInterfaceVersion followed by the appropriate
+ * GetAllx call to get all settings in two steps. Alternatively, it can
+ * call GetAll followed by GetAllx based on the interface version returned
+ * by GetAll. In either case, two D-Bus calls are required, unless the
+ * client is willing to make the assumption about the ofono version it's
+ * talking to.
+ */
+
+#define RIL_DBUS_VERSION_ARG             {"version", "i"}
+#define RIL_DBUS_AVAILABLE_MODEMS_ARG    {"availableModems", "ao"}
+#define RIL_DBUS_ENABLED_MODEMS_ARG      {"enabledModems", "ao" }
+#define RIL_DBUS_DEFAULT_DATA_SIM_ARG    {"defaultDataSim", "s" }
+#define RIL_DBUS_DEFAULT_VOICE_SIM_ARG   {"defaultVoiceSim", "s" }
+#define RIL_DBUS_DEFAULT_DATA_MODEM_ARG  {"defaultDataModem", "s" }
+#define RIL_DBUS_DEFAULT_VOICE_MODEM_ARG {"defaultVoiceModem" , "s"}
+#define RIL_DBUS_PRESENT_SIMS_ARG        {"presentSims" , "ab"}
+#define RIL_DBUS_IMEI_ARG                {"imei" , "as"}
+#define RIL_DBUS_MMS_SIM_ARG             {"mmsSim", "s"}
+#define RIL_DBUS_MMS_MODEM_ARG           {"mmsModem" , "s"}
+#define RIL_DBUS_READY_ARG               {"ready" , "b"}
+#define RIL_DBUS_MODEM_ERRORS_ARG        {"errors" , \
+                                          "aa(" RIL_DBUS_ERROR_SIGNATURE ")"}
+#define RIL_DBUS_GET_ALL_ARGS \
+	RIL_DBUS_VERSION_ARG, \
+	RIL_DBUS_AVAILABLE_MODEMS_ARG, \
+	RIL_DBUS_ENABLED_MODEMS_ARG, \
+	RIL_DBUS_DEFAULT_DATA_SIM_ARG, \
+	RIL_DBUS_DEFAULT_VOICE_SIM_ARG, \
+	RIL_DBUS_DEFAULT_DATA_MODEM_ARG, \
+	RIL_DBUS_DEFAULT_VOICE_MODEM_ARG
+#define RIL_DBUS_GET_ALL2_ARGS \
+	RIL_DBUS_GET_ALL_ARGS, \
+	RIL_DBUS_PRESENT_SIMS_ARG
+#define RIL_DBUS_GET_ALL3_ARGS \
+	RIL_DBUS_GET_ALL2_ARGS, \
+	RIL_DBUS_IMEI_ARG
+#define RIL_DBUS_GET_ALL4_ARGS \
+	RIL_DBUS_GET_ALL3_ARGS, \
+	RIL_DBUS_MMS_SIM_ARG, \
+	RIL_DBUS_MMS_MODEM_ARG
+#define RIL_DBUS_GET_ALL5_ARGS \
+	RIL_DBUS_GET_ALL4_ARGS, \
+	RIL_DBUS_READY_ARG
+#define RIL_DBUS_GET_ALL6_ARGS \
+	RIL_DBUS_GET_ALL5_ARGS, \
+	RIL_DBUS_MODEM_ERRORS_ARG
+static const GDBusMethodTable ril_plugin_dbus_methods[] = {
+	{ GDBUS_METHOD("GetAll",
+			NULL, GDBUS_ARGS(RIL_DBUS_GET_ALL_ARGS),
+			ril_plugin_dbus_get_all) },
+	{ GDBUS_METHOD("GetAll2",
+			NULL, GDBUS_ARGS(RIL_DBUS_GET_ALL2_ARGS),
+			ril_plugin_dbus_get_all2) },
+	{ GDBUS_ASYNC_METHOD("GetAll3",
+			NULL, GDBUS_ARGS(RIL_DBUS_GET_ALL3_ARGS),
+			ril_plugin_dbus_get_all3) },
+	{ GDBUS_ASYNC_METHOD("GetAll4",
+			NULL, GDBUS_ARGS(RIL_DBUS_GET_ALL4_ARGS),
+			ril_plugin_dbus_get_all4) },
+	{ GDBUS_ASYNC_METHOD("GetAll5",
+			NULL, GDBUS_ARGS(RIL_DBUS_GET_ALL5_ARGS),
+			ril_plugin_dbus_get_all5) },
+	{ GDBUS_ASYNC_METHOD("GetAll6",
+			NULL, GDBUS_ARGS(RIL_DBUS_GET_ALL6_ARGS),
+			ril_plugin_dbus_get_all6) },
+	{ GDBUS_METHOD("GetInterfaceVersion",
+			NULL, GDBUS_ARGS(RIL_DBUS_VERSION_ARG),
+			ril_plugin_dbus_get_interface_version) },
+	{ GDBUS_METHOD("GetAvailableModems",
+			NULL, GDBUS_ARGS(RIL_DBUS_AVAILABLE_MODEMS_ARG),
+			ril_plugin_dbus_get_available_modems) },
+	{ GDBUS_METHOD("GetEnabledModems",
+			NULL, GDBUS_ARGS(RIL_DBUS_ENABLED_MODEMS_ARG),
+			ril_plugin_dbus_get_enabled_modems) },
+	{ GDBUS_METHOD("GetPresentSims",
+			NULL, GDBUS_ARGS(RIL_DBUS_PRESENT_SIMS_ARG),
+			ril_plugin_dbus_get_present_sims) },
+	{ GDBUS_ASYNC_METHOD("GetIMEI",
+			NULL, GDBUS_ARGS(RIL_DBUS_IMEI_ARG),
+			ril_plugin_dbus_get_imei) },
+	{ GDBUS_METHOD("GetDefaultDataSim",
+			NULL, GDBUS_ARGS(RIL_DBUS_DEFAULT_DATA_SIM_ARG),
+			ril_plugin_dbus_get_default_data_sim) },
+	{ GDBUS_METHOD("GetDefaultVoiceSim",
+			NULL, GDBUS_ARGS(RIL_DBUS_DEFAULT_VOICE_SIM_ARG),
+			ril_plugin_dbus_get_default_voice_sim) },
+	{ GDBUS_METHOD("GetMmsSim",
+			NULL, GDBUS_ARGS(RIL_DBUS_MMS_SIM_ARG),
+			ril_plugin_dbus_get_mms_sim) },
+	{ GDBUS_METHOD("GetDefaultDataModem",
+			NULL, GDBUS_ARGS(RIL_DBUS_DEFAULT_DATA_MODEM_ARG),
+			ril_plugin_dbus_get_default_data_modem) },
+	{ GDBUS_METHOD("GetDefaultVoiceModem",
+			NULL, GDBUS_ARGS(RIL_DBUS_DEFAULT_VOICE_MODEM_ARG),
+			ril_plugin_dbus_get_default_voice_modem) },
+	{ GDBUS_METHOD("GetMmsModem",
+			NULL, GDBUS_ARGS(RIL_DBUS_MMS_MODEM_ARG),
+			ril_plugin_dbus_get_mms_modem) },
+	{ GDBUS_METHOD("GetReady",
+			NULL, GDBUS_ARGS(RIL_DBUS_READY_ARG),
+			ril_plugin_dbus_get_ready) },
+	{ GDBUS_METHOD("GetModemErrors",
+			NULL, GDBUS_ARGS(RIL_DBUS_MODEM_ERRORS_ARG),
+			ril_plugin_dbus_get_modem_errors) },
+	{ GDBUS_METHOD("SetEnabledModems",
+			GDBUS_ARGS({ "modems", "ao" }), NULL,
+			ril_plugin_dbus_set_enabled_modems) },
+	{ GDBUS_METHOD("SetDefaultDataSim",
+			GDBUS_ARGS({ "imsi", "s" }), NULL,
+			ril_plugin_dbus_set_default_data_sim) },
+	{ GDBUS_METHOD("SetDefaultVoiceSim",
+			GDBUS_ARGS({ "imsi", "s" }), NULL,
+			ril_plugin_dbus_set_default_voice_sim) },
+	{ GDBUS_METHOD("SetMmsSim",
+			GDBUS_ARGS({ "imsi", "s" }), NULL,
+			ril_plugin_dbus_set_mms_sim) },
+	{ }
+};
+
+static const GDBusSignalTable ril_plugin_dbus_signals[] = {
+	{ GDBUS_SIGNAL(RIL_DBUS_SIGNAL_ENABLED_MODEMS_CHANGED,
+			GDBUS_ARGS(RIL_DBUS_ENABLED_MODEMS_ARG)) },
+	{ GDBUS_SIGNAL(RIL_DBUS_SIGNAL_PRESENT_SIMS_CHANGED,
+			GDBUS_ARGS({"index", "i" },
+			{"present" , "b"})) },
+	{ GDBUS_SIGNAL(RIL_DBUS_SIGNAL_DEFAULT_DATA_SIM_CHANGED,
+			GDBUS_ARGS(RIL_DBUS_DEFAULT_DATA_SIM_ARG)) },
+	{ GDBUS_SIGNAL(RIL_DBUS_SIGNAL_DEFAULT_VOICE_SIM_CHANGED,
+			GDBUS_ARGS(RIL_DBUS_DEFAULT_VOICE_SIM_ARG)) },
+	{ GDBUS_SIGNAL(RIL_DBUS_SIGNAL_DEFAULT_DATA_MODEM_CHANGED,
+			GDBUS_ARGS(RIL_DBUS_DEFAULT_DATA_MODEM_ARG)) },
+	{ GDBUS_SIGNAL(RIL_DBUS_SIGNAL_DEFAULT_VOICE_MODEM_CHANGED,
+			GDBUS_ARGS(RIL_DBUS_DEFAULT_VOICE_MODEM_ARG)) },
+	{ GDBUS_SIGNAL(RIL_DBUS_SIGNAL_MMS_SIM_CHANGED,
+			GDBUS_ARGS(RIL_DBUS_MMS_SIM_ARG)) },
+	{ GDBUS_SIGNAL(RIL_DBUS_SIGNAL_MMS_MODEM_CHANGED,
+			GDBUS_ARGS(RIL_DBUS_MMS_MODEM_ARG)) },
+	{ GDBUS_SIGNAL(RIL_DBUS_SIGNAL_READY_CHANGED,
+			GDBUS_ARGS(RIL_DBUS_READY_ARG)) },
+	{ GDBUS_SIGNAL(RIL_DBUS_SIGNAL_MODEM_ERROR,
+			GDBUS_ARGS({"path","o"},
+			{"error_id", "s"},
+			{"message", "s"})) },
+	{ }
+};
+
+struct ril_plugin_dbus *ril_plugin_dbus_new(struct ril_plugin *plugin)
+{
+	struct ril_plugin_dbus *dbus = g_new0(struct ril_plugin_dbus, 1);
+
+	dbus->conn = dbus_connection_ref(ofono_dbus_get_connection());
+	dbus->plugin = plugin;
+	if (g_dbus_register_interface(dbus->conn, RIL_DBUS_PATH,
+			RIL_DBUS_INTERFACE, ril_plugin_dbus_methods,
+			ril_plugin_dbus_signals, NULL, dbus, NULL)) {
+		return dbus;
+	} else {
+		ofono_error("RIL D-Bus register failed");
+		ril_plugin_dbus_free(dbus);
+		return NULL;
+	}
+}
+
+void ril_plugin_dbus_free(struct ril_plugin_dbus *dbus)
+{
+	if (dbus) {
+		if (dbus->mms_watch) {
+			g_dbus_remove_watch(dbus->conn, dbus->mms_watch);
+		}
+
+		g_slist_free_full(dbus->blocked_imei_req,
+					ril_plugin_dbus_cancel_request);
+		g_dbus_unregister_interface(dbus->conn, RIL_DBUS_PATH,
+							RIL_DBUS_INTERFACE);
+		dbus_connection_unref(dbus->conn);
+		g_free(dbus);
+	}
+}
+
+/*
+ * Local Variables:
+ * mode: C
+ * c-basic-offset: 8
+ * indent-tabs-mode: t
+ * End:
+ */

ofono/drivers/ril/ril_radio.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2017 Jolla Ltd.
+ *  Copyright (C) 2015-2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -71,16 +71,14 @@ G_DEFINE_TYPE(RilRadio, ril_radio, G_TYPE_OBJECT)
 #define RIL_RADIO_TYPE (ril_radio_get_type())
 #define RIL_RADIO(obj) (G_TYPE_CHECK_INSTANCE_CAST(obj,RIL_RADIO_TYPE,RilRadio))
 
-#define DBG_(self,fmt,args...) DBG("%s" fmt, (self)->priv->log_prefix, ##args)
-
 static void ril_radio_submit_power_request(struct ril_radio *self, gboolean on);
 
 static inline gboolean ril_radio_power_should_be_on(struct ril_radio *self)
 {
 	struct ril_radio_priv *priv = self->priv;
 
-	return (self->online || g_hash_table_size(priv->req_table) > 0) &&
-		!priv->power_cycle;
+	return self->online && !priv->power_cycle &&
+				g_hash_table_size(priv->req_table) > 0;
 }
 
 static inline gboolean ril_radio_state_off(enum ril_radio_state radio_state)
@@ -101,14 +99,13 @@ static inline void ril_radio_emit_signal(struct ril_radio *self,
 
 static gboolean ril_radio_power_request_retry_cb(gpointer user_data)
 {
-	struct ril_radio *self = RIL_RADIO(user_data);
+	struct ril_radio *self = user_data;
 	struct ril_radio_priv *priv = self->priv;
 
-	DBG_(self, "");
+	DBG("%s", priv->log_prefix);
 	GASSERT(priv->retry_id);
 	priv->retry_id = 0;
-	ril_radio_submit_power_request(self,
-				ril_radio_power_should_be_on(self));
+	ril_radio_submit_power_request(self, ril_radio_power_should_be_on(self));
 
 	return G_SOURCE_REMOVE;
 }
@@ -118,7 +115,7 @@ static void ril_radio_cancel_retry(struct ril_radio *self)
 	struct ril_radio_priv *priv = self->priv;
 
 	if (priv->retry_id) {
-		DBG_(self, "retry cancelled");
+		DBG("%sretry cancelled", priv->log_prefix);
 		g_source_remove(priv->retry_id);
 		priv->retry_id = 0;
 	}
@@ -129,10 +126,10 @@ static void ril_radio_check_state(struct ril_radio *self)
 	struct ril_radio_priv *priv = self->priv;
 
 	if (!priv->pending_id) {
-		gboolean should_be_on = ril_radio_power_should_be_on(self);
+		const gboolean should_be_on = ril_radio_power_should_be_on(self);
 
-		if (ril_radio_state_on(priv->last_known_state) ==
-							should_be_on) {
+		if (ril_radio_state_on(self->priv->last_known_state) ==
+								should_be_on) {
 			/* All is good, cancel pending retry if there is one */
 			ril_radio_cancel_retry(self);
 		} else if (priv->state_changed_while_request_pending) {
@@ -140,7 +137,7 @@ static void ril_radio_check_state(struct ril_radio *self)
 			ril_radio_submit_power_request(self, should_be_on);
 		} else if (!priv->retry_id) {
 			/* There has been no reaction so far, wait a bit */
-			DBG_(self, "retry scheduled");
+			DBG("%sretry scheduled", priv->log_prefix);
 			priv->retry_id = g_timeout_add_seconds(POWER_RETRY_SECS,
 					ril_radio_power_request_retry_cb, self);
 		}
@@ -149,20 +146,28 @@ static void ril_radio_check_state(struct ril_radio *self)
 	/* Don't update public state while something is pending */
 	if (!priv->pending_id && !priv->retry_id &&
 				self->state != priv->last_known_state) {
-		DBG_(self, "%s -> %s", ril_radio_state_to_string(self->state),
+		DBG("%s%s -> %s", priv->log_prefix,
+			ril_radio_state_to_string(self->state),
 			ril_radio_state_to_string(priv->last_known_state));
 		self->state = priv->last_known_state;
 		ril_radio_emit_signal(self, SIGNAL_STATE_CHANGED);
 	}
 }
 
-static void ril_radio_power_request_done(struct ril_radio *self)
+static void ril_radio_power_request_cb(GRilIoChannel *channel, int ril_status,
+				const void *data, guint len, void *user_data)
 {
+	struct ril_radio *self = user_data;
 	struct ril_radio_priv *priv = self->priv;
 
 	GASSERT(priv->pending_id);
 	priv->pending_id = 0;
 
+	if (ril_status != RIL_E_SUCCESS) {
+		ofono_error("Power request failed: %s",
+					ril_error_to_string(ril_status));
+	}
+
 	if (priv->next_state_valid) {
 		ril_radio_submit_power_request(self, priv->next_state);
 	} else {
@@ -170,32 +175,13 @@ static void ril_radio_power_request_done(struct ril_radio *self)
 	}
 }
 
-static void ril_radio_power_request_cb(GRilIoChannel *channel, int ril_status,
-				const void *data, guint len, void *user_data)
-{
-	struct ril_radio *self = RIL_RADIO(user_data);
-
-	if (ril_status != RIL_E_SUCCESS) {
-		ofono_error("Power request failed: %s",
-					ril_error_to_string(ril_status));
-	}
-
-	ril_radio_power_request_done(self);
-}
-
 static void ril_radio_submit_power_request(struct ril_radio *self, gboolean on)
 {
-	/*
-	 * RIL_REQUEST_RADIO_POWER
-	 *
-	 * "data" is int *
-	 * ((int *)data)[0] is > 0 for "Radio On"
-	 * ((int *)data)[0] is == 0 for "Radio Off"
-	 *
-	 * "response" is NULL
-	 **/
-	GRilIoRequest *req = grilio_request_array_int32_new(1, on);
 	struct ril_radio_priv *priv = self->priv;
+	GRilIoRequest *req = grilio_request_sized_new(8);
+
+	grilio_request_append_int32(req, 1);
+	grilio_request_append_int32(req, on); /* Radio ON=1, OFF=0 */
 
 	priv->next_state_valid = FALSE;
 	priv->next_state = on;
@@ -203,10 +189,8 @@ static void ril_radio_submit_power_request(struct ril_radio *self, gboolean on)
 	ril_radio_cancel_retry(self);
 
 	GASSERT(!priv->pending_id);
-	grilio_request_set_blocking(req, TRUE);
 	priv->pending_id = grilio_queue_send_request_full(priv->q, req,
-			RIL_REQUEST_RADIO_POWER, ril_radio_power_request_cb,
-			NULL, self);
+		RIL_REQUEST_RADIO_POWER, ril_radio_power_request_cb, NULL, self);
 	grilio_request_unref(req);
 }
 
@@ -221,18 +205,13 @@ static void ril_radio_power_request(struct ril_radio *self, gboolean on,
 			/* Wait for the pending request to complete */
 			priv->next_state_valid = TRUE;
 			priv->next_state = on;
-			DBG_(self, "%s (queued)", on_off);
+			DBG("%s%s (queued)", priv->log_prefix, on_off);
 		} else {
-			DBG_(self, "%s (ignored)", on_off);
+			DBG("%s%s (ignored)", priv->log_prefix, on_off);
 		}
 	} else {
-		if (ril_radio_state_on(priv->last_known_state) == on) {
-			DBG_(self, "%s (already)", on_off);
-			ril_radio_check_state(self);
-		} else {
-			DBG_(self, "%s", on_off);
-			ril_radio_submit_power_request(self, on);
-		}
+		DBG("%s%s", priv->log_prefix, on_off);
+		ril_radio_submit_power_request(self, on);
 	}
 }
 
@@ -249,12 +228,12 @@ void ril_radio_power_cycle(struct ril_radio *self)
 		struct ril_radio_priv *priv = self->priv;
 
 		if (ril_radio_state_off(priv->last_known_state)) {
-			DBG_(self, "power is already off");
+			DBG("%spower is already off", priv->log_prefix);
 			GASSERT(!priv->power_cycle);
 		} else if (priv->power_cycle) {
-			DBG_(self, "already in progress");
+			DBG("%salready in progress", priv->log_prefix);
 		} else {
-			DBG_(self, "initiated");
+			DBG("%sinitiated", priv->log_prefix);
 			priv->power_cycle = TRUE;
 			if (!priv->pending_id) {
 				ril_radio_submit_power_request(self, FALSE);
@@ -271,7 +250,7 @@ void ril_radio_power_on(struct ril_radio *self, gpointer tag)
 		if (!g_hash_table_contains(priv->req_table, tag)) {
 			gboolean was_on = ril_radio_power_should_be_on(self);
 
-			DBG_(self, "%p", tag);
+			DBG("%s%p", priv->log_prefix, tag);
 			g_hash_table_insert(priv->req_table, tag, tag);
 			if (!was_on && ril_radio_power_should_be_on(self)) {
 				ril_radio_power_request(self, TRUE, FALSE);
@@ -286,7 +265,7 @@ void ril_radio_power_off(struct ril_radio *self, gpointer tag)
 		struct ril_radio_priv *priv = self->priv;
 
 		if (g_hash_table_remove(priv->req_table, tag)) {
-			DBG_(self, "%p", tag);
+			DBG("%s%p", priv->log_prefix, tag);
 			if (!ril_radio_power_should_be_on(self)) {
 				/* The last one turns the lights off */
 				ril_radio_power_request(self, FALSE, FALSE);
@@ -351,48 +330,27 @@ enum ril_radio_state ril_radio_state_parse(const void *data, guint len)
 static void ril_radio_state_changed(GRilIoChannel *io, guint code,
 				const void *data, guint len, void *user_data)
 {
-	struct ril_radio *self = RIL_RADIO(user_data);
+	struct ril_radio *self = user_data;
 	enum ril_radio_state radio_state = ril_radio_state_parse(data, len);
 
 	GASSERT(code == RIL_UNSOL_RESPONSE_RADIO_STATE_CHANGED);
 	if (radio_state != RADIO_STATE_UNAVAILABLE) {
 		struct ril_radio_priv *priv = self->priv;
 
-		DBG_(self, "%s", ril_radio_state_to_string(radio_state));
+		DBG("%s%s", priv->log_prefix,
+			ril_radio_state_to_string(radio_state));
 		GASSERT(!priv->pending_id || !priv->retry_id);
 
 		if (priv->power_cycle && ril_radio_state_off(radio_state)) {
-			DBG_(self, "switched off for power cycle");
+			DBG("%sswitched off for power cycle", priv->log_prefix);
 			priv->power_cycle = FALSE;
 		}
 
-		priv->last_known_state = radio_state;
-
 		if (priv->pending_id) {
-			if (ril_radio_state_on(radio_state) ==
-					ril_radio_power_should_be_on(self)) {
-				DBG_(self, "dropping pending request");
-				/*
-				 * All right, the modem has switched to the
-				 * desired state, drop the request.
-				 */
-				grilio_queue_cancel_request(priv->q,
-						priv->pending_id, FALSE);
-
-				/*
-				 * This will zero pending_id and call
-				 * ril_radio_check_state() if necesary:
-				 */
-				ril_radio_power_request_done(self);
-
-				/* We are done */
-				return;
-			} else {
-				/* Something weird is going on */
-				priv->state_changed_while_request_pending++;
-			}
+			priv->state_changed_while_request_pending++;
 		}
 
+		priv->last_known_state = radio_state;
 		ril_radio_check_state(self);
 	}
 }
@@ -407,7 +365,7 @@ struct ril_radio *ril_radio_new(GRilIoChannel *io)
 	priv->log_prefix =
 		(io && io->name && io->name[0] && strcmp(io->name, "RIL")) ?
 		g_strconcat(io->name, " ", NULL) : g_strdup("");
-	DBG_(self, "");
+	DBG("%s", priv->log_prefix);
 	priv->state_event_id = grilio_channel_add_unsol_event_handler(priv->io,
 				ril_radio_state_changed,
 				RIL_UNSOL_RESPONSE_RADIO_STATE_CHANGED, self);
@@ -464,7 +422,7 @@ static void ril_radio_finalize(GObject *object)
 	struct ril_radio *self = RIL_RADIO(object);
 	struct ril_radio_priv *priv = self->priv;
 
-	DBG_(self, "");
+	DBG("%s", priv->log_prefix);
 	g_free(priv->log_prefix);
 	grilio_channel_unref(priv->io);
 	grilio_queue_unref(priv->q);

ofono/drivers/ril/ril_radio.h

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2018 Jolla Ltd.
+ *  Copyright (C) 2015-2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -18,8 +18,6 @@
 
 #include "ril_types.h"
 
-#include <glib-object.h>
-
 struct ril_radio {
 	GObject object;
 	struct ril_radio_priv *priv;
@@ -46,9 +44,6 @@ void ril_radio_remove_handler(struct ril_radio *radio, gulong id);
 void ril_radio_remove_handlers(struct ril_radio *radio, gulong *ids, int n);
 enum ril_radio_state ril_radio_state_parse(const void *data, guint len);
 
-#define ril_radio_remove_all_handlers(r,ids) \
-	ril_radio_remove_handlers(r, ids, G_N_ELEMENTS(ids))
-
 #endif /* RIL_RADIO_H */
 
 /*

ofono/drivers/ril/ril_radio_caps.h

@@ -1,66 +0,0 @@
-/*
- *  oFono - Open Source Telephony - RIL-based devices
- *
- *  Copyright (C) 2017 Jolla Ltd.
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- *  GNU General Public License for more details.
- */
-
-#ifndef RIL_RADIO_CAPS_H
-#define RIL_RADIO_CAPS_H
-
-#include "ril_types.h"
-
-struct ril_data_manager;
-struct ril_radio_caps;
-struct ril_radio_caps_manager;
-struct ril_radio_capability;
-
-typedef void (*ril_radio_caps_manager_cb_t)(struct ril_radio_caps_manager *mgr,
-							void *user_data);
-/* ril_radio_capability pointer is NULL if functionality is unsupported */
-typedef void (*ril_radio_caps_check_cb_t)
-		(const struct ril_radio_capability *cap, void *user_data);
-
-/* The check can be cancelled with grilio_channel_cancel_request */
-guint ril_radio_caps_check(GRilIoChannel *io, ril_radio_caps_check_cb_t cb,
-							void *user_data);
-
-/* There should be a single ril_radio_caps_manager shared by all all modems */
-struct ril_radio_caps_manager *ril_radio_caps_manager_new
-					(struct ril_data_manager *dm);
-struct ril_radio_caps_manager *ril_radio_caps_manager_ref
-					(struct ril_radio_caps_manager *mgr);
-void ril_radio_caps_manager_unref(struct ril_radio_caps_manager *mgr);
-gulong ril_radio_caps_manager_add_aborted_handler
-				(struct ril_radio_caps_manager *mgr,
-				ril_radio_caps_manager_cb_t cb, void *arg);
-void ril_radio_caps_manager_remove_handler(struct ril_radio_caps_manager *mgr,
-								gulong id);
-
-/* And one ril_radio_caps object per modem */
-struct ril_radio_caps *ril_radio_caps_new(struct ril_radio_caps_manager *mgr,
-		const char *log_prefix, GRilIoChannel *io,
-		struct ril_data *data, struct ril_radio *radio,
-		struct ril_sim_card *sim, struct ril_network *net,
-		const struct ril_slot_config *config,
-		const struct ril_radio_capability *cap);
-struct ril_radio_caps *ril_radio_caps_ref(struct ril_radio_caps *caps);
-void ril_radio_caps_unref(struct ril_radio_caps *caps);
-
-#endif /* RIL_RADIO_CAPS_H */
-
-/*
- * Local Variables:
- * mode: C
- * c-basic-offset: 8
- * indent-tabs-mode: t
- * End:
- */

ofono/drivers/ril/ril_radio_settings.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2017 Jolla Ltd.
+ *  Copyright (C) 2015-2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -17,6 +17,7 @@
 #include "ril_sim_settings.h"
 #include "ril_util.h"
 #include "ril_log.h"
+#include "ril_constants.h"
 
 struct ril_radio_settings {
 	struct ofono_radio_settings *rs;
@@ -112,11 +113,15 @@ static gboolean ril_radio_settings_query_available_rats_cb(gpointer data)
 	struct ofono_error error;
 	struct ril_radio_settings_cbd *cbd = data;
 	struct ril_radio_settings *rsd = cbd->rsd;
+	guint rats = OFONO_RADIO_ACCESS_MODE_GSM | OFONO_RADIO_ACCESS_MODE_UMTS;
 
-	GASSERT(rsd->source_id);
+	if (cbd->rsd->settings->enable_4g) {
+		rats |= OFONO_RADIO_ACCESS_MODE_LTE;
+	}
+
+	GASSERT(cbd->rsd->source_id);
 	rsd->source_id = 0;
-	cbd->cb.available_rats(ril_error_ok(&error), rsd->settings->techs,
-								cbd->data);
+	cbd->cb.available_rats(ril_error_ok(&error), rats, cbd->data);
 	return G_SOURCE_REMOVE;
 }
 
@@ -127,8 +132,8 @@ static void ril_radio_settings_query_available_rats(
 	struct ril_radio_settings *rsd = ril_radio_settings_get_data(rs);
 
 	DBG_(rsd, "");
-	ril_radio_settings_later(rsd,
-			ril_radio_settings_query_available_rats_cb, cb, data);
+	ril_radio_settings_later(rsd, ril_radio_settings_query_available_rats_cb,
+								cb, data);
 }
 
 static gboolean ril_radio_settings_register(gpointer user_data)

ofono/drivers/ril/ril_sim.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2018 Jolla Ltd.
+ *  Copyright (C) 2015-2017 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -18,15 +18,11 @@
 #include "ril_util.h"
 #include "ril_log.h"
 
-#include "sailfish_watch.h"
 #include "simutil.h"
 #include "util.h"
 #include "ofono.h"
 
 #define SIM_STATE_CHANGE_TIMEOUT_SECS (5)
-#define FAC_LOCK_QUERY_TIMEOUT_SECS   (10)
-#define FAC_LOCK_QUERY_RETRIES        (1)
-#define SIM_IO_TIMEOUT_SECS           (20)
 
 #define EF_STATUS_INVALIDATED 0
 #define EF_STATUS_VALID 1
@@ -44,6 +40,13 @@
 /* FID/path of SIM/USIM root directory */
 #define ROOTMF "3F00"
 
+/* RIL_Request* parameter counts */
+#define GET_IMSI_NUM_PARAMS 1
+#define ENTER_SIM_PIN_PARAMS 2
+#define SET_FACILITY_LOCK_PARAMS 5
+#define ENTER_SIM_PUK_PARAMS 3
+#define CHANGE_SIM_PIN_PARAMS 3
+
 /* P2 coding (modes) for READ RECORD and UPDATE RECORD (see TS 102.221) */
 #define MODE_SELECTED (0x00) /* Currently selected EF */
 #define MODE_CURRENT  (0x04) /* P1='00' denotes the current record */
@@ -62,18 +65,6 @@
  *
  * The same applies to the app_type.
  */
-
-enum ril_sim_card_event {
-	SIM_CARD_STATUS_EVENT,
-	SIM_CARD_APP_EVENT,
-	SIM_CARD_EVENT_COUNT
-};
-
-enum ril_sim_io_event {
-	IO_EVENT_SIM_REFRESH,
-	IO_EVENT_COUNT
-};
-
 struct ril_sim {
 	GRilIoChannel *io;
 	GRilIoQueue *q;
@@ -84,17 +75,12 @@ struct ril_sim {
 	int retries[OFONO_SIM_PASSWORD_INVALID];
 	gboolean empty_pin_query_allowed;
 	gboolean inserted;
-	guint idle_id; /* Used by register and SIM reset callbacks */
-	gulong card_event_id[SIM_CARD_EVENT_COUNT];
-	gulong io_event_id[IO_EVENT_COUNT];
-	guint query_pin_retries_id;
+	guint idle_id;
+	gulong card_status_id;
 
 	const char *log_prefix;
 	char *allocated_log_prefix;
 
-	struct sailfish_watch *watch;
-	gulong sim_state_watch_id;
-
 	/* query_passwd_state context */
 	ofono_sim_passwd_cb_t query_passwd_state_cb;
 	void *query_passwd_state_cb_data;
@@ -108,19 +94,18 @@ struct ril_sim_io_response {
 	guint data_len;
 };
 
-struct ril_sim_cbd_io {
+struct ril_sim_cbd {
 	struct ril_sim *sd;
-	struct ril_sim_card *card;
 	union _ofono_sim_cb {
 		ofono_sim_file_info_cb_t file_info;
 		ofono_sim_read_cb_t read;
 		ofono_sim_write_cb_t write;
 		ofono_sim_imsi_cb_t imsi;
+		ofono_sim_pin_retries_cb_t retries;
 		ofono_query_facility_lock_cb_t query_facility_lock;
 		gpointer ptr;
 	} cb;
 	gpointer data;
-	guint req_id;
 };
 
 struct ril_sim_pin_cbd {
@@ -135,88 +120,26 @@ struct ril_sim_pin_cbd {
 	gulong card_status_id;
 };
 
-struct ril_sim_retry_query_cbd {
-	struct ril_sim *sd;
-	ofono_sim_pin_retries_cb_t cb;
-	void *data;
-	guint query_index;
-};
-
-struct ril_sim_retry_query {
-	const char *name;
-	enum ofono_sim_password_type passwd_type;
-	guint req_code;
-	GRilIoRequest *(*new_req)(struct ril_sim *sd);
-};
-
-static GRilIoRequest *ril_sim_empty_sim_pin_req(struct ril_sim *sd);
-static GRilIoRequest *ril_sim_empty_sim_puk_req(struct ril_sim *sd);
-static void ril_sim_query_retry_count_cb(GRilIoChannel *io, int status,
-				const void *data, guint len, void *user_data);
-
-static const struct ril_sim_retry_query ril_sim_retry_query_types[] = {
-	{
-		"pin",
-		OFONO_SIM_PASSWORD_SIM_PIN,
-		RIL_REQUEST_ENTER_SIM_PIN,
-		ril_sim_empty_sim_pin_req
-	},{
-		"pin2",
-		OFONO_SIM_PASSWORD_SIM_PIN2,
-		RIL_REQUEST_ENTER_SIM_PIN2,
-		ril_sim_empty_sim_pin_req
-	},{
-		"puk",
-		OFONO_SIM_PASSWORD_SIM_PUK,
-		RIL_REQUEST_ENTER_SIM_PUK,
-		ril_sim_empty_sim_puk_req
-	},{
-		"puk2",
-		OFONO_SIM_PASSWORD_SIM_PUK2,
-		RIL_REQUEST_ENTER_SIM_PUK2,
-		ril_sim_empty_sim_puk_req
-	}
-};
-
 #define DBG_(sd,fmt,args...) DBG("%s" fmt, (sd)->log_prefix, ##args)
 
+#define ril_sim_cbd_free g_free
+
 static inline struct ril_sim *ril_sim_get_data(struct ofono_sim *sim)
 {
 	return ofono_sim_get_data(sim);
 }
 
-static struct ril_sim_cbd_io *ril_sim_cbd_io_new(struct ril_sim *sd, void *cb,
+static struct ril_sim_cbd *ril_sim_cbd_new(struct ril_sim *sd, void *cb,
 								void *data)
 {
-	struct ril_sim_cbd_io *cbd = g_new0(struct ril_sim_cbd_io, 1);
+	struct ril_sim_cbd *cbd = g_new0(struct ril_sim_cbd, 1);
 
 	cbd->sd = sd;
 	cbd->cb.ptr = cb;
 	cbd->data = data;
-	cbd->card = ril_sim_card_ref(sd->card);
 	return cbd;
 }
 
-static void ril_sim_cbd_io_free(void *data)
-{
-
-	struct ril_sim_cbd_io *cbd = data;
-
-	ril_sim_card_sim_io_finished(cbd->card, cbd->req_id);
-	ril_sim_card_unref(cbd->card);
-	g_free(cbd);
-}
-
-static void ril_sim_cbd_io_start(struct ril_sim_cbd_io *cbd, GRilIoRequest* req,
-				guint code, GRilIoChannelResponseFunc cb)
-{
-	struct ril_sim *sd = cbd->sd;
-
-	cbd->req_id = grilio_queue_send_request_full(sd->q, req, code,
-						cb, ril_sim_cbd_io_free, cbd);
-	ril_sim_card_sim_io_started(cbd->card, cbd->req_id);
-}
-
 static void ril_sim_pin_cbd_state_event_count_cb(struct ril_sim_card *sc,
 							void *user_data)
 {
@@ -275,6 +198,11 @@ static void ril_sim_pin_req_done(gpointer ptr)
 	}
 }
 
+static const char *ril_sim_app_id(struct ril_sim *sd)
+{
+	return sd->card->app ? sd->card->app->aid : NULL;
+}
+
 int ril_sim_app_type(struct ofono_sim *sim)
 {
 	struct ril_sim *sd = ril_sim_get_data(sim);
@@ -444,7 +372,7 @@ static void ril_sim_io_response_free(struct ril_sim_io_response *res)
 static void ril_sim_file_info_cb(GRilIoChannel *io, int status,
 			const void *data, guint len, void *user_data)
 {
-	struct ril_sim_cbd_io *cbd = user_data;
+	struct ril_sim_cbd *cbd = user_data;
 	ofono_sim_file_info_cb_t cb = cbd->cb.file_info;
 	struct ril_sim *sd = cbd->sd;
 	struct ril_sim_io_response *res = NULL;
@@ -494,13 +422,12 @@ static void ril_sim_file_info_cb(GRilIoChannel *io, int status,
 static void ril_sim_request_io(struct ril_sim *sd, guint cmd, int fileid,
 		guint p1, guint p2, guint p3, const char *hex_data,
 		const guchar *path, guint path_len,
-		GRilIoChannelResponseFunc cb, struct ril_sim_cbd_io *cbd)
+		GRilIoChannelResponseFunc cb, struct ril_sim_cbd *cbd)
 {
 	GRilIoRequest *req = grilio_request_new();
 
 	DBG_(sd, "cmd=0x%.2X,efid=0x%.4X,%d,%d,%d,%s,pin2=(null),aid=%s",
-					cmd, fileid, p1, p2, p3, hex_data,
-					ril_sim_card_app_aid(sd->card));
+			cmd, fileid, p1, p2, p3, hex_data, ril_sim_app_id(sd));
 
 	grilio_request_append_int32(req, cmd);
 	grilio_request_append_int32(req, fileid);
@@ -510,11 +437,10 @@ static void ril_sim_request_io(struct ril_sim *sd, guint cmd, int fileid,
 	grilio_request_append_int32(req, p3);       /* P3 */
 	grilio_request_append_utf8(req, hex_data);  /* data; only for writes */
 	grilio_request_append_utf8(req, NULL);      /* pin2; only for writes */
-	grilio_request_append_utf8(req, ril_sim_card_app_aid(sd->card));
+	grilio_request_append_utf8(req, ril_sim_app_id(sd));
 
-	grilio_request_set_blocking(req, TRUE);
-	grilio_request_set_timeout(req, SIM_IO_TIMEOUT_SECS * 1000);
-	ril_sim_cbd_io_start(cbd, req, RIL_REQUEST_SIM_IO, cb);
+	grilio_queue_send_request_full(sd->q, req, RIL_REQUEST_SIM_IO,
+					cb, ril_sim_cbd_free, cbd);
 	grilio_request_unref(req);
 }
 
@@ -524,20 +450,18 @@ static void ril_sim_ofono_read_file_info(struct ofono_sim *sim, int fileid,
 {
 	struct ril_sim *sd = ril_sim_get_data(sim);
 	ril_sim_request_io(sd, CMD_GET_RESPONSE, fileid, 0, 0, 15, NULL,
-				path, len, ril_sim_file_info_cb,
-				ril_sim_cbd_io_new(sd, cb, data));
+		path, len, ril_sim_file_info_cb, ril_sim_cbd_new(sd, cb, data));
 }
 
 static void ril_sim_read_cb(GRilIoChannel *io, int status,
 				const void *data, guint len, void *user_data)
 {
-	struct ril_sim_cbd_io *cbd = user_data;
+	struct ril_sim_cbd *cbd = user_data;
 	ofono_sim_read_cb_t cb = cbd->cb.read;
 	struct ril_sim_io_response *res;
 	struct ofono_error err;
 
 	DBG_(cbd->sd, "");
-
 	res = ril_sim_parse_io_response(data, len);
 	if (ril_sim_io_response_ok(res) && status == RIL_E_SUCCESS) {
 		cb(ril_error_ok(&err), res->data, res->data_len, cbd->data);
@@ -555,7 +479,7 @@ static void ril_sim_read(struct ofono_sim *sim, guint cmd, int fileid,
 {
 	struct ril_sim *sd = ril_sim_get_data(sim);
 	ril_sim_request_io(sd, cmd, fileid, p1, p2, p3, NULL, path, path_len,
-			ril_sim_read_cb, ril_sim_cbd_io_new(sd, cb, data));
+			ril_sim_read_cb, ril_sim_cbd_new(sd, cb, data));
 }
 
 static void ril_sim_ofono_read_file_transparent(struct ofono_sim *sim,
@@ -585,13 +509,12 @@ static void ril_sim_ofono_read_file_cyclic(struct ofono_sim *sim, int fileid,
 static void ril_sim_write_cb(GRilIoChannel *io, int status,
 				const void *data, guint len, void *user_data)
 {
-	struct ril_sim_cbd_io *cbd = user_data;
+	struct ril_sim_cbd *cbd = user_data;
 	ofono_sim_write_cb_t cb = cbd->cb.write;
 	struct ril_sim_io_response *res;
 	struct ofono_error err;
 
 	DBG_(cbd->sd, "");
-
 	res = ril_sim_parse_io_response(data, len);
 	if (ril_sim_io_response_ok(res) && status == RIL_E_SUCCESS) {
 		cb(ril_error_ok(&err), cbd->data);
@@ -611,7 +534,7 @@ static void ril_sim_write(struct ofono_sim *sim, guint cmd, int fileid,
 	struct ril_sim *sd = ril_sim_get_data(sim);
 	char *hex_data = encode_hex(value, length, 0);
 	ril_sim_request_io(sd, cmd, fileid, p1, p2, length, hex_data, path,
-		path_len, ril_sim_write_cb, ril_sim_cbd_io_new(sd, cb, data));
+		path_len, ril_sim_write_cb, ril_sim_cbd_new(sd, cb, data));
 	g_free(hex_data);
 }
 
@@ -648,7 +571,7 @@ static void ril_sim_write_file_cyclic(struct ofono_sim *sim, int fileid,
 static void ril_sim_get_imsi_cb(GRilIoChannel *io, int status,
 				const void *data, guint len, void *user_data)
 {
-	struct ril_sim_cbd_io *cbd = user_data;
+	struct ril_sim_cbd *cbd = user_data;
 	ofono_sim_imsi_cb_t cb = cbd->cb.imsi;
 	struct ofono_error error;
 
@@ -676,11 +599,11 @@ static void ril_sim_read_imsi(struct ofono_sim *sim, ofono_sim_imsi_cb_t cb,
 				void *data)
 {
 	struct ril_sim *sd = ril_sim_get_data(sim);
-	const char *app_id = ril_sim_card_app_aid(sd->card);
-	struct ril_sim_cbd_io *cbd = ril_sim_cbd_io_new(sd, cb, data);
-	GRilIoRequest *req = grilio_request_array_utf8_new(1, app_id);
+	GRilIoRequest *req = grilio_request_sized_new(60);
 
-	DBG_(sd, "%s", app_id);
+	DBG_(sd, "%s", ril_sim_app_id(sd));
+	grilio_request_append_int32(req, GET_IMSI_NUM_PARAMS);
+	grilio_request_append_utf8(req, ril_sim_app_id(sd));
 
 	/*
 	 * If we fail the .read_imsi call, ofono gets into "Unable to
@@ -688,9 +611,9 @@ static void ril_sim_read_imsi(struct ofono_sim *sim, ofono_sim_imsi_cb_t cb,
 	 * on failure.
 	 */
 	grilio_request_set_retry(req, RIL_RETRY_MS, -1);
-	grilio_request_set_blocking(req, TRUE);
-	ril_sim_cbd_io_start(cbd, req, RIL_REQUEST_GET_IMSI,
-						ril_sim_get_imsi_cb);
+	grilio_queue_send_request_full(sd->q, req, RIL_REQUEST_GET_IMSI,
+				ril_sim_get_imsi_cb, ril_sim_cbd_free,
+				ril_sim_cbd_new(sd, cb, data));
 	grilio_request_unref(req);
 }
 
@@ -793,34 +716,6 @@ static void ril_sim_finish_passwd_state_query(struct ril_sim *sd,
 	}
 }
 
-static void ril_sim_check_perm_lock(struct ril_sim *sd)
-{
-	struct ril_sim_card *sc = sd->card;
-
-	/*
-	 * Zero number of retries in the PUK state indicates to the ofono
-	 * client that the card is permanently locked. This is different
-	 * from the case when the number of retries is negative (which
-	 * means that PUK is required but the number of remaining attempts
-	 * is not available).
-	 */
-	if (sc->app && sc->app->app_state == RIL_APPSTATE_PUK &&
-		sc->app->pin1_state == RIL_PINSTATE_ENABLED_PERM_BLOCKED) {
-
-		/*
-		 * It makes no sense for RIL to return non-zero number of
-		 * remaining attempts in PERM_LOCKED state. So when we get
-		 * here, the number of retries has to be negative (unknown)
-		 * or zero. Otherwise, something must be broken.
-		 */
-		GASSERT(sd->retries[OFONO_SIM_PASSWORD_SIM_PUK] <= 0);
-		if (sd->retries[OFONO_SIM_PASSWORD_SIM_PUK] < 0) {
-			sd->retries[OFONO_SIM_PASSWORD_SIM_PUK] = 0;
-			DBG_(sd, "SIM card is locked");
-		}
-	}
-}
-
 static void ril_sim_invalidate_passwd_state(struct ril_sim *sd)
 {
 	guint i;
@@ -830,16 +725,10 @@ static void ril_sim_invalidate_passwd_state(struct ril_sim *sd)
 		sd->retries[i] = -1;
 	}
 
-	ril_sim_check_perm_lock(sd);
 	ril_sim_finish_passwd_state_query(sd, OFONO_SIM_PASSWORD_INVALID);
 }
 
-static void ril_sim_app_changed_cb(struct ril_sim_card *sc, void *user_data)
-{
-	ril_sim_check_perm_lock((struct ril_sim *)user_data);
-}
-
-static void ril_sim_status_changed_cb(struct ril_sim_card *sc, void *user_data)
+static void ril_sim_status_cb(struct ril_sim_card *sc, void *user_data)
 {
 	struct ril_sim *sd = user_data;
 
@@ -848,7 +737,6 @@ static void ril_sim_status_changed_cb(struct ril_sim_card *sc, void *user_data)
 		if (sc->app) {
 			enum ofono_sim_password_type ps;
 
-			ril_sim_check_perm_lock(sd);
 			if (!sd->inserted) {
 				sd->inserted = TRUE;
 				ofono_info("SIM card OK");
@@ -872,18 +760,6 @@ static void ril_sim_status_changed_cb(struct ril_sim_card *sc, void *user_data)
 	}
 }
 
-static void ril_sim_state_changed_cb(struct sailfish_watch *watch, void *data)
-{
-	struct ril_sim *sd = data;
-	const enum ofono_sim_state state = ofono_sim_get_state(watch->sim);
-
-	DBG_(sd, "%d %d", state, sd->inserted);
-	if (state == OFONO_SIM_STATE_RESETTING && sd->inserted) {
-		/* That will simulate SIM card removal: */
-		ril_sim_card_reset(sd->card);
-	}
-}
-
 static int ril_sim_parse_retry_count(const void *data, guint len)
 {
 	int retry_count = -1;
@@ -895,29 +771,14 @@ static int ril_sim_parse_retry_count(const void *data, guint len)
 	return retry_count;
 }
 
-static GRilIoRequest *ril_sim_enter_sim_pin_req(struct ril_sim *sd,
-							const char *pin)
+static GRilIoRequest *ril_sim_enter_sim_req(struct ril_sim *sd, const char *pw)
 {
-	/*
-	 * If there's no AID then so be it... Some
-	 * adaptations (namely, MTK) don't provide it
-	 * but don't seem to require it either.
-	 */
-	GRilIoRequest *req = grilio_request_array_utf8_new(2, pin,
-					ril_sim_card_app_aid(sd->card));
-
-	grilio_request_set_blocking(req, TRUE);
-	return req;
-}
-
-static GRilIoRequest *ril_sim_enter_sim_puk_req(struct ril_sim *sd,
-					const char *puk, const char *pin)
-{
-	const char *app_id = ril_sim_card_app_aid(sd->card);
+	const char *app_id = ril_sim_app_id(sd);
 	if (app_id) {
-		GRilIoRequest *req = grilio_request_array_utf8_new(3,
-							puk, pin, app_id);
-		grilio_request_set_blocking(req, TRUE);
+		GRilIoRequest *req = grilio_request_new();
+		grilio_request_append_int32(req, ENTER_SIM_PIN_PARAMS);
+		grilio_request_append_utf8(req, pw);
+		grilio_request_append_utf8(req, app_id);
 		return req;
 	}
 	return NULL;
@@ -927,90 +788,63 @@ static GRilIoRequest *ril_sim_enter_sim_puk_req(struct ril_sim *sd,
  * Some RIL implementations allow to query the retry count
  * by sending the empty pin in any state.
  */
-
-static GRilIoRequest *ril_sim_empty_sim_pin_req(struct ril_sim *sd)
-{
-	return ril_sim_enter_sim_pin_req(sd, "");
-}
-
-static GRilIoRequest *ril_sim_empty_sim_puk_req(struct ril_sim *sd)
-{
-	return ril_sim_enter_sim_puk_req(sd, "", "");
-}
-
-static struct ril_sim_retry_query_cbd *ril_sim_retry_query_cbd_new(
-				struct ril_sim *sd, guint query_index,
-				ofono_sim_pin_retries_cb_t cb, void *data)
-{
-	struct ril_sim_retry_query_cbd *cbd =
-		g_new(struct ril_sim_retry_query_cbd, 1);
-
-	cbd->sd = sd;
-	cbd->cb = cb;
-	cbd->data = data;
-	cbd->query_index = query_index;
-	return cbd;
-}
-
-static gboolean ril_sim_query_retry_count(struct ril_sim *sd,
-		guint start_index, ofono_sim_pin_retries_cb_t cb, void *data)
-{
-	guint id = 0;
-
-	if (sd->empty_pin_query_allowed) {
-		guint i = start_index;
-
-		/* Find the first unknown retry count that we can query. */
-		while (i < G_N_ELEMENTS(ril_sim_retry_query_types)) {
-			const struct ril_sim_retry_query *query =
-				ril_sim_retry_query_types + i;
-
-			if (sd->retries[query->passwd_type] < 0) {
-				GRilIoRequest *req = query->new_req(sd);
-
-				if (req) {
-					DBG_(sd, "querying %s retry count...",
-								query->name);
-					id = grilio_queue_send_request_full(
-						sd->q, req, query->req_code,
-						ril_sim_query_retry_count_cb,
-						g_free,
-						ril_sim_retry_query_cbd_new(
-							sd, i, cb, data));
-					grilio_request_unref(req);
-				}
-				break;
-			}
-			i++;
-		}
-	}
-
-	return id;
-}
-
-static void ril_sim_query_retry_count_cb(GRilIoChannel *io, int status,
+static void ril_sim_query_pin2_retries_cb(GRilIoChannel *io, int status,
 				const void *data, guint len, void *user_data)
 {
-	struct ril_sim_retry_query_cbd *cbd = user_data;
+	struct ril_sim_cbd *cbd = user_data;
 	struct ril_sim *sd = cbd->sd;
+	ofono_sim_pin_retries_cb_t cb = cbd->cb.retries;
 	struct ofono_error error;
 
-	GASSERT(sd->query_pin_retries_id);
-	sd->query_pin_retries_id = 0;
-
 	if (status == RIL_E_SUCCESS) {
 		const int retry_count = ril_sim_parse_retry_count(data, len);
-		const struct ril_sim_retry_query *query =
-			ril_sim_retry_query_types + cbd->query_index;
+		DBG_(sd, "pin2 retry_count=%d", retry_count);
+		sd->retries[OFONO_SIM_PASSWORD_SIM_PIN2] = retry_count;
+	} else {
+		ofono_error("pin2 retry query is not supported");
+		sd->empty_pin_query_allowed = FALSE;
+	}
 
-		DBG_(sd, "%s retry_count=%d", query->name, retry_count);
-		sd->retries[query->passwd_type] = retry_count;
+	cb(ril_error_ok(&error), sd->retries, cbd->data);
+}
 
-		/* Submit the next request */
-		if ((sd->query_pin_retries_id =
-			ril_sim_query_retry_count(sd, cbd->query_index + 1,
-						cbd->cb, cbd->data)) != 0) {
-			/* The next request is pending */
+static gboolean ril_sim_query_pin2_retry_count(struct ril_sim *sd,
+				ofono_sim_pin_retries_cb_t cb, void *data)
+{
+	if (sd->empty_pin_query_allowed &&
+				sd->retries[OFONO_SIM_PASSWORD_SIM_PIN2] < 0) {
+		GRilIoRequest *req = ril_sim_enter_sim_req(sd, "");
+		if (req) {
+			DBG_(sd, "querying pin2 retry count...");
+			grilio_queue_send_request_full(sd->q, req,
+				RIL_REQUEST_ENTER_SIM_PIN2,
+				ril_sim_query_pin2_retries_cb,
+				ril_sim_cbd_free,
+				ril_sim_cbd_new(sd, cb, data));
+			grilio_request_unref(req);
+			return TRUE;
+		}
+	}
+	return FALSE;
+}
+
+static void ril_sim_query_pin_retries_cb(GRilIoChannel *io, int status,
+				const void *data, guint len, void *user_data)
+{
+	struct ril_sim_cbd *cbd = user_data;
+	struct ril_sim *sd = cbd->sd;
+	ofono_sim_pin_retries_cb_t cb = cbd->cb.retries;
+	struct ofono_error error;
+
+	if (status == RIL_E_SUCCESS) {
+		const int retry_count = ril_sim_parse_retry_count(data, len);
+		DBG_(sd, "pin retry_count=%d", retry_count);
+		sd->retries[OFONO_SIM_PASSWORD_SIM_PIN] = retry_count;
+		if (ril_sim_query_pin2_retry_count(sd, cb, cbd->data)) {
+			/*
+			 * ril_sim_query_pin2_retries_cb will invoke
+			 * the completion callback
+			 */
 			return;
 		}
 	} else {
@@ -1018,23 +852,43 @@ static void ril_sim_query_retry_count_cb(GRilIoChannel *io, int status,
 		sd->empty_pin_query_allowed = FALSE;
 	}
 
-	cbd->cb(ril_error_ok(&error), sd->retries, cbd->data);
+	cb(ril_error_ok(&error), sd->retries, cbd->data);
+}
+
+static gboolean ril_sim_query_pin_retry_count(struct ril_sim *sd,
+				ofono_sim_pin_retries_cb_t cb, void *data)
+{
+	if (sd->empty_pin_query_allowed &&
+				sd->retries[OFONO_SIM_PASSWORD_SIM_PIN] < 0) {
+		GRilIoRequest *req = ril_sim_enter_sim_req(sd, "");
+		if (req) {
+			DBG_(sd, "querying pin retry count...");
+			grilio_queue_send_request_full(sd->q, req,
+				RIL_REQUEST_ENTER_SIM_PIN,
+				ril_sim_query_pin_retries_cb,
+				ril_sim_cbd_free,
+				ril_sim_cbd_new(sd, cb, data));
+			grilio_request_unref(req);
+			return TRUE;
+		}
+	}
+	return FALSE;
 }
 
 static void ril_sim_query_pin_retries(struct ofono_sim *sim,
 				ofono_sim_pin_retries_cb_t cb, void *data)
 {
+	struct ofono_error error;
 	struct ril_sim *sd = ril_sim_get_data(sim);
 
 	DBG_(sd, "");
-	grilio_queue_cancel_request(sd->q, sd->query_pin_retries_id, FALSE);
-	sd->query_pin_retries_id = ril_sim_query_retry_count(sd, 0, cb, data);
-	if (!sd->query_pin_retries_id) {
-		struct ofono_error error;
-
-		/* Nothing to wait for */
-		cb(ril_error_ok(&error), sd->retries, data);
+	if (ril_sim_query_pin_retry_count(sd, cb, data) ||
+			ril_sim_query_pin2_retry_count(sd, cb, data)) {
+		/* Wait for completion of PIN and then PIN2 query */
+		return;
 	}
+
+	cb(ril_error_ok(&error), sd->retries, data);
 }
 
 static void ril_sim_query_passwd_state_complete_cb(struct ril_sim_card *sc,
@@ -1145,30 +999,20 @@ static void ril_sim_pin_change_state_cb(GRilIoChannel *io, int ril_status,
 	struct ril_sim_pin_cbd *cbd = user_data;
 	struct ril_sim *sd = cbd->sd;
 	const int retry_count = ril_sim_parse_retry_count(data, len);
-	enum ofono_sim_password_type type = cbd->passwd_type;
 
 	DBG_(sd, "result=%d passwd_type=%d retry_count=%d",
 			ril_status, cbd->passwd_type, retry_count);
 
-	if (ril_status == RIL_E_SUCCESS && retry_count == 0) {
-		enum ofono_sim_password_type associated_pin =
-						__ofono_sim_puk2pin(type);
-		/*
-		 * If PIN/PUK request has succeeded, zero retry count
-		 * makes no sense, we have to assume that it's unknown.
-		 * If it can be queried, it will be queried later. If
-		 * it can't be queried it will remain unknown.
-		 */
-		sd->retries[type] = -1;
-		if (associated_pin != OFONO_SIM_PASSWORD_INVALID) {
-			/* Successful PUK requests affect PIN retry count */
-			sd->retries[associated_pin] = -1;
-		}
+	if (ril_status == RIL_E_SUCCESS && retry_count == 0 &&
+			sd->empty_pin_query_allowed &&
+			(cbd->passwd_type == OFONO_SIM_PASSWORD_SIM_PIN ||
+			cbd->passwd_type == OFONO_SIM_PASSWORD_SIM_PIN2)) {
+		/* Will query it */
+		sd->retries[cbd->passwd_type] = -1;
 	} else {
-		sd->retries[type] = retry_count;
+		sd->retries[cbd->passwd_type] = retry_count;
 	}
 
-	ril_sim_check_perm_lock(sd);
 	cbd->ril_status = ril_status;
 	if (cbd->card_status_id && (!cbd->state_event_count ||
 					ril_sim_app_in_transient_state(sd))) {
@@ -1198,13 +1042,6 @@ static void ril_sim_pin_change_state_cb(GRilIoChannel *io, int ril_status,
 		} else {
 			cbd->cb(ril_error_failure(&error), cbd->data);
 		}
-
-		/* To avoid assert in ril_sim_pin_req_done: */
-		if (cbd->card_status_id) {
-			ril_sim_card_remove_handler(cbd->card,
-						cbd->card_status_id);
-			cbd->card_status_id = 0;
-		}
 	}
 }
 
@@ -1212,21 +1049,18 @@ static void ril_sim_pin_send(struct ofono_sim *sim, const char *passwd,
 				ofono_sim_lock_unlock_cb_t cb, void *data)
 {
 	struct ril_sim *sd = ril_sim_get_data(sim);
-	GRilIoRequest *req = ril_sim_enter_sim_pin_req(sd, passwd);
+	GRilIoRequest *req = grilio_request_new();
 
-	if (req) {
-		DBG_(sd, "%s,aid=%s", passwd, ril_sim_card_app_aid(sd->card));
-		grilio_queue_send_request_full(sd->q, req,
-			RIL_REQUEST_ENTER_SIM_PIN, ril_sim_pin_change_state_cb,
-			ril_sim_pin_req_done, ril_sim_pin_cbd_new(sd,
-				OFONO_SIM_PASSWORD_SIM_PIN, TRUE, cb, data));
-		grilio_request_unref(req);
-	} else {
-		struct ofono_error error;
+	grilio_request_append_int32(req, ENTER_SIM_PIN_PARAMS);
+	grilio_request_append_utf8(req, passwd);
+	grilio_request_append_utf8(req, ril_sim_app_id(sd));
 
-		DBG_(sd, "sorry");
-		cb(ril_error_failure(&error), data);
-	}
+	DBG_(sd, "%s,aid=%s", passwd, ril_sim_app_id(sd));
+	grilio_queue_send_request_full(sd->q, req, RIL_REQUEST_ENTER_SIM_PIN,
+		ril_sim_pin_change_state_cb, ril_sim_pin_req_done,
+		ril_sim_pin_cbd_new(sd, OFONO_SIM_PASSWORD_SIM_PIN,
+						TRUE, cb, data));
+	grilio_request_unref(req);
 }
 
 static guint ril_perso_change_state(struct ofono_sim *sim,
@@ -1242,7 +1076,10 @@ static guint ril_perso_change_state(struct ofono_sim *sim,
 	case OFONO_SIM_PASSWORD_PHNET_PIN:
 		if (!enable) {
 			code = RIL_REQUEST_ENTER_NETWORK_DEPERSONALIZATION;
-			req = grilio_request_array_utf8_new(1, passwd);
+			req = grilio_request_sized_new(12);
+			grilio_request_append_int32(req,
+					RIL_PERSOSUBSTATE_SIM_NETWORK);
+			grilio_request_append_utf8(req, passwd);
 		} else {
 			DBG_(sd, "Not supported, enable=%d", enable);
 		}
@@ -1255,7 +1092,7 @@ static guint ril_perso_change_state(struct ofono_sim *sim,
 	if (req) {
 		id = grilio_queue_send_request_full(sd->q, req, code,
 			ril_sim_pin_change_state_cb, ril_sim_pin_req_done,
-			ril_sim_pin_cbd_new(sd, passwd_type, FALSE, cb, data));
+			ril_sim_pin_cbd_new(sd, passwd_type, TRUE, cb, data));
 		grilio_request_unref(req);
 	}
 
@@ -1291,27 +1128,30 @@ static void ril_sim_pin_change_state(struct ofono_sim *sim,
 	const char *passwd, ofono_sim_lock_unlock_cb_t cb, void *data)
 {
 	struct ril_sim *sd = ril_sim_get_data(sim);
-	const char *app_id = ril_sim_card_app_aid(sd->card);
-	const char *type_str = ril_sim_facility_code(passwd_type);
 	struct ofono_error error;
+	const char *type_str = ril_sim_facility_code(passwd_type);
 	guint id = 0;
 
-	DBG_(sd, "%d,%s,%d,%s,0,aid=%s", passwd_type, type_str,
-						enable, passwd, app_id);
+	DBG_(sd, "%d,%s,%d,%s,0,aid=%s", passwd_type, type_str, enable, passwd,
+							ril_sim_app_id(sd));
 
 	if (passwd_type == OFONO_SIM_PASSWORD_PHNET_PIN) {
 		id = ril_perso_change_state(sim, passwd_type, enable, passwd,
 								cb, data);
 	} else if (type_str) {
-		GRilIoRequest *req = grilio_request_array_utf8_new(5, type_str,
-			enable ? RIL_FACILITY_LOCK : RIL_FACILITY_UNLOCK,
-			passwd, "0" /* class */, app_id);
+		GRilIoRequest *req = grilio_request_new();
+		grilio_request_append_int32(req, SET_FACILITY_LOCK_PARAMS);
+		grilio_request_append_utf8(req, type_str);
+		grilio_request_append_utf8(req, enable ?
+			RIL_FACILITY_LOCK : RIL_FACILITY_UNLOCK);
+		grilio_request_append_utf8(req, passwd);
+		grilio_request_append_utf8(req, "0");		/* class */
+		grilio_request_append_utf8(req, ril_sim_app_id(sd));
 
-		grilio_request_set_blocking(req, TRUE);
 		id = grilio_queue_send_request_full(sd->q, req,
 			RIL_REQUEST_SET_FACILITY_LOCK,
 			ril_sim_pin_change_state_cb, ril_sim_pin_req_done,
-			ril_sim_pin_cbd_new(sd, passwd_type, FALSE, cb, data));
+			ril_sim_pin_cbd_new(sd, passwd_type, TRUE, cb, data));
 		grilio_request_unref(req);
 	}
 
@@ -1325,22 +1165,19 @@ static void ril_sim_pin_send_puk(struct ofono_sim *sim,
 				ofono_sim_lock_unlock_cb_t cb, void *data)
 {
 	struct ril_sim *sd = ril_sim_get_data(sim);
-	GRilIoRequest *req = ril_sim_enter_sim_puk_req(sd, puk, passwd);
+	GRilIoRequest *req = grilio_request_sized_new(60);
 
-	if (req) {
-		DBG_(sd, "puk=%s,pin=%s,aid=%s", puk, passwd,
-					ril_sim_card_app_aid(sd->card));
-		grilio_queue_send_request_full(sd->q, req,
-			RIL_REQUEST_ENTER_SIM_PUK, ril_sim_pin_change_state_cb,
-			ril_sim_pin_req_done, ril_sim_pin_cbd_new(sd,
-				OFONO_SIM_PASSWORD_SIM_PUK, TRUE, cb, data));
-		grilio_request_unref(req);
-	} else {
-		struct ofono_error error;
+	grilio_request_append_int32(req, ENTER_SIM_PUK_PARAMS);
+	grilio_request_append_utf8(req, puk);
+	grilio_request_append_utf8(req, passwd);
+	grilio_request_append_utf8(req, ril_sim_app_id(sd));
 
-		DBG_(sd, "sorry");
-		cb(ril_error_failure(&error), data);
-	}
+	DBG_(sd, "puk=%s,pin=%s,aid=%s", puk, passwd, ril_sim_app_id(sd));
+	grilio_queue_send_request_full(sd->q, req, RIL_REQUEST_ENTER_SIM_PUK,
+		ril_sim_pin_change_state_cb, ril_sim_pin_req_done,
+		ril_sim_pin_cbd_new(sd, OFONO_SIM_PASSWORD_SIM_PUK,
+						TRUE, cb, data));
+	grilio_request_unref(req);
 }
 
 static void ril_sim_change_passwd(struct ofono_sim *sim,
@@ -1349,12 +1186,15 @@ static void ril_sim_change_passwd(struct ofono_sim *sim,
 				ofono_sim_lock_unlock_cb_t cb, void *data)
 {
 	struct ril_sim *sd = ril_sim_get_data(sim);
-	const char *app_id = ril_sim_card_app_aid(sd->card);
-	GRilIoRequest *req = grilio_request_array_utf8_new(3,
-					old_passwd, new_passwd, app_id);
+	GRilIoRequest *req = grilio_request_sized_new(60);
 
-	DBG_(sd, "old=%s,new=%s,aid=%s", old_passwd, new_passwd, app_id);
-	grilio_request_set_blocking(req, TRUE);
+	grilio_request_append_int32(req, CHANGE_SIM_PIN_PARAMS);
+	grilio_request_append_utf8(req, old_passwd);
+	grilio_request_append_utf8(req, new_passwd);
+	grilio_request_append_utf8(req, ril_sim_app_id(sd));
+
+	DBG_(sd, "old=%s,new=%s,aid=%s", old_passwd, new_passwd,
+							ril_sim_app_id(sd));
 	grilio_queue_send_request_full(sd->q, req,
 		(passwd_type == OFONO_SIM_PASSWORD_SIM_PIN2) ?
 		RIL_REQUEST_CHANGE_SIM_PIN2 : RIL_REQUEST_CHANGE_SIM_PIN,
@@ -1367,7 +1207,7 @@ static void ril_sim_query_facility_lock_cb(GRilIoChannel *io, int status,
 				const void *data, guint len, void *user_data)
 {
 	struct ofono_error error;
-	struct ril_sim_cbd_io *cbd = user_data;
+	struct ril_sim_cbd *cbd = user_data;
 	ofono_query_facility_lock_cb_t cb = cbd->cb.query_facility_lock;
 
 	if (status == RIL_E_SUCCESS) {
@@ -1386,47 +1226,26 @@ static void ril_sim_query_facility_lock_cb(GRilIoChannel *io, int status,
 	cb(ril_error_failure(&error), FALSE, cbd->data);
 }
 
-static gboolean ril_sim_query_facility_lock_retry(GRilIoRequest* req,
-				int ril_status, const void* response_data,
-				guint response_len, void* user_data)
-{
-	return (ril_status == GRILIO_STATUS_TIMEOUT);
-}
-
 static void ril_sim_query_facility_lock(struct ofono_sim *sim,
 				enum ofono_sim_password_type type,
 				ofono_query_facility_lock_cb_t cb, void *data)
 {
 	struct ril_sim *sd = ril_sim_get_data(sim);
+	GRilIoRequest *req = grilio_request_new();
 	const char *type_str = ril_sim_facility_code(type);
-	struct ril_sim_cbd_io *cbd = ril_sim_cbd_io_new(sd, cb, data);
-	GRilIoRequest *req = grilio_request_array_utf8_new(4,
-		type_str, "", "0" /* class */, ril_sim_card_app_aid(sd->card));
-
-	/* Make sure that this request gets completed sooner or later */
-	grilio_request_set_timeout(req, FAC_LOCK_QUERY_TIMEOUT_SECS * 1000);
-	grilio_request_set_retry(req, RIL_RETRY_MS, FAC_LOCK_QUERY_RETRIES);
-	grilio_request_set_retry_func(req, ril_sim_query_facility_lock_retry);
 
 	DBG_(sd, "%s", type_str);
-	ril_sim_cbd_io_start(cbd, req, RIL_REQUEST_QUERY_FACILITY_LOCK,
-					ril_sim_query_facility_lock_cb);
+	grilio_request_append_int32(req, 4);
+	grilio_request_append_utf8(req, type_str);
+	grilio_request_append_utf8(req, "");
+	grilio_request_append_utf8(req, "0"); /* class */
+	grilio_request_append_utf8(req, ril_sim_app_id(sd));
+	grilio_queue_send_request_full(sd->q, req,
+		RIL_REQUEST_QUERY_FACILITY_LOCK, ril_sim_query_facility_lock_cb,
+		ril_sim_cbd_free, ril_sim_cbd_new(sd, cb, data));
 	grilio_request_unref(req);
 }
 
-static void ril_sim_refresh_cb(GRilIoChannel *io, guint code,
-				const void *data, guint len, void *user_data)
-{
-	struct ril_sim *sd = user_data;
-
-	/*
-	 * RIL_UNSOL_SIM_REFRESH may contain the EFID of the updated file,
-	 * so we could be more descrete here. However I have't actually
-	 * seen that in real life, let's just refresh everything for now.
-	 */
-	__ofono_sim_refresh(sd->sim, NULL, TRUE, TRUE);
-}
-
 static gboolean ril_sim_register(gpointer user)
 {
 	struct ril_sim *sd = user;
@@ -1438,23 +1257,11 @@ static gboolean ril_sim_register(gpointer user)
 	ofono_sim_register(sd->sim);
 
 	/* Register for change notifications */
-	sd->card_event_id[SIM_CARD_STATUS_EVENT] =
-		ril_sim_card_add_status_changed_handler(sd->card,
-					ril_sim_status_changed_cb, sd);
-	sd->card_event_id[SIM_CARD_APP_EVENT] =
-		ril_sim_card_add_app_changed_handler(sd->card,
-					ril_sim_app_changed_cb, sd);
-	sd->sim_state_watch_id =
-		sailfish_watch_add_sim_state_changed_handler(sd->watch,
-					ril_sim_state_changed_cb, sd);
-
-	/* And RIL events */
-	sd->io_event_id[IO_EVENT_SIM_REFRESH] =
-		grilio_channel_add_unsol_event_handler(sd->io,
-			ril_sim_refresh_cb, RIL_UNSOL_SIM_REFRESH, sd);
+	sd->card_status_id = ril_sim_card_add_status_changed_handler(sd->card,
+						ril_sim_status_cb, sd);
 
 	/* Check the current state */
-	ril_sim_status_changed_cb(sd->card, sd);
+	ril_sim_status_cb(sd->card, sd);
 	return FALSE;
 }
 
@@ -1470,7 +1277,6 @@ static int ril_sim_probe(struct ofono_sim *sim, unsigned int vendor,
 	sd->io = grilio_channel_ref(ril_modem_io(modem));
 	sd->card = ril_sim_card_ref(modem->sim_card);
 	sd->q = grilio_queue_new(sd->io);
-	sd->watch = sailfish_watch_new(ril_modem_get_path(modem));
 
 	if (modem->log_prefix && modem->log_prefix[0]) {
 		sd->log_prefix = sd->allocated_log_prefix =
@@ -1491,7 +1297,6 @@ static void ril_sim_remove(struct ofono_sim *sim)
 
 	DBG_(sd, "");
 	g_list_free_full(sd->pin_cbd_list, ril_sim_pin_cbd_list_free_cb);
-	grilio_channel_remove_all_handlers(sd->io, sd->io_event_id);
 	grilio_queue_cancel_all(sd->q, FALSE);
 	ofono_sim_set_data(sim, NULL);
 
@@ -1508,11 +1313,7 @@ static void ril_sim_remove(struct ofono_sim *sim)
 			sd->query_passwd_state_sim_status_refresh_id);
 	}
 
-	sailfish_watch_remove_handler(sd->watch, sd->sim_state_watch_id);
-	sailfish_watch_unref(sd->watch);
-
-	ril_sim_card_remove_handlers(sd->card, sd->card_event_id,
-					G_N_ELEMENTS(sd->card_event_id));
+	ril_sim_card_remove_handler(sd->card, sd->card_status_id);
 	ril_sim_card_unref(sd->card);
 
 	grilio_channel_unref(sd->io);

ofono/drivers/ril/ril_sim_card.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2018 Jolla Ltd.
+ *  Copyright (C) 2015-2017 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -24,26 +24,6 @@
 
 #include <gutil_misc.h>
 
-/*
- * First we wait for USIM app to get activated by itself. If that
- * doesn't happen within UICC_SUBSCRIPTION_START_MS we poke the SIM
- * with SET_UICC_SUBSCRIPTION request, resubmitting it if it times out.
- * If nothing happens within UICC_SUBSCRIPTION_TIMEOUT_MS we give up.
- *
- * Submitting SET_UICC_SUBSCRIPTION request when rild doesn't expect
- * it sometimes breaks pretty much everything. Unfortunately, there no
- * reliable way to find out when rild expects it and when it doesn't :/
- */
-#define UICC_SUBSCRIPTION_START_MS    (5000)
-#define UICC_SUBSCRIPTION_TIMEOUT_MS (30000)
-
-/* SIM I/O idle timeout is measured in the number of idle loops.
- * When active SIM I/O is going on, the idle loop count very rarely
- * exceeds 1 between the requests, so 10 is more than enough. Idle
- * loop is actually more accurate criteria than a timeout because
- * it doesn't depend that much on the system load. */
-#define SIM_IO_IDLE_LOOPS (10)
-
 typedef GObjectClass RilSimCardClass;
 typedef struct ril_sim_card RilSimCard;
 
@@ -58,12 +38,7 @@ struct ril_sim_card_priv {
 	GRilIoQueue *q;
 	int flags;
 	guint status_req_id;
-	guint sub_req_id;
-	guint sub_start_timer;
 	gulong event_id[EVENT_COUNT];
-	guint sim_io_idle_id;
-	guint sim_io_idle_count;
-	GHashTable* sim_io_pending;
 };
 
 enum ril_sim_card_signal {
@@ -71,15 +46,13 @@ enum ril_sim_card_signal {
 	SIGNAL_STATUS_CHANGED,
 	SIGNAL_STATE_CHANGED,
 	SIGNAL_APP_CHANGED,
-	SIGNAL_SIM_IO_ACTIVE_CHANGED,
 	SIGNAL_COUNT
 };
 
-#define SIGNAL_STATUS_RECEIVED_NAME         "ril-simcard-status-received"
-#define SIGNAL_STATUS_CHANGED_NAME          "ril-simcard-status-changed"
-#define SIGNAL_STATE_CHANGED_NAME           "ril-simcard-state-changed"
-#define SIGNAL_APP_CHANGED_NAME             "ril-simcard-app-changed"
-#define SIGNAL_SIM_IO_ACTIVE_CHANGED_NAME   "ril-simcard-sim-io-active-changed"
+#define SIGNAL_STATUS_RECEIVED_NAME     "ril-simcard-status-received"
+#define SIGNAL_STATUS_CHANGED_NAME      "ril-simcard-status-changed"
+#define SIGNAL_STATE_CHANGED_NAME       "ril-simcard-state-changed"
+#define SIGNAL_APP_CHANGED_NAME         "ril-simcard-app-changed"
 
 static guint ril_sim_card_signals[SIGNAL_COUNT] = { 0 };
 
@@ -88,13 +61,6 @@ G_DEFINE_TYPE(RilSimCard, ril_sim_card, G_TYPE_OBJECT)
 #define RIL_SIMCARD(obj) (G_TYPE_CHECK_INSTANCE_CAST((obj), \
 	RIL_SIMCARD_TYPE, RilSimCard))
 
-#define NEW_SIGNAL(klass,name) NEW_SIGNAL_(klass,name##_CHANGED)
-#define NEW_SIGNAL_(klass,name) \
-	ril_sim_card_signals[SIGNAL_##name] = \
-		g_signal_new(SIGNAL_##name##_NAME, \
-			G_OBJECT_CLASS_TYPE(klass), G_SIGNAL_RUN_FIRST, \
-			0, NULL, NULL, NULL, G_TYPE_NONE, 0)
-
 #define RIL_SIMCARD_STATE_CHANGED  (0x01)
 #define RIL_SIMCARD_STATUS_CHANGED (0x02)
 
@@ -169,115 +135,29 @@ static void ril_sim_card_status_free(struct ril_sim_card_status *status)
 	}
 }
 
-static void ril_sim_card_tx_start(struct ril_sim_card *self)
-{
-	struct ril_sim_card_priv *priv = self->priv;
-	GRILIO_TRANSACTION_STATE tx_state =
-		grilio_queue_transaction_state(priv->q);
-
-	if (tx_state == GRILIO_TRANSACTION_NONE) {
-		tx_state = grilio_queue_transaction_start(priv->q);
-		DBG("status tx for slot %u %s", self->slot,
-			(tx_state == GRILIO_TRANSACTION_STARTED) ?
-						"started" : "starting");
-	}
-}
-
-static void ril_sim_card_tx_check(struct ril_sim_card *self)
-{
-	struct ril_sim_card_priv *priv = self->priv;
-
-	if (grilio_queue_transaction_state(priv->q) !=
-						GRILIO_TRANSACTION_NONE) {
-		const struct ril_sim_card_status *status = self->status;
-
-		if (status && status->card_state == RIL_CARDSTATE_PRESENT) {
-			/* Transaction (if there is any) is finished when
-			 * both GET_SIM_STATUS and SET_UICC_SUBSCRIPTION
-			 * complete or get dropped */
-			if (!priv->status_req_id && !priv->sub_req_id &&
-				status->gsm_umts_index >= 0 &&
-				status->gsm_umts_index < status->num_apps) {
-				DBG("status tx for slot %u finished",
-								self->slot);
-				grilio_queue_transaction_finish(priv->q);
-			}
-		} else {
-			DBG("status tx for slot %u cancelled", self->slot);
-			grilio_queue_transaction_finish(priv->q);
-		}
-	}
-}
-
-static void ril_sim_card_subscription_done(struct ril_sim_card *self)
-{
-	struct ril_sim_card_priv *priv = self->priv;
-
-	if (priv->sub_start_timer) {
-		/* Don't need this timer anymore */
-		g_source_remove(priv->sub_start_timer);
-		priv->sub_start_timer = 0;
-	}
-	if (priv->sub_req_id) {
-		/* Some RILs never reply to SET_UICC_SUBSCRIPTION requst,
-		 * so we better drop rather than cancel it (so that it gets
-		 * removed from the list of pending requests) */
-		grilio_channel_drop_request(priv->io, priv->sub_req_id);
-		priv->sub_req_id = 0;
-	}
-	ril_sim_card_tx_check(self);
-}
-
-static void ril_sim_card_subscribe_cb(GRilIoChannel* io, int status,
-				const void* data, guint len, void* user_data)
-{
-	struct ril_sim_card *self = RIL_SIMCARD(user_data);
-	struct ril_sim_card_priv *priv = self->priv;
-
-	GASSERT(status == GRILIO_STATUS_OK);
-	GASSERT(priv->sub_req_id);
-	priv->sub_req_id = 0;
-	DBG("UICC subscription OK for slot %u", self->slot);
-	ril_sim_card_subscription_done(self);
-}
-
-static void ril_sim_card_subscribe(struct ril_sim_card *self, int app_index)
+static void ril_sim_card_subscribe(struct ril_sim_card *self,
+						int app_index, int sub_status)
 {
 	struct ril_sim_card_priv *priv = self->priv;
 	GRilIoRequest *req = grilio_request_sized_new(16);
 	const guint sub_id = self->slot;
-	guint code;
 
-	DBG("%u,%d,%u", self->slot, app_index, sub_id);
+	DBG("%u,%d,%u,%d", self->slot, app_index, sub_id, sub_status);
 	grilio_request_append_int32(req, self->slot);
 	grilio_request_append_int32(req, app_index);
 	grilio_request_append_int32(req, sub_id);
-	grilio_request_append_int32(req, RIL_UICC_SUBSCRIPTION_ACTIVATE);
-
-	grilio_request_set_retry(req, 0, -1);
-	grilio_request_set_timeout(req, UICC_SUBSCRIPTION_TIMEOUT_MS);
-	code = (priv->io->ril_version <= 9 &&
+	grilio_request_append_int32(req, sub_status);
+	grilio_queue_send_request(priv->q, req, (priv->io->ril_version <= 9 &&
 		(priv->flags & RIL_SIM_CARD_V9_UICC_SUBSCRIPTION_WORKAROUND)) ?
-			RIL_REQUEST_V9_SET_UICC_SUBSCRIPTION :
-			RIL_REQUEST_SET_UICC_SUBSCRIPTION;
-	if (priv->sub_req_id) {
-		/* Some RILs never reply to SET_UICC_SUBSCRIPTION requst,
-		 * so we better drop rather than cancel it (so that it gets
-		 * removed from the list of pending requests) */
-		grilio_channel_drop_request(priv->io, priv->sub_req_id);
-	}
-
-	/* Don't allow any requests other that GET_SIM_STATUS until
-	 * we are done with the subscription */
-	ril_sim_card_tx_start(self);
-	priv->sub_req_id = grilio_queue_send_request_full(priv->q,
-			req, code, ril_sim_card_subscribe_cb, NULL, self);
+				RIL_REQUEST_V9_SET_UICC_SUBSCRIPTION :
+				RIL_REQUEST_SET_UICC_SUBSCRIPTION);
 	grilio_request_unref(req);
 }
 
 static int ril_sim_card_select_app(const struct ril_sim_card_status *status)
 {
-	int i, selected_app = -1;
+	int selected_app = -1;
+	guint i;
 
 	for (i = 0; i < status->num_apps; i++) {
 		const int type = status->apps[i].app_type;
@@ -303,16 +183,14 @@ static void ril_sim_card_update_app(struct ril_sim_card *self)
 		if (status->gsm_umts_index >= 0 &&
 				status->gsm_umts_index < status->num_apps) {
 			app_index = status->gsm_umts_index;
-			ril_sim_card_subscription_done(self);
 		} else {
 			app_index = ril_sim_card_select_app(status);
-			if (app_index >= 0 && !self->priv->sub_start_timer) {
-				ril_sim_card_subscribe(self, app_index);
+			if (app_index >= 0) {
+				ril_sim_card_subscribe(self, app_index, 1);
 			}
 		}
 	} else {
 		app_index = -1;
-		ril_sim_card_subscription_done(self);
 	}
 
 	if (app_index >= 0 &&
@@ -323,23 +201,11 @@ static void ril_sim_card_update_app(struct ril_sim_card *self)
 	}
 
 	if (!ril_sim_card_app_equal(old_app, self->app)) {
-		g_signal_emit(self, ril_sim_card_signals
-					[SIGNAL_APP_CHANGED], 0);
+		g_signal_emit(self,
+			ril_sim_card_signals[SIGNAL_APP_CHANGED], 0);
 	}
 }
 
-static gboolean ril_sim_card_sub_start_timeout(gpointer user_data)
-{
-	struct ril_sim_card *self = RIL_SIMCARD(user_data);
-	struct ril_sim_card_priv *priv = self->priv;
-
-	DBG("%u", self->slot);
-	GASSERT(priv->sub_start_timer);
-	priv->sub_start_timer = 0;
-	ril_sim_card_update_app(self);
-	return G_SOURCE_REMOVE;
-}
-
 static void ril_sim_card_update_status(struct ril_sim_card *self,
 					struct ril_sim_card_status *status)
 {
@@ -349,42 +215,24 @@ static void ril_sim_card_update_status(struct ril_sim_card *self,
 		struct ril_sim_card_status *old_status = self->status;
 
 		self->status = status;
-		if (diff & RIL_SIMCARD_STATE_CHANGED &&
-				status->card_state == RIL_CARDSTATE_PRESENT) {
-			struct ril_sim_card_priv *priv = self->priv;
-
-			/*
-			 * SIM card has just appeared, give it some time to
-			 * activate the USIM app
-			 */
-			if (priv->sub_start_timer) {
-				g_source_remove(priv->sub_start_timer);
-			}
-			DBG("started subscription timeout for slot %u",
-								self->slot);
-			priv->sub_start_timer =
-				g_timeout_add(UICC_SUBSCRIPTION_START_MS,
-					ril_sim_card_sub_start_timeout, self);
-		}
 		ril_sim_card_update_app(self);
-		g_signal_emit(self, ril_sim_card_signals
-					[SIGNAL_STATUS_RECEIVED], 0);
+		g_signal_emit(self, ril_sim_card_signals[
+						SIGNAL_STATUS_RECEIVED], 0);
 		if (diff & RIL_SIMCARD_STATUS_CHANGED) {
 			DBG("status changed");
-			g_signal_emit(self, ril_sim_card_signals
-					[SIGNAL_STATUS_CHANGED], 0);
+			g_signal_emit(self, ril_sim_card_signals[
+						SIGNAL_STATUS_CHANGED], 0);
 		}
 		if (diff & RIL_SIMCARD_STATE_CHANGED) {
 			DBG("state changed");
-			g_signal_emit(self, ril_sim_card_signals
-					[SIGNAL_STATE_CHANGED], 0);
+			g_signal_emit(self, ril_sim_card_signals[
+						SIGNAL_STATE_CHANGED], 0);
 		}
 		ril_sim_card_status_free(old_status);
 	} else {
-		ril_sim_card_update_app(self);
 		ril_sim_card_status_free(status);
-		g_signal_emit(self, ril_sim_card_signals
-					[SIGNAL_STATUS_RECEIVED], 0);
+		g_signal_emit(self, ril_sim_card_signals[
+						SIGNAL_STATUS_RECEIVED], 0);
 	}
 }
 
@@ -467,8 +315,7 @@ static struct ril_sim_card_status *ril_sim_card_status_parse(const void *data,
 		status->num_apps = num_apps;
 
 		if (num_apps > 0) {
-			status->apps =
-				g_new0(struct ril_sim_card_app, num_apps);
+			status->apps = g_new0(struct ril_sim_card_app, num_apps);
 		}
 
 		for (i = 0; i < num_apps; i++) {
@@ -489,7 +336,6 @@ static struct ril_sim_card_status *ril_sim_card_status_parse(const void *data,
 		}
 
 		if (i == num_apps) {
-			GASSERT(grilio_parser_at_end(&rilp));
 			return status;
 		} else {
 			ril_sim_card_status_free(status);
@@ -501,7 +347,7 @@ static struct ril_sim_card_status *ril_sim_card_status_parse(const void *data,
 static void ril_sim_card_status_cb(GRilIoChannel *io, int ril_status,
 				const void *data, guint len, void *user_data)
 {
-	struct ril_sim_card *self = RIL_SIMCARD(user_data);
+	struct ril_sim_card *self = user_data;
 	struct ril_sim_card_priv *priv = self->priv;
 
 	GASSERT(priv->status_req_id);
@@ -515,128 +361,30 @@ static void ril_sim_card_status_cb(GRilIoChannel *io, int ril_status,
 			ril_sim_card_update_status(self, status);
 		}
 	}
-
-	ril_sim_card_tx_check(self);
-}
-
-void ril_sim_card_reset(struct ril_sim_card *self)
-{
-	if (G_LIKELY(self)) {
-		struct ril_sim_card_status *status =
-			g_new0(struct ril_sim_card_status, 1);
-
-		/* Simulate removal and re-submit the SIM status query */
-		status->card_state = RIL_CARDSTATE_ABSENT;
-		status->gsm_umts_index = -1;
-		status->cdma_index = -1;
-		status->ims_index = -1;
-		ril_sim_card_update_status(self, status);
-		ril_sim_card_request_status(self);
-	}
 }
 
 void ril_sim_card_request_status(struct ril_sim_card *self)
 {
-	if (G_LIKELY(self)) {
-		struct ril_sim_card_priv *priv = self->priv;
+	struct ril_sim_card_priv *priv = self->priv;
 
-		if (priv->status_req_id) {
-			/* Retry right away, don't wait for retry
-			 * timeout to expire */
-			grilio_channel_retry_request(priv->io,
-						priv->status_req_id);
-		} else {
-			GRilIoRequest* req = grilio_request_new();
+	if (priv->status_req_id) {
+		/* Retry right away, don't wait for retry timeout to expire */
+		grilio_channel_retry_request(priv->io, priv->status_req_id);
+	} else {
+		GRilIoRequest* req = grilio_request_new();
 
-			/* Start the transaction to not allow any other
-			 * requests to interfere with SIM status query */
-			ril_sim_card_tx_start(self);
-			grilio_request_set_retry(req, RIL_RETRY_SECS*1000, -1);
-			priv->status_req_id =
-				grilio_queue_send_request_full(priv->q,
+		grilio_request_set_retry(req, RIL_RETRY_SECS*1000, -1);
+		priv->status_req_id = grilio_queue_send_request_full(priv->q,
 					req, RIL_REQUEST_GET_SIM_STATUS,
 					ril_sim_card_status_cb, NULL, self);
-			grilio_request_unref(req);
-		}
-	}
-}
-
-static void ril_sim_card_update_sim_io_active(struct ril_sim_card *self)
-{
-	/* SIM I/O is considered active for certain period of time after
-	 * the last request has completed. That's because SIM_IO requests
-	 * are usually submitted in large quantities and quick succession.
-	 * Some RILs don't like being bothered while they are doing SIM I/O
-	 * and some time after that too. That sucks but what else can we
-	 * do about it? */
-	struct ril_sim_card_priv *priv = self->priv;
-	const gboolean active = priv->sim_io_idle_id ||
-		g_hash_table_size(priv->sim_io_pending);
-
-	if (self->sim_io_active != active) {
-		self->sim_io_active = active;
-		DBG("SIM I/O for slot %u is %sactive", self->slot,
-						active ? "" : "in");
-		g_signal_emit(self, ril_sim_card_signals
-					[SIGNAL_SIM_IO_ACTIVE_CHANGED], 0);
-	}
-}
-
-void ril_sim_card_sim_io_started(struct ril_sim_card *self, guint id)
-{
-	if (G_LIKELY(self) && G_LIKELY(id)) {
-		struct ril_sim_card_priv *priv = self->priv;
-		gpointer key = GINT_TO_POINTER(id);
-
-		g_hash_table_insert(priv->sim_io_pending, key, key);
-		if (priv->sim_io_idle_id) {
-			g_source_remove(priv->sim_io_idle_id);
-			priv->sim_io_idle_id = 0;
-			priv->sim_io_idle_count = 0;
-		}
-		ril_sim_card_update_sim_io_active(self);
-	}
-}
-
-static gboolean ril_sim_card_sim_io_idle_cb(gpointer user_data)
-{
-	struct ril_sim_card *self = RIL_SIMCARD(user_data);
-	struct ril_sim_card_priv *priv = self->priv;
-
-	if (++(priv->sim_io_idle_count) >= SIM_IO_IDLE_LOOPS) {
-		priv->sim_io_idle_id = 0;
-		priv->sim_io_idle_count = 0;
-		ril_sim_card_update_sim_io_active(self);
-		return G_SOURCE_REMOVE;
-	} else {
-		return G_SOURCE_CONTINUE;
-	}
-}
-
-void ril_sim_card_sim_io_finished(struct ril_sim_card *self, guint id)
-{
-	if (G_LIKELY(self) && G_LIKELY(id)) {
-		struct ril_sim_card_priv *priv = self->priv;
-		gpointer key = GINT_TO_POINTER(id);
-
-		if (g_hash_table_remove(priv->sim_io_pending, key) &&
-				!g_hash_table_size(priv->sim_io_pending)) {
-			/* Reset the idle loop count */
-			if (priv->sim_io_idle_id) {
-				g_source_remove(priv->sim_io_idle_id);
-				priv->sim_io_idle_count = 0;
-			}
-			priv->sim_io_idle_id =
-				g_idle_add(ril_sim_card_sim_io_idle_cb, self);
-		}
-		ril_sim_card_update_sim_io_active(self);
+		grilio_request_unref(req);
 	}
 }
 
 static void ril_sim_card_status_changed(GRilIoChannel *io, guint code,
 				const void *data, guint len, void *user_data)
 {
-	struct ril_sim_card *self = RIL_SIMCARD(user_data);
+	struct ril_sim_card *self = user_data;
 
 	ril_sim_card_request_status(self);
 }
@@ -724,13 +472,6 @@ gulong ril_sim_card_add_app_changed_handler(struct ril_sim_card *self,
 		SIGNAL_APP_CHANGED_NAME, G_CALLBACK(cb), arg) : 0;
 }
 
-gulong ril_sim_card_add_sim_io_active_changed_handler(struct ril_sim_card *self,
-					ril_sim_card_cb_t cb, void *arg)
-{
-	return (G_LIKELY(self) && G_LIKELY(cb)) ? g_signal_connect(self,
-		SIGNAL_SIM_IO_ACTIVE_CHANGED_NAME, G_CALLBACK(cb), arg) : 0;
-}
-
 void ril_sim_card_remove_handler(struct ril_sim_card *self, gulong id)
 {
 	if (G_LIKELY(self) && G_LIKELY(id)) {
@@ -745,11 +486,8 @@ void ril_sim_card_remove_handlers(struct ril_sim_card *self, gulong *ids, int n)
 
 static void ril_sim_card_init(struct ril_sim_card *self)
 {
-	struct ril_sim_card_priv *priv = G_TYPE_INSTANCE_GET_PRIVATE(self,
-				RIL_SIMCARD_TYPE, struct ril_sim_card_priv);
-
-	self->priv = priv;
-	priv->sim_io_pending = g_hash_table_new(g_direct_hash, g_direct_equal);
+	self->priv = G_TYPE_INSTANCE_GET_PRIVATE(self, RIL_SIMCARD_TYPE,
+						struct ril_sim_card_priv);
 }
 
 static void ril_sim_card_dispose(GObject *object)
@@ -767,13 +505,6 @@ static void ril_sim_card_finalize(GObject *object)
 	struct ril_sim_card *self = RIL_SIMCARD(object);
 	struct ril_sim_card_priv *priv = self->priv;
 
-	if (priv->sim_io_idle_id) {
-		g_source_remove(priv->sim_io_idle_id);
-	}
-	if (priv->sub_start_timer) {
-		g_source_remove(priv->sub_start_timer);
-	}
-	g_hash_table_destroy(priv->sim_io_pending);
 	grilio_channel_unref(priv->io);
 	grilio_queue_unref(priv->q);
 	ril_sim_card_status_free(self->status);
@@ -787,11 +518,22 @@ static void ril_sim_card_class_init(RilSimCardClass *klass)
 	object_class->dispose = ril_sim_card_dispose;
 	object_class->finalize = ril_sim_card_finalize;
 	g_type_class_add_private(klass, sizeof(struct ril_sim_card_priv));
-	NEW_SIGNAL_(klass,STATUS_RECEIVED);
-	NEW_SIGNAL(klass,STATUS);
-	NEW_SIGNAL(klass,STATE);
-	NEW_SIGNAL(klass,APP);
-	NEW_SIGNAL(klass,SIM_IO_ACTIVE);
+	ril_sim_card_signals[SIGNAL_STATUS_RECEIVED] =
+		g_signal_new(SIGNAL_STATUS_RECEIVED_NAME,
+			G_OBJECT_CLASS_TYPE(klass), G_SIGNAL_RUN_FIRST,
+			0, NULL, NULL, NULL, G_TYPE_NONE, 0);
+	ril_sim_card_signals[SIGNAL_STATUS_CHANGED] =
+		g_signal_new(SIGNAL_STATUS_CHANGED_NAME,
+			G_OBJECT_CLASS_TYPE(klass), G_SIGNAL_RUN_FIRST,
+			0, NULL, NULL, NULL, G_TYPE_NONE, 0);
+	ril_sim_card_signals[SIGNAL_STATE_CHANGED] =
+		g_signal_new(SIGNAL_STATE_CHANGED_NAME,
+			G_OBJECT_CLASS_TYPE(klass), G_SIGNAL_RUN_FIRST,
+			0, NULL, NULL, NULL, G_TYPE_NONE, 0);
+	ril_sim_card_signals[SIGNAL_APP_CHANGED] =
+		g_signal_new(SIGNAL_APP_CHANGED_NAME,
+			G_OBJECT_CLASS_TYPE(klass), G_SIGNAL_RUN_FIRST,
+			0, NULL, NULL, NULL, G_TYPE_NONE, 0);
 }
 
 /*

ofono/drivers/ril/ril_sim_card.h

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2018 Jolla Ltd.
+ *  Copyright (C) 2015-2017 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -18,8 +18,6 @@
 
 #include "ril_types.h"
 
-#include <glib-object.h>
-
 struct ril_sim_card_app {
 	enum ril_app_type app_type;
 	enum ril_app_state app_state;
@@ -46,7 +44,6 @@ struct ril_sim_card {
 	struct ril_sim_card_priv *priv;
 	struct ril_sim_card_status *status;
 	const struct ril_sim_card_app *app;
-	gboolean sim_io_active;
 	guint slot;
 };
 
@@ -58,10 +55,7 @@ typedef void (*ril_sim_card_cb_t)(struct ril_sim_card *sc, void *arg);
 struct ril_sim_card *ril_sim_card_new(GRilIoChannel *io, guint slot, int flags);
 struct ril_sim_card *ril_sim_card_ref(struct ril_sim_card *sc);
 void ril_sim_card_unref(struct ril_sim_card *sc);
-void ril_sim_card_reset(struct ril_sim_card *sc);
-void ril_sim_card_request_status(struct ril_sim_card *sc);
-void ril_sim_card_sim_io_started(struct ril_sim_card *sc, guint id);
-void ril_sim_card_sim_io_finished(struct ril_sim_card *sc, guint id);
+void ril_sim_card_request_status(struct ril_sim_card *self);
 gboolean ril_sim_card_ready(struct ril_sim_card *sc);
 gulong ril_sim_card_add_status_received_handler(struct ril_sim_card *sc,
 					ril_sim_card_cb_t cb, void *arg);
@@ -71,19 +65,13 @@ gulong ril_sim_card_add_state_changed_handler(struct ril_sim_card *sc,
 					ril_sim_card_cb_t cb, void *arg);
 gulong ril_sim_card_add_app_changed_handler(struct ril_sim_card *sc,
 					ril_sim_card_cb_t cb, void *arg);
-gulong ril_sim_card_add_sim_io_active_changed_handler(struct ril_sim_card *sc,
-					ril_sim_card_cb_t cb, void *arg);
 void ril_sim_card_remove_handler(struct ril_sim_card *sc, gulong id);
 void ril_sim_card_remove_handlers(struct ril_sim_card *sc, gulong *ids, int n);
 
 /* Inline wrappers */
-static inline enum ril_app_type ril_sim_card_app_type(struct ril_sim_card *sc)
+static inline enum ril_app_type
+ril_sim_card_app_type(struct ril_sim_card *sc)
 	{ return (sc && sc->app) ? sc->app->app_type : RIL_APPTYPE_UNKNOWN; }
-static inline const char *ril_sim_card_app_aid(struct ril_sim_card *sc)
-	{ return (sc && sc->app) ? sc->app->aid : NULL; }
-
-#define ril_sim_card_remove_all_handlers(net, ids) \
-	ril_sim_card_remove_handlers(net, ids, G_N_ELEMENTS(ids))
 
 #endif /* RIL_SIM_CARD_H */
 

ofono/drivers/ril/ril_sim_info.c

@@ -0,0 +1,668 @@
+/*
+ *  oFono - Open Source Telephony - RIL-based devices
+ *
+ *  Copyright (C) 2016 Jolla Ltd.
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License version 2 as
+ *  published by the Free Software Foundation.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ */
+
+#include "ril_sim_info.h"
+#include "ril_network.h"
+#include "ril_log.h"
+
+#include <ofono/sim.h>
+
+#include "ofono.h"
+#include "storage.h"
+
+#define RIL_SIM_INFO_STORE          "cache"
+#define RIL_SIM_INFO_STORE_GROUP    "sim"
+#define RIL_SIM_INFO_STORE_SPN      "spn"
+
+/* ICCID -> IMSI map */
+#define RIL_SIM_ICCID_MAP           "iccidmap"
+#define RIL_SIM_ICCID_MAP_IMSI      "imsi"
+
+#define RIL_SIM_DEFAULT_SPN_BUFSIZE 8
+G_STATIC_ASSERT(RIL_SIM_DEFAULT_SPN_BUFSIZE >= \
+	OFONO_MAX_MCC_LENGTH + OFONO_MAX_MNC_LENGTH + 1);
+
+typedef GObjectClass RilSimInfoClass;
+typedef struct ril_sim_info RilSimInfo;
+
+typedef void (*ril_sim_info_remove_cb_t)(struct ofono_sim *sim,
+							unsigned int id);
+typedef void (*ril_sim_info_set_value_cb_t)(struct ril_sim_info *info,
+							const char *value);
+
+struct ril_sim_info_watch {
+	ril_sim_info_set_value_cb_t set_value;
+	ril_sim_info_remove_cb_t remove;
+	struct ril_sim_info *info;
+	unsigned int id;
+};
+
+struct ril_sim_info_priv {
+	char *log_prefix;
+	char *iccid;
+	char *imsi;
+	char *cached_spn;
+	char *sim_spn;
+	char *public_spn;
+	char default_spn[RIL_SIM_DEFAULT_SPN_BUFSIZE];
+	int public_spn_block;
+	struct ofono_sim *sim;
+	struct ril_sim_info_watch state_watch;
+	struct ril_sim_info_watch iccid_watch;
+	struct ril_sim_info_watch imsi_watch;
+	struct ril_sim_info_watch spn_watch;
+	struct ril_network *network;
+	gulong network_operator_changed_id;
+	gboolean update_imsi_cache;
+	gboolean update_iccid_map;
+};
+
+enum ril_sim_info_signal {
+	SIGNAL_ICCID_CHANGED,
+	SIGNAL_IMSI_CHANGED,
+	SIGNAL_SPN_CHANGED,
+	SIGNAL_COUNT
+};
+
+#define SIGNAL_ICCID_CHANGED_NAME   "ril-sim-info-iccid-changed"
+#define SIGNAL_IMSI_CHANGED_NAME    "ril-sim-info-imsi-changed"
+#define SIGNAL_SPN_CHANGED_NAME     "ril-sim-info-spn-changed"
+
+static guint ril_sim_info_signals[SIGNAL_COUNT] = { 0 };
+
+G_DEFINE_TYPE(RilSimInfo, ril_sim_info, G_TYPE_OBJECT)
+#define RIL_SIMINFO_TYPE (ril_sim_info_get_type())
+#define RIL_SIMINFO(obj) (G_TYPE_CHECK_INSTANCE_CAST((obj),\
+	RIL_SIMINFO_TYPE, RilSimInfo))
+
+#define NEW_SIGNAL(klass,name) \
+	ril_sim_info_signals[SIGNAL_##name##_CHANGED] = \
+		g_signal_new(SIGNAL_##name##_CHANGED_NAME, \
+			G_OBJECT_CLASS_TYPE(klass), G_SIGNAL_RUN_FIRST, \
+			0, NULL, NULL, NULL, G_TYPE_NONE, 0)
+
+#define DBG_(info,fmt,args...) DBG("%s" fmt, (info)->priv->log_prefix, ##args)
+
+static void ril_sim_info_signal_emit(struct ril_sim_info *self,
+						enum ril_sim_info_signal id)
+{
+	g_signal_emit(self, ril_sim_info_signals[id], 0);
+}
+
+static void ril_sim_info_watch_remove(struct ril_sim_info_watch *watch)
+{
+	if (watch->id) {
+		struct ril_sim_info_priv *priv = watch->info->priv;
+
+		GASSERT(priv->sim);
+		if (priv->sim) {
+			watch->remove(priv->sim, watch->id);
+			GASSERT(!watch->id);
+		}
+
+		watch->id = 0;
+	}
+
+	if (watch->set_value) {
+		watch->set_value(watch->info, NULL);
+	}
+}
+
+static void ril_sim_info_remove_spn_watch(struct ofono_sim *sim,
+							unsigned int id)
+{
+	ofono_sim_remove_spn_watch(sim, &id);
+}
+
+static void ril_sim_info_update_imsi_cache(struct ril_sim_info *self)
+{
+	struct ril_sim_info_priv *priv = self->priv;
+
+	if (priv->update_imsi_cache && priv->imsi && priv->imsi[0] &&
+				priv->cached_spn && priv->cached_spn[0]) {
+		gboolean save = FALSE;
+		const char *store = RIL_SIM_INFO_STORE;
+		GKeyFile *cache = storage_open(priv->imsi, store);
+		char *spn = g_key_file_get_string(cache,
+					RIL_SIM_INFO_STORE_GROUP,
+					RIL_SIM_INFO_STORE_SPN, NULL);
+
+		if (g_strcmp0(priv->cached_spn, spn)) {
+			save = TRUE;
+			g_key_file_set_string(cache, RIL_SIM_INFO_STORE_GROUP,
+				RIL_SIM_INFO_STORE_SPN, priv->cached_spn);
+		}
+
+		/*
+		 * Since we are most likely running on flash which
+		 * supports a limited number of writes, don't overwrite
+		 * the file unless something has actually changed.
+		 */
+		if (save) {
+			DBG_(self, "updating " STORAGEDIR "/%s/%s",
+							priv->imsi, store);
+			storage_close(priv->imsi, store, cache, TRUE);
+		} else {
+			g_key_file_free(cache);
+		}
+
+		g_free(spn);
+		priv->update_imsi_cache = FALSE;
+	}
+}
+
+static void ril_sim_info_update_iccid_map(struct ril_sim_info *self)
+{
+	struct ril_sim_info_priv *priv = self->priv;
+
+	if (priv->update_iccid_map && priv->iccid && priv->iccid[0] &&
+						priv->imsi && priv->imsi[0]) {
+		const char *store = RIL_SIM_ICCID_MAP;
+		GKeyFile *map = storage_open(NULL, store);
+		char *imsi = g_key_file_get_string(map, RIL_SIM_ICCID_MAP_IMSI,
+							priv->iccid, NULL);
+
+		/*
+		 * Since we are most likely running on flash which
+		 * supports a limited number of writes, don't overwrite
+		 * the file unless something has actually changed.
+		 */
+		if (g_strcmp0(imsi, priv->imsi)) {
+			DBG_(self, "updating " STORAGEDIR "/%s", store);
+			g_key_file_set_string(map, RIL_SIM_ICCID_MAP_IMSI,
+						priv->iccid, priv->imsi);
+			storage_close(NULL, store, map, TRUE);
+		} else {
+			g_key_file_free(map);
+		}
+
+		g_free(imsi);
+		priv->update_iccid_map = FALSE;
+	}
+}
+
+static void ril_sim_info_set_imsi(struct ril_sim_info *self, const char *imsi)
+{
+	struct ril_sim_info_priv *priv = self->priv;
+
+	if (g_strcmp0(priv->imsi, imsi)) {
+		g_free(priv->imsi);
+		self->imsi = priv->imsi = g_strdup(imsi);
+		priv->update_iccid_map = TRUE;
+		ril_sim_info_update_iccid_map(self);
+		ril_sim_info_update_imsi_cache(self);
+		ril_sim_info_signal_emit(self, SIGNAL_IMSI_CHANGED);
+	}
+}
+
+static void ril_sim_info_update_public_spn(struct ril_sim_info *self)
+{
+	struct ril_sim_info_priv *priv = self->priv;
+
+	GASSERT(priv->public_spn_block >= 0);
+	if (!priv->public_spn_block) {
+		const char *spn = priv->sim_spn ? priv->sim_spn :
+				priv->cached_spn ? priv->cached_spn :
+				priv->default_spn;
+
+		if (g_strcmp0(priv->public_spn, spn)) {
+			g_free(priv->public_spn);
+			self->spn = priv->public_spn = g_strdup(spn);
+			ril_sim_info_signal_emit(self, SIGNAL_SPN_CHANGED);
+		}
+	}
+}
+
+static void ril_sim_info_set_cached_spn(struct ril_sim_info *self,
+							const char *spn)
+{
+	struct ril_sim_info_priv *priv = self->priv;
+
+	if (g_strcmp0(priv->cached_spn, spn)) {
+		g_free(priv->cached_spn);
+		if (spn) {
+			DBG_(self, "cached spn \"%s\"", spn);
+			priv->cached_spn = g_strdup(spn);
+			priv->update_imsi_cache = TRUE;
+			ril_sim_info_update_imsi_cache(self);
+		} else {
+			priv->cached_spn = NULL;
+		}
+		ril_sim_info_update_public_spn(self);
+	}
+}
+
+static void ril_sim_info_set_sim_spn(struct ril_sim_info *self,
+							const char *spn)
+{
+	struct ril_sim_info_priv *priv = self->priv;
+
+	if (g_strcmp0(priv->sim_spn, spn)) {
+		g_free(priv->sim_spn);
+		priv->sim_spn = g_strdup(spn);
+		priv->update_imsi_cache = TRUE;
+		ril_sim_info_set_cached_spn(self, spn);
+		ril_sim_info_update_imsi_cache(self);
+		ril_sim_info_update_public_spn(self);
+	}
+}
+
+static void ril_sim_info_update_default_spn(struct ril_sim_info *self)
+{
+	struct ril_sim_info_priv *priv = self->priv;
+	char buf[RIL_SIM_DEFAULT_SPN_BUFSIZE];
+	const char *mcc = NULL;
+	const char *mnc = NULL;
+
+	if (priv->sim &&
+		ofono_sim_get_state(priv->sim) == OFONO_SIM_STATE_READY) {
+		mcc = ofono_sim_get_mcc(priv->sim);
+		mnc = ofono_sim_get_mnc(priv->sim);
+	}
+
+	if (mcc && mnc) {
+		snprintf(buf, RIL_SIM_DEFAULT_SPN_BUFSIZE, "%s%s", mcc, mnc);
+		buf[RIL_SIM_DEFAULT_SPN_BUFSIZE - 1] = 0;
+	} else {
+		buf[0] = 0;
+	}
+
+	if (strcmp(buf, priv->default_spn)) {
+		strncpy(priv->default_spn, buf, RIL_SIM_DEFAULT_SPN_BUFSIZE);
+		DBG_(self, "default spn \"%s\"", priv->default_spn);
+		ril_sim_info_update_public_spn(self);
+	}
+}
+
+static void ril_sim_info_network_check(struct ril_sim_info *self)
+{
+	struct ril_sim_info_priv *priv = self->priv;
+
+	if (priv->network && priv->network->operator && priv->sim &&
+		ofono_sim_get_state(priv->sim) == OFONO_SIM_STATE_READY) {
+		const char *mcc = ofono_sim_get_mcc(priv->sim);
+		const char *mnc = ofono_sim_get_mnc(priv->sim);
+		const struct ofono_network_operator *op =
+						priv->network->operator;
+
+		if (mcc && mcc[0] && !strcmp(mcc, op->mcc) &&
+				mnc && mnc[0] && !strcmp(mnc, op->mnc)) {
+
+			/*
+			 * If EFspn is present then sim_spn should be set
+			 * before we get registered with the network.
+			 */
+			DBG_(self, "home network \"%s\"", op->name);
+			if (!priv->sim_spn) {
+				ril_sim_info_set_cached_spn(self, op->name);
+			}
+		}
+	}
+}
+
+static void ril_sim_info_network_operator_changed(struct ril_network *network,
+							void *user_data)
+{
+	struct ril_sim_info *self = RIL_SIMINFO(user_data);
+
+	DBG_(self, "");
+	ril_sim_info_network_check(self);
+}
+
+static void ril_sim_info_load_cache(struct ril_sim_info *self)
+{
+	struct ril_sim_info_priv *priv = self->priv;
+
+	if (priv->iccid && priv->iccid[0]) {
+		GKeyFile *map = storage_open(NULL, RIL_SIM_ICCID_MAP);
+		char *imsi = g_key_file_get_string(map, RIL_SIM_ICCID_MAP_IMSI,
+							priv->iccid, NULL);
+		g_key_file_free(map);
+
+		if (imsi && imsi[0] && g_strcmp0(priv->imsi, imsi)) {
+			if (priv->imsi && priv->imsi[0]) {
+				/* Need to update ICCID -> IMSI map */
+				DBG_(self, "IMSI changed %s -> %s",
+							priv->imsi, imsi);
+				priv->update_imsi_cache = TRUE;
+			}
+			g_free(priv->imsi);
+			self->imsi = priv->imsi = imsi;
+			DBG_(self, "imsi[%s] = %s", priv->iccid, imsi);
+			ril_sim_info_update_iccid_map(self);
+			ril_sim_info_signal_emit(self, SIGNAL_IMSI_CHANGED);
+		} else if (imsi) {
+			g_free(imsi);
+		} else {
+			DBG_(self, "no imsi for iccid %s", priv->iccid);
+		}
+	}
+
+	if (priv->imsi && priv->imsi[0]) {
+		GKeyFile *cache = storage_open(priv->imsi, RIL_SIM_INFO_STORE);
+		char *spn = g_key_file_get_string(cache,
+					RIL_SIM_INFO_STORE_GROUP,
+					RIL_SIM_INFO_STORE_SPN, NULL);
+		g_key_file_free(cache);
+
+		if (spn && spn[0] && g_strcmp0(priv->cached_spn, spn)) {
+			if (priv->cached_spn && priv->cached_spn[0]) {
+				/* Need to update the cache file */
+				DBG_(self, "spn changing %s -> %s",
+						priv->cached_spn, spn);
+				priv->update_imsi_cache = TRUE;
+			}
+			g_free(priv->cached_spn);
+			priv->cached_spn = spn;
+			DBG_(self, "spn[%s] = \"%s\"", priv->imsi, spn);
+			ril_sim_info_update_imsi_cache(self);
+			ril_sim_info_update_public_spn(self);
+		} else if (spn) {
+			g_free(spn);
+		} else {
+			DBG_(self, "no spn for imsi %s", priv->imsi);
+		}
+	}
+}
+
+static void ril_sim_info_set_iccid(struct ril_sim_info *self, const char *iccid)
+{
+	struct ril_sim_info_priv *priv = self->priv;
+
+	if (g_strcmp0(priv->iccid, iccid)) {
+		g_free(priv->iccid);
+		self->iccid = priv->iccid = g_strdup(iccid);
+		ril_sim_info_signal_emit(self, SIGNAL_ICCID_CHANGED);
+		if (iccid) {
+			ril_sim_info_load_cache(self);
+		}
+	}
+}
+
+static void ril_sim_info_imsi_watch_cb(const char *imsi, void *data)
+{
+	struct ril_sim_info_watch *watch = data;
+
+	DBG_(watch->info, "%s", imsi);
+	ril_sim_info_set_imsi(watch->info, imsi);
+}
+
+static void ril_sim_info_spn_watch_cb(const char *spn, const char *dc,
+								void *data)
+{
+	struct ril_sim_info_watch *watch = data;
+
+	DBG_(watch->info, "%s", spn);
+	ril_sim_info_set_sim_spn(watch->info, spn);
+}
+
+static void ril_sim_info_iccid_watch_cb(const char *iccid, void *data)
+{
+	struct ril_sim_info_watch *watch = data;
+
+	DBG_(watch->info, "%s", iccid);
+	ril_sim_info_set_iccid(watch->info, iccid);
+}
+
+static void ril_sim_info_watch_done(void *data)
+{
+	struct ril_sim_info_watch *watch = data;
+
+	GASSERT(watch->id);
+	watch->id = 0;
+}
+
+static void ril_sim_info_handle_sim_state(struct ril_sim_info *self,
+						enum ofono_sim_state state)
+{
+	struct ril_sim_info_priv *priv = self->priv;
+	struct ril_sim_info_watch *watch;
+
+	DBG_(self, "%d", state);
+
+	switch (state) {
+	case OFONO_SIM_STATE_READY:
+		/* SPN */
+		watch = &priv->spn_watch;
+		if (!watch->id) {
+			ofono_sim_add_spn_watch(priv->sim, &watch->id,
+					ril_sim_info_spn_watch_cb, watch,
+					ril_sim_info_watch_done);
+			GASSERT(priv->spn_watch.id);
+		}
+		/* IMSI */
+		watch = &priv->imsi_watch;
+		if (!watch->id) {
+			watch->id = ofono_sim_add_imsi_watch(priv->sim,
+					ril_sim_info_imsi_watch_cb, watch,
+					ril_sim_info_watch_done);
+			GASSERT(watch->id);
+		}
+		/* no break */
+	case OFONO_SIM_STATE_INSERTED:
+	case OFONO_SIM_STATE_LOCKED_OUT:
+		/* ICCID */
+		watch = &priv->iccid_watch;
+		if (!watch->id) {
+			watch->id = ofono_sim_add_iccid_watch(priv->sim,
+					ril_sim_info_iccid_watch_cb, watch,
+					ril_sim_info_watch_done);
+			GASSERT(watch->id);
+		}
+		break;
+	case OFONO_SIM_STATE_NOT_PRESENT:
+	case OFONO_SIM_STATE_RESETTING:
+		ril_sim_info_watch_remove(&priv->spn_watch);
+		ril_sim_info_watch_remove(&priv->imsi_watch);
+		ril_sim_info_watch_remove(&priv->iccid_watch);
+		break;
+	}
+
+	ril_sim_info_update_default_spn(self);
+	ril_sim_info_network_check(self);
+}
+
+static void ril_sim_info_state_watch_cb(enum ofono_sim_state new_state,
+								void *data)
+{
+	struct ril_sim_info_watch *watch = data;
+	ril_sim_info_handle_sim_state(watch->info, new_state);
+}
+
+struct ril_sim_info *ril_sim_info_new(const char *log_prefix)
+{
+	struct ril_sim_info *self = g_object_new(RIL_SIMINFO_TYPE, NULL);
+
+	self->priv->log_prefix = (log_prefix && log_prefix[0]) ?
+		g_strconcat(log_prefix, " ", NULL) : g_strdup("");
+	return self;
+}
+
+struct ril_sim_info *ril_sim_info_ref(struct ril_sim_info *self)
+{
+	if (G_LIKELY(self)) {
+		g_object_ref(RIL_SIMINFO(self));
+		return self;
+	} else {
+		return NULL;
+	}
+}
+
+void ril_sim_info_unref(struct ril_sim_info *self)
+{
+	if (G_LIKELY(self)) {
+		g_object_unref(RIL_SIMINFO(self));
+	}
+}
+
+void ril_sim_info_set_ofono_sim(struct ril_sim_info *self,
+						struct ofono_sim *sim)
+{
+	if (G_LIKELY(self)) {
+		struct ril_sim_info_priv *priv = self->priv;
+
+		if (priv->sim != sim) {
+			priv->public_spn_block++;
+			ril_sim_info_watch_remove(&priv->state_watch);
+			ril_sim_info_watch_remove(&priv->iccid_watch);
+			ril_sim_info_watch_remove(&priv->imsi_watch);
+			ril_sim_info_watch_remove(&priv->spn_watch);
+
+			priv->update_imsi_cache = FALSE;
+			priv->update_iccid_map = FALSE;
+			priv->sim = sim;
+
+			if (sim) {
+				priv->state_watch.id =
+					ofono_sim_add_state_watch(sim,
+						ril_sim_info_state_watch_cb,
+						&priv->state_watch,
+						ril_sim_info_watch_done);
+				GASSERT(priv->state_watch.id);
+				DBG_(self, "attached to sim");
+				ril_sim_info_handle_sim_state(self,
+						ofono_sim_get_state(sim));
+			} else {
+				DBG_(self, "detached from sim");
+				ril_sim_info_update_default_spn(self);
+				ril_sim_info_network_check(self);
+			}
+
+			priv->public_spn_block--;
+			ril_sim_info_update_public_spn(self);
+		}
+	}
+}
+
+void ril_sim_info_set_network(struct ril_sim_info *self,
+					struct ril_network *network)
+{
+	if (G_LIKELY(self) && self->priv->network != network) {
+		struct ril_sim_info_priv *priv = self->priv;
+
+		if (priv->network) {
+			ril_network_remove_handlers(priv->network,
+				&priv->network_operator_changed_id, 1);
+			ril_network_unref(priv->network);
+		}
+		if (network) {
+			priv->network_operator_changed_id =
+				ril_network_add_operator_changed_handler(network,
+					ril_sim_info_network_operator_changed,
+					self);
+			priv->network = ril_network_ref(network);
+			ril_sim_info_network_check(self);
+		} else {
+			priv->network = NULL;
+		}
+	}
+}
+
+gulong ril_sim_info_add_iccid_changed_handler(struct ril_sim_info *self,
+					ril_sim_info_cb_t cb, void *arg)
+{
+	return (G_LIKELY(self) && G_LIKELY(cb)) ? g_signal_connect(self,
+		SIGNAL_ICCID_CHANGED_NAME, G_CALLBACK(cb), arg) : 0;
+}
+
+gulong ril_sim_info_add_imsi_changed_handler(struct ril_sim_info *self,
+					ril_sim_info_cb_t cb, void *arg)
+{
+	return (G_LIKELY(self) && G_LIKELY(cb)) ? g_signal_connect(self,
+		SIGNAL_IMSI_CHANGED_NAME, G_CALLBACK(cb), arg) : 0;
+}
+
+gulong ril_sim_info_add_spn_changed_handler(struct ril_sim_info *self,
+					ril_sim_info_cb_t cb, void *arg)
+{
+	return (G_LIKELY(self) && G_LIKELY(cb)) ? g_signal_connect(self,
+		SIGNAL_SPN_CHANGED_NAME, G_CALLBACK(cb), arg) : 0;
+}
+
+void ril_sim_info_remove_handler(struct ril_sim_info *self, gulong id)
+{
+	if (G_LIKELY(self) && G_LIKELY(id)) {
+		g_signal_handler_disconnect(self, id);
+	}
+}
+
+static void ril_sim_info_watch_init(struct ril_sim_info *self,
+				    struct ril_sim_info_watch *watch,
+				    ril_sim_info_set_value_cb_t set_value,
+				    ril_sim_info_remove_cb_t remove)
+{
+	watch->info = self;
+	watch->set_value = set_value;
+	watch->remove = remove;
+}
+
+static void ril_sim_info_init(struct ril_sim_info *self)
+{
+	struct ril_sim_info_priv *priv = G_TYPE_INSTANCE_GET_PRIVATE(self,
+				RIL_SIMINFO_TYPE, struct ril_sim_info_priv);
+
+	self->priv = priv;
+	ril_sim_info_watch_init(self, &priv->state_watch,
+		NULL, ofono_sim_remove_state_watch);
+	ril_sim_info_watch_init(self, &priv->iccid_watch,
+		ril_sim_info_set_iccid, ofono_sim_remove_iccid_watch);
+	ril_sim_info_watch_init(self, &priv->imsi_watch,
+		ril_sim_info_set_imsi, ofono_sim_remove_imsi_watch);
+	ril_sim_info_watch_init(self, &priv->spn_watch,
+		ril_sim_info_set_sim_spn, ril_sim_info_remove_spn_watch);
+}
+
+static void ril_sim_info_dispose(GObject *object)
+{
+	struct ril_sim_info *self = RIL_SIMINFO(object);
+
+	ril_sim_info_set_ofono_sim(self, NULL);
+	ril_sim_info_set_network(self, NULL);
+	G_OBJECT_CLASS(ril_sim_info_parent_class)->dispose(object);
+}
+
+static void ril_sim_info_finalize(GObject *object)
+{
+	struct ril_sim_info *self = RIL_SIMINFO(object);
+	struct ril_sim_info_priv *priv = self->priv;
+
+	g_free(priv->log_prefix);
+	g_free(priv->cached_spn);
+	g_free(priv->public_spn);
+	GASSERT(!priv->iccid);
+	GASSERT(!priv->imsi);
+	GASSERT(!priv->sim_spn);
+	G_OBJECT_CLASS(ril_sim_info_parent_class)->finalize(object);
+}
+
+static void ril_sim_info_class_init(RilSimInfoClass *klass)
+{
+	GObjectClass *object_class = G_OBJECT_CLASS(klass);
+
+	object_class->dispose = ril_sim_info_dispose;
+	object_class->finalize = ril_sim_info_finalize;
+	g_type_class_add_private(klass, sizeof(struct ril_sim_info_priv));
+	NEW_SIGNAL(klass, ICCID);
+	NEW_SIGNAL(klass, IMSI);
+	NEW_SIGNAL(klass, SPN);
+}
+
+/*
+ * Local Variables:
+ * mode: C
+ * c-basic-offset: 8
+ * indent-tabs-mode: t
+ * End:
+ */

ofono/drivers/ril/ril_sim_info.h

@@ -0,0 +1,53 @@
+/*
+ *  oFono - Open Source Telephony - RIL-based devices
+ *
+ *  Copyright (C) 2016 Jolla Ltd.
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License version 2 as
+ *  published by the Free Software Foundation.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ */
+
+#ifndef RIL_SIM_INFO_H
+#define RIL_SIM_INFO_H
+
+#include "ril_types.h"
+
+struct ril_sim_info {
+	GObject object;
+	struct ril_sim_info_priv *priv;
+	const char *iccid;
+	const char *imsi;
+	const char *spn;
+};
+
+struct ofono_sim;
+typedef void (*ril_sim_info_cb_t)(struct ril_sim_info *info, void *arg);
+
+struct ril_sim_info *ril_sim_info_new(const char *log_prefix);
+struct ril_sim_info *ril_sim_info_ref(struct ril_sim_info *info);
+void ril_sim_info_unref(struct ril_sim_info *si);
+void ril_sim_info_set_ofono_sim(struct ril_sim_info *si, struct ofono_sim *sim);
+void ril_sim_info_set_network(struct ril_sim_info *si, struct ril_network *net);
+gulong ril_sim_info_add_iccid_changed_handler(struct ril_sim_info *si,
+					ril_sim_info_cb_t cb, void *arg);
+gulong ril_sim_info_add_imsi_changed_handler(struct ril_sim_info *si,
+					ril_sim_info_cb_t cb, void *arg);
+gulong ril_sim_info_add_spn_changed_handler(struct ril_sim_info *si,
+					ril_sim_info_cb_t cb, void *arg);
+void ril_sim_info_remove_handler(struct ril_sim_info *si, gulong id);
+
+#endif /* RIL_SIM_INFO_H */
+
+/*
+ * Local Variables:
+ * mode: C
+ * c-basic-offset: 8
+ * indent-tabs-mode: t
+ * End:
+ */

ofono/drivers/ril/ril_sim_info_dbus.c

@@ -0,0 +1,243 @@
+/*
+ *  oFono - Open Source Telephony - RIL-based devices
+ *
+ *  Copyright (C) 2016 Jolla Ltd.
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License version 2 as
+ *  published by the Free Software Foundation.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ */
+
+#include "ril_plugin.h"
+#include "ril_sim_info.h"
+#include "ril_log.h"
+
+#include <ofono/dbus.h>
+
+#include <gdbus.h>
+
+#include "ofono.h"
+#include "storage.h"
+
+enum sim_info_event_id {
+	SIM_INFO_EVENT_ICCID,
+	SIM_INFO_EVENT_IMSI,
+	SIM_INFO_EVENT_SPN,
+	SIM_INFO_EVENT_COUNT
+};
+
+struct ril_sim_info_dbus {
+	struct ril_modem *md;
+	struct ril_sim_info *info;
+	DBusConnection *conn;
+	char *path;
+	gulong handler_id[SIM_INFO_EVENT_COUNT];
+};
+
+#define RIL_SIM_INFO_DBUS_INTERFACE             "org.nemomobile.ofono.SimInfo"
+#define RIL_SIM_INFO_DBUS_INTERFACE_VERSION     (1)
+
+#define RIL_SIM_INFO_DBUS_ICCID_CHANGED_SIGNAL  "CardIdentifierChanged"
+#define RIL_SIM_INFO_DBUS_IMSI_CHANGED_SIGNAL   "SubscriberIdentityChanged"
+#define RIL_SIM_INFO_DBUS_SPN_CHANGED_SIGNAL    "ServiceProviderNameChanged"
+
+static void ril_sim_info_dbus_append_string(DBusMessageIter *it, const char *s)
+{
+	if (!s) s = "";
+	dbus_message_iter_append_basic(it, DBUS_TYPE_STRING, &s);
+}
+
+static DBusMessage *ril_sim_info_dbus_reply_with_string(DBusMessage *msg,
+							const char *str)
+{
+	DBusMessage *reply = dbus_message_new_method_return(msg);
+	DBusMessageIter iter;
+
+	dbus_message_iter_init_append(reply, &iter);
+	ril_sim_info_dbus_append_string(&iter, str);
+	return reply;
+}
+
+static DBusMessage *ril_sim_info_dbus_get_all(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	struct ril_sim_info_dbus *dbus = data;
+	struct ril_sim_info *info = dbus->info;
+	DBusMessage *reply = dbus_message_new_method_return(msg);
+	const dbus_int32_t version = RIL_SIM_INFO_DBUS_INTERFACE_VERSION;
+	DBusMessageIter iter;
+
+	dbus_message_iter_init_append(reply, &iter);
+	dbus_message_iter_append_basic(&iter, DBUS_TYPE_INT32, &version);
+	ril_sim_info_dbus_append_string(&iter, info->iccid);
+	ril_sim_info_dbus_append_string(&iter, info->imsi);
+	ril_sim_info_dbus_append_string(&iter, info->spn);
+	return reply;
+}
+
+static DBusMessage *ril_sim_info_dbus_get_version(DBusConnection *dc,
+						DBusMessage *msg, void *data)
+{
+	DBusMessage *reply = dbus_message_new_method_return(msg);
+	dbus_int32_t version = RIL_SIM_INFO_DBUS_INTERFACE_VERSION;
+	DBusMessageIter iter;
+
+	dbus_message_iter_init_append(reply, &iter);
+	dbus_message_iter_append_basic(&iter, DBUS_TYPE_INT32, &version);
+	return reply;
+}
+
+static DBusMessage *ril_sim_info_dbus_get_iccid(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	struct ril_sim_info_dbus *dbus = data;
+	return ril_sim_info_dbus_reply_with_string(msg, dbus->info->iccid);
+}
+
+static DBusMessage *ril_sim_info_dbus_get_imsi(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	struct ril_sim_info_dbus *dbus = data;
+	return ril_sim_info_dbus_reply_with_string(msg, dbus->info->imsi);
+}
+
+static DBusMessage *ril_sim_info_dbus_get_spn(DBusConnection *conn,
+						DBusMessage *msg, void *data)
+{
+	struct ril_sim_info_dbus *dbus = data;
+	return ril_sim_info_dbus_reply_with_string(msg, dbus->info->spn);
+}
+
+static const GDBusMethodTable ril_sim_info_dbus_methods[] = {
+	{ GDBUS_METHOD("GetAll",
+			NULL, GDBUS_ARGS({"version", "i" },
+					 {"iccid", "s" },
+					 {"imsi", "s" }, 
+					 {"spn" , "s"}),
+			ril_sim_info_dbus_get_all) },
+	{ GDBUS_METHOD("GetInterfaceVersion",
+			NULL, GDBUS_ARGS({ "version", "i" }),
+			ril_sim_info_dbus_get_version) },
+	{ GDBUS_METHOD("GetCardIdentifier",
+			NULL, GDBUS_ARGS({ "iccid", "s" }),
+			ril_sim_info_dbus_get_iccid) },
+	{ GDBUS_METHOD("GetSubscriberIdentity",
+			NULL, GDBUS_ARGS({ "imsi", "s" }),
+			ril_sim_info_dbus_get_imsi) },
+	{ GDBUS_METHOD("GetServiceProviderName",
+			NULL, GDBUS_ARGS({ "spn", "s" }),
+			ril_sim_info_dbus_get_spn) },
+	{ }
+};
+
+static const GDBusSignalTable ril_sim_info_dbus_signals[] = {
+	{ GDBUS_SIGNAL(RIL_SIM_INFO_DBUS_ICCID_CHANGED_SIGNAL,
+			GDBUS_ARGS({ "iccid", "s" })) },
+	{ GDBUS_SIGNAL(RIL_SIM_INFO_DBUS_IMSI_CHANGED_SIGNAL,
+			GDBUS_ARGS({ "imsi", "s" })) },
+	{ GDBUS_SIGNAL(RIL_SIM_INFO_DBUS_SPN_CHANGED_SIGNAL,
+			GDBUS_ARGS({ "spn", "s" })) },
+	{ }
+};
+
+static void ril_sim_info_dbus_emit(struct ril_sim_info_dbus *dbus,
+					const char *signal, const char *value)
+{
+	const char *arg = value;
+	if (!arg) arg = "";
+	g_dbus_emit_signal(dbus->conn, dbus->path, RIL_SIM_INFO_DBUS_INTERFACE,
+			signal, DBUS_TYPE_STRING, &arg, DBUS_TYPE_INVALID);
+}
+
+static void ril_sim_info_dbus_iccid_cb(struct ril_sim_info *info, void *arg)
+{
+	struct ril_sim_info_dbus *dbus = arg;
+	ril_sim_info_dbus_emit(dbus, RIL_SIM_INFO_DBUS_ICCID_CHANGED_SIGNAL,
+								info->iccid);
+}
+
+static void ril_sim_info_dbus_imsi_cb(struct ril_sim_info *info, void *arg)
+{
+	struct ril_sim_info_dbus *dbus = arg;
+	ril_sim_info_dbus_emit(dbus, RIL_SIM_INFO_DBUS_IMSI_CHANGED_SIGNAL,
+								info->imsi);
+}
+
+static void ril_sim_info_dbus_spn_cb(struct ril_sim_info *info, void *arg)
+{
+	struct ril_sim_info_dbus *dbus = arg;
+	ril_sim_info_dbus_emit(dbus, RIL_SIM_INFO_DBUS_SPN_CHANGED_SIGNAL,
+								info->spn);
+}
+
+struct ril_sim_info_dbus *ril_sim_info_dbus_new(struct ril_modem *md,
+						struct ril_sim_info *info)
+{
+	struct ril_sim_info_dbus *dbus = g_new0(struct ril_sim_info_dbus, 1);
+
+	DBG("%s", ril_modem_get_path(md));
+	dbus->md = md;
+	dbus->path = g_strdup(ril_modem_get_path(md));
+	dbus->info = ril_sim_info_ref(info);
+	dbus->conn = dbus_connection_ref(ofono_dbus_get_connection());
+
+	/* Register D-Bus interface */
+	if (g_dbus_register_interface(dbus->conn, dbus->path,
+			RIL_SIM_INFO_DBUS_INTERFACE, ril_sim_info_dbus_methods,
+			ril_sim_info_dbus_signals, NULL, dbus, NULL)) {
+		ofono_modem_add_interface(md->ofono,
+						RIL_SIM_INFO_DBUS_INTERFACE);
+
+		dbus->handler_id[SIM_INFO_EVENT_ICCID] =
+			ril_sim_info_add_iccid_changed_handler(info,
+				ril_sim_info_dbus_iccid_cb, dbus);
+		dbus->handler_id[SIM_INFO_EVENT_IMSI] =
+			ril_sim_info_add_imsi_changed_handler(info,
+				ril_sim_info_dbus_imsi_cb, dbus);
+		dbus->handler_id[SIM_INFO_EVENT_SPN] =
+			ril_sim_info_add_spn_changed_handler(info,
+				ril_sim_info_dbus_spn_cb, dbus);
+
+		return dbus;
+	} else {
+		ofono_error("CellInfo D-Bus register failed");
+		ril_sim_info_dbus_free(dbus);
+		return NULL;
+	}
+}
+
+void ril_sim_info_dbus_free(struct ril_sim_info_dbus *dbus)
+{
+	if (dbus) {
+		unsigned int i;
+
+		DBG("%s", dbus->path);
+		g_dbus_unregister_interface(dbus->conn, dbus->path,
+						RIL_SIM_INFO_DBUS_INTERFACE);
+		ofono_modem_remove_interface(dbus->md->ofono,
+						RIL_SIM_INFO_DBUS_INTERFACE);
+		dbus_connection_unref(dbus->conn);
+
+		for (i=0; i<G_N_ELEMENTS(dbus->handler_id); i++) {
+			ril_sim_info_remove_handler(dbus->info,
+							dbus->handler_id[i]);
+		}
+		ril_sim_info_unref(dbus->info);
+
+		g_free(dbus->path);
+		g_free(dbus);
+	}
+}
+
+/*
+ * Local Variables:
+ * mode: C
+ * c-basic-offset: 8
+ * indent-tabs-mode: t
+ * End:
+ */

ofono/drivers/ril/ril_sim_settings.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2016-2017 Jolla Ltd.
+ *  Copyright (C) 2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -16,28 +16,27 @@
 #include "ril_sim_settings.h"
 #include "ril_log.h"
 
-#include "sailfish_watch.h"
-
 #include <gutil_misc.h>
 
-#define RIL_PREF_MODE_DEFAULT(self)                     (\
-	((self)->techs & OFONO_RADIO_ACCESS_MODE_LTE) ?  \
-	OFONO_RADIO_ACCESS_MODE_LTE :                    \
-	((self)->techs & OFONO_RADIO_ACCESS_MODE_UMTS) ? \
-	OFONO_RADIO_ACCESS_MODE_UMTS :                   \
-	OFONO_RADIO_ACCESS_MODE_GSM)
+#include <ofono/sim.h>
+
+#include "storage.h"
+
+#define RIL_SIM_STORE                   "ril"
+#define RIL_SIM_STORE_GROUP             "Settings"
+#define RIL_SIM_STORE_PREF_MODE         "TechnologyPreference"
+
+#define RIL_SIM_STORE_PREF_MODE_DEFAULT(self) ((self)->enable_4g ? \
+	OFONO_RADIO_ACCESS_MODE_LTE : OFONO_RADIO_ACCESS_MODE_UMTS)
 
 typedef GObjectClass RilSimSettingsClass;
 typedef struct ril_sim_settings RilSimSettings;
 
-enum sailfish_watch_events {
-	WATCH_EVENT_IMSI,
-	WATCH_EVENT_COUNT
-};
-
 struct ril_sim_settings_priv {
-	gulong watch_event_id[WATCH_EVENT_COUNT];
-	struct sailfish_watch *watch;
+	struct ofono_sim *sim;
+	guint imsi_watch_id;
+	guint state_watch_id;
+	GKeyFile *storage;
 	char *imsi;
 };
 
@@ -63,77 +62,176 @@ G_DEFINE_TYPE(RilSimSettings, ril_sim_settings, G_TYPE_OBJECT)
 			G_OBJECT_CLASS_TYPE(klass), G_SIGNAL_RUN_FIRST, \
 			0, NULL, NULL, NULL, G_TYPE_NONE, 0)
 
-/* Skip the leading slash from the modem path: */
-#define DBG_(obj,fmt,args...) DBG("%s " fmt, (obj)->path+1, ##args)
-
 static void ril_sim_settings_signal_emit(struct ril_sim_settings *self,
 					enum ril_sim_settings_signal id)
 {
 	g_signal_emit(self, ril_sim_settings_signals[id], 0);
 }
 
+static void ril_sim_settings_reload(struct ril_sim_settings *self)
+{
+	struct ril_sim_settings_priv *priv = self->priv;
+
+	if (priv->storage) {
+		g_key_file_free(priv->storage);
+		priv->storage = NULL;
+	}
+
+	if (priv->imsi) {
+		char *mode_str;
+		enum ofono_radio_access_mode mode;
+		priv->storage = storage_open(priv->imsi, RIL_SIM_STORE);
+		mode_str = g_key_file_get_string(priv->storage,
+			RIL_SIM_STORE_GROUP, RIL_SIM_STORE_PREF_MODE, NULL);
+		if (ofono_radio_access_mode_from_string(mode_str, &mode)) {
+			if (!self->enable_4g &&
+					mode == OFONO_RADIO_ACCESS_MODE_LTE) {
+				mode = OFONO_RADIO_ACCESS_MODE_ANY;
+			}
+		} else {
+			mode = OFONO_RADIO_ACCESS_MODE_ANY;
+		}
+		if (mode == OFONO_RADIO_ACCESS_MODE_ANY) {
+			self->pref_mode = RIL_SIM_STORE_PREF_MODE_DEFAULT(self);
+		} else {
+			self->pref_mode = mode;
+		}
+		g_free(mode_str);
+	}
+}
+
 void ril_sim_settings_set_pref_mode(struct ril_sim_settings *self,
 					enum ofono_radio_access_mode mode)
 {
 	if (G_LIKELY(self) && self->pref_mode != mode) {
-		self->pref_mode = mode;
-		ril_sim_settings_signal_emit(self, SIGNAL_PREF_MODE_CHANGED);
+		struct ril_sim_settings_priv *priv = self->priv;
+		const char *mode_str = ofono_radio_access_mode_to_string(mode);
+
+		GASSERT(priv->storage);
+		if (mode_str) {
+			if (priv->storage) {
+				g_key_file_set_string(priv->storage,
+					RIL_SIM_STORE_GROUP,
+					RIL_SIM_STORE_PREF_MODE, mode_str);
+				storage_sync(self->imsi, RIL_SIM_STORE,
+							priv->storage);
+			}
+			self->pref_mode = mode;
+			ril_sim_settings_signal_emit(self,
+						SIGNAL_PREF_MODE_CHANGED);
+		}
 	}
 }
 
-static void ril_sim_settings_imsi_changed(struct sailfish_watch *watch,
-							void *user_data)
+static void ril_sim_settings_set_imsi(struct ril_sim_settings *self,
+							const char *imsi)
+{
+	struct ril_sim_settings_priv *priv = self->priv;
+	if (g_strcmp0(priv->imsi, imsi)) {
+		enum ofono_radio_access_mode prev_mode = self->pref_mode;
+		g_free(priv->imsi);
+		self->imsi = priv->imsi = g_strdup(imsi);
+		ril_sim_settings_reload(self);
+		ril_sim_settings_signal_emit(self, SIGNAL_IMSI_CHANGED);
+		if (prev_mode != self->pref_mode) {
+			ril_sim_settings_signal_emit(self,
+						SIGNAL_PREF_MODE_CHANGED);
+		}
+	}
+}
+
+static void ril_sim_settings_imsi_watch_cb(const char *imsi, void *user_data)
+{
+	ril_sim_settings_set_imsi(RIL_SIM_SETTINGS(user_data), imsi);
+}
+
+static void ril_sim_settings_imsi_watch_done(void *user_data)
 {
 	struct ril_sim_settings *self = RIL_SIM_SETTINGS(user_data);
 	struct ril_sim_settings_priv *priv = self->priv;
 
-	if (g_strcmp0(priv->imsi, watch->imsi)) {
-		g_free(priv->imsi);
-		self->imsi = priv->imsi = g_strdup(watch->imsi);
-		ril_sim_settings_signal_emit(self, SIGNAL_IMSI_CHANGED);
-	}
+	GASSERT(priv->imsi_watch_id);
+	priv->imsi_watch_id = 0;
 }
 
-struct ril_sim_settings *ril_sim_settings_new(const char *path,
-					enum ofono_radio_access_mode techs)
+static void ril_sim_settings_state_check(struct ril_sim_settings *self,
+					enum ofono_sim_state new_state)
 {
-	struct ril_sim_settings *self = NULL;
-
-	if (G_LIKELY(path)) {
-		struct ril_sim_settings_priv *priv;
-
-		self = g_object_new(RIL_SIM_SETTINGS_TYPE, NULL);
-		priv = self->priv;
-		self->techs = techs;
-		self->pref_mode = RIL_PREF_MODE_DEFAULT(self);
-		priv->watch = sailfish_watch_new(path);
-		priv->watch_event_id[WATCH_EVENT_IMSI] =
-			sailfish_watch_add_imsi_changed_handler(priv->watch,
-				ril_sim_settings_imsi_changed, self);
-		self->imsi = priv->imsi = g_strdup(priv->watch->imsi);
+	if (new_state != OFONO_SIM_STATE_READY) {
+		ril_sim_settings_set_imsi(self, NULL);
 	}
-
-	return self;
 }
 
-struct ril_sim_settings *ril_sim_settings_ref(struct ril_sim_settings *self)
+static void ril_sim_settings_state_watch(enum ofono_sim_state new_state,
+							void *user_data)
+{
+	ril_sim_settings_state_check(RIL_SIM_SETTINGS(user_data), new_state);
+}
+
+static void ril_sim_settings_state_watch_done(void *user_data)
+{
+	struct ril_sim_settings *self = RIL_SIM_SETTINGS(user_data);
+	struct ril_sim_settings_priv *priv = self->priv;
+
+	GASSERT(priv->state_watch_id);
+	priv->state_watch_id = 0;
+}
+
+void ril_sim_settings_set_ofono_sim(struct ril_sim_settings *self,
+						struct ofono_sim *sim)
 {
 	if (G_LIKELY(self)) {
-		g_object_ref(RIL_SIM_SETTINGS(self));
-		return self;
-	} else {
-		return NULL;
+		struct ril_sim_settings_priv *priv = self->priv;
+		if (priv->sim != sim) {
+			GASSERT(priv->sim || !priv->imsi_watch_id);
+			if (priv->imsi_watch_id) {
+				ofono_sim_remove_imsi_watch(priv->sim,
+							priv->imsi_watch_id);
+				/*
+				 * ril_sim_settings_imsi_watch_done
+				 * clears it
+				 */
+				GASSERT(!priv->imsi_watch_id);
+			}
+			if (priv->state_watch_id) {
+				ofono_sim_remove_state_watch(priv->sim,
+						priv->state_watch_id);
+				/*
+				 * ril_sim_settings_state_watch_done
+				 * clears it
+				 */
+				GASSERT(!priv->state_watch_id);
+			}
+			priv->sim = sim;
+			if (sim) {
+				priv->state_watch_id =
+					ofono_sim_add_state_watch(sim,
+					ril_sim_settings_state_watch, self,
+					ril_sim_settings_state_watch_done);
+				GASSERT(priv->state_watch_id);
+				ril_sim_settings_state_check(self,
+						ofono_sim_get_state(sim));
+				/*
+				 * ofono_sim_add_imsi_watch immediately
+				 * calls the event callback if IMSI is
+				 * already known. It's useless though
+				 * because we still have to check the
+				 * current state in case if IMSI is not
+				 * available yet.
+				 */
+				priv->imsi_watch_id =
+					ofono_sim_add_imsi_watch(priv->sim,
+					ril_sim_settings_imsi_watch_cb, self,
+					ril_sim_settings_imsi_watch_done);
+				GASSERT(priv->state_watch_id);
+			}
+			/* Luckily, ofono_sim_get_imsi handles NULL pointer */
+			ril_sim_settings_set_imsi(self,
+						ofono_sim_get_imsi(sim));
+		}
 	}
 }
 
-void ril_sim_settings_unref(struct ril_sim_settings *self)
-{
-	if (G_LIKELY(self)) {
-		g_object_unref(RIL_SIM_SETTINGS(self));
-	}
-}
-
-
 gulong ril_sim_settings_add_imsi_changed_handler(struct ril_sim_settings *self,
 					ril_sim_settings_cb_t cb, void *arg)
 {
@@ -162,26 +260,51 @@ void ril_sim_settings_remove_handlers(struct ril_sim_settings *self,
 	gutil_disconnect_handlers(self, ids, count);
 }
 
+struct ril_sim_settings *ril_sim_settings_new(const struct ril_slot_config *sc)
+{
+	struct ril_sim_settings *self = g_object_new(RIL_SIM_SETTINGS_TYPE, 0);
+	self->enable_4g = sc->enable_4g;
+	self->slot = sc->slot;
+	self->pref_mode = RIL_SIM_STORE_PREF_MODE_DEFAULT(self);
+	return self;
+}
+
+struct ril_sim_settings *ril_sim_settings_ref(struct ril_sim_settings *self)
+{
+	if (G_LIKELY(self)) {
+		g_object_ref(RIL_SIM_SETTINGS(self));
+		return self;
+	} else {
+		return NULL;
+	}
+}
+
+void ril_sim_settings_unref(struct ril_sim_settings *self)
+{
+	if (G_LIKELY(self)) {
+		g_object_unref(RIL_SIM_SETTINGS(self));
+	}
+}
+
 static void ril_sim_settings_init(struct ril_sim_settings *self)
 {
 	self->priv =  G_TYPE_INSTANCE_GET_PRIVATE(self, RIL_SIM_SETTINGS_TYPE,
 						struct ril_sim_settings_priv);
 }
 
-static void ril_sim_settings_finalize(GObject *object)
+static void ril_sim_settings_dispose(GObject *object)
 {
 	struct ril_sim_settings *self = RIL_SIM_SETTINGS(object);
-	struct ril_sim_settings_priv *priv = self->priv;
 
-	sailfish_watch_remove_all_handlers(priv->watch, priv->watch_event_id);
-	sailfish_watch_unref(priv->watch);
-	g_free(priv->imsi);
-	G_OBJECT_CLASS(ril_sim_settings_parent_class)->finalize(object);
+	ril_sim_settings_set_ofono_sim(self, NULL);
+	G_OBJECT_CLASS(ril_sim_settings_parent_class)->dispose(object);
 }
 
 static void ril_sim_settings_class_init(RilSimSettingsClass *klass)
 {
-	G_OBJECT_CLASS(klass)->finalize = ril_sim_settings_finalize;
+	GObjectClass *object_class = G_OBJECT_CLASS(klass);
+
+	object_class->dispose = ril_sim_settings_dispose;
 	g_type_class_add_private(klass, sizeof(struct ril_sim_settings_priv));
 	NEW_SIGNAL(klass, IMSI);
 	NEW_SIGNAL(klass, PREF_MODE);

ofono/drivers/ril/ril_sim_settings.h

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2016-2018 Jolla Ltd.
+ *  Copyright (C) 2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -18,24 +18,26 @@
 
 #include "ril_types.h"
 
-#include <glib-object.h>
+#include <ofono/radio-settings.h>
 
 struct ril_sim_settings_priv;
 
 struct ril_sim_settings {
 	GObject object;
 	struct ril_sim_settings_priv *priv;
+	gboolean enable_4g;
+	guint slot;
 	const char *imsi;
-	enum ofono_radio_access_mode techs;
 	enum ofono_radio_access_mode pref_mode;
 };
 
 typedef void (*ril_sim_settings_cb_t)(struct ril_sim_settings *s, void *arg);
 
-struct ril_sim_settings *ril_sim_settings_new(const char *path,
-					enum ofono_radio_access_mode techs);
+struct ril_sim_settings *ril_sim_settings_new(const struct ril_slot_config *sc);
 struct ril_sim_settings *ril_sim_settings_ref(struct ril_sim_settings *s);
 void ril_sim_settings_unref(struct ril_sim_settings *s);
+void ril_sim_settings_set_ofono_sim(struct ril_sim_settings *s,
+					struct ofono_sim *sim);
 void ril_sim_settings_set_pref_mode(struct ril_sim_settings *s,
 					enum ofono_radio_access_mode mode);
 gulong ril_sim_settings_add_imsi_changed_handler(struct ril_sim_settings *s,

ofono/drivers/ril/ril_sms.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2017 Jolla Ltd.
+ *  Copyright (C) 2015-2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -14,6 +14,7 @@
  */
 
 #include "ril_plugin.h"
+#include "ril_constants.h"
 #include "ril_util.h"
 #include "ril_log.h"
 
@@ -254,9 +255,8 @@ static void ril_sms_submit(struct ofono_sms *sms, const unsigned char *pdu,
 
 	DBG("%s", tpdu);
 	grilio_queue_send_request_full(sd->q, req,
-		mms ? RIL_REQUEST_SEND_SMS_EXPECT_MORE : RIL_REQUEST_SEND_SMS,
-		ril_sms_submit_cb, ril_sms_cbd_free,
-		ril_sms_cbd_new(sd, cb, data));
+			RIL_REQUEST_SEND_SMS, ril_sms_submit_cb,
+			ril_sms_cbd_free, ril_sms_cbd_new(sd, cb, data));
 	grilio_request_unref(req);
 	g_free(tpdu);
 }
@@ -471,7 +471,7 @@ static int ril_sms_probe(struct ofono_sms *sms, unsigned int vendor,
 
 static void ril_sms_remove(struct ofono_sms *sms)
 {
-	unsigned int i;
+	int i;
 	struct ril_sms *sd = ril_sms_get_data(sms);
 
 	DBG("");

ofono/drivers/ril/ril_stk.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2017 Jolla Ltd.
+ *  Copyright (C) 2015 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -16,6 +16,7 @@
 #include "ril_plugin.h"
 #include "ril_util.h"
 #include "ril_log.h"
+#include "ril_constants.h"
 
 #include "util.h"
 
@@ -268,7 +269,7 @@ static int ril_stk_probe(struct ofono_stk *stk, unsigned int vendor, void *data)
 static void ril_stk_remove(struct ofono_stk *stk)
 {
 	struct ril_stk *sd = ril_stk_get_data(stk);
-	unsigned int i;
+	int i;
 
 	DBG("");
 	ofono_stk_set_data(stk, NULL);

ofono/drivers/ril/ril_subscription.conf

@@ -21,13 +21,6 @@
 #
 #EmptyConfig=false
 
-# User and group for the ofono process. RIL clients are typically
-# expected to run under radio:radio.
-#
-# Default is radio:radio
-#
-#Identity=radio:radio
-
 # If the phone has more than one SIM slot, the 3G/LTE module may be
 # shared by all modems, meaning that only one of the slots can use
 # 3G/LTE. In order to "hand 4G over" to the other slot, the modem
@@ -42,17 +35,6 @@
 #
 #3GLTEHandover=true
 
-# RIL_REQUEST_SET_RADIO_CAPABILITY may or may not be supported by your RIL.
-# This option allows you to forcibly enable or disable use of this request.
-# It's involved in 3G/LTE handover between the modems, meaning that it only
-# makes sense if you have more than one slot.
-#
-# Possible values are auto, on and off
-#
-# Default is auto (enable for RIL version >= 11)
-#
-#SetRadioCapability=auto
-
 [ril_0]
 
 # Required entry, defines the RIL socket path
@@ -85,15 +67,9 @@ socket=/dev/socket/rild
 #
 #timeout=0
 
-# Comma-separated list of radio technologies supported by the modem.
-# Valid technologies are "gsm", "umts" and "lte". The special value
-# "all" means that all technologies are supported.
+# Setting this one to false would disable 4G technology selection.
 #
-# The default is all
-#
-#technologies=all
-
-# This one is deprecated, use the technologies entry instead (above).
+# By default 4G is enabled
 #
 #enable4G=true
 
@@ -124,7 +100,7 @@ socket=/dev/socket/rild
 # This option allows you to forcibly enable or disable use of this request.
 # Possible values are auto, on and off
 #
-# Default is auto (enable for RIL version >= 11)
+# Default is auto (usage based on the RIL version)
 #
 #allowDataReq=auto
 
@@ -175,77 +151,3 @@ socket=/dev/socket/rild
 #
 #remoteHangupReasons=20
 #localHangupReasons=23
-
-# Voice call support. Some devices like USB modems and tablets don't support
-# voice calls. By default, voice calls are enabled and this option allows you
-# to disable voice call handling.
-#
-# Default true
-#
-#enableVoicecall=true
-
-# Support for Cell Broadcast System (CBS). By default, its enabled but if
-# your rild and/or modem is not happy about it, you can turn it off.
-#
-# Default true
-#
-#enableCellBroadcast=true
-
-# Timeout for the modem to show up, in milliseconds. Those that don't
-# show up before this timeout expires, will be dropped (ignored).
-#
-# In some fairly rare cases it makes sense to shorten this timeout for
-# optional modems (which may or may not be available), to speed up the
-# boot up process.
-#
-# The default is 20000 (20 seconds)
-#
-#startTimeout=20000
-
-# This allows to use deprecated RIL_REQUEST_GET_IMEI instead of
-# RIL_REQUEST_DEVICE_IDENTITY to query IMEI from the modem. Some
-# RILs (e.g. MTK) still don't understand RIL_REQUEST_DEVICE_IDENTITY.
-#
-# Default is false (use RIL_REQUEST_DEVICE_IDENTITY)
-#
-#legacyImeiQuery=false
-
-# Some devices don't support LTE RAT mode PREF_NET_TYPE_LTE_GSM_WCDMA.
-# This option allows to set a custom LTE mode.
-#
-# The default is 9 (PREF_NET_TYPE_LTE_GSM_WCDMA)
-#
-#lteNetworkMode=9
-
-# Timeout for RIL_REQUEST_SET_PREFERRED_NETWORK_TYPE, in milliseconds.
-#
-# The default is 20000 (20 seconds)
-#
-#networkModeTimeout=20000
-
-# Cycle radio power at startup.
-#
-# The default is true (cycle the power)
-#
-#radioPowerCycle=true
-
-# With some RILs it seems to be necessary to kick (RIL_REQUEST_RADIO_POWER)
-# the modems with power on after one of the modems has been powered off.
-# Otherwise bad things may happen (like the modem never registering
-# on the network).
-#
-# On the other hand, with some RILs it's causing some trouble (like this
-# extra RIL_REQUEST_RADIO_POWER getting stuck indefinitely).
-#
-# The default is true for historical reasons
-#
-#confirmRadioPowerOn=true
-
-# Normally we should be able to have two simultaneously active data
-# contexts - one for mobile data and one for MMS. Some devices however
-# require that mobile data is disconnected before we can send or receive
-# MMS. In other words, activation of the second data context fails.
-#
-# The default is false (more than one context is supported)
-#
-#singleDataContext=false

ofono/drivers/ril/ril_types.h

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2018 Jolla Ltd.
+ *  Copyright (C) 2015-2017 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -23,12 +23,11 @@
 #include <grilio_types.h>
 #include <gutil_macros.h>
 
+#include <ofono/types.h>
+
 struct ofono_modem;
 struct ofono_sim;
 
-#include <ofono/types.h>
-#include <ofono/radio-settings.h>
-
 #include <stdio.h>
 #include <errno.h>
 #include <stdlib.h>
@@ -40,25 +39,20 @@ struct ofono_sim;
 #define RIL_RETRY_SECS (2)
 #define RIL_RETRY_MS   (RIL_RETRY_SECS*1000)
 
+struct ril_mce;
 struct ril_data;
-struct ril_data_call;
 struct ril_modem;
 struct ril_radio;
 struct ril_network;
 struct ril_sim_card;
-struct ril_vendor_hook;
+struct ril_sim_info;
+struct ril_sim_settings;
+struct ril_cell_info;
 
 struct ril_slot_config {
 	guint slot;
-	enum ofono_radio_access_mode techs;
-	int lte_network_mode;
-	int network_mode_timeout;
-	gboolean query_available_band_mode;
+	gboolean enable_4g;
 	gboolean empty_pin_query;
-	gboolean radio_power_cycle;
-	gboolean confirm_radio_power_on;
-	gboolean enable_voicecall;
-	gboolean enable_cbs;
 	GUtilInts *local_hangup_reasons;
 	GUtilInts *remote_hangup_reasons;
 };

ofono/drivers/ril/ril_ussd.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2018 Jolla Ltd.
+ *  Copyright (C) 2015-2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -16,12 +16,11 @@
 #include "ril_plugin.h"
 #include "ril_util.h"
 #include "ril_log.h"
+#include "ril_constants.h"
 
 #include "smsutil.h"
 #include "util.h"
 
-#define USSD_CANCEL_TIMEOUT_SEC (20)
-
 struct ril_ussd {
 	struct ofono_ussd *ussd;
 	GRilIoChannel *io;
@@ -116,14 +115,11 @@ static void ril_ussd_cancel(struct ofono_ussd *ussd,
 				ofono_ussd_cb_t cb, void *data)
 {
 	struct ril_ussd *ud = ril_ussd_get_data(ussd);
-	GRilIoRequest *req = grilio_request_new();
 
 	ofono_info("send ussd cancel");
-	grilio_request_set_timeout(req, USSD_CANCEL_TIMEOUT_SEC * 1000);
-	grilio_queue_send_request_full(ud->q, req, RIL_REQUEST_CANCEL_USSD,
+	grilio_queue_send_request_full(ud->q, NULL, RIL_REQUEST_CANCEL_USSD,
 				ril_ussd_cancel_cb, ril_ussd_cbd_free,
 				ril_ussd_cbd_new(cb, data));
-	grilio_request_unref(req);
 }
 
 static void ril_ussd_notify(GRilIoChannel *io, guint code,

ofono/drivers/ril/ril_util.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2018 Jolla Ltd.
+ *  Copyright (C) 2015-2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -18,8 +18,6 @@
 
 #include <grilio_channel.h>
 
-#include <gutil_misc.h>
-
 #include <sys/socket.h>
 #include <ctype.h>
 
@@ -50,8 +48,7 @@ const char *ril_error_to_string(int error)
 	RIL_E_(MODE_NOT_SUPPORTED);
 	RIL_E_(FDN_CHECK_FAILURE);
 	RIL_E_(ILLEGAL_SIM_OR_ME);
-	RIL_E_(MISSING_RESOURCE);
-	RIL_E_(NO_SUCH_ELEMENT);
+	RIL_E_(UNUSED);
 	RIL_E_(DIAL_MODIFIED_TO_USSD);
 	RIL_E_(DIAL_MODIFIED_TO_SS);
 	RIL_E_(DIAL_MODIFIED_TO_DIAL);
@@ -60,39 +57,11 @@ const char *ril_error_to_string(int error)
 	RIL_E_(USSD_MODIFIED_TO_USSD);
 	RIL_E_(SS_MODIFIED_TO_DIAL);
 	RIL_E_(SS_MODIFIED_TO_USSD);
-	RIL_E_(SUBSCRIPTION_NOT_SUPPORTED);
 	RIL_E_(SS_MODIFIED_TO_SS);
-	RIL_E_(LCE_NOT_SUPPORTED);
-	RIL_E_(NO_MEMORY);
-	RIL_E_(INTERNAL_ERR);
-	RIL_E_(SYSTEM_ERR);
-	RIL_E_(MODEM_ERR);
-	RIL_E_(INVALID_STATE);
-	RIL_E_(NO_RESOURCES);
-	RIL_E_(SIM_ERR);
-	RIL_E_(INVALID_ARGUMENTS);
-	RIL_E_(INVALID_SIM_STATE);
-	RIL_E_(INVALID_MODEM_STATE);
-	RIL_E_(INVALID_CALL_ID);
-	RIL_E_(NO_SMS_TO_ACK);
-	RIL_E_(NETWORK_ERR);
-	RIL_E_(REQUEST_RATE_LIMITED);
-	RIL_E_(SIM_BUSY);
-	RIL_E_(SIM_FULL);
-	RIL_E_(NETWORK_REJECT);
-	RIL_E_(OPERATION_NOT_ALLOWED);
-	RIL_E_(EMPTY_RECORD);
-	RIL_E_(INVALID_SMS_FORMAT);
-	RIL_E_(ENCODING_ERR);
-	RIL_E_(INVALID_SMSC_ADDRESS);
-	RIL_E_(NO_SUCH_ENTRY);
-	RIL_E_(NETWORK_NOT_READY);
-	RIL_E_(NOT_PROVISIONED);
-	RIL_E_(NO_SUBSCRIPTION);
-	RIL_E_(NO_NETWORK_FOUND);
-	RIL_E_(DEVICE_IN_USE);
-	RIL_E_(ABORTED);
-	RIL_E_(INVALID_RESPONSE);
+	RIL_E_(SUBSCRIPTION_NOT_SUPPORTED);
+	RIL_E_(MISSING_RESOURCE);
+	RIL_E_(NO_SUCH_ELEMENT);
+	RIL_E_(INVALID_PARAMETER);
 	default:
 		snprintf(unknown, sizeof(unknown), "%d", error);
 		return unknown;
@@ -235,8 +204,6 @@ const char *ril_request_to_string(guint request)
 	RIL_REQUEST_(SHUTDOWN);
 	RIL_REQUEST_(GET_RADIO_CAPABILITY);
 	RIL_REQUEST_(SET_RADIO_CAPABILITY);
-	case RIL_RESPONSE_ACKNOWLEDGEMENT:
-		return "RESPONSE_ACK";
 	default:
 		snprintf(unknown, sizeof(unknown), "RIL_REQUEST_%d", request);
 		return unknown;
@@ -326,7 +293,8 @@ int ril_parse_tech(const char *stech, int *ril_tech)
 {
 	int access_tech = -1;
 	int tech = -1;
-	if (gutil_parse_int(stech, 0, &tech)) {
+	if (stech && stech[0]) {
+		tech = atoi(stech);
 		switch (tech) {
 		case RADIO_TECH_GPRS:
 		case RADIO_TECH_GSM:
@@ -383,8 +351,8 @@ gboolean ril_parse_mcc_mnc(const char *str, struct ofono_network_operator *op)
 
 		if (i == OFONO_MAX_MCC_LENGTH) {
 			/* Usually 2 but sometimes 3 digit network code */
-			for (i = 0;
-			     i < OFONO_MAX_MNC_LENGTH && *ptr && isdigit(*ptr);
+			for (i=0;
+			     i<OFONO_MAX_MNC_LENGTH && *ptr && isdigit(*ptr);
 			     i++) {
 				op->mnc[i] = *ptr++;
 			}

ofono/drivers/ril/ril_util.h

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2018 Jolla Ltd.
+ *  Copyright (C) 2015-2016 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as

ofono/drivers/ril/ril_vendor.c

@@ -1,164 +0,0 @@
-/*
- *  oFono - Open Source Telephony - RIL-based devices
- *
- *  Copyright (C) 2016-2018 Jolla Ltd.
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- *  GNU General Public License for more details.
- */
-
-#include "ril_vendor.h"
-#include "ril_log.h"
-
-struct ril_vendor_hook *ril_vendor_create_hook
-		(const struct ril_vendor_driver *vendor, GRilIoChannel *io,
-			const char *path, const struct ril_slot_config *config,
-			struct ril_network *network)
-{
-	if (vendor) {
-		const void *data = vendor->driver_data;
-
-		/*
-		 * NOTE: we are looking for the callback in the base but
-		 * keeping the original driver data.
-		 */
-		while (!vendor->create_hook && vendor->base) {
-			vendor = vendor->base;
-		}
-		if (vendor->create_hook) {
-			return vendor->create_hook(data, io, path, config,
-								network);
-		}
-	}
-	return NULL;
-}
-
-struct ril_vendor_hook *ril_vendor_hook_init(struct ril_vendor_hook *self,
-				const struct ril_vendor_hook_proc *proc,
-				ril_vendor_hook_free_proc free)
-{
-	self->proc = proc;
-	self->free = free;
-	g_atomic_int_set(&self->ref_count, 1);
-	return self;
-}
-
-struct ril_vendor_hook *ril_vendor_hook_ref(struct ril_vendor_hook *self)
-{
-	if (self) {
-		GASSERT(self->ref_count > 0);
-		g_atomic_int_inc(&self->ref_count);
-	}
-	return self;
-}
-
-static void ril_vendor_hook_free(struct ril_vendor_hook *self)
-{
-	if (self->free) {
-		self->free(self);
-	}
-}
-
-void ril_vendor_hook_unref(struct ril_vendor_hook *self)
-{
-	if (self) {
-		GASSERT(self->ref_count > 0);
-		if (g_atomic_int_dec_and_test(&self->ref_count)) {
-			ril_vendor_hook_free(self);
-		}
-	}
-}
-
-void ril_vendor_get_defaults(const struct ril_vendor_driver *vendor,
-					struct ril_vendor_defaults *defaults)
-{
-	if (vendor) {
-		while (!vendor->get_defaults && vendor->base) {
-			vendor = vendor->base;
-		}
-		if (vendor->get_defaults) {
-			vendor->get_defaults(defaults);
-		}
-	}
-}
-
-const char *ril_vendor_hook_request_to_string(struct ril_vendor_hook *self,
-							guint request)
-{
-	if (self) {
-		const struct ril_vendor_hook_proc *proc = self->proc;
-
-		while (!proc->request_to_string && proc->base) {
-			proc = proc->base;
-		}
-		if (proc->request_to_string) {
-			return proc->request_to_string(self, request);
-		}
-	}
-	return NULL;
-}
-
-const char *ril_vendor_hook_event_to_string(struct ril_vendor_hook *self,
-							guint event)
-{
-	if (self) {
-		const struct ril_vendor_hook_proc *proc = self->proc;
-
-		while (!proc->event_to_string && proc->base) {
-			proc = proc->base;
-		}
-		if (proc->event_to_string) {
-			return proc->event_to_string(self, event);
-		}
-	}
-	return NULL;
-}
-
-GRilIoRequest *ril_vendor_hook_data_call_req(struct ril_vendor_hook *self,
-			int tech, const char *profile, const char *apn,
-			const char *username, const char *password,
-			enum ril_auth auth, const char *proto)
-{
-	if (self) {
-		const struct ril_vendor_hook_proc *proc = self->proc;
-
-		while (!proc->data_call_req && proc->base) {
-			proc = proc->base;
-		}
-		if (proc->data_call_req) {
-			return proc->data_call_req(self, tech, profile, apn,
-					username, password, auth, proto);
-		}
-	}
-	return NULL;
-}
-
-gboolean ril_vendor_hook_data_call_parse(struct ril_vendor_hook *self,
-		struct ril_data_call *call, int ver, GRilIoParser *rilp)
-{
-	if (self) {
-		const struct ril_vendor_hook_proc *proc = self->proc;
-
-		while (!proc->data_call_parse && proc->base) {
-			proc = proc->base;
-		}
-		if (proc->data_call_parse) {
-			return proc->data_call_parse(self, call, ver, rilp);
-		}
-	}
-	return FALSE;
-}
-
-/*
- * Local Variables:
- * mode: C
- * c-basic-offset: 8
- * indent-tabs-mode: t
- * End:
- */

ofono/drivers/ril/ril_vendor.h

@@ -1,103 +0,0 @@
-/*
- *  oFono - Open Source Telephony - RIL-based devices
- *
- *  Copyright (C) 2016-2018 Jolla Ltd.
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- *  GNU General Public License for more details.
- */
-
-#ifndef RIL_VENDOR_H
-#define RIL_VENDOR_H
-
-#include "ril_types.h"
-
-struct ril_vendor_defaults {
-	gboolean empty_pin_query;
-	gboolean legacy_imei_query;
-	gboolean enable_cbs;
-	gboolean query_available_band_mode;
-};
-
-struct ril_vendor_driver {
-	const char *name;
-	const void *driver_data;
-	const struct ril_vendor_driver *base;
-	void (*get_defaults)(struct ril_vendor_defaults *defaults);
-	struct ril_vendor_hook *(*create_hook)(const void *driver_data,
-				GRilIoChannel *io, const char *path,
-				const struct ril_slot_config *cfg,
-				struct ril_network *network);
-};
-
-struct ril_vendor_hook_proc {
-	const struct ril_vendor_hook_proc *base;
-	const char *(*request_to_string)(struct ril_vendor_hook *hook,
-							guint request);
-	const char *(*event_to_string)(struct ril_vendor_hook *hook,
-							guint event);
-	GRilIoRequest *(*data_call_req)(struct ril_vendor_hook *hook,
-			int tech, const char *profile, const char *apn,
-			const char *username, const char *password,
-			enum ril_auth auth, const char *proto);
-	gboolean (*data_call_parse)(struct ril_vendor_hook *hook,
-			struct ril_data_call *call, int version,
-			GRilIoParser *rilp);
-};
-
-typedef void (*ril_vendor_hook_free_proc)(struct ril_vendor_hook *hook);
-struct ril_vendor_hook {
-	const struct ril_vendor_hook_proc *proc;
-	ril_vendor_hook_free_proc free;
-	gint ref_count;
-};
-
-struct ril_vendor_hook *ril_vendor_create_hook
-		(const struct ril_vendor_driver *vendor, GRilIoChannel *io,
-			const char *path, const struct ril_slot_config *cfg,
-			struct ril_network *network);
-void ril_vendor_get_defaults(const struct ril_vendor_driver *vendor,
-					struct ril_vendor_defaults *defaults);
-
-struct ril_vendor_hook *ril_vendor_hook_init(struct ril_vendor_hook *hook,
-				const struct ril_vendor_hook_proc *proc,
-				ril_vendor_hook_free_proc free);
-struct ril_vendor_hook *ril_vendor_hook_ref(struct ril_vendor_hook *hook);
-void ril_vendor_hook_unref(struct ril_vendor_hook *hook);
-
-const char *ril_vendor_hook_request_to_string(struct ril_vendor_hook *hook,
-					guint request);
-const char *ril_vendor_hook_event_to_string(struct ril_vendor_hook *hook,
-					guint event);
-GRilIoRequest *ril_vendor_hook_data_call_req(struct ril_vendor_hook *hook,
-			int tech, const char *profile, const char *apn,
-			const char *username, const char *password,
-			enum ril_auth auth, const char *proto);
-gboolean ril_vendor_hook_data_call_parse(struct ril_vendor_hook *hook,
-			struct ril_data_call *call, int version,
-			GRilIoParser *rilp);
-
-/* Put vendor driver descriptors to the "__vendor" section */
-#define RIL_VENDOR_DRIVER_DEFINE(name) \
-	const struct ril_vendor_driver name \
-	__attribute__((used, section("__vendor"))) =
-#define RIL_VENDOR_DRIVER_FOREACH(var) \
-	for ((var) = __start___vendor; (var) < __stop___vendor; (var)++)
-extern const struct ril_vendor_driver __start___vendor[];
-extern const struct ril_vendor_driver __stop___vendor[];
-
-#endif /* RIL_VENDOR_H */
-
-/*
- * Local Variables:
- * mode: C
- * c-basic-offset: 8
- * indent-tabs-mode: t
- * End:
- */

ofono/drivers/ril/ril_vendor_mtk.c

@@ -1,703 +0,0 @@
-/*
- *  oFono - Open Source Telephony - RIL-based devices
- *
- *  Copyright (C) 2016-2018 Jolla Ltd.
- *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- *  GNU General Public License for more details.
- */
-
-#include "ril_plugin.h"
-#include "ril_vendor.h"
-#include "ril_network.h"
-#include "ril_data.h"
-#include "ril_log.h"
-
-#include "sailfish_watch.h"
-
-#include <grilio_channel.h>
-#include <grilio_parser.h>
-#include <grilio_request.h>
-#include <grilio_queue.h>
-
-#include <gutil_macros.h>
-#include <gutil_misc.h>
-
-#include "ofono.h"
-
-#define SET_INITIAL_ATTACH_APN_TIMEOUT (20*1000)
-
-enum ril_mtk_watch_events {
-	WATCH_EVENT_IMSI_CHANGED,
-	WATCH_EVENT_COUNT
-};
-
-enum ril_mtk_network_events {
-	NETWORK_EVENT_PREF_MODE_CHANGED,
-	NETWORK_EVENT_COUNT
-};
-
-enum ril_mtk_events {
-	MTK_EVENT_REGISTRATION_SUSPENDED,
-	MTK_EVENT_SET_ATTACH_APN,
-	MTK_EVENT_PS_NETWORK_STATE_CHANGED,
-	MTK_EVENT_INCOMING_CALL_INDICATION,
-	MTK_EVENT_COUNT
-};
-
-struct ril_vendor_hook_mtk {
-	struct ril_vendor_hook hook;
-	const struct ril_mtk_msg *msg;
-	GRilIoQueue *q;
-	GRilIoChannel *io;
-	struct ril_network *network;
-	struct sailfish_watch *watch;
-	guint set_initial_attach_apn_id;
-	gboolean initial_attach_apn_ok;
-	gulong network_event_id[NETWORK_EVENT_COUNT];
-	gulong watch_event_id[WATCH_EVENT_COUNT];
-	gulong ril_event_id[MTK_EVENT_COUNT];
-	guint slot;
-};
-
-/* driver_data point this this: */
-struct ril_vendor_mtk_driver_data {
-	const char *name;
-	const struct ril_mtk_msg *msg;
-	const struct ril_vendor_hook_proc *proc;
-};
-
-/* Hook with auto-detection */
-struct ril_vendor_hook_mtk_auto {
-	struct ril_vendor_hook_mtk mtk;
-	const struct ril_vendor_mtk_driver_data *type;
-	gulong detect_id;
-};
-
-/* MTK specific RIL messages (actual codes differ from model to model!) */
-struct ril_mtk_msg {
-	gboolean attach_apn_has_roaming_protocol;
-	guint request_resume_registration;
-	guint request_set_call_indication;
-
-	/* See ril_vendor_mtk_auto_detect_event */
-#define unsol_msgs unsol_ps_network_state_changed
-#define MTK_UNSOL_MSGS (4)
-
-	guint unsol_ps_network_state_changed;
-	guint unsol_registration_suspended;
-	guint unsol_incoming_call_indication;
-	guint unsol_set_attach_apn;
-};
-
-static const struct ril_mtk_msg msg_mtk1 = {
-	.attach_apn_has_roaming_protocol = TRUE,
-	.request_resume_registration = 2050,
-	.request_set_call_indication = 2065,
-	.unsol_ps_network_state_changed = 3012,
-	.unsol_registration_suspended = 3021,
-	.unsol_incoming_call_indication = 3037,
-	.unsol_set_attach_apn = 3065
-};
-
-static const struct ril_mtk_msg msg_mtk2 = {
-	.attach_apn_has_roaming_protocol = FALSE,
-	.request_resume_registration = 2065,
-	.request_set_call_indication = 2086,
-	.unsol_ps_network_state_changed = 3015,
-	.unsol_registration_suspended = 3024,
-	.unsol_incoming_call_indication = 3042,
-	.unsol_set_attach_apn = 3073
-};
-
-static inline struct ril_vendor_hook_mtk *ril_vendor_hook_mtk_cast
-						(struct ril_vendor_hook *hook)
-{
-	return G_CAST(hook, struct ril_vendor_hook_mtk, hook);
-}
-
-static inline struct ril_vendor_hook_mtk_auto *ril_vendor_hook_mtk_auto_cast
-						(struct ril_vendor_hook *hook)
-{
-	return G_CAST(hook, struct ril_vendor_hook_mtk_auto, mtk.hook);
-}
-
-static const char *ril_vendor_mtk_request_to_string
-				(struct ril_vendor_hook *hook, guint request)
-{
-	struct ril_vendor_hook_mtk *self = ril_vendor_hook_mtk_cast(hook);
-	const struct ril_mtk_msg *msg = self->msg;
-
-	if (request == msg->request_resume_registration) {
-		return "MTK_RESUME_REGISTRATION";
-	} else if (request == msg->request_set_call_indication) {
-		return "MTK_SET_CALL_INDICATION";
-	} else {
-		return NULL;
-	}
-}
-
-static const char *ril_vendor_mtk_unsol_msg_name(const struct ril_mtk_msg *msg,
-								guint event)
-{
-	if (event == msg->unsol_ps_network_state_changed) {
-		return "MTK_PS_NETWORK_STATE_CHANGED";
-	} else if (event == msg->unsol_registration_suspended) {
-		return "MTK_REGISTRATION_SUSPENDED";
-	} else if (event == msg->unsol_set_attach_apn) {
-		return "MTK_SET_ATTACH_APN";
-	} else if (event == msg->unsol_incoming_call_indication) {
-		return "MTK_INCOMING_CALL_INDICATION";
-	} else {
-		return NULL;
-	}
-}
-
-static const char *ril_vendor_mtk_event_to_string(struct ril_vendor_hook *hook,
-								guint event)
-{
-	struct ril_vendor_hook_mtk *self = ril_vendor_hook_mtk_cast(hook);
-
-	return ril_vendor_mtk_unsol_msg_name(self->msg, event);
-}
-
-static void ril_vendor_mtk_registration_suspended(GRilIoChannel *io, guint id,
-				const void *data, guint len, void *user_data)
-{
-	struct ril_vendor_hook_mtk *self = user_data;
-	const struct ril_mtk_msg *msg = self->msg;
-	GRilIoParser rilp;
-	int session_id;
-
-	GASSERT(id == msg->unsol_registration_suspended);
-	grilio_parser_init(&rilp, data, len);
-	if (grilio_parser_get_int32(&rilp, NULL) &&
-			grilio_parser_get_int32(&rilp, &session_id)) {
-		GRilIoRequest *req = grilio_request_new();
-		DBG("slot=%u,session_id=%d", self->slot, session_id);
-		grilio_request_append_int32(req, 1);
-		grilio_request_append_int32(req, session_id);
-		grilio_queue_send_request(self->q, req,
-					msg->request_resume_registration);
-		grilio_request_unref(req);
-	}
-}
-
-static GRilIoRequest *ril_vendor_mtk_build_set_attach_apn_req
-			(const struct ofono_gprs_primary_context *pc,
-						gboolean roamingProtocol)
-{
-	GRilIoRequest *req = grilio_request_new();
-	const char *proto = ril_data_ofono_protocol_to_ril(pc->proto);
-
-	DBG("%s %d", pc->apn, roamingProtocol);
-	grilio_request_append_utf8(req, pc->apn);       /* apn */
-	grilio_request_append_utf8(req, proto);         /* protocol */
-	if (roamingProtocol) {
-		grilio_request_append_utf8(req, proto); /* roamingProtocol */
-	}
-
-	if (pc->username[0]) {
-		int auth;
-
-		switch (pc->auth_method) {
-		case OFONO_GPRS_AUTH_METHOD_ANY:
-			auth = RIL_AUTH_BOTH;
-			break;
-		case OFONO_GPRS_AUTH_METHOD_NONE:
-			auth = RIL_AUTH_NONE;
-			break;
-		case OFONO_GPRS_AUTH_METHOD_CHAP:
-			auth = RIL_AUTH_CHAP;
-			break;
-		case OFONO_GPRS_AUTH_METHOD_PAP:
-			auth = RIL_AUTH_PAP;
-			break;
-		default:
-			auth = RIL_AUTH_NONE;
-			break;
-		}
-
-		grilio_request_append_int32(req, auth);
-		grilio_request_append_utf8(req, pc->username);
-		grilio_request_append_utf8(req, pc->password);
-	} else {
-		grilio_request_append_int32(req, RIL_AUTH_NONE);
-		grilio_request_append_utf8(req, "");
-		grilio_request_append_utf8(req, "");
-	}
-
-	grilio_request_append_utf8(req, ""); /* operatorNumeric */
-	grilio_request_append_int32(req, FALSE); /* canHandleIms */
-	grilio_request_append_int32(req, -1); /* dualApnPlmnList */
-
-	return req;
-}
-
-static const struct ofono_gprs_primary_context *ril_vendor_mtk_internet_context
-					(struct ril_vendor_hook_mtk *self)
-{
-	struct sailfish_watch *watch = self->watch;
-
-	if (watch->imsi) {
-		struct ofono_atom *atom = __ofono_modem_find_atom(watch->modem,
-							OFONO_ATOM_TYPE_GPRS);
-
-		if (atom) {
-			return __ofono_gprs_context_settings_by_type
-				(__ofono_atom_get_data(atom),
-					OFONO_GPRS_CONTEXT_TYPE_INTERNET);
-		}
-	}
-
-	return NULL;
-}
-
-static void ril_vendor_mtk_initial_attach_apn_resp(GRilIoChannel *io,
-		int ril_status, const void *data, guint len, void *user_data)
-{
-	struct ril_vendor_hook_mtk *self = user_data;
-
-	GASSERT(self->set_initial_attach_apn_id);
-	self->set_initial_attach_apn_id = 0;
-	if (ril_status == RIL_E_SUCCESS) {
-		DBG("ok");
-		self->initial_attach_apn_ok = TRUE;
-	}
-}
-
-static void ril_vendor_mtk_initial_attach_apn_check
-					(struct ril_vendor_hook_mtk *self)
-{
-
-	if (!self->set_initial_attach_apn_id && !self->initial_attach_apn_ok) {
-		const struct ofono_gprs_primary_context *pc =
-			ril_vendor_mtk_internet_context(self);
-
-		if (pc) {
-			GRilIoRequest *req =
-				ril_vendor_mtk_build_set_attach_apn_req(pc,
-				self->msg->attach_apn_has_roaming_protocol);
-
-			grilio_request_set_timeout(req,
-					SET_INITIAL_ATTACH_APN_TIMEOUT);
-			self->set_initial_attach_apn_id =
-				grilio_queue_send_request_full(self->q, req,
-					RIL_REQUEST_SET_INITIAL_ATTACH_APN,
-					ril_vendor_mtk_initial_attach_apn_resp,
-					NULL, self);
-			grilio_request_unref(req);
-		}
-	}
-}
-
-static void ril_vendor_mtk_initial_attach_apn_reset
-					(struct ril_vendor_hook_mtk *self)
-{
-	self->initial_attach_apn_ok = FALSE;
-	if (self->set_initial_attach_apn_id) {
-		grilio_queue_cancel_request(self->q,
-			self->set_initial_attach_apn_id, FALSE);
-		self->set_initial_attach_apn_id = 0;
-	}
-}
-
-static void ril_vendor_mtk_watch_imsi_changed(struct sailfish_watch *watch,
-							void *user_data)
-{
-	struct ril_vendor_hook_mtk *self = user_data;
-
-	if (watch->imsi) {
-		ril_vendor_mtk_initial_attach_apn_check(self);
-	} else {
-		ril_vendor_mtk_initial_attach_apn_reset(self);
-	}
-}
-
-static void ril_vendor_mtk_network_pref_mode_changed(struct ril_network *net,
-							void *user_data)
-{
-	struct ril_vendor_hook_mtk *self = user_data;
-
-	if (net->pref_mode >= OFONO_RADIO_ACCESS_MODE_LTE) {
-		ril_vendor_mtk_initial_attach_apn_check(self);
-	} else {
-		ril_vendor_mtk_initial_attach_apn_reset(self);
-	}
-}
-
-static void ril_vendor_mtk_set_attach_apn(GRilIoChannel *io, guint id,
-				const void *data, guint len, void *self)
-{
-	ril_vendor_mtk_initial_attach_apn_check(self);
-}
-
-static void ril_vendor_mtk_ps_network_state_changed(GRilIoChannel *io,
-		guint id, const void *data, guint len, void *user_data)
-{
-	struct ril_vendor_hook_mtk *self = user_data;
-
-	ril_network_query_registration_state(self->network);
-}
-
-static void ril_vendor_mtk_incoming_call_indication(GRilIoChannel *io, guint id,
-				const void *data, guint len, void *user_data)
-{
-	struct ril_vendor_hook_mtk *self = user_data;
-	const struct ril_mtk_msg *msg = self->msg;
-	GRilIoRequest* req = NULL;
-
-	GASSERT(id == msg->unsol_incoming_call_indication);
-
-	if (msg->request_set_call_indication) {
-		int nparams, cid, seq;
-		gchar *call_id = NULL, *seq_no = NULL;
-		GRilIoParser rilp;
-
-		grilio_parser_init(&rilp, data, len);
-
-		if (grilio_parser_get_int32(&rilp, &nparams) && nparams >= 5 &&
-			(call_id = grilio_parser_get_utf8(&rilp)) != NULL &&
-			grilio_parser_skip_string(&rilp) /* number */ &&
-			grilio_parser_skip_string(&rilp) /* type */ &&
-			grilio_parser_skip_string(&rilp) /* call_mode */ &&
-			(seq_no = grilio_parser_get_utf8(&rilp)) != NULL &&
-				gutil_parse_int(call_id, 10, &cid) &&
-				gutil_parse_int(seq_no, 10, &seq)) {
-
-			DBG("slot=%u,cid=%d,seq=%d", self->slot, cid, seq);
-			req = grilio_request_new();
-			grilio_request_append_int32(req, 3); /* Param count */
-			/* mode - IMS_ALLOW_INCOMING_CALL_INDICATION: */
-			grilio_request_append_int32(req, 0);
-			grilio_request_append_int32(req, cid);
-			grilio_request_append_int32(req, seq);
-		} else {
-			DBG("failed to parse INCOMING_CALL_INDICATION");
-		}
-
-		g_free(call_id);
-		g_free(seq_no);
-	}
-
-	if (req) {
-		grilio_queue_send_request(self->q, req,
-					msg->request_set_call_indication);
-		grilio_request_unref(req);
-	} else {
-		/* Let ril_voicecall.c know that something happened */
-		grilio_channel_inject_unsol_event(io,
-				RIL_UNSOL_RESPONSE_CALL_STATE_CHANGED, NULL, 0);
-	}
-}
-
-static GRilIoRequest *ril_vendor_mtk_data_call_req
-	(struct ril_vendor_hook *hook, int tech, const char *profile,
-		const char *apn, const char *username, const char *password,
-		enum ril_auth auth, const char *proto)
-{
-	struct ril_vendor_hook_mtk *self = ril_vendor_hook_mtk_cast(hook);
-	GRilIoRequest *req = grilio_request_new();
-
-	grilio_request_append_int32(req, 8); /* Number of parameters */
-	grilio_request_append_format(req, "%d", tech);
-	grilio_request_append_utf8(req, profile);
-	grilio_request_append_utf8(req, apn);
-	grilio_request_append_utf8(req, username);
-	grilio_request_append_utf8(req, password);
-	grilio_request_append_format(req, "%d", auth);
-	grilio_request_append_utf8(req, proto);
-	grilio_request_append_format(req, "%d", self->slot+1);
-	return req;
-}
-
-static gboolean ril_vendor_mtk_data_call_parse_v6(struct ril_vendor_hook *hook,
-			struct ril_data_call *call, int version,
-			GRilIoParser *rilp)
-{
-	if (version < 11) {
-		int prot;
-		char *prot_str;
-		guint32 status = PDP_FAIL_ERROR_UNSPECIFIED;
-		guint32 active = RIL_DATA_CALL_INACTIVE;
-
-		/* RIL_Data_Call_Response_v6 with MTK specific additions */
-		grilio_parser_get_uint32(rilp, &status);
-		grilio_parser_get_int32(rilp, &call->retry_time);
-		grilio_parser_get_int32(rilp, &call->cid);
-		grilio_parser_get_uint32(rilp, &active);
-		grilio_parser_get_int32(rilp, &call->mtu); /* MTK specific */
-		prot_str = grilio_parser_get_utf8(rilp);
-		prot = ril_data_protocol_to_ofono(prot_str);
-		g_free(prot_str);
-
-		if (prot >= 0) {
-			call->ifname = grilio_parser_get_utf8(rilp);
-			call->addresses = grilio_parser_split_utf8(rilp, " ");
-			call->dnses = grilio_parser_split_utf8(rilp, " ");
-			call->gateways = grilio_parser_split_utf8(rilp, " ");
-			if (call->ifname && call->addresses) {
-				call->prot = prot;
-				call->status = status;
-				call->active = active;
-				return TRUE;
-			}
-		}
-	}
-	return FALSE;
-}
-
-static void ril_vendor_mtk_get_defaults(struct ril_vendor_defaults *defaults)
-{
-	/*
-	 * With most Qualcomm RIL implementations, querying available band
-	 * modes causes some magic Android properties to appear. Otherwise
-	 * this request is pretty harmless and useless.
-	 *
-	 * Most MediaTek RIL implementations don't support this request and
-	 * don't even bother to reply which slows things down because we wait
-	 * for this request to complete at startup.
-	 */
-	defaults->query_available_band_mode = FALSE;
-	defaults->empty_pin_query = FALSE;
-	defaults->legacy_imei_query = TRUE;
-}
-
-static void ril_vendor_mtk_hook_subscribe(struct ril_vendor_hook_mtk *self)
-{
-	const struct ril_mtk_msg *msg = self->msg;
-
-	self->ril_event_id[MTK_EVENT_REGISTRATION_SUSPENDED] =
-			grilio_channel_add_unsol_event_handler(self->io,
-				ril_vendor_mtk_registration_suspended,
-				msg->unsol_registration_suspended, self);
-	if (msg->unsol_set_attach_apn) {
-		self->ril_event_id[MTK_EVENT_SET_ATTACH_APN] =
-			grilio_channel_add_unsol_event_handler(self->io,
-				ril_vendor_mtk_set_attach_apn,
-				msg->unsol_set_attach_apn, self);
-	}
-	if (msg->unsol_ps_network_state_changed) {
-		self->ril_event_id[MTK_EVENT_PS_NETWORK_STATE_CHANGED] =
-			grilio_channel_add_unsol_event_handler(self->io,
-				ril_vendor_mtk_ps_network_state_changed,
-				msg->unsol_ps_network_state_changed, self);
-	}
-	if (msg->unsol_incoming_call_indication) {
-		self->ril_event_id[MTK_EVENT_INCOMING_CALL_INDICATION] =
-			grilio_channel_add_unsol_event_handler(self->io,
-				ril_vendor_mtk_incoming_call_indication,
-				msg->unsol_incoming_call_indication, self);
-	}
-}
-
-static void ril_vendor_mtk_hook_init(struct ril_vendor_hook_mtk *self,
-	const struct ril_vendor_mtk_driver_data *mtk_driver_data,
-	ril_vendor_hook_free_proc free, GRilIoChannel *io, const char *path,
-	const struct ril_slot_config *config, struct ril_network *network)
-{
-	self->msg = mtk_driver_data->msg;
-	self->q = grilio_queue_new(io);
-	self->io = grilio_channel_ref(io);
-	self->watch = sailfish_watch_new(path);
-	self->slot = config->slot;
-	self->network = ril_network_ref(network);
-	self->watch_event_id[WATCH_EVENT_IMSI_CHANGED] =
-			sailfish_watch_add_imsi_changed_handler(self->watch,
-				ril_vendor_mtk_watch_imsi_changed, self);
-	self->network_event_id[NETWORK_EVENT_PREF_MODE_CHANGED] =
-			ril_network_add_pref_mode_changed_handler(self->network,
-				ril_vendor_mtk_network_pref_mode_changed, self);
-	ril_vendor_mtk_hook_subscribe(self);
-	ril_vendor_hook_init(&self->hook, mtk_driver_data->proc, free);
-}
-
-static void ril_vendor_mtk_destroy(struct ril_vendor_hook_mtk *self)
-{
-	grilio_queue_cancel_all(self->q, FALSE);
-	grilio_channel_remove_all_handlers(self->io, self->ril_event_id);
-	grilio_queue_unref(self->q);
-	grilio_channel_unref(self->io);
-	sailfish_watch_remove_all_handlers(self->watch, self->watch_event_id);
-	sailfish_watch_unref(self->watch);
-	ril_network_remove_all_handlers(self->network, self->network_event_id);
-	ril_network_unref(self->network);
-}
-
-static void ril_vendor_mtk_free(struct ril_vendor_hook *hook)
-{
-	struct ril_vendor_hook_mtk *self = ril_vendor_hook_mtk_cast(hook);
-
-	DBG("slot %u", self->slot);
-	ril_vendor_mtk_destroy(self);
-	g_free(self);
-}
-
-static struct ril_vendor_hook *ril_vendor_mtk_create_hook_from_data
-		(const void *driver_data, GRilIoChannel *io, const char *path,
-					const struct ril_slot_config *config,
-					struct ril_network *network)
-{
-	const struct ril_vendor_mtk_driver_data *mtk_driver_data = driver_data;
-	struct ril_vendor_hook_mtk *self =
-		g_new0(struct ril_vendor_hook_mtk, 1);
-
-	ril_vendor_mtk_hook_init(self, mtk_driver_data, ril_vendor_mtk_free,
-						io, path, config, network);
-	DBG("%s slot %u", mtk_driver_data->name, self->slot);
-	return &self->hook;
-}
-
-static const struct ril_vendor_hook_proc ril_vendor_mtk_hook_base_proc = {
-	.request_to_string  = ril_vendor_mtk_request_to_string,
-	.event_to_string    = ril_vendor_mtk_event_to_string,
-	.data_call_req      = ril_vendor_mtk_data_call_req
-};
-
-static const struct ril_vendor_driver ril_vendor_mtk_base = {
-	.get_defaults       = ril_vendor_mtk_get_defaults,
-	.create_hook        = ril_vendor_mtk_create_hook_from_data
-};
-
-static const struct ril_vendor_mtk_driver_data ril_vendor_mtk1_data = {
-	.name               = "mtk1",
-	.msg                = &msg_mtk1,
-	.proc               = &ril_vendor_mtk_hook_base_proc
-};
-
-static struct ril_vendor_hook_proc ril_vendor_mtk2_proc = {
-	.base               = &ril_vendor_mtk_hook_base_proc,
-	.data_call_parse    = ril_vendor_mtk_data_call_parse_v6
-};
-
-static const struct ril_vendor_mtk_driver_data ril_vendor_mtk2_data = {
-	.name               = "mtk2",
-	.msg                = &msg_mtk2,
-	.proc               = &ril_vendor_mtk2_proc
-};
-
-#define DEFAULT_MTK_TYPE (&ril_vendor_mtk1_data)
-
-static const struct ril_vendor_mtk_driver_data *mtk_types [] = {
-	&ril_vendor_mtk1_data,
-	&ril_vendor_mtk2_data
-};
-
-RIL_VENDOR_DRIVER_DEFINE(ril_vendor_driver_mtk1) {
-	.name               = "mtk1",
-	.driver_data        = &ril_vendor_mtk1_data,
-	.base               = &ril_vendor_mtk_base
-};
-
-RIL_VENDOR_DRIVER_DEFINE(ril_vendor_driver_mtk2) {
-	.name               = "mtk2",
-	.driver_data        = &ril_vendor_mtk2_data,
-	.base               = &ril_vendor_mtk_base
-};
-
-/* Auto-selection */
-
-static gboolean ril_vendor_mtk_auto_set_type
-			(struct ril_vendor_hook_mtk_auto *self,
-				const struct ril_vendor_mtk_driver_data *type)
-{
-	struct ril_vendor_hook_mtk *mtk = &self->mtk;
-	gboolean changed = FALSE;
-
-	if (self->type != type) {
-		DBG("switching type %s -> %s", self->type->name, type->name);
-		self->type = type;
-		mtk->msg = type->msg;
-		mtk->hook.proc = type->proc;
-		grilio_channel_remove_all_handlers(mtk->io, mtk->ril_event_id);
-		ril_vendor_mtk_hook_subscribe(mtk);
-		changed = TRUE;
-	}
-
-	grilio_channel_remove_handler(mtk->io, self->detect_id);
-	self->detect_id = 0;
-	return changed;
-}
-
-static void ril_vendor_mtk_auto_detect_event(GRilIoChannel *io, guint id,
-				const void *data, guint len, void *self)
-{
-	guint i;
-
-	for (i = 0; i < G_N_ELEMENTS(mtk_types); i++) {
-		const struct ril_vendor_mtk_driver_data *type = mtk_types[i];
-		const struct ril_mtk_msg *msg = type->msg;
-		const guint *ids = &msg->unsol_msgs;
-		guint j;
-
-		for (j = 0; j < MTK_UNSOL_MSGS; j++) {
-			if (ids[j] == id) {
-				DBG("event %u is %s %s", id, type->name,
-					ril_vendor_mtk_unsol_msg_name(msg,id));
-				if (ril_vendor_mtk_auto_set_type(self, type)) {
-					/* And repeat the event to invoke
-					 * the handler */
-					grilio_channel_inject_unsol_event(io,
-								id, data, len);
-				}
-				return;
-			}
-		}
-	}
-}
-
-static void ril_vendor_mtk_auto_free(struct ril_vendor_hook *hook)
-{
-	struct ril_vendor_hook_mtk_auto *self =
-		ril_vendor_hook_mtk_auto_cast(hook);
-	struct ril_vendor_hook_mtk *mtk = &self->mtk;
-
-	DBG("slot %u", mtk->slot);
-	grilio_channel_remove_handler(mtk->io, self->detect_id);
-	ril_vendor_mtk_destroy(mtk);
-	g_free(self);
-}
-
-static struct ril_vendor_hook *ril_vendor_mtk_create_hook_auto
-	(const void *driver_data, GRilIoChannel *io, const char *path,
-		const struct ril_slot_config *cfg, struct ril_network *network)
-{
-	struct ril_vendor_hook_mtk_auto *self =
-		g_new0(struct ril_vendor_hook_mtk_auto, 1);
-	struct ril_vendor_hook_mtk *mtk = &self->mtk;
-
-	/* Pick the default */
-	self->type = DEFAULT_MTK_TYPE;
-	ril_vendor_mtk_hook_init(mtk, self->type, ril_vendor_mtk_auto_free,
-						io, path, cfg, network);
-	DBG("%s slot %u", self->type->name, mtk->slot);
-
-	/*
-	 * Subscribe for (all) unsolicited events. Keep on listening until
-	 * we receive an MTK specific event that tells us which particular
-	 * kind of MTK adaptation we are using.
-	 */
-	self->detect_id = grilio_channel_add_unsol_event_handler(mtk->io,
-				ril_vendor_mtk_auto_detect_event, 0, self);
-	return &mtk->hook;
-}
-
-RIL_VENDOR_DRIVER_DEFINE(ril_vendor_driver_mtk) {
-	.name               = "mtk",
-	.get_defaults       = ril_vendor_mtk_get_defaults,
-	.create_hook        = ril_vendor_mtk_create_hook_auto
-};
-
-/*
- * Local Variables:
- * mode: C
- * c-basic-offset: 8
- * indent-tabs-mode: t
- * End:
- */

ofono/drivers/ril/ril_voicecall.c

@@ -1,7 +1,7 @@
 /*
  *  oFono - Open Source Telephony - RIL-based devices
  *
- *  Copyright (C) 2015-2018 Jolla Ltd.
+ *  Copyright (C) 2015-2017 Jolla Ltd.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -14,6 +14,7 @@
  */
 
 #include "ril_plugin.h"
+#include "ril_constants.h"
 #include "ril_ecclist.h"
 #include "ril_util.h"
 #include "ril_log.h"
@@ -22,13 +23,9 @@
 
 #include <gutil_ints.h>
 #include <gutil_ring.h>
-#include <gutil_idlequeue.h>
-#include <gutil_intarray.h>
 
 #define FLAG_NEED_CLIP 1
 
-#define VOICECALL_BLOCK_TIMEOUT_MS (5*1000)
-
 enum ril_voicecall_events {
 	VOICECALL_EVENT_CALL_STATE_CHANGED,
 	VOICECALL_EVENT_SUPP_SVC_NOTIFICATION,
@@ -42,11 +39,11 @@ struct ril_voicecall {
 	GRilIoQueue *q;
 	struct ofono_voicecall *vc;
 	struct ril_ecclist *ecclist;
+	unsigned int local_release;
 	unsigned char flags;
 	ofono_voicecall_cb_t cb;
 	void *data;
-	GUtilIntArray *local_release_ids;
-	GUtilIdleQueue *idleq;
+	guint timer_id;
 	GUtilRing *dtmf_queue;
 	GUtilInts *local_hangup_reasons;
 	GUtilInts *remote_hangup_reasons;
@@ -58,13 +55,11 @@ struct ril_voicecall {
 	gulong ecclist_change_id;
 };
 
-struct ril_voicecall_request_data {
-	int ref_count;
-	int pending_call_count;
-	int success;
+struct ril_voicecall_change_state_req {
 	struct ofono_voicecall *vc;
 	ofono_voicecall_cb_t cb;
 	gpointer data;
+	int affected_types;
 };
 
 struct lastcause_req {
@@ -75,32 +70,6 @@ struct lastcause_req {
 static void ril_voicecall_send_one_dtmf(struct ril_voicecall *vd);
 static void ril_voicecall_clear_dtmf_queue(struct ril_voicecall *vd);
 
-struct ril_voicecall_request_data *ril_voicecall_request_data_new
-	(struct ofono_voicecall *vc, ofono_voicecall_cb_t cb, void *data)
-{
-	struct ril_voicecall_request_data *req =
-		g_slice_new0(struct ril_voicecall_request_data);
-
-	req->ref_count = 1;
-	req->vc = vc;
-	req->cb = cb;
-	req->data = data;
-	return req;
-}
-
-static void ril_voicecall_request_data_unref
-				(struct ril_voicecall_request_data *req)
-{
-	if (!--req->ref_count) {
-		g_slice_free(struct ril_voicecall_request_data, req);
-	}
-}
-
-static void ril_voicecall_request_data_free(gpointer data)
-{
-	ril_voicecall_request_data_unref(data);
-}
-
 static inline struct ril_voicecall *ril_voicecall_get_data(
 						struct ofono_voicecall *vc)
 {
@@ -306,8 +275,7 @@ static void ril_voicecall_lastcause_cb(GRilIoChannel *io, int status,
 		case CALL_FAIL_ERROR_UNSPECIFIED:
 			call_status = ril_voicecall_status_with_id(vc, id);
 			if (call_status == CALL_STATUS_DIALING ||
-			    call_status == CALL_STATUS_ALERTING ||
-			    call_status == CALL_STATUS_INCOMING) {
+			    call_status == CALL_STATUS_ALERTING) {
 				reason = OFONO_DISCONNECT_REASON_REMOTE_HANGUP;
 			}
 			break;
@@ -335,18 +303,14 @@ static void ril_voicecall_clcc_poll_cb(GRilIoChannel *io, int status,
 	GASSERT(vd->clcc_poll_id);
 	vd->clcc_poll_id = 0;
 
-	/*
-	 * Only RIL_E_SUCCESS and RIL_E_RADIO_NOT_AVAILABLE are expected here,
-	 * all other errors are filtered out by ril_voicecall_clcc_retry()
-	 */
-	if (status == RIL_E_SUCCESS) {
-		calls = ril_voicecall_parse_clcc(data, len);
-	} else {
-		/* RADIO_NOT_AVAILABLE == no calls */
-		GASSERT(status == RIL_E_RADIO_NOT_AVAILABLE);
-		calls = NULL;
+	if (status != RIL_E_SUCCESS) {
+		ofono_error("We are polling CLCC and received an error");
+		ofono_error("All bets are off for call management");
+		return;
 	}
 
+	calls = ril_voicecall_parse_clcc(data, len);
+
 	n = calls;
 	o = vd->calls;
 
@@ -355,9 +319,7 @@ static void ril_voicecall_clcc_poll_cb(GRilIoChannel *io, int status,
 		struct ofono_call *oc = o ? o->data : NULL;
 
 		if (oc && (nc == NULL || (nc->id > oc->id))) {
-			/* old call is gone */
-			if (gutil_int_array_remove_all_fast(
-					vd->local_release_ids, oc->id)) {
+			if (vd->local_release & (1 << oc->id)) {
 				ofono_voicecall_disconnected(vd->vc, oc->id,
 					OFONO_DISCONNECT_REASON_LOCAL_HANGUP,
 					NULL);
@@ -437,19 +399,9 @@ static void ril_voicecall_clcc_poll_cb(GRilIoChannel *io, int status,
 	}
 
 	g_slist_free_full(vd->calls, g_free);
-	vd->calls = calls;
-}
 
-static gboolean ril_voicecall_clcc_retry(GRilIoRequest* req, int ril_status,
-		const void* response_data, guint response_len, void* user_data)
-{
-	switch (ril_status) {
-	case RIL_E_SUCCESS:
-	case RIL_E_RADIO_NOT_AVAILABLE:
-		return FALSE;
-	default:
-		return TRUE;
-	}
+	vd->calls = calls;
+	vd->local_release = 0;
 }
 
 static void ril_voicecall_clcc_poll(struct ril_voicecall *vd)
@@ -458,7 +410,6 @@ static void ril_voicecall_clcc_poll(struct ril_voicecall *vd)
 	if (!vd->clcc_poll_id) {
 		GRilIoRequest* req = grilio_request_new();
 		grilio_request_set_retry(req, RIL_RETRY_MS, -1);
-		grilio_request_set_retry_func(req, ril_voicecall_clcc_retry);
 		vd->clcc_poll_id = grilio_queue_send_request_full(vd->q,
 					req, RIL_REQUEST_GET_CURRENT_CALLS,
 					ril_voicecall_clcc_poll_cb, NULL, vd);
@@ -469,47 +420,52 @@ static void ril_voicecall_clcc_poll(struct ril_voicecall *vd)
 static void ril_voicecall_request_cb(GRilIoChannel *io, int status,
 				const void *data, guint len, void *user_data)
 {
-	struct ril_voicecall_request_data *req = user_data;
+	struct ril_voicecall_change_state_req *req = user_data;
 	struct ril_voicecall *vd = ril_voicecall_get_data(req->vc);
+	struct ofono_error error;
+
+	if (status == RIL_E_SUCCESS) {
+		GSList *l;
+
+		if (req->affected_types) {
+			for (l = vd->calls; l; l = l->next) {
+				struct ofono_call *call = l->data;
+
+				if (req->affected_types & (1 << call->status)) {
+					vd->local_release |= (1 << call->id);
+				}
+			}
+		}
+
+		ril_error_init_ok(&error);
+	} else {
+		ofono_error("generic fail");
+		ril_error_init_failure(&error);
+	}
 
 	ril_voicecall_clcc_poll(vd);
 
-	/*
-	 * The ofono API call is considered successful if at least one
-	 * associated RIL request succeeds.
-	 */
-	if (status == RIL_E_SUCCESS) {
-		req->success++;
-	}
-
-	/*
-	 * Only invoke the callback if this is the last request associated
-	 * with this ofono api call (pending call count becomes zero).
-	 */
-	GASSERT(req->pending_call_count > 0);
-	if (!--req->pending_call_count && req->cb) {
-		struct ofono_error error;
-
-		if (req->success) {
-			ril_error_init_ok(&error);
-		} else {
-			ril_error_init_failure(&error);
-		}
-
+	/* We have to callback after we schedule a poll if required */
+	if (req->cb) {
 		req->cb(&error, req->data);
 	}
 }
 
-static void ril_voicecall_request(const guint code, struct ofono_voicecall *vc,
-		GRilIoRequest *req, ofono_voicecall_cb_t cb, void *data)
+static void ril_voicecall_request(const guint rreq, struct ofono_voicecall *vc,
+		unsigned int affected_types, GRilIoRequest *ioreq,
+		ofono_voicecall_cb_t cb, void *data)
 {
-	struct ril_voicecall_request_data *req_data =
-		ril_voicecall_request_data_new(vc, cb, data);
+	struct ril_voicecall *vd = ril_voicecall_get_data(vc);
+	struct ril_voicecall_change_state_req *req;
 
-	req_data->pending_call_count++;
-	grilio_queue_send_request_full(ril_voicecall_get_data(vc)->q, req,
-				code, ril_voicecall_request_cb,
-				ril_voicecall_request_data_free, req_data);
+	req = g_new0(struct ril_voicecall_change_state_req, 1);
+	req->vc = vc;
+	req->cb = cb;
+	req->data = data;
+	req->affected_types = affected_types;
+
+	grilio_queue_send_request_full(vd->q, ioreq, rreq,
+				ril_voicecall_request_cb, g_free, req);
 }
 
 static void ril_voicecall_dial_cb(GRilIoChannel *io, int status,
@@ -567,104 +523,47 @@ static void ril_voicecall_dial(struct ofono_voicecall *vc,
 	grilio_request_unref(req);
 }
 
-static void ril_voicecall_submit_hangup_req(struct ofono_voicecall *vc,
-			int id, struct ril_voicecall_request_data *req)
-{
-	struct ril_voicecall *vd = ril_voicecall_get_data(vc);
-	GRilIoRequest *ioreq = grilio_request_array_int32_new(1, id);
-
-	/* Append the call id to the list of calls being released locally */
-	GASSERT(!gutil_int_array_contains(vd->local_release_ids, id));
-	gutil_int_array_append(vd->local_release_ids, id);
-
-	/* Send request to RIL. ril_voicecall_request_data_free will unref
-	 * the request data */
-	req->ref_count++;
-	req->pending_call_count++;
-	grilio_queue_send_request_full(vd->q, ioreq, RIL_REQUEST_HANGUP,
-				ril_voicecall_request_cb,
-				ril_voicecall_request_data_free, req);
-	grilio_request_unref(ioreq);
-}
-
-static void ril_voicecall_hangup(struct ofono_voicecall *vc,
-			gboolean (*filter)(struct ofono_call *call),
-			ofono_voicecall_cb_t cb, void *data)
-{
-	struct ril_voicecall *vd = ril_voicecall_get_data(vc);
-	struct ril_voicecall_request_data *req = NULL;
-	GSList *l;
-
-	/*
-	 * Here the idea is that we submit (potentially) multiple
-	 * hangup requests to RIL and invoke the callback after
-	 * the last request has completed (pending call count
-	 * becomes zero).
-	 */
-	for (l = vd->calls; l; l = l->next) {
-		struct ofono_call *call = l->data;
-
-		if (!filter || filter(call)) {
-			if (!req) {
-				req = ril_voicecall_request_data_new(vc, cb,
-									data);
-			}
-
-			/* Send request to RIL */
-			DBG("Hanging up call with id %d", call->id);
-			ril_voicecall_submit_hangup_req(vc, call->id, req);
-		} else {
-			DBG("Skipping call with id %d", call->id);
-		}
-	}
-
-	if (req) {
-		/* Release our reference (if any) */
-		ril_voicecall_request_data_unref(req);
-	} else {
-		/* No requests were submitted */
-		struct ofono_error error;
-		cb(ril_error_ok(&error), data);
-	}
-}
-
-static gboolean ril_voicecall_hangup_active_filter(struct ofono_call *call)
-{
-	switch (call->status) {
-	case CALL_STATUS_ACTIVE:
-	case CALL_STATUS_DIALING:
-	case CALL_STATUS_ALERTING:
-	case CALL_STATUS_INCOMING:
-		return TRUE;
-	case CALL_STATUS_HELD:
-	case CALL_STATUS_WAITING:
-	case CALL_STATUS_DISCONNECTED:
-		break;
-	}
-	return FALSE;
-}
-
-static void ril_voicecall_hangup_active(struct ofono_voicecall *vc,
-			ofono_voicecall_cb_t cb, void *data)
-{
-	ril_voicecall_hangup(vc, ril_voicecall_hangup_active_filter, cb, data);
-}
-
 static void ril_voicecall_hangup_all(struct ofono_voicecall *vc,
 			ofono_voicecall_cb_t cb, void *data)
 {
-	ril_voicecall_hangup(vc, NULL, cb, data);
+	struct ril_voicecall *vd = ril_voicecall_get_data(vc);
+	struct ofono_error error;
+	GSList *l;
+
+	for (l = vd->calls; l; l = l->next) {
+		struct ofono_call *call = l->data;
+		GRilIoRequest *req = grilio_request_sized_new(8);
+
+		/* TODO: Hangup just the active ones once we have call
+		 * state tracking (otherwise it can't handle ringing) */
+		DBG("Hanging up call with id %d", call->id);
+		grilio_request_append_int32(req, 1); /* Always 1 - AT+CHLD=1x */
+		grilio_request_append_int32(req, call->id);
+
+		/* Send request to RIL */
+		ril_voicecall_request(RIL_REQUEST_HANGUP, vc, 0x3f, req,
+								NULL, NULL);
+		grilio_request_unref(req);
+	}
+
+	/* TODO: Deal in case of an error at hungup */
+	cb(ril_error_ok(&error), data);
 }
 
-static void ril_voicecall_release_specific(struct ofono_voicecall *vc,
+static void ril_voicecall_hangup_specific(struct ofono_voicecall *vc,
 		int id, ofono_voicecall_cb_t cb, void *data)
 {
-	struct ril_voicecall_request_data *req =
-		ril_voicecall_request_data_new(vc, cb, data);
+	GRilIoRequest *req = grilio_request_sized_new(8);
+	struct ofono_error error;
 
 	DBG("Hanging up call with id %d", id);
-	ril_voicecall_submit_hangup_req(vc, id, req);
-	ril_voicecall_request_data_unref(req);
+	grilio_request_append_int32(req, 1); /* Always 1 - AT+CHLD=1x */
+	grilio_request_append_int32(req, id);
+
+	/* Send request to RIL */
+	ril_voicecall_request(RIL_REQUEST_HANGUP, vc, 0x3f, req, NULL, NULL);
+	grilio_request_unref(req);
+	cb(ril_error_ok(&error), data);
 }
 
 static void ril_voicecall_call_state_changed_event(GRilIoChannel *io,
@@ -693,7 +592,7 @@ static void ril_voicecall_supp_svc_notification_event(GRilIoChannel *io,
 	grilio_parser_get_int32(&rilp, &type);
 	grilio_parser_get_int32(&rilp, &code);
 	grilio_parser_get_int32(&rilp, &index);
-	grilio_parser_get_int32(&rilp, &phone.type);
+	grilio_parser_get_int32(&rilp, NULL);
 	tmp = grilio_parser_get_utf8(&rilp);
 
 	if (tmp) {
@@ -719,7 +618,7 @@ static void ril_voicecall_answer(struct ofono_voicecall *vc,
 {
 	/* Send request to RIL */
 	DBG("Answering current call");
-	ril_voicecall_request(RIL_REQUEST_ANSWER, vc, NULL, cb, data);
+	ril_voicecall_request(RIL_REQUEST_ANSWER, vc, 0, NULL, cb, data);
 }
 
 static void ril_voicecall_send_dtmf_cb(GRilIoChannel *io, int status,
@@ -788,25 +687,29 @@ static void ril_voicecall_clear_dtmf_queue(struct ril_voicecall *vd)
 static void ril_voicecall_create_multiparty(struct ofono_voicecall *vc,
 			ofono_voicecall_cb_t cb, void *data)
 {
-	ril_voicecall_request(RIL_REQUEST_CONFERENCE, vc, NULL, cb, data);
+	ril_voicecall_request(RIL_REQUEST_CONFERENCE,
+			vc, 0, NULL, cb, data);
 }
 
 static void ril_voicecall_transfer(struct ofono_voicecall *vc,
 			ofono_voicecall_cb_t cb, void *data)
 {
 	ril_voicecall_request(RIL_REQUEST_EXPLICIT_CALL_TRANSFER,
-						vc, NULL, cb, data);
+			vc, 0, NULL, cb, data);
 }
 
 static void ril_voicecall_private_chat(struct ofono_voicecall *vc, int id,
 			ofono_voicecall_cb_t cb, void *data)
 {
-	GRilIoRequest *req = grilio_request_array_int32_new(1, id);
+	GRilIoRequest *req = grilio_request_sized_new(8);
 	struct ofono_error error;
 
 	DBG("Private chat with id %d", id);
+	grilio_request_append_int32(req, 1);
+	grilio_request_append_int32(req, id);
+
 	ril_voicecall_request(RIL_REQUEST_SEPARATE_CONNECTION,
-			vc, req, NULL, NULL);
+			vc, 0, req, NULL, NULL);
 	grilio_request_unref(req);
 	cb(ril_error_ok(&error), data);
 }
@@ -814,51 +717,51 @@ static void ril_voicecall_private_chat(struct ofono_voicecall *vc, int id,
 static void ril_voicecall_swap_without_accept(struct ofono_voicecall *vc,
 			ofono_voicecall_cb_t cb, void *data)
 {
-	DBG("");
 	ril_voicecall_request(RIL_REQUEST_SWITCH_HOLDING_AND_ACTIVE,
-						vc, NULL, cb, data);
+			vc, 0, NULL, cb, data);
 }
 
 static void ril_voicecall_hold_all_active(struct ofono_voicecall *vc,
 			ofono_voicecall_cb_t cb, void *data)
 {
-	DBG("");
 	ril_voicecall_request(RIL_REQUEST_SWITCH_HOLDING_AND_ACTIVE,
-						vc, NULL, cb, data);
+			vc, 0, NULL, cb, data);
 }
 
 static void ril_voicecall_release_all_held(struct ofono_voicecall *vc,
 					ofono_voicecall_cb_t cb, void *data)
 {
-	DBG("");
 	ril_voicecall_request(RIL_REQUEST_HANGUP_WAITING_OR_BACKGROUND,
-						vc, NULL, cb, data);
+			vc, 0, NULL, cb, data);
 }
 
 static void ril_voicecall_release_all_active(struct ofono_voicecall *vc,
 					ofono_voicecall_cb_t cb, void *data)
 {
-	DBG("");
 	ril_voicecall_request(RIL_REQUEST_HANGUP_FOREGROUND_RESUME_BACKGROUND,
-						vc, NULL, cb, data);
+			vc, 0, NULL, cb, data);
 }
 
 static void ril_voicecall_set_udub(struct ofono_voicecall *vc,
 					ofono_voicecall_cb_t cb, void *data)
 {
-	DBG("");
-	ril_voicecall_request(RIL_REQUEST_UDUB, vc, NULL, cb, data);
+	ril_voicecall_request(RIL_REQUEST_HANGUP_WAITING_OR_BACKGROUND,
+			vc, 0, NULL, cb, data);
 }
 
-static void ril_voicecall_enable_supp_svc(struct ril_voicecall *vd)
+static gboolean ril_voicecall_enable_supp_svc(struct ril_voicecall *vd)
 {
-	GRilIoRequest *req = grilio_request_array_int32_new(1, 1);
+	GRilIoRequest *req = grilio_request_sized_new(8);
+
+	grilio_request_append_int32(req, 1); /* size of array */
+	grilio_request_append_int32(req, 1); /* notifications enabled */
 
-	grilio_request_set_timeout(req, VOICECALL_BLOCK_TIMEOUT_MS);
-	grilio_request_set_blocking(req, TRUE);
 	grilio_queue_send_request(vd->q, req,
 				RIL_REQUEST_SET_SUPP_SVC_NOTIFICATION);
 	grilio_request_unref(req);
+
+	/* Makes this a single shot */
+	return FALSE;
 }
 
 static void ril_voicecall_ringback_tone_event(GRilIoChannel *io,
@@ -886,10 +789,12 @@ static void ril_voicecall_ecclist_changed(struct ril_ecclist *list, void *data)
 	ofono_voicecall_en_list_notify(vd->vc, vd->ecclist->list);
 }
 
-static void ril_voicecall_register(gpointer user_data)
+static gboolean ril_delayed_register(gpointer user_data)
 {
 	struct ril_voicecall *vd = user_data;
 
+	GASSERT(vd->timer_id);
+	vd->timer_id = 0;
 	ofono_voicecall_register(vd->vc);
 
 	/* Emergency Call Codes */
@@ -923,6 +828,9 @@ static void ril_voicecall_register(gpointer user_data)
 		grilio_channel_add_unsol_event_handler(vd->io,
 				ril_voicecall_ringback_tone_event,
 				RIL_UNSOL_RINGBACK_TONE, vd);
+
+	/* This makes the timeout a single-shot */
+	return FALSE;
 }
 
 static int ril_voicecall_probe(struct ofono_voicecall *vc, unsigned int vendor,
@@ -939,15 +847,13 @@ static int ril_voicecall_probe(struct ofono_voicecall *vc, unsigned int vendor,
 	vd->dtmf_queue = gutil_ring_new();
 	vd->local_hangup_reasons = gutil_ints_ref(cfg->local_hangup_reasons);
 	vd->remote_hangup_reasons = gutil_ints_ref(cfg->remote_hangup_reasons);
-	vd->local_release_ids = gutil_int_array_new();
-	vd->idleq = gutil_idle_queue_new();
 	vd->vc = vc;
+	vd->timer_id = g_idle_add(ril_delayed_register, vd);
 	if (modem->ecclist_file) {
 		vd->ecclist = ril_ecclist_new(modem->ecclist_file);
 	}
 	ril_voicecall_clear_dtmf_queue(vd);
 	ofono_voicecall_set_data(vc, vd);
-	gutil_idle_queue_add(vd->idleq, ril_voicecall_register, vd);
 	return 0;
 }
 
@@ -959,6 +865,10 @@ static void ril_voicecall_remove(struct ofono_voicecall *vc)
 	ofono_voicecall_set_data(vc, NULL);
 	g_slist_free_full(vd->calls, g_free);
 
+	if (vd->timer_id > 0) {
+		g_source_remove(vd->timer_id);
+	}
+
 	ril_ecclist_remove_handler(vd->ecclist, vd->ecclist_change_id);
 	ril_ecclist_unref(vd->ecclist);
 
@@ -970,8 +880,6 @@ static void ril_voicecall_remove(struct ofono_voicecall *vc)
 	gutil_ring_unref(vd->dtmf_queue);
 	gutil_ints_unref(vd->local_hangup_reasons);
 	gutil_ints_unref(vd->remote_hangup_reasons);
-	gutil_int_array_free(vd->local_release_ids, TRUE);
-	gutil_idle_queue_free(vd->idleq);
 	g_free(vd);
 }
 
@@ -981,9 +889,8 @@ const struct ofono_voicecall_driver ril_voicecall_driver = {
 	.remove                 = ril_voicecall_remove,
 	.dial                   = ril_voicecall_dial,
 	.answer                 = ril_voicecall_answer,
-	.hangup_active          = ril_voicecall_hangup_active,
 	.hangup_all             = ril_voicecall_hangup_all,
-	.release_specific       = ril_voicecall_release_specific,
+	.release_specific       = ril_voicecall_hangup_specific,
 	.send_tones             = ril_voicecall_send_dtmf,
 	.create_multiparty      = ril_voicecall_create_multiparty,
 	.transfer               = ril_voicecall_transfer,