ubports-volte/ofono-binder-plugin
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[ofono-binder] Fix double free when SMS sending fails. JB#63132

Browse Source 
Only affects AIDL interface.
Fix an indentation style issue and reduce the scope of some variables.
This commit is contained in:
Matti Lehtimäki
2025-02-11 15:06:51 +02:00
parent fadbe2be24
commit 33f5a70553
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/binder_sms.c
View File

@@ -468,18 +468,19 @@ binder_sms_submit_cb(
(RADIO_MESSAGING_RESP)resp == RADIO_MESSAGING_RESP_SEND_IMS_SMS) {
if (error == RADIO_ERROR_NONE) {
GBinderReader reader;
gint32 message_ref;
char* ack_pdu = NULL;
gint32 error_code;
gbinder_reader_copy(&reader, args);
if (binder_read_parcelable_size(&reader)) {
gint32 message_ref;
char* ack_pdu = NULL;
gint32 error_code;
gbinder_reader_read_int32(&reader, &message_ref);
ack_pdu = gbinder_reader_read_string16(&reader);
gbinder_reader_read_int32(&reader, &error_code);
DBG("%ssms msg ref: %d, ack: %s err: %d", ims ? "ims " : "",
message_ref, ack_pdu, error_code);
message_ref, ack_pdu, error_code);
g_free(ack_pdu);
/*
@@ -495,7 +496,6 @@ binder_sms_submit_cb(
return;
}
}
g_free(ack_pdu);
} else {
ofono_error("%ssms send error %s", ims ? "ims " : "",
binder_radio_error_string(error));