LineageOS/android_development
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify the return value of CompareCommonRecordFields

Browse Source 
Before this commit, the function returns
(kDirectDiff, RecordFieldDiffIR *) or (kIndirectDiff/kNoDiff, nullptr).
The commit changes the return value to a DiffStatus. The caller decides
whether to create a RecordFieldDiffIR by the DiffStatus.

Test: ./test.py
Bug: 255702405
Change-Id: If2bfd5bca78e9d924be34ad5c522db9b91382cde
This commit is contained in:
Hsin-Yi Chen
2023-02-03 11:34:51 +08:00
parent 28f992d407
commit 3417140281
2 changed files with 20 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
vndk/tools/header-checker/src/repr/abi_diff_helpers.cpp
View File

@@ -366,28 +366,19 @@ static bool CompareSizeAndAlignment(const TypeIR *old_type,
old_type->GetAlignment() == new_type->GetAlignment();
}
DiffStatusPair<std::unique_ptr<RecordFieldDiffIR>>
AbiDiffHelper::CompareCommonRecordFields(
const RecordFieldIR *old_field,
const RecordFieldIR *new_field,
std::deque<std::string> *type_queue,
DiffMessageIR::DiffKind diff_kind) {
DiffStatus field_diff_status =
CompareAndDumpTypeDiff(old_field->GetReferencedType(),
new_field->GetReferencedType(),
type_queue, diff_kind);
DiffStatus AbiDiffHelper::CompareCommonRecordFields(
const RecordFieldIR *old_field, const RecordFieldIR *new_field,
std::deque<std::string> *type_queue, DiffMessageIR::DiffKind diff_kind) {
DiffStatus field_diff_status = CompareAndDumpTypeDiff(
old_field->GetReferencedType(), new_field->GetReferencedType(),
type_queue, diff_kind);
if (old_field->GetOffset() != new_field->GetOffset() ||
// TODO: Should this be an inquality check instead ? Some compilers can
// make signatures dependant on absolute values of access specifiers.
IsAccessDowngraded(old_field->GetAccess(), new_field->GetAccess()) ||
field_diff_status.IsDirectDiff()) {
return std::make_pair(
DiffStatus::kDirectDiff,
std::make_unique<RecordFieldDiffIR>(old_field, new_field));
IsAccessDowngraded(old_field->GetAccess(), new_field->GetAccess())) {
field_diff_status.CombineWith(DiffStatus::kDirectDiff);
}
return std::make_pair(field_diff_status, nullptr);
return field_diff_status;
}
// This function filters out the pairs of old and new fields that meet the
@@ -435,9 +426,8 @@ void AbiDiffHelper::FilterOutRenamedRecordFields(
continue;
}
auto comparison_result =
CompareCommonRecordFields(*old_it, *new_it, type_queue, diff_kind);
if (comparison_result.second != nullptr) {
if (CompareCommonRecordFields(*old_it, *new_it, type_queue, diff_kind)
.IsDirectDiff()) {
out_old_fields.emplace_back(*old_it);
out_new_fields.emplace_back(*new_it);
}
@@ -480,14 +470,14 @@ RecordFieldDiffResult AbiDiffHelper::CompareRecordFields(
utils::FindCommonElements(old_fields_map, new_fields_map);
bool common_field_diff_exists = false;
for (auto &&common_fields : cf) {
auto diffed_field_ptr = CompareCommonRecordFields(
DiffStatus field_diff_status = CompareCommonRecordFields(
common_fields.first, common_fields.second, type_queue, diff_kind);
if (diffed_field_ptr.first.HasDiff()) {
if (field_diff_status.HasDiff()) {
common_field_diff_exists = true;
}
if (diffed_field_ptr.second != nullptr) {
result.diffed_fields.emplace_back(
std::move(*(diffed_field_ptr.second.release())));
if (field_diff_status.IsDirectDiff()) {
result.diffed_fields.emplace_back(common_fields.first,
common_fields.second);
}
}
// Determine DiffStatus.

13
vndk/tools/header-checker/src/repr/abi_diff_helpers.h
View File

@@ -63,9 +63,6 @@ class DiffStatus {
Status status_;
};
template <typename T>
using DiffStatusPair = std::pair<DiffStatus, T>;
struct RecordFieldDiffResult {
DiffStatus status = DiffStatus::kNoDiff;
std::vector<RecordFieldDiffIR> diffed_fields;
@@ -181,12 +178,10 @@ class AbiDiffHelper {
FixupDiffedFieldTypeIds(
const std::vector<RecordFieldDiffIR> &field_diffs);
DiffStatusPair<std::unique_ptr<RecordFieldDiffIR>>
CompareCommonRecordFields(
const RecordFieldIR *old_field,
const RecordFieldIR *new_field,
std::deque<std::string> *type_queue,
IRDiffDumper::DiffKind diff_kind);
DiffStatus CompareCommonRecordFields(const RecordFieldIR *old_field,
const RecordFieldIR *new_field,
std::deque<std::string> *type_queue,
IRDiffDumper::DiffKind diff_kind);
void FilterOutRenamedRecordFields(
std::deque<std::string> *type_queue, DiffMessageIR::DiffKind diff_kind,