LineageOS/android_development
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix rects view (weird triangular shapes)

Browse Source 
Rectangles with property cornerRadius === 0 could result
in weird triangular shapes being drawn instead of rectangles

Fix: b/264541479
Test: follow steps in b/264541479 and check issue is gone
Change-Id: I2421e47cdbf7c932218640f2553647ded676a80d
This commit is contained in:
Kean Mariotti
2023-01-05 16:50:38 +00:00
parent 7ea7bf3815
commit e75ca180ff
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tools/winscope/src/viewers/components/rects/canvas.ts
View File

@@ -253,7 +253,12 @@ export class Canvas {
const height = rect.bottomRight.y - rect.topLeft.y;
const width = rect.bottomRight.x - rect.topLeft.x;
const minEdge = Math.min(height, width);
const cornerRadius = Math.min(rect.cornerRadius, minEdge / 2);
let cornerRadius = Math.min(rect.cornerRadius, minEdge / 2);
// Force radius > 0, because radius === 0 could result in weird triangular shapes
// being drawn instead of rectangles. Seems like quadraticCurveTo() doesn't
// always handle properly the case with radius === 0.
cornerRadius = Math.max(cornerRadius, 0.01);
// Create (rounded) rect shape
return new THREE.Shape()