LineageOS/android_development
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
33,523 Commits 2 Branches 0 Tags
123b01e28f3e6b8ad8712d0edd52dc6b4aa5a587
Commit Graph

33523 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Treehugger Robot
123b01e28f Merge "Fix errorprone warnings that should be errors" am: eb8582344b 
Original change: https://android-review.googlesource.com/c/platform/development/+/2254753

Change-Id: I3ab35338f5e066a20adf163ebbff21d4b6cf0172
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-17 16:38:28 +00:00
Treehugger Robot
eb8582344b Merge "Fix errorprone warnings that should be errors" 2022-10-17 16:03:16 +00:00
Cole Faust
a54b856e8d Fix errorprone warnings that should be errors 
This commit is part of a large scale change to fix errorprone
errors that have been downgraded to warnings in the android
source tree, so that they can be promoted to errors again.
The full list of changes include the following, but not all
will be present in any one individual commit:

BadAnnotationImplementation
BadShiftAmount
BanJNDI
BoxedPrimitiveEquality
ComparableType
ComplexBooleanConstant
CollectionToArraySafeParameter
ConditionalExpressionNumericPromotion
DangerousLiteralNull
DoubleBraceInitialization
DurationFrom
DurationTemporalUnit
EmptyTopLevelDeclaration
EqualsNull
EqualsReference
FormatString
FromTemporalAccessor
GetClassOnAnnotation
GetClassOnClass
HashtableContains
IdentityBinaryExpression
IdentityHashMapBoxing
InstantTemporalUnit
InvalidTimeZoneID
InvalidZoneId
IsInstanceIncompatibleType
JUnitParameterMethodNotFound
LockOnBoxedPrimitive
MathRoundIntLong
MislabeledAndroidString
MisusedDayOfYear
MissingSuperCall
MisusedWeekYear
ModifyingCollectionWithItself
NoCanIgnoreReturnValueOnClasses
NonRuntimeAnnotation
NullableOnContainingClass
NullTernary
OverridesJavaxInjectableMethod
ParcelableCreator
PeriodFrom
PreconditionsInvalidPlaceholder
ProtoBuilderReturnValueIgnored
ProtoFieldNullComparison
RandomModInteger
RectIntersectReturnValueIgnored
ReturnValueIgnored
SelfAssignment
SelfComparison
SelfEquals
SizeGreaterThanOrEqualsZero
StringBuilderInitWithChar
TreeToString
TryFailThrowable
UnnecessaryCheckNotNull
UnusedCollectionModifiedInPlace
XorPower

See https://errorprone.info/bugpatterns for more
information on the checks.

Bug: 253827323
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: Ic7e78cc74523ee09c1b4aa9969756f0cfd609e08
 2022-10-15 21:33:28 -07:00
Christopher Ferris
23d53bfa1b Merge "Remove obsolete script." am: 7fa99882d8 
Original change: https://android-review.googlesource.com/c/platform/development/+/2254765

Change-Id: I4ceafe8fa1b263122e5c652bc2c12162520279eb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-14 19:47:27 +00:00
Christopher Ferris
7fa99882d8 Merge "Remove obsolete script." 2022-10-14 19:03:38 +00:00
Treehugger Robot
c542fcf2a5 Merge "Fix the comparison of opaque types that have multiple definitions" am: 1d2edd2cd2 
Original change: https://android-review.googlesource.com/c/platform/development/+/2252362

Change-Id: I0e5975f5eaf6ee6a118d343ab18270496a0cb889
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-14 09:52:39 +00:00
Treehugger Robot
1d2edd2cd2 Merge "Fix the comparison of opaque types that have multiple definitions" 2022-10-14 09:33:04 +00:00
Hsin-Yi Chen
959646a857 Fix the comparison of opaque types that have multiple definitions 
The types defined in more than one source file are identified with
"#ODR:" and the source paths. The paths can be in intermediate
directories and differ between build targets. They cause ABI check
failure on opaque types. This commit fixes the bug by removing the
suffixes before the comparison.

Test: make libcamera2ndk
Bug: 253095767
Change-Id: I79e6e843460c981afcf2ce0e0d2ad9335d0b3e90
 2022-10-14 14:33:00 +08:00
Christopher Ferris
99d580a123 Remove obsolete script. 
In addition, remove the test for it and the test file.

Test: NA
Change-Id: Ib5124749c523177805f494d9a6daf2400b6fc84c
 2022-10-13 16:38:34 -07:00
Cole Faust
221747c23b Merge "Dist the module-lib and system-server lint databases" am: 0bd20974dd 
Original change: https://android-review.googlesource.com/c/platform/development/+/2242801

Change-Id: Icb5bfec80da41defa1b675caebe058dd4c64fdc6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-12 23:01:02 +00:00
Cole Faust
0bd20974dd Merge "Dist the module-lib and system-server lint databases" 2022-10-12 22:49:06 +00:00
Treehugger Robot
afa1f3d2c4 Merge "Add riscv binary recognition in gdb script" am: 9a0d8d75f0 
Original change: https://android-review.googlesource.com/c/platform/development/+/2251854

Change-Id: I5da716ada782308d3f7dc758a91a0e59c46fb811
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-12 18:38:38 +00:00
Treehugger Robot
9a0d8d75f0 Merge "Add riscv binary recognition in gdb script" 2022-10-12 18:04:03 +00:00
Xia Lifang
8d2ff19bc3 Add riscv binary recognition in gdb script 
Signed-off-by: Xia Lifang <lifang_xia@linux.alibaba.com>
Signed-off-by: Mao Han <han_mao@linux.alibaba.com>
Change-Id: I61793c3c1e32828ac4196a20f85b4fe2832c4992
 2022-10-12 19:36:09 +08:00
Inseob Kim
dfd57730f1 Merge "gdbrunner: Make sure remote lldb-server has +x" am: d9150d3841 
Original change: https://android-review.googlesource.com/c/platform/development/+/2248094

Change-Id: Iffe7ab6637ab4419528fbe33fbc657f8b7c9c12d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-12 02:19:14 +00:00
Inseob Kim
d9150d3841 Merge "gdbrunner: Make sure remote lldb-server has +x" 2022-10-12 01:53:25 +00:00
Inseob Kim
7b29d05387 gdbrunner: Make sure remote lldb-server has +x 
Because 'adb push' often misses the executable permission, lldbserver
can fail without any meaningful error messages. This may happen when the
users are on Windows. To fix that, explicitly chmod remote lldbserver
after push.

Bug: 185210505
Test: manual
Change-Id: I88defd4905a9b902424ae8ef4b38a16932b31f02
 2022-10-12 09:40:14 +09:00
Xin Li
5beb068a13 Merge "Merge tm-qpr-dev-plus-aosp-without-vendor@9129937" into stage-aosp-master 2022-10-11 17:39:20 +00:00
Treehugger Robot
f3cd490aed Merge "Fix the comparison between opaque parameters" am: 1caa406e30 
Original change: https://android-review.googlesource.com/c/platform/development/+/2238125

Change-Id: I73ad577c316b6a8c74c6da6b28a95230037e5ccc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-07 02:40:49 +00:00
Treehugger Robot
1caa406e30 Merge "Fix the comparison between opaque parameters" 2022-10-07 02:07:49 +00:00
Cole Faust
d01c3b26d1 Dist the module-lib and system-server lint databases 
So that they can be downloaded to prebuilts/sdk.

Bug: 193460475
Test: m sdk dist
Change-Id: I0018256221c994b1b7070bab13a45e5067df1c2a
 2022-10-06 13:40:11 -07:00
Xin Li
426708144c Merge tm-qpr-dev-plus-aosp-without-vendor@9129937 
Bug: 248070379
Merged-In: I5a1fd64f9101caa29d87d9f65bd4d17b8bd77059
Change-Id: Ia49878fd6f70239c3ed1f91129719c5ee60066a5
 2022-10-06 11:59:19 -07:00
Hsin-Yi Chen
5cc255dee6 Fix the comparison between opaque parameters 
Function parameters can be opaque and have no size information. For
example, __va_list in AArch64 ABI. header-abi-diff considers opaque
types compatible if their mangled names are the same.

The mangled name of __va_list can be _ZTI9__va_list or _ZTISt9__va_list.
They are also compatible.

Test: ./test.py
Bug: 248418092
Change-Id: I812abcabb620301eb575c54c7e3d2ff63dade488
 2022-10-06 15:46:16 +08:00
Inseob Kim
f4cbf12fa2 Merge "Add overrides support for snapshots" am: f6e13d426b 
Original change: https://android-review.googlesource.com/c/platform/development/+/2238539

Change-Id: I013a576650aeb4138708ff3d145acc052ed6ece7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-06 00:09:53 +00:00
Inseob Kim
f6e13d426b Merge "Add overrides support for snapshots" 2022-10-05 23:43:00 +00:00
Hsin-Yi Chen
5e8fd40e2d Merge "Simplify the error message for ABI check" am: acccadc399 
Original change: https://android-review.googlesource.com/c/platform/development/+/2238114

Change-Id: Ic8d6a65e6231a934428ab5a33c5899734a7956fa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-05 05:35:48 +00:00
Hsin-Yi Chen
acccadc399 Merge "Simplify the error message for ABI check" 2022-10-05 05:13:20 +00:00
Hsin-Yi Chen
2b3d297c0b Merge "Do not allow extending pass-by-value parameters or return types" am: fc212f2a34 
Original change: https://android-review.googlesource.com/c/platform/development/+/2236034

Change-Id: I86802aa767981cd78a31ab2d62fc9fe22cbc8ad0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-05 02:25:43 +00:00
Hsin-Yi Chen
f5f04a5b6c Simplify the error message for ABI check 
- Remove "VNDK" from the message.
- Deprecate -elf-unreferenced-symbol-errors.
- Fix the status string for CompatibilityStatusIR::UnreferencedChanges.

Test: ./test.py
Bug: 249324120
Change-Id: I5a1fd64f9101caa29d87d9f65bd4d17b8bd77059
 2022-10-05 10:13:41 +08:00
Hsin-Yi Chen
fc212f2a34 Merge "Do not allow extending pass-by-value parameters or return types" 2022-10-05 02:03:26 +00:00
Inseob Kim
1c56623fac Add overrides support for snapshots 
Overrides properties will now be captured in json flag files, which will
be copied to installed vendor snapshot modules.

Bug: 216567575
Test: soong test && manual install
Change-Id: I921a19b978b17812e830d15df562d217e4e51f73
 2022-10-04 14:45:06 +09:00
Treehugger Robot
e6b29979c9 Merge "idegen: Migrate try-finally to try-with-resources for Configuration.java" am: f8a1fc304c 
Original change: https://android-review.googlesource.com/c/platform/development/+/2237051

Change-Id: I4b778c7f65621f2882b2dd869a5e2641ff5c3982
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-03 05:23:53 +00:00
Treehugger Robot
f8a1fc304c Merge "idegen: Migrate try-finally to try-with-resources for Configuration.java" 2022-10-03 04:50:00 +00:00
utzcoz
e381c93d13 idegen: Migrate try-finally to try-with-resources for Configuration.java 
Test: run idegen.sh to generate files for IntelliJ without error

Signed-off-by: utzcoz <utzcoz@gmail.com>
Change-Id: If1066d236ef44aff6b9f73a40751ad232a80f6f9
 2022-10-01 10:04:48 +00:00
Treehugger Robot
e49b237676 Merge "idegen: Handle symbolic link that targets to current or parent directory" am: d6c9ae2806 am: e78fac030c am: 517c07c85e am: 7db63833a3 
Original change: https://android-review.googlesource.com/c/platform/development/+/2203929

Change-Id: I64d8affa689a137e448e41e313633a0491e7ad71
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-30 08:09:31 +00:00
Treehugger Robot
7db63833a3 Merge "idegen: Handle symbolic link that targets to current or parent directory" am: d6c9ae2806 am: e78fac030c am: 517c07c85e 
Original change: https://android-review.googlesource.com/c/platform/development/+/2203929

Change-Id: I535eab8d1126466b29e4a2b49baa719e02fa324b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-30 07:43:34 +00:00
Treehugger Robot
517c07c85e Merge "idegen: Handle symbolic link that targets to current or parent directory" am: d6c9ae2806 am: e78fac030c 
Original change: https://android-review.googlesource.com/c/platform/development/+/2203929

Change-Id: I0b80faa79788f972ead85973dc8482e5e81226ff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-30 07:15:02 +00:00
Treehugger Robot
e78fac030c Merge "idegen: Handle symbolic link that targets to current or parent directory" am: d6c9ae2806 
Original change: https://android-review.googlesource.com/c/platform/development/+/2203929

Change-Id: I539afd4eaa4a467e509433109856749c6f82c5bd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-30 06:42:13 +00:00
Treehugger Robot
d6c9ae2806 Merge "idegen: Handle symbolic link that targets to current or parent directory" 2022-09-30 06:23:50 +00:00
Hsin-Yi Chen
183ae5a1d3 Merge "Allow adding class/struct members to padding space" am: 4f2576b93a am: 4384b4cdd0 am: 5c30332ddd am: d8183bf29f 
Original change: https://android-review.googlesource.com/c/platform/development/+/2238294

Change-Id: Ia5cfc34eac90ad157c413cc687a2b7c170b8e033
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-30 04:19:38 +00:00
Hsin-Yi Chen
d8183bf29f Merge "Allow adding class/struct members to padding space" am: 4f2576b93a am: 4384b4cdd0 am: 5c30332ddd 
Original change: https://android-review.googlesource.com/c/platform/development/+/2238294

Change-Id: If0702c9163353438f11ec363e8e048826bc14b19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-30 03:38:08 +00:00
Hsin-Yi Chen
5c30332ddd Merge "Allow adding class/struct members to padding space" am: 4f2576b93a am: 4384b4cdd0 
Original change: https://android-review.googlesource.com/c/platform/development/+/2238294

Change-Id: If7579d9f5ee2a546168db7fffb118a9eba4491c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-30 03:09:31 +00:00
Hsin-Yi Chen
4384b4cdd0 Merge "Allow adding class/struct members to padding space" am: 4f2576b93a 
Original change: https://android-review.googlesource.com/c/platform/development/+/2238294

Change-Id: Ie1af62f6a9d164dcfea2c0ff988357b622b2e6b5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-30 02:36:25 +00:00
Hsin-Yi Chen
4f2576b93a Merge "Allow adding class/struct members to padding space" 2022-09-30 02:09:39 +00:00
Hsin-Yi Chen
9f22a276fd Allow adding class/struct members to padding space 
This commit removes the comparison between class size and member offsets
from RecordTypeDiffIR::IsExtended. New members can be added to padding
space in a class without changing the existing members.

Test: ./test.py
Bug: 248418092
Change-Id: I34d002478f1dcfd3c183e76899917e602de2b4c1
 2022-09-29 19:49:41 +08:00
Hsin-Yi Chen
7f320b10bc Merge "Allow appending members to structs and classes" am: efd3826863 am: f3c5194bf2 am: e0f5ee63db am: 9e14193cfc 
Original change: https://android-review.googlesource.com/c/platform/development/+/2229078

Change-Id: Ia76a8a4177b247622951b0cc9a8f48f8357d7b5c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-28 11:07:32 +00:00
Hsin-Yi Chen
d875d513f2 Do not allow extending pass-by-value parameters or return types 
Resizing the parameters or return types changes the stack layout. It
is not an allowed extension to functions.
AbiDiffHelper::CompareFunctionTypes additionally checks the sizes of the
parameters and the return types. The difference cannot be ignored by
-allow-extensions. The user who intends to ignore the difference should
specify -ignore-symbols or -ignore-linker-set-key.

Test: ./test.py
Bug: 248418092
Change-Id: Ibef3b9260504afff3fc0260b0565736133b8e0dc
 2022-09-28 10:59:51 +00:00
Hsin-Yi Chen
9e14193cfc Merge "Allow appending members to structs and classes" am: efd3826863 am: f3c5194bf2 am: e0f5ee63db 
Original change: https://android-review.googlesource.com/c/platform/development/+/2229078

Change-Id: I68d42cfe2779eee010447a0e0d3c68f346d546ff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-28 10:39:56 +00:00
Hsin-Yi Chen
e0f5ee63db Merge "Allow appending members to structs and classes" am: efd3826863 am: f3c5194bf2 
Original change: https://android-review.googlesource.com/c/platform/development/+/2229078

Change-Id: I79aa03b164dae4374024a1cfb45c0da3a0e9140d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-28 10:11:39 +00:00
Hsin-Yi Chen
f3c5194bf2 Merge "Allow appending members to structs and classes" am: efd3826863 
Original change: https://android-review.googlesource.com/c/platform/development/+/2229078

Change-Id: I86f9478f3177fbb4b0c96e7d4f3c6b91aa64f6c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-28 09:41:08 +00:00