For convenient diff test in post-submit, write a script.
Bug: 138639389
Test: development/vndk/tools/image-diff-tool/compare_images_and_print.sh "-t path1 path2 -s SYSTEM -i"
Change-Id: Ia7e1f7fb7f22bd2a53028e0e65458b7c1adc53bd
1. Rename some variables to more detail
2. Fix a bug that occurs when system.img contains product, system_ext
3. Remove multithread code, it made performance worse :(
before: 136.97s user 1070.22s system 290% cpu 6:55.84 total
after: 56.29s user 76.95s system 105% cpu 2:06.84 total
Bug: 138329983
Test: compare some images, and check if result is same as before
Change-Id: I4cec27475283a34d063ad3251cfc5909c34071c1
These haven't been touched in nearly 10 years, and make assumptions
about the build system that are either no longer true, or will no longer
be true soon.
Test: treehugger
Change-Id: I8bed2f9a7644f559e82b6958a783875089af2c2e
recovery uses its own product id of D001, for adb/sideload/resuce modes.
Bug: 136716811
Test: Install the (unsigned) driver on Windows 7. `adb devices` shows a
device under recovery mode (adb/sideload/rescue).
Change-Id: Ie7526644825c400c9e2b3a9daa9fb93ae8ed00b1
system_product_image_diff -> compare_images
it has more general options, so change its name more general
Bug: 131273025
Test: m
Change-Id: I7579f01edb9f8b8f2fe727b405a592b9c6217eb4
Even though some apps has identical contents(code, resource), they looks
different from each other if signing keys are different.
So, for efficiency, add --ignore_signing_key option in compare tool.
If it is set, sha1sum logic is changed.
As-is: sha1sum apk_file
To-be: add every sha1sum of files that are in apk_file except META-INF,
and then get sha1sum from sha1sums
Bug: 135503972
Test: compare two apk of which code and resource is same but signing key
is diffent.
Change-Id: I2176fdfce5f0fc2181073a1a1183c51dfbfaee49
* changes:
WinScope: Support missing layers
Winscope: Fix how layers with transforms and positions are rendered
WinScope: Modify instead of replacing proto objects
Support SF traces without any layers (needed when booting SF)
Winscope: Translate layer flags in Surface flinger dump
Update `Display default` checkbox label
Add Type to transform objects.
Fix visibility rule for SF traces on Winscope
Allow SF traces to omit default values on the property list
Fix "TypeError: Cannot read property 'x' of null" on SF traces
Display only elements actually visible on the screen as "Visible"
Display SF layer based on size, crop & parent instead of buffer size
WinScope: Support boundless surfaces in WinScope
Winscope: Use a unique stableId for all layers and wm entries
Winscope: keep backwards compatibility prior to windowFrames
This commit changes <dump-files> to be an optional parameter for
header-abi-linker. The linker can generate lsdump files for libraries
without source files.
Test: ./test.py
Test: ./create_reference_dumps.py -products aosp_arm64
Bug: 135728451
Change-Id: Ib9fe56591bd476921904118b1bafcdf2e987f8bb
The new sf layer transform changes breaks when missing layers are added since they do not contain transform
data. Fix this is by adding a transform when creating missing layers.
Also set the transform type when populating transform matrices so they are displayed as IDENTITY.
Test: Open trace from bug
Fixes: 130886882
Merged-In: I85f52bd3dc9174499c4a4840c6b5e80555f28fc7
Change-Id: I85f52bd3dc9174499c4a4840c6b5e80555f28fc7
Currently position is applied to the layer bounds before applying the transform. The bounds
are also not bounded by parent bounds.
Change the logic to use the calculated layer bounds and apply the transform with position when
rendering the layer on screen.
Keep existing logic to view traces before layer bounds were added.
Bug: 128925841
Test: open winscope with old (P) and new trace (Q ToT). Check if layers are rendered correctly when rotated.
Merged-In: Ia91262e4dfe3e8ad647acf8e0cf961e270441cde
Change-Id: Ia91262e4dfe3e8ad647acf8e0cf961e270441cde
Converting the proto object inorder to set the enum string values
or display default values replaces existing proto objects and its
properties which maybe used by the formatter function.
Instead replace toObject method with a custom one that limits
modifications to the existing proto objects.
Test: run WinScope and check WM and SF traces
Merged-In: Ie084d288aaf569476f1e9284c3a9c8a06364a61a
Change-Id: Ie084d288aaf569476f1e9284c3a9c8a06364a61a
When using continuous logging and having the trace enabled by default,
the first entries have no layers and crash Winscope.
Test: Flash a device with SF tracing enabled by default. Record the
initial trace. Open trace in Winscope.
Merged-In: I693815ff3e6468291770d3e8197e21bf75a2a87a
Change-Id: I693815ff3e6468291770d3e8197e21bf75a2a87a
Test: Open sf trace and check if flags are translated
Fixes: 127436444
Merged-In: If696d33054ae566d209b769427f5681d4e1ff876
Change-Id: If696d33054ae566d209b769427f5681d4e1ff876
Replace label for `Show default properties` and add tooltip explaining
what this checkbox is used for
Test: Open winscope
Merged-In: I39de3e1d7c203d5273084bd54c4d2f749e8e6f5f
Change-Id: I39de3e1d7c203d5273084bd54c4d2f749e8e6f5f
Add a type, based on the framework/native definitions, to the transform
objects.
If the transform matrix can be reconstructed from the type (identity,
translate, rotate 0/90/180/270) it should not be stored on the protobuf,
but should instead be reconstructed on Winscope.
Test: Record a Proto3 SF trace. Open it without displaying default
values in Winscope. Check if it is correct. Select a legacy trace. Open
it in Winscope. Check is it is also correct.
Merged-In: I03744efba2c8740d7c543f6793bce0ba7bf6d975
Change-Id: I03744efba2c8740d7c543f6793bce0ba7bf6d975
When traces don't have a visible region object assigned winscope crashes
while loading a SF trace.
Test: Open a SF trace without a visible region object on winscope. It
should no longer crash
Merged-In: I7919a0301ccfb6a0811fd15feb718c8ac0b210b1
Change-Id: I7919a0301ccfb6a0811fd15feb718c8ac0b210b1
The C++ proto2 implementation write the default values ot the file.
Until the surface flinger dump is updated to proto3, this implementation
will not have any effect.
Test: (Un)Check the `display defaults` checkbox. Load a file. If the
checkbox is unchecked, default values should not appear on winscope,
otherwise they should appear.
Merged-In: I2432966f3e14aba5fc1dee26d5a09c743406b417
Change-Id: I2432966f3e14aba5fc1dee26d5a09c743406b417
The protobuf definition allows the position attribute not to be defined.
Winscope crashes if the position is not defined, instead of assuming it
as (x: 0, y: 0)
Test: Load a SF protobuf object without the position attribute. Check if
Winscope does't crash while loading it.
Merged-In: Ib12ba7875f1e7b22819274c1cd9961a1dbfe82cf
Change-Id: Ib12ba7875f1e7b22819274c1cd9961a1dbfe82cf
