Inseob Kim
4e9f55572d
Merge "gdbrunner: Make sure remote lldb-server has +x" am: d9150d3841 am: dfd57730f1
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2248094
Change-Id: I305ed46c8718ed566584f887e555e94865047cc3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-12 02:49:25 +00:00
Inseob Kim
dfd57730f1
Merge "gdbrunner: Make sure remote lldb-server has +x" am: d9150d3841
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2248094
Change-Id: Iffe7ab6637ab4419528fbe33fbc657f8b7c9c12d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-12 02:19:14 +00:00
Inseob Kim
d9150d3841
Merge "gdbrunner: Make sure remote lldb-server has +x"
2022-10-12 01:53:25 +00:00
Inseob Kim
7b29d05387
gdbrunner: Make sure remote lldb-server has +x
...
Because 'adb push' often misses the executable permission, lldbserver
can fail without any meaningful error messages. This may happen when the
users are on Windows. To fix that, explicitly chmod remote lldbserver
after push.
Bug: 185210505
Test: manual
Change-Id: I88defd4905a9b902424ae8ef4b38a16932b31f02
2022-10-12 09:40:14 +09:00
Xin Li
99fa4406f5
[automerger skipped] Merge "Merge tm-qpr-dev-plus-aosp-without-vendor@9129937" into stage-aosp-master am: 5beb068a13 -s ours
...
am skip reason: Merged-In I5a1fd64f9101caa29d87d9f65bd4d17b8bd77059 with SHA-1 f5f04a5b6c is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/development/+/20135618
Change-Id: Idc179c4308eb28645c8517903c2b977555c94daa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-11 17:58:43 +00:00
Xin Li
5b3b548d10
[automerger skipped] Merge tm-qpr-dev-plus-aosp-without-vendor@9129937 am: 426708144c -s ours
...
am skip reason: Merged-In I5a1fd64f9101caa29d87d9f65bd4d17b8bd77059 with SHA-1 f5f04a5b6c is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/development/+/20135618
Change-Id: I47b45c0f54b55217111eeba7b852bf9a186c2b92
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-11 17:55:48 +00:00
Xin Li
5beb068a13
Merge "Merge tm-qpr-dev-plus-aosp-without-vendor@9129937" into stage-aosp-master
2022-10-11 17:39:20 +00:00
Treehugger Robot
7670a1dcad
Merge "Fix the comparison between opaque parameters" am: 1caa406e30 am: f3cd490aed
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2238125
Change-Id: Id11e1fca077417cfdaa15a708c29d3fa7ee94eca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-07 03:09:35 +00:00
Treehugger Robot
f3cd490aed
Merge "Fix the comparison between opaque parameters" am: 1caa406e30
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2238125
Change-Id: I73ad577c316b6a8c74c6da6b28a95230037e5ccc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-07 02:40:49 +00:00
Treehugger Robot
1caa406e30
Merge "Fix the comparison between opaque parameters"
2022-10-07 02:07:49 +00:00
Xin Li
426708144c
Merge tm-qpr-dev-plus-aosp-without-vendor@9129937
...
Bug: 248070379
Merged-In: I5a1fd64f9101caa29d87d9f65bd4d17b8bd77059
Change-Id: Ia49878fd6f70239c3ed1f91129719c5ee60066a5
2022-10-06 11:59:19 -07:00
Hsin-Yi Chen
5cc255dee6
Fix the comparison between opaque parameters
...
Function parameters can be opaque and have no size information. For
example, __va_list in AArch64 ABI. header-abi-diff considers opaque
types compatible if their mangled names are the same.
The mangled name of __va_list can be _ZTI9__va_list or _ZTISt9__va_list.
They are also compatible.
Test: ./test.py
Bug: 248418092
Change-Id: I812abcabb620301eb575c54c7e3d2ff63dade488
2022-10-06 15:46:16 +08:00
Inseob Kim
2af0f8ca99
Merge "Add overrides support for snapshots" am: f6e13d426b am: f4cbf12fa2
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2238539
Change-Id: I57f70bd1c8cc86cdfb9307e6a9dbfbd1011f41e9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-06 00:38:37 +00:00
Inseob Kim
f4cbf12fa2
Merge "Add overrides support for snapshots" am: f6e13d426b
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2238539
Change-Id: I013a576650aeb4138708ff3d145acc052ed6ece7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-06 00:09:53 +00:00
Inseob Kim
f6e13d426b
Merge "Add overrides support for snapshots"
2022-10-05 23:43:00 +00:00
Hsin-Yi Chen
37cf9ae9aa
Merge "Simplify the error message for ABI check" am: acccadc399 am: 5e8fd40e2d am: a6882be48c am: 8d65584c74
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2238114
Change-Id: I9b2f17f5ce88287ea61c297c341106122c79802f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-05 07:16:56 +00:00
Hsin-Yi Chen
8d65584c74
Merge "Simplify the error message for ABI check" am: acccadc399 am: 5e8fd40e2d am: a6882be48c
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2238114
Change-Id: I252f7af0396dd4dad2eeb144529e2500b3c09b14
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-05 06:36:40 +00:00
Hsin-Yi Chen
a6882be48c
Merge "Simplify the error message for ABI check" am: acccadc399 am: 5e8fd40e2d
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2238114
Change-Id: I159b8f7b38d4d4847159fd13f7995bcf3c6c1e9a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-05 06:08:10 +00:00
Hsin-Yi Chen
5e8fd40e2d
Merge "Simplify the error message for ABI check" am: acccadc399
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2238114
Change-Id: Ic8d6a65e6231a934428ab5a33c5899734a7956fa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-05 05:35:48 +00:00
Hsin-Yi Chen
acccadc399
Merge "Simplify the error message for ABI check"
2022-10-05 05:13:20 +00:00
Hsin-Yi Chen
97d0c6f2e3
Merge "Do not allow extending pass-by-value parameters or return types" am: fc212f2a34 am: 2b3d297c0b am: c0f3567f03 am: eeb50f4b0a
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2236034
Change-Id: Ic957a6cecc539ba9c7a41d07a83fe52e6e764254
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-05 03:54:52 +00:00
Hsin-Yi Chen
eeb50f4b0a
Merge "Do not allow extending pass-by-value parameters or return types" am: fc212f2a34 am: 2b3d297c0b am: c0f3567f03
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2236034
Change-Id: Id1812966f9846ad5e6bffe6320a0bb11bff5393f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-05 03:26:32 +00:00
Hsin-Yi Chen
c0f3567f03
Merge "Do not allow extending pass-by-value parameters or return types" am: fc212f2a34 am: 2b3d297c0b
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2236034
Change-Id: I8e81bac3dad077cdcbb204e4103478bd04fb2045
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-05 02:56:12 +00:00
Hsin-Yi Chen
2b3d297c0b
Merge "Do not allow extending pass-by-value parameters or return types" am: fc212f2a34
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2236034
Change-Id: I86802aa767981cd78a31ab2d62fc9fe22cbc8ad0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-05 02:25:43 +00:00
Hsin-Yi Chen
f5f04a5b6c
Simplify the error message for ABI check
...
- Remove "VNDK" from the message.
- Deprecate -elf-unreferenced-symbol-errors.
- Fix the status string for CompatibilityStatusIR::UnreferencedChanges.
Test: ./test.py
Bug: 249324120
Change-Id: I5a1fd64f9101caa29d87d9f65bd4d17b8bd77059
2022-10-05 10:13:41 +08:00
Hsin-Yi Chen
fc212f2a34
Merge "Do not allow extending pass-by-value parameters or return types"
2022-10-05 02:03:26 +00:00
Inseob Kim
1c56623fac
Add overrides support for snapshots
...
Overrides properties will now be captured in json flag files, which will
be copied to installed vendor snapshot modules.
Bug: 216567575
Test: soong test && manual install
Change-Id: I921a19b978b17812e830d15df562d217e4e51f73
2022-10-04 14:45:06 +09:00
Treehugger Robot
c63265f6be
Merge "idegen: Migrate try-finally to try-with-resources for Configuration.java" am: f8a1fc304c am: e6b29979c9 am: 9d969a890e am: 831d03cfb6
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2237051
Change-Id: I2a8fcec65043d549e5bb9e68269b1b5501f3f0d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-03 07:19:48 +00:00
Treehugger Robot
831d03cfb6
Merge "idegen: Migrate try-finally to try-with-resources for Configuration.java" am: f8a1fc304c am: e6b29979c9 am: 9d969a890e
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2237051
Change-Id: I6559e907dcb1298ee6589addbd814d1a0d70fa25
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-03 06:36:42 +00:00
Treehugger Robot
9d969a890e
Merge "idegen: Migrate try-finally to try-with-resources for Configuration.java" am: f8a1fc304c am: e6b29979c9
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2237051
Change-Id: Idf5b11909d77871cd9cdacd2027dfacdfde4275a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-03 06:08:08 +00:00
Treehugger Robot
e6b29979c9
Merge "idegen: Migrate try-finally to try-with-resources for Configuration.java" am: f8a1fc304c
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2237051
Change-Id: I4b778c7f65621f2882b2dd869a5e2641ff5c3982
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-03 05:23:53 +00:00
Treehugger Robot
f8a1fc304c
Merge "idegen: Migrate try-finally to try-with-resources for Configuration.java"
2022-10-03 04:50:00 +00:00
utzcoz
e381c93d13
idegen: Migrate try-finally to try-with-resources for Configuration.java
...
Test: run idegen.sh to generate files for IntelliJ without error
Signed-off-by: utzcoz <utzcoz@gmail.com >
Change-Id: If1066d236ef44aff6b9f73a40751ad232a80f6f9
2022-10-01 10:04:48 +00:00
Treehugger Robot
e49b237676
Merge "idegen: Handle symbolic link that targets to current or parent directory" am: d6c9ae2806 am: e78fac030c am: 517c07c85e am: 7db63833a3
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2203929
Change-Id: I64d8affa689a137e448e41e313633a0491e7ad71
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-30 08:09:31 +00:00
Treehugger Robot
7db63833a3
Merge "idegen: Handle symbolic link that targets to current or parent directory" am: d6c9ae2806 am: e78fac030c am: 517c07c85e
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2203929
Change-Id: I535eab8d1126466b29e4a2b49baa719e02fa324b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-30 07:43:34 +00:00
Treehugger Robot
517c07c85e
Merge "idegen: Handle symbolic link that targets to current or parent directory" am: d6c9ae2806 am: e78fac030c
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2203929
Change-Id: I0b80faa79788f972ead85973dc8482e5e81226ff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-30 07:15:02 +00:00
Treehugger Robot
e78fac030c
Merge "idegen: Handle symbolic link that targets to current or parent directory" am: d6c9ae2806
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2203929
Change-Id: I539afd4eaa4a467e509433109856749c6f82c5bd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-30 06:42:13 +00:00
Treehugger Robot
d6c9ae2806
Merge "idegen: Handle symbolic link that targets to current or parent directory"
2022-09-30 06:23:50 +00:00
Hsin-Yi Chen
183ae5a1d3
Merge "Allow adding class/struct members to padding space" am: 4f2576b93a am: 4384b4cdd0 am: 5c30332ddd am: d8183bf29f
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2238294
Change-Id: Ia5cfc34eac90ad157c413cc687a2b7c170b8e033
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-30 04:19:38 +00:00
Hsin-Yi Chen
d8183bf29f
Merge "Allow adding class/struct members to padding space" am: 4f2576b93a am: 4384b4cdd0 am: 5c30332ddd
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2238294
Change-Id: If0702c9163353438f11ec363e8e048826bc14b19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-30 03:38:08 +00:00
Hsin-Yi Chen
5c30332ddd
Merge "Allow adding class/struct members to padding space" am: 4f2576b93a am: 4384b4cdd0
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2238294
Change-Id: If7579d9f5ee2a546168db7fffb118a9eba4491c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-30 03:09:31 +00:00
Hsin-Yi Chen
4384b4cdd0
Merge "Allow adding class/struct members to padding space" am: 4f2576b93a
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2238294
Change-Id: Ie1af62f6a9d164dcfea2c0ff988357b622b2e6b5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-30 02:36:25 +00:00
Hsin-Yi Chen
4f2576b93a
Merge "Allow adding class/struct members to padding space"
2022-09-30 02:09:39 +00:00
Hsin-Yi Chen
9f22a276fd
Allow adding class/struct members to padding space
...
This commit removes the comparison between class size and member offsets
from RecordTypeDiffIR::IsExtended. New members can be added to padding
space in a class without changing the existing members.
Test: ./test.py
Bug: 248418092
Change-Id: I34d002478f1dcfd3c183e76899917e602de2b4c1
2022-09-29 19:49:41 +08:00
Hsin-Yi Chen
7f320b10bc
Merge "Allow appending members to structs and classes" am: efd3826863 am: f3c5194bf2 am: e0f5ee63db am: 9e14193cfc
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2229078
Change-Id: Ia76a8a4177b247622951b0cc9a8f48f8357d7b5c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-28 11:07:32 +00:00
Hsin-Yi Chen
d875d513f2
Do not allow extending pass-by-value parameters or return types
...
Resizing the parameters or return types changes the stack layout. It
is not an allowed extension to functions.
AbiDiffHelper::CompareFunctionTypes additionally checks the sizes of the
parameters and the return types. The difference cannot be ignored by
-allow-extensions. The user who intends to ignore the difference should
specify -ignore-symbols or -ignore-linker-set-key.
Test: ./test.py
Bug: 248418092
Change-Id: Ibef3b9260504afff3fc0260b0565736133b8e0dc
2022-09-28 10:59:51 +00:00
Hsin-Yi Chen
9e14193cfc
Merge "Allow appending members to structs and classes" am: efd3826863 am: f3c5194bf2 am: e0f5ee63db
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2229078
Change-Id: I68d42cfe2779eee010447a0e0d3c68f346d546ff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-28 10:39:56 +00:00
Hsin-Yi Chen
e0f5ee63db
Merge "Allow appending members to structs and classes" am: efd3826863 am: f3c5194bf2
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2229078
Change-Id: I79aa03b164dae4374024a1cfb45c0da3a0e9140d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-28 10:11:39 +00:00
Hsin-Yi Chen
f3c5194bf2
Merge "Allow appending members to structs and classes" am: efd3826863
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2229078
Change-Id: I86f9478f3177fbb4b0c96e7d4f3c6b91aa64f6c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-28 09:41:08 +00:00
Hsin-Yi Chen
efd3826863
Merge "Allow appending members to structs and classes"
2022-09-28 09:18:15 +00:00