Commit Graph

33115 Commits

Author SHA1 Message Date
Hsin-Yi Chen
4f2576b93a Merge "Allow adding class/struct members to padding space" 2022-09-30 02:09:39 +00:00
Hsin-Yi Chen
9f22a276fd Allow adding class/struct members to padding space
This commit removes the comparison between class size and member offsets
from RecordTypeDiffIR::IsExtended. New members can be added to padding
space in a class without changing the existing members.

Test: ./test.py
Bug: 248418092
Change-Id: I34d002478f1dcfd3c183e76899917e602de2b4c1
2022-09-29 19:49:41 +08:00
Hsin-Yi Chen
efd3826863 Merge "Allow appending members to structs and classes" 2022-09-28 09:18:15 +00:00
Hsin-Yi Chen
e0d81eed8f Merge "Delete VNDK definition tools" 2022-09-28 04:24:25 +00:00
Hsin-Yi Chen
cdf49db15c Allow appending members to structs and classes
This commit adds RecordTypeDiffIR::IsExtended() that determines whether
the difference is a pure extension, i.e., appending members and
increasing the size. The extensions are stored in
record_type_extension_diffs in abi_diff messages. They can be ignored by
specifying -allow-extensions.

Test: ./test.py
Bug: 248418092
Change-Id: Ibdef042c6176dc84d2dd61f71a3f88035e943dd4
2022-09-28 12:18:01 +08:00
Treehugger Robot
a3aa817aa5 Merge "Add FLAG_IMMUTABLE to PendingIntents" 2022-09-24 00:24:30 +00:00
Cole Faust
f4dc2d5f25 Add FLAG_IMMUTABLE to PendingIntents
If your app targets Android 12, you must specify the mutability of each PendingIntent
object that your app creates. This additional requirement improves your app's security.
https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability

Android Lint is being updated, and adds an error-level check for this.

Bug: 247885568
Test: Presubmits
Change-Id: I2bb91d98b443af2b5c16944ce197d863dbd33f9a
2022-09-23 15:17:52 -07:00
Hsin-Yi Chen
adc960d590 Merge "Filter added or removed types by -ignore-linker-set-key" 2022-09-23 03:31:49 +00:00
Hsin-Yi Chen
cc90871286 Merge "Add linker_set_key to RecordTypeDiff and EnumTypeDiff" 2022-09-22 07:00:47 +00:00
Hsin-Yi Chen
37792200d3 Filter added or removed types by -ignore-linker-set-key
Test: development/vndk/tools/header-checker/tests/test.py
Bug: 243903630
Change-Id: I103779591cf8f52f9178d33ad5a205ca4eaaba2f
2022-09-21 09:00:40 +00:00
Hsin-Yi Chen
00d8159166 Add linker_set_key to RecordTypeDiff and EnumTypeDiff
RecordTypeDiff and EnumTypeDiff in abi_diff.proto contain linker set
keys. The developers can copy them to the ignore list. The other Diff
messages do not need the field because it's in the messages imported
from abi_dump.proto.

Test: Update prebuilts/clang-tools; make libz
Bug: 243903630
Change-Id: I1e90d3c6cbfd09d72b3fdb244a4079ae899630aa
2022-09-21 16:50:58 +08:00
Treehugger Robot
16a8d0fa8e Merge "Move SdkSetup app into device/generic/goldfish" 2022-09-20 22:15:01 +00:00
Roman Kiryanov
a60ef1b115 Move SdkSetup app into device/generic/goldfish
this app is designed for emulator

Bug: 247004472
Test: presubmit
Signed-off-by: Roman Kiryanov <rkir@google.com>
Change-Id: I3fa6178d51551bc3540d03827dea17d5abba06c7
2022-09-19 16:33:48 -07:00
Pirama Arumuga Nainar
dafc6d0793 Merge "Update clang-tools build to clang-r458507" 2022-09-19 20:02:41 +00:00
Krzysztof Kosiński
5acfb41d4a Merge "Remove Python enables identical to global defaults." 2022-09-19 16:08:47 +00:00
Pirama Arumuga Nainar
2e6f159eae Update clang-tools build to clang-r458507
Bug: http://b/236798112
Bug: http://b/244486343
Test: presubmit
Change-Id: Icff1712b289925901582f5429bfea3fde1834eec
2022-09-19 05:16:10 +00:00
Krzysztof Kosiński
45c7ebda06 Remove Python enables identical to global defaults.
Bug: 245854393
Test: presubmit
Change-Id: I9bb5cbd972432a26afcb13d7c2a6bbc73fb0991f
2022-09-17 11:33:50 +00:00
Hsin-Yi Chen
f38939ac24 Delete VNDK definition tools
The tools have not been maintained since Android 11.
vndk-lib-extra-list-*.txt are not deleted because VTS depends on them.

Test: make
Bug: 247032590
Change-Id: Iafaf98d13e77edea34a45c84ac44804703aa6d24
2022-09-16 14:37:04 +08:00
Treehugger Robot
01cd913312 Merge "Revert "Revert "Add license metadata to non-module targets.""" 2022-09-14 18:48:30 +00:00
Matthew Maurer
16ed4a3cc3 Merge changes I78bc86ad,Ieeab8376
* changes:
  c2a: Legacy cleanup
  c2a: Parse new cargo output
2022-09-14 14:41:30 +00:00
Treehugger Robot
43ee75e845 Merge "add u option(unbundled build) in build_vendor.sh" 2022-09-13 06:18:53 +00:00
Jeongik Cha
1b1068f52a add u option(unbundled build) in build_vendor.sh
if u option is set, turn on TARGET_BUILD_UNBUNDLED_IMAGE

Bug: 237350883
Test: build_vendor.sh with -u
Change-Id: I9a3ceb22181eb68715f8da597ca4e5e752487c1f
2022-09-13 13:48:26 +09:00
Bob Badour
4964db9772 Revert "Revert "Add license metadata to non-module targets.""
This reverts commit 696b533ad7.

Bug: 240149934

Test: m droid dist

Test: build/soong/soong_ui.bash --make-mode TARGET_PRODUCT=sdk TARGET_BUILD_VARIANT=userdebug sdk dist sdk_repo

Change-Id: I1902bac43ab3a8337b344983df7b72f5f6c7ec76
2022-09-12 19:51:45 -07:00
Treehugger Robot
511583f2b3 Merge "Add comments to ninja_metrics.proto" 2022-09-13 02:31:32 +00:00
Justin Yun
8e0560c601 Add comments to ninja_metrics.proto
Bug: 241033491
Test: na
Change-Id: I421189fbcdd05f5d7b7e20e1a772c23abfd37f1e
2022-09-13 09:57:04 +09:00
Bob Badour
e541ed3b16 Merge "Revert "Add license metadata to non-module targets."" 2022-09-13 00:54:30 +00:00
Bob Badour
696b533ad7 Revert "Add license metadata to non-module targets."
This reverts commit 846c5acd90.

Reason for revert: breaks sdk target on aosp-master

Change-Id: Iea8f2c676533e61a5bea06d17719fea630340b20
2022-09-13 00:52:29 +00:00
Thiébaud Weksteen
0c211bf161 Merge "Remove e2fsdroid and sload_f2fs from platform sdk" 2022-09-12 23:51:31 +00:00
Treehugger Robot
e63705e7ca Merge "Add license metadata to non-module targets." 2022-09-12 21:07:31 +00:00
Treehugger Robot
d3d1bd6bc2 Merge "Remove py2 usages" 2022-09-12 20:57:30 +00:00
Matthew Maurer
b59698e2e9 c2a: Legacy cleanup
* Removed import of print function - we only support py3 now
* Switched from set() to a set literal

Bug: None
Test: Regenerated argh_derive
Change-Id: I78bc86ad22c747c5f6ad88e2caa5e707e1ffc381
2022-09-12 13:03:32 -07:00
Matthew Maurer
ae5da710b3 c2a: Parse new cargo output
Cargo now outputs
'unittests src/lib.rs'
where before it output
'unittests'.

Bug: 246384761
Test: Add "test": true to argh_derive, regenerate, observe same bp file
Change-Id: Ieeab83761f5fe7cff88af1ce8293818736a6bb9b
2022-09-12 12:55:47 -07:00
Cole Faust
d7b3122a24 Remove py2 usages
Bug: 203436762
Test: m nothing
Change-Id: I1ab26c5cfc28032700cb9d5454cbee1b7fd8cbd7
2022-09-12 12:32:22 -07:00
Bob Badour
846c5acd90 Add license metadata to non-module targets.
Bug: 240149934

Test: m droid dist

Change-Id: I2228a9e3b347eb5db97ab776098a563567a5ac2c
2022-09-09 16:54:13 -07:00
Mu-Le Lee
3ccbbe8717 Merge "Update README in header checker for option ignored_linker_set_keys" 2022-09-05 08:13:48 +00:00
Mu-Le Lee
a008152637 Merge "Add option to ignore some specific LinkerSetKeys in header-abi-diff" 2022-09-05 07:37:06 +00:00
Treehugger Robot
9382092804 Merge "Build dist to get build metrics" 2022-09-05 04:24:12 +00:00
Justin Yun
367944f1c5 Build dist to get build metrics
Include dist target to build the build metrics for the vendor inner
tree build.

Bug: 241033491
Test: development/multitree/build_vendor.sh -d vsoc_x86_64 \
      -p cf_x86_64_phone -r out/dist -i %bid%
Change-Id: I7230fe2ee70eefad5e71cec7d5dc710f74f8c503
2022-09-05 12:10:25 +09:00
Treehugger Robot
8e3e3530e8 Merge "Fix module-file name collisions" 2022-09-01 23:36:01 +00:00
Cole Faust
7bc42679aa Fix module-file name collisions
Bazel doesn't allow a module and file with the same name.

Bug: 198619163
Test: Presubmits
Change-Id: I8f143ad512f0d6372e3c75d363ee73f339849a3e
2022-09-01 15:13:34 -07:00
Mu-Le Lee
d93d4de71f Add option to ignore some specific LinkerSetKeys in header-abi-diff
Sometimes developers may want to ignore some incompatible changes in ABI
because it is safe for some reason. An option should be added to
header-abi-diff so it ignores these LinkerSetKeys passed from cli or
config file.

Test: perform abi diff on libz with abi-dump version 33 with the LinkerSetKey _ZTI14internal_stat is specified.
Bug: 243903630
Change-Id: Iccc79d648ae17634a987faac32a2a7cbaa784e5c
2022-09-01 08:08:13 +00:00
Mu-Le Lee
173a9dd208 Update README in header checker for option ignored_linker_set_keys
NDK and platform Libraries are required to ensure the compatibility
across SDK version. However, some changes of a library that break its
ABI compatibility are necessary. Thus a ignored_linker_set_keys option
is added to let developers to skip some symobls.

Test: no need
Bug: 243903630
Change-Id: If6ca665189fdeec7c3e735a0f691dffd180ddc63
2022-08-31 09:08:44 +00:00
Treehugger Robot
17a42834d3 Merge "Skip vndk variants check for vendor builds" 2022-08-31 05:14:38 +00:00
Inseob Kim
05bf9bef07 Skip vndk variants check for vendor builds
Bug: 238270531
Test: manual
Change-Id: Ia30b7203a76ca2f19b5dff9ca0ea003a0c43414d
2022-08-31 11:59:20 +09:00
Treehugger Robot
23862f4296 Merge "Generate ninja_inputs.pb as build metrics" 2022-08-30 01:24:48 +00:00
Justin Yun
f020989c94 Generate ninja_inputs.pb as build metrics
To monitor ninja inputs, generate ninja_inputs.pb as build metrics.
This will count the number of input files and required git projects,
with the number of files for each project.

Bug: 241033491
Test: $ cp .repo/manifests/default.xml out/dist/manifest_1.xml
      $ development/multitree/build_vendor.sh -d vsoc_x86_64 \
          -p cf_x86_64_phone -r out/dist -i 1
Change-Id: Ie185863f1c8fca313baba6135374d509e2d93937
2022-08-29 15:20:12 +09:00
Mu-Le Lee
d8fdf8bc91 Merge "Update README in header checker for header-abi-diff configuration" 2022-08-26 12:59:18 +00:00
Mu-Le Lee
06f41abd76 Update README in header checker for header-abi-diff configuration
Add description of the config format and logic for developer to add
flags to header-abi-diff in Cross-Version ABI Check.

Test: no need
Bug: 239790286
Change-Id: I5b8fbe57aaafd1357495395a416a5d6b51f0ff3f
2022-08-26 11:19:46 +00:00
Treehugger Robot
126ca5f962 Merge changes Ib62b19c1,I80a6ecd8,I37b9aa96,I4de409b3
* changes:
  c2a: Clean-up no-ops with 'pass'
  c2a: Crate: Don't parse -Wclippy, -D, and -W flags
  c2a: Crate: Parse unquoted rustc args
  c2a: Extend unquote() to single quotes
2022-08-25 18:22:08 +00:00
Pierre-Clément Tosi
fd12b5feed c2a: Clean-up no-ops with 'pass'
Bug: 243662244
Test: -
Change-Id: Ib62b19c18da7e3a44c74303a72a9c27f9d8b3315
2022-08-24 17:41:08 +01:00