Treehugger Robot
63c6f707c4
Merge "Update deps for rmtypedefs and mkstubs." am: 99a9d7be5e am: d480253149 am: 4def7525c1
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2287993
Change-Id: I7b340bcd5d29b33de2402947b630edf5e24544c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-05 06:01:12 +00:00
Treehugger Robot
4def7525c1
Merge "Update deps for rmtypedefs and mkstubs." am: 99a9d7be5e am: d480253149
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2287993
Change-Id: Iabbecbfa369f601617b85b4ed7441d2cb0371f8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-05 05:29:13 +00:00
Treehugger Robot
d480253149
Merge "Update deps for rmtypedefs and mkstubs." am: 99a9d7be5e
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2287993
Change-Id: Ie4442d81afeacc375238c8513965cbf508fb164b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-05 04:43:35 +00:00
Treehugger Robot
99a9d7be5e
Merge "Update deps for rmtypedefs and mkstubs."
2022-11-05 03:42:44 +00:00
Krzysztof Kosiński
02fd031e00
Update deps for rmtypedefs and mkstubs.
...
Use Guava built from source and a newer version of asm.
Test: mm
Bug: 244341573
Change-Id: Ic061b6a9b801f1378fafb23e493f1d29c46b06fe
2022-11-04 19:25:41 +00:00
Christopher Ferris
89486bba90
Merge "Fix build id check for libraries." am: 9d99dc95aa am: 842e5cf4f7 am: 63ddab41ad
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2281549
Change-Id: Ia98daee8903950500033050d5b47f9fa710de5b7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-03 20:42:21 +00:00
Kean Mariotti
b5569a88b1
Merge changes I1dee45ba,I05129db8
...
* changes:
Fix viewer screen recording
Fix disappearing labels in SurfaceFlinger rects view
2022-11-03 20:20:34 +00:00
Christopher Ferris
63ddab41ad
Merge "Fix build id check for libraries." am: 9d99dc95aa am: 842e5cf4f7
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2281549
Change-Id: I9659e88d96c0a39687c4f90c8176eb984db16956
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-03 20:10:35 +00:00
Christopher Ferris
842e5cf4f7
Merge "Fix build id check for libraries." am: 9d99dc95aa
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2281549
Change-Id: Ie98e0c0caf0469e5ba1c2015b0b4294a3b408c69
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-03 19:12:19 +00:00
Christopher Ferris
9d99dc95aa
Merge "Fix build id check for libraries."
2022-11-03 18:38:14 +00:00
Elliott Hughes
3354f617a9
Merge "Remove renderscript samples." am: 14f9cec041 am: b240895819 am: 350f649d83
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2282102
Change-Id: I487a614d55c2a5897e0128de4c0b75e883fba74b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-03 17:25:16 +00:00
Elliott Hughes
350f649d83
Merge "Remove renderscript samples." am: 14f9cec041 am: b240895819
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2282102
Change-Id: Ib29dbe71ad602adfc14b38ada6c8d3dc1e334b10
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-03 16:36:25 +00:00
Elliott Hughes
b240895819
Merge "Remove renderscript samples." am: 14f9cec041
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2282102
Change-Id: I63a95ff65f3992bd25fc5e0490ff121e37df2a89
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-03 16:08:40 +00:00
Elliott Hughes
14f9cec041
Merge "Remove renderscript samples."
2022-11-03 15:32:26 +00:00
Kean Mariotti
b5a9158e35
Fix viewer screen recording
...
- Minimized <video> element would still intercept pointer events
- Original area occupied by ViewerScreenRecording component would always intercept
pointer events, even after dragging the element somewhere else.
Test: npm run build:all && npm run test:all
Fix: b/238090772
Change-Id: I1dee45bada91e61c0a80495a9ec8ce16c73cbba7
2022-11-03 14:51:30 +00:00
Kean Mariotti
150a5378f3
Fix disappearing labels in SurfaceFlinger rects view
...
Test: open SF trace, scroll back and forth in time, check that labels don't disappear
Fix: b/254244305
Change-Id: I05129db8f5a7a5ee2dd42d7d685aac1588b8594c
2022-11-03 14:51:27 +00:00
Kean Mariotti
3a78e1fcdd
Merge "Make CollectTracesComponent more responsive"
2022-11-03 14:47:35 +00:00
Cosmin Băieș
46b6825eb0
Merge "Refactor and simplify layouts and css styles"
2022-11-03 14:34:09 +00:00
Cosmin Băieș
649c56ebcd
Refactor and simplify layouts and css styles
...
Test: npm start and check responsiveness to diferent screen sizes
Fix: 254047706
Change-Id: If89ffdf8d7edb9b82ebb392163b74bc650f62cb9
2022-11-03 13:34:54 +01:00
Christopher Ferris
29fcc84e82
Fix build id check for libraries.
...
The current build id check uses the file utility. Unfortunately, it
doesn't work on all systems. Replace with a call to llvm-readelf and
get the bitness and build id using that data.
Other small modifications:
- Only attempt to get the full path for a library once for each library.
- Do not add directories into the symbol libraries.
Test: Unit tests pass.
Test: Running using a libart.so that file doesn't understand and
Test: verifying the line numbers are correct.
Change-Id: I12c3d3c4599d201c3c01feeb48448fee6c633d71
2022-11-02 17:55:57 -07:00
Elliott Hughes
cbb1cbc777
Remove renderscript samples.
...
Renderscript is deprecated and scheduled for removal. Let's start by
removing the easiest part to remove.
Test: treehugger
Change-Id: I5f172497756c3931ccfda742e9c08bde56b362c9
2022-11-02 16:56:36 +00:00
Kean Mariotti
1febe1caa9
Make CollectTracesComponent more responsive
...
Test: collect traces through ADB proxy and check that they are loaded more quickly
Change-Id: Ibecf18b354d702f6b956e24a95dbc9ceaaae9088
2022-11-01 13:57:53 +00:00
Kean Mariotti
32c8f58390
Fix handling of traces with no entries
...
Test: npm run build:unit && npm run test:unit
Change-Id: Ic715711c0f9971b8b6d5dfc7219e6c459e1a421e
2022-11-01 13:46:24 +00:00
Kean Mariotti
81bc9f49db
ParserWindowManagerDump more robust to invalid input
...
ParserWindowManagerDump is prone to accepting invalid inputs because it lacks a magic number check.
This commit reduces changes of accepting invalid inputs by making sure that the parser is actually
able to create a trace entry from the decoded proto.
Test: npm run build:unit && npm run test:unit
Change-Id: I1aad12387ce064cde6e27e09cd6d329bb21f5066
2022-11-01 13:46:24 +00:00
Kean Mariotti
343b2f165c
Fix UI change detection after trace collection
...
CollectTracesComponent used to correctly notify AppComponent through callbacks, but the Angular
change detection was not always triggered (no input change), AppComponent was not updated and the
UI would hang with the message "Loading data..." or would not respond to "Upload new" botton clicks.
This commit solves the issue by manually triggering the Angular change detection through
ChangeDetectorRef#detectChanges().
Fix: b/256602610
Fix: b/256766721
Test: start winscope and collect a trace through ADB proxy
Change-Id: Iddbcc6a29c5d5a502f294b4fc49295dc06c9f00b
2022-11-01 10:09:00 +00:00
Kean Mariotti
a34a33b8e7
Update tabs order
...
Different views (when available) are displayed in tabs with this order:
SF
WM
IME
Transactions
Protolog
Test: open winscope, load traces, check that tab order is correct
Fix: b/254043055
Change-Id: I5b08cc8cdb4c623552f7ad8a1ba693ebfefb4928
2022-10-31 13:39:36 +00:00
Kean Mariotti
a9286726c6
Fix accesses to undefined in IME viewers
...
Fix: b/255741990
Test: npm run build:unit && npm run test:unit
Change-Id: I555397d75b667890fb5c0d27af708db69deb8fe9
2022-10-31 13:24:19 +00:00
Kean Mariotti
d39a88a2c1
Fix log views not fully rendered
...
Fix: b/255966194
Test: npm run build:all && npm run test:all
Change-Id: Icb5c4c6064c6a2f3967ede5f251b337dc26dfec1
2022-10-30 18:31:58 +00:00
Kean Mariotti
5d96d3c955
Add screenrecording viewer
...
This change also needed and includes the refactorings listed below.
Extend viewer's interface to support overlay views:
viewers return a list of views that could have either "tab" or "overlay" type.
Extend TraceViewComponent to render overlay views as well.
Simplify TraceViewComponent's interface for simpler event handling:
receive list of viewers + callback as input instead of entire TraceCoordinator
Test: npm run build:all && npm run test:all
Fix: b/238090772
Change-Id: Iac4c7e66ebe662a76166318d045c2c35e689ef15
2022-10-27 18:16:10 +00:00
Treehugger Robot
d4046b3bad
Merge "Add logcat APIs." am: e6b57e4a05 am: 0d1016edf6 am: 54f47b9510
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2264282
Change-Id: I19f1a442f10a162e6b2648858a29e912ce95ba4a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-24 20:17:50 +00:00
Treehugger Robot
54f47b9510
Merge "Add logcat APIs." am: e6b57e4a05 am: 0d1016edf6
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2264282
Change-Id: I3434777bc19ef9a399db40ca425e2a2e3b967d50
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-24 18:29:13 +00:00
Treehugger Robot
0d1016edf6
Merge "Add logcat APIs." am: e6b57e4a05
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2264282
Change-Id: Ib39571acbcbde6bd59be7c6c7b3040ccd0dbf3c4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-24 17:56:05 +00:00
Treehugger Robot
e6b57e4a05
Merge "Add logcat APIs."
2022-10-24 17:19:27 +00:00
Treehugger Robot
1fec512028
Merge "Add the instructions to resolve ABI difference" am: 7487a0a121 am: d82440d841 am: 26793b8d64
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2262922
Change-Id: Ie0a70c510da29e2540da8d1fc991ea6672509ae6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-24 10:52:44 +00:00
Treehugger Robot
26793b8d64
Merge "Add the instructions to resolve ABI difference" am: 7487a0a121 am: d82440d841
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2262922
Change-Id: I0dca13962e92cec3ce9c648012cadb73fdd36926
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-24 10:20:43 +00:00
Treehugger Robot
d82440d841
Merge "Add the instructions to resolve ABI difference" am: 7487a0a121
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2262922
Change-Id: I8691544de3df7e32c5e0170cd878e919012bec24
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-24 09:53:02 +00:00
Treehugger Robot
7487a0a121
Merge "Add the instructions to resolve ABI difference"
2022-10-24 09:25:25 +00:00
Hsin-Yi Chen
3776a20379
Add the instructions to resolve ABI difference
...
The instructions are organized into a section. The developers who need
to resolve ABI difference can easily find it.
Test: None
Bug: 244520027
Change-Id: I211de0e1f65eece093fe716122753ea795c43b3e
2022-10-24 16:41:14 +08:00
Kean Mariotti
bfb80775a6
Improve rects view code health
...
Fix: b/254244305
Test: npm run test:component
Change-Id: Iac424696b4351dc22c2f802d19aff6d7b029556c
2022-10-21 09:55:15 +00:00
Kean Mariotti
fe3458851f
Improve rects view
...
- Labels have typography consistent with the rest of Winscope
- Fix labels position - get rid of fragile hardcoded x-axis shifts
Fix: b/251785717
Test: run "npm run start", load SF trace, check layers labels
Change-Id: Id32b31f3bf66e4096fedfb3369f6df479f4e0c47
2022-10-21 09:19:18 +00:00
Kean Mariotti
9815ff5c32
Remove blank space in properties view
...
- WindowManager viewer
- IME viewers
Fix: b/254437771
Test: load WM + IME traces in winscope, click on an entry in the hierarchy view, check that there is no blank space in the properties view between controls on top (filter) and the properties (tree) view below
Change-Id: I943433b594e91d4d6323af50087002b42d324d40
2022-10-21 09:19:18 +00:00
Kean Mariotti
5137d1ae45
Fix npm package vulnerability
...
The previous version of terser was volnerable to ReDos attacks.
Test: npm audit
Change-Id: I0ceda6931e68ad4338f7b382bfc6866812315e08
2022-10-21 09:19:18 +00:00
Kean Mariotti
0fa0e6070b
Add prettier
...
Test: npm run prettier
Change-Id: Ie15a2104be13ccf37ca155c334fdd2798bad539f
2022-10-21 09:19:18 +00:00
Kean Mariotti
fd6c1bdf85
Merge "Add viewer Transaction"
2022-10-21 09:18:10 +00:00
Kean Mariotti
81c2db9a67
Add viewer Transaction
...
Fix: 238088678
Test: npm run build:all && npm run test:all
Change-Id: I90ad36a0a18e3b68216ea18d2a47e3ff38d98412
2022-10-21 08:13:54 +00:00
Dan Albert
034e7e2827
Add logcat APIs.
...
Bug: None
Test: Using this in the NDK
Change-Id: I8becab8a0697f2378f1ce472091be497ba13c848
2022-10-20 17:03:10 -07:00
Kean Mariotti
fe5c7132de
Remove obsolete dependencies to legacy transactions proto
...
Fix: b/254653004
Test: yarn build
Change-Id: I864c3c3a6a8524e54e363398f17403db7e81c0a6
2022-10-20 16:39:09 +00:00
Kean Mariotti
00c160c5fd
Merge "Add viewer ProtoLog"
2022-10-20 15:23:52 +00:00
Treehugger Robot
3deceb52e7
Merge "Use gdb-remote without host if not given" am: a063ff34e4 am: d48428a5a9 am: ece1e0406b
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2254565
Change-Id: Icdee637968b93eb7047ad28f85da2f104ecda870
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-19 20:19:09 +00:00
Treehugger Robot
ece1e0406b
Merge "Use gdb-remote without host if not given" am: a063ff34e4 am: d48428a5a9
...
Original change: https://android-review.googlesource.com/c/platform/development/+/2254565
Change-Id: Id92f8272adeaaeba41683019b00210754d54046b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-19 19:47:02 +00:00